[00:17:34] thanks AndyRussG ! [00:17:56] ejegg: thank you! right so what you meant about waiting for Adyen tech to confirm is that most recent e-mail thread, "Am I correct in assuming that there is no problem in always sending browserInfo"? [00:18:04] Yep yep [00:18:22] I'm pretty sure that's the case - I think they assume it will most always be sent [00:18:27] and this is the same: " [00:18:30] For Adyen we can send the extra browserInfo whenever the currency/ [00:18:32] country rule tells us to. If we send it for an unsupported card [00:18:34] type it will just be ignored." [00:18:55] ejegg: what is the urgency level on this? is this something you were hoping we could deploy this evening? [00:19:08] AndyRussG: right. Also, at least for EUR they are requiring 3DS to be supported on all card types [00:19:12] AndyRussG: yes, this evening [00:19:35] but like I said, jgleeson|away's version totally works too and I'm happy to just +2 that [00:20:33] ejegg: this is the other version? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/816858 [00:20:40] conceptually i liked the alternate implementations of canSet... [00:20:55] but I had forgotten that the GlobalCollect one existed when I started [00:21:06] yep, that's the alternate [00:22:17] ejegg: so ok to deploy even without the aforementioned Adyen reply? [00:22:34] AndyRussG: wellll, I /think/ so [00:22:41] lemme read those docs again [00:24:04] ejegg: ok and then what's the reason for deploying this evening? I guess just so that as soon as Adyen confirms, we're ready to turn a campaign back on? [00:24:38] yeah, the donor relations team is seeing a lot of frustrated donors in France [00:24:43] I think the campaign there is still up [00:25:02] hmm, wait, that's just in tests still, right? [00:25:12] maybe it's just emails that are on hold [00:25:21] looking at traffic [00:26:46] ok, so not much traffic since the last bundle test [00:27:00] I guess deploying tomorrow is probably OK too [00:39:32] ejegg: yeah I understood that e-mails have paused and banners are down... but if they've sent e-mails recently those would still be bringing stuff in [00:40:09] what are the potential consequences if the assumption we're waiting to confirm is incorrect? [00:54:25] AndyRussG: in the Ingenico case, people with cards that did not support 3DSecure in the targeted countries would get errors [00:55:04] so we will still be making the additional fields depend on the country/currency configuration be in the 3DSecureCountries config array [00:55:29] or... that's not the exact global name, but there is a config var that controls when we send it [01:24:15] ok thx ejegg [02:21:32] OK, I will hold off till tomorrow. Gonna head to bed [02:24:25] (03CR) 10Ejegg: "This looks good! I played with a different version here: https://gerrit.wikimedia.org/r/816864 making the canSet... call abstract with dif" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816858 (https://phabricator.wikimedia.org/T313756) (owner: 10Jgleeson) [02:26:11] ejegg yeah still trying to get my brain around this... many interruptions since kids here [02:30:46] 10Fundraising-Backlog: 3DS needed on CarteBaincaire in France - https://phabricator.wikimedia.org/T313528 (10Ejegg) @EMartin we have a fix that will start sending the browserInfo for all Adyen card payments in countries/currencies configured for 3DS, without checking the card type. For FR/EUR that should be fine... [02:32:54] AndyRussG: if you want to offer any better suggestions for the fails on this ticket: [02:32:57] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/816830/1#message-0d1042279ed07ef363756d11da6c44c875c87751 [02:33:09] I'd be curious to hear them [02:33:53] ejegg|away: ok sure... 3DS is first tho, right? [02:33:55] Looks like our GatewayChooser refactor ended up putting some MW-only code (the MediaWikiServices->getConfig call) into the codepath that's called from under drupal [02:34:13] AndyRussG: yeah, definitely 3DS is the priority [02:34:23] oki got it [02:34:46] the other thing is just going to mean some more code uglification unless we can think of a better way [02:35:06] my brain hopefully will make it at least as far as being able to say something mildly coherent about the 3DS patches [02:35:41] cool cool. Have a good evening! [02:35:45] thx same! [02:38:59] 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.22; 2022-07-25): Gpay errors - https://phabricator.wikimedia.org/T313333 (10Ejegg) Post-payment MC should now not show up for GPay in UK. Sorry about that! Still troubleshooting Spain disablement with Adyen on email and have not yet looked in to the IL failure. [02:42:03] 10Fundraising-Backlog: Adyen Carte Bancaire transaction log weirdness - https://phabricator.wikimedia.org/T313720 (10Ejegg) For posterity, we figured out the missing payment_submethod was due to the Adyen component not giving us anything in the submit callback where we look for it under both state.data.paymentMe... [02:58:19] (03PS1) 10Wfan: Update SmashPig library and vendor directory [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/816881 [03:05:45] (03CR) 10CI reject: [V: 04-1] Update SmashPig library and vendor directory [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/816881 (owner: 10Wfan) [05:30:05] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10Patch-For-Review: Adyen Carte Bancaire 3D Secure Headers not being set - https://phabricator.wikimedia.org/T313756 (10AndyRussG) Just copying here this e-mail to Adyen from @Ejegg, which helped me understand what's going on here, and what exac... [05:33:10] (03CR) 10AndyRussG: "Looks good! See inline for a few nitpicks..." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) (owner: 10Ejegg) [05:35:08] (03CR) 10AndyRussG: "Looks good, though the approach in Idc6125f4f617 does seem a bit tidier (though also possibly not nit-free... ;) )" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816858 (https://phabricator.wikimedia.org/T313756) (owner: 10Jgleeson) [05:46:30] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10Patch-For-Review: Adyen Carte Bancaire 3D Secure Headers not being set - https://phabricator.wikimedia.org/T313756 (10AndyRussG) Both of the attached patches look like they'd do the job (haven't smoke tested though). The [[ https://gerrit.wiki... [05:48:53] (03CR) 10AndyRussG: 3DS: make canSet abstract, change Adyen implementation (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) (owner: 10Ejegg) [06:04:39] (03CR) 10AndyRussG: 3DS: make canSet abstract, change Adyen implementation (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) (owner: 10Ejegg) [06:30:48] 10Fundraising-Backlog: Recurring set up at Adyen but not in Civi - https://phabricator.wikimedia.org/T313702 (10RKumar_WMF) By email I am searching in Civi. I get the email from Adyen after searching with the PSP reference number provided in the chargeback notification email that I receive. [07:41:52] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10fr-donorservices: iDeal donation flow broken - https://phabricator.wikimedia.org/T313325 (10RKumar_WMF) CID: 56291613 iDeal donation completed without any issues. Thank you page as well as Thank you email received as expected. Transaction show... [12:02:15] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1002:down https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_kafkatee [12:07:15] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1003:down https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_kafkatee [12:08:43] ACKNOWLEDGEMENT - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1003:down Jeff_Green known https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_kafkatee [12:17:15] RECOVERY - check_kafkatee on frban1001 is OK: OK: brokers:9 topics:1 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_kafkatee [12:27:15] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1006:down https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_kafkatee [12:32:15] PROBLEM - check_kafkatee on frban1001 is CRITICAL: CRITICAL: kafka-jumbo1007:down https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_kafkatee [12:42:15] RECOVERY - check_kafkatee on frban1001 is OK: OK: brokers:9 topics:1 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_kafkatee [13:52:52] 10fundraising-tech-ops: Install and configure new host frlog1002 - https://phabricator.wikimedia.org/T312581 (10Jgreen) [14:31:30] (03CR) 10Jgleeson: Remove payment submethod check during Adyen 3DSecure (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816858 (https://phabricator.wikimedia.org/T313756) (owner: 10Jgleeson) [14:52:50] 10fundraising-tech-ops: Install and configure new host frlog1002 - https://phabricator.wikimedia.org/T312581 (10Jgreen) [15:21:00] (03CR) 10Jgleeson: [C: 03+1] "Thanks ejegg. I like this approach more, providing the check across all implementations feels sensible. Albeit the globalcollect update fe" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) (owner: 10Ejegg) [15:30:05] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10fr-donorservices: iDeal donation flow broken - https://phabricator.wikimedia.org/T313325 (10EMartin) @RKumar_WMF Thank you, Rakhi, for overseeing that. Looks like we are good to resume in NL! [15:30:15] (03CR) 10Ejegg: 3DS: make canSet abstract, change Adyen implementation (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) (owner: 10Ejegg) [15:33:01] (03CR) 10AndyRussG: 3DS: make canSet abstract, change Adyen implementation (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) (owner: 10Ejegg) [15:33:31] hi fr-tech! [15:33:41] heyyy ejegg :) [15:35:38] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: Unknown Payment Method cartebancaire_applepay - https://phabricator.wikimedia.org/T313710 (10jgleeson) 05Open→03In progress Looks like this got done in https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/816799. Moving to pending... [15:36:27] howdy ejegg [15:39:51] (03CR) 10AndyRussG: 3DS: make canSet abstract, change Adyen implementation (032 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) (owner: 10Ejegg) [15:50:40] (03PS1) 10Wfan: update venodr and composer.lock for new smashpig version [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/817297 [16:03:08] (03CR) 10Wfan: [C: 03+2] update venodr and composer.lock for new smashpig version [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/817297 (owner: 10Wfan) [16:05:41] hi ejegg [16:05:58] (03CR) 10Wfan: [V: 03+2 C: 03+2] update venodr and composer.lock for new smashpig version [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/817297 (owner: 10Wfan) [16:11:58] hi dami [16:14:25] (03CR) 10CI reject: [V: 04-1] update venodr and composer.lock for new smashpig version [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/817297 (owner: 10Wfan) [16:15:19] (03PS2) 10Ejegg: 3DS: move card type check to Ingenico subclass [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) [16:18:25] (03CR) 10Ejegg: "Thank for the review AndyRussG and jgleeson! While rewriting the canSet method comment I decided it didn't need to be abstract after all." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) (owner: 10Ejegg) [16:20:26] (03CR) 10Ejegg: "...since the base isRecommend method needs those two keys, leaving that check in a base implementation of canSet seemed logical." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) (owner: 10Ejegg) [16:21:05] (03Abandoned) 10Wfan: Update SmashPig library and vendor directory [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/816881 (owner: 10Wfan) [16:22:25] (03CR) 10Ejegg: "I think you will have to add an update to the DonationInterface submodule which contains the updated smash-pig version requirement in its " [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/817297 (owner: 10Wfan) [16:25:42] (03PS2) 10Wfan: update venodr, DI and composer.lock for new smashpig version [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/817297 [16:26:28] (03CR) 10Wfan: [V: 03+2 C: 03+2] update venodr, DI and composer.lock for new smashpig version [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/817297 (owner: 10Wfan) [16:27:09] 10Fundraising-Backlog: Donation shows in Adyen but not in Civi - NL - https://phabricator.wikimedia.org/T313826 (10RKumar_WMF) [16:34:01] (03CR) 10AndyRussG: [C: 03+1] "Thanks much for all this! I like this layout :) Only +1'ing still because:" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) (owner: 10Ejegg) [16:35:59] (03Merged) 10jenkins-bot: update venodr, DI and composer.lock for new smashpig version [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/817297 (owner: 10Wfan) [17:00:33] Hi FRTech. I want to raise this here to avoid a problem down the road as we are about to launch NL. We tested the fix for IDeal which worked well now, however the test transactions aren't making it to Civi.https://phabricator.wikimedia.org/T313826. Might there be a disconnect in picking up output files from Adyen? [17:16:45] emartin: you aren't using %% as a language code, are you? [17:17:04] that's breaking Civi imports right now [17:17:51] https://phabricator.wikimedia.org/T313092 [17:21:46] I'm not using %% . I'm not even sure how I would! ;( Good to know there is a known issue. Explains a few things. [17:23:06] 10Fundraising-Backlog: Donation shows in Adyen but not in Civi - NL - https://phabricator.wikimedia.org/T313826 (10EMartin) @RKumar_WMF Hi Rakhi, Please follow this task concerning this issue. https://phabricator.wikimedia.org/T313092. A known problem is being worked on. [17:23:14] emartin: I think someone had some test links and left %% as a placeholder for 'fill in language code here' but then never replaced it with 'en' or 'nl' or the like [17:23:44] I'm not sure it's related to the iDEAL-not-in-civi but I can check in a little bit [17:24:36] Ah, I see. Not sure of the origin. We've had testers in NL help us out today.....perhaps the culprit? [17:26:31] where are you getting the links to send them? [17:30:24] emartin: ah yep, I'm seeing a couple ideal donations from this morning in the dead-letter bin [17:30:29] with this: "language":"%%isolang%%" [17:30:39] so where are you getting the links to send the testers? [17:31:13] those links must have the bad language code on the URL [17:32:33] so as per that Phab ticket we should be able to handle bad input without crashing the queue consumer [17:33:06] but if want to get good test results we really should be sending valid URLs [17:41:10] (03PS1) 10Jgleeson: WIP: Add Braintree Webhook Signature Validator component [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817315 (https://phabricator.wikimedia.org/T311169) [17:43:46] I was half expecting that Acoustic product update email to be a name change fr-tech :) [17:45:45] (03CR) 10CI reject: [V: 04-1] WIP: Add Braintree Webhook Signature Validator component [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817315 (https://phabricator.wikimedia.org/T311169) (owner: 10Jgleeson) [17:49:00] 10fundraising-tech-ops: Install and configure new host frlog1002 - https://phabricator.wikimedia.org/T312581 (10Jgreen) [18:01:35] 10Fundraising-Backlog: Donation shows in Adyen but not in Civi - NL - https://phabricator.wikimedia.org/T313826 (10Ejegg) @EMartin where are you getting the links to send to testers? [18:03:22] 10Fundraising-Backlog: 3DS needed on CarteBaincaire in France - https://phabricator.wikimedia.org/T313528 (10greg) Reply from Adyen: "Indeed, always sending browserInfo is definitely recommended. And is the default of what merchants are doing. Let me know if you have any questions on this." [18:03:31] 10Fundraising-Backlog: Donation shows in Adyen but not in Civi - NL - https://phabricator.wikimedia.org/T313826 (10Ejegg) There were two failed donations early this morning, both iDEAL donations from folks with wikimedia email addresses and both not imported due to bad language codes. I see that the full code se... [18:04:00] (03PS2) 10Jgleeson: WIP: Add Braintree Webhook Signature Validator component [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817315 (https://phabricator.wikimedia.org/T311169) [18:06:01] wfan: do you mind if I rephrase your ticket? I think the description of the work to do is 'Update PayPal IPN listener to discard donations initiated via Braintree' https://phabricator.wikimedia.org/T313512 [18:06:39] NP thanks for rephrase for this ticket :) [18:08:28] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Braintree-Integration: Update PayPal IPN listener to discard donations initiated via Braintree - https://phabricator.wikimedia.org/T313512 (10Ejegg) [18:26:50] wow. there was debate taking place between the two contenders to be the next prime minister here and the presenter just fainted and collapsed during the question and answers part! [18:27:44] she's ok according to twitter. https://www.bbc.co.uk/news/live/uk-politics-62273292 [18:28:10] pcoombe: did you catch that by any chance? [18:52:21] jgleeson: ejegg: should I smoke test ejegg's latest 3DS patch then? [18:52:34] sure AndyRussG [18:53:22] 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Braintree-Integration: Setup production accounts/access for Braintree - https://phabricator.wikimedia.org/T310100 (10Ejegg) All of fr-tech has user accounts now, and we have access to th... [18:53:23] oki cool! jgleeson did you feel your questions about submethods were answered? [18:53:35] thanks AndyRussG, that would be great! [18:53:44] oki doing that now [18:56:44] AndyRussG: I'll take a look now [18:57:01] thx ! [18:58:50] Hey ejegg! you about for a question realted to the Phab tasks about iDeal/NL? [18:59:12] yep tskaff [18:59:40] Cool, so ... Greg, Noah and I were chatting about this one https://phabricator.wikimedia.org/T313826 [19:00:05] tskaff: where are testers getting their links? [19:00:41] That's what I'm wondering too ... b/c we ran an NL banner pre-test July 6, but we have not yet run any email ... so perhaps from payments? [19:01:06] (or sidebar if these were real donations) [19:01:07] tskaff: payments just passes through the language code that people have on the URL [19:01:13] 10Fundraising-Backlog, 10FR-Braintree-Integration: Braintree: investigate possibility of a clickless JS redirect to PayPal login - https://phabricator.wikimedia.org/T313843 (10AndyRussG) [19:01:19] so who sent those testers the links to payments-wiki? [19:01:29] Sorry I meant the payments team providing a link [19:01:35] ah yeah [19:01:49] I thought maybe from them, that's why I asked emartin on the task [19:02:10] Right ok, b/c I'm not sure there's actually an issue here? [19:02:14] I'm guessing there's a spreadsheet somewhere with bad links in it [19:02:20] and the testers are getting bad links [19:02:22] Ha ok, I'll follow up. [19:02:39] so the donation queue consumer should definitely handle bad input better [19:02:42] (03CR) 10Jgleeson: [C: 03+1] "Latest PS looks good to me. Thanks for answer on the submethod list, I figured as much." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) (owner: 10Ejegg) [19:02:46] but for a test, we should send out realistic URLs [19:02:52] looks good to me AndyRussG [19:02:53] Totally [19:03:17] Thanks! [19:03:21] yw [19:03:24] thx jgleeson [19:15:52] ejegg: jgleeson: fr-tech so now I'm confused about what we should do for Adyen 3Ds [19:15:59] according to this response, "Indeed, always sending browserInfo is definitely recommended." [19:16:57] AndyRussG: So we /could/ send browser fingerprinting always [19:17:00] shouldn't we just remove Adyen3DSecure.php, and just always send those fields for Adyen? [19:17:16] (03PS1) 10Jgleeson: WIP: Create IPN listener for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817357 (https://phabricator.wikimedia.org/T303451) [19:17:18] but I thought it might be nice to minimize it to the situations where they require it [19:17:38] just for a minimal privacy boost [19:17:47] right... so if we did that, 3DS would just be controlled via that console [19:18:04] yeah, we wouldn't have to coordinate console settings with LocalSettings [19:18:14] hmm [19:18:23] ejegg: don't they already have access to that via the JS they're running and background requests etc? [19:18:30] it's not our data, it's just data from the browser [19:18:36] do we have the country/country management in the braintree console that we get with the staging helper checks ejegg & AndyRussG ? [19:19:14] I think the reason they want us to send that info is not so they can have it, but just to check that it coincides with what they're getting, as a security check? [19:19:44] jgleeson: not sure what you mean by "staging helper checks"? [19:20:50] AndyRussG: I guess they do technically have the possibility of fingerprinting via their own JS [19:21:03] do you think they're not [19:21:04] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: This code snippet might be the way to get rid of `WMFTransaction` - https://phabricator.wikimedia.org/T313846 (10Eileenmcnaughton) [19:21:10] oh wow I just had a heart attack [19:21:24] for a moment there I thought I'd pushed up the production keys for braintree https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/817357/1/config/braintree/main.yaml [19:21:28] jgleeson: get the defibrillator! [19:21:47] jgleeson: oh ahhh I thought you meant literally! [19:21:59] lol ejegg [19:22:07] oh gosh those strings yeah, I would have freaked for a moment as well! [19:22:08] I nearly did AndyRussG [19:22:16] phew [19:23:21] jgleeson: K glad it wasn't really that, though!! also, oopss I see what you mean by "staging helper" (sorry I was thinking of the other kind of staging) but still not sure what you mean by the question [19:24:42] AndyRussG: at the moment we have switch on 3DS by country and country via the LocalSettings $mwglobal and I think were now talking about removing the class that does that bit and just injecting the headers for all trxns, effectively removing that control I think? [19:25:02] entirely possible I'm misunderstanding your suggestion also [19:25:23] grr s/have/CAN/ [19:25:24] jgleeson: as far as I understand there is also a switch on the Adyen console? [19:25:32] oh man, country and currency. sorry AndyRussG [19:25:43] AndyRussG and jgleeson yep, I think the adyen console rule is by currency and country too [19:25:53] yeah AndyRussG, i guess my question is "does it give us the same controls" [19:26:00] ah ok then that's good [19:26:07] so we don't really control it, really it's controlled via the console [19:26:09] I haven't seen that bit of the console [19:26:26] I haven't either, for me it's just a rumour that the console has it ;) [19:26:33] ha [19:27:08] still, if all we're doing is coordinating whether or not to send info for coutnries/currencies where it's enabled, but Adyen is just recommending that we always send that info anyway, doing so would remove one level of setup coordination [19:27:11] apparently this magic console also generates the code changes we need, or did until that google engineer blew the lid on it all [19:29:44] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: This code snippet might be the way to get rid of `WMFTransaction` - https://phabricator.wikimedia.org/T313846 (10nshahquinn-wmf) Please forgive the random interjection, but your title gave me amazing "This one weird trick might be the way to get rid of be... [20:02:50] 10Fundraising-Backlog, 10WMIT-CiviCRM: Get imports running in the background - https://phabricator.wikimedia.org/T312166 (10Dwisehaupt) [20:07:23] 10Fundraising-Backlog: Donation shows in Adyen but not in Civi - NL - https://phabricator.wikimedia.org/T313826 (10nisrael) The %%isolang%% is standard code we use in our emails. That triggers the personalization that pulls in the specific contact's native language. I checked the email links and they are coded c... [20:08:31] 10Fundraising Sprint High velocity swallows, 10Fundraising Sprint Incantation optimisation, 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, and 4 others: Convert offline2civicrm to a CiviCRM extension - https://phabricator.wikimedia.org/T270669 (10Dwisehaupt) [20:19:07] 10Fundraising-Backlog, 10fr-donorservices: Adyen donors think they are recurring July 2022 - https://phabricator.wikimedia.org/T313854 (10MBeat33) [20:47:41] (03PS1) 10Ejegg: Horrific shim for MediawikiService::getConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/817380 [20:50:22] (03CR) 10CI reject: [V: 04-1] Horrific shim for MediawikiService::getConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/817380 (owner: 10Ejegg) [21:13:06] lol ejegg that patch name caught my eye [21:17:17] honesty in naming [21:18:31] ye [21:18:33] p [21:19:07] i was just talking to Dana Bredemeyer about why it's hard to explain to stakeholders the value of refatctoring stuff [22:16:59] (03PS2) 10Ejegg: Horrific shim for MediawikiService::getConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/817380 [22:17:04] turd... polished [22:17:40] (03PS3) 10Ejegg: 3DS: move card type check to Ingenico subclass [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) [22:17:55] AndyRussG: ok, I added that extra comment ^^^ [22:18:31] ok thx! [22:23:49] (03CR) 10Wfan: [C: 03+2] Horrific shim for MediawikiService::getConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/817380 (owner: 10Ejegg) [22:36:07] (03Merged) 10jenkins-bot: Horrific shim for MediawikiService::getConfig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/817380 (owner: 10Ejegg) [22:44:43] wfan: so before we tag a new version of donation-interface let's try running those CRM tests with that one fix [22:44:48] let me see [22:45:06] ok [22:45:21] that is, we need to get 'em running locally [22:45:28] (and failing on the current version) [22:48:12] but my docker@civicrm:/srv/civi-sites/wmff$ ./vendor/bin/phpunit --filter testRectify pass with both old and the new update 😅 [22:48:24] very odd... [22:52:09] right, I tried running them unfiltered and it's taking forever. [22:52:14] ok, i'll try filtering them [22:54:09] huh, that file is tagged with @group DonationInterface but it doesn't seem to work [22:57:00] oh derp, wrong file [22:57:13] OK, so wfan try this: ./civicrm-phpunit.sh wmff --group=OrphanSlayer [22:57:21] ok [22:57:39] That gets me the error with the 2.5.7.2 package untouched [22:57:47] now I'll try it with the merged fix [23:01:11] passes! [23:01:16] with this ./civicrm-phpunit.sh wmff --group=OrphanSlayer, I also have 3 tests pass [23:02:03] wfan are you sure you have the 2.5.7.2 package installed in vendor? [23:02:42] you mean the civi vendor di? [23:02:45] so if you grep MediaWikiServices /srv/civi-sites/wmff/vendor/wikimedia/donation-interface/gateway_common/gateway.adapter.php in the container, what do you get? [23:02:55] yep, in the civi container [23:03:33] nothing [23:03:50] so then you've got a different version [23:04:22] you have the change to composer.json to update the requirements, right? [23:04:34] Oh I see, I need to do the same thing as smash-pig for di [23:05:09] then what is the output when you run composer update wikimedia/smash-pig wikimedia/donation-interface [23:05:12] ? [23:06:14] yeah, I update the composer.json, but did not do that to di as I did for smashpig inside vendor, running this composer update now. [23:08:31] ok after update di I have the use MediaWiki\MediaWikiServices; [23:08:31] static::getIdentifier(), $variant, MediaWikiServices::getInstance()->getMainConfig() as grep result [23:08:44] great, so now you have the right version! [23:08:58] so the tests should fail [23:10:32] yeah, you are right! I was following the instruction there https://wikitech.wikimedia.org/wiki/Fundraising/Cluster/Deployments#Deploying_in_Payments-wiki, which we did not have di update, will add to my own notes :) Thanks so much! [23:11:44] :) [23:11:52] ok, so you know the next steps? [23:12:05] ok, then we need to add 2.5.7.3 for the new di you just updated right~ [23:12:54] bingo, make and push the new tag in DI, then update the package, then update your crm patch with the new version number [23:14:09] ok~ [23:33:43] 10Fundraising-Backlog: Donation shows in Adyen but not in Civi - NL - https://phabricator.wikimedia.org/T313826 (10Ejegg) @nisrael So when you send the email via Acoustic, Acoustic will replace %%isolang%% with the donor's language. When you manually copy a link to send to a tester outside of Acoustic, you need... [23:35:21] (03CR) 10AndyRussG: [C: 03+2] "yaaayyyyy works great! thanks everyone for the discussion and for tweaking to get the code just right!! :) :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) (owner: 10Ejegg) [23:37:01] thanks AndyRussG ! [23:37:22] ejegg: thank u :) [23:38:54] (03Merged) 10jenkins-bot: 3DS: move card type check to Ingenico subclass [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816864 (https://phabricator.wikimedia.org/T313756) (owner: 10Ejegg)