[09:24:07] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.21; 2022-07-18): Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10Aklapper) @Pcoombe, @Ejegg: This task has been open and "Unbreak now" for three weeks, w... [14:22:05] (03PS2) 10Cstone: WIP: Add Braintree recurring [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/810394 (https://phabricator.wikimedia.org/T303425) [14:50:21] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.21; 2022-07-18): Bundle test unintended duplicate donations - https://phabricator.wikimedia.org/T310915 (10Pcoombe) 05Open→03Resolved a:03AndyRussG Thanks for the reminder @Aklapper, closin... [15:08:58] (03CR) 10Damilare Adedoyin: [C: 03+2] "Looks good to me, good test coverage and tests ran successfully" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/818242 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [15:10:13] (03Merged) 10jenkins-bot: Regerate recurring token if null for audit and test [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/818242 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [15:35:49] 10Fundraising-Backlog, 10FR-Braintree-Integration, 10Machine-Learning-Team (Active Tasks): add braintree audit parse cron job - https://phabricator.wikimedia.org/T314317 (10AnnWF) [15:38:43] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Braintree-Integration: add braintree audit parse cron job - https://phabricator.wikimedia.org/T314317 (10AnnWF) [15:39:13] Thanks Dami :) Will do the smashpig upgrade for the civi part :) [15:40:49] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10FR-Braintree-Integration: add braintree audit parse cron job - https://phabricator.wikimedia.org/T314317 (10AnnWF) [15:40:51] 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, and 3 others: break down Download and parse Braintree audit files task - https://phabricator.wikimedia.org/T303442 (10AnnWF) [16:03:32] cool, sounds good wfan. I'd be on the look out for the update [16:07:01] Facing some problem with the tag update, last time we have 0.8.3 and not yet deleted... ! [remote rejected] v0.8.3 (prohibited by Gerrit: not permitted: delete) [16:07:01] error: failed to push some refs to 'ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig' do you wanna try to delete it with the cmd `git push --delete origin v0.8.3` ? [16:10:05] let me try [16:13:07] looks like we may not have the delete access [16:13:22] permission* [16:14:30] ejegg: jgleeson: please can you help delete the tag v0.8.3. I had created it for the IPN stuff but looks like we didn't need a tag for that. [16:15:21] sure damilare lemme take a look [16:15:40] thanks [16:16:35] that's deleted [16:17:15] wfan: damilare you should both have permission to delete tags on the repo via this UI I think https://gerrit.wikimedia.org/r/admin/repos/wikimedia%252Ffundraising%252FSmashPig,tags/q/filter:8 [16:17:44] if you see DELETE on the right hand side, it should be good. [16:17:52] good to see, not to press :) [16:18:49] Thanks jgleeson [16:18:59] np [16:19:46] Ohh I see the delete button, guess it's cause we were trying to delete from cli [16:20:02] Jeff_Green: dwisehaupt we've got a nagios email wave [16:20:22] checking. [16:21:35] hmmm... looks like it may be a centralized collector issue vs hosts/services broken. [16:30:37] sorry about the email spam. working with operations to get ncsa restarted which should clear it. [16:33:59] thanks dwisehaupt [16:39:50] some are starting to clear up but there is a backlog of messages getting delivered so we will probably see them trickling in for a bit. sadly. [16:40:23] for instance. i just got one delivered from 30 mins ago. [16:58:15] good thing I mark all those as read with a filter :) [16:59:44] yeah. it's a bit annoying. the central collector sometimes has issues on restarts. even though our checks are clean, they are not collected and thus show as awol: https://phabricator.wikimedia.org/T196336 for history. [17:06:27] jgleeson: the delete from UI is not working for the remote tag, since if you hit update from the packagist, you will still see 8.3, I believe last time Elliott delete the remote tag with the comment `git push --delete origin v0.8.3` before [17:11:33] so the error is like remote: You need 'Delete Reference' rights or 'Push' rights with the [17:11:33] remote: 'Force Push' flag set to delete references. [17:11:33] remote: User: wfan [17:12:02] lemme take a look wfan [17:12:50] Thanks :) [17:16:19] wfan: interesting. it looks like the tag is removed from out gerrit repo but not the github mirror repo, that packagist reads from [17:17:16] oh haha, then dose the mirror repo needs time to get the updates or we need to do the same thing form that ui for mirror repo? [17:17:25] maybeee [17:17:35] I'm sure to be honest [17:18:58] hmm that was meant to say, I'm NOT sure to be honest :) [17:19:14] give it a bit of time. if it doesn't fix itself we'll dig in [17:23:32] Thanks, then maybe we should try to get the 'Delete Reference' right [17:24:19] I feel like in the past that all we've needed to do to clean up unwanted tags but I might be wrong [17:25:13] ejegg: looks like a deleted gerrit repo tag on smashpig hasn't cascaded to the github mirror and is upsetting the apple cart. any ideas? [17:33:35] wfan: if it doesn't fix itself or others jump in, in the next hour, I'll dig in. Sorry I can't be more helpful I'm just trying to finish the braintree stuff I planned on finishing last night until I started watching the England Women's team in the European Cup Final and then I got distracted. [17:40:58] heh. yeah, that was a good game. [17:40:59] Thanks Jack, the tag ui link is helpful, let’s wait to see if the mirror repo get the update in next hrs [17:47:25] wfan or jgleeson: which tag is it? [17:47:47] oh ok, just read backscroll [17:48:16] 8.3 is the one want to delete, and then I have the 8.2.1 as the new one [17:52:51] hmm, it's not showing me any way to delete the tag in the github UI either [17:53:02] let's see if I can push to the github remote [17:56:13] just to follow up on the nagios emails. the resolution process we have used in the past is not working. nothing appears to be failing service wise right now but we are still getting the warnings and emails. [17:57:45] ejegg: thanks, and you did the remote delete from cli last time right [18:09:45] (03PS1) 10Cstone: WIP: Add vaulting for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819127 (https://phabricator.wikimedia.org/T303425) [18:10:11] (03Abandoned) 10Cstone: WIP: Add recurring for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/809048 (https://phabricator.wikimedia.org/T303425) (owner: 10Cstone) [18:16:30] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: 3DS needed on CarteBaincaire in France - https://phabricator.wikimedia.org/T313528 (10EMartin) Note: This is still an issue as we do not know what was causing the CarteBancaire declines on that network. We have rerouted traffic to process on the V... [18:20:44] (03PS2) 10Cstone: WIP: Add vaulting for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819127 (https://phabricator.wikimedia.org/T303425) [18:21:31] (03PS3) 10Cstone: WIP: Add vaulting for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819127 (https://phabricator.wikimedia.org/T303425) [18:23:42] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: 3DS needed on CarteBaincaire in France - https://phabricator.wikimedia.org/T313528 (10greg) p:05Unbreak!→03Medium (Moving priority down to Medium from UBN! until we learn more. Thanks!) [18:25:08] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: 3DS needed on CarteBaincaire in France - https://phabricator.wikimedia.org/T313528 (10jgleeson) hi @EMartin. Thanks for the update. I'm wondering now if we needed to enable 3DS-by-default at all, now that we're processing through Vi/MC. I guess... [18:35:21] 10Fundraising-Backlog: PCI DSS 4.0 requirements - https://phabricator.wikimedia.org/T314329 (10EMartin) [18:37:44] ok, I think that might have worked [18:43:26] Yeah worked, what did you do to make the tag gone? or the mirror branch from github get the gerrit update? [18:43:41] I just did the same as before from the command line [18:43:56] but with the github remote [18:43:57] git push --delete github v0.8.3 [18:44:59] nice ejegg [18:45:45] I was thinking before that when I've run into that, it's possible I deleted the unwanted tag before it synced out to the mirror so maybe that's why I haven't hit that before [18:45:54] wfan it looks like maybe your github user isn't part of the wikimedia github organization [18:46:56] looks like greg-g is an admin of that group - wfan what's your github username? [18:47:11] :) [18:47:28] wikimediaWfan [18:47:31] Thanks :) [18:49:37] ejegg: greg-g please can you add mine too damilare1 [18:49:54] thanks [18:52:38] * greg-g is logging in [18:53:59] alright, both wfan and damilare should be invited to the Fundraising team in the wikimedia github org [18:54:41] you'll probably get an email or some other notification via your github account [18:54:43] thanks greg-g ! [18:54:57] np :) [18:54:58] Thanks greg-g: :) [18:55:07] thanks greg-g [19:12:24] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: 3DS needed on CarteBaincaire in France - https://phabricator.wikimedia.org/T313528 (10EMartin) Hi Jack, 3DS is currently not enabled on VI/MC in France from what I'm seeing in the console, correct? If so, I say we leave it as is. We are seeing h... [19:20:08] hmm there's a disconnect there then [19:20:27] we're basically sending the 3DS headers but it's switched off at the console [19:20:56] which will prevent it from redirecting but feels weird to have the code behaving as if 3DS is enabled [19:24:05] jgleeson: so isn't 3DS enabled in France for Visa and Mastercard too? [19:25:39] (03PS3) 10Jgleeson: WIP: Add Braintree Webhook Signature Validator component [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817315 (https://phabricator.wikimedia.org/T311169) [19:25:41] (03PS2) 10Jgleeson: WIP: Create IPN listener for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817357 (https://phabricator.wikimedia.org/T303451) [19:26:16] (03CR) 10CI reject: [V: 04-1] WIP: Add Braintree Webhook Signature Validator component [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817315 (https://phabricator.wikimedia.org/T311169) (owner: 10Jgleeson) [19:26:17] ejegg: in the code yes but Evelyn has switched it off in the Adyen console [19:27:17] (03CR) 10CI reject: [V: 04-1] WIP: Create IPN listener for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817357 (https://phabricator.wikimedia.org/T303451) (owner: 10Jgleeson) [19:28:16] jgleeson: hmm, that looks like it was skipped on a case-by-case basis [19:28:29] Dynamic3dsActionSkip3ds [19:29:02] so with Dynamic 3ds, Adyen can decide on the fly whether to apply 3ds [19:29:13] depending on amount and maybe other fraud flags [19:29:26] (03PS4) 10Jgleeson: WIP: Add Braintree Webhook Signature Validator component [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817315 (https://phabricator.wikimedia.org/T311169) [19:29:28] (03PS3) 10Jgleeson: WIP: Create IPN listener for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817357 (https://phabricator.wikimedia.org/T303451) [19:30:41] ejegg: I checked over a few in the logs and I couldn't see the 3DS redirect coming back from Adyen [19:30:50] but I was seeing us sending the headers [19:31:06] oh really, none are getting 3ds'ed at all? [19:31:16] So I guess that could explain the auth jump [19:31:23] I didn't check 'em all. there were over a thousand :) [19:31:35] I could write a grep to pipe them in [19:31:37] oops call [19:33:56] looks like 46 hits on the Adyen resultswitcher in the last 19 hrs [19:34:47] from FR donations? [19:35:16] (03PS4) 10Jgleeson: WIP: Create IPN listener for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817357 (https://phabricator.wikimedia.org/T303451) [19:35:40] at least one is FR/EUR/cc (126621350.1) [19:36:36] yup I see that [20:00:15] 10Fundraising-Backlog, 10fr-donorservices: Donation form issues if back button utilized - https://phabricator.wikimedia.org/T313969 (10Ejegg) We should look at the recurring parameter being sent by donatewiki - maybe it's sending a blank / no value for recurring when the donor chooses one-time? Probably it sh... [20:03:08] 10Fundraising-Backlog: Recurring set up at Adyen but not in Civi - https://phabricator.wikimedia.org/T313702 (10XenoRyet) 05Open→03Invalid [20:11:00] 10Fundraising Tech DRI, 10Fundraising-Backlog, 10fr-donorservices: Donation form issues if back button utilized - https://phabricator.wikimedia.org/T313969 (10XenoRyet) [20:11:14] 10Fundraising Tech DRI, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-WMF-Audit: Ingenico audit parser sending already-refunded donations to refund queue - https://phabricator.wikimedia.org/T312824 (10XenoRyet) [20:32:23] PROBLEM - check_puppetrun on frmon2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 4 minutes ago with 1 failures. Failed resources (up to 3 shown): Service[prometheus] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frmon2001&service=check_puppetrun [20:38:13] RECOVERY - check_puppetrun on frmon2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frmon2001&service=check_puppetrun [21:04:07] 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, and 3 others: Update payments-wiki CSP for Braintree scripts - https://phabricator.wikimedia.org/T303490 (10Jgreen) 05Open→03... [21:25:54] 10Fundraising-Backlog: Donation shows in Adyen but not in Civi - NL - https://phabricator.wikimedia.org/T313826 (10Ejegg) @RKumar_WMF manually settled Adyen donations would come in on the next audit file. It looks like they are sending those to us weekly these days, and we got the last one on Jul 29th. So if it'... [21:26:49] hmm, deadlocks [21:27:00] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: Donation shows in Adyen but not in Civi - NL - https://phabricator.wikimedia.org/T313826 (10Ejegg) [21:27:16] yep, there's a big dedupe query going [21:27:20] 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog: Donation shows in Adyen but not in Civi - NL - https://phabricator.wikimedia.org/T313826 (10Ejegg) 05Open→03Resolved a:03Ejegg [21:28:12] by user 'adri' [21:28:42] killed 3 procs [21:28:54] and will requeue the ones that got bumped to damaged table [21:32:21] ejegg: got a question about the desc on this task https://phabricator.wikimedia.org/T303451 [21:34:02] i don't see any notifications in the braintree webhook console that match the ones in the desc. I do see notifications related to 'Local Payments' but I think those are something unrelated. [21:34:42] is that ticket implying that we can get the paypal notifications via the braintree webhook stuff? did you dig into that [21:36:15] ejegg: got a question for tag, I am running git push --delete github v0.8.2.1 [21:36:15] ERROR: Permission to wikimedia/wikimedia-fundraising-SmashPig.git denied to wikimediaWfan. [21:36:15] fatal: Could not read from remote repository. [21:36:15] Please make sure you have the correct access rights [21:36:15] and the repository exists. [21:36:15] my github remote url is git@github.com:wikimedia/wikimedia-fundraising-SmashPig.git [21:41:53] Oh I see, never mind, I should use the wikimediaWfan not wikimedia the folked repo [21:44:38] weird [21:44:52] wfan: did my last message come through? [21:45:27] ah nvm [21:45:30] I see it on the mirror [21:45:38] ? [21:45:58] 22:43 wfan: I don't see v0.8.2.1 locally [21:45:59] 22:43 only v0.8.2 [21:46:01] 22:43 -- irc: disconnected from server [21:46:03] 22:44 --> jgleeson1 (~jgleeson@wikimedia/jgleeson-wmf) has joined #wikimedia-fundraising [21:47:03] oh right, both github and gerrit does not have the 0.8.2.1 [21:47:17] no [21:47:20] I do see it on github [21:47:27] the github moirro [21:47:29] oops [21:47:31] mirror* [21:47:34] I just clone from github, no 0.8.2.1 [21:47:42] ohh maybe cache? [21:48:20] I was using git fetch --all --tags and then git tag to check the current tag [21:48:20] jack@jack-ThinkPad:~/Projects/wiki/fundraising-dev/src/smashpig$ git pull github --tags [21:48:21] From https://github.com/wikimedia/wikimedia-fundraising-SmashPig [21:48:23] * [new branch] deployment -> github/deployment [21:48:25] * [new branch] master -> github/master [21:48:27] * [new tag] 0.8.2.1 -> 0.8.2.1 [21:48:29] * [new tag] lo -> lo [21:48:31] * [new tag] log -> log [21:48:33] I just pulled it in [21:48:38] lemme try and delete it too [21:49:30] what is your remote github url [21:52:13] oops, sorry wfan and jgleeson1 just seeing your questions [21:52:23] looking at the doc question first [21:52:34] I also don't have permissions wfan [21:53:09] wfan: git@github.com:wikimedia/wikimedia-fundraising-SmashPig.git that's my remote url [21:53:32] guess it's just a perms thing [21:56:47] jgleeson1: ok, looking at the docs for braintree webhooks I see most of them are inherently async, that is, they don't have much that would duplicate the synchronous API call responses [21:57:23] so maybe the transaction settled webhook is what we would want to listen for in the case of 'capture confirmation' and refund [21:57:26] https://developer.paypal.com/braintree/docs/reference/general/webhooks/transaction [21:59:20] ohh, but does this mean it's only for bank transfer? [21:59:29] > Transaction webhooks are only available for ACH Transaction: Sale and Transaction: Refund requests. [21:59:36] dang [21:59:36] yeah [21:59:59] ok, those webhooks are looking a lot less useful than i though [22:03:11] oh huh, we might need one to get Venmo donor name + email (rather than just username) https://developer.paypal.com/braintree/articles/guides/payment-methods/venmo#enriched-customer-data [22:03:39] or maybe that's just to get changes in realtime [22:04:50] I guess I'm not clear on what notifications we want [22:05:09] should I make a ticket to capture the job and associated chat needed to determine that [22:05:40] jgleeson1: I was hoping we could get the same type of notifications as we're currently getting from PayPal [22:05:50] that is, confirmations of each payment [22:06:04] plus instant status updates on refunds and chargebacks [22:06:50] I haven't seen anything in the console about paypal notifications and I can't login to the paypal account we've linked to braintree anymore. i think it's tied to you account ejegg [22:06:55] your* [22:07:02] jgleeson1: not only we have no permission to delete tag from github, but for gerrit we do not able to delete tag from cli, while I will ignore this tag deletion test (seems only ejegg: you have the permission to delete the tag, this is not a big deal at this moment so you guys can ignore me), and just use my newly created 8.2.1 to upgrade the civi. [22:07:42] wfan: I feel like gerrit has always blocked CLI tag deletes for me [22:07:47] so I fall back to the UI [22:08:15] my guess is that github repo has also never worked for me [22:08:20] albeit I know it does work for others [22:09:16] yeah ui is working fine, but ui only delete the gerrit not the github, so still needs some access help. maybe we can talk this a bit at tomorrow's tech talk 😄 [22:09:43] ah yeah I agree the github step is still not doable for us ordinary folk [22:10:00] greg-g: any thoughts on our access? [22:10:33] someone switch on the chaos team bat light [22:11:53] hmmm [22:11:56] lemme look [22:12:08] wfan very odd, I am not an org owner on the Wikimedia github org, so I'm not sure how I would have enhanced permissions to the smashpig mirror [22:13:06] Did you use the folked repo as the remote url? [22:13:08] wfan: I don't see you at https://github.com/orgs/wikimedia/teams/fundraising/members Did you accept the invitation? [22:13:44] (or did I invite the wrong person?!) [22:13:47] Ahh i see, it's the team as admin, not the whole org [22:13:54] that link doesn't work for me [22:14:10] Hmm I do not have the invitation email 😂 [22:14:25] jgleeson1: are you signed into a github account that's part of the wikimedia org? [22:14:28] Wfan@wikimedia [22:14:37] .org is my email [22:14:38] wfan: is that a github username? [22:15:06] No wimimedaWfan is my username [22:15:06] (also, sidenote, I don't know the context, why are we using github instead of gerrit here?) [22:15:14] yup greg https://github.com/jackgleeson [22:15:16] that's what I thought... lemme look [22:15:33] greg-g the repo sync doesn't seem to carry over tag deletions [22:15:35] https://github.com/search?q=wimimedaWfan&type=users [22:15:46] I don't see a user by that name? [22:15:46] I'm not part of wmf on github tho [22:15:49] so I was able to push a tag deletion direct to the github mirror, but they aren't [22:16:04] sorry that was meant to be, yep ejegg https://github.com/jackgleeson [22:16:21] jgleeson1: huh, yeah, you're not there either (and casey still is, should probably remove him) [22:16:29] Oh wikimediaWfan 😂 [22:16:42] jgleeson1: ohh you need to be part of the org (and the fundraising subteam) to be able to push to the SmashPig mirror [22:16:54] wfan: bah, I'm blind :P [22:17:49] wfan: alright, invited again, I think you have to accept the invitation somehow [22:18:07] ejegg: I guess I missed that bit off the onboarding :P [22:18:19] Ok thanks, will let u know if I received the email :) [22:18:36] Received now [22:18:37] jgleeson1: invited you too :) [22:19:11] Note: If you get a 404 page, make sure you’re signed in as jackgleeson. [22:19:15] wfan: whew, I think I did something wrong last time, I don't remember seeing this "pending invites" list after I (thought) I invited you initially. [22:19:17] And dami needs that too thanks haha [22:19:19] reassuring note from github [22:19:40] Dami's in there (according to the github team page) now. [22:19:57] and now I see wfan :) [22:20:37] (I guess I'll remove a.wight as well) [22:20:53] I can delete the github tag now! thanks!!!!! [22:21:11] dwisehaupt: do we have a SAL-like thing? I feel like !log'ing these additions/removals from the github team [22:22:05] we could get bd.808 to make us a separate tab on https://sal.toolforge.org/ [22:27:37] 10fundraising-tech-ops: Fundraising access request for lmedley - https://phabricator.wikimedia.org/T314075 (10Dwisehaupt) [22:28:13] 10fundraising-tech-ops: Fundraising access request for lmedley - https://phabricator.wikimedia.org/T314075 (10Dwisehaupt) [22:30:03] you can use !log and put it in the regular SAL. [22:30:28] we don't have our own, but i think it could be useful. i can definitely think of uses for it. [22:32:10] i had no idea there was the possibility of other tabs on the SAL [22:33:25] yup! I can talk to bd808 about it. [22:33:50] * bd808 is summoned from the depths of irc [22:34:26] there is a https://sal.toolforge.org/fr-tech-dev but i'm not sure what that is for [22:35:13] that would go with the https://openstack-browser.toolforge.org/project/fr-tech-dev Cloud VPS project [22:36:08] ah. makes sense. [22:36:29] ah, that's for our proxy so we have a routable URL for testing some things [22:39:00] The main custom SALs that exist today are https://www.mediawiki.org/wiki/Analytics/Server_Admin_Log and https://wikitech.wikimedia.org/wiki/Release_Engineering/SAL. [22:39:56] Stashbot is configured to listen for !log in this channel and treat it like it happened in -operations (add to https://wikitech.wikimedia.org/wiki/Server_Admin_Log and all the related places) [22:40:35] Pointing that somewhere else is not hard to do at all. [22:40:44] (03PS5) 10Jgleeson: WIP: Create IPN listener for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817357 (https://phabricator.wikimedia.org/T303451) [22:43:51] (03CR) 10CI reject: [V: 04-1] WIP: Create IPN listener for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817357 (https://phabricator.wikimedia.org/T303451) (owner: 10Jgleeson) [22:46:22] (03PS1) 10Ejegg: Don't let cache problems stop failmail being sent [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819182 [22:46:46] ejegg: I just pushed up a fix for fundraising-dev [22:46:56] also, should this change break so much on CI? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/817357/4..5 [22:47:24] is there a CI build somewhere that needs updating to accommodate the new jobs queue maybe [22:49:30] bd808: I was about to distract myself from other work starting on a copy/pasta commit for stashbot. :) [22:50:33] greg-g: there is code for the goofiness that we setup for releng, but here it would probably all be untracked config changes. [22:51:06] releng got special stuff for #reasons [22:52:19] The Analytics SAL for example is just a config block [22:55:04] uh oh [22:55:16] [GitHub] Subscribed to 22 wikimedia repositories [22:55:34] You’ll receive notifications for all issues, pull requests, and comments that happen inside the repository. If you would like to stop watching any of these repositories, you can manage your settings here: [22:56:01] time for a github email filter maybe [22:57:46] i've used something like SAL to great effect at previous jobs for different purposes. [22:58:28] in one place we had all the 'machine' things like package updates, deployments, config changes, etc, in one log. and then a separate log that could be date sorted that was a more freeflow 'what i've been working on' log that effectively replaced standups. [22:59:15] more importantly, it served the purpose for the never ending question: what was i working on before i was led down these 3 rabbit holes. [23:09:01] jgleeson1: ahh, that breakage should be fixed quick with an addition to the test yaml file [23:09:39] like this: https://phabricator.wikimedia.org/diffusion/WFSP/browse/master/Tests/data/test_global.yaml$57 [23:20:27] (03CR) 10Ejegg: WIP: Add Braintree recurring (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/810394 (https://phabricator.wikimedia.org/T303425) (owner: 10Cstone) [23:33:12] 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, and 3 others: Create IPN listener for Braintree - https://phabricator.wikimedia.org/T303451 (10jgleeson) To test out receiving Braintree IPNs, y... [23:33:29] (03CR) 10Jgleeson: "Test Instructions here https://phabricator.wikimedia.org/T303451" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817357 (https://phabricator.wikimedia.org/T303451) (owner: 10Jgleeson) [23:33:45] (03CR) 10Jgleeson: "here even https://phabricator.wikimedia.org/T303451#8122006" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817357 (https://phabricator.wikimedia.org/T303451) (owner: 10Jgleeson) [23:34:23] fr-tech, I've added test instructions to help with reviewing the IPN patches here https://phabricator.wikimedia.org/T303451#8122006 [23:35:45] the last PS is failing on CI, possibly needing CI build updates to fix, but don't be put off as everything still works... [23:36:00] jenkins lie! [23:36:16] anyway it's late. bye for now [23:36:21] thanks for making such detailed instructions jgleeson [23:36:33] np cstone bye for now o. [23:36:39] o/* [23:36:56] I'll repost that CI fix on the gerrit ticket [23:38:09] (03CR) 10Ejegg: "CI failures should be fixed by adding stuff to the test yaml file like this:" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817357 (https://phabricator.wikimedia.org/T303451) (owner: 10Jgleeson)