[00:31:11] (03CR) 10Cstone: "Haven't finished testing yet but ending for today so don't want to forget, looks good so far and the Maintenance script works great! just " [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819220 (https://phabricator.wikimedia.org/T307602) (owner: 10Ejegg) [01:25:53] AndyRussG: do you think you will be able to take a look st the (int) cast patch tonight? [01:26:03] oops [01:29:49] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/820175 [01:37:46] (03PS2) 10Ejegg: Break up big function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819775 (https://phabricator.wikimedia.org/T313069) [01:37:48] (03PS3) 10Ejegg: Fix failmail on Adyen unsupported card: Take 2 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819776 (https://phabricator.wikimedia.org/T313069) [01:46:39] ejegg: yep! just almost finished non-work duties for the evening here...... [02:13:26] (03CR) 10Ejegg: [C: 04-1] "Need to just use the string returned from the tokenize function (agreed that it should not include Adyen in the name) rather than looking " [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819220 (https://phabricator.wikimedia.org/T307602) (owner: 10Ejegg) [02:14:54] (03CR) 10Ejegg: [C: 04-1] "Needs to add one more bit of info to the messages" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790417 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [02:23:24] (03PS1) 10Eileen: Improve performance of greeting procssing [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/820258 (https://phabricator.wikimedia.org/T313000) [02:25:26] (03CR) 10CI reject: [V: 04-1] Improve performance of greeting procssing [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/820258 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [02:32:51] 10Fundraising Tech Bug Petting Zoo: Retry cert fetch on Amazon IPN firewall failure - https://phabricator.wikimedia.org/T314552 (10Ejegg) [02:32:59] (03PS1) 10Ejegg: Retry Amazon IPN message validation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/820259 (https://phabricator.wikimedia.org/T314552) [02:33:24] (03CR) 10CI reject: [V: 04-1] Retry Amazon IPN message validation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/820259 (https://phabricator.wikimedia.org/T314552) (owner: 10Ejegg) [02:33:40] (03PS2) 10Ejegg: Retry Amazon IPN message validation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/820259 (https://phabricator.wikimedia.org/T314552) [02:34:05] (03CR) 10CI reject: [V: 04-1] Retry Amazon IPN message validation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/820259 (https://phabricator.wikimedia.org/T314552) (owner: 10Ejegg) [02:36:03] (03Restored) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [02:36:09] (03PS2) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [02:37:36] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [02:39:10] (03PS6) 10Wfan: Fix Get Adyen token [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819220 (https://phabricator.wikimedia.org/T307602) (owner: 10Ejegg) [02:39:36] (03CR) 10CI reject: [V: 04-1] Fix Get Adyen token [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819220 (https://phabricator.wikimedia.org/T307602) (owner: 10Ejegg) [02:39:44] (03PS3) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [02:40:04] (03PS6) 10Wfan: WIP: Need check if transaction number there before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790417 (https://phabricator.wikimedia.org/T307602) [02:40:57] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [02:41:36] (03CR) 10CI reject: [V: 04-1] WIP: Need check if transaction number there before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790417 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [02:43:08] (03PS7) 10Wfan: Fix Get Adyen token [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819220 (https://phabricator.wikimedia.org/T307602) (owner: 10Ejegg) [02:52:07] ejegg: why do we want $recurring to be a number rather than a boolean? [02:53:23] (03PS4) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [02:55:00] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [02:55:18] AndyRussG: because boolean false is discarded by getLocalURL [02:55:43] we could manually add it back on later, but the gateway pages handle 0 and 1 just fine [02:56:00] (03PS5) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [02:56:56] ejegg: ohhh oki that's sneaky of getLocalURL hmmm [02:57:21] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [02:57:42] (03PS6) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [02:58:40] sure is sneaky [02:58:59] not even documented [02:59:08] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [03:00:30] ejegg: what about other random parameters that may passed in as "false" and then that we're not passing through as expected? might there be other bugs there? [03:02:44] (03PS7) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [03:02:47] just wondering if there's a more robust way to handle that that would just take care of all "false" params... or hmmm let me see how we'd pass thorugh other falseness [03:03:07] maybe this only happens with recurring [03:04:05] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [03:04:29] AndyRussG: I think for other params we're pulling them as the string val [03:04:41] we had only been casting recurring to a bool [03:05:01] so getLocalURL /I think/ will pass through string 'false' just fine [03:05:14] but for other bools we care about we mostly get them as 0 or 1 [03:05:18] like opt in [03:06:18] (03PS8) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [03:07:42] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [03:08:14] hmmm [03:09:10] yep, confirmed, passing opt_in=false on the chooser QS gets through to the gateway page URL just fine [03:09:16] (03PS9) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [03:09:25] the problem was introduced with the cast to bool [03:10:41] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [03:14:12] (03PS10) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [03:14:58] ejegg: oki [03:15:01] thx [03:15:29] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [03:15:35] ejegg: what do you think about the current logic in sanitizedValOrNull() ? [03:15:52] (also btw don't let me stop you heading out, I know it's later there...) [03:22:05] AndyRussG: seems OK for our purposes, why? [03:22:23] line 391: [03:22:26] if ( empty( $val ) ) { [03:22:28] return null; [03:22:30] } [03:23:40] heh, fortunately (int)null == 0 [03:23:41] so if it's 0, we cast to null, and then we have to re-cast null to an int? [03:24:07] ejegg: so that's a private function, only used for params that the gateway chooser cares about [03:24:15] and of those, recurring is the only boolean one [03:24:19] yep [03:24:40] let's just move all the param munging logic there, and on the way add a comment explaining this craziness? [03:25:03] seems like that would simplify it? [03:25:08] hmm, but we don't want to turn an absent variant param into variant=0 [03:25:42] (03PS11) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [03:26:23] null is what we want (and will correctly be discarded by getLocalURL) for all the rest [03:26:38] ejegg: right but the empty() check seems wrong generally... not sure why I put that there hehe [03:26:48] and also for any "0" that may be passed in for recurring [03:26:56] looking at legacy, it only does this: [03:27:09] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [03:28:05] or rather, did: [03:28:07] $val = $request->getVal( $paramName, null ); [03:28:10] if ( $val === '' ) { [03:28:11] $val = null; [03:28:13] } [03:28:58] so, following your logic, yes let's not munge anything else that's missing into 0 [03:29:24] OK, but I think we SHOULD munge a non-existing recurring param to 0 [03:29:25] but let's switch sanitizedValOrNull to use the above logic instead of empty() [03:29:50] since a person coming back through the chooser is trying a new donation [03:30:11] and if their new donation has no recurring param that means they don't want it to be recurring [03:30:11] yes correct that bit let's do in getParamsFromURL() [03:30:12] (03PS12) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [03:30:40] so yeah you're right not all the param munging in sanitizedValOrNull [03:30:51] but the empty() check definitely seems to be complicating things [03:31:18] so let's move that back to how legacy worked (again, not sure why I did it differently, apologies) [03:31:31] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [03:32:25] and then we only have to map "true" or "false" to 0 or 1 respectively [03:34:10] so at least getting rid of the // map null to .. section? [03:35:20] (03PS13) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [03:35:57] (03PS4) 10Ejegg: Ensure recurring=false passes through chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820175 (https://phabricator.wikimedia.org/T313969) [03:35:59] (03PS1) 10Ejegg: GatewayChooser: don't nullify false-y strings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820262 [03:36:26] AndyRussG: I'm leaving that section in, but expanded the comment saying why [03:36:53] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [03:37:17] we DO want to add recurring=0 to the gateway URL when the chooser URL has no recurring or recurring='' [03:38:09] ejegg: ahhh right [03:38:40] got it, sorry I think that leftover cheesecake might have eaten my brain [03:39:40] ejegg: so this means that no matter what, the gateway form page will always get a recurring param, correct? [03:39:46] yep yep [03:39:50] oki [03:47:34] (03PS1) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/820263 (https://phabricator.wikimedia.org/T313000) [03:48:54] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/820263 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [03:50:25] (03CR) 10AndyRussG: "Thx!! (see inline)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820175 (https://phabricator.wikimedia.org/T313969) (owner: 10Ejegg) [03:52:53] (03CR) 10AndyRussG: GatewayChooser: don't nullify false-y strings (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820262 (owner: 10Ejegg) [03:54:31] (03PS14) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [03:54:38] (03Abandoned) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/820263 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [03:54:40] (03CR) 10AndyRussG: Ensure recurring=false passes through chooser (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820175 (https://phabricator.wikimedia.org/T313969) (owner: 10Ejegg) [03:55:09] ejegg: thx for waiting up for me on this btw eh :) [03:55:59] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [03:57:09] (03PS5) 10Ejegg: Ensure recurring=false passes through chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820175 (https://phabricator.wikimedia.org/T313969) [03:57:11] (03PS2) 10Ejegg: GatewayChooser: don't nullify false-y strings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820262 [03:57:36] k, let's make sure those tests still pass with the input all stringified [03:58:20] (03PS15) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [03:59:42] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [04:03:07] AndyRussG: looks like it's good to go! I think PS5 addresses all your comments [04:04:53] ejegg: cool beans, looking, thx! [04:05:01] ahhh so many permutations [04:05:51] what if it's just a random string, like recurring=recur [04:09:09] we can deal with that in another patch maybe? [04:09:44] I just want the people waking up to banners tomorrow in bundle countries to be less likely to make unintended recurrings [04:10:12] ejegg: yes sorry just kidding really [04:10:58] K I don't see anything to comment on in the new versions :) I'll just smoke test quickly [04:11:14] ejegg: do you mean to say you think we should deploy this tonite? [04:11:22] that's what I was hoping [04:11:46] was trying to get it out earlier but damilare only felt comfortable giving it C+1 [04:12:00] so it's seeped out of the chaos team containment vessel [04:12:05] (03PS16) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [04:13:17] ejegg: noooo an escaped but mostly domesticated tarantula! [04:13:18] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [04:13:25] oki one sec then [04:13:55] sorry I didn't realize today deploy was the idea [04:14:38] unintended recurrings feel pretty UBN to me [04:15:19] right I just guessed it was quite uncommon [04:15:35] and truthfully didn't think that much about it [04:18:28] (03PS17) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [04:19:47] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [04:23:58] (03CR) 10AndyRussG: [C: 03+2] "Cool thanks for all this!! ;)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820175 (https://phabricator.wikimedia.org/T313969) (owner: 10Ejegg) [04:24:45] (03CR) 10AndyRussG: [C: 03+2] "beautiful :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820262 (owner: 10Ejegg) [04:24:52] ejegg: ^ [04:25:06] 10Fundraising Tech Bug Petting Zoo, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.22; 2022-07-25): Gpay errors - https://phabricator.wikimedia.org/T313333 (10Ejegg) @EMartin settlement is out of our hands. 126797657.2 was caught in the velocity filter. [04:25:59] (03Merged) 10jenkins-bot: Ensure recurring=false passes through chooser [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820175 (https://phabricator.wikimedia.org/T313969) (owner: 10Ejegg) [04:26:20] (03PS18) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [04:26:43] thanks AndyRussG [04:27:13] (03Merged) 10jenkins-bot: GatewayChooser: don't nullify false-y strings [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820262 (owner: 10Ejegg) [04:27:17] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/820264 [04:27:20] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/820264 (owner: 10Ejegg) [04:27:41] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [04:28:29] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/820265 [04:28:31] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/820265 (owner: 10Ejegg) [04:28:39] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/820264 (owner: 10Ejegg) [04:28:48] ejegg: thank u!!!!!!!!!!!!!!! [04:31:45] 10Fundraising Tech Bug Petting Zoo, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.22; 2022-07-25): Gpay errors - https://phabricator.wikimedia.org/T313333 (10Ejegg) OK, the auth-but-not-captured one is also velocity filter [04:35:12] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/820265 (owner: 10Ejegg) [04:38:22] !log payments-wiki upgraded from 712df4ce to 0e4a5b3b [04:38:23] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [04:39:39] woot, that seemed to work! [04:40:01] ejegg: :) :) [04:40:41] no new errors in logs [04:41:02] hmm, maybe we should just shunt client-side errors to a different file tho [04:41:17] also we need a new file for braintree [04:41:27] will ask ops about both tomorrow [04:41:53] anyway... I tihnk I'll tag the 'db is read-only' as DRI team [04:42:14] PROBLEM - check_procs on frdb2003 is CRITICAL: PROCS CRITICAL: 2097 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [04:42:48] 10Fundraising Tech Bug Petting Zoo, 10Fundraising-Backlog, 10FR-Alerts: Lots of DBReadOnlyError cluttering up payments-wiki error logs - https://phabricator.wikimedia.org/T308162 (10Ejegg) [04:46:11] OK, I tried a bunch of different recurring params on prod and it's all working as expected [04:46:25] I feel like I can probably rest easy [04:48:26] 10Fundraising Tech Bug Petting Zoo, 10Fundraising-Backlog, 10fr-donorservices: Donation form issues if back button utilized - https://phabricator.wikimedia.org/T313969 (10Ejegg) 05Open→03Resolved a:03Ejegg @Pcoombe We deployed a fix for this and it seems to be working as expected. Thanks for your excel... [04:52:12] RECOVERY - check_procs on frdb2003 is OK: PROCS OK: 1432 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [04:53:48] ejegg: fantasmic, thx so so much :) [04:53:53] the zoo is happy [08:22:29] (03PS19) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) [08:23:48] (03CR) 10CI reject: [V: 04-1] Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [09:19:11] (03PS1) 10Eileen: Test fast-cache improvement [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/820387 [09:20:45] (03CR) 10CI reject: [V: 04-1] Test fast-cache improvement [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/820387 (owner: 10Eileen) [09:34:21] (03PS1) 10Eileen: Test fast-cache - use more [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/820394 [09:48:48] (03CR) 10CI reject: [V: 04-1] Fix another cache miss [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/820400 (owner: 10Eileen) [09:51:34] (03PS1) 10Eileen: Another cache [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/820403 [09:53:23] (03CR) 10CI reject: [V: 04-1] Another cache [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/820403 (owner: 10Eileen) [13:25:53] (03PS1) 10Damilare Adedoyin: Add missing supported countries in Paypal present in Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820447 (https://phabricator.wikimedia.org/T314500) [13:30:51] I'm curious damilare, where's MF? [13:31:17] Saint Martin [13:31:36] https://www.iso.org/obp/ui/#iso:code:3166:MF [13:31:45] ah nice [14:39:46] (03CR) 10Jgleeson: "The code looks good, and the solution makes sense. However, I can't see any easy way to test this code, have you managed to smoke test it?" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/820259 (https://phabricator.wikimedia.org/T314552) (owner: 10Ejegg) [14:45:58] (03CR) 10Jgleeson: [C: 03+2] "Nice spot!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820447 (https://phabricator.wikimedia.org/T314500) (owner: 10Damilare Adedoyin) [14:52:20] (03Merged) 10jenkins-bot: Add missing supported countries in Paypal present in Braintree [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820447 (https://phabricator.wikimedia.org/T314500) (owner: 10Damilare Adedoyin) [14:52:29] thanks jgleeson [14:54:53] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/820466 [15:00:09] np! thank you! [15:06:54] ut-oh XenoRyet, there's a new Xeno in the foundation [15:10:14] (03CR) 10Damilare Adedoyin: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/820466 (owner: 10Damilare Adedoyin) [15:11:40] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/820466 (owner: 10Damilare Adedoyin) [15:12:04] 10Fundraising-Backlog, 10fr-donorservices: Adyen donors think they are recurring July 2022 - https://phabricator.wikimedia.org/T313854 (10greg) >>! In T313854#8129436, @greg wrote: > There is one option question (from around 7:20) if the "card on file" option will display differently to our donors than the "su... [15:16:16] (03PS1) 10Damilare Adedoyin: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/820470 [15:16:58] (03PS2) 10Damilare Adedoyin: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/820470 [15:18:50] (03PS7) 10Wfan: WIP: Need check if transaction number there before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790417 (https://phabricator.wikimedia.org/T307602) [15:20:41] (03Abandoned) 10Wfan: WIP: Need check if transaction number there before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/790417 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [15:28:30] (03PS1) 10Wfan: Check if recurring donation need to re get token before before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820472 (https://phabricator.wikimedia.org/T307602) [15:29:46] (03CR) 10Damilare Adedoyin: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/820470 (owner: 10Damilare Adedoyin) [15:30:59] (03CR) 10CI reject: [V: 04-1] Check if recurring donation need to re get token before before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820472 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [15:39:23] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/820470 (owner: 10Damilare Adedoyin) [15:43:18] !log payments-wiki upgraded from 0e4a5b3b to 6880236d [15:43:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:46:34] (03CR) 10Jgleeson: "This is a nice refactor splitting out one big method into smaller ones." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819775 (https://phabricator.wikimedia.org/T313069) (owner: 10Ejegg) [15:50:16] cstone: I started reviewing your braintree recurring stuff and realised it might be a good one to go over on a call so we could run one through end-to-end and I could ask questions about the smashpig bit [15:50:33] sure jgleeson [15:51:22] jgleeson: I just did that refactor with the IDE 'extract method' so all the code paths should be identical to the originals [15:52:01] I will fix that method name [15:52:55] I don't trust the IDE enough to +2 it without testing ejegg [15:53:11] PHPStorm crashes quite a bit [15:53:50] (flippant comment) [15:54:05] (03PS3) 10Ejegg: Break up big function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819775 (https://phabricator.wikimedia.org/T313069) [15:54:07] (03PS4) 10Ejegg: Fix failmail on Adyen unsupported card: Take 2 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819776 (https://phabricator.wikimedia.org/T313069) [15:54:55] so let's see, I don't think we have a way to create the old-style recurrings any more [15:55:50] I guess you could create two new-style recurrings and then delete the contribution_recur. invoice_id from one of them [15:56:25] (03CR) 10Jgleeson: Break up big function (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819775 (https://phabricator.wikimedia.org/T313069) (owner: 10Ejegg) [15:59:39] (03PS3) 10Wfan: Retry Amazon IPN message validation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/820259 (https://phabricator.wikimedia.org/T314552) (owner: 10Ejegg) [16:01:03] (03CR) 10Jgleeson: Break up big function (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819775 (https://phabricator.wikimedia.org/T313069) (owner: 10Ejegg) [16:01:38] ejegg: and then process those from the civicrm smashpib ext? [16:01:42] smashpig* [16:02:33] old style as like from the ipns? [16:05:27] would we ever be calling that code again? [16:10:59] ejegg: now I know who Wayne Kramer is... and that the email in that test is not real (I think!) [16:22:51] cstone: I dont know enough about things to answers those [16:23:01] if they were general questions [16:23:58] just looking at it i dont think wed ever call that createRecurringPaymentFromToken again? [16:28:54] (03CR) 10Jgleeson: [C: 03+2] "This looks great. Good tidy up (those cc strings are huge) and two good tests." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819776 (https://phabricator.wikimedia.org/T313069) (owner: 10Ejegg) [16:30:25] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] "Always good to keep dev in sync. LGTM" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/812920 (https://phabricator.wikimedia.org/T312155) (owner: 10Ejegg) [16:31:55] (03CR) 10Jgleeson: [C: 03+2] "Ah this explains the issue I was seeing locally last week. LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819182 (owner: 10Ejegg) [16:32:25] (03CR) 10Ejegg: Break up big function (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819775 (https://phabricator.wikimedia.org/T313069) (owner: 10Ejegg) [16:33:13] (03Merged) 10jenkins-bot: Don't let cache problems stop failmail being sent [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819182 (owner: 10Ejegg) [17:00:26] 10Fundraising Sprint NaN is a Number, 10fundraising-tech-ops, 10FR-Braintree-Integration: Add the Braintree audit dirs to production via puppet - https://phabricator.wikimedia.org/T314521 (10AnnWF) >>! In T314521#8129902, @Dwisehaupt wrote: > I have added in the braintree audit dirs to config. There is still... [17:06:08] 10fundraising-tech-ops: Fundraising access request for lmedley - https://phabricator.wikimedia.org/T314075 (10LMedley-WMF) Greetings Dallas, Hope your day is going well! I kindly tried to configure the Yubikey and may have found the public side of the key. Please confirm if this information is the correct info... [17:10:07] wfan: when looking for the audit dir location, i realized there must be something that i missed. the archive directories are present, but it didn't create the symlinks and such. [17:10:26] i'll see if i can get that fixed before i depart today. [17:11:12] Thanks Dalla :P [17:11:19] Dallas~ :) [17:11:57] go Giants!!! dwisehaupt :) [17:14:55] we don't have baseball over here and I've often thought about attending a baseball and even basketball game when I'm in the US at some point in the future to have that experience [17:15:16] if you go to baseball jgleeson make sure your seat isnt in the sun [17:15:48] looks like there's a video for that https://www.youtube.com/watch?v=O4ONveWPsyw - Taking a Brit to a Baseball Game [17:16:04] ah ok cstone, is that because you can't see anything? [17:16:26] haha just my one rockies game no I cooked and nothing was happening :P [17:19:16] ha! on that video cstone they're also recommending that you don't sit in the sun [17:20:40] baseball is essentially cricket. you hang out it in the sun for an afternoon and drink and chat. [17:21:10] it's less about the game and more about the experience. [17:22:46] ahh ok. in my head I was thinking of the game 'rounders' at scale but the cricket comparison works better [17:22:58] cricket is a hard one to stick with ha [17:25:15] hah the rockies are in the video jgleeson [17:27:27] haha [17:27:41] it looks cool. good crowd participation [17:27:57] ive never had the team i went to see ever win in any large sporting event haha [17:28:34] yeah I'm an Everton fan. I know the feeling [17:29:57] mainly hockey games though [17:30:34] fr-tech is this list still valid? If so is there a place we can put it so it's more prominent as we work https://www.mediawiki.org/wiki/Fundraising_tech/Definition_of_Done [17:30:51] i think probably move it over to team processes? [17:31:10] ^ that sounds right to me as well. [17:31:20] 10Fundraising Sprint NaN is a Number, 10fundraising-tech-ops, 10FR-Braintree-Integration: Add the Braintree audit dirs to production via puppet - https://phabricator.wikimedia.org/T314521 (10Dwisehaupt) In digging in to get the locations, I found some inconsistencies with how the audit directories are tracke... [17:31:39] cstone: could you link me to the team processes pls and I'll move it [17:32:16] you'd have to make it but here https://wikitech.wikimedia.org/wiki/Fundraising/Team_processes/Definition_of_Done [17:34:27] ahh thaks [17:34:29] thanks* [17:35:01] just gonna grab some food and then will do that first [17:42:58] 10fundraising-tech-ops: Fundraising access request for lmedley - https://phabricator.wikimedia.org/T314075 (10Dwisehaupt) [18:33:06] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Make it impossible for people to send us their credit card number - https://phabricator.wikimedia.org/T133937 (10Jgreen) [18:48:31] thanks for the review, jgleeson|dinner ! [18:50:48] so damilare I was thinking I could look at those DBReadOnly errors [18:50:56] and try to understand where they are coming from [18:51:07] sounds good ejegg [18:58:51] jgleeson|dinner: I think we can use the TestAdyenRecurring maintenance script to try those code paths [18:59:03] I just need to make one little thing conditional [19:02:22] can [19:07:53] huh cstone I can find some old-style recurrings in the test console but I can't seem to remember how to charge them [19:08:42] so for adyen test txn 883595901771147G , it has a shopper reference of 2100000011.6 [19:09:44] but trying anything from 2100000011.1 to 2100000011.6 as the token via the old SOAP auth call gets me 800 Contract not found [19:10:00] I wish I could remember how to find the right shopper reference [19:10:31] oh, maybe it's this: 8415959017722174 [19:10:49] hmm, nope [19:13:57] Hmmm I don't remember either did we switch all old style over I vaguely remember something like that [19:16:04] fr-tech folks, is there a reason for the alphabetical ordering alongside the numeric on our docs? https://wikitech.wikimedia.org/wiki/Fundraising#G_How_we_work_(Team_Processes) [19:16:41] cstone I know we switched over all the prod ones but I don't think we did it for all the test ones [19:16:54] oh well [19:17:16] hey jgleeson yeah that came from the numbers here https://www.mediawiki.org/wiki/Fundraising_tech/notes/Draft:Documentation_overhaul#Outline [19:17:23] though I think it could be removed [19:17:39] (and also that start page much fixed up, it's been just an iterative process) [19:18:47] ah cool thanks [19:18:51] jgleeson: AndyRussG it's a combo of the first and second drafts too if some don't match [19:19:02] I think we were renaming the endpoints to something else right? [19:19:08] systems or something like that [19:19:17] hhh hmmm [19:19:27] internal endpoints [19:19:28] jgleeson: yeah the "cannonical" version with the stuff we decided is here: https://www.mediawiki.org/wiki/Fundraising_tech/notes/Draft:Documentation_overhaul#Outline [19:19:42] I remember we voted on an etherpad somewhere [19:19:42] "facing" [19:19:47] yep yep [19:19:58] though indeed some pages have mixed and matched versions too [19:20:10] that's one detail I've been meaning to suggest we clean up [19:21:05] thanks [19:22:04] thank u :) [19:22:51] so I can see https://wikitech.wikimedia.org/wiki/Fundraising/Team_processes [19:23:16] bit then I don't think that links in with the stuff here https://wikitech.wikimedia.org/wiki/Fundraising#G_How_we_work_(Team_Processes) [19:23:42] did we import stuff over and then start linking things afterwards? [19:23:49] sorry I've not written much on the new docs [19:23:55] jgleeson I found an old-style recurring that seems to work! [19:24:49] oh hmm [19:24:51] almost [19:24:53] php PaymentProviders/Adyen/Maintenance/TestAdyenRecurring.php --token=48990868.3 --amount=2 --currency=EUR [19:25:10] can I run that at my end? [19:25:22] jgleeson I think so [19:25:29] I'll give it a whirl [19:26:00] but it's outputting that it failed when the "resultCode":"Received" [19:26:10] so I think it should have actually succeeded [19:26:33] I'm 99% sure you'll get the same output with or without that method extraction patch though [19:26:43] does it still need ipns to complete? [19:26:51] cstone oh maybe [19:26:58] right, that rings a bell [19:27:24] jgleeson: on the docs on wikitech its a combo of old stuff and new so kind of chaos and needs organizing [19:27:46] i was updating things as i used them [19:34:14] thanks cstone [19:34:26] as to why some stuff is updated haphazardly [19:46:25] ejegg: I'm seeing Unknown Adyen status Received [19:46:36] jgleeson: yeah, me too [19:47:09] I'm not sure if we've changed the code since we last used it, or if they changed the statuses since we last used the code [19:47:23] anyway, it's the same before + after the method extraction [19:47:39] ok it looks like that's a direct debit [19:47:43] yeah [19:47:46] so maybe that status is normal [19:48:01] I tried with some CC ones but kept getting 800 contract not found [19:50:04] looks like those send us IPNs with more info [19:50:15] after being received maybe [19:50:19] yep, but that's outside the scope of this method [19:50:28] and no longer used in any case [19:50:41] I can do a follow-up patch that removes the old-style recurring [19:52:17] so ejegg that tests the 2/3 code paths [19:52:25] oh hah, the adyen token updater is still running [19:52:28] let's see the output [19:53:03] the middle one with 'processor_contact_id' check is left. is that called from the civi ext? [19:53:18] jgleeson: yep, but you can call that from the same test script [19:53:25] just add an --invoice parameter [19:53:34] let me find one that should work [19:54:09] that one we just tried effectively worked from a code standpoint. [19:54:20] a bad result handled as expected is still a pass [19:54:38] so if you add a --invoice parameter it will go down the processor_contact_id path [19:54:58] do I need to add a specific invoice or just make oneup? [19:55:51] i'm trying to find a good one in the test console [19:56:01] but I'm forgetting where to find the token there [19:57:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: ipset_error 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [19:57:21] oh hey, we have another test script for that [19:57:51] oh right, but not yet merged [19:58:07] see https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/819220 [20:01:06] ive got test ones if you need one jgleeson [20:01:08] OK, so on the console you click the payment ID and then under the shopper details go to the 'stored payment details' [20:01:27] the Detail reference field is the one you want for recurring_payment_token [20:01:35] so run that script with token= G2HTL9WBZ2M84H82 [20:01:42] and invoice=15033.1 [20:01:50] to go down the modern recurring charge path [20:02:01] jgleeson: ^^^ [20:02:03] 8877665569.1 [20:02:12] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [20:02:47] or you can make an adyen recurring and run the charge job with the id [20:05:19] ok thanks ejegg cstone will try that out [20:08:41] ah that worked. now I see where the mapRest... thingy came from also [20:09:05] so once we get rid of the SOAP calls we can make that name less confusing again [20:12:11] (03CR) 10Jgleeson: [C: 03+2] "Tested out the refactored code and all worked as expected. LGTM" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819775 (https://phabricator.wikimedia.org/T313069) (owner: 10Ejegg) [20:13:02] (03Merged) 10jenkins-bot: Break up big function [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819775 (https://phabricator.wikimedia.org/T313069) (owner: 10Ejegg) [20:13:06] (03Merged) 10jenkins-bot: Fix failmail on Adyen unsupported card: Take 2 [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819776 (https://phabricator.wikimedia.org/T313069) (owner: 10Ejegg) [20:13:23] thanks jgleeson ! [20:14:19] thank you! [20:23:13] (03PS3) 10Ejegg: Tweaks to query file parsing to get more data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820064 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [20:23:22] (03CR) 10Ejegg: [C: 03+2] "Thanks, looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820064 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [20:25:00] (03CR) 10CI reject: [V: 04-1] Tweaks to query file parsing to get more data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820064 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [20:25:38] guh - cat: /src/wikimedia/fundraising/crm/civicrm-buildkit/extern/composer.txt: No such file or directory [20:25:46] is that the failure? [20:25:51] right, looks like it [20:25:58] /src/wikimedia/fundraising/crm/civicrm-buildkit/bin/civi-download-tools: line 314: /src/wikimedia/fundraising/crm/civicrm-buildkit/extern/composer.txt: No such file or directory [20:26:14] something new broken with civicrm CI [20:26:21] I guess that's a bugzoo task? [20:27:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: ipset_error 2 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [20:28:19] hmm, composer.txt seems to have never been in that dir [20:28:37] oh i see, extern is gitignored [20:28:50] so some other process creates composer.txt I guess [20:32:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: ipset_error 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [20:35:11] When testing braintree recurring, the drush cvapi job.process_smashpig_recurring contribution_recur_id= give me error as docker@civicrm:/srv/civi-sites/wmff/drupal$ drush cvapi job.process_smashpig_recurring contribution_recur_id=4 [20:35:11] WD php: Error: Call to a member function getErrorCode() on null in CRM_Core_Payment_SmashPig->throwException() (line 206 of [error] [20:35:11] /srv/civi-sites/wmff/drupal/sites/default/civicrm/extensions/org.wikimedia.smashpig/CRM/Core/Payment/SmashPig.php). [20:35:11] Error: Call to a member function getErrorCode() on null in CRM_Core_Payment_SmashPig->throwException() (line 206 of /srv/civi-sites/wmff/drupal/sites/default/civicrm/extensions/org.wikimedia.smashpig/CRM/Core/Payment/SmashPig.php). [20:35:11] Drush command terminated abnormally due to an unrecoverable error. [error] any one have the similar issue? [20:37:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: ipset_error 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [20:39:43] nm, I see $processorResponse->getErrors() is blank, for this [error] => CreatePayment failed. [20:41:59] cstone: does this look ok to you? .https://wikitech.wikimedia.org/wiki/Fundraising#G_How_we_work_(Team_Processes) [20:42:12] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [20:42:27] I just added one line and two links [20:42:39] I figured adding the DoD on it's own didn't make much sense [20:44:03] wfan oh hmm, should that have an error then? [20:45:16] it was having if (!$processorResponse->hasErrors()) but this is blank not not exist so when we are using $processorResponse->getErrors()[0]->getErrorCode(); it's null [20:47:08] hmm, let me look at the code [20:47:32] yeah im getting that error now too [20:47:45] trying to see what changed since i tested it last [20:48:19] wfan ohh, maybe it has a validation error? [20:49:15] this can be on me now ejegg somethings not right [20:49:39] cstone so we used to just have one 'errors' array that were all of type PaymentError [20:49:42] so for line 199 should we update to if (!$processorResponse->hasErrors() || !$processorResponse->getErrors()[0]) [20:49:43] ah no [20:49:49] did that change in the last 2 days? [20:49:58] the errors array was a mixed bag of PaymentError and ValidationError [20:50:08] no, we changed it a few months ago at least [20:50:11] hmm okay [20:50:14] maybe even last fall [20:50:17] jsut curious why it worked for me last time I tested it [20:50:30] so anyway, we should maybe update that check [20:50:32] i can debug through this though [20:50:45] since hasErrrors() doesn't mean getErrors() will necessarily return something [20:51:09] now it means that EITHER getErrors() or getValidationErrors() will return something [20:54:00] 10Fundraising Tech Bug Petting Zoo, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Alerts: Invalid language codes should not break donation queue consumer - https://phabricator.wikimedia.org/T313092 (10Damilare) [20:56:01] ejegg: I remembering following through one of your patches I reviewed earlier and see that error check [20:56:10] could have been a test [20:56:36] (03PS1) 10Ejegg: Add comment clarifying meaning of hasErrors() [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/820558 [20:57:17] (03PS5) 10Cstone: Add vaulting for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819127 (https://phabricator.wikimedia.org/T303425) [20:57:21] false alarm. the one in your patch was $response->getValidationErrors()[0]->getField() [20:58:22] hmm what happened to our smashpig repo that it stopped auto adding reviewers? [20:58:25] 10Fundraising Tech Bug Petting Zoo, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Alerts: Invalid language codes should not break donation queue consumer - https://phabricator.wikimedia.org/T313092 (10Damilare) a:03Damilare [20:58:26] (03CR) 10CI reject: [V: 04-1] Add vaulting for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819127 (https://phabricator.wikimedia.org/T303425) (owner: 10Cstone) [20:58:36] oh that's weird cstone [20:58:48] or was it my double depends on that was causing it [20:58:50] wrapping up for tonight. cstone sorry I didn't get to your patch but looks like others are also looking now so I'll try and jump on it tomorrow if it's not already merged [20:59:02] good night jgleeson [20:59:02] no worries jgleeson and yeah looks like something is up with it [20:59:15] night all! [21:04:14] (03CR) 10Wfan: [C: 03+2] Add comment clarifying meaning of hasErrors() (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/820558 (owner: 10Ejegg) [21:05:24] (03Merged) 10jenkins-bot: Add comment clarifying meaning of hasErrors() [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/820558 (owner: 10Ejegg) [21:05:35] (03PS1) 10Ejegg: SmashPig: handle fail on just ValidationError [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820560 [21:05:55] (03CR) 10Ejegg: Add comment clarifying meaning of hasErrors() (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/820558 (owner: 10Ejegg) [21:06:51] wfan https://gerrit.wikimedia.org/r/820560 is the corresponding fix in the SmashPig Civi extension [21:06:59] (03CR) 10CI reject: [V: 04-1] SmashPig: handle fail on just ValidationError [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820560 (owner: 10Ejegg) [21:07:19] but it just failed CI because of some new buildkit change [21:07:21] nice you can use my broken code to test too :P [21:07:46] fr-tech you might not want to destroy your docker civi sites right now - might be hard to get them back! [21:08:15] so I should try making another locally I think [21:08:44] ejegg: ah looks really good, just the build Step ‘Publish xUnit test result report’ failed. [21:10:09] (03CR) 10Wfan: [C: 03+2] "looks really good thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820560 (owner: 10Ejegg) [21:11:51] wfan that Publish... step seems to happen every time there's a fail [21:12:02] don't put salt in your eye [21:12:03] there's an earlier line pointing to something closer to the cause [21:12:10] put salt in your eye [21:12:15] don't destroy your civi site [21:12:18] (03CR) 10CI reject: [V: 04-1] SmashPig: handle fail on just ValidationError [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820560 (owner: 10Ejegg) [21:12:19] destroy your Civi site!!!!!!!!! [21:12:24] /src/wikimedia/fundraising/crm/civicrm-buildkit/bin/civi-download-tools: line 314: /src/wikimedia/fundraising/crm/civicrm-buildkit/extern/composer.txt: No such file or directory [21:14:26] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820064 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [21:16:23] Oh I see some buildkit change on 8/2 [21:16:35] hmm, it's working locally [21:16:52] oh weird, line 314 is echo "$COMPOSER_VERSION" > "$PRJDIR/extern/composer.txt" [21:17:13] so it's the whole '$PRJDIR/extern' directory that's missing? [21:19:47] ok, way down on 728 it's created [21:19:48] [ ! -d "$PRJDIR/extern" ] && mkdir "$PRJDIR/extern" [21:19:59] think that just needs to go before the install_composer [21:23:25] install_composer is 696 before 728 [21:24:35] should we move 728 before install_composer then? [21:32:57] yes i think so [21:41:52] I just made a pull request [21:42:06] eileen___: https://github.com/civicrm/civicrm-buildkit/pull/716 [21:43:04] cool - I assume it's safe / tested (can I blind merge :-) [21:43:50] eileen___: heh, now that you mention it, I could test [21:43:57] :-) [21:44:09] but it's pretty safe - just moving a directory creation line up to before where it's expected to exist [21:46:04] ok, if I just delete extern without deleting any other things it complains about a symlink already existing in bin [21:46:26] but if I clear out those symlinks too it recreates extern happily and does all the download things [21:46:34] so yes, should be safe to merge eileen___ [21:46:53] and should get CI passing again [21:47:02] ok - I'll merge [21:47:06] thanks! [21:48:07] done [21:50:42] (03CR) 10Ejegg: [C: 03+2] "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820064 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [22:04:05] (03Merged) 10jenkins-bot: Tweaks to query file parsing to get more data [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820064 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [22:11:10] ejegg: this is the most significant of the things I tried on staging that improved performance - https://github.com/civicrm/civicrm-core/pull/24156 - I think we should try deploying it at a time when there is high traffic [22:11:50] but it also really surprised me - as I thought Redis would be faster.... [22:58:09] (03PS1) 10Eileen: Fix cache miss in FastArrays on 'has()' [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/820576 (https://phabricator.wikimedia.org/T313000) [23:03:24] thanks eileen___ ! I'll look later tonight [23:03:40] no hurry - I want to think about how to deploy [23:16:36] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Investigate Redis speed - https://phabricator.wikimedia.org/T314619 (10Eileenmcnaughton) [23:26:19] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Investigate Redis speed - https://phabricator.wikimedia.org/T314619 (10Eileenmcnaughton) [23:27:18] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Investigate Redis speed - https://phabricator.wikimedia.org/T314619 (10Eileenmcnaughton)