[02:16:31] (03PS2) 10Ejegg: SmashPig: handle fail on just ValidationError [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820560 [02:50:25] (03PS8) 10Ejegg: Fix Get Adyen token [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819220 (https://phabricator.wikimedia.org/T307602) [02:51:09] (03CR) 10Ejegg: "PS8: Rebase and edit commit message to indicate new name for test php script" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819220 (https://phabricator.wikimedia.org/T307602) (owner: 10Ejegg) [02:51:36] (03CR) 10Ejegg: [C: 03+2] "This looks good!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819220 (https://phabricator.wikimedia.org/T307602) (owner: 10Ejegg) [02:52:06] (03Merged) 10jenkins-bot: Fix Get Adyen token [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819220 (https://phabricator.wikimedia.org/T307602) (owner: 10Ejegg) [02:54:17] (03PS2) 10Ejegg: Check if recurring donation need to re get token before before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820472 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [02:57:12] (03CR) 10Ejegg: [C: 03+2] "Seems like this should work. Let's give it a shot!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820472 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [03:08:19] (03CR) 10CI reject: [V: 04-1] Check if recurring donation need to re get token before before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820472 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [03:13:07] (03PS1) 10Ejegg: Update smash-pig dependency and own version number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820594 [03:13:10] (03CR) 10Ejegg: [C: 03+2] Update smash-pig dependency and own version number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820594 (owner: 10Ejegg) [03:14:14] (03CR) 10CI reject: [V: 04-1] Update smash-pig dependency and own version number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820594 (owner: 10Ejegg) [03:16:53] (03CR) 10Ejegg: [C: 03+2] "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820594 (owner: 10Ejegg) [03:17:12] oh heck, did our github tag sync stop working for smashpig? [03:19:25] (03Merged) 10jenkins-bot: Update smash-pig dependency and own version number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820594 (owner: 10Ejegg) [03:22:42] (03PS1) 10Ejegg: Update smash-pig and donation-interface libraries [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820595 [03:23:13] (03CR) 10Ejegg: [C: 03+2] Update smash-pig and donation-interface libraries [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820595 (owner: 10Ejegg) [03:23:37] (03PS3) 10Ejegg: Check if recurring donation need to re get token before before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820472 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [03:35:22] (03Merged) 10jenkins-bot: Update smash-pig and donation-interface libraries [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820595 (owner: 10Ejegg) [03:36:37] (03CR) 10CI reject: [V: 04-1] Check if recurring donation need to re get token before before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820472 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [03:43:44] (03CR) 10Ejegg: "Oops, just needs one test update, but I think the code is solid." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820472 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [03:58:24] (03CR) 10CI reject: [V: 04-1] Check if recurring donation need to re get token before before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820472 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [04:47:12] PROBLEM - check_procs on frdb2003 is CRITICAL: PROCS CRITICAL: 2182 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [04:57:12] RECOVERY - check_procs on frdb2003 is OK: PROCS OK: 1458 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_procs [07:02:01] (03Abandoned) 10Eileen: Do not merge - remove legacy token evaluation [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819770 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [07:02:21] (03Abandoned) 10Eileen: Do not merge - remove token processor smarty eval [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819771 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [07:04:11] (03Abandoned) 10Eileen: Blunt force trauma [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/819766 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [07:04:37] (03Abandoned) 10Eileen: Test fast-cache improvement [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/820387 (owner: 10Eileen) [12:39:47] did I lose you damilare / [12:39:49] ? [13:24:35] damilare: we could go text only on IRC if the network isn't great? [13:35:47] sure thanks jgleeson [14:04:03] asdfds [14:04:26] lol. I'm also having internet problems damilare. my router just went down [14:05:10] the network providers just can't wait to start their weekends [14:18:05] (03PS1) 10Damilare Adedoyin: Handle invalid language codes properly in Civi [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820751 (https://phabricator.wikimedia.org/T313092) [14:20:32] haha [14:23:35] (03PS2) 10Damilare Adedoyin: Handle invalid language codes properly in Civi [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820751 (https://phabricator.wikimedia.org/T313092) [14:25:19] (03PS3) 10Damilare Adedoyin: Handle invalid language codes properly in Civi [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820751 (https://phabricator.wikimedia.org/T313092) [14:42:30] (03CR) 10CI reject: [V: 04-1] Handle invalid language codes properly in Civi [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820751 (https://phabricator.wikimedia.org/T313092) (owner: 10Damilare Adedoyin) [14:42:48] damilare: I just watched a pretty emotional news clip related to the commonwealth games taking place in your city. I think you'd like it https://www.bbc.co.uk/news/uk-scotland-62435294 it's the second video towards the bottom of the article [14:42:54] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Investigate Redis speed - https://phabricator.wikimedia.org/T314619 (10Jgreen) @Eileenmcnaughton couple questions: * How large were the arrays in question? Are we talking multi-KB or smaller. * As far as I know we're only using t... [14:43:19] checking [14:47:59] Aww that was so emotional jgleeson. thanks for sharing [14:48:53] yeah it's pretty inspirational and gives a great account of the hospitals close to you! [14:50:44] yh it definitely does [14:53:24] jgleeson looks like catching that error is failing this test - ImportMessageTest::testMessageImportInvalidLocaleThrowsException [14:55:38] Can I take off the tests as its no longer applicable or maybe we should move the donation to the damaged queue instead as proposed in the ticket? [14:58:11] is that one of the ones we recently added? [14:58:14] the name looks familiar [14:58:51] if so, sure feel free to remove [14:59:30] yh I think so, it was added by you in february this year [14:59:51] T298400 [14:59:52] T298400: Move attempt to guess contact's country & language from silverpop to import scripts to CiviCRM - https://phabricator.wikimedia.org/T298400 [15:00:09] ohh nice, didn't know of this feature [15:03:34] me neither ha [15:22:18] (03PS4) 10Damilare Adedoyin: Handle invalid language codes properly in Civi [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820751 (https://phabricator.wikimedia.org/T313092) [15:47:59] 10Fundraising Tech Bug Petting Zoo, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.22; 2022-07-25): Gpay errors - https://phabricator.wikimedia.org/T313333 (10EMartin) From Adyen: I had a look at the different between the en-US and en-ES configuration and what stood out was the difference n the `paymen... [15:53:20] (03PS4) 10Wfan: Check if recurring donation need to re get token before before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820472 (https://phabricator.wikimedia.org/T307602) [15:58:22] (03CR) 10Wfan: [C: 03+2] "Not sure how to test it, but the code looks reasonable, let's try if this helps the IPN failmail." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/820259 (https://phabricator.wikimedia.org/T314552) (owner: 10Ejegg) [15:59:51] (03Merged) 10jenkins-bot: Retry Amazon IPN message validation [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/820259 (https://phabricator.wikimedia.org/T314552) (owner: 10Ejegg) [16:05:47] fr-tech something has happened with the airline were flying with next week and I'm on the phone with them now but it's taking a while to sort out so I'm not gonna make standup. sorry! will provide my update as soon as I get off this call [16:05:52] we're* [16:06:05] cool cool. [16:06:06] thanks. [16:06:15] jgleeson|brb: "enjoy" [16:22:11] (03CR) 10Wfan: [C: 03+2] Check if recurring donation need to re get token before before send to queue (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820472 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [16:37:46] (03Merged) 10jenkins-bot: Check if recurring donation need to re get token before before send to queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/820472 (https://phabricator.wikimedia.org/T307602) (owner: 10Wfan) [17:06:05] ha greg-g [17:08:54] Slightly stressful but the good news is we're still going to Turkey next week, just not with the airline we booked with and not on the seats we prepaid for to sit by the other two families coming. [17:09:25] to avoid cancelling our flight they've given our booking to another airline [17:09:41] airlines seems pretty crazy at the moment [17:12:44] fr-tech, so re:standup. Today has consisted of looking into the existing paypal IPNs and working out how to handle two sets of IPNs, Paypal & Braintree, coming in for the same gateway transaction, Braintree, as part of the IPN job task. Also I checked in on a few patches I reviewed yesterday and had a check-in with Dami and listened to his findings on the failmail isolang issue [19:23:42] 10Fundraising Sprint NaN is a Number: Update Braintree Order ID after successful payment - https://phabricator.wikimedia.org/T314681 (10Damilare) [19:30:53] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] "Thanks for the link!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/820169 (owner: 10Ejegg) [19:31:43] (03PS6) 10Cstone: Add vaulting for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819127 (https://phabricator.wikimedia.org/T303425) [19:32:18] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Investigate Redis speed - https://phabricator.wikimedia.org/T314619 (10Jgreen) Testing with redis-benchmark I'm not seeing anything that suggests redis is performing poorly. I set up prometheus exporter on frdev1001 (it's already... [19:34:06] (03CR) 10CI reject: [V: 04-1] Add vaulting for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819127 (https://phabricator.wikimedia.org/T303425) (owner: 10Cstone) [19:36:02] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Investigate Redis speed - https://phabricator.wikimedia.org/T314619 (10Eileenmcnaughton) @Jgreen - I'm not completely sure re array size - could be multi kb & we use `Redis` for both caching & getting a unique key for contributio... [19:36:52] (03PS7) 10Cstone: Add vaulting for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/819127 (https://phabricator.wikimedia.org/T303425) [19:42:21] fr-tech for peeps asking about recurring that ^ one doesn't have the bug anymore [19:42:48] nice cstone [19:43:14] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Investigate Redis speed - https://phabricator.wikimedia.org/T314619 (10Jgreen) >>! In T314619#8134490, @Eileenmcnaughton wrote: > @Jgreen - I'm not completely sure re array size - could be multi kb & we use `Redis` for both cach... [19:58:55] (03CR) 10Damilare Adedoyin: [C: 03+1] "Looks good to me, +1'ing to allow other pair of eyes on the signature validator implementation" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817357 (https://phabricator.wikimedia.org/T303451) (owner: 10Jgleeson) [20:07:45] 10Fundraising Tech Bug Petting Zoo: Create Documentation for testing IPNs on each Gateway - https://phabricator.wikimedia.org/T314683 (10Damilare) [20:07:58] thx cstone :) [20:08:02] 10Fundraising Tech Bug Petting Zoo: Create Documentation for testing IPNs on each Gateway - https://phabricator.wikimedia.org/T314683 (10Damilare) a:03Damilare [20:10:04] (03CR) 10Jgleeson: [C: 04-1] "Struggling to test this one." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820161 (owner: 10Ejegg) [20:50:37] 10Fundraising-Backlog, 10fr-donorservices: Adyen donors think they are recurring July 2022 - https://phabricator.wikimedia.org/T313854 (10EMartin) @fr-tech. I was looking at Kristie's recap of donor complaints about this topic. I had a thought about recurring around iDeal since most of the complaints surroun... [21:08:01] 10Fundraising Tech Bug Petting Zoo, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.22; 2022-07-25): Gpay errors - https://phabricator.wikimedia.org/T313333 (10EMartin) Successful GPay test transactions by market. MYR - {F35402118} PT - {F35402120} NOK - {F35402122} DKK - {F35402127} ILS - {F35402129} [21:13:59] 10Fundraising Tech Bug Petting Zoo, 10fr-donorservices: Adyen donors think they are recurring July 2022 - https://phabricator.wikimedia.org/T313854 (10greg) Moving this to the DRI workboard so we can get this going next week. [21:27:59] 10Fundraising-Backlog: Make Adyen default for 6ENC campaigns by 13 Aug 2022 - https://phabricator.wikimedia.org/T314687 (10EMartin) [21:58:23] 10Fundraising Sprint NaN is a Number, 10Fundraising-Backlog: Adyen - auto settle stopped prior donors - https://phabricator.wikimedia.org/T299692 (10greg)