[00:12:13] 10Fundraising Sprint Machine Unlearning, 10Fundraising Sprint NaN is a Number, 10Fundraising-Backlog, 10FR-Braintree-Integration: Update PayPal IPN listener to discard donations initiated via Braintree - https://phabricator.wikimedia.org/T313512 (10AnnWF) https://gerrit.wikimedia.org/r/c/wikimedia/fundrais... [00:21:24] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts: Lots of DBReadOnlyError cluttering up payments-wiki error logs - https://phabricator.wikimedia.org/T308162 (10Ejegg) Easy to reproduce locally by putting $wgReadOnly = 'blah'; in LocalSettings. Looks like the ResourceLoader dependency tra... [00:28:52] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts: Lots of DBReadOnlyError cluttering up payments-wiki error logs - https://phabricator.wikimedia.org/T308162 (10Ejegg) Yeah! ResourceLoaderUseObjectCacheForDeps should fix us right up. https://phabricator.wikimedia.org/source/mediawiki/brows... [00:33:07] oh crap, looks like rsyslog isn't sending anything to the central logger [00:34:57] ohhhh, new central logger [00:35:02] :) [00:37:07] heh [00:57:40] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts: Lots of DBReadOnlyError cluttering up payments-wiki error logs - https://phabricator.wikimedia.org/T308162 (10Ejegg) Hmm, looks like that is already set to true (in the puppetized bits) and we're still seeing the RO errors. So it seems to... [01:09:57] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts: Lots of DBReadOnlyError cluttering up payments-wiki error logs - https://phabricator.wikimedia.org/T308162 (10Ejegg) OK, I set $wgMainStash to CACHE_ACCEL at 01:03:24 UTC on Aug 16 and it doesn't seem to be breaking anything. I haven't seen... [02:09:03] 10Fundraising-Backlog, 10donate.wikimedia.org: Broken links from Waystogive? - https://phabricator.wikimedia.org/T315268 (10Ejegg) [05:06:01] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_37) - 10https://gerrit.wikimedia.org/r/823349 (owner: 10L10n-bot) [08:12:00] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/822790 (owner: 10L10n-bot) [08:30:52] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_37) - 10https://gerrit.wikimedia.org/r/823349 (owner: 10L10n-bot) [09:52:34] 10Fundraising-Backlog, 10donate.wikimedia.org: Broken links from Waystogive? - https://phabricator.wikimedia.org/T315268 (10Pcoombe) Weird, I tried different browsers and couldn't reproduce with https://donate.wikimedia.org/wiki/Ways_to_Give#PayPal. Have you seen many of these? I wonder if someone shared the l... [12:28:40] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Current Employer Relationship additions immediately becoming inactive - https://phabricator.wikimedia.org/T230032 (10Aklapper) [12:29:17] 10fundraising-tech-ops: encrypt fundraising database client->server communication - https://phabricator.wikimedia.org/T170321 (10Aklapper) [13:14:17] (03CR) 10Damilare Adedoyin: [C: 04-1] "Thanks for the work on this, just a little comment inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820161 (owner: 10Ejegg) [14:28:56] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Update orphan rectifier log source from /srv/archive/frlog1001 to /srv/archive/frlog - https://phabricator.wikimedia.org/T315033 (10Jgreen) >>! In T315033#8155357, @Ejegg wrote: > This is updated. I notice there are only 45 days of payments logs in there... [14:49:18] 10Fundraising-Backlog, 10donate.wikimedia.org: Broken links from Waystogive? - https://phabricator.wikimedia.org/T315268 (10Ejegg) I just noticed a few pf them in the logs last night after quieting down some other noisy errors. Maybe it's actually a weird error in the logging? Will get a count today and see if... [14:51:56] hi damilare , thank you for looking at the patch. I think your inline comment must still be in 'draft' status because I can't see it in gerrit [14:54:06] (03CR) 10Damilare Adedoyin: [C: 04-1] Gateway chooser: check country restriction on method (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820161 (owner: 10Ejegg) [14:54:28] sorry about that ejegg [14:57:24] (03CR) 10Ejegg: Gateway chooser: check country restriction on method (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820161 (owner: 10Ejegg) [15:53:29] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Update orphan rectifier log source from /srv/archive/frlog1001 to /srv/archive/frlog - https://phabricator.wikimedia.org/T315033 (10Ejegg) Sometimes we get older donations in newer log files, and sometimes we keep trying to reprocess the same logs files f... [16:05:33] ooh damilare I found another bug in the submethod country limiting logic! [16:05:50] I really should have found it when I was reviewing the code a couple months ago, but better late than never [16:06:07] hmm, maybe I should do this patch as a follow-on though [16:06:15] since it's a different change [16:07:23] (03PS4) 10Ejegg: Gateway chooser: check country restriction on method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820161 [16:07:25] (03PS1) 10Ejegg: GatewayChooser: fix submethod country bug, add comments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/823683 [16:07:29] oh let's see, I should add a couple tests [16:14:56] Yep tests are definitely good! [16:23:57] (03CR) 10CI reject: [V: 04-1] GatewayChooser: fix submethod country bug, add comments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/823683 (owner: 10Ejegg) [16:24:31] linter [16:24:52] (03PS5) 10Ejegg: Gateway chooser: check country restriction on method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820161 [16:24:54] (03PS2) 10Ejegg: GatewayChooser: fix submethod country bug, add comments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/823683 [16:25:07] ok, now there's a test for each restriction ^^ [16:29:09] ooh, error logs looking clean [16:29:54] last DBReadOnlyError more than 15 hours ago! [16:30:22] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts: Lots of DBReadOnlyError cluttering up payments-wiki error logs - https://phabricator.wikimedia.org/T308162 (10Ejegg) Still none more than 15 hours later! [16:30:26] wooo ejegg [16:33:03] (03CR) 10CI reject: [V: 04-1] Gateway chooser: check country restriction on method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820161 (owner: 10Ejegg) [16:33:24] (03CR) 10CI reject: [V: 04-1] GatewayChooser: fix submethod country bug, add comments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/823683 (owner: 10Ejegg) [16:33:59] oh nasty, the output page gets barfed into the test output when the chooser doesn't redirect [16:34:02] hmm [16:35:48] ahh, specialPage->getOutput()->output() has an optional param to output the text [16:36:06] i mean return the text rather than print it [16:36:14] I think some of the old tests could have used that [16:39:43] (03PS6) 10Ejegg: GatewayChooser: check country restriction on method [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820161 [16:39:45] (03PS3) 10Ejegg: GatewayChooser: fix submethod country bug, add comments [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/823683 [16:44:01] ejegg another question on the smashpig+di in civi update, composer update is mad that the current lockfile has an older smashpig what is the usual process to deal with that? [16:44:54] hmm, you are running composer update --no-dev wikimedia/smash-pig wikimedia/donation-interface ? [16:45:06] and you updated both version numbers in composer.json? [16:46:46] hah that worked fine I guess i was thinking just di should have grabbed the smashpig too [16:47:07] arr yeah, there's a -W switch to also update all the dependencies [16:47:20] i was trying that but it was failing me [16:47:20] but that might have surprised us with a new MinFraud version or something [16:47:26] ah yeah [16:49:32] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts: Lots of DBReadOnlyError cluttering up payments-wiki error logs - https://phabricator.wikimedia.org/T308162 (10Ejegg) 05Open→03Resolved a:03Ejegg [16:49:47] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MW-1.39-notes (1.39.0-wmf.25; 2022-08-15): Make Adyen default for 6ENC campaigns by 13 Aug 2022 - https://phabricator.wikimedia.org/T314687 (10Ejegg) 05Open→03Resolved [16:50:12] ACKNOWLEDGEMENT - Host frbackup2002 is DOWN: PING CRITICAL - Packet loss = 100% Jeff_Green kernel update [21:02:57] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Braintree-Integration, 10MediaWiki-extensions-DonationInterface: Remove PayPal EC front-end and orphan rectifier - https://phabricator.wikimedia.org/T315375 (10Ejegg) [21:04:32] AndyRussG: that's the medium-term plan for moving forward with tech debt reduction ^^ [21:06:21] ah cool thx much ejegg! :) [21:06:53] maybe not exactly one phab task worth of work there, but it's written down somewhere now... [21:11:38] !log civicrm upgraded from 92467234 to c228e3d7 [21:11:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:14:10] 10Fundraising-Backlog, 10Diffusion-Repository-Administrators, 10Projects-Cleanup, 10Wikimedia-GitHub: Archive the FundraisingEmailUnsubscribe - https://phabricator.wikimedia.org/T224764 (10Aklapper) 05Stalled→03Open @Ejegg: Reopening per last question. [21:19:06] 10Fundraising-Backlog: Search kit question - https://phabricator.wikimedia.org/T315376 (10MDemosWMF) [21:26:10] 10Fundraising Sprint Machine Unlearning, 10Fundraising Sprint NaN is a Number, 10Fundraising-Backlog, 10FR-Alerts: New Adyen recurrings from the audit file are missing their recurring_token and creating Error: INVALID_MESSAGE Recurring donation, but no subscription... - https://phabricator.wikimedia.org/T307602 [21:30:06] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts: INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found failmail coming from the listener on ideal - https://phabricator.wikimedia.org/T315031 (10AnnWF) [21:30:24] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts: INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found failmail coming from the listener on ideal - https://phabricator.wikimedia.org/T315031 (10AnnWF) [21:32:25] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts: INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found failmail coming from the listener on ideal - https://phabricator.wikimedia.org/T315031 (10AnnWF) [21:39:56] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10FR-Braintree-Integration: Write a script that can migrate a PayPal EC billing agreement to a Braintree vault token - https://phabricator.wikimedia.org/T315371 (10Ejegg) OK, looks like this process mostly happens on their side: http... [21:40:15] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10FR-Braintree-Integration: Paypal audit parser should drop Braintree-initiated donations - https://phabricator.wikimedia.org/T315258 (10AnnWF) [21:40:27] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10FR-Braintree-Integration: Migrate PayPal EC billing agreements to Braintree vault tokens - https://phabricator.wikimedia.org/T315371 (10Ejegg) [21:42:04] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10FR-Braintree-Integration: Paypal audit parser should drop Braintree-initiated donations - https://phabricator.wikimedia.org/T315258 (10Ejegg) So we can do this the easy way or the hard way. Easy way = adding more logic to existing... [21:56:13] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts: INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found failmail coming from the listener on ideal - https://phabricator.wikimedia.org/T315031 (10AnnWF) [22:02:08] 10Fundraising-Backlog, 10Diffusion-Repository-Administrators, 10Projects-Cleanup, 10Wikimedia-GitHub: Archive the FundraisingEmailUnsubscribe - https://phabricator.wikimedia.org/T224764 (10Ejegg) @Aklapper we keep getting asked for new features, so the new page still hasn't been built out to handle the uns... [22:16:47] 10Fundraising Tech - Chaos Crew, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.25; 2022-08-15): Adyen donors think they are recurring July 2022 - https://phabricator.wikimedia.org/T313854 (10EMartin) Note: I checked with Donor Relations and no further instances of these complaints reported. Indeed closed... [22:30:37] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Search kit question - https://phabricator.wikimedia.org/T315376 (10Eileenmcnaughton) @MDemosWMF - I think if you add in `Contact` as a required 'with' and 'Primary Address' then you will get 'Contributions with Contacts with a Primary Address' - per the... [23:08:19] 10Fundraising-Backlog: Change source_type to be more specific - https://phabricator.wikimedia.org/T315390 (10Cstone) [23:23:01] 10Fundraising-Backlog, 10Diffusion-Repository-Administrators, 10Projects-Cleanup, 10Wikimedia-GitHub: Archive the FundraisingEmailUnsubscribe - https://phabricator.wikimedia.org/T224764 (10Aklapper) 05Open→03Stalled Ah, thanks for the update! [23:28:16] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts: INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found failmail coming from the listener on ideal - https://phabricator.wikimedia.org/T315031 (10AnnWF) [23:29:10] thanks for updating that yet again wfan [23:29:37] np :) Thanks for the tech talk :)