[00:01:44] (03PS1) 10Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/824321 [00:02:00] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/824321 (owner: 10Eileen) [00:06:24] !log civicrm upgraded from 97638e58 to edfe2f16 [00:06:26] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:07:29] ejegg: when you are about I'd like to discuss doctor breeding with you & how to fix :-) [00:08:00] doctors breeding more doctors? [00:11:51] yep - that's the problem [00:11:59] see https://phabricator.wikimedia.org/T315509 [00:12:53] ha. [00:28:27] hi again, sorry, was called away to help with kid stuff [00:28:44] so eileen___ looks like you deployed about 22 min ago [00:28:57] looking at queue graphs [00:29:01] lol the graph rather shows that doesn't it [00:29:54] oh yeah, that queue slants down pretty quick after that [00:30:14] and there's at least one run where we got back up to 8 donations per second [00:31:17] so that's pretty good! [00:32:44] heh, so about this healthcare professional glut... I guess we want to fix that check, no? [00:32:45] ejegg: so our second dip is lower than the first - but do we still have the traffic to make that meaningful? [00:33:04] eileen___: no, the traffic is off and the queue is back around zero [00:33:10] oh well [00:33:51] ejegg: yep - are you ok with my proposal to just remove the whole prefix & suffix checks & let if fail if they are invalid - it doesn't look to me like it would really happen in batch jobs [00:34:14] but if it did we could re-instate something better [00:34:50] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Set expiry time for GeoIP cookies - https://phabricator.wikimedia.org/T122097 (10nshahquinn-wmf) >>! In T122097#6369943, @Tgr wrote: > This can be quite confusing. I still have a US geoip cookie, even though I haven't been in the US for almost five m... [00:35:44] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Traffic: Set expiry time for GeoIP cookies - https://phabricator.wikimedia.org/T122097 (10nshahquinn-wmf) I believe the GeoIP cookie is set by Varnish, which is maintained by #traffic. [00:41:51] hmm - I think the graph is compelling that the second fix helped too - I thought there was a way to annotate it [00:47:47] eileen___: we certainly didn't get up to 8 per second with just the first fix on [00:48:13] ah cool - [00:48:20] yeah, i remember have a way to put vertical lines in graphs for when stuff happens [00:48:45] but maybe that was a different version? or different dashboards entirely? I'm not seeing it here [00:49:51] eileen___: ohh i see, removing the checks means just sending them verbatim to the API and letting it discard ones with no match [00:49:54] sure, that sounds OK [00:50:19] given that we're just parsing out a limited number of prefixes based on that name parsing library anyway [00:50:27] ejegg: I think it would error rather than discard - but my take is that happened last a year ago & it was on a user import [00:51:12] So we do already have entries for all the ones detected by that lib? [00:51:36] I'm guessing so - I didn't check suffixes but I scrolled through the prefixes being created [00:53:16] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Stop prolific doctor breeding - https://phabricator.wikimedia.org/T315509 (10Eileenmcnaughton) Prefixes created since Oct last year LABEL | +------------+... [00:53:37] ejegg: ^^ shows list since Oct last year [00:54:07] if they were all legit would be one every three weeks - but they aren't [00:54:18] as in legit not-already-in -the-db [00:58:52] I found one legit suffix insert this year (O.D.) - but once again it was a user import & 'OD' already exists so might be better [01:07:14] (03PS4) 10Ejegg: Audits: send merchant ID as gateway_account [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/436086 [01:10:52] ooh, doctor of optometry [01:11:44] yeah seems like it would be better without the dots like MD [01:12:07] well sure, let's cut out the checks [01:13:12] Hah, -od is a linguistic suffic in Welsh and Hungarian [01:13:14] https://en.wiktionary.org/wiki/-od [01:13:47] kor (“age”) → a korod (“your age”) [01:18:10] alright [01:18:30] think i'mma call it quits for today [01:18:53] good night/afternoon all [02:12:53] (03PS2) 10Eileen: Remove unused function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824312 [02:17:10] (03PS1) 10Eileen: Remove buggy function to ensure prefix & suffix exist [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824323 (https://phabricator.wikimedia.org/T315509) [02:17:33] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Stop prolific doctor breeding - https://phabricator.wikimedia.org/T315509 (10Eileenmcnaughton) [02:21:46] (03PS6) 10Eileen: Remove system.flush that should be obsolete now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809332 [02:24:40] (03CR) 10CI reject: [V: 04-1] Remove system.flush that should be obsolete now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809332 (owner: 10Eileen) [02:30:29] (03CR) 10CI reject: [V: 04-1] Remove buggy function to ensure prefix & suffix exist [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824323 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen) [03:04:00] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Email Greeting Field in Civi - blank for some donors - https://phabricator.wikimedia.org/T308181 (10Eileenmcnaughton) Just noting that we did some testing today... [04:46:31] (03PS1) 10Eileen: Add upgrade script to removed unused prefix, suffix, language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824328 (https://phabricator.wikimedia.org/T315509) [04:46:33] (03PS1) 10Eileen: IDE cheer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824329 [04:52:30] (03PS2) 10Eileen: IDE cheer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824329 [04:52:32] (03PS2) 10Eileen: Add upgrade script to removed unused prefix, suffix, language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824328 (https://phabricator.wikimedia.org/T315509) [04:57:20] (03PS3) 10Eileen: Add upgrade script to removed unused prefix, suffix, language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824328 (https://phabricator.wikimedia.org/T315509) [05:00:25] (03CR) 10CI reject: [V: 04-1] IDE cheer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824329 (owner: 10Eileen) [05:05:37] (03CR) 10CI reject: [V: 04-1] Add upgrade script to removed unused prefix, suffix, language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824328 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen) [05:06:13] (03CR) 10CI reject: [V: 04-1] IDE cheer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824329 (owner: 10Eileen) [05:12:59] (03CR) 10CI reject: [V: 04-1] Add upgrade script to removed unused prefix, suffix, language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824328 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen) [05:17:00] (03PS4) 10Eileen: Add upgrade script to removed unused prefix, suffix, language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824328 (https://phabricator.wikimedia.org/T315509) [05:32:52] (03CR) 10CI reject: [V: 04-1] Add upgrade script to removed unused prefix, suffix, language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824328 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen) [05:50:46] (03PS1) 10Eileen: Add upgrade script to removed unused prefix, suffix, language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824334 (https://phabricator.wikimedia.org/T315509) [06:03:49] (03CR) 10CI reject: [V: 04-1] Add upgrade script to removed unused prefix, suffix, language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824334 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen) [06:22:23] (03PS3) 10Eileen: IDE cheer [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824329 [06:22:25] (03PS2) 10Eileen: Add upgrade script to removed unused prefix, suffix, language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824334 (https://phabricator.wikimedia.org/T315509) [06:23:45] (03CR) 10Eileen: "This change is ready for review." [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/820400 (owner: 10Eileen) [06:35:49] (03Abandoned) 10Eileen: Remove system.flush that should be obsolete now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/809332 (owner: 10Eileen) [06:55:32] (03PS1) 10Eileen: Allow greeting processing on new contacts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824392 (https://phabricator.wikimedia.org/T308181) [09:33:29] (03Abandoned) 10Eileen: Add upgrade script to removed unused prefix, suffix, language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824328 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen) [09:43:40] (03PS2) 10Eileen: Remove buggy function to ensure prefix & suffix exist [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824323 (https://phabricator.wikimedia.org/T315509) [09:56:53] (03CR) 10CI reject: [V: 04-1] Remove buggy function to ensure prefix & suffix exist [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824323 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen) [10:13:12] (03PS3) 10Eileen: Remove buggy function to ensure prefix & suffix exist [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824323 (https://phabricator.wikimedia.org/T315509) [10:26:51] (03CR) 10CI reject: [V: 04-1] Remove buggy function to ensure prefix & suffix exist [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824323 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen) [14:58:48] 10fundraising-tech-ops: install/configure frdev1002 - https://phabricator.wikimedia.org/T285892 (10Jgreen) [15:07:06] (03PS1) 10Wfan: Add merchantId if currency is not USD and has account to support it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/824518 (https://phabricator.wikimedia.org/T312808) [15:09:41] (03CR) 10CI reject: [V: 04-1] Add merchantId if currency is not USD and has account to support it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/824518 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [15:28:24] 10fundraising-tech-ops: install/configure frdev1002 - https://phabricator.wikimedia.org/T285892 (10Jgreen) [15:37:57] (03PS7) 10Wfan: Check if currency supported by braintree merchant account [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/822191 (https://phabricator.wikimedia.org/T312808) [15:39:38] 10fundraising-tech-ops: install/configure frdev1002 - https://phabricator.wikimedia.org/T285892 (10Jgreen) [15:43:18] (03PS1) 10Wfan: Add merchantId if currency is not USD and has account to support it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/824528 (https://phabricator.wikimedia.org/T312808) [15:43:55] (03CR) 10CI reject: [V: 04-1] Add merchantId if currency is not USD and has account to support it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/824528 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [15:44:00] (03Abandoned) 10Wfan: Add merchantId if currency is not USD and has account to support it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/824518 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [15:46:34] (03PS2) 10Wfan: Add merchantId if currency is not USD and has account to support it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) [15:47:09] (03Abandoned) 10Wfan: Add merchantId if currency is not USD and has account to support it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/824528 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [15:56:03] 10fundraising-tech-ops: install/configure frdev1002 - https://phabricator.wikimedia.org/T285892 (10Jgreen) [15:57:02] 10fundraising-tech-ops: install/configure frdev1002 - https://phabricator.wikimedia.org/T285892 (10Jgreen) [16:39:38] 10Fundraising-Backlog, 10Epic: Upgrading payments-wiki from buster to bullseye - https://phabricator.wikimedia.org/T315585 (10Dwisehaupt) [16:49:27] dwisehaupt: what base bullseye image are you using? is there a wikimedia-bullseye somewhere? [16:50:34] we are using the base debian bullseye image and then managing it with puppet. we don't have or use a docker image. [16:50:41] oh ok [16:51:05] our vm testing is to install the base debian and then do our overlay and have it persist. [17:20:06] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10SRE, 10Traffic-Icebox: Geoip lookup - Misidentifying country due to travelling - https://phabricator.wikimedia.org/T175691 (10nshahquinn-wmf) The main idea here is to regularly expire or refresh GeoIP cookies, so I'd say this is the same as T12... [17:20:29] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10SRE, 10Traffic-Icebox: Geoip lookup - Misidentifying country due to travelling - https://phabricator.wikimedia.org/T175691 (10nshahquinn-wmf) [17:20:34] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Traffic: Set expiry time for GeoIP cookies - https://phabricator.wikimedia.org/T122097 (10nshahquinn-wmf) [17:22:10] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Traffic: Set expiry time for GeoIP cookies - https://phabricator.wikimedia.org/T122097 (10nshahquinn-wmf) Important comments from T175691: >>! In T175691#3601975, @AndyRussG wrote: > It's not a negligible number of users whose GeoIP location doe... [17:41:38] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10AMJohnson) [17:42:39] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10AMJohnson) [17:42:41] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10AMJohnson) [17:42:43] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10AMJohnson) [17:42:45] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10AMJohnson) [17:42:47] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10AMJohnson) [17:46:05] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/824540 [17:46:08] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/824540 (owner: 10Ejegg) [17:47:05] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/824540 (owner: 10Ejegg) [17:47:25] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/824541 [17:47:29] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/824541 (owner: 10Ejegg) [17:49:28] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10AMJohnson) [17:52:24] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10AMJohnson) [17:56:43] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/824541 (owner: 10Ejegg) [17:58:33] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10MBeat33) I refunded my test donation 127517100.1 and the PayPal console performed the refund in USD [18:10:10] 10Fundraising-Backlog, 10FR-OtherProcessors, 10FR-Smashpig, 10Epic: [Epic] Move all listener message processing to a second stage - https://phabricator.wikimedia.org/T143342 (10Ejegg) Note: we tried moving PayPal's IPN validation step into the job queue and it turned out that was way too slow. The job queu... [18:15:21] (03CR) 10Ejegg: [C: 04-1] "The logic to add the code looks great! We don't want to put the WMF-specific account names in the default config in this repo though - our" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [18:18:27] Hi Elliott, if add something to private-config, should I have the private-config merge first? otherwise this smashpig will fail as not find this config? [18:19:24] wfan sure, it makes sense to push a private-config change first, so we can pull it for testing purposes [18:19:54] ok [18:22:10] (03CR) 10Ejegg: [C: 04-1] "Hmm, how about we also return a validation error if the currency does not have a matching account? You would also want to add the USD acco" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [18:26:04] aha, there is a whole other endpoint for getting tokens in Adyen: https://docs.adyen.com/api-explorer/#/Recurring/v67/post/listRecurringDetails [18:26:14] apparently that one will get us tokens for iDEAL [18:27:15] and probably will not get us the irrelevant generic payment method data [18:28:19] no need to add USD account to map, USD is default, so if no merchantAccountId indicated, will use USD, I left USD on purpose [18:28:55] wfan: so under Braintree, our own default merchant account is set to USD, but other users could have something else [18:29:11] let's try to make SmashPig as general-purpose as possible [18:29:38] Ok~ [18:30:05] then production config will be different with our sandbox one, since they have different name~ [18:30:14] USD account [18:30:37] yep, the config-private should have our sandbox account IDs [18:32:11] ok will add it~ [18:32:34] fr-tech I just tried deploying the latest payments-wiki and had to roll back [18:32:52] because it's breaking the gateway chooser for NL / EUR / rtbt / rtbt_ideal [18:33:01] I'll try to fix ASAP [18:33:04] hmmm [18:33:13] k thanks ejegg I'm about as needed [18:33:20] thank AndyRussG [18:33:22] *thanks [18:33:28] :) [18:34:16] I wanted to deploy quickly because we're still sending some donors to a Braintree form with non-working multicurrency support (see https://phabricator.wikimedia.org/T315592 ) [18:34:27] and I thought my gatewayChooser changes would fix that [18:34:36] but they're a bit too restrictive I guess? [18:34:41] or just plain buggy [18:37:38] (03PS1) 10Ejegg: WIP gatewayChooser test for rtbt_ideal with submethod [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 [18:39:59] (03CR) 10CI reject: [V: 04-1] WIP gatewayChooser test for rtbt_ideal with submethod [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 (owner: 10Ejegg) [18:44:58] ooh, those in_array checks are apparently not the way to go here [18:45:32] not when we're looking for a top-level key anyway [18:49:22] (03PS2) 10Ejegg: GatewayChooser: fix submethod support check [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 [18:49:41] AndyRussG: ok, I think ^^^ should fix it [18:50:21] just replaces the in_array check with an isset check, and adds a test case [18:51:28] (03CR) 10CI reject: [V: 04-1] GatewayChooser: fix submethod support check [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 (owner: 10Ejegg) [18:51:38] 10fundraising-tech-ops: reimage fundraising payments role servers to Bullseye - https://phabricator.wikimedia.org/T315599 (10Dwisehaupt) [18:51:44] htm [18:51:47] *hrm [18:52:20] oh, now the negative test case is failing? [18:56:16] ohhhh, country is not a scalar either [18:56:23] it's a hash of string -> bool [18:56:33] so in_array is also not useful there [18:56:43] huh, that's inconsistent [18:57:04] 10fundraising-tech-ops: reimage fundraising frdb_analytics role servers to Bullseye - https://phabricator.wikimedia.org/T315600 (10Dwisehaupt) [18:57:41] really, that's interesting [18:58:03] 10fundraising-tech-ops: reimage fundraising_database role servers to Bullseye - https://phabricator.wikimedia.org/T315601 (10Dwisehaupt) [18:59:33] so I can't see anywhere that we set a country code to false in a payment_submethods.yaml [19:00:08] (03CR) 10AndyRussG: GatewayChooser: fix submethod support check (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 (owner: 10Ejegg) [19:01:38] fr-tech I'm going to disable the braintree gateway in production till we can get this patch out [19:01:50] people are getting charged more than they expect [19:04:53] OK, disabled [19:07:50] yeah, thanks [19:08:43] ejegg: is this UBN? [19:09:05] I'm trying to understand what went on with the previous two patches to get some context [19:09:23] but maybe I should hurry up and skip doing that [19:28:08] AndyRussG: so the disablement should make sure nobody else gets charged extra [19:28:26] ejegg: ok [19:28:30] (sorry, had a quick meeting in there) [19:28:36] no worries ofc! [19:28:39] how were people getting charged extra? [19:28:53] Trying to donate 100CNY and getting charged 100USD instead [19:28:53] on what payment method? how is that related to gateway chooser? [19:29:00] paypal payment method [19:29:05] oooff [19:29:07] they were getting routed to the braintree form [19:29:12] ah I see [19:29:23] because it didn't have the submethod-level restrictions [19:29:40] err rather, method-level country restrictions [19:29:41] this is for people in countries unsuppoerted by old Braintree, correct? [19:29:54] right, unsupported by old paypal [19:30:01] ok thx [19:30:14] so CN for example should have gotten a 'no form found' error [19:30:18] just wondering is we should send a heads-up to donor services? [19:30:27] or maybe even a phab task or report of some sort? [19:30:32] or is it not enuf for that? [19:30:47] donor services already created a ticket [19:31:08] I thought that quick deploy would fix it and then I could explain on the ticket [19:31:31] but the deploy caused a different problem, breaking the gateway chooser for iDEAL donors [19:31:49] so instead I disabled Braintree in production [19:31:53] anyway, I [19:32:14] should reply on that ticket and then I'll get back to fixing the patch [19:32:27] will go to dental appointment now, and back in 2 hrs, and the multi-currency use USD as default cause that error~ that's why need to update braintree's currency.yaml and block before we have the merchant created [19:33:00] wfan: hope it goes well :) [19:33:11] right thta tmakes sense [19:33:19] ejegg: oki thanks! [19:33:53] I have a bit of non-work for the next hour or so (aka lunch) but if it were a dire emergency I'd keep on this [19:35:23] ok, I think it can wait [19:35:33] err rather it can definitely wait. Have lunch! [19:37:40] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10Ejegg) Hi @AMJohnson and @MBeat33, very sorry about this. The donor was routed to the new Braintree form because the current PayPal gateway doesn't have CN as a supported countr... [19:38:03] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10Ejegg) Also, I will look for other donors who got routed to Braintree and were charged in USD while the form might have shown some other currency. [19:38:09] ejegg: oki thanks! [19:55:18] (03PS4) 10Eileen: Remove buggy function to ensure prefix & suffix exist [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824323 (https://phabricator.wikimedia.org/T315509) [19:58:59] ejegg: in the meantime, please let me know if there's anything I could help with [20:04:35] thanks damilare ! [20:06:48] (03PS3) 10Ejegg: GatewayChooser: fix submethod support check [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 [20:07:58] (03CR) 10CI reject: [V: 04-1] Remove buggy function to ensure prefix & suffix exist [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824323 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen) [20:09:33] (03PS4) 10Ejegg: GatewayChooser: fix submethod support check [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 [20:10:20] damilare: i know it [20:10:44] 's pretty late for you, but if you would like to weigh in on that patch I'd be happy to hear your comments [20:11:00] Sure I’m looking into it now [20:11:50] I'm trying to remember why we used the boolean values [20:11:56] I guess we thought we could override them? [20:12:20] but the way our yamls files cascade we can only override a whole file at a time, not a single value [20:13:09] Maybe we were looking forward to moving all the yaml configs into SmashPig, where the cascading overrides DO let you override a single value in a file [20:15:24] hi eileen___ [20:15:32] hey [20:17:08] So we haven't seen any donation queue build-up today - were you expecting some at 4pm UTC? [20:18:45] I wasn't sure - they sent an email then - but just to the formerly on hold [20:19:56] I think it;s clear from the graph now that second patch squoze a bit more performance out of it though [20:21:59] if we pause queues for a bit is there enough to get a back log - or not really - I feel like we need probably more traffic to see a pattern than we have - [20:24:29] i doubt it [20:30:56] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10MBeat33) Many thanks for the context + followup, @Ejegg [20:31:05] gonna head out for a half hour or so, see you in a bit! [20:32:06] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10AMJohnson) Thanks for the quick reply Elliott! No worries from us happy we know the cause. :) We're trying to figure out which of the donors donations we should refund in PayPa... [20:37:26] eileen___: at the current rates, i think we would have to hold the queues for quite some time to get any sense of a backlog. [20:37:47] dwisehaupt: ok thanks [20:38:48] there is another low volume test starting on the 22nd so there may be a decent chance then. [20:39:10] next 100% test isn't until the 1st. [20:40:39] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10Ejegg) I did a search for donations in Civi tagged with gateway braintree and non-USD. These additional CIDs came up: 56622468 56622799 51202551 35973901 54657717 All were CNY c... [20:45:09] ejegg|away looks like there may be a discrepancy but the submethod level countries for me is flattened int => country_code [20:46:05] is this what you have too? https://i.imgur.com/7BaSZSL.png [20:54:35] for braintree disable other currencies, could we update the currencies.yaml first, to make it only contains USD? [20:56:52] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10AnnWF) Yeah, we can do the refund from braintree console, and at the same time should we update our braintree_gateway/config/currencies.yaml to only USD until multi-currency is... [21:05:36] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10EMartin) {F35477273}. @MBeat33 I see the transaction in the Braintree console. Shall I refund it? [21:21:11] (03PS3) 10Wfan: Pass merchantAccountId with currency to support multi currencies [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) [21:22:00] (03CR) 10CI reject: [V: 04-1] Pass merchantAccountId with currency to support multi currencies [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [21:46:25] damilare: is that maybe the restriction in payment_method.yaml ? [21:47:17] yes those are the countries for the paypal submethod in braintree payment_methods.yaml [21:47:47] the one in payment_submethods looks like this: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/ingenico_gateway/config/payment_submethods.yaml$31 [21:48:03] so for that I had to use the empty() function rather than in_array [21:48:21] since empty() will test for the key being missing, or the key being there but the value being false [21:49:31] wfan for braintree I think we can use the fallbackCurrency logic [21:50:50] Ohh ok [21:51:02] oh sorry, wfan you meant to just set currencies.yaml to USD-only just as a temporary safety measure [21:51:04] In that case not all gateways have that file [21:51:06] yes, that would be a good idea [21:51:15] damilare: right, I think amazon doesn [21:51:16] 't [21:51:22] and maybe braintree doesn't either [21:51:39] just ones with second-level methods [21:51:40] neither does Braintree and Paypal [21:52:04] ohh ok I see what you mean [21:52:32] right, makes sense. that file is mostly used to determine which logo buttons to show on forms [21:52:44] at least, it's used that way under Ingenico and DLocal [22:00:28] 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10Ejegg) I just refunded the biggest one, at $745.68 for CID 56622468. It showed a success status after the refund, but when I search transactions in the Braintree console it stil... [22:14:44] for reference on the queue backups and speed, here is the queue backlog of the last 4 tests: https://w.wiki/5azW [22:15:08] not related to the current ubn work but just putting here for information. [22:19:39] ejegg: sorry for delay, finally getting to this :) [22:19:51] no worries AndyRussG [22:20:44] (03CR) 10Damilare Adedoyin: [C: 03+1] "Thanks for catching this, tested and works fine. +1ing because of the unresolved comment from AndyRussG" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 (owner: 10Ejegg) [22:20:46] ejegg: thx :) [22:21:14] ah also thx damilare :) [22:23:22] np AndyRussG [22:26:03] (03CR) 10AndyRussG: GatewayChooser: fix submethod support check (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 (owner: 10Ejegg) [22:30:01] i managed to rework that to be the last 5 tests. [22:40:22] dwisehaupt: so what my performance testing tells me is that if we can identify & eliminate frequent 'GET' calls to redis it helps. If I could do redis-cli monitor |grep GET then that would find those but not those prev next cache ones which use a different access call. - but I can't do that without putting the password on the command line - I'm wondering if we could have a wrapper like we do for drush (or just a [22:40:22] log output to grep but that seems like a lot ) - I'm really looking for things that are called more than once per batch job [23:01:40] hmmmm... thinking about this. [23:03:02] ejegg: I am still not fully groking what happened in the previous patch, what the intention was behind the change in that part of the codein the previous patch, how that was different from before, and how this was causing issues... where were were sending payment submethod params? [23:03:11] also ahhhh I have to run again in a sec [23:03:15] or a few I should say [23:16:56] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Investigate Redis speed - https://phabricator.wikimedia.org/T314619 (10Eileenmcnaughton) I've logged this https://lab.civicrm.org/dev/core/-/issues/3813 - [23:17:20] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Investigate queue consumer slowdown in pretest of July 13 2022 - https://phabricator.wikimedia.org/T313000 (10Eileenmcnaughton) Regarding r... [23:22:14] ejegg I'll for sure look more later ofc [23:22:37] maybe my brain will work better then ;p