[00:26:40] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Figure out command-safe way to call `redis-cli - https://phabricator.wikimedia.org/T315629 (10Eileenmcnaughton) [01:14:04] (03PS4) 10Wfan: Pass merchantAccountId with currency to support multi currencies [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) [01:14:55] (03CR) 10CI reject: [V: 04-1] Pass merchantAccountId with currency to support multi currencies [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [01:15:43] (03PS5) 10Wfan: Pass merchantAccountId with currency to support multi currencies [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) [01:16:23] (03PS6) 10Wfan: Pass merchantAccountId with currency to support multi currencies [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) [02:01:43] (03PS1) 10Ejegg: Change API call to look up tokens [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/824581 (https://phabricator.wikimedia.org/T315031) [02:06:09] wfan ^^^ might be the way to get those iDEAL recurring tokens [02:06:24] according to that email we got back from adyen support [02:07:03] Ha, nice, will take a look~ thanks so much [02:11:35] is that possible to make ideal donation locally? [02:12:03] wfan yep, we can make test iDEAL donations [02:12:53] https://docs.adyen.com/development-resources/testing/test-card-numbers#ideal [02:13:02] oh hmm [02:13:06] ha, I see, we do not even need test card for this [02:13:30] right right, you just choose the bank you want depending on the result code you want back [02:15:58] hmm, docker@smashpig:/srv/smashpig$ php PaymentProviders/Adyen/Maintenance/TestGetPaymentToken.php --pcid=25392491.1 [02:15:58] 2022-08-19T02:14:56+00:00 [INFO ] {SmashPig-Adyen-TestGetPaymentToken::SPCID-1194083897} Initiating cURL [02:15:58] 2022-08-19T02:14:56+00:00 [INFO ] {SmashPig-Adyen-TestGetPaymentToken::SPCID-1194083897} Preparing to send POST request to https://pal-test.adyen.com/pal/servlet/Payment/v67/listRecurringDetails [02:15:58] 2022-08-19T02:14:57+00:00 [ERROR ] {SmashPig-Adyen-TestGetPaymentToken::SPCID-1194083897} Request returned http status (404): 701 Method listRecurringDetails not found in PaymentService [02:15:58] sh: 1: /usr/sbin/sendmail: not found [02:15:59] 2022-08-19T02:14:57+00:00 [WARNING] {SmashPig-Adyen-TestGetPaymentToken::SPCID-1194083897} Could not send email to fr-tech-failmail@wikimedia.org. PHP Mailer had exception. [02:15:59] PHPMailer\PHPMailer\Exception@/srv/smashpig/vendor/phpmailer/phpmailer/src/PHPMailer.php:1763 (Could not execute: /usr/sbin/sendmail -t -i) [02:16:00] 2022-08-19T02:14:57+00:00 [ALERT ] {SmashPig-Adyen-TestGetPaymentToken::SPCID-1194083897} Last chance exception handler fired. [02:16:00] SmashPig\Core\ApiException@/srv/smashpig/PaymentProviders/Adyen/ExceptionMapper.php:321 (No response or malformed JSON) [02:16:23] oh oops, i think i forgot to commit one thing [02:17:11] (03PS2) 10Ejegg: Change API call to look up tokens [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/824581 (https://phabricator.wikimedia.org/T315031) [02:17:16] ok wfan ^^^ should work [02:18:26] wow, yep works like a charm~ [02:18:38] (03CR) 10Ejegg: [C: 04-1] "The logic for setting looks good, but I really think we need to return a validation error when the caller sends a currency which is not su" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [02:18:46] great! [02:18:58] Oh I thought the validation error is return by the curerncies.yaml? [02:20:40] wfan that might work from DonationInterface, but we should guard against any configuration errors. For example recurring donations that are charged by the back end won't have that additional layer of validation [02:21:19] and if someone deletes a currency from the account map in the SmashPig config, we would silently start charging people a very different amount than they expected [02:22:48] I see, let me find other validation error examples from smashpig see how would this one works~ [02:23:27] so since you are doing the mapping inside a helper function, that helper function should throw an exception [02:24:53] and the function which calls it should return the appropriate response type with isSuccessful set to false, and with a validation error added using ->addValidationError( new ValidationError( 'currency' ) ) [02:29:29] Ha, I see we have this validation error other places, ok~ and do you want me to plus 2 the ideal ticket? I might want to take a look again tomorrow just try to understand all the change at API class, and then plus 2 if we are not deploy soon. [02:29:47] wfan that can wait till tomorrow [02:29:52] ok thanks~ [02:29:53] I wouldn't try to deploy tonight [02:30:53] haha ok [02:53:50] (03PS2) 10Ejegg: Adyen: Don't failmail on 500 status with errorCode [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/823270 (https://phabricator.wikimedia.org/T313069) [02:54:08] ok wfan I managed to get a test to assert whether or not an error has been logged ^^^ [02:54:15] (03CR) 10CI reject: [V: 04-1] Adyen: Don't failmail on 500 status with errorCode [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/823270 (https://phabricator.wikimedia.org/T313069) (owner: 10Ejegg) [02:54:19] boo [02:55:07] haha style error [02:55:31] (03PS3) 10Ejegg: Adyen: Don't failmail on 500 status with errorCode [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/823270 (https://phabricator.wikimedia.org/T313069) [05:11:47] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10AndyRussG) [05:15:17] (03PS7) 10Wfan: Pass merchantAccountId with currency to support multi currencies [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) [07:36:17] (03CR) 10AndyRussG: "hiiii thanks so much for this! pls see inline for some notes about possible new Phab tasks and improvements to the all-powerful commit mes" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 (owner: 10Ejegg) [07:43:50] (03CR) 10AndyRussG: "ahhh apologies, I should have first read the end-of-week e-mail, @ejegg... that would have helped a lot... thx again!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 (owner: 10Ejegg) [08:33:55] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Pick a CRM donation management software system for the F2F campaign 2022 - https://phabricator.wikimedia.org/T281683 (10Jopparn) >>! In T281683#7920254, @Jenny_Brandt_WMSE wrote: > Checklist CRM - subtasks will be created @Jenny_... [14:57:46] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Pick a CRM donation management software system for the F2F campaign 2022 - https://phabricator.wikimedia.org/T281683 (10Jenny_Brandt_WMSE) [] Create an [[ https://docs.google.com/document/d/1BqAvYq8CSeofck5ioPQ0ws-K-9-pubzCueC-DAPZ... [16:15:19] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10SHust) @Ejegg Can you please let us know when the refund for the donor with cid=3597390, goes through so we can let him kno... [16:18:59] (03CR) 10Wfan: [C: 03+2] "Looks good, thanks for the test case 😊" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/823270 (https://phabricator.wikimedia.org/T313069) (owner: 10Ejegg) [16:19:32] (03Merged) 10jenkins-bot: Adyen: Don't failmail on 500 status with errorCode [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/823270 (https://phabricator.wikimedia.org/T313069) (owner: 10Ejegg) [16:25:33] (03Abandoned) 10Damilare Adedoyin: add missing paypal countries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/823203 (owner: 10Damilare Adedoyin) [16:41:46] 10Fundraising Tech - Chaos Crew: Ensure only paypal supported countries are processed by Braintree - https://phabricator.wikimedia.org/T315684 (10Damilare) [16:42:11] (03PS5) 10Damilare Adedoyin: GatewayChooser: fix submethod support check [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 (https://phabricator.wikimedia.org/T315684) (owner: 10Ejegg) [16:47:00] 10Fundraising Tech - Chaos Crew, 10Patch-For-Review: Ensure only paypal supported countries are processed by Braintree - https://phabricator.wikimedia.org/T315684 (10Damilare) Initial commit: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/820161/6 [18:59:24] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10AnnWF) >>! In T315592#8169556, @SHust wrote: > @Ejegg Can you please let us know when the refund for the donor with cid=359... [19:03:52] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10AnnWF) >>! In T315592#8167450, @Ejegg wrote: > I just refunded the biggest one, at $745.68 for CID 56622468. It showed a su... [20:16:34] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10fr-donorservices: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10SHust) Thank you @Ejegg and @AnnWF :) [22:32:50] (03CR) 10Wfan: "It works well, just some concern 😊" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/824581 (https://phabricator.wikimedia.org/T315031) (owner: 10Ejegg)