[04:39:08] (03PS6) 10AndyRussG: GatewayChooser: fix submethod support check [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 (https://phabricator.wikimedia.org/T315684) (owner: 10Ejegg) [08:49:53] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/825124 (owner: 10L10n-bot) [09:33:36] 10Fundraising-Backlog, 10Data-Engineering, 10Event-Platform Value Stream, 10MediaWiki-extensions-EventLogging, and 2 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10phuedx) [11:02:55] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/825124 (owner: 10L10n-bot) [12:18:28] (03PS2) 10Damilare Adedoyin: WIP: Move donor to temp to allow multiple donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824806 (https://phabricator.wikimedia.org/T314681) [14:16:02] 10Fundraising-Backlog: Review Cadence of Audit Files for Manually settled Adyen Donations - https://phabricator.wikimedia.org/T314753 (10RKumar_WMF) Adyen PSP 122781361.1 has still not come to Civi. There is one difference that I noticed is that it says it was "settled externally". The transaction was settled on... [14:36:49] hi fr-tech [14:39:23] heyyy ejegg fr-tech :) [14:51:18] hey fr-tech ejegg AndyRussG [14:51:34] :) [14:55:06] (03PS3) 10Ejegg: Change API call to look up tokens [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/824581 (https://phabricator.wikimedia.org/T315031) [15:01:51] (03PS4) 10Ejegg: Change API call to look up tokens [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/824581 (https://phabricator.wikimedia.org/T315031) [15:02:03] (03CR) 10Ejegg: Change API call to look up tokens (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/824581 (https://phabricator.wikimedia.org/T315031) (owner: 10Ejegg) [15:04:46] Thanks for clarifying that commit message AndyRussG ! [15:04:59] Is there any further code change needed to get that patch merged? [15:17:15] 10Fundraising Sprint Nyan cats for everyone, 10Fundraising Sprint Octopus hugs, 10Fundraising Sprint Pseudopretzels, 10Fundraising-Backlog: Process to transfer MG employers data file between civi1001 and frpm1001 - https://phabricator.wikimedia.org/T256825 (10Ejegg) a:05Ejegg→03None [15:17:34] 10Fundraising Sprint Nyan cats for everyone, 10Fundraising Sprint Octopus hugs, 10Fundraising Sprint Pseudopretzels, 10Fundraising-Backlog: Process to transfer MG employers data file between civi1001 and frpm1001 - https://phabricator.wikimedia.org/T256825 (10Ejegg) 05Open→03Resolved a:03Ejegg [15:18:54] ejegg: code seems fine to me! also damilare made a linked bug [15:18:59] 10Fundraising Sprint Lazy Loading Life, 10Fundraising Sprint MySQL is YourSQL and WeSQL, 10Fundraising-Backlog: Flowchart all incoming data from non fundraising sources - https://phabricator.wikimedia.org/T254783 (10Ejegg) a:05Ejegg→03None [15:19:02] I haven't smoke tested but damilare did [15:19:20] (I think u mentioned that in a comment, no?) [15:19:36] I smoketested locally too [15:19:41] ah cool beans [15:19:45] at least for iDEAL [15:20:01] ejegg: I didn't understand what the iDEAL issue was [15:20:31] if it's at all worth documenting, maybe some additional details could be explained in comments on the linked bug? or would that be another one? [15:21:23] my (probably wrong) understanding was that all this was done along the way as part of fixing the form chooser to not send people to Braintree [15:21:26] *gateway chooser [15:22:37] ejegg: I think the iDEAL issue that was as described in your end-of-week e-mail ("I tried deploying the method-level country restrictions I wrote at the end of last sprint, but those had a bug that stopped iDEAL donors at the GatewayChooser") and [15:23:27] (03CR) 10Ejegg: "Thanks for putting the validation error logic in there! Just one question about how you decided to indicate the error to the calling funct" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [15:24:20] ...and no this other iDEAL one https://phabricator.wikimedia.org/T292271 , or some other extant iDEAL bug that I'm not finding? [15:24:45] AndyRussG: yes, exactly, when I deployed last week's gatewayChooser patches, I saw three iDEAL donors get stopped at the gateway chooser and given the 'no form found' error [15:24:59] so i rolled back [15:25:12] there was never a phab filed for the iDEAL bug [15:25:19] since the code was only deployed for three minutes [15:25:51] ejegg: ok probably not worth a phab task, but maybe a note on the task already linked to that last unmerged patch? [15:26:17] I had just been trying to find out what the actual goals of all the patches were, to understand if they would or wouldn't have the expected effect [15:26:58] So the goal of the original patch was to allow us to turn braintree back on without anyone being sent there via the gateway chooser [15:27:46] also didn't know if the change in the preceding one was just to fix an issue that was randomly noticed in the way we were traversing the hierarchy (a level was missing) or if it was actually having an effect [15:27:53] while working on that, I saw an error in the logic for the submethod country restrictions (looking at the 'countries' key directly under the 'submethods' key when it needed to be a level down, under the individual submethod) [15:28:10] yeah... but was that impacting anything? [15:28:21] just a point of curiosity now though [15:28:23] AndyRussG: it was routing non-NL donors to rtbt [15:28:34] oh I see [15:28:34] We may indeed want to allow that [15:28:50] but we should put the allowed countries in the rtbt countries list if so [15:29:01] but that wasn't happening before the method-level country restrictions went out? [15:29:22] yes, it was happening ever since the gateway chooser refactor [15:29:56] previously the FormChooser settings were restricting rtbt to just NL donors [15:30:31] hmmm oki so maybe that does deserve a bug all its own? [15:30:31] I just saw the error when I was working on the code a few lines up [15:30:40] right yeah nice catch! [15:30:41] OK [15:30:53] sorry to be so complain-y about paperwork btw [15:31:52] making the phab now [15:33:38] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Gateway Chooser not checking submethod country restrictions correctly - https://phabricator.wikimedia.org/T315899 (10Ejegg) [15:34:01] (03CR) 10Ejegg: "Related phab: T315899" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/823683 (owner: 10Ejegg) [15:35:43] (03PS7) 10Ejegg: GatewayChooser: fix submethod support check [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 (https://phabricator.wikimedia.org/T315899) [15:35:51] ok, retagged ^^ [15:40:31] ejegg: I had created this phab for the initial merged commit https://phabricator.wikimedia.org/T315684 [15:41:15] and tagged the new unmerged one to the same tag as I thought the ideal bug was due to the initial merge [15:47:53] damilare: ahhh heheh it's definitely complicated eh :) [15:48:43] ejegg: on https://phabricator.wikimedia.org/T315899 can we document that since the Gateway chooser was deployed, donors from other countries have still been able to get to iDEAL via the gateway chooser? [15:49:38] something that could come into play here is the CentralNotice cookie duration--sometimes people move about but get targeted by banners for a country they were but no longer are in, especially if they don't clear out their browser sessions [15:50:49] https://phabricator.wikimedia.org/T315899 [15:51:43] also ejegg what was the 3-minute issue you saw when you deployed? that's what was in your end-of-week e-mail? how was that related to T315899 ? [15:51:44] T315899: Gateway Chooser not checking submethod country restrictions correctly - https://phabricator.wikimedia.org/T315899 [15:52:01] and/or to T315684 ? [15:52:02] T315684: Ensure only paypal supported countries are processed by Braintree - https://phabricator.wikimedia.org/T315684 [15:55:15] thanks for that other bug damilare! [15:55:47] right, so the only patch related to your bug was the one you linked in the phab comment [15:56:04] no p [15:56:15] (03CR) 10Ejegg: "Related phab task: T315684" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/820161 (owner: 10Ejegg) [15:56:37] (just making the link bidirectional) [15:59:30] 10fundraising-tech-ops: Install and configure new host frlog1002 - https://phabricator.wikimedia.org/T312581 (10Jgreen) [15:59:41] AndyRussG: the three minutes was I think how long I left the bad code deployed before I rolled back [16:03:34] ejegg: right so was that 3-minute bad effect also due to the same error in the code that was sending non-NL donors to iDEAL (i.e., incorrect traversal of the data structure when checking submethod country restrictions)? just to understand specifically what that bad effect was and what caused it [16:03:47] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Gateway Chooser not checking submethod country restrictions correctly - https://phabricator.wikimedia.org/T315899 (10Ejegg) [16:03:57] it doesn't have to be a separate bug, I just don't understand what happened, that's all [16:04:12] AndyRussG: the original issue was that we were effectively never checking country restrictions at a submethod level [16:04:27] right [16:04:40] that's T315899 [16:04:40] T315899: Gateway Chooser not checking submethod country restrictions correctly - https://phabricator.wikimedia.org/T315899 [16:04:48] the bug in the attempt to fix that was the use of in_array() [16:05:04] which always returns false when searching for a scalar key [16:05:08] ejegg: ahhh oki I see [16:05:13] in an array whose values are associative arrays [16:05:40] so in_array( 'IN', ['IN' => true] ) == false [16:05:57] though in_array( 'IN', ['IN'] ) is of course true [16:05:57] yes [16:06:04] aka, in-array checks for values, not keys [16:06:30] so the 3-minute prod badness was not at all due to any bugs in the code to prevent Braintree donors from going through, correct? [16:06:43] and really not at all related to that, right? [16:06:57] no, that's why in my end-of-day email I said you could just revert the second patch [16:07:00] the first patch was OK [16:07:55] I just thought I could get the fix for the other patch out within say the hour, so I didn't bother with the phab overhead at first [16:08:08] then when I had to head out I just had time to explain it in the email [16:08:34] right... I think part of the confusion then was that folks thought the patch to fix T315899 was actually to fix T315684 [16:08:35] T315684: Ensure only paypal supported countries are processed by Braintree - https://phabricator.wikimedia.org/T315684 [16:08:38] damilare: ^ [16:10:05] (or at least folks thought it was somehow related to T315684, fixing an issue in the patch for that one) [16:10:34] ok, do you think we can get it merged and deployed before standup? [16:10:43] it's ok and many apologies for making a fuss about paperwork again [16:10:46] I'd like to re-enable braintree for more testing if possible? [16:11:03] ejegg: yeah I'm down for whatever order of +2'ing folks would like [16:11:04] err, strike that '?' [16:11:15] AndyRussG: there's just one outstanding patch to +2 [16:11:27] right [16:11:42] https://gerrit.wikimedia.org/r/824549 [16:11:46] I mean, order of formal approval about the bits different people contributed to it [16:12:08] ejegg: so if you're OK with the changes to the commit message that you didn't make, then I can +2 [16:12:14] (03CR) 10Ejegg: [C: 03+1] "Message fix looks good" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 (https://phabricator.wikimedia.org/T315899) (owner: 10Ejegg) [16:12:16] damilare: also would you be ok with that ^ ? [16:13:14] yep looks good to me [16:14:10] (03CR) 10Damilare Adedoyin: [C: 03+1] GatewayChooser: fix submethod support check [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 (https://phabricator.wikimedia.org/T315899) (owner: 10Ejegg) [16:17:40] yay thx so much damilare and ejegg :) [16:18:57] (03CR) 10AndyRussG: [C: 03+2] "thanks cooool yaaaaaaaaayyyyyyyyyyyyyyyyyyy :) :) :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 (https://phabricator.wikimedia.org/T315899) (owner: 10Ejegg) [16:21:32] (03Merged) 10jenkins-bot: GatewayChooser: fix submethod support check [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824549 (https://phabricator.wikimedia.org/T315899) (owner: 10Ejegg) [16:22:57] ejegg: damilare: would it fall to DRI team, so damilare or jgleeson|away, to do such a deploy maybe.......? [16:23:22] well I could do a deploy if we are all set [16:25:03] sure, sounds good [16:25:35] damilare: the one twist is that you will have to specify -p payments-wiki=head [16:25:41] when you run fundraising-code-update [16:25:56] ohh ok, why's that? [16:26:07] When I last ran it with -p payments-wiki=rollback, it 'locked' the revision [16:26:20] since rollback is usually because the code was bad [16:26:39] the deploy script will prevent you from accidentally deploying the bad code again [16:27:08] ohh ok [16:27:32] thanks for this, would have gotten stuck there [16:29:57] heh yeah I only learned about that detail recently also [16:30:23] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/825378 [16:31:02] also thx damilare :) [16:31:03] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10FR-Braintree-Integration: Update PayPal IPN listener to mark Braintree donations with correct gateway and txn_id - https://phabricator.wikimedia.org/T315370 (10Ejegg) a:03Ejegg [16:31:30] (03CR) 10Damilare Adedoyin: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/825378 (owner: 10Damilare Adedoyin) [16:46:10] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/825378 (owner: 10Damilare Adedoyin) [16:47:43] I find a bug maybe? https://payments.wikimedia.org/index.php?title=Special:AdyenCheckoutGateway&appeal=JimmyQuote&country=US¤cy=OOO&payment_method=cc&recurring=0&uselang=en&amount=5&utm_medium=spontaneous&utm_campaign=spontaneous&utm_source=fr-redir.default~default~default~default~control.cc&utm_key=vw_1643~vh_796~otherAmt_0~time_3 for any currency not valid at all, like this link, we do not warn donor this will be made in USD [16:48:09] (03PS1) 10Damilare Adedoyin: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/825379 [16:48:46] I believe that we do want to warn folks that currency OOO is not valid right? [16:51:04] oh interesting wfan [16:51:30] if I try that link with a valid-but-not-supported currency code like EEK, it shows the 'please select a valid currency' error [16:51:46] so I think we would want that same behavior for a completely nonsense currency code [16:52:38] yep, I believe so, thanks~ [16:59:44] (03CR) 10Damilare Adedoyin: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/825379 (owner: 10Damilare Adedoyin) [17:09:04] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/825379 (owner: 10Damilare Adedoyin) [17:13:56] 10Fundraising-Backlog, 10fr-donorservices: Donations appearing in Civi but not Adyen - https://phabricator.wikimedia.org/T315487 (10AMJohnson) Have come across another instance. **ZenDesk ticket: **1152875 **Donor CID:** 6-8-2-7-0-2-8 **Donor comment:** "Thank you for your thanks, but this one is not yet appr... [17:15:01] !log payments-wiki upgraded from f9f91f1f to fb50c013 [17:15:03] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:15:51] deployment completed [17:16:22] Darn, Im not seeing the Braintree ID anywhere in the PayPal IPN message. T315370 might not be workable [17:16:22] T315370: Update PayPal IPN listener to mark Braintree donations with correct gateway and txn_id - https://phabricator.wikimedia.org/T315370 [17:18:29] ejegg: Looks like the ideal links are working now ejegg. Tested with this https://payments.wikimedia.org/index.php?title=Special:AdyenCheckoutGateway&appeal=JimmyQuote&payment_method=rtbt&payment_submethod=rtbt_ideal&recurring=0&uselang=en&language=en¤cy=EUR&amount=2&country=NL [17:18:37] great damilare ! [17:19:07] is there any other thing we'd like to test? [17:21:24] I think that's fine [17:21:30] let's just tail the logs for a bit [17:21:35] to see if any errors show up [17:23:25] cool [17:36:59] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.39-notes (1.39.0-wmf.26; 2022-08-22): Gateway Chooser not checking submethod country restrictions correctly - https://phabricator.wikimedia.org/T315899 (10AndyRussG) [17:37:21] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.39-notes (1.39.0-wmf.26; 2022-08-22): Gateway Chooser not checking submethod country restrictions correctly - https://phabricator.wikimedia.org/T315899 (10AndyRussG) Thanks so much fo... [18:39:50] (03PS3) 10Damilare Adedoyin: Backup Donor session to allow additional donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824806 (https://phabricator.wikimedia.org/T314681) [18:41:08] (03PS4) 10Damilare Adedoyin: Backup Donor session to allow additional donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824806 (https://phabricator.wikimedia.org/T314681) [18:43:19] (03PS5) 10Damilare Adedoyin: Backup Donor session to allow additional donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824806 (https://phabricator.wikimedia.org/T314681) [18:43:45] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10FR-Braintree-Integration: Update PayPal IPN listener to mark Braintree donations with correct gateway and txn_id - https://phabricator.wikimedia.org/T315370 (10Ejegg) Oops, this may be impossible after all. I'm not finding either th... [18:45:51] 10Fundraising-Backlog: Braintree audit parse refund not working properly - https://phabricator.wikimedia.org/T315921 (10AnnWF) [18:49:49] (03PS6) 10Damilare Adedoyin: Backup Donor session to allow additional donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824806 (https://phabricator.wikimedia.org/T314681) [18:53:55] ejegg: if you have some bandwidth, please can you review and drop some comments ^ [18:55:41] ok, will do [18:55:58] thanks [19:05:11] (03CR) 10Damilare Adedoyin: [C: 03+2] Option for queue push to fall back to db [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/821320 (https://phabricator.wikimedia.org/T314805) (owner: 10Ejegg) [19:05:44] (03Merged) 10jenkins-bot: Option for queue push to fall back to db [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/821320 (https://phabricator.wikimedia.org/T314805) (owner: 10Ejegg) [19:07:24] 10fundraising-tech-ops, 10Patch-For-Review: Install and configure new host frlog1002 - https://phabricator.wikimedia.org/T312581 (10Jgreen) [19:10:14] 10fundraising-tech-ops, 10Patch-For-Review: Install and configure new host frlog1002 - https://phabricator.wikimedia.org/T312581 (10Jgreen) [19:10:46] 10fundraising-tech-ops, 10Patch-For-Review: Install and configure new host frlog1002 - https://phabricator.wikimedia.org/T312581 (10Jgreen) 05Open→03Resolved p:05Triage→03Medium Done! [19:22:15] (03CR) 10Ejegg: "This approach looks like it should work. Some suggestions inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824806 (https://phabricator.wikimedia.org/T314681) (owner: 10Damilare Adedoyin) [19:23:27] fr-tech civi / buildkit / civicrm repo currently in a state able to successfully rebuild Civi locally, as far as anyone knows? [19:23:45] AndyRussG: it should be! [19:24:03] We fixed the little buildkit bug that was breaking CI a week or two ago [19:25:57] fr-tech I'll be a little late for the meeting [19:27:06] thx ejegg :) [19:44:54] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Search kit question - https://phabricator.wikimedia.org/T315376 (10XenoRyet) 05Open→03Resolved [19:47:48] wfan: thanks for the code review on https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/824581 [19:49:09] (03CR) 10Wfan: [C: 03+2] Change API call to look up tokens [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/824581 (https://phabricator.wikimedia.org/T315031) (owner: 10Ejegg) [19:49:35] np, looks good now :) Thanks for this fix, saves a lot failmail haha [19:49:41] (03Merged) 10jenkins-bot: Change API call to look up tokens [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/824581 (https://phabricator.wikimedia.org/T315031) (owner: 10Ejegg) [19:49:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Donations appearing in Civi but not Adyen - https://phabricator.wikimedia.org/T315487 (10XenoRyet) [19:49:51] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Change source_type to be more specific - https://phabricator.wikimedia.org/T315390 (10XenoRyet) [19:49:53] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Name changes required for Ingenico 3S2.0 - https://phabricator.wikimedia.org/T312877 (10XenoRyet) [20:12:13] 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, 10Fundraising Sprint NaN is a Number, and 4 others: Create Braintree IPN Job Handler - https://phabricator.wikimedia.org/T314400 (10Dwisehaupt) [20:16:10] 10Fundraising-Backlog, 10Patch-For-Review: Civi emails and donations have different timestamps in the activities tab - https://phabricator.wikimedia.org/T313510 (10Dwisehaupt) [20:17:58] 10Fundraising-Backlog: Braintree audit parse refund not working properly - https://phabricator.wikimedia.org/T315921 (10Dwisehaupt) [20:20:07] 10Fundraising-Backlog, 10FR-Smashpig: When throttling failmail, send a count of suppressed emails with the next one sent. - https://phabricator.wikimedia.org/T315238 (10Eileenmcnaughton) I'm wondering if monolog would adds some support here [20:25:42] 10Fundraising-Backlog, 10FR-Smashpig: When throttling failmail, send a count of suppressed emails with the next one sent. - https://phabricator.wikimedia.org/T315238 (10Dwisehaupt) [20:31:56] hey damilare, wfan. looks like the highest priority ticket on the chaos crew board is https://phabricator.wikimedia.org/T315031 [20:32:11] in progress ticket* [20:32:32] wfan: I can see you reviewed some of cstone's work on that. is that one still not finished? [20:32:36] this just merged [20:32:55] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/824581 [20:33:21] ah nice. can that be moved over to done then do you think wfan [20:33:52] can move to pending deployment [20:34:25] looks like we done have a lane for that currently on the chaos board [20:34:32] i think we still need to create new smashpig version to make di get the latest one before deploy to production right~ [20:34:32] greg-g: can we add that? [20:34:55] XenoRyet: ^ [20:35:25] oh hey, looks like we all can. I just added one [20:36:33] There's a way to reorder the columns too, but I can't put my finger on it. [20:37:02] yeah took a min to find that. looks ok now [20:37:04] https://phabricator.wikimedia.org/project/board/6067/?order=priority [20:37:24] this looks good haha [20:37:26] Nice [20:41:39] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Donations appearing in Civi but not Adyen - https://phabricator.wikimedia.org/T315487 (10jgleeson) a:03jgleeson [20:46:02] fr-tech, looks like Elliott added a reminder in the calendar to 'Renew PayPal API certificate' this week. I don't see any tickets in the sprint for this so I'll add one now. [20:48:51] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Renew PayPal API certificate by September 25th 2022 - https://phabricator.wikimedia.org/T315931 (10jgleeson) [20:49:29] should we pull that into the chaos crew board? [20:51:06] XenoRyet: do you know who has a the admin paypal account now for wmf stuff ? [20:51:11] I think it used to be tle, tony [20:53:01] Elliott send a email about this PayPal admin account for me dami and Andy [20:53:15] I think it includes Jack too [20:53:47] yep it does [20:54:11] ah thanks I'll check it [20:54:18] And Julianne is on that from the latest reply email [20:55:11] Right Jack you are on the list at the request account email, since we are not sure if you have it or not :) [20:56:21] pretty sure I don't have it [20:56:34] I guess we can chase up Julianne on that [20:56:50] looks like once we get the cert, it needs handing over to ops [20:56:56] so the more lead time the better [20:57:10] I've put that ticket in the chaos crew backlog [20:58:13] Yea, that's a chaos crew thing for sure. [22:10:41] (03PS7) 10Damilare Adedoyin: Backup Donor session to allow additional donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824806 (https://phabricator.wikimedia.org/T314681) [22:35:23] (03PS8) 10Damilare Adedoyin: Backup Donor session to allow additional donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824806 (https://phabricator.wikimedia.org/T314681) [22:37:00] (03PS9) 10Damilare Adedoyin: Backup Donor session to allow additional donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824806 (https://phabricator.wikimedia.org/T314681) [22:40:19] (03CR) 10CI reject: [V: 04-1] Backup Donor session to allow additional donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824806 (https://phabricator.wikimedia.org/T314681) (owner: 10Damilare Adedoyin) [22:41:58] (03PS10) 10Damilare Adedoyin: Backup Donor session to allow additional donations [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824806 (https://phabricator.wikimedia.org/T314681) [22:45:28] (03CR) 10Damilare Adedoyin: Backup Donor session to allow additional donations (035 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/824806 (https://phabricator.wikimedia.org/T314681) (owner: 10Damilare Adedoyin) [23:08:01] TopLoveAnn1314! [23:08:35] 😅 [23:08:40] wrong stuff here