[00:34:42] (03PS1) 10Ejegg: Don't push iDEAL donations from the front end [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/827606 (https://phabricator.wikimedia.org/T315487) [00:35:05] cstone: thanks! I had forgotten all about the offers console [00:35:33] so the three iDEAL donations since the debug logging started are all showing as completed payments at Adyen [00:36:13] but I think ^^^ will be the fix if as suspected we are getting the 'Authorized' status at the front-end for things that later fail [00:37:16] so far all the good ones seem to get the IPN and the RecordPaymentCaptureJob, while the bad ones don't [00:37:30] (03CR) 10CI reject: [V: 04-1] Don't push iDEAL donations from the front end [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/827606 (https://phabricator.wikimedia.org/T315487) (owner: 10Ejegg) [00:38:16] oh hey, we have test coverage for that queue push! [00:38:23] i'll just update that test [00:41:28] heh, DBReadOnlyError when I run it locally [00:42:27] guess I have to disable that to run tests [00:59:17] (03PS2) 10Ejegg: Don't push iDEAL donations from the front end [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/827606 (https://phabricator.wikimedia.org/T315487) [01:00:52] took me a minute to realize why it wasn't sending it to the pending queue [01:00:55] in the test [01:01:19] it DOES send the pending queue message when you click the continue button in smoke tests [01:01:30] just not in the bit of code covered by that unit test [01:02:30] So this will prevent the authorized but not captured ideal donation right, code looks ok, just do not know how to test it. But since we got an test case and adyen ipn is reliable could plus 2, should I go that? [01:03:06] testing is annoying if you have a ton on the jobs adyen queue [01:03:26] i think we should test this locally cause we have no way to test it live [01:03:31] wfan maybe let's hold off for a sec? [01:03:53] yeah, I'm really curious to see a real txn logged in this state first [01:04:15] https://docs.adyen.com/payment-methods/ideal/api-only mentions there is a 'Received' state that is basically 'Pending' [01:04:21] I'm okay with +1 right now also curious if jack had any insight we are missing since we do have an extra day now [01:04:41] yeah, I'm also curious to hear from Jack [01:05:26] Sure, do we have folks from nl, then maybe we can make a code change for a sec and let someone so the regular ideal donation without actually pay to test the code? [01:06:17] ohhhh, maybe it IS the 'Received' thing [01:06:45] ok, new patch coming [01:07:11] wfan: you can test this with what we looked at earlier too, the recurring instructions tell you what way to run the queues just [01:07:24] you might need to clean out your jobs-adyen mine had like 200 old msgs in it [01:08:36] (03PS1) 10Ejegg: Fix mapping of 'Received' iDEAL status [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/827607 (https://phabricator.wikimedia.org/T315487) [01:08:52] cstone: ok, now i think that ^^^ is the real only change we need [01:09:00] I should have read the docs first! [01:09:44] The link in the commit message spells out which statuses you can trust to be 'done' [01:09:57] and we had 'Received' in the wrong place [01:10:46] (03CR) 10Ejegg: [C: 04-1] "Now I think this is wrong and Idff71fdb6c7f1079ef9224210099d92b57af304d is right." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/827606 (https://phabricator.wikimedia.org/T315487) (owner: 10Ejegg) [01:11:00] ah okay ejegg [01:11:03] Oh, so now we can ignore the first pr right? Still only prevent the recurring ideal donation and accept the second pr which is mark received as pending instead of complete. [01:11:10] well the old way was also working :P but htis is much more straightforwad [01:11:31] Ok great 😊 [01:16:43] i had vague memories of this before I guess I forgot about my comment about received when I +2d it like a month later -_- [01:17:46] pending got split out into its own group but received didn't get moved with it [01:18:06] ohh [01:19:00] so for card payments we're still mapping Received to complete - not sure if we ever get it there though [01:19:47] cstone: I guess you mean this patch? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/740709 [01:19:51] yeah [01:20:02] just for the redirect ones [01:20:35] yeah, i totally forgot writing that one [01:20:49] oh but for the card payments there are some in the offer_closed did you see those [01:20:53] visa debit cards [01:21:02] oh for real? [01:21:02] way less than ideal but I saw at least 2 [01:21:13] lemme look at the docs for those too [01:21:23] 128001518.1 is one [01:22:28] that might be a separate bug though? [01:24:57] lets see if i can rebuild a pending response [01:25:59] so their generic result code glossary is here: https://docs.adyen.com/online-payments/payment-result-codes [01:26:20] it says that Received "is part of the standard payment flow for methods such as SEPA Direct Debit, where it can take some time before the final status of the payment is known" [01:27:59] I don't remember what the flow does when it ends up pending is it waiting for the capture ipn or is it just kind of stuck there [01:28:05] our pending [01:28:23] cstone the IPN will get it to Civi [01:28:37] ok cool [01:28:54] the IPN listener files a RecordCaptureJob [01:28:58] I think this is safe enough of a change to +2 and see if it behaves everything looks fine locally [01:29:04] and that job sends the donation [01:29:24] thanks! [01:29:33] Yeah, I'd be happy to deploy this one even right now [01:29:49] since it's more compliant with the docs and since we have the backup path [01:30:59] (03CR) 10Cstone: [C: 03+2] "Looks good! Tested fine locally" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/827607 (https://phabricator.wikimedia.org/T315487) (owner: 10Ejegg) [01:31:31] (03Merged) 10jenkins-bot: Fix mapping of 'Received' iDEAL status [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/827607 (https://phabricator.wikimedia.org/T315487) (owner: 10Ejegg) [01:32:02] thanks cstone! [01:32:07] I'll tag the version [01:32:10] thanks ejegg [01:32:22] I'm gona go look for frogs with my sister but I'll be back in a few [01:32:25] I still really want to see one of those 'Received' statuses in the logs [01:32:31] hope you find a lot of frogs! [01:37:51] (03PS1) 10Ejegg: Update SmashPig lib [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/827608 [01:39:38] (03CR) 10Ejegg: [C: 03+2] Update SmashPig lib [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/827608 (owner: 10Ejegg) [01:41:40] (03Merged) 10jenkins-bot: Update SmashPig lib [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/827608 (owner: 10Ejegg) [01:42:22] (03PS1) 10Ejegg: Update SmashPig lib [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/827609 [01:42:24] (03CR) 10Ejegg: [C: 03+2] Update SmashPig lib [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/827609 (owner: 10Ejegg) [01:43:15] (03Merged) 10jenkins-bot: Update SmashPig lib [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/827609 (owner: 10Ejegg) [01:44:32] (03PS1) 10Ejegg: Update DonationInterface [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/827611 [01:44:35] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/827611 (owner: 10Ejegg) [01:46:38] Four frogs [01:55:40] (03Merged) 10jenkins-bot: Update DonationInterface [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/827611 (owner: 10Ejegg) [02:25:25] nice cstone [02:29:41] !log payments-wiki upgraded from dc6d899d to 80657b06 [02:29:44] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:33:35] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10Epic: [epic] Adyen - auto settle stopped prior donors (Pending transaction Resolver) - https://phabricator.wikimedia.org/T299692 (10AndyRussG) [02:40:06] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog: Adyen Pending Transaction Resolver: queries to evaluate impact - https://phabricator.wikimedia.org/T316616 (10AndyRussG) [02:43:18] 10Fundraising Sprint NaN is a Number, 10Fundraising-Backlog, 10Epic: [epic] Adyen - auto settle stopped prior donors (Pending transaction Resolver) - https://phabricator.wikimedia.org/T299692 (10AndyRussG) [02:43:28] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), 10Patch-For-Review: Donations appearing in Civi but not Adyen - https://phabricator.wikimedia.org/T315487 (10Ejegg) We found that we were incorrectly mapping one of the possible status... [02:43:32] (03PS1) 10Ejegg: Allow PayPal donations from China [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/827613 (https://phabricator.wikimedia.org/T315592) [03:04:39] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog: Review steps and create subtasks for Adyen Pending Transaction Resolver - https://phabricator.wikimedia.org/T316582 (10AndyRussG) Result of this task: other subtasks of T299692. [03:08:12] (03PS1) 10Ejegg: Adyen: use API idempotency header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/827615 (https://phabricator.wikimedia.org/T243967) [03:08:31] 10Fundraising-Backlog, 10FR-Smashpig, 10Patch-For-Review: Use idempotency headers in payment processing requests - https://phabricator.wikimedia.org/T243967 (10Ejegg) This will help if we're worried that we are charging duplicates when we get a timeout making an API call and automatically retry. This will N... [03:08:40] (03CR) 10CI reject: [V: 04-1] Adyen: use API idempotency header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/827615 (https://phabricator.wikimedia.org/T243967) (owner: 10Ejegg) [03:25:00] (03PS2) 10Ejegg: Adyen: use API idempotency header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/827615 (https://phabricator.wikimedia.org/T243967) [03:25:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Adyen duplicate donations after donors see error message - August 2022 - https://phabricator.wikimedia.org/T316157 (10Ejegg) API Idempotency ticket: T243967 Related patch: https://gerrit.wikimedia.org/r/827615 [04:03:43] 10Fundraising Sprint NaN is a Number, 10Fundraising-Backlog, 10Epic: [epic] Adyen - auto settle stopped prior donors (Pending transaction Resolver) - https://phabricator.wikimedia.org/T299692 (10Ejegg) I was just going over the Adyen API and the Ingenico Pending Txn Resolver. Looks like this one will have t... [04:05:02] AndyRussG: ugh, i just remembered that adyen has no txn lookup calls in its API. So.... random idea for making the PTR still possible in that comment ^^^ [04:05:13] going to bed now, but maybe tomorrow we can chat [05:08:59] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_37) - 10https://gerrit.wikimedia.org/r/827686 (owner: 10L10n-bot) [06:38:19] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10netops: Upgrade fasw to Junos 21 - https://phabricator.wikimedia.org/T316542 (10ayounsi) @Dwisehaupt that will be too soon for us (SRE summit + routers upgrades planned this month). Is the following maintenance week known? [10:58:03] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/827064 (owner: 10L10n-bot) [11:13:44] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_37) - 10https://gerrit.wikimedia.org/r/827686 (owner: 10L10n-bot) [13:28:18] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Contact similar organisations ahead of F2F campaign - https://phabricator.wikimedia.org/T276054 (10Jopparn) 05Openβ†’03Resolved a:03Jopparn No info was shared. [13:28:20] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: β˜‚Fundraising campaign F2F 2021/2022 - https://phabricator.wikimedia.org/T275368 (10Jopparn) [13:34:24] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Prepare and participate in the Impact day event - https://phabricator.wikimedia.org/T292519 (10Jopparn) 05Openβ†’03Resolved a:03Jopparn [13:34:30] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Pick a CRM donation management software system for the F2F campaign 2022 - https://phabricator.wikimedia.org/T281683 (10Jopparn) [13:34:34] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: Salesforce trial period - https://phabricator.wikimedia.org/T308148 (10Jopparn) 05Openβ†’03Resolved a:03Jopparn [14:14:56] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), 10Patch-For-Review: Donations appearing in Civi but not Adyen - https://phabricator.wikimedia.org/T315487 (10jgleeson) >>! In T315487#8196715, @Cstone wrote: > You can see these in the... [15:24:22] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), 10Patch-For-Review: Donations appearing in Civi but not Adyen - https://phabricator.wikimedia.org/T315487 (10jgleeson) It looks like Adyen marks these transactions as OfferCancelled in... [15:31:09] 10Fundraising-Backlog: Adyen: Can we send name field on subsequent donations - https://phabricator.wikimedia.org/T316404 (10EMartin) From Adyen: If you want to get the name field in the API response, you can go to Developers > Additional Data > Enable the Cardholder Name field. If you would like to receive the... [15:33:32] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), 10Patch-For-Review: Donations appearing in Civi but not Adyen - https://phabricator.wikimedia.org/T315487 (10HNordeenWMF) Hi Jack, Christine and Elliott, thanks for all the work on thi... [15:38:16] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), 10Patch-For-Review: Donations appearing in Civi but not Adyen - https://phabricator.wikimedia.org/T315487 (10jgleeson) >>! In T315487#8199045, @HNordeenWMF wrote: > Hi Jack, Christine... [15:45:58] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), 10Patch-For-Review: Donations appearing in Civi but not Adyen - https://phabricator.wikimedia.org/T315487 (10jgleeson) Circling back on the numbers of affected donations. I tried runni... [16:35:09] (03PS2) 10Ejegg: Allow greeting processing on new contacts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824392 (https://phabricator.wikimedia.org/T308181) (owner: 10Eileen) [16:35:18] (03CR) 10Ejegg: [C: 03+2] "Let's give it a shot!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824392 (https://phabricator.wikimedia.org/T308181) (owner: 10Eileen) [16:43:39] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Adyen duplicate donations after donors see error message - August 2022 - https://phabricator.wikimedia.org/T316157 (10jgleeson) a:03jgleeson [16:44:10] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10donate.wikimedia.org: Broken links from Waystogive? - https://phabricator.wikimedia.org/T315268 (10jgleeson) a:05jgleesonβ†’03None [16:51:30] (03Merged) 10jenkins-bot: Allow greeting processing on new contacts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824392 (https://phabricator.wikimedia.org/T308181) (owner: 10Eileen) [16:52:10] 10Fundraising-Backlog: Pending Transaction Resolver Diagram - https://phabricator.wikimedia.org/T316684 (10jgleeson) [16:54:08] AndyRussG: ^^ just added that ticket as discussed. just gonna run an errand but once I get back I'll make a start on that. I did start friday but never got very far [16:54:22] jgleeson: thx! [16:56:10] 10Fundraising-Backlog: Pending Transaction Resolver Diagram - https://phabricator.wikimedia.org/T316684 (10AndyRussG) [16:56:12] 10Fundraising Sprint NaN is a Number, 10Fundraising-Backlog, 10Epic: [epic] Adyen - auto settle stopped prior donors (Pending transaction Resolver) - https://phabricator.wikimedia.org/T299692 (10AndyRussG) [16:56:41] 10Fundraising Sprint Nitpicking, 10Fundraising Sprint Octopus Untangling, 10Fundraising Sprint Pretending This Isn't Happening, 10Fundraising Sprint Technical debt house of horrors, and 6 others: Documentation: UML activity and sequence diagrams for all processors - https://phabricator.wikimedia.org/T141617... [16:56:43] 10Fundraising-Backlog: Adyen - UML sequence diagrams - https://phabricator.wikimedia.org/T316584 (10AndyRussG) [16:58:24] (03PS13) 10Wfan: Pass merchantAccountId with currency to support multi currencies [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) [17:03:29] (03PS3) 10Ejegg: Add upgrade script to removed unused prefix, suffix, language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824334 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen) [17:04:27] (03CR) 10Ejegg: [C: 03+2] "Looks good, works locally. Might delete a few built-in options on sparse dev installs, but shouldn't be any worry on production." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824334 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen) [17:19:36] nice, Asana email pushing the 4 day workweek [17:20:05] (03Merged) 10jenkins-bot: Add upgrade script to removed unused prefix, suffix, language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/824334 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen) [17:20:42] (03PS4) 10Ejegg: Contribution Recur trigger updates contact modified_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/826683 (https://phabricator.wikimedia.org/T293945) [17:30:53] ejegg: I didn't get that email so I decided to check my spam. what fun that was [17:31:00] a few phishing attempts [17:31:08] and then this [17:31:10] oh maybe it was just in Spanish [17:31:18] The International Criminal Court and The International Court of Justice: [17:31:20] I want to legally sue Wikimedia Foundation for discrimination. [17:31:22] There are biographies of characters with less creative talent than the talent I have, and my biography is not on wikipedia. That is discrimination, it has to be discrimination. [17:31:34] Example of characters with less creative talent compared to the creative talent I have: Steven Spielberg, Martin Scorsese Stanley Kubrick, Alfred Hitchcock, Quentin Tarantino ... [17:31:35] oof [17:31:42] Thank you, have a nice day [17:31:44] ^^ [17:32:15] that guy must have a lot of creative talent [17:32:51] I'm not sure if I'd put Tarantino in that bracket with the others mentioned [18:00:53] 10Fundraising Sprint NaN is a Number, 10Fundraising-Backlog, 10Epic: [epic] Adyen - auto settle stopped prior donors (Pending transaction Resolver) - https://phabricator.wikimedia.org/T299692 (10AndyRussG) Thanks for those notes, @Ejegg! See also [[ https://phabricator.wikimedia.org/T316616#8199825 | this co... [18:02:02] ejegg: ^ [18:15:37] 10Fundraising Tech - Chaos Crew, 10Release-Engineering-Team, 10GitLab (Project Migration): Create new GitLab project group: Fundraising-Tech - https://phabricator.wikimedia.org/T316695 (10jgleeson) [18:46:23] (03PS1) 10Damilare Adedoyin: WIP: Ingenico audit parser sending already-refunded donations to refund queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) [18:48:15] (03PS2) 10Damilare Adedoyin: WIP: Ingenico audit parser sending already-refunded donations to refund queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) [19:00:27] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-WMF-Audit, 10Patch-For-Review: Ingenico audit parser sending already-refunded donations to refund queue - https://phabricator.wikimedia.org/T312824 (10Damilare) a:03Damilare [19:06:16] (03CR) 10Jgleeson: [C: 03+2] "This is working well for me. Hopefully it'll stop a few dupes! thanks." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/827615 (https://phabricator.wikimedia.org/T243967) (owner: 10Ejegg) [19:06:35] 10Fundraising Sprint Machine Unlearning, 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, and 3 others: Don't send failmail on Adyen unsupported card - https://phabricator.wikimedia.org/T313069 (10XenoRyet) 05Openβ†’03Resolved [19:07:34] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog: Complete Adyen Checkout documentation to include donation statuses for all stages/permutations - https://phabricator.wikimedia.org/T316583 (10AndyRussG) Also adding some stuff here: https://wikitech.wikimedia.org/wiki/Fundraising/Data_a... [19:07:44] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Adyen duplicate donations after donors see error message - August 2022 - https://phabricator.wikimedia.org/T316157 (10jgleeson) I've +2ed the patch you submitted ejegg but before moving it to done, I want to dig into some of the exam... [19:08:45] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10XenoRyet) [19:09:21] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Donation Form Currency Issue PayPal USD/CNY - https://phabricator.wikimedia.org/T315592 (10XenoRyet) 05Openβ†’03Resolved [19:09:33] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog: Allow PayPal donations from CN - https://phabricator.wikimedia.org/T316703 (10Ejegg) [19:09:42] 10Fundraising Sprint Esperantoland, 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, and 17 others: Update Fundraising tech CI image to use upstream buildkit, no symlink for civ... - https://phabricator.wikimedia.org/T277500 [19:09:52] (03PS2) 10Ejegg: Allow PayPal donations from China [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/827613 (https://phabricator.wikimedia.org/T316703) [19:10:01] 10Fundraising Sprint Esperantoland, 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, and 19 others: Fix civicrm repo to be non-symlinked - https://phabricator.wikimedia.org/T289100 (10XenoRyet) 05Openβ†’03Resolved [19:10:29] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.39-notes (1.39.0-wmf.26; 2022-08-22): Gateway Chooser not checking submethod country restrictions correctly - https://phabricator.wikimedia.org/T315899 (10XenoRyet) 05Openβ†’03Resolv... [19:11:05] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Decommission Fundraising's crm/civicrm git repo - https://phabricator.wikimedia.org/T314995 (10XenoRyet) 05Openβ†’03Resolved [19:11:08] 10Fundraising Sprint Esperantoland, 10Fundraising Sprint File Systems Stage Show, 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, and 19 others: Fix civicrm repo to be non-symlinked - https://phabricator.wikimedia.org/T289100 (10XenoRyet) [19:12:51] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10donate.wikimedia.org, 10fr-donorservices, 10FR-Email: Donation Form Error Message - Country Detection - https://phabricator.wikimedia.org/T316578 (10XenoRyet) [19:14:22] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10Patch-For-Review: Allow PayPal donations from CN - https://phabricator.wikimedia.org/T316703 (10Ejegg) a:03Ejegg [19:14:33] (03CR) 10CI reject: [V: 04-1] WIP: Ingenico audit parser sending already-refunded donations to refund queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) (owner: 10Damilare Adedoyin) [19:15:15] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Investigate Redis speed - https://phabricator.wikimedia.org/T314619 (10XenoRyet) 05Openβ†’03Resolved [19:15:17] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Investigate queue consumer slowdown in pretest of July 13 2022 - https://phabricator.wikimedia.org/T313000 (10XenoRyet) [19:17:28] (03Merged) 10jenkins-bot: Adyen: use API idempotency header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/827615 (https://phabricator.wikimedia.org/T243967) (owner: 10Ejegg) [19:21:59] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10FR-Smashpig, 10Patch-For-Review: Use idempotency headers in payment processing requests - https://phabricator.wikimedia.org/T243967 (10Ejegg) p:05Triageβ†’03Medium a:03Ejegg [19:24:14] thanks for the cr jgleeson ! [19:45:48] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Decommission Fundraising's crm/civicrm git repo - https://phabricator.wikimedia.org/T314995 (10Aklapper) > archive the `crm\civicrm` repo **If** t... [19:50:00] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Last CiviCRM point update for the year - https://phabricator.wikimedia.org/T316713 (10Eileenmcnaughton) [19:50:56] 10Fundraising-Backlog, 10FR-Braintree-Integration: Migrate PayPal EC billing agreements to Braintree vault tokens - https://phabricator.wikimedia.org/T315371 (10Ejegg) [19:54:58] 10Fundraising-Backlog, 10fr-donorservices: Donor directed to "Thank You" page even though payment rejected - https://phabricator.wikimedia.org/T310383 (10Ejegg) Potentially related: T131401 [19:55:02] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Unit tests for Adyen Pending Transaction Resolver - https://phabricator.wikimedia.org/T316588 (10XenoRyet) [19:55:04] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Write code for Adyen Pending Transaction Resolver - https://phabricator.wikimedia.org/T316587 (10XenoRyet) [19:55:07] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Document how to test Adyen Pending Transaction Resolver locally - https://phabricator.wikimedia.org/T316585 (10XenoRyet) [19:57:36] 10Fundraising Sprint P 2022, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Last CiviCRM point update for the year - https://phabricator.wikimedia.org/T316713 (10XenoRyet) [19:57:41] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint P 2022, 10Fundraising-Backlog, 10Patch-For-Review: Allow PayPal donations from CN - https://phabricator.wikimedia.org/T316703 (10XenoRyet) [19:57:47] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint P 2022, 10Fundraising-Backlog: Complete Adyen Checkout documentation to include donation statuses for all stages/permutations - https://phabricator.wikimedia.org/T316583 (10XenoRyet) [19:57:49] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint P 2022, 10Fundraising-Backlog: Review steps and create subtasks for Adyen Pending Transaction Resolver - https://phabricator.wikimedia.org/T316582 (10XenoRyet) [19:57:51] 10Fundraising Sprint P 2022, 10Fundraising-Backlog: Adyen: Can we send name field on subsequent donations - https://phabricator.wikimedia.org/T316404 (10XenoRyet) [19:57:53] 10Fundraising Sprint P 2022, 10Fundraising-Backlog: Remaining campaign markets need Adyen set as default - https://phabricator.wikimedia.org/T316168 (10XenoRyet) [19:57:55] 10Fundraising Sprint P 2022, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Delete deleted contacts - lets get a bit more done pre BE - https://phabricator.wikimedia.org/T316059 (10XenoRyet) [19:57:57] 10Fundraising Sprint P 2022, 10Fundraising-Backlog, 10Epic: Upgrading payments-wiki from buster to bullseye - https://phabricator.wikimedia.org/T315585 (10XenoRyet) [19:58:02] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint P 2022, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Stop prolific doctor breeding - https://phabricator.wikimedia.org/T315509 (10XenoRyet) [19:58:07] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint P 2022, 10Fundraising-Backlog, 10FR-Braintree-Integration: Update PayPal IPN listener to mark Braintree donations with correct gateway and txn_id - https://phabricator.wikimedia.org/T315370 (10XenoRyet) [19:58:11] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint P 2022, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10Patch-For-Review: Paypal audit parser should drop Braintree-initiated donations - https://phabricator.wikimedia.org/T315258 (10XenoRyet) [19:58:19] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint P 2022, 10Fundraising-Backlog, 10Patch-For-Review: Custom field "AF_has_active_recurring_donation" is showing false positives - https://phabricator.wikimedia.org/T315102 (10XenoRyet) [19:58:25] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint P 2022, 10Fundraising-Backlog, 10FR-form-chooser-refactor: Document new gateway chooser logic and settings - https://phabricator.wikimedia.org/T315011 (10XenoRyet) [19:58:28] 10Fundraising Sprint P 2022, 10Fundraising-Backlog: Use nightly rather than weekly audit file for Adyen - https://phabricator.wikimedia.org/T314753 (10XenoRyet) [19:58:35] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint P 2022, 10Fundraising-Backlog, and 2 others: Investigate queue consumer slowdown in pretest of July 13 2022 - https://phabricator.wikimedia.org/T313000 (10XenoRyet) [19:58:42] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint P 2022, 10Fundraising-Backlog, and 3 others: Add multiple currency support to Braintree - https://phabricator.wikimedia.org/T312808 (10XenoRyet) [19:58:47] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint P 2022, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Get imports running in the background - https://phabricator.wikimedia.org/T312166 (10XenoRyet) [19:58:51] 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, 10Fundraising Sprint NaN is a Number, and 6 others: Implement Braintree Webhook signature validation - https://phabricator.wikimedia.org/T311169 (10XenoRyet) [19:58:56] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint P 2022, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Email Greeting Field in Civi - blank for some donors - https://phabricator.wikimedia.org/T308181 (10XenoRyet) [19:58:59] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint P 2022, 10Fundraising-Backlog, and 2 others: Creating New Matching Gift Import - https://phabricator.wikimedia.org/T303986 (10XenoRyet) [19:59:03] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint P 2022, 10Fundraising-Backlog, 10Epic: [epic] Adyen - auto settle stopped prior donors (Pending transaction Resolver) - https://phabricator.wikimedia.org/T299692 (10XenoRyet) [19:59:05] 10Fundraising Sprint P 2022, 10Fundraising-Backlog, 10FR-Adyen: Properly handle pending-poke with Adyen Checkout - https://phabricator.wikimedia.org/T299690 (10XenoRyet) [19:59:08] 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, and 4 others: configure endpoint monitoring for Braintree API hosts - https://phabricator.wikimedia.org/T311727 (10XenoRyet) [19:59:10] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint P 2022, 10Fundraising-Backlog, 10FR-Smashpig: Use idempotency headers in payment processing requests - https://phabricator.wikimedia.org/T243967 (10XenoRyet) [20:01:56] (03PS1) 10Umherirrender: build: Disable phan option scalar_implicit_cast and make pass [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/828082 (https://phabricator.wikimedia.org/T316575) [20:17:42] more Jeff Koons: https://publicdelivery.org/jeff-koons-balloon-dog/ [20:57:29] (03PS1) 10Ejegg: Set contribution_recur_id when token found [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828094 (https://phabricator.wikimedia.org/T315031) [21:11:32] (03CR) 10CI reject: [V: 04-1] Set contribution_recur_id when token found [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828094 (https://phabricator.wikimedia.org/T315031) (owner: 10Ejegg) [21:29:31] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts, 10Patch-For-Review: INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found failmail coming from the listener on ideal - https://phabricator.wikimedia.org/T315031 (10Ejegg) Ugh, we have a test that spec... [21:31:05] (03PS1) 10Eileen: Add upgrade script to removed unused prefix, suffix, language options [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/828097 (https://phabricator.wikimedia.org/T315509) [21:31:27] (03CR) 10Eileen: [C: 03+2] Add upgrade script to removed unused prefix, suffix, language options [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/828097 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen) [21:55:10] (03PS1) 10Eileen: Remove duplicated language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828100 (https://phabricator.wikimedia.org/T315509) [21:55:23] 10Fundraising Sprint Potato, 10Fundraising-Backlog: Adyen: Can we send name field on subsequent donations - https://phabricator.wikimedia.org/T316404 (10Cstone) a:03Cstone [21:57:00] (03PS1) 10Cstone: Add getContactInfo to createPaymentFromToken [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828101 (https://phabricator.wikimedia.org/T316404) [22:02:06] !log civicrm upgraded from a31c7590 to 76308ffb [22:02:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:21:16] (03PS1) 10Ejegg: Exclude Completed recurrings from has_recur [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/828105 (https://phabricator.wikimedia.org/T315102) [22:48:02] 10Fundraising-Backlog, 10fr-donorservices: Fix fake PayPal cancellations on the fly - https://phabricator.wikimedia.org/T242158 (10Ejegg) Let's do this task along with the work to cancel recurrings that haven't gotten any payments in a few months ( T315102 ) [22:48:17] (03CR) 10Cstone: [C: 03+2] "Looks good updated the contacts modified_date when tested" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/826683 (https://phabricator.wikimedia.org/T293945) (owner: 10Ejegg) [22:49:12] 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10fr-donorservices: Fix fake PayPal cancellations on the fly - https://phabricator.wikimedia.org/T242158 (10Ejegg) [22:49:42] 10fundraising-tech-ops: reimage fundraising frmx role servers to Bullseye - https://phabricator.wikimedia.org/T316725 (10Dwisehaupt) [23:01:01] (03Merged) 10jenkins-bot: Contribution Recur trigger updates contact modified_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/826683 (https://phabricator.wikimedia.org/T293945) (owner: 10Ejegg) [23:01:54] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts, 10Patch-For-Review: INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found failmail coming from the listener on ideal - https://phabricator.wikimedia.org/T315031 (10Ejegg) So we're doing a lot of work... [23:16:16] (03CR) 10Eileen: [C: 03+2] Exclude Completed recurrings from has_recur [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/828105 (https://phabricator.wikimedia.org/T315102) (owner: 10Ejegg) [23:18:09] (03Merged) 10jenkins-bot: Exclude Completed recurrings from has_recur [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/828105 (https://phabricator.wikimedia.org/T315102) (owner: 10Ejegg)