[00:00:08] 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10Patch-For-Review: Adyen: Can we send name field on subsequent donations - https://phabricator.wikimedia.org/T316404 (10EMartin) awesome! @Cstone Thank YOU!! [00:41:57] eileen: so.. If I want to add a new action to an existing API4 class, where do I put the static function? [00:42:25] I'm creating a new Civi\Api4\Action\ContributionRecur\CancelInactives class for the action [00:43:11] and I see for the other custom actions we have, we always create a matching Civi\Api4\WMFContact (e.g.) class to make a static function that returns a new instance of that action class [00:43:34] but for ContributionRecur, there already exists a Civi\Api4\ContributionRecur class [00:46:06] is it possible to attach new actions to an existing Api4 entity in an extension? [00:46:26] I'm not seeing it at https://docs.civicrm.org/dev/en/latest/api/v4/architecture/ [00:47:25] well, I see this "It is also possible to add other ad-hoc actions to any entity; e.g. Contact::getChecksum is an ad-hoc action added to the Contact entity." but not exactly how to do it [00:49:31] I guess maybe it's not possible, and I should invent a new 'InactiveRecurring' abstract entity to hang the new action on? [00:56:47] ooh, maybe via the magic __callStatic method on AbstractEntity? [00:59:32] yes! [01:16:05] 10Fundraising-Backlog, 10FR-Braintree-Integration: Handle HTTP errors setting up Braintree donation - https://phabricator.wikimedia.org/T316730 (10Ejegg) [01:31:19] weird, I can run it via the API4 explorer [01:31:26] but not via the commandline [01:32:16] oh, it works via cv but not drush cvapi ? [01:33:46] oh, needed version=4, right [01:37:49] (03PS2) 10Ejegg: Set contribution_recur_id when token found [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828094 (https://phabricator.wikimedia.org/T315031) [01:38:33] (03PS1) 10Ejegg: Add ContributionRecur::cancelInactives API4 Action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828129 (https://phabricator.wikimedia.org/T315102) [01:39:03] OK eileen, ^^^ seems to do the trick [01:46:40] (03CR) 10Ejegg: [C: 03+2] "Nice one CStone, looks like an easy win!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828101 (https://phabricator.wikimedia.org/T316404) (owner: 10Cstone) [01:47:14] (03Merged) 10jenkins-bot: Add getContactInfo to createPaymentFromToken [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828101 (https://phabricator.wikimedia.org/T316404) (owner: 10Cstone) [01:51:13] (03CR) 10CI reject: [V: 04-1] Set contribution_recur_id when token found [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828094 (https://phabricator.wikimedia.org/T315031) (owner: 10Ejegg) [01:53:51] (03PS14) 10Ejegg: Pass merchantAccountId with currency to support multi currencies [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [01:53:58] (03CR) 10Ejegg: [C: 03+2] Pass merchantAccountId with currency to support multi currencies [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [01:54:27] (03Merged) 10jenkins-bot: Pass merchantAccountId with currency to support multi currencies [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/822192 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [02:20:06] (03PS1) 10Ejegg: Braintree multi-currency minor tweaks [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828131 (https://phabricator.wikimedia.org/T312808) [02:20:10] (03PS1) 10Ejegg: Remove unneeded pass-by-reference & [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828132 [05:08:56] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/828208 (owner: 10L10n-bot) [09:27:11] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: check_endpoints_critical (Astropay-DLocal:1) 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [09:37:12] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [09:57:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: check_endpoints_critical (Astropay-DLocal:1) 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [10:02:15] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [14:10:15] hi fr-tech! [14:11:47] Hi jgleeson [14:13:43] how's it goin cstone [14:15:34] Good windy today though (and 6ft waves!) so no porch desk [14:20:15] ha [14:20:28] pretty mild here today. the feeling of summer drawing to a close :( [14:20:46] Is it still warm there jgleeson ? [14:20:52] Oh hah [14:21:21] I shouldn't be greedy. we had a few weeks of sun which is good for us over here lol [14:23:22] The lake will flip soon here and that usually is when I head back but I'm here till September 27 this time [14:23:55] are you looking forward to getting back to your new place? [14:24:24] Yes but also it's still completely unpacked so there's that to do hah [14:24:37] Er it needs to be unpacked [14:26:10] I'm bad at unpacking. we've still got stuff in the loft from when we moved in. [14:26:19] nearly 3 years ago [14:26:35] most of it is likely junk [14:27:09] we've been talking about doing a carboot sale for a while now, not sure if you do those over in the US? [14:27:47] basically you stick a bunch of stuff in the boot/trunk, drive to a field and then sell it to people looking for cheap bargains [14:28:16] https://www.boundless.co.uk/be-inspired/lifestyle/how-to-do-a-car-boot-sale [14:32:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), 10Patch-For-Review: Donations appearing in Civi but not Adyen - https://phabricator.wikimedia.org/T315487 (10HNordeenWMF) thanks @jgleeson ! [14:33:13] Ah I haven't seen that exact method but people will sell things from their yard/driveway [14:35:22] I have a lot of boxes for things hoarded which is nice for moving but I also don't plan on moving again anytime soon [14:35:57] ha me neither [14:42:06] (03CR) 10Jgleeson: [C: 04-1] "When testing locally with this URL, https://localhost:9001/index.php?title=Special:PaypalExpressGateway&appeal=JimmyQuote&country=CN&curre" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/827613 (https://phabricator.wikimedia.org/T316703) (owner: 10Ejegg) [14:47:45] (03CR) 10Jgleeson: [C: 03+2] "LGTM" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/825867 (owner: 10Ejegg) [14:48:16] (03Merged) 10jenkins-bot: Context: fluent setters, add return types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/825867 (owner: 10Ejegg) [14:50:40] (03PS5) 10Jgleeson: Audits: send merchant ID as gateway_account [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/436086 (owner: 10Ejegg) [14:51:08] heyyy jgleeson cstone fr-tech [14:53:01] jgleeson: so what's the chaos crew routine? :) [14:54:31] (03CR) 10Jgleeson: [C: 03+2] "Confirmed via the tests. LGTM" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/436086 (owner: 10Ejegg) [14:54:44] hey AndyRussG :) [14:55:01] (03Merged) 10jenkins-bot: Audits: send merchant ID as gateway_account [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/436086 (owner: 10Ejegg) [14:56:04] hmmm looks like you've got a bunch of stuff already assigned AndyRussG https://phabricator.wikimedia.org/project/board/6067/?order=priority [14:56:22] I was just gonna say, check out that board and dig into what you fancy [14:57:25] jgleeson: oki! yeah just not sure how we collaborate or what the priority was [14:57:48] https://phabricator.wikimedia.org/T316157 seems pretty high... I see you've got it assigned [14:58:10] there was a lot of talk about it in yesterday's tech-talk, so I'd suggest checking out the recording :) [14:58:34] and I guess whenever you're ready, maybe lmk how I can support on that? how does that sound? [14:58:37] yeah, ejegg|away pushed up a patch for that one with I +2ed but felt like it was worth a dig around in the logs also [14:58:54] check out the last comment [14:59:23] k there was some digging after that comment yesterday, I think it was db queries rather than logs [14:59:47] discussed in tech-talk I think not right at the beginning, after the civi stuff IIRC [15:00:16] hmm so the idea I had was to check the logs to find evidence of retries [15:00:25] which I think is what ejegg|away's patch tries to solve. [15:00:44] so maybe a little different than in the db [15:01:22] thanks for the heads up I'll check out the recoridng [15:01:27] recording* [15:02:41] thank u! so again I'll work on the assigned tasks that are actually important for the feature team PTR stuff, and again lmk if there's stuff you're working on that I can help with, sound good? [15:03:49] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29): Generate list of incomplete iDeal donations - https://phabricator.wikimedia.org/T316778 (10jgleeson) [15:05:35] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29): Generate list of incomplete iDeal donations - https://phabricator.wikimedia.org/T316778 (10jgleeson) a:05jgleeson→03None [15:05:43] AndyRussG: what's PTr? [15:06:00] ah I see [15:06:02] pending.. [15:07:23] sure that makes sense. also I'm just adding some followup tasks for the iDeal bug https://phabricator.wikimedia.org/T315487 [15:07:47] looks like we're gonna need to clean up civicrm [15:08:25] currently I'm looking at writing those tasks, following up in the logs on the retires and a little bit of review [15:10:53] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29): Remove incomplete iDeal transactions from CiviCRM - https://phabricator.wikimedia.org/T316780 (10jgleeson) [15:14:22] (03PS3) 10Jgleeson: Use ReferenceData to decode Ingenico submethods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790788 (https://phabricator.wikimedia.org/T308088) (owner: 10Ejegg) [15:33:57] (03CR) 10Wfan: [C: 03+2] Braintree multi-currency minor tweaks [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828131 (https://phabricator.wikimedia.org/T312808) (owner: 10Ejegg) [15:34:16] (03CR) 10Jgleeson: [C: 04-1] "It looks like we're sending in 'visa' when the unstaging helper's logic is expecting a numeric paymentMethodId. We catch the exception so " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790788 (https://phabricator.wikimedia.org/T308088) (owner: 10Ejegg) [15:34:28] (03Merged) 10jenkins-bot: Braintree multi-currency minor tweaks [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828131 (https://phabricator.wikimedia.org/T312808) (owner: 10Ejegg) [15:36:02] (03PS2) 10Jgleeson: Params for Adyen paymentMethods test script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/821350 (https://phabricator.wikimedia.org/T313333) (owner: 10Ejegg) [15:44:10] (03CR) 10Jgleeson: [C: 03+2] "Nice. I didn't know about this maintenance script and now it's even better. Took a while to find a combo that gave different results. It j" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/821350 (https://phabricator.wikimedia.org/T313333) (owner: 10Ejegg) [15:44:39] (03Merged) 10jenkins-bot: Params for Adyen paymentMethods test script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/821350 (https://phabricator.wikimedia.org/T313333) (owner: 10Ejegg) [15:45:33] 10Fundraising-Backlog: Pending Transaction Resolver Diagram - https://phabricator.wikimedia.org/T316684 (10jgleeson) a:03jgleeson [15:45:49] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Pending Transaction Resolver Diagram - https://phabricator.wikimedia.org/T316684 (10jgleeson) [15:46:15] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29): Remove incomplete iDeal transactions from CiviCRM - https://phabricator.wikimedia.org/T316780 (10jgleeson) a:05jgleeson→03None [15:47:16] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), 10Patch-For-Review: Donations appearing in Civi but not Adyen - https://phabricator.wikimedia.org/T315487 (10jgleeson) a:05jgleeson→03None [15:50:56] 10Fundraising Sprint Potato, 10Fundraising-Backlog: Remaining campaign markets need Adyen set as default - https://phabricator.wikimedia.org/T316168 (10AnnWF) a:03AnnWF [15:53:47] (03CR) 10Jforrester: build: Disable phan option scalar_implicit_cast and make pass (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/828082 (https://phabricator.wikimedia.org/T316575) (owner: 10Umherirrender) [15:53:58] (03PS3) 10Damilare Adedoyin: WIP: Ingenico audit parser sending already-refunded donations to refund queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) [15:55:51] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Adyen duplicate donations after donors see error message - August 2022 - https://phabricator.wikimedia.org/T316157 (10jgleeson) Hmm, based on the logs, it looks like the Adyen API might have timed out, which contradicts the "//Our AP... [16:05:19] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), 10Patch-For-Review: Donations appearing in Civi but not Adyen - https://phabricator.wikimedia.org/T315487 (10greg) For the record: this is fixed, data going forward is good, but the hi... [16:16:52] 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10FR-Adyen: Adyen Checkout: Show fail form rather than exception when rejecting for fraud - https://phabricator.wikimedia.org/T299690 (10Ejegg) [16:27:43] 10Fundraising-Backlog, 10FR-Braintree-Integration: Add spinner to Braintree UI while waiting for button to appear - https://phabricator.wikimedia.org/T312897 (10Dwisehaupt) [16:34:35] 10Fundraising-Backlog: Check need to account for opt-in param loss from 2022-06-15 through 2022-06-30 - https://phabricator.wikimedia.org/T311974 (10Dwisehaupt) [16:35:30] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10donate.wikimedia.org: Broken links from Waystogive? - https://phabricator.wikimedia.org/T315268 (10Ejegg) Still seeing some of these as of Aug 31: Aug 31 16:19:41 payments1007 donation_gateway: GatewayChooserNo supported gateway for parameters: Array... [17:14:03] (03CR) 10Ejegg: "Hi Jgleeson, I should have said in the commit message that this is to allow the GatewayChooser to route PayPal donations from CN to the Pa" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/827613 (https://phabricator.wikimedia.org/T316703) (owner: 10Ejegg) [17:15:01] (03CR) 10Ejegg: "https://payments.wikimedia.org/index.php?title=Special:GatewayChooser&uselang=en&language=en¤cy=CNY&country=CN&amount=2500&payment_m" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/827613 (https://phabricator.wikimedia.org/T316703) (owner: 10Ejegg) [17:16:53] (03Abandoned) 10Ejegg: Silverpop has_recur: require donation within 60 days [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/826410 (https://phabricator.wikimedia.org/T315102) (owner: 10Ejegg) [17:21:24] (03PS3) 10Ejegg: GatewayChooser: Route China to PayPal gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/827613 (https://phabricator.wikimedia.org/T315592) [17:38:17] (03PS4) 10Damilare Adedoyin: WIP: Ingenico audit parser sending already-refunded donations to refund queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) [17:39:06] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Be consistent with staged card type in Ingenico - https://phabricator.wikimedia.org/T316796 (10Ejegg) [17:41:33] (03CR) 10Ejegg: "Good find! Looks like in IngenicoMethodCodec we're staging up TWO versions of the darn variable, one as payment_product and one as payment" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/790788 (https://phabricator.wikimedia.org/T308088) (owner: 10Ejegg) [17:45:44] Thanks for all the code review, Jack! [17:51:56] np ejegg. I think I was seeing the string version of the param at the first stage (when clicking visa) [17:52:14] I didn't get as far as entering any details in the resulting hosted payment page [17:53:32] ah i think you explain that in https://phabricator.wikimedia.org/T316796 [18:17:00] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10FR-Braintree-Integration, 10Patch-For-Review: Paypal audit parser should drop Braintree-initiated donations - https://phabricator.wikimedia.org/T315258 (10AnnWF) Also need to find if no donation at c... [18:25:23] (03PS7) 10Wfan: Opt out braintree transaction from paypal audit [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/827523 (https://phabricator.wikimedia.org/T315258) [18:26:00] (03CR) 10Jgleeson: [C: 03+2] "ah ok. i see now that this patch fixes the GatewayChooser error. LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/827613 (https://phabricator.wikimedia.org/T315592) (owner: 10Ejegg) [18:26:41] (03CR) 10CI reject: [V: 04-1] Opt out braintree transaction from paypal audit [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/827523 (https://phabricator.wikimedia.org/T315258) (owner: 10Wfan) [18:26:57] (03PS8) 10Wfan: Opt out braintree transaction from paypal audit [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/827523 (https://phabricator.wikimedia.org/T315258) [18:28:59] (03Merged) 10jenkins-bot: GatewayChooser: Route China to PayPal gateways [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/827613 (https://phabricator.wikimedia.org/T315592) (owner: 10Ejegg) [18:45:40] dami I noticed a couple of edge cases at least in local testing where I got to the donor session backup code and the gateway key wasn't set, leading to an error when trying to write a log message [18:45:54] maybe wouldn't happen on production though [18:50:27] (03PS1) 10Ejegg: Tweak log message to avoid possible error [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828624 [18:51:01] damilare: do you mind if we just take that $donor['gateway'] out of the message before we deploy your patch? ^^^ [18:52:05] ohh ok, this makes sense [18:52:19] Sure thing ejegg [18:52:24] thanks! [19:07:59] fr-tech. when log diving for adyen stuff, I noticed that for monthly convert and at least one other flow, we're not logging the "sent donor to thank you page" step, at the end of the journey. It's not a mistake, we just don't do it due to the flow. However, I find that log line particularly useful when trying to get an idea of the donors journey, via the logs as it's an easy way to identify the [19:08:01] final step. Is there any reason why we wouldn't do it for monthly convert? [19:08:40] in all cases, we send them to a thank you page [19:08:56] but we only log it for some cases [19:09:11] jgleeson: so for monthly convert, we send them to the TY page from javascript [19:09:32] I suppose we could try doing a non-blocking API call in the background at the same time, to get a log line in there [19:09:48] but for the other cases when we log it, we are doing a server-side redirect [19:11:41] hmm [19:12:14] jgleeson: looks like we would need to use sendBeacon for the browser not to cancel the request when we subsequently redirect in JS [19:12:17] so I think we make an api call when they select yes, or modify the amount and select yes [19:12:36] exactly, the current flow only interacts with the server on 'yes' [19:12:59] ah, so 'no' triggers a vanilla js redirect [19:13:06] right [19:13:26] we send the TY page URL to one of the mw.config client-side variables [19:13:35] when we render the MC form [19:15:27] ok I have another suggestion [19:16:29] how about we change the prefix of this log line to be something like "Displaying monthly convert.." https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/24cf4b7419c64a6d41ca33d6992ed918a738535a/gateway_common/GatewayPage.php#L397 [19:17:06] that would make the wording closer to the the log line on 402 [19:17:10] sure jgleeson [19:17:17] I'd C+2 that [19:17:27] ok cool I'll push it [19:17:29] thanks [19:21:19] (03CR) 10Damilare Adedoyin: [C: 03+2] Tweak log message to avoid possible error [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828624 (owner: 10Ejegg) [19:21:28] ty damilare [19:22:46] (03PS2) 10Ejegg: Ignore Paypal mp_notification IPNs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/826629 (owner: 10Jgleeson) [19:22:56] (03CR) 10Ejegg: [C: 03+2] Ignore Paypal mp_notification IPNs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/826629 (owner: 10Jgleeson) [19:23:12] ok, I'm going to tag another version for SmashPig [19:23:40] (03Merged) 10jenkins-bot: Ignore Paypal mp_notification IPNs [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/826629 (owner: 10Jgleeson) [19:23:49] then maybe in a bit we can deploy DonationInterface including a library update and damilare's session backup patch [19:23:55] (03Merged) 10jenkins-bot: Tweak log message to avoid possible error [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828624 (owner: 10Ejegg) [19:24:27] sounds good to me [19:24:31] (03PS1) 10Jgleeson: Update wording for monthly convert logging. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828626 [19:24:33] (03Abandoned) 10Umherirrender: tests: Fix timestamps in HistoryTest/CampaignTest for postgres [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/814292 (owner: 10Umherirrender) [19:24:52] (03PS2) 10Ejegg: Update wording for monthly convert logging. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828626 (owner: 10Jgleeson) [19:25:14] (03CR) 10Ejegg: [C: 03+2] Update wording for monthly convert logging. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828626 (owner: 10Jgleeson) [19:25:43] ty ejegg [19:26:04] :) [19:27:15] (03Merged) 10jenkins-bot: Update wording for monthly convert logging. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828626 (owner: 10Jgleeson) [19:27:49] (03PS1) 10Ejegg: Add missing argument to createPaymentSession() [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828627 [19:28:37] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Adyen duplicate donations after donors see error message - August 2022 - https://phabricator.wikimedia.org/T316157 (10jgleeson) After some additional digging, I found cases where the duplicate calls happen without requests timing out... [19:28:43] (03PS1) 10Ejegg: Update SmashPig to 0.8.2.8 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828628 [19:28:56] (03PS2) 10Umherirrender: build: Disable phan option scalar_implicit_cast and make pass [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/828082 (https://phabricator.wikimedia.org/T316575) [19:29:01] back shortly [19:29:41] (03CR) 10Umherirrender: build: Disable phan option scalar_implicit_cast and make pass (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/828082 (https://phabricator.wikimedia.org/T316575) (owner: 10Umherirrender) [19:30:00] (03CR) 10CI reject: [V: 04-1] Add missing argument to createPaymentSession() [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828627 (owner: 10Ejegg) [19:31:24] fr-tech: sounds like there was some digging on this last night https://phabricator.wikimedia.org/T315031 and it's currently the next priority item on the chaos crew board based. Did you all figure anything out wrt it? [19:33:35] XenoRyet: I don't think this one is a chaos crew one - it feels more like feature work https://phabricator.wikimedia.org/T316368 [19:33:52] looking [19:34:09] or maybe even just a question we could talk over on tech-talk [19:34:51] cstone: I think you worked on some of that right? https://phabricator.wikimedia.org/T316368 [19:35:28] Jgleeson, sounds reasonable. I probably just misread it on monday while we were talking about that UBN. I'll take it off the Chaos board. [19:35:44] thanks [19:37:34] That ticket has a weird history. Looks like Aklapper originally added the Chaos tag, then greg moved it to the column, probably because it had the tag, then jack took the tag off, but it probably stayed in the column, then got the tag readded when I bulk edited the column. [19:37:45] Anyway, I'll take the tag back off and put it in a better place. [19:37:55] 10Fundraising-Backlog: Adyen iDeal code seems to go through DirectDebitPaymentProvider - https://phabricator.wikimedia.org/T316368 (10XenoRyet) [19:48:41] (03PS5) 10Damilare Adedoyin: Ingenico audit parser sending already-refunded donations to refund queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) [19:53:35] 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10FR-Adyen: Adyen Checkout: Show fail form rather than exception when rejecting for fraud - https://phabricator.wikimedia.org/T299690 (10Damilare) a:03Damilare [19:56:02] jgleeson: hmm if i named it that way its cause maybe i thought that ideal was a type of direct debit? or i was just building off of what was there [19:56:45] could just be ignorant american there as I dont use banktransfor/direct debit things [19:58:54] I'm not sure who came up with the names. I can see how Direct Debit definitely sounds like a general purpose thing [19:59:35] is that a very specific thing then? [20:02:19] over here and I think in Europe, it's synonymous with recurring payment [20:02:34] although I can see on the wiki page it means different things around the world. https://en.wikipedia.org/wiki/Direct_debit#United_Kingdom [20:03:24] pretty much most of the country pay regular househouse bills by direct debit [20:03:42] (03CR) 10CI reject: [V: 04-1] Ingenico audit parser sending already-refunded donations to refund queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) (owner: 10Damilare Adedoyin) [20:04:23] In Europe it's usually just SEPA I think [20:12:51] 10Fundraising-Backlog: Adyen iDeal code seems to go through DirectDebitPaymentProvider - https://phabricator.wikimedia.org/T316368 (10Ejegg) Ah, this was my mistake I guess. I wasn't clear on the distinction between direct debit and whatever-ideal-is. If you want to rename the class please go ahead. [20:13:19] 10Fundraising-Backlog: Adyen iDeal code seems to go through DirectDebitPaymentProvider - https://phabricator.wikimedia.org/T316368 (10Ejegg) err, sorry, cstone wrote this, but I thought it was right too! [20:20:18] (03CR) 10Ejegg: [C: 03+2] Update SmashPig to 0.8.2.8 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828628 (owner: 10Ejegg) [20:21:56] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/828639 [20:21:58] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/828639 (owner: 10Ejegg) [20:23:01] (03CR) 10CI reject: [V: 04-1] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/828639 (owner: 10Ejegg) [20:24:33] (03PS2) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/828639 [20:27:09] (03Merged) 10jenkins-bot: Update SmashPig to 0.8.2.8 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828628 (owner: 10Ejegg) [20:27:17] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/828639 (owner: 10Ejegg) [20:27:26] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/828642 [20:27:39] (03CR) 10Damilare Adedoyin: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) (owner: 10Damilare Adedoyin) [20:30:37] ejegg: cstone. maybe this is a UK bias thing? [20:30:59] on my part [20:32:27] jgleeson: I only use my debit card in other countries so open to whatever you want to rename it to [20:32:56] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/828643 [20:33:36] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/828643 (owner: 10Eileen) [20:36:41] I'll think on it and search the internet first for more balanced views to see if the distinction is worth making [20:36:55] !log config revision changed from b1bd9422 to 4331ef59 [20:36:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:37:10] catch you all tomorrow o/ [20:37:12] ejegg: that pushed it out - so we can see impact from there [20:38:03] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/828639 (owner: 10Ejegg) [20:40:00] 10Fundraising-Backlog: Adyen iDeal code seems to go through DirectDebitPaymentProvider - https://phabricator.wikimedia.org/T316368 (10Cstone) Yeah same I just thought iDEAL was a type of direct debit. +1 to renaming it whatever it actually is. [20:40:06] (03CR) 10CI reject: [V: 04-1] Ingenico audit parser sending already-refunded donations to refund queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) (owner: 10Damilare Adedoyin) [20:44:48] 10fundraising-tech-ops: reimage fundraising frmx role servers to Bullseye - https://phabricator.wikimedia.org/T316725 (10Dwisehaupt) [20:46:51] 10fundraising-tech-ops: reimage fundraising frmx role servers to Bullseye - https://phabricator.wikimedia.org/T316725 (10Dwisehaupt) frmx2001 rebuild and test messages sent and verified that dkim signatures are correct. [20:48:34] 10fundraising-tech-ops: Modify dns_to_ipset to do both UDP and TCP DNS requests. - https://phabricator.wikimedia.org/T316819 (10Jgreen) [21:14:49] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Remove WmfDatabase and WmfTransaction if possible - https://phabricator.wikimedia.org/T316823 (10Ejegg) [21:23:52] (03PS2) 10Ejegg: Add missing argument to createPaymentSession() [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828627 [21:27:33] ejegg: what do you think about the grafana - it might be within the margin of error for that patch? [21:29:35] although maybe on the rate graph it is discernable? [21:38:12] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: GatewayChooser: improve error style for 'No Form' message - https://phabricator.wikimedia.org/T316824 (10Ejegg) [21:38:30] eileen: looking [21:39:47] oh yeah, looks like a definite increase in the 'import times' graph for Create Contact [21:41:01] 25ms more on average, just about double [21:47:57] hmm [21:48:08] I guess it's doing more work [21:48:21] should we push out the civitoken update & see if that affects [21:48:29] it might be more efficient [21:50:13] 10fundraising-tech-ops: Modify dns_to_ipset to do both UDP and TCP DNS requests. - https://phabricator.wikimedia.org/T316819 (10Jgreen) 05Open→03Resolved p:05Triage→03High a:03Jgreen Done, and it seems to have worked. [21:54:05] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/828642 (owner: 10Ejegg) [21:54:27] sure eileen, let's try that [21:54:36] lemme just find that to give it a C+2 [21:55:14] (03PS4) 10Ejegg: Update to latest civiToken [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/819768 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [21:55:18] (03CR) 10Ejegg: [C: 03+2] Update to latest civiToken [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/819768 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [21:56:54] ejegg: is there one more hour of test? [21:57:23] eileen: ahh, the payments nginx traffix graph is way down [21:57:28] guessing the test is over [21:57:33] dang [21:57:36] https://frmon.frdev.wikimedia.org/d/Pq1YNMviz/fundraising-overview?orgId=1&refresh=1m&from=now-3h&to=now&viewPanel=8 [21:58:22] well I'll push out the civitoken & next time we can try the opposite - turning the greeting processing OFF again [21:58:30] i suspect there may be something wrong with the count of 5xx errors on that graph [21:58:46] it's way higher than I would expect and it's always the same as the 4xx errors [21:59:22] oh yeah, there it is [22:00:01] updated [22:02:37] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/828642 (owner: 10Ejegg) [22:09:08] (03Merged) 10jenkins-bot: Update to latest civiToken [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/819768 (https://phabricator.wikimedia.org/T313000) (owner: 10Eileen) [22:10:11] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/828647 [22:21:41] (03PS6) 10Damilare Adedoyin: Ingenico audit parser sending already-refunded donations to refund queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) [22:38:01] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/828647 (owner: 10Eileen) [22:38:57] !log config revision changed from 4331ef59 to d3696af7 [22:38:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:40:09] (03CR) 10Wfan: [C: 03+1] Ingenico audit parser sending already-refunded donations to refund queue (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) (owner: 10Damilare Adedoyin) [22:42:28] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Don't tokenize cards when donation is under Monthly Convert minimum - https://phabricator.wikimedia.org/T316840 (10Ejegg) [22:45:28] !log payments-wiki upgraded from 80657b06 to 648842f9 [22:45:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:49:25] PROBLEM - Host frmx2001 is DOWN: PING CRITICAL - Packet loss = 100% [22:50:37] ^ that was me. readded the downtime. [22:55:29] RECOVERY - Host frmx2001 is UP: PING OK - Packet loss = 0%, RTA = 30.15 ms [22:56:56] I feel like it has settled into 51 up from 48 ms per contact create https://frmon.frdev.wikimedia.org/d/Pq1YNMviz/fundraising-overview?orgId=1&refresh=1m&viewPanel=33 - with greeting processing on [22:57:32] let's leave it on & get the next update out (which has a couple more minor improvements) & then try turning it OFF during traffic & see [23:16:35] eileen: any thoughts on this API Action for cancelling the old recurrings? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/828129 [23:23:30] (03PS2) 10Ejegg: Remove duplicated language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828100 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen) [23:23:37] (03CR) 10Ejegg: [C: 03+2] Remove duplicated language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828100 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen) [23:37:06] (03Merged) 10jenkins-bot: Remove duplicated language options [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828100 (https://phabricator.wikimedia.org/T315509) (owner: 10Eileen)