[01:31:16] (03PS1) 10Ejegg: Fix legacy paypal reactivate function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828666 (https://phabricator.wikimedia.org/T242158) [02:00:11] (03PS1) 10Ejegg: Reactive cancelled recurrings on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828667 (https://phabricator.wikimedia.org/T242158) [02:04:43] 10Fundraising Sprint Potato, 10Fundraising-Backlog: Update payments-wiki docker image in fundraising-dev from buster to bullseye - https://phabricator.wikimedia.org/T316848 (10Ejegg) [02:04:59] 10Fundraising Sprint Potato, 10Fundraising-Backlog: Update payments-wiki docker image in fundraising-dev from buster to bullseye - https://phabricator.wikimedia.org/T316848 (10Ejegg) a:03Ejegg [02:05:29] 10Fundraising-Backlog, 10Epic: Upgrading payments-wiki from buster to bullseye - https://phabricator.wikimedia.org/T315585 (10Ejegg) [02:06:28] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10FR-Smashpig: Use idempotency headers in payment processing requests - https://phabricator.wikimedia.org/T243967 (10Ejegg) Looks like for Ingenico this is only available for 'Create Payment' [02:12:07] (03CR) 10CI reject: [V: 04-1] Reactive cancelled recurrings on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828667 (https://phabricator.wikimedia.org/T242158) (owner: 10Ejegg) [02:14:31] (03PS2) 10Ejegg: Reactivate cancelled recurrings on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828667 (https://phabricator.wikimedia.org/T242158) [02:41:51] (03PS1) 10Ejegg: Add UniqueId helper class, use for Adyen idempotence [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828671 (https://phabricator.wikimedia.org/T243967) [02:41:53] (03PS1) 10Ejegg: Use idempotence headers for Ingenico [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828672 (https://phabricator.wikimedia.org/T243967) [02:43:08] (03CR) 10CI reject: [V: 04-1] Use idempotence headers for Ingenico [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828672 (https://phabricator.wikimedia.org/T243967) (owner: 10Ejegg) [02:43:10] (03CR) 10CI reject: [V: 04-1] Add UniqueId helper class, use for Adyen idempotence [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828671 (https://phabricator.wikimedia.org/T243967) (owner: 10Ejegg) [02:44:18] (03PS2) 10Ejegg: Add UniqueId helper class, use for Adyen idempotence [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828671 (https://phabricator.wikimedia.org/T243967) [02:44:20] (03PS2) 10Ejegg: Use idempotence headers for Ingenico [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828672 (https://phabricator.wikimedia.org/T243967) [08:08:11] (03PS7) 10Damilare Adedoyin: Ingenico audit parser sending already-refunded donations to refund queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) [12:26:18] (03PS8) 10Damilare Adedoyin: Ingenico audit parser sending already-refunded donations to refund queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) [13:25:12] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), 10Patch-For-Review: Donations appearing in Civi but not Adyen - https://phabricator.wikimedia.org/T315487 (10jgleeson) a:03jgleeson [13:55:08] (03CR) 10Jgleeson: [C: 03+2] "Nice tidy up. LGTM" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828666 (https://phabricator.wikimedia.org/T242158) (owner: 10Ejegg) [14:13:55] 10Wikimedia-Fundraising-Banners: Make it easier to develop banners locally - https://phabricator.wikimedia.org/T286081 (10Pcoombe) 05Open→03Declined Moved this work to Asana [14:16:12] 10Wikimedia-Fundraising-Banners: [Enhancement] Improve error message for opt-in - https://phabricator.wikimedia.org/T277200 (10Pcoombe) 05Open→03Declined Moved this work to Asana [14:16:14] 10Wikimedia-Fundraising-Banners: QA for English Latin America - https://phabricator.wikimedia.org/T275449 (10Pcoombe) [14:17:01] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-Core-Skin-Architecture (Menus 2.0), 10Technical-Debt: [Maintenance request] CentralNotice should not use SkinTemplateNavigation hook to add special page tabs - https://phabricator.wikimedia.org/T315562 (10AndyRussG) [14:19:40] 10Wikimedia-Fundraising-Banners: Make it easier to disable recurring payment methods - https://phabricator.wikimedia.org/T272610 (10Pcoombe) 05Open→03Declined Moved this work to Asana [14:31:00] 10Wikimedia-Fundraising-Banners, 10donate.wikimedia.org: Selecting pay the fee can submit amount with too many decimal places - https://phabricator.wikimedia.org/T262683 (10spatton) Resolving this and moving to our Asana dev board. [14:31:04] 10Wikimedia-Fundraising-Banners, 10donate.wikimedia.org: Selecting pay the fee can submit amount with too many decimal places - https://phabricator.wikimedia.org/T262683 (10spatton) 05Open→03Resolved [14:32:16] 10Wikimedia-Fundraising-Banners, 10donate.wikimedia.org: Don't ask to "pay the fee" if it would take donation over maximum amount - https://phabricator.wikimedia.org/T228540 (10Pcoombe) 05Open→03Resolved a:03Pcoombe Resolved for donatewiki, declined for banners as it's the edgiest of edge cases there [14:34:19] (03CR) 10Jgleeson: "Thanks. Code looks good. I dropped a question about the UUID implementation and wonder if the hostname prefix might be useful in the futur" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828671 (https://phabricator.wikimedia.org/T243967) (owner: 10Ejegg) [14:39:51] (03CR) 10Jgleeson: [C: 03+2] "Nice addition! LGTM" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828672 (https://phabricator.wikimedia.org/T243967) (owner: 10Ejegg) [14:48:04] (03CR) 10Jgleeson: [C: 04-1] "Hmmm, I'm seeing any params in the method signature here https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/63944887583b48c3" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828627 (owner: 10Ejegg) [14:49:14] hi fr-tech :) [14:49:22] (03CR) 10Jgleeson: [C: 04-1] "oh hey, I found it for Adyen/ApplePay https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/d8d2ab03bd0c894c7f0902e319a3b80175b" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828627 (owner: 10Ejegg) [15:01:35] hey AndyRussG ! [15:01:39] &fr-tech [15:01:49] :) [15:02:38] hi AndyRussG jgleeson [15:02:47] :) :) [15:04:04] hi cstone AndyRussG jgleeson [15:04:18] :) :) :) [15:04:32] :) x3 [15:04:49] haha [15:05:03] hi damilare ! [15:05:18] hi cstone damilare ! [15:05:47] (03PS1) 10Wfan: Merge branch 'master' of https://gerrit.wikimedia.org/r/p/mediawiki/extensions/DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/829025 [15:05:49] (03PS1) 10Wfan: Update default gateway to adyen for countries LV, BG, KW, SK, RO, HU, HK, PL, IT, JP [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/829026 (https://phabricator.wikimedia.org/T316168) [15:06:40] https://imgur.com/a/6GTtJsE [15:12:55] (03PS2) 10Wfan: Update default gateway to adyen for countries LV, BG, KW, SK, RO, HU, HK, PL, IT, JP [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/829026 (https://phabricator.wikimedia.org/T316168) [15:16:59] AndyRussG: is that super dog? :) [15:17:18] hehehhe yeah indeed! [15:17:31] super dog who got rained on [15:18:33] :) [15:20:47] 10Wikimedia-Fundraising-Banners, 10Instrument-ClientError, 10Patch-For-Review: Tag errors where a banner is being displayed - https://phabricator.wikimedia.org/T265096 (10Pcoombe) Hi @Jdlrobson, not sure what the status of this is. Is it still something that you're working on? [15:36:28] 10Fundraising-Backlog, 10Wikimedia-Fundraising-Banners, 10FR-Japan, 10donate.wikimedia.org, 10fr-donorservices: Investigate Japanese unintended recurring donations - https://phabricator.wikimedia.org/T262361 (10Pcoombe) @MBeat33 @krobinson We've made quite a few changes since this task, including to clar... [15:36:59] (03CR) 10Jgleeson: [C: 03+2] "LGTM" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828132 (owner: 10Ejegg) [15:37:28] (03Merged) 10jenkins-bot: Remove unneeded pass-by-reference & [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828132 (owner: 10Ejegg) [15:37:37] thanks! [15:47:25] 10Wikimedia-Fundraising-Banners: [Enhancement] Rearrange CC logos in a line rather than a square (for better viewing on tablets and horizontal orientations) - https://phabricator.wikimedia.org/T270913 (10Pcoombe) 05Open→03Declined Moved this work into Asana [15:47:27] 10Wikimedia-Fundraising-Banners: Mobile small w/ payment methods visible in step 2 - https://phabricator.wikimedia.org/T270887 (10Pcoombe) [15:47:46] 10Wikimedia-Fundraising-Banners: Re-think how we manage credit card logos - https://phabricator.wikimedia.org/T286670 (10Pcoombe) 05Open→03Declined Moved this work into Asana [16:01:41] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10donate.wikimedia.org: Broken links from Waystogive? - https://phabricator.wikimedia.org/T315268 (10Pcoombe) I still can't reproduce this. But I did just change those links from Special:GatewayFormChooser to Special:GatewayChooser as they didn't get up... [16:02:55] (03CR) 10Ejegg: "Oops, I was confused by an IDE typehint!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828627 (owner: 10Ejegg) [16:02:59] (03Abandoned) 10Ejegg: Add missing argument to createPaymentSession() [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/828627 (owner: 10Ejegg) [16:36:37] (03PS3) 10Ejegg: Update default gateway to adyen for countries LV, BG, KW, SK, RO, HU, HK, PL, IT, JP [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/829026 (https://phabricator.wikimedia.org/T316168) (owner: 10Wfan) [16:36:42] (03CR) 10Ejegg: [C: 03+2] Update default gateway to adyen for countries LV, BG, KW, SK, RO, HU, HK, PL, IT, JP [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/829026 (https://phabricator.wikimedia.org/T316168) (owner: 10Wfan) [16:47:27] (03Merged) 10jenkins-bot: Update default gateway to adyen for countries LV, BG, KW, SK, RO, HU, HK, PL, IT, JP [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/829026 (https://phabricator.wikimedia.org/T316168) (owner: 10Wfan) [17:01:57] 10Fundraising-Backlog: Adyen: Client side error on Safari even with successful donation - https://phabricator.wikimedia.org/T310737 (10Dwisehaupt) [17:04:26] 10Fundraising-Backlog, 10FR-AutoTY-Email: Civi TY email delayed display (cache issue) - https://phabricator.wikimedia.org/T310561 (10Ejegg) [17:04:30] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Editing system workflow messages should clear cached values - https://phabricator.wikimedia.org/T305103 (10Ejegg) [17:09:25] 10Fundraising-Backlog, 10fr-donorservices: Donor directed to "Thank You" page even though payment rejected - https://phabricator.wikimedia.org/T310383 (10Dwisehaupt) [17:11:26] 10Fundraising-Backlog, 10fr-donorservices: Donor directed to "Thank You" page even though payment rejected - https://phabricator.wikimedia.org/T310383 (10Dwisehaupt) [17:15:51] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Added in Assistant Email for Individual Records in Civi - https://phabricator.wikimedia.org/T309503 (10Dwisehaupt) [17:16:16] thanks elliott :) [18:09:28] (03CR) 10Ejegg: "This looks like it only checks the refunded status when the primary lookup (main_transaction_exists_in_civi) fails and we have to resort t" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) (owner: 10Damilare Adedoyin) [18:51:48] 10Wikimedia-Fundraising-Banners, 10Instrument-ClientError, 10Patch-For-Review: Tag errors where a banner is being displayed - https://phabricator.wikimedia.org/T265096 (10Jdlrobson) It's been causing less problems so I haven't thought too much of this and haven't been working on it. The more important unde... [19:00:49] 10Fundraising Tech - Chaos Crew: Document contribution_tracking contibution_source tbl triggers - https://phabricator.wikimedia.org/T316898 (10jgleeson) [19:01:27] 10Fundraising Tech - Chaos Crew: Document contribution_tracking contibution_source tbl triggers - https://phabricator.wikimedia.org/T316898 (10jgleeson) [19:04:09] 10Fundraising Tech - Chaos Crew, 10Release-Engineering-Team, 10GitLab (Project Migration): Create new GitLab project group: Fundraising-Tech - https://phabricator.wikimedia.org/T316695 (10Dzahn) I created https://gitlab.wikimedia.org/repos/fundraising-tech as a new subgroup under the /repos/ top-group. So... [19:08:59] 10Fundraising Tech - Chaos Crew, 10Release-Engineering-Team, 10GitLab (Project Migration): Create new GitLab project group: Fundraising-Tech - https://phabricator.wikimedia.org/T316695 (10Dzahn) You can compare group members from the Gerrit link to the new link here: https://gitlab.wikimedia.org/groups/repo... [19:12:23] 10Fundraising Tech - Chaos Crew, 10Release-Engineering-Team, 10serviceops, 10serviceops-collab, 10GitLab (Project Migration): Create new GitLab project group: Fundraising-Tech - https://phabricator.wikimedia.org/T316695 (10Dzahn) 05Open→03In progress a:03Dzahn [19:12:44] 10Fundraising Tech - Chaos Crew, 10Release-Engineering-Team, 10serviceops, 10serviceops-collab, 10GitLab (Project Migration): Create new GitLab project group: Fundraising-Tech - https://phabricator.wikimedia.org/T316695 (10Dzahn) [19:14:44] 10Fundraising Tech - Chaos Crew, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.25; 2022-08-15): Adyen donors think they are recurring July 2022 - https://phabricator.wikimedia.org/T313854 (10MBeat33) We are still seeing a few of these tickets, with 8 from Adyen donors with donation dates since August 15th.... [19:17:27] 10Fundraising Tech - Chaos Crew, 10Release-Engineering-Team, 10serviceops, 10serviceops-collab, 10GitLab (Project Migration): Create new GitLab project group: Fundraising-Tech - https://phabricator.wikimedia.org/T316695 (10jgleeson) thanks @Dzahn ! [19:21:21] 10Fundraising Tech - Chaos Crew, 10Release-Engineering-Team, 10serviceops, 10serviceops-collab, 10GitLab (Project Migration): Create new GitLab project group: Fundraising-Tech - https://phabricator.wikimedia.org/T316695 (10Dzahn) 05In progress→03Resolved Yep. cheers. Feel free to reopen if there are... [19:22:59] (03PS1) 10Ejegg: Add SQL for contribution_source [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/829051 [19:23:07] jgleeson: there it is ^^^ [19:23:31] so next up would be to just fix the code to allow ideal donations to get rows there [19:23:40] and then to run it as part of dev installs [19:23:52] then finally to figure out where it all goes when we get off drupal7 [19:24:51] ejegg: Bug:T316898 maybe? [19:24:53] T316898: Document contribution_tracking contibution_source tbl triggers - https://phabricator.wikimedia.org/T316898 [19:26:24] 10Fundraising Tech - Chaos Crew, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.25; 2022-08-15): Adyen donors think they are recurring July 2022 - https://phabricator.wikimedia.org/T313854 (10Ejegg) One other small thing we could do is skip keeping the card on file when the amount is below the minimum for s... [20:14:00] (03CR) 10Damilare Adedoyin: "Thanks Elliot for the CR, I had considered the approach you suggested earlier while working on it but had a change of mind later on. Pleas" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) (owner: 10Damilare Adedoyin) [20:14:50] hi ejegg, I just responded to your comment on my patch. Please check it out. ^^ [20:47:31] (03CR) 10Ejegg: "Thanks for the review jgleeson! Answers inline." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828671 (https://phabricator.wikimedia.org/T243967) (owner: 10Ejegg) [20:47:39] thanks damilare [20:48:33] well that took longer than I expected [20:49:24] AndyRussG: here's those activity diagrams I promised https://gitlab.wikimedia.org/jgleeson/fr-tech-diagrams/-/commit/4ea3226b749bbb3a07d1d3e637ce9ca49d46690a [20:49:40] also with the plantuml text definitions [20:50:04] I'm gonna move that repo over to our new group [20:52:42] (03CR) 10Jgleeson: [C: 03+2] "Thanks. LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828671 (https://phabricator.wikimedia.org/T243967) (owner: 10Ejegg) [20:53:16] (03Merged) 10jenkins-bot: Add UniqueId helper class, use for Adyen idempotence [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828671 (https://phabricator.wikimedia.org/T243967) (owner: 10Ejegg) [20:53:18] (03Merged) 10jenkins-bot: Use idempotence headers for Ingenico [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/828672 (https://phabricator.wikimedia.org/T243967) (owner: 10Ejegg) [20:56:31] (03CR) 10Ejegg: "Ahh, sorry I missed that! There is some confusing logic and comments in that base audit processor due to the way we used to record refunds" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) (owner: 10Damilare Adedoyin) [20:57:13] damilare: So all that audit logic really needs an overhaul [20:58:02] true, it really does. It's a good idea to move that invoice_id check as a fallback. [20:58:11] partly (as i mentioned in that comment) because it was written when we were still creating separate (negative valued) contributions [20:58:18] but... maybe your patch is good for now [20:58:49] and maybe we can do a more complete rewrite when we have time to move the audit processing from the drupal module to the Civi module [20:59:19] heh, or you could start the rewrite now on the pretext of needing to do it for that ticket! [20:59:39] might be a fun way to get into the more modern Civi code [21:00:36] So how about we go with that patch as-is, I'll write a patch with comment updates and TODOs, and then we can see about the rewrite [21:03:10] oh shoot, do we really want an exception in there? [21:04:07] 10Fundraising Sprint Potato, 10Fundraising-Backlog: Use nightly rather than weekly audit file for Adyen - https://phabricator.wikimedia.org/T314753 (10Cstone) a:03Cstone [21:07:36] 10Fundraising Tech - Chaos Crew: Document contribution_tracking contibution_source tbl triggers - https://phabricator.wikimedia.org/T316898 (10Ejegg) Also we can probably move this logic out of triggers and into code, now that the contribution_tracking table is only ever written to by the contribution tracking q... [21:10:01] hmm, looks like there are some functions that throw exceptions in there. But maybe I should make this change you suggested as it's a more quiet way to skip the transaction. [21:13:39] also doing the rewrite sure sounds fun too. [21:17:53] here's the ticket for that: https://phabricator.wikimedia.org/T270675 [21:18:48] it could potentially just be code within the larger Wmf extension [21:19:27] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29): Generate list of incomplete iDeal donations - https://phabricator.wikimedia.org/T316778 (10jgleeson) a:03jgleeson [21:21:10] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Convert wmf_audit to an extension or move logic into wmf-civicrm Civi extension - https://phabricator.wikimedia.org/T270675 (10Ejegg) [21:23:16] That's definitely a lot of bonus points for the BaseAuditProcessor module. Each probably deserve it's own task. [21:26:46] bye for now fr-tech o/ [21:34:29] toodles [21:40:58] damilare: yep, it's big - it's got 8 points on it! [21:44:34] (03PS1) 10Ejegg: Move contribution_source population into code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/829073 [21:44:37] hmm, now I'm thinking maybe we should leave the patch as is to fix the issues with the queues. Then approach this overhaul epic head on with their own tasks. [21:47:00] is it really only twice as big as most of our 4s? that almost looks like a 16 to me. [21:47:06] damilare: OK, let me make sure that it's not going to crash the whole audit parse the first time it hits an already-refunded donation [21:47:13] (says the person who doesn't write the code :) [21:48:20] damilare: hmm, in that loop, the exception isn't going to be caught [21:48:45] ohh why's that? [21:49:10] there's no try/catch inside the foreach ($total_missing['negative'] as $record) { loop [21:49:27] when we hit an already refunded donation we just want to skip it [21:49:34] and go on to process the next refund [21:49:54] yh sorry didn't know that's what you meant. Ok, i'd add that [21:50:32] so I don't think a try/catch is the simplest way here [21:51:09] Maybe just replace that throw line with a continue; statement [21:51:37] yep [21:57:22] (03CR) 10CI reject: [V: 04-1] Move contribution_source population into code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/829073 (owner: 10Ejegg) [22:08:05] (03CR) 10Ejegg: "This looks good! Maybe just remove the change to braintree.adapter.php since it's not going to be hit with the current version of your Sma" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/822191 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [22:10:19] (03PS16) 10Wfan: Check if currency supported by braintree merchant account [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/822191 (https://phabricator.wikimedia.org/T312808) [22:10:57] (03CR) 10Ejegg: "Another thought for dealing with non-donor-fixable ValidationErrors like order_id inline" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/822191 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [22:16:26] (03CR) 10Ejegg: [C: 04-1] "I think we don't need this patch. As suggested on the parent patch, we should just show a retry link if there's a problem the donor can't " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/826653 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [22:17:21] (03Abandoned) 10Wfan: Add more invalid error translation currency, order_id and payment_token [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/826653 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [22:17:27] (03CR) 10Ejegg: "Ok, I just found the existing message key for invalid currency and put in in an inline comment" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/822191 (https://phabricator.wikimedia.org/T312808) (owner: 10Wfan) [22:17:56] sorry wfan, just found one more thing! ^^^ [22:18:55] ok, yeah I realized the donate_interface-error-msg-invalid-currency before, will do the update with order_id and payment_token check :) Thanks~ [22:27:54] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10FR-form-chooser-refactor: Document new gateway chooser logic and settings - https://phabricator.wikimedia.org/T315011 (10AnnWF) https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_flow/PSP_integra... [22:41:41] (03PS9) 10Ejegg: Opt out braintree transaction from paypal audit [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/827523 (https://phabricator.wikimedia.org/T315258) (owner: 10Wfan) [22:41:45] (03CR) 10Ejegg: [C: 03+2] Opt out braintree transaction from paypal audit [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/827523 (https://phabricator.wikimedia.org/T315258) (owner: 10Wfan) [22:43:42] (03Merged) 10jenkins-bot: Opt out braintree transaction from paypal audit [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/827523 (https://phabricator.wikimedia.org/T315258) (owner: 10Wfan) [22:47:06] (03PS9) 10Damilare Adedoyin: Ingenico audit parser sending already-refunded donations to refund queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) [22:48:35] thanks ejegg, patch updated. [22:48:37] o/ [22:48:56] bkuhvncvve [22:48:59] hmmm haha