[00:38:45] (03CR) 10Jforrester: [C: 03+2] build: Disable phan option scalar_implicit_cast and make pass (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/828082 (https://phabricator.wikimedia.org/T316575) (owner: 10Umherirrender) [00:42:41] (03Merged) 10jenkins-bot: build: Disable phan option scalar_implicit_cast and make pass [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/828082 (https://phabricator.wikimedia.org/T316575) (owner: 10Umherirrender) [05:00:57] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_37) - 10https://gerrit.wikimedia.org/r/829932 (owner: 10L10n-bot) [07:14:59] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_37) - 10https://gerrit.wikimedia.org/r/829932 (owner: 10L10n-bot) [08:56:34] 10Fundraising Tech - Chaos Crew, 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail, and 2 others: DMarc Email Address for Wikimedia.org - https://phabricator.wikimedia.org/T316899 (10MatthewVernon) @Jgreen It looks to me like this is no longer an SRE access request; are you OK with me removing t... [12:59:58] howdy fr-tech! [13:02:06] jgleeson: fr-tech hellosie-ohs [13:02:27] jgleeson: is there a way to send up a WIP PR to the uml diagram repo? [13:03:10] As in, I don't want to request it be pulled yet, just like a Gerrit change that I'd like to let people see but that isn't ready to be +2'ed [13:03:29] a don't-P-yet-R ? [13:04:00] AndyRussG: how about a new branch called something like WIP-yadayada [13:04:34] and then we can merge it to master/main once you're ready [13:04:46] jgleeson: so not cloning a personal copy of the repo under my Gitlab account? [13:04:57] like what's the normal CR flow? [13:06:09] oh looks like you're right [13:06:12] https://m.mediawiki.org/wiki/GitLab/Workflows/Code_review [13:06:35] you could do that too. I'm guessing we'll probably use gitflow or one of the newer approaches [13:07:08] https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow [13:07:31] https://www.mediawiki.org/wiki/GitLab/Workflows#Making_a_GitLab_Merge_Request [13:07:45] cool thx! :) [13:08:11] looks like you can make a branch on the mainline repo [13:08:17] yeah [13:08:19] hmm gotta learn what the equivalent of patch sets are too [13:08:50] yeah the gerrit way is definitely different to what I worked with before coming here [13:09:03] after using gerrit for so long I'd forgot most of what came before [13:09:24] looks like gitflow, the model I used to follow, is now a legacy workflow [13:09:26] :O [13:11:37] next workflow in 5 years: submit first to AI CR [13:12:38] LOL [13:17:39] the UK has a new Prime Minister. Boris Johnson is finally out and has been replaced by Liz Truss. The Queen made them both travel to Scotland today to ask to form a new government. I wonder if she's ever replied "no" to try add a bit of humour to things :) [13:18:30] No, sadly you can't form a government just now, I need to walk the dogs [13:18:36] ahhh heheh [13:18:41] yeah I've been unsuccessful in my news avoidance this past week [13:18:58] especially regarding Ukraine [13:19:35] It looks like the counter offensive is really working [13:19:46] from what I saw on TV [13:22:28] Pretty slick from the Ukrainians. The Ukrainian military talked down the prospect of taking back parts of Southern Ukraine to the point of maybe making the Russians get too comfortable and then launched a stinging counter offensive and swept over the area pushing the Russian Army out. [13:30:54] I did not know Ben Stiller was involved with the UN. Apparently he's a goodwill ambassador for the UN High Commissioner for Refugees (UNHCR). He met with Zelensky https://www.bbc.co.uk/news/world-europe-62806655 [13:32:54] oh hmmmm [13:33:32] damilare|away: I'm popping on the school run now but we can hopefully chat when I get back if you're free. I've got an idea about how we can retain the approvePaymentAndReturnStatus so my thinking is I'll push it up and then you can overlay your updates on that, hopefully! [13:33:58] approvePaymentAndReturnStatus steps* [13:34:04] back soon! [13:37:18] Hi jgleeson|skrun AndyRussG fr-tech [13:42:16] :) [14:05:57] hi fr-tech [14:06:46] sure thing jgleeson [14:09:07] 10Fundraising Tech - Chaos Crew, 10fundraising-tech-ops, 10Mail: DMarc Email Address for Wikimedia.org - https://phabricator.wikimedia.org/T316899 (10Jgreen) >>! In T316899#8213167, @MatthewVernon wrote: > @Jgreen It looks to me like this is no longer an SRE access request; are you OK with me removing that t... [14:15:43] :) [14:42:15] howdy cstone damilare ! [14:42:39] hi jgleeson [14:44:11] also hi AndyRussG! sorry thought I'd said hi [14:44:52] IRC formalities and all [15:14:04] 10Fundraising-Backlog, 10Growth-Team, 10Growth-Team-Filtering, 10MassMessage, and 14 others: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Dreamy_Jazz) [16:12:41] fr-tech here are the UML diagrams I have so far!!!! more in my notes that I haven't added, and just a tidbit to add before bifurcation that explains states to resolve by PTR [16:12:43] https://gitlab.wikimedia.org/repos/fundraising-tech/fr-tech-diagrams/-/tree/donation-flows/donation_flows [16:12:56] gotta run to an errand before upcoming meeting, back soon! [16:15:52] nice AndyRussG ! [16:16:10] thx!!!! :) [16:43:26] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10donate.wikimedia.org, 10fr-donorservices, 10FR-Email: Donation Form Error Message - Country Detection - https://phabricator.wikimedia.org/T316578 (10TSkaff) @XenoRyet howdy! I see this is resolved, but this happened to me today,... [17:07:17] 10Fundraising Tech - Chaos Crew, 10Patch-For-Review: Document contribution_tracking contibution_source tbl triggers - https://phabricator.wikimedia.org/T316898 (10jgleeson) This is related to the issue in T316949 [17:32:07] 10Fundraising Sprint Potato, 10FR-Adyen: Write code for Adyen Pending Transaction Resolver - https://phabricator.wikimedia.org/T316587 (10AnnWF) a:05AndyRussG→03AnnWF [17:38:11] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Complete Adyen Checkout documentation to include donation statuses for all stages/permutations - https://phabricator.wikimedia.org/T316583 (10Damilare) [17:40:11] hi jgleeson, were you able to push the approvePaymentAndReturnStatus to the uml diagram [17:41:03] I'm looking at that now damilare [17:41:18] inbetween tasks sorry [17:41:37] okk cool, give me a shout if you need a chat or something [17:41:39] no p [17:41:39] I'm breaking out the switch so it's a but fiddly [17:41:46] bit* [17:41:54] right that area is quite dense [17:44:36] damilare: I was looking at hotels near the Civicrm training and sprint venue next month and it looks like there's a Premier Inn really close and it's only £48 a night https://www.premierinn.com/gb/en/hotels/england/greater-manchester/manchester/manchester-city-centre-princess-street.html [17:45:02] that chain is usually pretty good [17:45:55] nice we should get our booking in early then [17:46:06] thanks for bringing this up [17:47:22] hi fr-tech! [17:47:40] Hi Elliott~ [17:47:40] hi ejegg ! [17:47:52] hi ejegg [17:48:13] yep I'm gonna try and get mine booked this week damilare. that hotel is only a 12 min walk too! https://goo.gl/maps/xhLEd4ApoDGY5NDm6 [17:48:31] (one of the things distracting me :O) [17:48:43] so wfan jgleeson damilare I'd like to move the population of the contribution_source table into php from SQL if that sounds good [17:49:07] I've got the existing triggers (and table) sql checked in with this commit: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/829051 [17:49:23] and then the PHP version in this commit: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/829073 [17:50:00] still got one more patch to write that will fix the backfill SQL script to work with the iDEAL rows that have three dots [17:51:22] sounds good ejegg [17:52:29] +1 [17:52:41] anyone available for code review on those first two? [17:52:56] would it make sense to update the triggers file in the second commit to mention about it being deprecated [17:53:30] yep, I could even remove them with that commit jgleeson [17:54:10] Why the second one does not have ticket number? [17:54:16] sounds good, also please let's have the bug ticket in the commit message for this: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/829073 [17:54:25] I assume it's the same for the fitst [17:55:26] wfan I'll add that too [17:55:52] Haha, sounds good~ [17:56:32] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Adyen - UML sequence diagrams - https://phabricator.wikimedia.org/T316584 (10AnnWF) https://gitlab.wikimedia.org/repos/fundraising-tech/fr-tech-diagrams/-/tree/donation-flows/donation_flows [17:57:03] (03PS3) 10Ejegg: Move contribution_source population into code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/829073 (https://phabricator.wikimedia.org/T316949) [17:57:38] ok wfan damilare jgleeson ^^^ has the ticket number and gets rid of the triggers file [17:58:40] Oh I guess I tagged the patch that checks the current triggers in to the 'document' ticket and this patch to the 'Null banner entries for "_ideal"' ticket [17:59:10] now to fix that backfill script [18:09:39] huh, local mysql server stopped working with this morning's dist-upgrade [18:09:47] good thing there's the docker env! [18:18:12] (03CR) 10Wfan: [C: 03+2] "works perfect and the test instruction is very helpful~" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828129 (https://phabricator.wikimedia.org/T315102) (owner: 10Ejegg) [18:19:52] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10donate.wikimedia.org, 10fr-donorservices, 10FR-Email: Donation Form Error Message - Country Detection - https://phabricator.wikimedia.org/T316578 (10XenoRyet) 05Resolved→03Open p:05Unbreak!→03High [18:20:18] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog, 10donate.wikimedia.org, 10fr-donorservices, 10FR-Email: Donation Form Error Message - Country Detection - https://phabricator.wikimedia.org/T316578 (10XenoRyet) Reopening, was able to reproduce following Thea's steps in a fresh br... [18:20:53] (03PS1) 10Ejegg: Update contribution_source backfill for iDEAL [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830232 (https://phabricator.wikimedia.org/T316949) [18:23:30] ejegg: for this drush @wmff cvapi ContributionRecur.cancelInactives version=4, are we have the date settled as 60days and should you add this cmd to cron? [18:23:48] wfan right, we will add the command to cron [18:24:06] I will check with Eileen whether she thinks 60 days is good [18:24:24] but if it needs a change we can just put the number on the command line [18:24:35] thank you for the code review! [18:24:54] cool~ I will not move this ticket to pending deploy yet then~ [18:24:58] np [18:31:32] jgleeson: what's the command to run the install scripts again? [18:32:23] (03Merged) 10jenkins-bot: Add ContributionRecur::cancelInactives API4 Action [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828129 (https://phabricator.wikimedia.org/T315102) (owner: 10Ejegg) [18:32:34] (03Merged) 10jenkins-bot: Fix legacy paypal reactivate function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828666 (https://phabricator.wikimedia.org/T242158) (owner: 10Ejegg) [18:33:57] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10donate.wikimedia.org, and 2 others: Donation Form Error Message - Country Detection - https://phabricator.wikimedia.org/T316578 (10XenoRyet) [18:34:50] 10Fundraising-Backlog, 10FR-Tech-Analytics, 10Patch-For-Review: Null banner entries for "_ideal" banners/donations - https://phabricator.wikimedia.org/T316949 (10XenoRyet) p:05Triage→03Unbreak! [18:35:01] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen iframe config error messages inside card fields - https://phabricator.wikimedia.org/T292571 (10MBeat33) @AMJohnson found ticket 1164346, where the donor got the same //The iframe has not configured - see suggestions in Console// error message on Se... [18:35:33] 10Fundraising Sprint Potato, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Tech-Analytics, 10Patch-For-Review: Null banner entries for "_ideal" banners/donations - https://phabricator.wikimedia.org/T316949 (10XenoRyet) [18:49:31] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Adyen iDEAL TY email delay - https://phabricator.wikimedia.org/T316602 (10XenoRyet) [19:04:29] damilare for the install scripts, run drush @wmff updb [19:04:43] thanks ejegg [19:37:42] 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, and 4 others: configure endpoint monitoring for Braintree API hosts - https://phabricator.wikimedia.org/T311727 (10Jgreen) [19:38:56] 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, and 4 others: configure endpoint monitoring for Braintree API hosts - https://phabricator.wikimedia.org/T311727 (10Jgreen) [19:39:11] 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, and 4 others: configure endpoint monitoring for Braintree API hosts - https://phabricator.wikimedia.org/T311727 (10Jgreen) [19:41:02] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Complete Adyen Checkout documentation to include donation statuses for all stages/permutations - https://phabricator.wikimedia.org/T316583 (10XenoRyet) [19:41:12] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising-Backlog: Review steps and create subtasks for Adyen Pending Transaction Resolver - https://phabricator.wikimedia.org/T316582 (10XenoRyet) [19:41:32] 10Fundraising Sprint NaN is a Number, 10Fundraising-Backlog, 10Epic: [epic] Adyen - auto settle stopped prior donors (Pending transaction Resolver) - https://phabricator.wikimedia.org/T299692 (10XenoRyet) [19:45:44] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Name changes required for Ingenico 3S2.0 - https://phabricator.wikimedia.org/T312877 (10XenoRyet) p:05Medium→03Low [19:46:35] 10Fundraising Sprint Potato, 10Fundraising-Backlog: Unit tests for Adyen Pending Transaction Resolver - https://phabricator.wikimedia.org/T316588 (10XenoRyet) [19:46:45] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Complete Adyen Checkout documentation to include donation statuses for all stages/permutations - https://phabricator.wikimedia.org/T316583 (10XenoRyet) p:05Triage→03Medium [19:47:13] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Document how to test Adyen Pending Transaction Resolver locally - https://phabricator.wikimedia.org/T316585 (10XenoRyet) p:05Triage→03Medium [19:48:35] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29): Remove incomplete iDeal transactions from CiviCRM - https://phabricator.wikimedia.org/T316780 (10XenoRyet) p:05Triage→03Medium [19:55:38] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Get imports running in the background - https://phabricator.wikimedia.org/T312166 (10Eileenmcnaughton) a:03Eileenmcnaughton [21:10:42] 10Fundraising-Backlog: Look into paypal recurrings that are status pending but no next_sched_contribution_date - https://phabricator.wikimedia.org/T317164 (10Cstone) [21:11:31] 10Fundraising-Backlog: Look into paypal recurrings that are status pending but no next_sched_contribution_date - https://phabricator.wikimedia.org/T317164 (10AnnWF) [21:18:02] damilare: I've pushed up an updated pending transaction resolver activity diagram here https://gitlab.wikimedia.org/repos/fundraising-tech/fr-tech-diagrams/-/commit/6d9cd8c20a6422fd232965ffb499c040f92fa30a [21:18:26] feel free to ignore it now, I know it's late but we can hopefully chat tomorrow [21:18:32] jgleeson: we didn't record too much cause lots of PII but ive updated the tech talk recordings here from today https://wikitech.wikimedia.org/wiki/Fundraising/Team_processes/Tech_talks [21:18:35] cool. O [21:18:47] cool. I'd check it out tomorrow first thing [21:18:47] thanks cstone ! [21:18:57] thanks jgleeson for all the work on theat [21:19:00] that* [21:19:01] sounds good damilare! [21:19:09] thank you for all the review! [21:19:17] see you all tomorrow! [21:19:21] o/ [21:19:47] (03PS1) 10Ejegg: Cancel inactives even with a cancel_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830266 (https://phabricator.wikimedia.org/T315102) [21:20:08] eileen there's the cancel_date change ^^^ [21:20:13] hmm, no eileen in IRC? [21:21:52] bye for now fr-tech [21:21:59] (03CR) 10Eileen: [C: 03+2] Cancel inactives even with a cancel_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830266 (https://phabricator.wikimedia.org/T315102) (owner: 10Ejegg) [21:22:05] thanks eileen ! [21:23:54] oh hey, the trigger generation code is already deployed [21:24:09] I can regenerate that file right now [21:27:57] 10fundraising-tech-ops: Fundraising access request for lmedley - https://phabricator.wikimedia.org/T314075 (10Dwisehaupt) @LMedley-WMF That looks like it is correct and I added it to our setup along with your ssh public key back on Aug 4th. I believe I communicated back to you to try to login but just wanted to... [21:28:51] (03PS1) 10Ejegg: Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830271 [21:29:06] ok eileen, there's the trigger update ^^^ [21:29:33] looks like planned giving has made a couple of new tables [21:33:07] 10fundraising-tech-ops: Fundraising access request for dbu - https://phabricator.wikimedia.org/T314827 (10Dwisehaupt) [21:34:47] 10fundraising-tech-ops: Fundraising access request for dbu - https://phabricator.wikimedia.org/T314827 (10Dwisehaupt) @DBu-WMF I just wanted to check back in and see if you needed assistance with the SSH setup of if that was not access you needed at this point? [21:35:25] (03Merged) 10jenkins-bot: Cancel inactives even with a cancel_date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830266 (https://phabricator.wikimedia.org/T315102) (owner: 10Ejegg) [21:39:03] dwisehaupt: OK, I've got the triggers dumped on prod for an update. They're checking in to gerrit in https://gerrit.wikimedia.org/r/830271 (waiting for eileen to review) but they're also in the civi dir under sites/default/files/civicrm/ConfigAndLog/CiviCRM.trigger6317baab73df8r4ZQ7702126718965e4a41105a08d6202e60.sql [21:39:14] *checked in to gerrit [21:40:42] cstone: I'm going to do a civi deploy soon. Want to tag another version of donation-interface so we can get that and smash-pig updated in the same deploy? [21:41:22] Yes but I'm picking up takeout for dinner 😂 I'll be back in like 20 mins [21:41:33] ok great - i just realized I could do one more smashpig point version first [21:41:43] to get the Ingenico idempotency headers too [21:41:48] Nice [21:42:13] ejegg: ok. i'll take a look. [21:42:46] dwisehaupt: very little change, just logging for a couple new custom value tables that look like they were added by the planned giving folks [21:42:58] and one extra line to the contribution_recur update trigger [21:43:11] that will update the contact modification date [21:45:00] (03PS1) 10Ejegg: update smash-pig requirement to 0.8.2.9 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/830273 [21:45:03] (03CR) 10Ejegg: [C: 03+2] update smash-pig requirement to 0.8.2.9 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/830273 (owner: 10Ejegg) [21:46:24] ejegg: just so i'm clear, these are triggers on the civi db and not drupal db like we looked at last week. correct? [21:46:37] dwisehaupt: yep, exactly! [21:47:00] hopefully later today we can drop a trigger on the drupal db, but the code to replace it is still in review [21:47:46] (03Merged) 10jenkins-bot: update smash-pig requirement to 0.8.2.9 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/830273 (owner: 10Ejegg) [21:52:48] ok. let me know when it's all reviewed and such and i can roll them out. [21:52:51] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10Patch-For-Review: Custom field "AF_has_active_recurring_donation" is showing false positives - https://phabricator.wikimedia.org/T315102 (10Eileenmcnaughton) Just noting I tested the recurs we expect t... [21:54:06] (03CR) 10Eileen: [C: 03+2] "Guess planned giving added a custom field huh...." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830271 (owner: 10Ejegg) [21:56:55] 10Fundraising-Backlog: Look into paypal recurrings that are status pending but no next_sched_contribution_date - https://phabricator.wikimedia.org/T317164 (10Eileenmcnaughton) Note my query ` select cr.next_sched_contribution_date, count(*), cr.contact_id,cr.id, MAX(create_date) FROM civicrm_contribution_recur... [21:57:28] 10Fundraising-Backlog: Look into paypal recurrings that are status pending but no next_sched_contribution_date - https://phabricator.wikimedia.org/T317164 (10Eileenmcnaughton) [21:57:31] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10Patch-For-Review: Custom field "AF_has_active_recurring_donation" is showing false positives - https://phabricator.wikimedia.org/T315102 (10Eileenmcnaughton) [21:58:25] ejegg: that is merged - and I put my validation queries on the ticket & linked the two phabs [22:02:45] thanks! [22:04:59] (03PS1) 10Ejegg: Update own version number [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/830277 [22:05:13] oops, that was against deployment [22:05:36] (03Abandoned) 10Ejegg: Update own version number [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/830277 (owner: 10Ejegg) [22:05:59] (03PS1) 10Ejegg: Update own version number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/830278 [22:06:04] (03CR) 10Ejegg: [C: 03+2] Update own version number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/830278 (owner: 10Ejegg) [22:06:42] ejegg heyyy I see a bunch of patches flying by but I don't know if they're related to the urgent Chaos Crew iDEAL issue [22:06:44] dwisehaupt: ok, they're reviewed! [22:07:04] did eileen +2 stuff? [22:07:08] AndyRussG: nope, these here are for a civi deploy [22:07:14] ah oki [22:07:34] AndyRussG: she +2ed the things for the contribution recur status issues [22:07:43] ah cool [22:07:49] ejegg: ok. i'll get started on the things. stopping the queues first. [22:07:55] thanks dwisehaupt [22:09:13] ejegg I was thinking of resting my brain another 30 min or so before trying to understand this stuff... can I ask about how long might u be around today? [22:09:30] AndyRussG: probably another 3-4 hours [22:10:02] oki thx! [22:10:15] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/830279 [22:10:22] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/830279 (owner: 10Ejegg) [22:15:49] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/830281 [22:15:52] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/830281 (owner: 10Ejegg) [22:17:30] (03Merged) 10jenkins-bot: Update own version number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/830278 (owner: 10Ejegg) [22:18:43] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/830279 (owner: 10Ejegg) [22:21:01] ejegg: eileen: ok. triggers applied. anything you wish to test? [22:21:09] thanks dwisehaupt [22:21:23] I guess I can update a recurring on my own record and see my modified date update [22:22:07] ok ejegg I am back [22:22:37] cool cool cstone [22:22:58] want to pull the latest on DI and make a new tag for composer? [22:23:04] sure [22:23:26] I just merged an update to the smash-pig requirement in DI's composer.json [22:23:44] and updated the version number in extension.json to the probably next tag [22:23:57] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/830281 (owner: 10Ejegg) [22:24:08] did you tag a new smashpig too? [22:25:04] oh i see 9/1 was commit date ok cool [22:25:34] cstone yep yep [22:25:54] dwisehaupt: ok, that modified_date trigger looks good! [22:26:11] dwisehaupt: I'd say we're ready to turn queues back on [22:26:13] PROBLEM - check_mysql on frdb2002 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2002&service=check_mysql [22:26:16] cool. i'll reenable replication on the canary and turn them back on. [22:29:19] ok. jobs re-enabled and replication flowing again [22:29:35] ok 2.5.7.8 https://packagist.org/packages/wikimedia/donation-interface [22:30:44] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising-Backlog: Custom field "AF_has_active_recurring_donation" is showing false positives - https://phabricator.wikimedia.org/T315102 (10AnnWF) After deploy, needs to confirm the date and add this cmd `drush @wmff cvapi... [22:31:15] RECOVERY - check_mysql on frdb2002 is OK: Uptime: 1060489 Threads: 10 Questions: 53178951 Slow queries: 524 Opens: 2272 Flush tables: 1 Open tables: 948 Queries per second avg: 50.145 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2002&service=check_mysql [22:34:43] (03PS1) 10Cstone: Update SmashPig to v0.8.2.9 and DonationInterface to v2.5.7.8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830282 [22:35:34] thanks again dwisehaupt [22:35:42] it being so dark out cause its finally raining is really messing with my sense of time [22:36:16] (03CR) 10Ejegg: [C: 03+2] Update SmashPig to v0.8.2.9 and DonationInterface to v2.5.7.8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830282 (owner: 10Cstone) [22:36:47] hah was just making sure i put the right versions in the commit message but i did [22:39:43] do we have an idea on how long until the drupal triggers would want to be done? just asking to get a time on if i can make it to cover for piano in 20 mins or not. [22:41:44] it takes longer than that to merge through to deploy I think - when will you be back? [22:42:26] i would be back in.... about an hour from now, ish. probably a little bit less. [22:42:52] yeah - you should do that then [22:43:25] ok cool. i may be back sooner but it depends on how fast $kid's bus is. slow bus == piano for me. [22:45:54] dwisehaupt: I think AndyRussG will look at the stuff in half an hour or so [22:46:04] and will probably come up with things to fix [22:46:27] so that would be at least an hour, probably two before it's ready [22:46:31] kk. that works good for me. [22:46:59] ahhhh [22:49:41] (03CR) 10CI reject: [V: 04-1] Update SmashPig to v0.8.2.9 and DonationInterface to v2.5.7.8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830282 (owner: 10Cstone) [22:50:12] why fail [22:51:29] ok. i'll see you all in 45 mins or so. [22:52:54] why audit tests failing hmm [22:57:23] ohh, new field added [22:57:28] but that failure looks wrong [22:57:43] I guess the assertion has expected and actual mixed up [22:57:57] why do we always has string int error? [22:58:32] did we change how we run the tests locally i cant get them to run [22:58:40] cstone: it's from this smashpig patch: 8bbaaeeb26d7a84d42cc09b0785254481f8fe70a [22:58:54] oh cstone? what happens when you try? [22:59:35] well nothing was autocompleting so i tried the drush script then that errors out [22:59:40] for civi tests [23:01:18] ohhhh you maybe have to do another composer install (sans --no-dev) to get phpunit back? [23:02:40] cstone: ./civicrm-phpunit.sh wmff works for me after I do another composer install [23:02:49] ah okay [23:02:59] yeah I was running ./vendor/bin/phpunit --filter testParseFiles from wmff, and seems working fine~ [23:03:03] but do we just need to add that new field to the audit tests then [23:03:20] yeah ./vendor/bin wasn't autocompleting then i was helpless haha [23:04:21] do you mean the gateway_account ? [23:04:44] the test output is so hard to read but yeah i guess [23:06:19] woo autocomplete works again [23:07:51] ok cool got them to break locally [23:10:37] cstone: if those assert params are in the wrong order feel free to flip them around in the test fix! [23:13:17] wont this break the old tests now ? it's not locally but [23:16:00] (03PS1) 10Cstone: Update tests to match change SmashPig's https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/436086 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830306 [23:16:03] lets see [23:16:42] does ingenico need the merchant account ? [23:16:59] ejegg: so the update to the trigger and the new PHP code to replace it should go out simultaneously I guess? [23:18:34] AndyRussG: the current trigger is checked in for historical purposes and then deleted in the patch that replaces it with code. [23:19:19] The third patch in that chain is an update to the backfill script, and I would like to run that while I have the queues off for deployment [23:21:30] cstone: oh shoot, it really is sending back one fewer param? [23:21:36] ejegg: and the first patch? it's linked to this task https://phabricator.wikimedia.org/T316898 which says "document etc etcf" [23:21:46] should it be linked to the new one too then? [23:22:01] AndyRussG: right, that's to document the current state of things [23:22:25] well, to bring it out of complete obscurity into a dim candle light at least [23:22:43] but that patch doesn't do anything to fix the _ideal bug [23:22:47] its adding one and removing some? but why aren't my local tests breaking hmm [23:23:22] ejegg: k brain not working well.... hmmm so the first patch is documentation in the form of code? [23:23:36] AndyRussG: yep yep [23:23:51] oh now they are okay [23:23:54] ejegg: ok and why is it needed for the iDEAL issue? [23:23:58] +1 for brain not working well [23:24:10] AndyRussG: in the next patch I add some code that writes to that table [23:24:21] and the code fails tests when the table doesn't exist [23:24:28] hmmm [23:24:42] ejegg: and why again did we document something via code? [23:24:58] was it like existing on production because of ad-hoc stuff done to prod or something? [23:25:08] AndyRussG: sort of? [23:25:34] sorry to be a second convo here but what do we need to do force merge the smashpig one then let the test one run naturally? [23:25:35] A long time ago the contributionTracking mediawiki extension had a direct connection string to drupal [23:25:48] including creating tables and triggers [23:25:54] or other way ? [23:25:57] ejegg: I realize it's been a pretty meeting-heavy day but if you'd like to do a call to discuss that might help [23:26:00] cstone: why not squash the patches? [23:26:06] cstone: ah you're talking about something different? [23:26:11] haha yeah sorry [23:26:18] hmm [23:26:26] AndyRussG: so the code used to be in a mediawiki extension which managed a table in the drupal database [23:26:26] cstone: heheh no worries just thought I'd check [23:26:50] https://phabricator.wikimedia.org/diffusion/ECNT/browse/master/;22cb54fc457b7b7d7aaaa38d86393b65ff5ae809 [23:27:03] eileen: fr-tech: anyone want to do a call to chat about https://phabricator.wikimedia.org/T316949 ? [23:27:17] I can in a few minutes [23:27:20] yep - in fifteen? [23:27:34] thx eileen ejegg !!! :) [23:27:45] (03CR) 10CI reject: [V: 04-1] Update tests to match change SmashPig's https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/436086 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830306 (owner: 10Cstone) [23:28:19] computer why you freeze [23:28:28] cstone: so in general when I update a lib that necessitates a test change, I will update the tests in that same patch [23:28:35] K I'll take a sec to get another snack then [23:29:03] ok ejegg that makes sense I guess i was thinking i would keep them separate for i dont know tiredbrain reasons [23:29:21] (03Abandoned) 10Cstone: Update tests to match change SmashPig's https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/436086 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830306 (owner: 10Cstone) [23:35:02] K I'm in the earlier tech-talk meet https://meet.google.com/rvq-ygtd-xgm?authuser=1 [23:35:08] K I'm in the earlier tech-talk meet https://meet.google.com/rvq-ygtd-xgm rather [23:36:15] (03PS2) 10Cstone: Update SmashPig to v0.8.2.9 and DonationInterface to v2.5.7.8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830282 [23:48:01] sorry will be a few more mins [23:53:46] (03CR) 10Cstone: [C: 03+2] Update SmashPig to v0.8.2.9 and DonationInterface to v2.5.7.8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830282 (owner: 10Cstone)