[00:06:41] (03Merged) 10jenkins-bot: Update SmashPig to v0.8.2.9 and DonationInterface to v2.5.7.8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830282 (owner: 10Cstone) [00:07:57] (03PS3) 10Ejegg: Add SQL for contribution_source [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/829051 (https://phabricator.wikimedia.org/T316898) [00:09:15] (03PS2) 10Ejegg: Update contribution_source backfill for iDEAL [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830232 (https://phabricator.wikimedia.org/T316949) [00:10:20] (03PS4) 10Ejegg: Add SQL for contribution_source [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/829051 (https://phabricator.wikimedia.org/T316898) [00:10:35] (03PS4) 10Ejegg: Move contribution_source population into code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/829073 (https://phabricator.wikimedia.org/T316949) [00:13:52] (03PS1) 10Cstone: Update SmashPig to v0.8.2.9 and DonationInterface to v2.5.7.8 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/830309 [00:14:31] (03CR) 10Cstone: [C: 03+2] Update SmashPig to v0.8.2.9 and DonationInterface to v2.5.7.8 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/830309 (owner: 10Cstone) [00:16:18] (03CR) 10AndyRussG: [C: 03+2] "Thanks for update as per live CR!!! :) :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/829051 (https://phabricator.wikimedia.org/T316898) (owner: 10Ejegg) [00:21:07] (03PS3) 10Ejegg: Update contribution_source backfill for iDEAL [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830232 (https://phabricator.wikimedia.org/T316949) [00:26:37] (03Merged) 10jenkins-bot: Update SmashPig to v0.8.2.9 and DonationInterface to v2.5.7.8 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/830309 (owner: 10Cstone) [00:28:27] (03Merged) 10jenkins-bot: Add SQL for contribution_source [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/829051 (https://phabricator.wikimedia.org/T316898) (owner: 10Ejegg) [01:23:31] OK, I'm just going to deploy up through the SmashPig update [01:23:39] and we'll do the contribution_tracking bit tomorrow [01:25:46] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/830314 [01:26:30] (03CR) 10AndyRussG: [C: 03+2] "Thanks so much for this, for the explanations and the hand-holding while live debugging! :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/829073 (https://phabricator.wikimedia.org/T316949) (owner: 10Ejegg) [01:26:43] (03PS2) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/830314 [01:26:46] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/830314 (owner: 10Ejegg) [01:28:34] (03CR) 10CI reject: [V: 04-1] Move contribution_source population into code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/829073 (https://phabricator.wikimedia.org/T316949) (owner: 10Ejegg) [01:28:45] oh hmm [01:29:26] huh? [01:29:44] i don't see the problem there [01:29:56] (03CR) 10Ejegg: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/829073 (https://phabricator.wikimedia.org/T316949) (owner: 10Ejegg) [01:30:43] (03CR) 10AndyRussG: Update contribution_source backfill for iDEAL (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830232 (https://phabricator.wikimedia.org/T316949) (owner: 10Ejegg) [01:30:46] eileen: does 60 days seem like a good value for that cancelInactives Action? We can specify something else on the command line if not [01:32:10] (03CR) 10Ejegg: Update contribution_source backfill for iDEAL (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830232 (https://phabricator.wikimedia.org/T316949) (owner: 10Ejegg) [01:36:47] (03CR) 10AndyRussG: Update contribution_source backfill for iDEAL (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830232 (https://phabricator.wikimedia.org/T316949) (owner: 10Ejegg) [01:45:25] hmm, I'm testing the update on dev_drupal and it is certainly taking a few minutes [01:49:32] shoulda done it under 'screen'... [01:49:52] (03CR) 10AndyRussG: [C: 03+2] "Yaaay works great!!!!!!!!!!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830232 (https://phabricator.wikimedia.org/T316949) (owner: 10Ejegg) [01:49:58] :) thanks AndyRussG ! [01:50:03] ejegg: thank you!!!!!!!!!!!! [01:50:51] and on top of everything let's celebrate the loss of a superfluous level of parens in a WHERE clause [01:51:05] heh, yeah, that was bothering me [01:51:20] I was like, could that possibly be there for a reason? [01:51:35] cute trick for counting the number of commas though [01:51:46] I mean periods [01:53:40] heh, inspired by how the old SQL trigger was doing it [01:57:03] !log updated payments-wiki from 648842f9 to de4b2bb9 [01:57:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:02:54] (03Merged) 10jenkins-bot: Move contribution_source population into code [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/829073 (https://phabricator.wikimedia.org/T316949) (owner: 10Ejegg) [02:02:56] (03Merged) 10jenkins-bot: Update contribution_source backfill for iDEAL [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830232 (https://phabricator.wikimedia.org/T316949) (owner: 10Ejegg) [02:16:02] !log civicrm upgraded from 5aa1309d to 2fcd3bb4 [02:16:03] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:25:48] ugh, rolling back [02:26:35] !log rolled back civicrm from 2fcd3bb4 to 5aa1309d [02:26:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:27:40] argh bargh [02:27:56] X-Idempotency-Key seems to have screwed up the auth headers [02:37:00] ejegg: ? [02:37:10] AndyRussG: that failstorm [02:37:23] was caused by the deployment of the idempotency headers [02:37:40] which i thought I had tested locally by making donations through the console\ [02:37:58] but of course were only going to be hit by the recurring charge job [02:38:07] hmmm [02:38:34] the new header needs to be part of the signed string when calculating the authentication header [02:38:45] so I rolled back on prod [02:39:00] hmmm unaware of any of this context but available to help as needed [02:39:03] * AndyRussG googles [02:39:04] but to deploy the other fix we'll need to revert the deploy branch and stuff [02:39:20] The calculation of the auth header is here: https://epayments-api.developer-ingenico.com/s2sapi/v1/en_US/java/authentication.html?paymentPlatform=ALL [02:39:34] The new idempotency header is here: https://epayments-api.developer-ingenico.com/s2sapi/v1/en_US/java/idempotent-requests.html?paymentPlatform=ALL [02:45:40] ok, I think I just want to decrement the failure count for those guys [02:50:05] ugh, of course some of those got cancelled because this bogus failure was the last straw [02:50:40] is there a campaign using Ingenico up somewhere? [02:51:17] no, we have a lot of recurring ingenicos [02:51:31] those 700 failmails were from the recurring job [02:52:31] ohhhh hmm [02:53:20] aww I see what you mean about the cancellation [02:53:42] lemme write some SQL and maybe you can take a quick look? [02:53:48] yep for sure [02:54:04] ugh, maybe I better not run any SQL on prod at this hour though [02:54:17] I'll just try to script it out [02:56:54] oki [03:06:18] (03PS1) 10Ejegg: WIP fix Ingenico Auth for Idempotency headers [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/830318 (https://phabricator.wikimedia.org/T243967) [03:16:16] oh that's nice, there is a list of all the failed contribution_recur_ids right at the top of the process-control output [03:19:47] ah cool [03:23:42] wrt the iDEAL fix if you like ejegg I can deal with trying to get it deployed with Jeff early tomorrow... since it is CC material [03:24:29] oh cool! [03:24:42] So I was just thinking about when would be a good time to do that backfill [03:25:01] it looks like we will need queues off for a good little chunk of time [03:25:25] like maybe half an hour, not sure [03:25:41] on staging it was super slow but that hardware is much less beefy than prod [03:26:00] so i didn't even get it to finish for me there - killed the query after 20 minutes [03:26:09] Maybe batches are the way to go after all [03:26:18] but they'll have to be a lot bigger than 1000 [03:29:10] hmmm [03:29:28] ejegg: well we could also limit by date just to get say the last year [03:29:30] or order by date [03:29:47] also true [03:29:50] and do recent now, and the rest during some maintenance window [03:30:13] yeah, that sounds good [03:30:21] yeah let's start with a batch and see how long it takes on prod [03:31:23] so... i just did. 100k took 1 min 41 sec [03:31:34] i'm going to stop doing things now before i make a bigger mess [03:34:10] ohhh oki! on prod? did you stop the queue consumer? [03:34:19] I guess that's not needed [03:34:32] hah, I probably should have.... [03:34:44] how many rows are there? [03:34:46] and yes on prod [03:34:55] K that's a good measurement [03:35:03] in contribution_tracking? like 79 million or something [03:35:11] okkiiiii hehehe [03:37:44] hmmm we could also have a batch job that runs a bunch every now and again until it finishes [03:38:14] also possible [03:51:11] (03PS1) 10Ejegg: Revert "Update SmashPig to v0.8.2.9 and DonationInterface to v2.5.7.8" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830319 [03:51:17] (03CR) 10Ejegg: [C: 03+2] Revert "Update SmashPig to v0.8.2.9 and DonationInterface to v2.5.7.8" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830319 (owner: 10Ejegg) [03:53:36] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/830320 [03:53:41] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/830320 (owner: 10Ejegg) [03:54:20] ok, that should make crm deployable in the morning [03:54:27] (03CR) 10CI reject: [V: 04-1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/830320 (owner: 10Ejegg) [03:54:34] ecch [03:56:10] https://web.dev/sandboxed-iframes/ [03:56:19] thx ejegg ! [03:56:30] k I believe it's now sleepy sleepy time time [03:57:26] cya! [04:03:44] (03Merged) 10jenkins-bot: Revert "Update SmashPig to v0.8.2.9 and DonationInterface to v2.5.7.8" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830319 (owner: 10Ejegg) [05:08:33] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/830376 (owner: 10L10n-bot) [14:32:59] hiii fr-tech [14:34:07] jgleeson: btw for the dry chaos, we have today an issue with Civi deployability which is blocking deployment of a fix for an UBN task: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/830320 [14:34:53] apparent issue? [14:34:56] 22:54:22 In GitDownloader.php line 156: [14:34:57] 22:54:22 [14:35:00] 22:54:22 The .git directory is missing from /src/vendor/wikimedia/donation-interface [14:35:01] 22:54:22 , see https://getcomposer.org/commit-deps for more information [14:35:04] in CI https://integration.wikimedia.org/ci/job/wikimedia-fundraising-crm-composer-php73-docker/3818/console [14:35:39] (03CR) 10AndyRussG: "resubmit" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/830320 (owner: 10Ejegg) [14:39:21] hey AndyRussG [14:39:43] :) [14:39:54] is this the ideal triggers fix? [14:40:01] that we need to deploy [14:40:25] jgleeson: yeah.... the code for that is merged as of last night [14:40:35] ah cool [14:41:58] AndyRussG: looks like this failed Upgrading wikimedia/donation-interface (v2.5.7.6 => v2.5.7.7): Update of wikimedia/donation-interface failed [14:42:18] maybe the composer lock file isn't right [14:43:40] jgleeson hmmm [14:44:16] hash looks right https://packagist.org/packages/wikimedia/donation-interface#v2.5.7.7 [14:44:48] (03CR) 10AndyRussG: "recheck" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/830320 (owner: 10Ejegg) [14:46:25] (03CR) 10CI reject: [V: 04-1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/830320 (owner: 10Ejegg) [14:46:26] k just tried to jiggle Jenkins a different way now, appears to be running [14:46:33] ahahah and rejected again [14:47:17] jgleeson: I have about 30 min of urgent non-work here right now and can dig in again after that [14:47:22] yeah I think there's something up with the revert [14:47:48] cool AndyRussG I'll take a look also [14:48:07] thx much jgleeson :) :) [15:04:51] ok I found some helpful info on the problem [15:05:24] Im here too but not sure what got rolled back/or deployed [15:05:30] if i can help at all [15:06:23] https://github.com/composer/composer/issues/8840 explains why it's happened. It looks like composer is expecting to file a .git file in the package location as it's being treated as an upgrade [15:06:51] for extra info on composers prefer-dist vs prefer-source, I found this helpful https://stackoverflow.com/questions/16205100/difference-between-composer-prefer-dist-and-prefer-source [15:07:38] so basically this is just a CI issue. I'm guessing we clean out .git files on any non-prefer-dist packages that get installed [15:09:16] hmm and now how to fix it [15:10:41] 10fundraising-tech-ops: Fundraising access request for dbu - https://phabricator.wikimedia.org/T314827 (10DBu-WMF) I now have access to both Superset and Civi. Thank you for your assistance. [15:15:47] hi fr-tech! [15:16:10] hi ejegg [15:16:21] jgleeson: so we need to either delete the new versions of smashpig and donation-interface in packagist [15:16:29] heyyy ejegg cstone :) [15:16:30] or make new versions with the fixes [15:16:50] ejegg: why would we need to delete them? [15:16:51] I think we can delete them just temporarily for now [15:17:01] jgleeson because CI runs composer update [15:17:09] I don't think it is [15:17:13] and if it sees the new versions it tries to update them in vendor [15:17:35] but because donation-interface is installed from source [15:17:44] and not from a zup [15:17:45] *zip [15:17:49] it looks like it's running composer install and trying to install the newer version specified in the composer.lock file [15:18:04] i.e, we're telling it to upgrade [15:18:10] jgleeson that composer.lock was rolled back though [15:18:18] err, reverted [15:19:08] ejegg: check out this output https://integration.wikimedia.org/ci/job/wikimedia-fundraising-crm-composer-php73-docker/3818/console [15:19:41] so loh hmm, it does indeed say 'composer install [15:19:49] ahh [15:19:55] so maybe it's the vendor dir? [15:20:15] let's get the vendor dir lined up with that [15:20:16] it looks like vendor comes with d-i 2.5.7.6 [15:20:33] and the patch composer.lock is telling it to jump to 2.5/7/7 [15:20:36] oops [15:20:43] ok, let's fix vendor then [15:21:02] sounds good [15:21:34] (03PS2) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/830320 [15:21:58] thanks jgleeson! [15:22:14] sorry I was insisting on the wrong thing there [15:22:18] I think this one should work [15:22:27] thanks for pointing out the right solution [15:24:04] I never really understood the --prefer-dist vs --prefer-source stuff until then so thanks for giving me a reason to learn it :) [15:24:24] :) [15:32:15] ok, ok, that merge is passing CI now [15:32:18] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/830320 (owner: 10Ejegg) [15:34:09] jgleeson so for smashpig, composer has both 'source' and 'dist' options available, and that's because we have packagist pointing at the github mirror [15:34:45] github automatically makes a zip file ('dist') available to download any commit, and composer knows how to make the github URL for the zip [15:35:11] but for donation-interface, we still have packagist pointing directly at the gerrit repo [15:35:44] and even though gerrit technically does let you download zips for any commit, composer doesn't know how to find that automatically [15:36:11] so for the gerrit repo it only sees the 'source' available and needs to have the .git folder there to be able to update [15:37:42] aww, nice kid art worked into the presentation in the tech dept meeting [15:37:53] also, more goats [15:42:54] ah jgleeson ejegg thanks for figuring that one out [15:46:33] ah thanks for the info about gerrit not making zips easy to find. I was still not clear why, even with the --prefer-dist flag, composer was pulling in the .git folder [15:48:01] gij [15:48:47] * jgleeson must learn to let yubikey finish before changing terminal tab [15:51:32] it might even just be composer not recognizing that its a gerrit repo? Maybe it just understands how to ask for zips from github because it can recognize the URL [15:52:35] ok, so I will turn off queues to deploy that [15:52:57] looks like not too crazy traffic right now [15:53:40] dwisehaupt or Jeff_Green, is one of you available to drop a couple triggers in a little while? [15:55:40] !log fundraising scheduled jobs disabled for deployment [15:55:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:56:40] hey ejegg, sure [15:56:53] great! [15:57:05] lemme make sure the contribution_tracking queue consumer has stopped [15:57:18] ok [15:57:39] yep [15:57:54] so there are just two triggers on the contribution_tracking table in drupal [15:58:07] ok [15:58:39] I believe they are called contribution_tracking_insert and contribution_tracking_update [15:58:43] we want to drop them both [15:58:58] because we're deploying code to do the work they do in PHP [15:59:07] great, I see them [15:59:24] cool cool, we are all ready to drop them when you are! [15:59:50] ok here goes [16:00:14] done [16:00:18] thanks! [16:00:26] no prob [16:00:36] !log fundraising civicrm upgraded from 5aa1309d to 2fcd3bb4 [16:00:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:01:04] ok, I'll try a backfill of 500k rows while the queues are off [16:01:48] there's a computed where clause in that backfill which makes it kind of slow [16:02:04] that's probably a good thing [16:02:29] oops, meeting time [16:29:16] 10Fundraising Sprint Potato, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Tech-Analytics: Null banner entries for "_ideal" banners/donations - https://phabricator.wikimedia.org/T316949 (10Dwisehaupt) [16:30:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29): Remove incomplete iDeal transactions from CiviCRM - https://phabricator.wikimedia.org/T316780 (10Dwisehaupt) [16:31:24] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29): Generate list of incomplete iDeal donations - https://phabricator.wikimedia.org/T316778 (10Dwisehaupt) [16:33:18] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/830320 (owner: 10Ejegg) [16:34:21] !log fundraising civicrm upgraded from 2fcd3bb4 to c1f0e041 [16:34:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:48:24] 10Fundraising Sprint Potato, 10Fundraising-Backlog: Unit tests for Adyen Pending Transaction Resolver - https://phabricator.wikimedia.org/T316588 (10AndyRussG) a:05AndyRussG→03None [16:50:48] 10Fundraising Sprint Potato, 10FR-Adyen: Write code for Adyen Pending Transaction Resolver - https://phabricator.wikimedia.org/T316587 (10AnnWF) [16:56:09] !log restarted fundraising scheduled jobs [16:56:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:56:39] damilare: I just sent you an invite to be a maintainer on the dev-images repo [16:56:51] wfan: I sent you one too, once you are able to log into your account [16:57:01] received,thanks ejegg [16:58:00] 10Fundraising Sprint Potato, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Tech-Analytics: Null banner entries for "_ideal" banners/donations - https://phabricator.wikimedia.org/T316949 (10Ejegg) OK, the fix is deployed and the last million or so rows of missing data have been backfilled (sh... [16:58:16] Thanks ejegg, and noticed that you have one pr https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/828667 not merged yet, but ticket in pending deployment~ [16:58:36] ohhh, oops! [16:58:48] I thought people had already reviewed that :) [16:58:54] sorry, it should be in review [16:59:20] i think I addressed all of jgleeson's comments in PS3 [16:59:35] so if someone wants to take another look that would be great! [16:59:38] what now [16:59:47] ah lemme check [17:01:42] ejegg: do you think it's worth including some of that explanation as a comment near the code? >https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/828667/3/drupal/sites/all/modules/wmf_civicrm/wmf_civicrm.module [17:01:56] Looks fine for me just wanna jack to take another look haha [17:02:12] or is it obvious enough at that point that it's a "live" subscription [17:02:39] lemme see what it looks like in the ide [17:05:02] I guess the comment directly above already does that to a degree [17:08:23] (03CR) 10Jgleeson: [C: 03+2] "LGTM. thanks for the updates!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828667 (https://phabricator.wikimedia.org/T242158) (owner: 10Ejegg) [17:23:16] (03Merged) 10jenkins-bot: Reactivate cancelled recurrings on import [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828667 (https://phabricator.wikimedia.org/T242158) (owner: 10Ejegg) [17:26:33] jgleeson: Kindly review the updated MR that has your changes pulled: https://gitlab.wikimedia.org/repos/fundraising-tech/fr-tech-diagrams/-/merge_requests/1 [17:28:30] damilare: that commit trail is confusing me [17:29:39] would you be able to submit straight to the latest? [17:32:02] The commits would be squashed into one if approved [17:33:01] if merged** [17:56:48] 10Fundraising-Backlog: Create a docker image for donatewiki in fundraising-dev - https://phabricator.wikimedia.org/T317225 (10Ejegg) [18:51:48] hey fr-tech I've been fighting a headache and it's winning, I'm going to take the rest of the day as a sick day and sleep, should make it go away [18:53:03] hope you feel better soon cstone ! [18:59:56] cstone: blugh, feel better! [19:00:33] 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Delete deleted contacts - lets get a bit more done pre BE - https://phabricator.wikimedia.org/T316059 (10AnnWF) [19:07:32] it's amazing how a chunk of package upgrades can derail you for a while. [19:19:05] feel better cstone ! [19:19:20] Also I just ran that update and got the expected number of rows changed [19:22:36] (03PS11) 10Ejegg: Ingenico audit parser sending already-refunded donations to refund queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) (owner: 10Damilare Adedoyin) [19:23:00] (03CR) 10Ejegg: [C: 03+2] "Looks good, thanks! And sorry for the delay in following up with review." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) (owner: 10Damilare Adedoyin) [19:35:20] (03Merged) 10jenkins-bot: Ingenico audit parser sending already-refunded donations to refund queue [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828069 (https://phabricator.wikimedia.org/T312824) (owner: 10Damilare Adedoyin) [19:37:59] 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Delete deleted contacts - lets get a bit more done pre BE - https://phabricator.wikimedia.org/T316059 (10AnnWF) [19:42:10] 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Delete deleted contacts - lets get a bit more done pre BE - https://phabricator.wikimedia.org/T316059 (10AnnWF) [19:47:31] (03PS2) 10Ejegg: Fix Ingenico Auth for Idempotency headers [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/830318 (https://phabricator.wikimedia.org/T243967) [19:52:52] 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Delete deleted contacts - lets get a bit more done pre BE - https://phabricator.wikimedia.org/T316059 (10AnnWF) [20:08:49] 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Delete deleted contacts - lets get a bit more done pre BE - https://phabricator.wikimedia.org/T316059 (10AnnWF) [20:20:14] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10donate.wikimedia.org, and 2 others: Donation Form Error Message - Country Detection - https://phabricator.wikimedia.org/T316578 (10jgleeson) After talking with the folks in #wikimedia-sre, they're... [20:23:29] AndyRussG: are you about? [20:23:51] hiiii eileen [20:24:17] AndyRussG: if you have a mo can you jump on https://meet.google.com/udu-uhyd-ndg?authuser=0 [20:24:22] ish, but I can be more so in 5 min [20:24:31] ok one sec [20:29:17] AndyRussG: we figured it out [20:30:58] eileen: ah oki... yeah I see no one else in the call now :) [20:31:09] what was the issue? [20:31:09] :-) [20:31:32] wenjun's docker was confusing - but we unconfused ourselves :-) [20:31:41] ahh oki [20:32:14] k sorry it took me a few minutes to be available... just got back from picking up kids from school [20:33:30] no it's fine - it was just on the off chance [20:36:16] ahh hehe oki thx :) yes as always pls don't hesitate to ping anytime [20:52:07] 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Delete deleted contacts - lets get a bit more done pre BE - https://phabricator.wikimedia.org/T316059 (10AnnWF) a:03AnnWF [20:57:12] (03PS1) 10Wfan: Skip and log the contact id that not able to get deleted due to exist contributions Need to turn the job delete_deleted_contacts back once this move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830701 (https://phabricator.wikimedia.org/T316059) [21:47:13] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig, 10Epic: Move PayPal EC API calls to SmashPig - https://phabricator.wikimedia.org/T317245 (10Ejegg) [21:50:00] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29): Generate list of incomplete iDeal donations - https://phabricator.wikimedia.org/T316778 (10Ejegg) As discussed in IRC, the included 8000 or so OFFER_CLOSED IPN messages. The... [21:53:32] fr-tech I have a fix for the bug I deployed last night that does seem to work in local tests: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/830318 [21:54:18] If anyone (wfan or eileen?) can review that I'd like to tag a non-broken version of SmashPig to push out [21:55:51] Ha, it pass the test you wrote, so I think it looks fine to me~ [21:56:45] (03CR) 10Wfan: [C: 03+2] "Looks good to me, also it covered by a unit test and pass" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/830318 (https://phabricator.wikimedia.org/T243967) (owner: 10Ejegg) [21:57:23] (03Merged) 10jenkins-bot: Fix Ingenico Auth for Idempotency headers [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/830318 (https://phabricator.wikimedia.org/T243967) (owner: 10Ejegg) [22:08:34] looks like wfan beat me [22:08:46] ejegg: where are you at on the stuff you were working on yesterday? [22:14:47] eileen: i was able to deploy that today,thanks! [22:14:54] cool [22:15:00] seems to be working so far [22:15:19] thank you for the code review wfan ! [22:17:04] np and I now have the gitlab access after replace email address for Wfan219 thanks~ [22:22:58] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Based on the new log find out why those contact with donation get deleted - https://phabricator.wikimedia.org/T317254 (10AnnWF) [22:23:12] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Based on the new log find out why those contact with donation get deleted - https://phabricator.wikimedia.org/T317254 (10AnnWF) a:05AnnWF→03None [22:24:05] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Based on the new log find out why those contact with donation get deleted - https://phabricator.wikimedia.org/T317254 (10AnnWF) [22:26:36] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Create a cron job that query those contacts with donation get deleted, and send failmail to alert us - https://phabricator.wikimedia.org/T317257 (10AnnWF) [22:27:04] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Create a cron job that query those contacts with donation get deleted, and send failmail to alert us - https://phabricator.wikimedia.org/T317257 (10AnnWF) a:05AnnWF→03None [22:32:04] (03PS2) 10Eileen: Skip and log the contact id that not able to get deleted due to exist contributions Need to turn the job delete_deleted_contacts back once this move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830701 (https://phabricator.wikimedia.org/T316059) (owner: 10Wfan) [22:32:48] (03CR) 10Eileen: [C: 03+2] "Looks good - I just made a couple of edits to bring it into line with the whitespace standards for the CiviCRM / drupal code" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830701 (https://phabricator.wikimedia.org/T316059) (owner: 10Wfan) [22:33:40] Thanks eileen :) [22:45:50] (03Merged) 10jenkins-bot: Skip and log the contact id that not able to get deleted due to exist contributions Need to turn the job delete_deleted_contacts back once this move [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830701 (https://phabricator.wikimedia.org/T316059) (owner: 10Wfan)