[00:34:21] (03PS4) 10Eileen: Add last modified date for last delete_deleted_modified_date to skip the check of those contact not able to get deleted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830946 (https://phabricator.wikimedia.org/T316059) (owner: 10Wfan) [00:34:23] (03PS1) 10Eileen: Further fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830956 (https://phabricator.wikimedia.org/T316059) [00:38:32] (03PS2) 10Eileen: Further fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830956 (https://phabricator.wikimedia.org/T316059) [00:41:12] Thanks eileen for the update~ [00:41:32] wfan: it's still not quite working for me on staging - just trying to figure out why [00:44:34] Oh maybe staging does not have any contact that can be deleted? [00:47:21] (03PS3) 10Eileen: Further fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830956 (https://phabricator.wikimedia.org/T316059) [00:54:09] wfan: yep - I'm closing in on it [00:57:44] Ha, I see, $comparisonOperators only use BETWEE [00:58:01] *BETWEEN, thanks for the test! [01:05:13] (03PS2) 10Ejegg: Use bullseye for payments-wiki [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/829103 (https://phabricator.wikimedia.org/T316848) [01:11:56] (03PS1) 10Eileen: Further fixes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830958 (https://phabricator.wikimedia.org/T316059) [01:15:30] wfan: my latest version is working for me [01:18:19] eileen: oh, so I should make another edit to that inactive recurrings patch to make it also cancel things with NULL next_sched, huh? [01:25:02] ejegg: I think we logged a separate phab on that - did we? [01:25:25] I think it's a one-off? No we also wanted to understand why they are happening [01:26:20] eileen: Should we squash those two prs or I can modify the one you have to the original pr~ [01:26:40] you mean my two or yours & mine - I'm not sure why I seem to have two.... [01:27:27] but yeah this commit is working 10c1395e0cbefc544a417491 [01:27:45] Ok, let me make them one~ [01:27:49] I'm OK either or for squashing or two commits - it just wound up enough change I didn't just want to push to yours [01:32:30] (03PS5) 10Wfan: Add last modified date for last delete_deleted_modified_date to skip the check of those contact not able to get deleted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830946 (https://phabricator.wikimedia.org/T316059) [01:36:55] (03CR) 10Wfan: Add last modified date for last delete_deleted_modified_date to skip the check of those contact not able to get deleted (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830946 (https://phabricator.wikimedia.org/T316059) (owner: 10Wfan) [01:38:17] (03PS4) 10Ejegg: Add DonationApiBase::getLogger() [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/733965 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [01:39:42] (03CR) 10Eileen: [C: 03+2] "I just did a git diff & this is indeed the same code as what worked for me via the other commit - which is what I tested on staging" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830946 (https://phabricator.wikimedia.org/T316059) (owner: 10Wfan) [01:40:05] cool - that is merging .... on zuul's time schedule [01:40:17] (03CR) 10CI reject: [V: 04-1] Add DonationApiBase::getLogger() [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/733965 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [01:40:28] Thanks eileen~! [01:41:47] (03PS5) 10Ejegg: Add DonationApiBase::getLogger() [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/733965 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [01:42:35] (03CR) 10Ejegg: [C: 03+2] "This looks good, thanks! PS4 just deletes a single space that now offends the linter." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/733965 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [01:45:15] (03Merged) 10jenkins-bot: Add DonationApiBase::getLogger() [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/733965 (https://phabricator.wikimedia.org/T294032) (owner: 10AndyRussG) [01:50:21] (03PS3) 10Ejegg: A better now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/815964 (owner: 10Eileen) [01:50:26] (03CR) 10Ejegg: [C: 03+2] A better now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/815964 (owner: 10Eileen) [01:55:20] (03Merged) 10jenkins-bot: Add last modified date for last delete_deleted_modified_date to skip the check of those contact not able to get deleted [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/830946 (https://phabricator.wikimedia.org/T316059) (owner: 10Wfan) [02:03:59] (03Merged) 10jenkins-bot: A better now [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/815964 (owner: 10Eileen) [08:13:07] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/831010 (owner: 10L10n-bot) [12:23:13] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/831010 (owner: 10L10n-bot) [14:34:42] Hi fr-tech [14:35:04] heyyy cstone fr-tech :) [14:36:40] howdy damilare cstone AndyRussG fr-tech [14:37:15] Hi AndyRussG jgleeson [14:37:28] :) :) [14:37:58] 90% humidity here is ruining my working on the deck plans [14:40:22] ah that is high [14:52:18] Yhh [14:52:25] Brb [15:18:06] ok I'm gonna take another pass on ejegg|away docker updates. Looks like he's ironed out some of the issues we hit yesterday. Has anyone else managed to build the images? [15:18:12] fr-tecy^ [15:18:15] oops [15:18:22] fr-tech [15:18:59] heyyy jgleeson no haven't done so yet [15:25:04] cool cool [15:25:48] 10Fundraising Tech - Chaos Crew, 10fundraising-tech-ops, 10Mail, 10Patch-For-Review: DMarc Email Address for Wikimedia.org - https://phabricator.wikimedia.org/T316899 (10DBu-WMF) Hi all. Trying to follow along as best possible. Can someone give me an update if someone has been able to give me acess to th... [15:49:44] 10Fundraising-Backlog: Investigate timeouts from Adyen Soap listener - https://phabricator.wikimedia.org/T317422 (10AndyRussG) [16:03:12] 10Fundraising-Backlog, 10Data-Engineering, 10Event-Platform Value Stream, 10MediaWiki-extensions-EventLogging, and 2 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10phuedx) [16:12:04] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29): Generate list of incomplete iDeal donations - https://phabricator.wikimedia.org/T316778 (10XenoRyet) Confirmed, go ahead and clear the bad data. [16:21:34] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10donate.wikimedia.org: Ensure country detected in Donate wiki - https://phabricator.wikimedia.org/T317427 (10AndyRussG) [16:28:40] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Be consistent with staged card type in Ingenico - https://phabricator.wikimedia.org/T316796 (10Dwisehaupt) [16:31:36] 10Fundraising-Backlog, 10FR-Braintree-Integration: Handle HTTP errors setting up Braintree donation - https://phabricator.wikimedia.org/T316730 (10Dwisehaupt) [16:32:31] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Adyen iDEAL TY email delay - https://phabricator.wikimedia.org/T316602 (10Dwisehaupt) [16:34:24] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising-Backlog: Custom field "AF_has_active_recurring_donation" is showing false positives - https://phabricator.wikimedia.org/T315102 (10KHaggard) Also quick follow up after checking today - it seems the 32k false positi... [16:34:29] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-Core-Skin-Architecture (Menus 2.0), 10Technical-Debt: [Maintenance request] CentralNotice should not use SkinTemplateNavigation hook to add special page tabs - https://phabricator.wikimedia.org/T315562 (10Dwisehaupt) [17:21:13] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10donate.wikimedia.org, and 2 others: Donation Form Error Message - Country Detection - https://phabricator.wikimedia.org/T316578 (10Pcoombe) I've added some on-wiki javascript to tackle this. If a u... [18:05:29] hey jgleeson|food I just responded to your comments on that patch. Thanks for the CR [18:20:10] 10Fundraising-Backlog, 10Growth-Team, 10Growth-Team-Filtering, 10MassMessage, and 14 others: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Jdforrester-WMF) [18:50:49] thanks damilare|brb I'll check 'em out now [18:51:32] (03PS1) 10Jforrester: Replace use of deprecated $.debounce() with mw.util.debounce() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/831137 (https://phabricator.wikimedia.org/T213426) [18:52:36] 10Fundraising-Backlog, 10Growth-Team, 10Growth-Team-Filtering, 10MassMessage, and 14 others: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Volker_E) https://codesearch.wmcloud.org/search/?q=%5C%24%5C.debounce&i=nope&files=&e... [18:54:00] (03CR) 10CI reject: [V: 04-1] Replace use of deprecated $.debounce() with mw.util.debounce() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/831137 (https://phabricator.wikimedia.org/T213426) (owner: 10Jforrester) [18:57:37] 10Fundraising-Backlog, 10Growth-Team, 10Growth-Team-Filtering, 10MassMessage, and 14 others: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Jdforrester-WMF) >>! In T213426#8225521, @Volker_E wrote: > https://codesearch.wmclou... [18:57:53] 10Fundraising-Backlog, 10Growth-Team, 10Growth-Team-Filtering, 10MassMessage, and 14 others: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Volker_E) [18:58:26] 10Fundraising-Backlog, 10Growth-Team, 10Growth-Team-Filtering, 10MassMessage, and 14 others: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Jdforrester-WMF) [18:58:53] 10Fundraising-Backlog, 10Growth-Team, 10Growth-Team-Filtering, 10MassMessage, and 14 others: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Jdforrester-WMF) [19:00:22] 10Fundraising-Backlog, 10Growth-Team, 10Growth-Team-Filtering, 10MassMessage, and 14 others: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Volker_E) [19:02:25] 10Fundraising-Backlog, 10Growth-Team, 10Growth-Team-Filtering, 10MassMessage, and 14 others: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Jdforrester-WMF) [19:06:21] 10Fundraising-Backlog, 10Growth-Team, 10Growth-Team-Filtering, 10MassMessage, and 14 others: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Volker_E) [19:07:17] approved and merged damilare|brb ! [19:08:39] 10Fundraising-Backlog, 10Growth-Team, 10Growth-Team-Filtering, 10MassMessage, and 14 others: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Jdforrester-WMF) [19:09:32] (03CR) 10Jforrester: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/830507 (owner: 10L10n-bot) [19:15:17] (03CR) 10Jforrester: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/831137 (https://phabricator.wikimedia.org/T213426) (owner: 10Jforrester) [19:31:57] (03CR) 10VolkerE: [C: 03+1] Replace use of deprecated $.debounce() with mw.util.debounce() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/831137 (https://phabricator.wikimedia.org/T213426) (owner: 10Jforrester) [19:33:33] thanks jgleeson [20:30:10] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail: Investigate in-house DMARC analysis tool options - https://phabricator.wikimedia.org/T317443 (10Jgreen) [20:35:03] (03PS1) 10Cstone: WIP: Audit module part of using the payments_detail_report for audit There will be a smashpig patch to go along with this [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) [20:43:46] 10Fundraising-Backlog: Cannot import DAF Engage import file - https://phabricator.wikimedia.org/T317446 (10MDemosWMF) [20:44:38] 10Fundraising-Backlog: Cannot import DAF Engage import file - https://phabricator.wikimedia.org/T317446 (10MDemosWMF) p:05Triage→03High [23:04:55] (03PS1) 10Cstone: WIP: Adding PaymentAccountingReport to the files the adyen audit looks at [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/831159 (https://phabricator.wikimedia.org/T314753) [23:05:23] (03CR) 10CI reject: [V: 04-1] WIP: Adding PaymentAccountingReport to the files the adyen audit looks at [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/831159 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [23:06:59] (03PS2) 10Cstone: WIP: Adding PaymentAccountingReport to the files the adyen audit looks at [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/831159 (https://phabricator.wikimedia.org/T314753) [23:07:25] (03CR) 10CI reject: [V: 04-1] WIP: Adding PaymentAccountingReport to the files the adyen audit looks at [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/831159 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [23:08:44] (03PS3) 10Cstone: WIP: Adding PaymentAccountingReport to the files the adyen audit looks at [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/831159 (https://phabricator.wikimedia.org/T314753) [23:22:08] 10Fundraising Sprint Potato, 10Fundraising-Backlog, 10Patch-For-Review: Use nightly rather than weekly audit file for Adyen - https://phabricator.wikimedia.org/T314753 (10Cstone) Testing the report downloads is complicated. This is a WIP just so I don't forget steps. I'll move these to the wiki once everythi... [23:30:22] (03PS4) 10Cstone: WIP: Adding PaymentAccountingReport to the files the adyen audit looks at [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/831159 (https://phabricator.wikimedia.org/T314753) [23:31:19] (03CR) 10CI reject: [V: 04-1] WIP: Adding PaymentAccountingReport to the files the adyen audit looks at [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/831159 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone)