[01:48:14] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10donate.wikimedia.org, and 2 others: Donation Form Error Message - Country Detection - https://phabricator.wikimedia.org/T316578 (10AndyRussG) >>! In T316578#8227652, @AndyRussG wrote: > I see it ev... [05:16:16] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/831285 (owner: 10L10n-bot) [06:38:07] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/831285 (owner: 10L10n-bot) [08:06:58] (03CR) 10Mooeypoo: [C: 03+2] Replace use of deprecated $.debounce() with mw.util.debounce() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/831137 (https://phabricator.wikimedia.org/T213426) (owner: 10Jforrester) [08:24:29] (03Merged) 10jenkins-bot: Replace use of deprecated $.debounce() with mw.util.debounce() [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/831137 (https://phabricator.wikimedia.org/T213426) (owner: 10Jforrester) [08:30:27] (03PS1) 10Jforrester: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/831486 [08:31:18] 10Fundraising-Backlog, 10Growth-Team, 10Growth-Team-Filtering, 10MassMessage, and 14 others: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Jdforrester-WMF) [09:40:21] 10Fundraising-Backlog, 10Growth-Team, 10Growth-Team-Filtering, 10MassMessage, and 14 others: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle - https://phabricator.wikimedia.org/T213426 (10kostajh) [09:40:34] 10Fundraising-Backlog, 10Growth-Team, 10MassMessage, 10MediaViewer, and 13 others: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle - https://phabricator.wikimedia.org/T213426 (10kostajh) [09:40:44] 10Fundraising-Backlog, 10Growth-Team, 10MassMessage, 10MediaViewer, and 13 others: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle - https://phabricator.wikimedia.org/T213426 (10kostajh) [10:57:12] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10donate.wikimedia.org, and 2 others: Donation Form Error Message - Country Detection - https://phabricator.wikimedia.org/T316578 (10Pcoombe) Thanks @AndyRussG. Agree that we should go ahead with the... [12:38:30] 10Fundraising-Backlog: Investigate timeouts from Adyen Soap listener - https://phabricator.wikimedia.org/T317422 (10jgleeson) We got one of these this morning. [14:22:05] 10Fundraising-Backlog: Cannot import DAF Engage import file - https://phabricator.wikimedia.org/T317446 (10MDemosWMF) Just tried it this morning and despite a slight lag the import seems to be working again! Any idea what this might have been? Thanks! [15:18:09] 10Fundraising-Backlog: Create a docker image for donatewiki in fundraising-dev - https://phabricator.wikimedia.org/T317225 (10Ejegg) [15:18:15] 10Fundraising-Backlog, 10FR-Docker: Add a test version of Donate Wiki to fundraising-dev - https://phabricator.wikimedia.org/T317498 (10Ejegg) [16:07:01] (03CR) 10Ejegg: [C: 03+1] "Thanks, this looks great! Just found one typo in the readme" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/831239 (owner: 10AndyRussG) [16:09:24] (03CR) 10Ejegg: "Won't that reload wipe out URL params?" [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/831243 (https://phabricator.wikimedia.org/T317427) (owner: 10AndyRussG) [16:10:44] ejegg: if you do `docker images | grep fundraising` do you see an image for fundraising-bullseye? I'm trying to clear out the old images to test your latest but I don't see this image https://gitlab.wikimedia.org/repos/releng/dev-images/-/blob/7fa6ab306ecfceb60271c185fdeb2f75b8e8c6bb/dockerfiles/fundraising-bullseye/changelog [16:10:50] (03CR) 10AndyRussG: [C: 04-1] Try reloading once if no GeoIP cookie found (031 comment) [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/831243 (https://phabricator.wikimedia.org/T317427) (owner: 10AndyRussG) [16:11:23] (03PS2) 10Ejegg: Fix formatting in README.md [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/789347 (owner: 10AndyRussG) [16:11:33] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Fix formatting in README.md [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/789347 (owner: 10AndyRussG) [16:12:00] hi jgleeson, let me check [16:13:22] yep, I have two fundraising-bullseye, one with the version number as in my MR and one that I build a week earlier with a diff version number [16:13:59] looks like there's one without the fundraising prefix on my machine https://phabricator.wikimedia.org/P34525 [16:14:24] hmmm not sure how I've managed that [16:14:34] jgleeson: huh, I guess that must be from upstream? I have one too [16:14:38] docker-registry.wikimedia.org/bullseye latest e493a1a8c826 4 weeks ago 80.4MB [16:15:17] oh right, fundraising-bullseye is based on bullseye [16:15:31] so I guess it gets pulled down when you build the image based on it [16:15:38] (03PS2) 10AndyRussG: Support for LocalSettings-local.php for untracked settings [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/831239 [16:16:20] I was trying to use docker-pkg to prune the older images but it didn't work as the versions haven't changed, or at least it appeared to not do anything. maybe it deleted that image and left the others [16:16:42] (03PS3) 10AndyRussG: Support for LocalSettings-local.php for untracked settings [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/831239 [16:17:45] (03CR) 10AndyRussG: "Thanks!! :)" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/831239 (owner: 10AndyRussG) [16:20:01] oh well. I cleared out the other two and it seems to have picked up the correct 3 to build [16:20:14] local craziness probably [16:21:57] ah i didn't know you could prune with docker-pkg! [16:22:11] I've just been manually copying shas from `docker image ls` [16:22:24] to paste into `docker image rm ...` [16:22:54] (03PS4) 10Ejegg: Support for LocalSettings-local.php for untracked settings [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/831239 (owner: 10AndyRussG) [16:22:59] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Support for LocalSettings-local.php for untracked settings [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/831239 (owner: 10AndyRussG) [16:23:50] mm [16:23:53] hmm* [16:28:54] 2022-09-12 17:20:44,044 [docker-pkg-build] INFO - Err:9 http://mirrors.wikimedia.org/debian bullseye/main amd64 libc6 amd64 2.31-13+deb11u4 [16:28:56] Could not resolve 'mirrors.wikimedia.org' (image.py:179) [16:29:32] weird, that loads fine for me [16:29:39] but it loads for me [16:30:22] geh [16:30:25] I'll dig back in after food. back soon [16:31:09] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Adyen iDEAL TY email delay - https://phabricator.wikimedia.org/T316602 (10MBeat33) CID 46730354 / ZD ticket 1166357 is another example, with the same donation and TY email dates (TY Amber for finding this one) [16:59:47] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising-Backlog: Custom field "AF_has_active_recurring_donation" is showing false positives - https://phabricator.wikimedia.org/T315102 (10Ejegg) @KHaggard darn! I'm looking at the CiviCRM database now, and sure enough it... [17:10:40] (03PS2) 10AndyRussG: Try reloading once if no GeoIP cookie found [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/831243 (https://phabricator.wikimedia.org/T317427) [17:26:58] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail: Investigate in-house DMARC analysis tool options - https://phabricator.wikimedia.org/T317443 (10Jgreen) [17:32:13] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [17:37:13] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [17:39:42] ^^^ i'm fixing that up. some more oddities with statements not executing over replication but running fine by hand. [17:40:59] (03CR) 10AndyRussG: Try reloading once if no GeoIP cookie found (031 comment) [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/831243 (https://phabricator.wikimedia.org/T317427) (owner: 10AndyRussG) [17:42:13] RECOVERY - check_mysql on frdb2003 is OK: Uptime: 1731750 Threads: 5 Questions: 862673827 Slow queries: 636 Opens: 4229 Open tables: 1432 Queries per second avg: 498.151 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [17:49:32] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising-Backlog: Custom field "AF_has_active_recurring_donation" is showing false positives - https://phabricator.wikimedia.org/T315102 (10KHaggard) Thanks @Ejegg ! Oh yeah, I just ran a rough query that I was hoping would... [17:56:28] xdebug is working again ejegg [17:56:39] nice jgleeson ! [17:57:09] it's not the prettiest code in the new setup.sh, but it does seem to support both xdebug 2 and xdebug3 [17:57:10] ejegg: there's a minor gotcha [17:57:16] oh, what's that? [17:58:37] folks will need to restart apache2 to load in the config changes you suggest using in the commit message, after setup.php finishes [17:58:53] oh yep, that's true, I can add that to the commit message [17:58:56] I just realised after setting it and getting nothing [17:59:10] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Erich Brill - https://phabricator.wikimedia.org/T317560 (10SHust) [17:59:32] i need to rebase it anyway [18:00:44] (03PS3) 10Ejegg: Use bullseye for payments-wiki [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/829103 (https://phabricator.wikimedia.org/T316848) [18:00:59] ok jgleeson, I added that instruction ^^^ [18:01:00] I think you can either reload apache2 or just restart the docker container [18:01:02] same thing [18:01:13] well, not exactly the same but it'll work in both cases ha [18:01:47] ah you put both in the commit :) [18:02:36] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Erich Brill - https://phabricator.wikimedia.org/T317560 (10SHust) [18:04:22] ejegg: [18:04:24] sorry to nitpick [18:04:36] but you only have to reload/restart for the web settings [18:05:10] I know you know, but the cmt message is ambiguous [18:07:25] oh right [18:08:02] (03PS4) 10Ejegg: Use bullseye for payments-wiki [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/829103 (https://phabricator.wikimedia.org/T316848) [18:09:51] thanks! [18:10:01] :) thank you for the review! [18:12:21] (03PS3) 10Ejegg: Replace deprecated loadData() method of HTMLForm [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/772320 (owner: 10Func) [18:12:22] ejegg: how about detecting the OS to decide which version of xdebug settings to add [18:12:42] or would that be too much work for a tmp solution [18:13:03] (03CR) 10Ejegg: [C: 03+2] "Looks good to me. Thanks for the fix, Func!" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/772320 (owner: 10Func) [18:14:05] jgleeson: ehh, I figure we can easily move the images from one list to the other for now [18:14:59] I mean move the file paths from one list to the other [18:26:10] (03Merged) 10jenkins-bot: Replace deprecated loadData() method of HTMLForm [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/772320 (owner: 10Func) [18:30:42] ejegg: [18:30:46] one other idea [18:31:27] how about automatically renaming the old xdebug ini files to filename.bk [18:31:41] that way people don't need to delete anything during the interim [18:32:42] for payments, in this patch [18:33:52] jgleeson: oh you mean the custom ones? OK, guess I could do that [18:34:30] I just thinking of a way to run setup.sh and it does the upgrade for you [18:34:48] and a way to make it future proof [18:37:36] (03CR) 10Jgleeson: [C: 03+1] "Thanks! This is working for me after the fixes to the xdebug setup. As discussed on IRC it would be nice if we could automagically backup " [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/829103 (https://phabricator.wikimedia.org/T316848) (owner: 10Ejegg) [18:47:13] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [18:52:13] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [18:57:13] RECOVERY - check_mysql on frdb2003 is OK: Uptime: 1736249 Threads: 5 Questions: 865663914 Slow queries: 636 Opens: 4238 Open tables: 1432 Queries per second avg: 498.582 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [19:07:12] (03PS5) 10Ejegg: Use bullseye for payments-wiki [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/829103 (https://phabricator.wikimedia.org/T316848) [19:07:42] jgleeson: ok, that seems to work for me to automatically replace the existing file with a fresh one for the correct version ^^^ [19:29:00] (03PS5) 10Cstone: WIP: Adding PaymentAccountingReport to the files the adyen audit looks at [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/831159 (https://phabricator.wikimedia.org/T314753) [19:29:33] (03CR) 10CI reject: [V: 04-1] WIP: Adding PaymentAccountingReport to the files the adyen audit looks at [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/831159 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [19:58:33] (03PS1) 10Wfan: WIP: Add adyen to pending transaction resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831618 (https://phabricator.wikimedia.org/T316587) [19:59:06] (03CR) 10CI reject: [V: 04-1] WIP: Add adyen to pending transaction resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831618 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [20:00:23] (03PS2) 10Wfan: WIP: Add adyen to pending transaction resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831618 (https://phabricator.wikimedia.org/T316587) [20:16:23] (03CR) 10CI reject: [V: 04-1] WIP: Add adyen to pending transaction resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831618 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [20:22:13] 10Fundraising-Backlog, 10FR-Docker: Add a test version of Donate Wiki to fundraising-dev - https://phabricator.wikimedia.org/T317498 (10Dwisehaupt) [20:23:06] 10Fundraising-Backlog: Ingenico FIELD_LENGTH_INVALID error when firstName is too long - https://phabricator.wikimedia.org/T317355 (10Dwisehaupt) [20:23:16] 10Fundraising-Backlog: Investigate timeouts from Adyen Soap listener - https://phabricator.wikimedia.org/T317422 (10Dwisehaupt) [20:29:00] 10Fundraising-Backlog: Custom field for Direct Mail Appeal not working on Engage import - https://phabricator.wikimedia.org/T317327 (10Dwisehaupt) [20:35:00] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Create a cron job that query those contacts with donation get deleted, and send failmail to alert us - https://phabricator.wikimedia.org/T317257 (10Dwisehaupt) [20:36:40] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Based on the new log find out why those contact with donation get deleted - https://phabricator.wikimedia.org/T317254 (10Dwisehaupt) [20:40:11] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig, 10Epic: Move PayPal EC API calls to SmashPig - https://phabricator.wikimedia.org/T317245 (10Dwisehaupt) [20:53:48] nice refuse of the backup fn ejegg [20:54:19] reuse even [20:54:30] thing I've got a cold coming on [20:54:37] argh [20:54:43] think* [20:57:48] hmm that didn't seem to work for me ejegg [20:58:04] I reinstated the old xdebug.ini files for payments and ran setup.sh [20:58:13] oh wait did I forget to actually checkout the latest [21:00:27] hmm nope the code looks to be the latest [21:02:32] jgleeson: hmm, really? Let me double check here [21:02:39] Did it output the new message? [21:02:57] I did the same to test and I got the new message and the new file locally [21:03:13] config/payments/xdebug-cli.ini exists and does not need updating. [21:03:15] config/payments/xdebug-web.ini exists and does not need updating. [21:03:42] and those have the old remote_port line in them? [21:04:14] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10Mail: Investigate in-house DMARC analysis tool options - https://phabricator.wikimedia.org/T317443 (10Jgreen) [21:05:47] yup ejegg [21:06:14] want to do a screen share jgleeson ? [21:07:18] sure [21:07:38] same call we were just on? [21:21:44] Merge details [21:21:46] Changes merged into main with 7fa6ab30. [21:21:48] Deleted the source branch. [21:22:30] (03CR) 10Jgleeson: [C: 03+2] "Working great! thanks for the updates to preserve the old config files." [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/829103 (https://phabricator.wikimedia.org/T316848) (owner: 10Ejegg) [21:22:39] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] Use bullseye for payments-wiki [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/829103 (https://phabricator.wikimedia.org/T316848) (owner: 10Ejegg) [22:08:31] 10Fundraising-Backlog: Cannot import DAF Engage import file - https://phabricator.wikimedia.org/T317446 (10Eileenmcnaughton) Honestly - no :-) That error is particularly mysterious. I does have the temporary feel to it though [23:09:11] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Erich Brill - https://phabricator.wikimedia.org/T317560 (10Dwisehaupt) [23:09:46] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Erich Brill - https://phabricator.wikimedia.org/T317560 (10Dwisehaupt) a:03Dwisehaupt [23:11:14] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Erich Brill - https://phabricator.wikimedia.org/T317560 (10Dwisehaupt) @SHust If you could have Erich add their info to https://collab.wikimedia.org/wiki/Fundraising#Contact_List when they start, then I can get moving with their acco... [23:11:56] 10Fundraising-Backlog: Cannot import DAF Engage import file - https://phabricator.wikimedia.org/T317446 (10MDemosWMF) Strange! Haha glad it cleared up.