[00:09:54] (03PS5) 10Damilare Adedoyin: Don't tokenize cards when donation is under Monthly Convert minimum [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832508 (https://phabricator.wikimedia.org/T316840) [00:11:44] (03CR) 10CI reject: [V: 04-1] Don't tokenize cards when donation is under Monthly Convert minimum [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832508 (https://phabricator.wikimedia.org/T316840) (owner: 10Damilare Adedoyin) [00:29:49] (03PS6) 10Damilare Adedoyin: Don't tokenize cards when donation is under Monthly Convert minimum [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832508 (https://phabricator.wikimedia.org/T316840) [00:31:45] (03CR) 10CI reject: [V: 04-1] Don't tokenize cards when donation is under Monthly Convert minimum [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832508 (https://phabricator.wikimedia.org/T316840) (owner: 10Damilare Adedoyin) [00:50:56] (03PS7) 10Damilare Adedoyin: Don't tokenize cards when donation is under Monthly Convert minimum [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832508 (https://phabricator.wikimedia.org/T316840) [00:52:48] (03CR) 10CI reject: [V: 04-1] Don't tokenize cards when donation is under Monthly Convert minimum [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832508 (https://phabricator.wikimedia.org/T316840) (owner: 10Damilare Adedoyin) [00:54:12] (03PS8) 10Damilare Adedoyin: Don't tokenize cards when donation is under Monthly Convert minimum [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832508 (https://phabricator.wikimedia.org/T316840) [00:57:42] (03PS4) 10Cstone: Adding payments_details_report as an option for the Adyen Audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) [00:59:04] (03PS5) 10Cstone: Adding payments_details_report as an option for the Adyen Audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) [01:01:52] (03PS14) 10Cstone: Adding PaymentsAccountingReport as a source audit file [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/831159 (https://phabricator.wikimedia.org/T314753) [01:02:17] (03CR) 10CI reject: [V: 04-1] Adding PaymentsAccountingReport as a source audit file [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/831159 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [01:03:25] (03PS15) 10Cstone: Adding PaymentsAccountingReport as a source audit file [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/831159 (https://phabricator.wikimedia.org/T314753) [01:11:46] (03CR) 10CI reject: [V: 04-1] Adding payments_details_report as an option for the Adyen Audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [01:53:21] (03PS2) 10Ejegg: Update namespaces for SmashPig responses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/832523 [01:53:23] (03PS1) 10Ejegg: WIP add Adyen data deletion requests to forgetme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/832580 (https://phabricator.wikimedia.org/T311741) [02:03:56] (03PS1) 10Wfan: unset card info includes cardNumber and expiryDate for ingenico log [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832581 (https://phabricator.wikimedia.org/T311455) [02:06:59] (03CR) 10Ejegg: "jgleeson I think you'll want to make the JS changes here: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/adyen_gateway/for" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832568 (https://phabricator.wikimedia.org/T317713) (owner: 10Jgleeson) [02:08:02] (03CR) 10CI reject: [V: 04-1] Update namespaces for SmashPig responses [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/832523 (owner: 10Ejegg) [02:09:13] (03CR) 10CI reject: [V: 04-1] WIP add Adyen data deletion requests to forgetme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/832580 (https://phabricator.wikimedia.org/T311741) (owner: 10Ejegg) [02:09:56] nick ejegg|away [08:08:35] 10Fundraising-Backlog, 10Data-Engineering, 10Event-Platform Value Stream, 10MediaWiki-extensions-EventLogging, and 2 others: Determine which remaining legacy EventLogging schemas need to be migrated or decommissioned - https://phabricator.wikimedia.org/T282131 (10phuedx) [13:35:55] (03CR) 10Jgleeson: [C: 03+1] "This looks great! thanks for the updates. I just had two minor nitpicks which I added inline but they're not blocking so if you don't agre" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [14:52:49] (03CR) 10Jgleeson: "hmm still no luck getting jenkins to test this? strange" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831618 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [15:12:59] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Epic: DonationInterface: Combine payments-initial and contribution-tracking data to make new payments_event_log - https://phabricator.wikimedia.org/T317988 (10jgleeson) [15:53:53] jgleeson: thanks for the review! I'm conflicted with fileName I do like more descriptive variable names but then $file is used a ton of other times everywhere too [15:54:35] if it would make it more confusing in the end [15:56:58] ok stick with $file then if it fits better [15:57:08] I didn't check too much around the code to see how other things were using it [15:57:10] thanks cstone ! [15:58:57] (03PS1) 10AndyRussG: Only pass on params from URL query string [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/832663 (https://phabricator.wikimedia.org/T317427) [16:00:44] (03CR) 10CI reject: [V: 04-1] Only pass on params from URL query string [extensions/FundraiserLandingPage] - 10https://gerrit.wikimedia.org/r/832663 (https://phabricator.wikimedia.org/T317427) (owner: 10AndyRussG) [16:03:34] (03CR) 10Wfan: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832581 (https://phabricator.wikimedia.org/T311455) (owner: 10Wfan) [16:04:49] 10Wikimedia-Fundraising-CiviCRM, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Blocking 🧱): CI has somehow completely stopped for a pr at wikimedia/fundraising/crm master - https://phabricator.wikimedia.org/T317928 (10AnnWF) @dancy Yeah, I noticed this error while the pr has nothing to... [16:09:16] (03PS6) 10Cstone: Adding payments_details_report as an option for the Adyen Audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) [16:13:39] 10Fundraising-Backlog: Look into paypal recurrings that are status pending but no next_sched_contribution_date - https://phabricator.wikimedia.org/T317164 (10Dwisehaupt) [16:17:34] 10Fundraising-Backlog: Cannot import DAF Engage import file - https://phabricator.wikimedia.org/T317446 (10Dwisehaupt) 05Open→03Resolved Thanks for reporting this. We are going to mark this as resolved for now. [16:23:04] (03PS1) 10Ahmon Dancy: Test update to README.txt. Will be abandoned [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832688 [16:23:24] (03CR) 10CI reject: [V: 04-1] Adding payments_details_report as an option for the Adyen Audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [16:27:58] (03PS2) 10Ahmon Dancy: unset card info includes cardNumber and expiryDate for ingenico log [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832581 (https://phabricator.wikimedia.org/T311455) (owner: 10Wfan) [16:29:56] (03CR) 10CI reject: [V: 04-1] unset card info includes cardNumber and expiryDate for ingenico log [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832581 (https://phabricator.wikimedia.org/T311455) (owner: 10Wfan) [16:32:47] (03PS3) 10Wfan: unset card info includes cardNumber and expiryDate for ingenico log [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832581 (https://phabricator.wikimedia.org/T311455) [16:35:23] (03CR) 10Wfan: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831618 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [16:36:19] 10Wikimedia-Fundraising-CiviCRM, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Blocking 🧱): CI has somehow completely stopped for a pr at wikimedia/fundraising/crm master - https://phabricator.wikimedia.org/T317928 (10dancy) Hi @AnnWF I don't think the problem is specific to your accou... [16:36:25] 10Wikimedia-Fundraising-CiviCRM, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Blocking 🧱): CI has somehow completely stopped for a pr at wikimedia/fundraising/crm master - https://phabricator.wikimedia.org/T317928 (10AnnWF) It's working now, thanks ! [16:37:28] (03Abandoned) 10Ahmon Dancy: Test update to README.txt. Will be abandoned [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832688 (owner: 10Ahmon Dancy) [16:43:15] (03PS4) 10Wfan: unset card info includes cardNumber and expiryDate for ingenico log [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832581 (https://phabricator.wikimedia.org/T311455) [16:44:06] (03PS5) 10Wfan: unset card info includes cardNumber and expiryDate for ingenico log [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832581 (https://phabricator.wikimedia.org/T311455) [16:46:01] (03CR) 10CI reject: [V: 04-1] unset card info includes cardNumber and expiryDate for ingenico log [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832581 (https://phabricator.wikimedia.org/T311455) (owner: 10Wfan) [16:47:33] (03PS6) 10Wfan: unset card info includes cardNumber and expiryDate for ingenico log [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832581 (https://phabricator.wikimedia.org/T311455) [16:50:06] (03CR) 10CI reject: [V: 04-1] unset card info includes cardNumber and expiryDate for ingenico log [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832581 (https://phabricator.wikimedia.org/T311455) (owner: 10Wfan) [16:53:00] (03PS7) 10Wfan: unset card info includes cardNumber and expiryDate for ingenico log [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832581 (https://phabricator.wikimedia.org/T311455) [16:54:47] (03CR) 10CI reject: [V: 04-1] unset card info includes cardNumber and expiryDate for ingenico log [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832581 (https://phabricator.wikimedia.org/T311455) (owner: 10Wfan) [18:11:33] the lamb was a success! [18:31:42] argh. I managed to get the drupal and civi updates working but it looks like they swapped out all of those drupal variables we set last night [18:31:50] cstone: wfan ^ [18:32:19] Ah for the audit ? [18:32:20] I noticed when I was running `drush parse-audit adyen` it was looking at test files instead of the file we downloaded last night [18:32:22] ya [18:32:53] I'll reset them back to the right values [18:33:25] ha~ nice for the drupal and civi updates, I also got my payment vendor smashpig update for unit test [18:57:30] (03PS8) 10Wfan: unset card info includes cardNumber and expiryDate for ingenico log [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832581 (https://phabricator.wikimedia.org/T311455) [19:01:52] (03CR) 10Jgleeson: [C: 03+2] "LGTM! Let's get this merged to get the related patch passing on CI" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/831159 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [19:02:23] (03Merged) 10jenkins-bot: Adding PaymentsAccountingReport as a source audit file [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/831159 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [19:02:30] cstone: I think you might need to go through the smashpig version bump dance to get your civicrm patch passing [19:02:48] Yeah thanks jgleeson ! [19:03:05] (03CR) 10Jgleeson: WIP: Stop Adyen adapter from sending an additional pending message (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832568 (https://phabricator.wikimedia.org/T317713) (owner: 10Jgleeson) [19:04:58] (03PS3) 10Jgleeson: Stop Adyen adapter from sending an additional pending message [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832568 (https://phabricator.wikimedia.org/T317713) [19:08:38] have a good weekend fr-tech. see you all tuesday! It's a holiday here Monday :) [19:08:42] bye for now [21:22:57] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10MW-1.39-notes (1.39.0-wmf.27; 2022-08-29): Remove incomplete iDeal transactions from CiviCRM - https://phabricator.wikimedia.org/T316780 (10Cstone) Cleared them out using search kit [21:30:39] (03PS1) 10Umherirrender: HTMLCentralNoticeBannerMessage: Do not use mParams in constructor [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/832709 (https://phabricator.wikimedia.org/T317368)