[06:22:30] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] HTMLCentralNoticeBannerMessage: Do not use mParams in constructor (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/832709 (https://phabricator.wikimedia.org/T317368) (owner: 10Umherirrender) [08:29:09] 10WMSE-Content-partnerships-support-2021-Fundraising, 10User-Jenny_Brandt_WMSE: PM Insamling - https://phabricator.wikimedia.org/T308157 (10Lokal_Profil) This is largely done. Check in with @Jopparn on Sept 19th to identify any remaining parts [15:22:49] (03PS1) 10AndyRussG: Command-line tools for queues [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/833017 [15:23:30] hiii fr-tech [15:23:43] hi AndyRussG [15:23:46] Greetings [15:23:47] who would like a command-line tool to pretty-print json in all queue messages? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/833017 [15:23:51] heyyy :) :) [15:27:07] (03PS2) 10AndyRussG: Command-line tools for queues [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/833017 [15:29:48] (03PS3) 10AndyRussG: Command-line tools for queues [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/833017 [15:58:06] fr-tech: Can someone please do our update for the advancement standup in an hour? Being just back from the trip, I'm not sure I'd know what to say today. [15:59:50] I can XenoRyet [16:00:02] Awesome, thanks. [16:00:30] For the order, we go second. [16:07:43] (03PS1) 10Wfan: Remove expiryDate from adyen soap listner [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/833021 (https://phabricator.wikimedia.org/T311455) [16:08:15] (03CR) 10CI reject: [V: 04-1] Remove expiryDate from adyen soap listner [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/833021 (https://phabricator.wikimedia.org/T311455) (owner: 10Wfan) [16:13:35] (03PS2) 10Wfan: Remove expiryDate from adyen soap listner [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/833021 (https://phabricator.wikimedia.org/T311455) [16:16:26] (03PS3) 10Wfan: Remove expiryDate from adyen soap listner [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/833021 (https://phabricator.wikimedia.org/T311455) [16:17:26] (03PS4) 10Wfan: Remove expiryDate from adyen soap listner [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/833021 (https://phabricator.wikimedia.org/T311455) [16:27:42] (03PS5) 10Wfan: Remove expiryDate from adyen soap listner Remove card info from ingenico auth fail log at HttpStatusValidator [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/833021 (https://phabricator.wikimedia.org/T311455) [16:41:38] 10Fundraising Sprint Quarkery, 10Fundraising-Backlog, 10FR-WMF-Audit: Clarify audit processor logging - https://phabricator.wikimedia.org/T315034 (10AnnWF) a:03AnnWF [16:50:31] (03CR) 10Cstone: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [16:59:48] (03PS1) 10Wfan: Update the ideal non recurring payment function name from direct Debit to ideal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/833056 (https://phabricator.wikimedia.org/T316368) [17:00:10] 10Fundraising Sprint Quarkery, 10Fundraising-Backlog, 10Patch-For-Review: Adyen iDeal code seems to go through DirectDebitPaymentProvider - https://phabricator.wikimedia.org/T316368 (10AnnWF) a:03AnnWF [17:00:22] (03PS2) 10Wfan: Update the ideal non recurring payment function name from direct Debit to ideal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/833056 (https://phabricator.wikimedia.org/T316368) [17:36:51] (03CR) 10Umherirrender: [C: 03+2] HTMLCentralNoticeBannerMessage: Do not use mParams in constructor (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/832709 (https://phabricator.wikimedia.org/T317368) (owner: 10Umherirrender) [17:49:54] (03PS4) 10Ejegg: Stop Adyen adapter from sending an additional pending message [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832568 (https://phabricator.wikimedia.org/T317713) (owner: 10Jgleeson) [18:05:01] (03PS5) 10Ejegg: Stop Adyen adapter from sending an additional pending message [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832568 (https://phabricator.wikimedia.org/T317713) (owner: 10Jgleeson) [18:05:35] (03CR) 10Ejegg: [C: 03+2] "Looks good! PS5 just removes the FIXME comment." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832568 (https://phabricator.wikimedia.org/T317713) (owner: 10Jgleeson) [18:07:40] (03Merged) 10jenkins-bot: Stop Adyen adapter from sending an additional pending message [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832568 (https://phabricator.wikimedia.org/T317713) (owner: 10Jgleeson) [18:26:09] (03CR) 10Ejegg: "Would it be possible to do this at the log level with some regular expressions? This way seems like it will complicate a lot of the code a" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/833021 (https://phabricator.wikimedia.org/T311455) (owner: 10Wfan) [18:31:25] (03CR) 10Ejegg: "Looking pretty good so far! Are you going to also add a function to the PendingDatabase class that will let us get the oldest message by p" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831618 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [18:33:50] ejegg: I think we already have this function, at consume as fetchMessageByGatewayOldest to get the oldest message [18:34:18] wfan can you pass it 'cc' to only fetch credit card donations? [18:34:24] oor will it get ideal donations as well? [18:34:48] we also have this cc check at resolve as isMessageResolvable [18:34:48] Well, I guess we can check to see whether we need it [18:35:10] wfan and what happens when an ideal message fails the check at isMessageResolvable? [18:36:44] mark this pending txn with final status as FAILED and leave it at the pending table [18:37:04] wfan it's not just deleted at the pending table? [18:37:30] so if it's deleted, we might not be able to record a late-clearing ideal donation [18:37:57] and if it's not deleted, the resolver will get stuck retrieving the same message over and over again because it will still be the oldest [18:38:15] So i'm not actually sure if the first of those is a problem [18:38:53] we could probably go through the IPN logs and figure out the longest it's ever taken for an iDEAL donation to send a capture message [18:39:26] and if that's less than the minimum age for the Pending Transaction Resolver to touch a message, then we're OK to go ahead with the code as it is [18:39:59] but if it sometimes takes longer for the iDEAL capture IPN to come in, we will need to consume the pending table differently [18:40:11] Oh, right we delete this ideal message from pending table, and what do you mean by not be able to record a late-clearing ideal donation, should we move this message to other places? [18:40:38] wfan no, we should leave it in the pending queue since it's info about a pending iDEAL transaction [18:41:31] When the Adyen IPN listener gets a message about a payment capture, it looks for the donor info in the pending table to record the donation in civi [18:43:22] well, it sets up a RecordCaptureJob that does the combination of pending table + IPN info [18:44:39] ok, let me test an ideal locally with RecordCaptureJob first, see how long will iDEAL capture IPN to come in, and make sure the pending table will not stuck there as get oldest message for ideal by add more filter there. [18:44:44] wfan do you think you can figure out the maximum lag between pending message send and the recordcapturejob running for any given ideal message? [18:45:25] it would need a few grep commands and some small amount of code to do the date subtraction [18:45:43] but the necessary info should be in the logs [18:46:08] will see from civi for a real ideal donation, and see if we can find the corespondent log, then test other ideal donations, probably can get the medium lap [18:47:03] the reucrrings are waiting for the RECURRING_NOTIFICATION too [18:47:09] ipn [18:47:51] ooh, good point cstone [18:47:59] any idea how long those can take to come in? [18:48:20] no idea [19:02:57] ejegg: are we trying to keep DI up to date in civi? Like I want to update just smashpig for it but should I do DI too ? [19:03:19] cstone we are just updating DI because we have to [19:03:30] ever since we went to strict version constraints [19:03:56] so if DI requires smash-pig version 0.8.2.1 and then we want to upgrade smashpig in CRM we have to upgrade DI too [19:04:32] oh hmm, what if we started saying 0.8.2.1-or-higher in the DI requirement? [19:04:35] can we do that? [19:05:09] yep, totally could [19:05:41] thats fine just wanted to confirm to update the documentation [19:05:47] wait, but I think that would get us back to the problem we had before locking that version number [19:05:53] its fine ejegg [19:06:02] ok [19:06:02] i think this is better than CI broken [19:07:15] flow would be update smashpig -> update its version in civi and DI -> do I need to update the DI in civi too? [19:07:21] i guess thats what I was trying to ask hah [19:07:47] yep yep, when you update the smashpig version in civi you need to update the DI version in civi too [19:07:52] ok [19:08:31] wfan do you want me to try to do that log analysis to figure out the iDEAL capture timing? [19:09:15] tag smashpig -> update smashpig in DI -> tag DI -> update smashpig and DI in civi [19:09:50] Oh if you can help with that thanks! I am doing the regex one for that expiration date now [19:09:54] Thanks elliott :) [19:31:56] (03PS6) 10Wfan: Remove expiryDate from adyen soap listner Remove card info from ingenico auth fail log at HttpStatusValidator [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/833021 (https://phabricator.wikimedia.org/T311455) [19:42:16] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10FR-Email: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330 (10greg) See also {T317929} [19:49:52] 10Fundraising-Backlog: Custom field for Direct Mail Appeal not working on Engage import - https://phabricator.wikimedia.org/T317327 (10XenoRyet) Cool, if it's working now I'll go ahead and close this. Feel free to reopen if it crops up again. [19:50:01] 10Fundraising-Backlog: Custom field for Direct Mail Appeal not working on Engage import - https://phabricator.wikimedia.org/T317327 (10XenoRyet) 05Open→03Resolved [21:15:02] (03PS1) 10Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/833107 [21:15:49] fr-tech is there anything on this DI deploy that needs extra actions/more attention https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/833107 [21:16:41] cstone: I'd just test an Adyen donation to make sure it gets to the TY page [21:16:47] ok thanks ejegg ! [21:17:18] (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/833107 (owner: 10Cstone) [21:18:15] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/833107 (owner: 10Cstone) [21:20:01] (03PS1) 10Wfan: update smash-pig requirement to 0.8.2.12 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/833109 [21:21:33] (03CR) 10Wfan: [C: 03+2] update smash-pig requirement to 0.8.2.12 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/833109 (owner: 10Wfan) [21:22:58] hey our table of contents is back [21:23:43] (03Merged) 10jenkins-bot: update smash-pig requirement to 0.8.2.12 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/833109 (owner: 10Wfan) [21:43:14] (03PS1) 10Wfan: Update smash-pig to v0.8.2.12 and donation-interface to v2.5.7.11 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833117 [21:46:07] (03CR) 10Cstone: [C: 03+2] Update smash-pig to v0.8.2.12 and donation-interface to v2.5.7.11 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833117 (owner: 10Wfan) [21:55:30] (03CR) 10CI reject: [V: 04-1] Update smash-pig to v0.8.2.12 and donation-interface to v2.5.7.11 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833117 (owner: 10Wfan) [21:58:56] wfan I at least got a list of ideal timings for today - looks like the longest delay this time was like 15 min [21:59:41] I'll try to adapt the script to scan the last month [22:09:45] ejegg: for the audit changes in civi, I need smashpig updated but those updates alone fail CI cause it doesn't have my changed files [22:09:54] have we just had them all in the same commit in the past? [22:18:28] (03PS4) 10AndyRussG: Command-line tools for queues [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/833017 [22:20:30] (03PS5) 10AndyRussG: Command-line tools for queues [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/833017 [22:20:54] fr-tech got it to work!!!! https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/833017 [22:21:15] (03PS7) 10Wfan: Adding payments_details_report as an option for the Adyen Audit Also add the ability to choose the audit class based on filename Update smash-pig to v0.8.2.12 and donation-interface to v2.5.7.11 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [22:22:00] (03PS8) 10Wfan: Adding payments_details_report as an option for the Adyen Audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [22:55:21] (03Abandoned) 10Wfan: Update smash-pig to v0.8.2.12 and donation-interface to v2.5.7.11 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833117 (owner: 10Wfan)