[00:10:25] (03PS6) 10AndyRussG: Command-line tools for queues [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/833017 [00:15:07] (03PS1) 10Eileen: Use a setting to enable & disable greeting processing on create [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833131 (https://phabricator.wikimedia.org/T308181) [00:21:36] ejegg: I moved this to a setting - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/833131 so we can turn on & off more easily [00:26:00] eileen: oh great! [00:26:45] cstone sorry, just saw your question. Yep, I usually include the library update with the same commit that uses the changed functions [00:27:35] no worries ejegg [00:38:40] (03PS1) 10Cstone: Update DonationInterface submodule, vendor, and composer.lock [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/833133 [00:38:46] did i do this right [00:38:53] nope haha [00:39:54] (03PS1) 10Eileen: CiviCRM 5.53.0 tarball [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833134 (https://phabricator.wikimedia.org/T316713) [00:42:38] (03CR) 10CI reject: [V: 04-1] Update DonationInterface submodule, vendor, and composer.lock [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/833133 (owner: 10Cstone) [00:46:13] eileen: I'm wondering why I don't see any new row in civicrm_setting even after I ran system.flush and can see the new setting on the 'WMF specific configuration' page [00:46:38] it's not defaulting to true [00:49:20] hmm, it does persist fine when I save it though [00:49:33] saves it as string "1" [00:50:28] oh wait no, it saves it as an array with the name in there again [00:50:36] I guess that's how Civi does checkbox groups? [00:52:41] ok, html_type radio seems to work better [00:53:48] (03PS2) 10Cstone: Update DonationInterface submodule, vendor, and composer.lock [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/833133 [00:54:18] (03CR) 10Ejegg: "Very handy setting to have! Locally I had to edit the definition a little bit to make it default correctly to on" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833131 (https://phabricator.wikimedia.org/T308181) (owner: 10Eileen) [00:55:10] ejegg: can you push up your local changes? they look right [00:55:23] k [00:56:22] (03PS2) 10Ejegg: Use a setting to enable & disable greeting processing on create [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833131 (https://phabricator.wikimedia.org/T308181) (owner: 10Eileen) [00:56:38] (03CR) 10CI reject: [V: 04-1] CiviCRM 5.53.0 tarball [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833134 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen) [00:56:58] cool - who gives it +2 now? [00:57:24] I can? :P [00:58:15] (03CR) 10CI reject: [V: 04-1] Update DonationInterface submodule, vendor, and composer.lock [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/833133 (owner: 10Cstone) [00:59:05] what is going on with that failure [01:00:53] I'll figure it out tomorrow [01:01:10] ehh, I think I can C+2 [01:01:13] (03CR) 10Ejegg: [C: 03+2] Use a setting to enable & disable greeting processing on create [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833131 (https://phabricator.wikimedia.org/T308181) (owner: 10Eileen) [01:14:59] (03Merged) 10jenkins-bot: Use a setting to enable & disable greeting processing on create [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833131 (https://phabricator.wikimedia.org/T308181) (owner: 10Eileen) [01:34:34] oh shoot, my docker payments is now throwing errors on the : self typehint! [01:34:58] PHP Fatal error: Cannot use 'SmashPig\\PaymentProviders\\Responses\\self' as class name as it is reserved in /var/www/html/vendor/wikimedia/smash-pig/PaymentProviders/PaymentProviderResponse.php on line 74 [01:35:27] that's the strangest thing - I swear that wasn't causing problems on php7.4 when I was running that locally [01:41:57] that type hint's been there for a year now [01:49:28] works on PHP 8.1, works on PHP 7.3, why the heck is it breaking on php7.4? [01:50:37] ohhhh [01:50:49] dumb refactor issue? [01:51:04] just noticed the namespace [01:56:46] very helpful, PHPStorm... [02:29:23] (03PS3) 10Ejegg: Clean up base PaymentProviders folder [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/832522 [02:29:49] (03PS3) 10Ejegg: Declare recurringBaseUrl, allow for others [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/832384 (https://phabricator.wikimedia.org/T311741) [02:29:51] (03PS10) 10Ejegg: Implement Adyen data deletion API calls [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/832385 (https://phabricator.wikimedia.org/T311741) [02:54:46] (03CR) 10Ejegg: [V: 03+2 C: 03+2] "Very handy. Thanks!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/833017 (owner: 10AndyRussG) [02:56:37] (03CR) 10Ejegg: "Manual test now works! PS10 also corrects the endpoint the request was being sent to." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/832385 (https://phabricator.wikimedia.org/T311741) (owner: 10Ejegg) [03:15:41] (03PS2) 10Ejegg: WIP add Adyen data deletion requests to forgetme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/832580 (https://phabricator.wikimedia.org/T311741) [03:28:11] (03CR) 10CI reject: [V: 04-1] WIP add Adyen data deletion requests to forgetme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/832580 (https://phabricator.wikimedia.org/T311741) (owner: 10Ejegg) [06:13:08] (03PS1) 10Eileen: Use strict comparison for exception type. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833266 (https://phabricator.wikimedia.org/T316713) [06:14:00] This has me confused ^^ https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/833266 [06:14:55] (03PS2) 10Eileen: Use strict comparison for exception type. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833266 (https://phabricator.wikimedia.org/T316713) [06:17:54] (03PS1) 10Eileen: Commit test that was somehow missing from greeting setting commit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833267 (https://phabricator.wikimedia.org/T308181) [06:32:23] (03CR) 10CI reject: [V: 04-1] Commit test that was somehow missing from greeting setting commit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833267 (https://phabricator.wikimedia.org/T308181) (owner: 10Eileen) [06:58:43] 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Last CiviCRM point update for the year - https://phabricator.wikimedia.org/T316713 (10Eileenmcnaughton) a:03Eileenmcnaughton [06:59:02] (03PS1) 10Eileen: CiviCRM 5.54 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833308 (https://phabricator.wikimedia.org/T316713) [07:02:24] (03PS2) 10Eileen: Commit test that was somehow missing from greeting setting commit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833267 (https://phabricator.wikimedia.org/T308181) [07:14:11] (03CR) 10CI reject: [V: 04-1] CiviCRM 5.54 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833308 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen) [07:14:49] (03CR) 10CI reject: [V: 04-1] Commit test that was somehow missing from greeting setting commit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833267 (https://phabricator.wikimedia.org/T308181) (owner: 10Eileen) [15:09:33] (03CR) 10Cstone: "recheck" [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/833133 (owner: 10Cstone) [16:19:25] 10Fundraising-Backlog: Figure out what to do with CHARGEBACK_REVERSED Adyen ipns - https://phabricator.wikimedia.org/T318175 (10Cstone) [16:24:49] fr-tech is anyone available to review this namespace change? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/832522 [16:25:02] I'm afraid it will go stale if we wait too long [16:25:15] since it touches so many files [16:27:16] (03CR) 10Ejegg: [C: 03+2] Use strict comparison for exception type. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833266 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen) [16:27:31] (03PS3) 10Ejegg: Commit test that was somehow missing from greeting setting commit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833267 (https://phabricator.wikimedia.org/T308181) (owner: 10Eileen) [16:36:24] (03CR) 10Ejegg: "I'm not thrilled about the propertyExists check. If the goal is simply not to touch the other child classes, we could still have that with" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [16:41:09] (03Merged) 10jenkins-bot: Use strict comparison for exception type. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833266 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen) [16:43:59] (03CR) 10CI reject: [V: 04-1] Commit test that was somehow missing from greeting setting commit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833267 (https://phabricator.wikimedia.org/T308181) (owner: 10Eileen) [16:47:03] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen iframe config error messages inside card fields - https://phabricator.wikimedia.org/T292571 (10MBeat33) Ticket #1170431 is another example from September 17th (thanks, @krobinson) - we will ask them for browser / OS / add-ons details. [16:47:33] (03CR) 10Ejegg: "ah, looks like the early return doesn't work in phpunit" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833267 (https://phabricator.wikimedia.org/T308181) (owner: 10Eileen) [17:02:41] hey ejegg looks like theres a bugfix we need in the latest rel1_35 so unit tests will pass [17:02:52] do you have time to do a call to go over the process there? [17:03:05] sure cstone! [17:03:06] then I can add it to our docs [17:03:42] cstone https://meet.google.com/aio-mocx-ggt [17:13:28] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Performance-Team, 10Product-Analytics, 10SEO: Central Notice severely impacts CLS score - https://phabricator.wikimedia.org/T318046 (10mpopov) @jwang has looked into this but not for Hebrew Wikisource. Putting this into tracking for us for no... [17:13:36] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Performance-Team, 10Product-Analytics, 10SEO: Central Notice severely impacts CLS score - https://phabricator.wikimedia.org/T318046 (10AndyRussG) [17:18:56] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Performance-Team, 10Product-Analytics, 10SEO: Central Notice severely impacts CLS score - https://phabricator.wikimedia.org/T318046 (10kzimmerman) @ovasileva I remember you and @jwang had looked at some of the Wikipedias, and wanted to surfac... [17:32:44] (03CR) 10Cstone: [V: 03+2 C: 03+2] Update DonationInterface submodule, vendor, and composer.lock [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/833133 (owner: 10Cstone) [17:48:18] 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen iframe config error messages inside card fields - https://phabricator.wikimedia.org/T292571 (10MBeat33) @AMJohnson found two more, 1171882 from Sep 15th & 1174321 from today the 20th. 1171882 confirmed that the error messaging appeared before enter... [17:55:06] (03PS1) 10Cstone: Merge branch 'REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/833433 [17:56:48] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Performance-Team, 10Product-Analytics, 10SEO: CentralNotice severely impacts CLS score - https://phabricator.wikimedia.org/T318046 (10Krinkle) [18:04:24] (03CR) 10Cstone: [C: 03+2] Merge branch 'REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/833433 (owner: 10Cstone) [18:13:11] (03Merged) 10jenkins-bot: Merge branch 'REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/833433 (owner: 10Cstone) [18:15:50] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Performance-Team, 10Product-Analytics, and 2 others: CentralNotice severely impacts CLS score - https://phabricator.wikimedia.org/T318046 (10ovasileva) Discussed this with @jwang and we will look into it further. [18:22:21] ah AndyRussG, i see you're already aware of the new ticket ^^^ [18:22:36] yep yep [18:22:38] thx! [18:45:46] !log payments-wiki upgraded from de4b2bb9 to 0456850e [18:45:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:51:26] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Performance-Team, 10Product-Analytics, and 2 others: CentralNotice severely impacts CLS score - https://phabricator.wikimedia.org/T318046 (10AndyRussG) Hiiii all, thanks so much for this... a few quick notes, in case they're helpful: - It's bee... [18:53:42] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Product-Design-Strategy, 10Product-Infrastructure-Team-Backlog, and 6 others: [Discussion] Prevent SEO decline due to Google "page experience": mid-June 2021 - https://phabricator.wikimedia.org/T280476 (10AndyRussG) [18:54:52] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: Proposal: Fix banner bump with server-side cache-layer banner selection - https://phabricator.wikimedia.org/T283521 (10AndyRussG) [19:16:10] 10Fundraising-Backlog: Acoustic Click-tracking - SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T318188 (10DBu-WMF) [19:22:05] 10Fundraising-Backlog: GDPR "Email Opt-in" language change - As soon as possible - https://phabricator.wikimedia.org/T318189 (10DBu-WMF) [19:22:39] (03CR) 10Cstone: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [19:24:23] (03PS1) 10Damilare Adedoyin: WIP: Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316587) [19:30:51] (03PS2) 10Damilare Adedoyin: WIP: Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316587) [19:34:15] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/833445 [19:35:08] (03CR) 10CI reject: [V: 04-1] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/833445 (owner: 10Eileen) [19:36:11] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Ingenico FIELD_LENGTH_INVALID error when firstName is too long - https://phabricator.wikimedia.org/T317355 (10XenoRyet) [19:36:18] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Investigate timeouts from Adyen Soap listener - https://phabricator.wikimedia.org/T317422 (10XenoRyet) [19:42:01] (03PS1) 10Eileen: Update smash-pig to v0.8.2.11 and DonationInterface to v2.5.7.10 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/833446 [19:43:18] (03CR) 10Eileen: [C: 03+2] Update smash-pig to v0.8.2.11 and DonationInterface to v2.5.7.10 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/833446 (owner: 10Eileen) [19:44:02] (03PS2) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/833445 [19:49:16] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/833445 (owner: 10Eileen) [19:55:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Name changes required for Ingenico 3DS2.0 - https://phabricator.wikimedia.org/T312877 (10Cstone) [19:56:18] (03Merged) 10jenkins-bot: Update smash-pig to v0.8.2.11 and DonationInterface to v2.5.7.10 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/833446 (owner: 10Eileen) [19:58:03] (03CR) 10Eileen: [C: 03+2] "recheck" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/833445 (owner: 10Eileen) [19:58:59] k, i turned off the deleted contacts job [20:01:09] !log civicrm upgraded from e82d9cd0 to dcef393d [20:01:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:01:45] ok - that just went out [21:01:01] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Bee Wheel, 10Fundraising Sprint Cheese String Theory, and 46 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10AnnWF) [21:11:57] ejegg: for your smashpig patch to rename stuff did you run any composer things? [21:41:58] ejegg: so looking at the queue - it seems choppy - but I'm gonna change that setting & see if anything changes [21:43:00] it's currently off - so I will turn it down & look for further slow down [21:45:17] ok - changed on the quarter-hour [21:47:29] ok - just started seeing them resolved [21:57:58] (03PS1) 10Eileen: Re-fix cache miss [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833460 [21:58:23] (03CR) 10CI reject: [V: 04-1] Re-fix cache miss [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833460 (owner: 10Eileen) [21:58:35] hmm - we lost the cache-miss patch in the check in - I put it up - but I can also just focus on the civi update if we aren't gonna get it out this test [21:59:59] (03PS2) 10Eileen: CiviCRM 5.53.0 tarball [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833134 (https://phabricator.wikimedia.org/T316713) [22:00:25] (03PS2) 10Eileen: Re-fix cache miss [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833460 [22:11:33] cstone: no, no composer stuff yet for the smashpig patch [22:12:01] (03CR) 10CI reject: [V: 04-1] CiviCRM 5.53.0 tarball [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833134 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen) [22:15:11] (03CR) 10Wfan: [C: 03+2] "Tested locally that when donation amount lower than monthly convert min requirement for donation currency from config will not show Monthl" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832508 (https://phabricator.wikimedia.org/T316840) (owner: 10Damilare Adedoyin) [22:15:18] (03PS9) 10Wfan: Don't tokenize cards when donation is under Monthly Convert minimum [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832508 (https://phabricator.wikimedia.org/T316840) (owner: 10Damilare Adedoyin) [22:17:30] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833134 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen) [23:35:35] (03PS4) 10Eileen: Commit test that was somehow missing from greeting setting commit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833267 (https://phabricator.wikimedia.org/T308181) [23:48:08] (03CR) 10jenkins-bot: Commit test that was somehow missing from greeting setting commit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833267 (https://phabricator.wikimedia.org/T308181) (owner: 10Eileen)