[00:14:13] <wikibugs>	 (03PS1) 10Eileen: Adapt to exception changes in civi-upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833465 (https://phabricator.wikimedia.org/T316713)
[00:14:46] <wikibugs>	 (03PS3) 10Eileen: CiviCRM 5.53.0 tarball [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833134 (https://phabricator.wikimedia.org/T316713)
[00:44:23] <wikibugs>	 (03PS2) 10Eileen: CiviCRM 5.54 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833308 (https://phabricator.wikimedia.org/T316713)
[00:56:47] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] CiviCRM 5.54 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833308 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen)
[02:59:32] <wikibugs>	 (03PS1) 10Eileen: Adjust EoyEmail to pass language in the new core way [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833475 (https://phabricator.wikimedia.org/T316713)
[03:00:48] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Adjust EoyEmail to pass language in the new core way [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833475 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen)
[03:01:50] <wikibugs>	 (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833475 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen)
[11:32:20] <wikibugs>	 (03CR) 10Awight: "This change is ready for review." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/833757 (https://phabricator.wikimedia.org/T318222) (owner: 10Awight)
[11:43:55] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Vanity URL for Major Gifts Annual Appeal Mailing - https://phabricator.wikimedia.org/T318224 (10RLewis)
[12:00:50] <wikibugs>	 (03CR) 10Awight: Convert configuration into class const (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/833757 (https://phabricator.wikimedia.org/T318222) (owner: 10Awight)
[13:16:29] <wikibugs>	 10Fundraising-Backlog: Unsub Link in "Donation Thank You" email - https://phabricator.wikimedia.org/T318234 (10DBu-WMF)
[13:44:28] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+2] Create IPN listener for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817357 (https://phabricator.wikimedia.org/T303451) (owner: 10Jgleeson)
[13:45:23] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+2] Add Braintree Webhook Signature Validator component [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817315 (https://phabricator.wikimedia.org/T311169) (owner: 10Jgleeson)
[13:45:55] <wikibugs>	 (03Merged) 10jenkins-bot: Add Braintree Webhook Signature Validator component [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817315 (https://phabricator.wikimedia.org/T311169) (owner: 10Jgleeson)
[13:45:59] <wikibugs>	 (03Merged) 10jenkins-bot: Create IPN listener for Braintree [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/817357 (https://phabricator.wikimedia.org/T303451) (owner: 10Jgleeson)
[13:49:34] <wikibugs>	 (03PS2) 10Awight: Convert configuration into class const [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/833757 (https://phabricator.wikimedia.org/T318222)
[13:49:53] <wikibugs>	 (03CR) 10Awight: "This change is ready for review." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/833775 (https://phabricator.wikimedia.org/T318222) (owner: 10Awight)
[14:16:12] <wikibugs>	 (03PS3) 10Damilare Adedoyin: Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316587)
[14:26:02] <wikibugs>	 (03CR) 10Damilare Adedoyin: "Thanks for working on this Wfan. Looks good so far, I think we'd also have to rename the class name from DirectDebitPaymentProvider to Ban" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/833056 (https://phabricator.wikimedia.org/T316368) (owner: 10Wfan)
[14:44:13] <jgleeson>	 hi fr-tech!
[14:44:23] <cstone>	 hi jgleeson 
[14:44:44] <XenoRyet>	 Greetings
[14:45:27] <jgleeson>	 :)
[14:47:05] <greg-g>	 g'morn!
[15:14:32] <AndyRussG>	 hey fr-tech jgleeson cstone XenoRyet greg-g :)
[15:15:07] <AndyRussG>	 jgleeson: how are you feeling?
[15:15:51] <jgleeson>	 ahhh so so thanks AndyRussG. still feeling it a bit 
[15:16:20] <AndyRussG>	 greg-g: questions and thoughts on ESi dumped in ny last two comments here: https://phabricator.wikimedia.org/T308799
[15:17:04] <AndyRussG>	 jgleeson: awww hope you feel better soon, rest up :)
[15:18:57] <greg-g>	 AndyRussG: ty
[15:20:22] <greg-g>	 hopefully brandon has some time to review/respond soon, I fear there might be a "oh shit, what now?" moment soon (with varying levels of severity/ASAP-ness, depending) with that new CLS task :/
[15:25:22] <AndyRussG>	 greg-g: thank u!
[15:27:50] <greg-g>	 AndyRussG: and, of course, SRE are at their offsite this week so we probably won't hear back until at least tuesday next week :/
[15:28:11] <AndyRussG>	 ah right
[15:57:58] <wfan>	 damilare: thanks for the review, and good point, BankTransferPaymentProvider sounds good to me, on it
[15:58:43] <damilare>	 my pleasure wfan!
[15:59:24] <wikibugs>	 10Fundraising-Backlog: American Express needs to be accounted for differently in Civi - https://phabricator.wikimedia.org/T318250 (10EMartin)
[16:54:51] <wfan>	 ha actually damilare: based on this note "For now we only handle recurring rtbt, which is treated as direct debit under the hood." do you really think we should still update the name to BankTransferPaymentProvider from DirectDebitPaymentProvider? 
[16:59:49] <wfan>	 Or should we name it as IdealBankTransfer?  
[17:02:21] <wikibugs>	 (03PS3) 10Wfan: Update the ideal non recurring payment function name from direct Debit to ideal and the rest direct debit to bank transfer [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/833056 (https://phabricator.wikimedia.org/T316368)
[17:05:10] <wikibugs>	 (03PS4) 10Wfan: Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) (owner: 10Damilare Adedoyin)
[17:07:13] <damilare>	 IdealBankTransfer sounds fair wfan sure.
[17:07:31] <wfan>	 ok
[17:08:22] <damilare>	 thanks for the bug change on the tests
[17:09:25] <wikibugs>	 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising-Backlog: Unit tests for Adyen Pending Transaction Resolver - https://phabricator.wikimedia.org/T316588 (10Damilare) Gerrit patch: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/833444
[17:13:21] <wikibugs>	 (03PS4) 10Wfan: Update adyen class name from DirectDebit to IdealBankTransfer and function name from createDirectDebitPaymentFromCheckout to createIdealNonRecurringPaymentFromCheckout for easy understanding [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/833056 (https://phabricator.wikimedia.org/T316368)
[17:16:31] <greg-g>	 FYI: In Phabricator I changed the "additional hashtag" #fr-tech from #wikimedia-fundraising (which afaict we don't use) to #fundraising-backlog. See https://phabricator.wikimedia.org/project/manage/363/#89546 and https://phabricator.wikimedia.org/project/manage/41/#89547
[17:28:28] <XenoRyet>	 Noted, and good call.
[17:37:34] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+2] Update adyen class name from DirectDebit to IdealBankTransfer and function name from createDirectDebitPaymentFromCheckout to createIdealNonR [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/833056 (https://phabricator.wikimedia.org/T316368) (owner: 10Wfan)
[17:38:02] <wikibugs>	 (03Merged) 10jenkins-bot: Update adyen class name from DirectDebit to IdealBankTransfer and function name from createDirectDebitPaymentFromCheckout to createIdealNonRecurringPaymentFromCheckout for easy understanding [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/833056 (https://phabricator.wikimedia.org/T316368) (owner: 10Wfan)
[18:27:15] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[18:32:09] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[18:34:49] <icinga-wm>	 ACKNOWLEDGEMENT - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) Jeff_Green known https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[19:07:18] <wikibugs>	 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Epic: CiviCRM/SmashPig: wmf_audit refactor - https://phabricator.wikimedia.org/T318265 (10jgleeson)
[19:07:44] <jgleeson>	 fr-tech, I added a ticket with a link to the etherpad created on the last call https://phabricator.wikimedia.org/T318265
[19:08:11] <jgleeson>	 I'm not sure if it should be tagged against that refactor epic 
[19:08:31] <jgleeson>	 do we have a civicrm refactor tag floating around?
[19:28:32] <jgleeson>	 I found the drupal upgrade tag but not sure if that fits either
[20:01:12] <jgleeson>	 fr-tech I'm looing at something to pick up in the back log. I looked over the pending_trxn_resolver tickets and they all seem done and possibly ready for review AndyRussG? There's a docker testing ticket which I might pick up. ejegg cstone do you have any more details on the exhaustive testing mentioned?> https://phabricator.wikimedia.org/T317701
[20:02:00] <cstone>	 jgleeson: I made that hoping someone else would elaborate 😂
[20:02:05] <jgleeson>	 are we testing out the upgrade of the other services? 
[20:02:12] <jgleeson>	 or just payments.
[20:02:13] <jgleeson>	 ah
[20:04:44] <jgleeson>	 ejegg: this is in review but I can't see a patch on the ticket https://phabricator.wikimedia.org/T317836 
[20:05:09] <jgleeson>	 I feel like I've seen that patch
[20:05:29] <cstone>	 There are some smashing name change patches up for review that I was going to try to look at but feel free jgleeson 
[20:05:32] <cstone>	 I'm at the post office 
[20:05:40] <jgleeson>	 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/714578
[20:05:57] <jgleeson>	 cstone: I think dami +2ed the directdebit one
[20:06:04] <cstone>	 It was a different one 
[20:06:12] <jgleeson>	 ah np sorry to bug
[20:06:12] <cstone>	 That Elliott put up
[20:06:16] <cstone>	 No worries 
[20:06:22] <cstone>	 I am waiting in line 
[20:06:49] <wikibugs>	 10Fundraising Sprint Quarkery, 10Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: Use REST endpoint for cancelling Adyen payments - https://phabricator.wikimedia.org/T317836 (10jgleeson) related patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/714578
[20:07:46] <cstone>	 This one jgleeson https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/832522
[20:10:23] <jgleeson>	 ahh ok cool thanks cstone 
[20:13:36] <wikibugs>	 (03CR) 10Jgleeson: Adyen: Use REST for cancelling payments (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/714578 (https://phabricator.wikimedia.org/T317834) (owner: 10Ejegg)
[20:14:21] <wikibugs>	 10Fundraising Sprint Quarkery, 10Fundraising-Backlog: Exhaustively test bullseye upgrade in fundraising-dev - https://phabricator.wikimedia.org/T317701 (10jgleeson) a:03jgleeson
[20:37:41] <ejegg>	 ack, sorry, my pings aren't coming through
[20:37:49] <ejegg>	 thanks for linking those!
[20:39:58] <wikibugs>	 10Fundraising-Backlog, 10fr-donorservices: build Adyen API into Civi Forget Me button - https://phabricator.wikimedia.org/T318283 (10MBeat33)
[20:45:45] <wikibugs>	 (03PS5) 10Ejegg: Adyen: Use REST for cancelling payments [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/714578 (https://phabricator.wikimedia.org/T317836)
[20:46:10] <wikibugs>	 (03CR) 10Ejegg: Adyen: Use REST for cancelling payments (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/714578 (https://phabricator.wikimedia.org/T317836) (owner: 10Ejegg)
[22:31:12] <wikibugs>	 (03PS1) 10Eileen: Rc fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833859
[23:06:50] <cstone>	 eileen: are you around to sanity check me real quick?
[23:32:19] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Adyen iDEAL TY email delay - https://phabricator.wikimedia.org/T316602 (10Cstone) This was related to a bug where if we were importing a recurring iDEAL donation from the audit it wasn't getting the token from Adyen and not getting i...