[02:43:19] <wikibugs>	 (03PS2) 10Eileen: Update to latest civitoken [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/834620 (https://phabricator.wikimedia.org/T318304)
[04:25:34] <wikibugs>	 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Quarkery, 10Fundraising-Backlog, 10Epic: [epic] Adyen - auto settle stopped prior donors (Pending transaction Resolver) - https://phabricator.wikimedia.org/T299692 (10AndyRussG) a:05AndyRussG→03None
[05:16:50] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/834767 (owner: 10L10n-bot)
[08:16:52] <wikibugs>	 (03CR) 10Awight: "This change is ready for review." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/835077 (owner: 10Awight)
[08:17:33] <wikibugs>	 (03CR) 10Awight: "This change is ready for review." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/835078 (https://phabricator.wikimedia.org/T318511) (owner: 10Awight)
[08:37:55] <wikibugs>	 (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/834767 (owner: 10L10n-bot)
[10:21:47] <wikibugs>	 10Fundraising-Backlog, 10FR-AutoTY-Email: Copy request for recurring receipt and standard TY email - https://phabricator.wikimedia.org/T251428 (10Aklapper) a:05spatton→03None Removing task assignee due to inactivity as this open task has been assigned for more than two years. See the email sent to the task...
[10:23:30] <wikibugs>	 10Fundraising Sprint CAPS LOCK CULTS, 10Fundraising Sprint Dampness, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Delete more deleted contacts? - https://phabricator.wikimedia.org/T247347 (10Aklapper) a:05Eileenmcnaughton→03None Removing task assignee due to inactivity as this...
[10:26:56] <wikibugs>	 10fundraising-tech-ops: encrypt fundraising database client->server communication - https://phabricator.wikimedia.org/T170321 (10Aklapper) a:05Dwisehaupt→03None Removing task assignee due to inactivity as this open task has been assigned for more than two years. See the email sent to the task assignee on Aug...
[10:33:11] <wikibugs>	 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MinervaNeue (Tracking), 10Performance-Team (Radar): Safari crashes on some click handling events for banners that move the centralNotice element outside of the the main body - https://phabricator.wikimedia.org/T242895 (10Aklapper) a:05Jdrewnia...
[10:36:31] <wikibugs>	 10Wikimedia-Fundraising-Banners, 10MediaWiki-extensions-CentralNotice: Find and remove unneeded sitenotice rules from local CSS - https://phabricator.wikimedia.org/T247244 (10Aklapper) a:05Pcoombe→03None Removing task assignee due to inactivity as this open task has been assigned for more than two years. S...
[10:37:15] <wikibugs>	 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Browser-Support-Firefox, 10MW-1.37-notes (1.37.0-wmf.11; 2021-06-21): <select> on payments form is slightly taller than other fields in Firefox - https://phabricator.wikimedia.org/T187451 (10Aklapper) a:05Pcoombe→03None Removing task as...
[10:50:23] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New custom Activities Created in Civi - https://phabricator.wikimedia.org/T318529 (10RLewis)
[10:53:11] <wikibugs>	 (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/834163 (owner: 10L10n-bot)
[11:43:55] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Error message when using the export contacts function in Civi - https://phabricator.wikimedia.org/T318339 (10RLewis)
[12:50:16] <wikibugs>	 (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Remove unused variables [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/835077 (owner: 10Awight)
[13:04:00] <wikibugs>	 (03Merged) 10jenkins-bot: Remove unused variables [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/835077 (owner: 10Awight)
[13:11:12] <wikibugs>	 (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Convert configuration into class const (032 comments) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/833757 (https://phabricator.wikimedia.org/T318222) (owner: 10Awight)
[13:13:21] <wikibugs>	 (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Detect empty list of countries or regions [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/834490 (https://phabricator.wikimedia.org/T318222) (owner: 10Awight)
[13:18:17] <wikibugs>	 (03Merged) 10jenkins-bot: Detect empty list of countries or regions [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/834490 (https://phabricator.wikimedia.org/T318222) (owner: 10Awight)
[14:52:12] <icinga-wm>	 PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: check_endpoints_critical (minFraud-East:4) 4 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages
[14:57:12] <icinga-wm>	 PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: check_endpoints_critical (minFraud-East:5) 5 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages
[15:02:12] <icinga-wm>	 PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: check_endpoints_critical (minFraud-East:6) 6 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages
[15:07:12] <icinga-wm>	 PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: check_endpoints_critical (minFraud-East:3) 3 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages
[15:12:12] <icinga-wm>	 RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages
[15:18:43] <wikibugs>	 10Fundraising-Backlog, 10fundraising-tech-ops: Vanity URL for Major Gifts Annual Appeal Mailing - https://phabricator.wikimedia.org/T318224 (10Jgreen) 05Open→03Resolved @RLewis I'm going to close this task since the part we can do on our end is done. If you decide to change the Endowment URL to a fundraisi...
[15:23:57] <wikibugs>	 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Performance-Team (Radar): Safari crashes on some click handling events for banners that move the centralNotice element outside of the the main body - https://phabricator.wikimedia.org/T242895 (10Jdlrobson)
[16:44:13] <wikibugs>	 10Fundraising Sprint Quarkery, 10Fundraising-Backlog: Exhaustively test bullseye upgrade in fundraising-dev - https://phabricator.wikimedia.org/T317701 (10jgleeson) | **Test** | **Buster Result** | **Bullseye Result** |  Notes | | Adyen Donation - CC | Pass | Pass | | | Adyen Donation - iDEAL |  |  | | | Adyen...
[17:11:31] <wikibugs>	 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen iframe config error messages inside card fields - https://phabricator.wikimedia.org/T292571 (10jgleeson)
[17:12:06] <jgleeson>	 fr-tech I just tagged that with Chaos Crew ^^^- Kristie mentioned it on the call 
[17:12:33] <AndyRussG>	 thx jgleeson :)
[17:12:44] <jgleeson>	 np
[18:07:10] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[18:12:10] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[18:17:14] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[18:22:08] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[18:27:12] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[18:31:29] <damilare>	 hi ejegg, I added this maintenance script: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/834598 to test the cancel payment patch you worked on. Please check out the last comment I dropped on your patch, so we can push it forward today https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/714578/6
[18:32:11] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[18:35:31] <ejegg>	 hi damilare, looks good! I'll fix that param name right now
[18:35:43] <damilare>	 thanks
[18:37:05] <ejegg>	 damilare ooohh, i just realized that reference isn't the gateway txn ID after all! It's a new reference for the cancel
[18:37:12] <ejegg>	 and it's optional
[18:37:42] <ejegg>	 so I guess that would correspond to the order_id for other calls
[18:38:37] <damilare>	 oh that's true, it's just the merchant account that's compulsory
[18:38:59] <ejegg>	 so I guess that cancel function should take a params array. I'll make those changes
[18:39:00] <damilare>	 however, having paymentReference in the body does raise an error
[18:39:22] <ejegg>	 yep yep, the (psp) payment reference should only go in the URL
[18:39:49] <damilare>	 yep correct, thanks
[18:42:13] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[18:42:40] <ejegg>	 ooh, that would mean changing ICancelablePaymentProvider... let'
[18:42:48] <ejegg>	 s see where else that is actually being used
[18:43:23] <ejegg>	 huh, that's in a lot of places
[18:43:32] <ejegg>	 I think maybe I'll leave that as a TODO, actually
[18:46:45] <damilare>	 oohh ok
[18:47:13] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[18:48:07] <wikibugs>	 (03PS7) 10Ejegg: Adyen: Use REST for cancelling payments [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/714578 (https://phabricator.wikimedia.org/T317836)
[18:48:20] <ejegg>	 ok damilare, there it is with just the bad param removed
[18:48:47] <damilare>	 cool thanks, I'd check it now.
[18:49:14] <damilare>	 Do we need the maintenance script in the long run ejegg
[18:51:53] <wikibugs>	 (03CR) 10Ejegg: "Thanks, this is useful! Let's update the copied bits a little and maybe take 'Test' out of the script name." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834598 (owner: 10Damilare Adedoyin)
[18:52:07] <ejegg>	 damilare: I'm not sure, but it could be nice to have!
[18:52:11] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[18:56:35] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] Adapt to exception changes in civi-upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833465 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen)
[18:57:11] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[19:02:11] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[19:04:57] <wikibugs>	 (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks for working on the fixes, looks good to me." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/714578 (https://phabricator.wikimedia.org/T317836) (owner: 10Ejegg)
[19:06:11] <wikibugs>	 (03Merged) 10jenkins-bot: Adyen: Use REST for cancelling payments [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/714578 (https://phabricator.wikimedia.org/T317836) (owner: 10Ejegg)
[19:06:23] <ejegg>	 thanks damilare !
[19:07:11] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[19:08:33] <ejegg>	 fr-tech I see a lot of recurring QC failures on failed email sends. Maybe we should bring this into the next sprint: https://phabricator.wikimedia.org/T256176
[19:08:52] <ejegg>	 or rather recurring charge job failures
[19:09:00] <wikibugs>	 (03Merged) 10jenkins-bot: Adapt to exception changes in civi-upgrade [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833465 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen)
[19:09:02] <damilare>	 np ejegg
[19:12:11] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[19:14:12] <wikibugs>	 (03PS3) 10Damilare Adedoyin: Maintenance script useful for testing the Adyen cancel payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834598
[19:14:39] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] Maintenance script useful for testing the Adyen cancel payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834598 (owner: 10Damilare Adedoyin)
[19:14:45] <wikibugs>	 (03CR) 10Ejegg: [C: 03+2] "Woohoo, this is so much better!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833475 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen)
[19:16:01] <wikibugs>	 (03PS4) 10Damilare Adedoyin: Maintenance script useful for testing the Adyen cancel payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834598
[19:17:11] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[19:17:54] <wikibugs>	 (03PS5) 10Damilare Adedoyin: Maintenance script useful for testing the Adyen cancel payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834598
[19:19:12] <wikibugs>	 (03CR) 10Damilare Adedoyin: Maintenance script useful for testing the Adyen cancel payment (034 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834598 (owner: 10Damilare Adedoyin)
[19:22:11] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[19:27:11] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[19:28:59] <wikibugs>	 10Fundraising-Backlog: Bug (not yet deployed): Adyen no longer shows error page - https://phabricator.wikimedia.org/T318617 (10AndyRussG)
[19:31:29] <wikibugs>	 10Fundraising-Backlog, 10FR-Docker: Clean up and simplify fraud filter settings in LocalSettings-private.php in config-private for local dev setup - https://phabricator.wikimedia.org/T318619 (10AndyRussG)
[19:32:12] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[19:33:03] <wikibugs>	 10Fundraising-Backlog: Bug (not yet deployed): Adyen no longer shows error page - https://phabricator.wikimedia.org/T318617 (10Ejegg) Oops, looks like there should be a 'return' after that redirect in the isFailed block.
[19:34:02] <wikibugs>	 10Fundraising-Backlog, 10FR-Adyen: Increase timeouts for Adyen API calls - https://phabricator.wikimedia.org/T318620 (10AndyRussG)
[19:35:50] <wikibugs>	 10Fundraising-Backlog: Bug (not yet deployed): Adyen no longer shows error page - https://phabricator.wikimedia.org/T318617 (10jgleeson) ah. not run into that one before.
[19:37:12] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[19:42:12] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[19:43:58] <wikibugs>	 10Fundraising-Backlog, 10FR-Adyen: Add metrics and data pipeline for response times from Adyen - https://phabricator.wikimedia.org/T318621 (10AndyRussG)
[19:45:43] <wikibugs>	 (03PS1) 10Ejegg: Return after redirecting to fail page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/835261 (https://phabricator.wikimedia.org/T318617)
[19:47:54] <wikibugs>	 10Wikimedia-Fundraising, 10MediaWiki-extensions-CentralNotice, 10MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), 10Patch-For-Review: Special:CentralNotice shows broken text in "short lists" - https://phabricator.wikimedia.org/T318222 (10awight) Problem is fixed on the [[ https://meta.wikimedia.beta.wmflabs.org/w...
[19:48:13] <wikibugs>	 10Wikimedia-Fundraising, 10MediaWiki-extensions-CentralNotice, 10MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), 10Patch-For-Review: Special:CentralNotice shows broken text in "short lists" - https://phabricator.wikimedia.org/T318222 (10awight)
[19:52:12] <icinga-wm>	 RECOVERY - check_mysql on frdb2003 is OK: Uptime: 360107 Threads: 5 Questions: 255592968 Slow queries: 142 Opens: 1751 Open tables: 1424 Queries per second avg: 709.769 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[19:52:44] <wikibugs>	 10Wikimedia-Fundraising, 10MediaWiki-extensions-CentralNotice, 10MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), 10Patch-For-Review: Special:CentralNotice shows broken text in "short lists" - https://phabricator.wikimedia.org/T318222 (10awight) > ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 202...
[19:53:41] <wikibugs>	 10Fundraising-Backlog: American Express needs to be accounted for differently in Civi - https://phabricator.wikimedia.org/T318250 (10XenoRyet) Thanks for the ticket.  As discussed, we'll take a look at this after en6c.
[19:54:54] <wikibugs>	 (03CR) 10Awight: [C: 03+1] "This turned out to not be relevant to fixing the bug, but helps make sure that it doesn't regress." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/833775 (https://phabricator.wikimedia.org/T318222) (owner: 10Awight)
[19:58:45] <wikibugs>	 10Fundraising-Backlog: GDPR "Email Opt-in" language change - As soon as possible - https://phabricator.wikimedia.org/T318189 (10XenoRyet) As far as I can tell, this looks like it's only on DonateWiki and not on PaymentsWiki.   @Pcoombe, can you let me know if that's right?
[20:01:41] <wikibugs>	 (03CR) 10Jgleeson: [C: 04-1] "hmm this is strange. I'm getting the redirect to the error page with and without this patch." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/835261 (https://phabricator.wikimedia.org/T318617) (owner: 10Ejegg)
[20:07:41] <wikibugs>	 10Fundraising-Backlog: GDPR "Email Opt-in" language change - As soon as possible - https://phabricator.wikimedia.org/T318189 (10Pcoombe) 05Open→03Resolved a:03Pcoombe That's correct, this change was made on donatewiki already.
[20:08:11] <wikibugs>	 10Fundraising-Backlog: chmod(): Operation not permitted BaseAuditProcessor.php:1063 - https://phabricator.wikimedia.org/T318623 (10AnnWF)
[20:27:12] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[20:37:12] <icinga-wm>	 RECOVERY - check_mysql on frdb2003 is OK: Uptime: 362807 Threads: 5 Questions: 256410876 Slow queries: 144 Opens: 1763 Open tables: 1430 Queries per second avg: 706.741 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[20:39:01] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations: Recurring charge job shouldn't crash on email send error - https://phabricator.wikimedia.org/T256176 (10Dwisehaupt)
[20:41:15] <wikibugs>	 (03CR) 10Ejegg: "jgleeson it looks like the repro steps are to get it caught in the fraud filter after a successful auth" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/835261 (https://phabricator.wikimedia.org/T318617) (owner: 10Ejegg)
[20:46:51] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New custom Activities Created in Civi - https://phabricator.wikimedia.org/T318529 (10Dwisehaupt)
[20:47:01] <wikibugs>	 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: New custom Activities Created in Civi - https://phabricator.wikimedia.org/T318529 (10jgleeson) https://wikitech.wikimedia.org/wiki/Fundraising#Custom_fields
[20:47:04] <wikibugs>	 10Fundraising-Backlog, 10FR-AutoTY-Email: Unsub Link in "Donation Thank You" email - https://phabricator.wikimedia.org/T318234 (10KHaggard) 05Open→03Resolved a:03KHaggard Hi @DBu-WMF - "instantly" has been removed from the TY email copy in English.  As we have a different ticket (T317929) about the unsub...
[20:49:26] <wikibugs>	 10Fundraising-Backlog, 10FR-Smashpig, 10Patch-For-Review: Consistently track time taken for payment processor API responses - https://phabricator.wikimedia.org/T318380 (10Dwisehaupt)
[20:50:08] <eileen>	 XenoRyet: just realised I should have stayed in as I closed out
[20:50:44] <XenoRyet>	 No worries, I don't have anything for this week really, but I could jump back on if you want to bs a bit.
[20:52:12] <icinga-wm>	 PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[20:53:52] <eileen>	 nah that's cool
[20:55:04] <wikibugs>	 10Wikimedia-Fundraising-CiviCRM, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team (Blocking 🧱): CI has somehow completely stopped for a pr at wikimedia/fundraising/crm master - https://phabricator.wikimedia.org/T317928 (10thcipriani) 05Open→03Resolved a:03dancy >>! In T317928#8242575...
[21:02:12] <icinga-wm>	 RECOVERY - check_mysql on frdb2003 is OK: Uptime: 364307 Threads: 5 Questions: 256799402 Slow queries: 146 Opens: 1767 Open tables: 1432 Queries per second avg: 704.898 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql
[21:24:04] <wikibugs>	 (03CR) 10Jgleeson: [C: 03+2] "LGTM. Nice tidy up. Tested a donation after applying and worked without issue." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/832522 (owner: 10Ejegg)
[21:24:38] <wikibugs>	 (03Merged) 10jenkins-bot: Clean up base PaymentProviders folder [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/832522 (owner: 10Ejegg)
[21:26:18] <wikibugs>	 (03CR) 10Jgleeson: Return after redirecting to fail page (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/835261 (https://phabricator.wikimedia.org/T318617) (owner: 10Ejegg)
[21:45:41] <eileen>	 dwisehaupt: so if we update civi tomorrow - what time works for you?
[21:48:09] <ejegg>	 thanks jgleeson !
[21:50:22] <wikibugs>	 (03PS5) 10Ejegg: Declare recurringBaseUrl, allow for others [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/832384 (https://phabricator.wikimedia.org/T311741)
[21:50:24] <wikibugs>	 (03PS12) 10Ejegg: Implement Adyen data deletion API calls [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/832385 (https://phabricator.wikimedia.org/T311741)
[21:51:33] <ejegg>	 AndyRussG: would you be able to review this fix for the opt-outs missed due to the gatewayChooser bug? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/834413
[21:52:10] <ejegg>	 there's a bit more context of why it works on the ticket: https://phabricator.wikimedia.org/T311974#8254870
[22:00:26] <wikibugs>	 (03PS2) 10Awight: Make chooser's makePossibleBanners publicly accessible [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/835078 (https://phabricator.wikimedia.org/T318511)
[22:08:53] <dwisehaupt>	 eileen: sorry, i've got nothing on the calendar but midsprint. so i'm ok until ~6p PDT.
[22:10:43] <eileen>	 dwisehaupt: this? https://www.timeanddate.com/worldclock/meetingdetails.html?year=2022&month=9&day=29&hour=0&min=0&sec=0&p1=2099&p2=224&p3=136&p4=179&p5=240
[22:11:36] <dwisehaupt>	 up to one hour later than that.
[22:12:02] <dwisehaupt>	 but yeah. if we started then it would be ok.
[22:12:40] <ejegg>	 tomorrow, huh? I really should focus on reviewing those changes!
[22:17:15] <dwisehaupt>	 i'm going to go ahead and stop the p-c jobs in prep for the frdb1004 kernel and mariadb updates.
[22:25:29] <dwisehaupt>	 oh yeah, i'll put civi in maint mode too since the db restarting would cause errors. just fyi.
[22:35:26] <icinga-wm>	 PROBLEM - Host frdb1004 is DOWN: PING CRITICAL - Packet loss = 100%
[22:36:02] <dwisehaupt>	 ^^^ that's expected during the reboot. i'll put in the downtime.
[22:36:14] <icinga-wm>	 PROBLEM - check_mysql on frdb1006 is CRITICAL: Slave IO: Connecting Slave SQL: Yes Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1006&service=check_mysql
[22:38:26] <icinga-wm>	 RECOVERY - Host frdb1004 is UP: PING OK - Packet loss = 0%, RTA = 0.30 ms
[22:41:14] <icinga-wm>	 RECOVERY - check_mysql on frdb1006 is OK: Uptime: 532032 Threads: 4 Questions: 90265039 Slow queries: 0 Opens: 905 Open tables: 729 Queries per second avg: 169.660 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1006&service=check_mysql
[22:53:15] <dwisehaupt>	 we still have a steady stream of donations coming in, possibly from the email campaign that has been running. going to hold off on doing the update/reboot on the queue server for now.
[22:56:59] * greg-g nods
[23:12:12] <eileen>	 ejegg: let me put a new patch up - for the civi rc code
[23:13:24] <eileen>	 these should be good to go - but are more optional https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/834620
[23:30:35] <wikibugs>	 (03PS3) 10Eileen: CiviCRM 5.54 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833308 (https://phabricator.wikimedia.org/T316713)
[23:31:50] <wikibugs>	 (03PS4) 10Eileen: CiviCRM 5.54 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833308 (https://phabricator.wikimedia.org/T316713)
[23:32:14] <wikibugs>	 (03Abandoned) 10Eileen: Rc fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833859 (owner: 10Eileen)
[23:32:44] <wikibugs>	 (03PS2) 10Eileen: Adjust EoyEmail to pass language in the new core way [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833475 (https://phabricator.wikimedia.org/T316713)
[23:32:55] <eileen>	 ok ejegg if that passes jenkins it should be good to go
[23:34:57] <wikibugs>	 (03CR) 10Ejegg: [C: 04-1] "It's great to be able to filter, but I would really rather introduce a dedicated column for payment_method. This has the potential to perf" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834599 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan)
[23:35:10] <ejegg>	 thanks eileen, pulling it down now
[23:41:44] <ejegg>	 wfan so in SmashPig we haven't yet decided how to do incremental database updates
[23:42:20] <wfan>	 ejegg:  for the pending table, we do not have a column named payment_method, what do you mean bt introduce a dedicated column? 
[23:42:40] <ejegg>	 I guess the easiest would be to just add an extra script to each of the database folders then add that to the list of files in the corresponding database class's getTableScriptFiles
[23:43:11] <ejegg>	 wfan exactly, I think we should add an indexed payment_method column so we can be pretty sure that new lookup will be fast
[23:44:09] <ejegg>	 so you would add 007_AddPaymentMethodToPendingTable.sql to both the Schema/mysql and Schema/sqlite folders
[23:44:43] <wikibugs>	 (03CR) 10CI reject: [V: 04-1] CiviCRM 5.54 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833308 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen)
[23:46:49] <wfan>	 ok will check this patch as reference https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/741738
[23:47:13] <ejegg>	 wfan yep, that's a good start.
[23:47:28] <ejegg>	 so yours will be the first standalone alter table patch
[23:47:36] <eileen>	 dwisehaupt: sorry this time - the day was wrong on the first
[23:47:37] <eileen>	 https://www.timeanddate.com/worldclock/meetingdetails.html?year=2022&month=9&day=28&hour=0&min=0&sec=0&p1=2099&p2=224&p3=136&p4=179&p5=240
[23:47:39] <ejegg>	 and as long as nothing calls it twice it should be fine
[23:48:26] <ejegg>	 we are using 'create table if not exists' to let us call the existing scripts twice
[23:48:49] <ejegg>	 but there's no simple equivalent 'add column if not exists' for sqlite at least
[23:52:12] <ejegg>	 so let's just try it with the simple alter table add column syntax and see if that gives us problems.
[23:52:14] <wfan>	 hmm, we can use IF NOT EXISTS
[23:52:32] <dwisehaupt>	 eileen: that works.
[23:52:48] <wfan>	 https://stackoverflow.com/questions/24571611/mysql-alter-table-if-column-not-exists like this ejegg:
[23:53:14] <ejegg>	 wfan yep, that will work for mysql, it's just not supported under sqlite, which we use for tests
[23:53:36] <ejegg>	 so hopefully we don't need it for sqlite