[00:01:02] puppet run started to put civi in maint mode. [00:01:42] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/835714 [00:01:44] thanks dwisehaupt [00:01:56] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/835714 (owner: 10Eileen) [00:02:50] SmashPig-ConsumePendingQueue still processing the queue but it should wrap up in the next few minutes. [00:02:54] (03PS6) 10Wfan: Add payment_methods to pending table for fetchMessageByGatewayOldest to filter it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834599 (https://phabricator.wikimedia.org/T316587) [00:03:01] ok - code is merged through [00:03:41] (03CR) 10CI reject: [V: 04-1] Add payment_methods to pending table for fetchMessageByGatewayOldest to filter it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834599 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [00:04:34] hi eileen, I'm back [00:04:45] (03PS7) 10Wfan: Add payment_methods to pending table for fetchMessageByGatewayOldest to filter it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834599 (https://phabricator.wikimedia.org/T316587) [00:05:10] ejegg: cool - I'm ready to push the code once dwisehaupt confirms stuff is off [00:07:13] weird, pending queue consumer usually finishes within a minute [00:07:28] ah but it does wait the whole minute to see if new messages come in [00:08:23] (03CR) 10Ejegg: [C: 03+2] Contactlayouteditor update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835707 (https://phabricator.wikimedia.org/T318304) (owner: 10Eileen) [00:08:43] sorry, family came home. that smashpig job is still rolling through messages but everything else should be good. [00:08:55] weird, lemme look at the logs [00:09:16] oh, pending qc is nothing to do with civi in any case so we should be fine to go [00:09:39] (03PS1) 10Eileen: Civix upgrade on forgetme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835715 (https://phabricator.wikimedia.org/T318304) [00:10:23] and it's done. [00:10:31] ahhh, we made it run for 10 minute cycles [00:10:34] dwisehaupt: ok so I should push the code now? [00:10:55] and wait the whole time [00:10:56] eileen: you are clear. [00:11:06] ejegg: yeah: Processed 802 pending messages in 586 seconds. [00:11:31] just for future reference dwisehaupt and eileen that job doesn't touch any civi code or the civi db [00:11:37] !log civicrm upgraded from e198fb4c to 118c1d0b [00:11:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:11:40] so it could probably stay running [00:11:56] ok - upgrade script started [00:14:32] the script has run - I'll grab the triggers [00:20:21] (03Merged) 10jenkins-bot: Contactlayouteditor update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835707 (https://phabricator.wikimedia.org/T318304) (owner: 10Eileen) [00:20:37] eileen: if the triggers are on civi in org.wikimedia.civicrm/drupal/sites/all/modules/wmf_civicrm/scripts/ i can grab them. [00:21:32] dwisehaupt: yeah just updating them [00:22:57] cool. [00:23:52] (03PS1) 10Eileen: Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835717 (https://phabricator.wikimedia.org/T316713) [00:24:01] today I learned about newgrp [00:24:24] handy command to get your new group membership to take effect without logging out and back in [00:24:42] ejegg: wanna merge ^^ [00:25:08] ejegg: interesting. i did not know about newgrp [00:25:14] looking eileen [00:26:39] 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10FR-Adyen, 10Patch-For-Review: Write code for Adyen Pending Transaction Resolver - https://phabricator.wikimedia.org/T316587 (10AnnWF) [00:29:56] (03PS2) 10Ejegg: Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835717 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen) [00:29:59] (03CR) 10Ejegg: [C: 03+2] Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835717 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen) [00:30:54] hmm shall I verify it - otherwise it's a big wait [00:31:04] sure, might as well [00:31:26] (03CR) 10Eileen: [V: 03+2] Update triggers [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835717 (https://phabricator.wikimedia.org/T316713) (owner: 10Eileen) [00:32:48] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/835719 [00:33:01] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/835719 (owner: 10Eileen) [00:34:50] !log civicrm upgraded from 118c1d0b to 916a8b08 [00:34:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:35:12] dwisehaupt: the triggers are there now -wmf_civicrm/scripts/triggers.mysql [00:35:33] coolthx [00:35:49] (03PS2) 10Ejegg: Monolog update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835709 (https://phabricator.wikimedia.org/T318304) (owner: 10Eileen) [00:35:56] (03CR) 10Ejegg: [C: 03+2] Monolog update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835709 (https://phabricator.wikimedia.org/T318304) (owner: 10Eileen) [00:37:42] (03PS2) 10Ejegg: Civix upgrade on matching_gifts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835710 (https://phabricator.wikimedia.org/T318304) (owner: 10Eileen) [00:37:49] (03CR) 10Ejegg: [C: 03+2] Civix upgrade on matching_gifts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835710 (https://phabricator.wikimedia.org/T318304) (owner: 10Eileen) [00:38:18] PROBLEM - check_redis on frqueue1003 is CRITICAL: CRITICAL: pending is 2152 2000 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 6 hours 33 minutes - memory use is 8.23M (peak 8.55M, 0.15% of max, fragmentation 1.53%), connected_slaves is 3, donations is 95, jobs is 0, jobs-adyen is 105, jobs-paypal is 45, payments-antifraud is 3873, payments-init is 908, recurring is 0, refund is 0, unsubscribe is 0 https://icing [00:38:18] ia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [00:39:49] ok. updates are complete and diff looks good [00:40:42] ACKNOWLEDGEMENT - check_redis on frqueue1003 is CRITICAL: CRITICAL: pending is 2152 2000 - REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 10 keys, up 6 hours 33 minutes - memory use is 8.23M (peak 8.55M, 0.15% of max, fragmentation 1.53%), connected_slaves is 3, donations is 95, jobs is 0, jobs-adyen is 105, jobs-paypal is 45, payments-antifraud is 3873, payments-init is 908, recurring is 0, refund is 0, unsubscribe is 0 Dwise [00:40:42] i upgrade https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1003&service=check_redis [00:40:58] eileen: you should be all set to test what you need. [00:41:12] would you like for me to move civi out of maint mode and keep the queues off? [00:42:21] dwisehaupt: yes please [00:43:50] ok. civi is out of maint mode and queues are still off [00:44:10] yay thanks [00:44:28] ejegg: there is a github mirror of our crm repo isnt there? [00:45:25] oh i think so [00:46:14] https://github.com/wikimedia/wikimedia-fundraising-crm/ [00:46:56] eileen: shoot, I haven't been verifying all of the functionality of the extensions that just have the basic civix updates [00:47:10] ejegg: nah - I think that's ok [00:47:25] I just wanted this view - https://github.com/wikimedia/wikimedia-fundraising-crm/tree/master/drupal/sites/default/civicrm/extensions to check which haven't had it [00:47:40] site loads, gonna try a slow -start [00:47:45] but I just tried the acoustic data link after the omnimail update and am getting 'Unknown path' [00:47:53] oh dang [00:47:57] (locally, not yet C+2 ed) [00:48:07] oh well I'll check that out once civi is up [00:48:17] so I saw that it's replacing the angular fn with a mixin [00:49:52] yeah - it erm... should work.... [00:50:11] dwisehaupt: donation processed - let's start-er-up [00:50:18] ok. [00:50:47] eileen: should we try a single recurring charge first? [00:51:36] urm. i was too fast. :( :) [00:51:55] i can turn the queues back off if you want. [00:52:08] nah, let's see how it goes :) [00:52:15] lol I was gonna say that [00:53:17] I just ran one with a slow-start and it worked fine [00:54:45] (03Merged) 10jenkins-bot: Monolog update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835709 (https://phabricator.wikimedia.org/T318304) (owner: 10Eileen) [00:54:48] (03Merged) 10jenkins-bot: Civix upgrade on matching_gifts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835710 (https://phabricator.wikimedia.org/T318304) (owner: 10Eileen) [00:57:48] (03PS1) 10Eileen: Remove angular profiles [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835721 (https://phabricator.wikimedia.org/T318304) [00:59:10] ok - anything left other than emailing users ? https://collab.wikimedia.org/wiki/Checklists_for_maintenance_%26_Recovery [01:00:19] eileen so for the full db update to silverpop, is that just a deploy with that days parameter set to like 10000 ? [01:01:20] ejegg: basically it is delete the export view & then re-create it without the modifed_date filter & we will get the full file export - but it we want to rebuild the whole db then it might be a bit more [01:01:58] I guess we could do the days param set super high though [01:02:02] would it work just to deploy with the crazy-long days parameters? [01:02:33] we could try it :-) [01:02:52] min(modified_date) is 2006-12-14 [01:03:18] RECOVERY - check_redis on frqueue1003 is OK: OK: REDIS 5.0.14 on 127.0.0.1:6379 has 1 databases (db0) with 8 keys, up 6 hours 58 minutes - memory use is 2.05M (peak 10.80M, 0.08% of max, fragmentation 3.19%), connected_slaves is 3, donations is 1, jobs is 0, jobs-adyen is 0, jobs-paypal is 1, payments-antifraud is 18, payments-init is 8, pending is 4, recurring is 0, refund is 0, unsubscribe is 0 https://icinga.wikimedia.org/cgi-bin/icin [01:03:18] o.cgi?type=2&host=frqueue1003&service=check_redis [01:03:49] 6400 days ought to be plenty [01:03:55] cool - let's try it [01:04:10] i'll do 10000 just in case my math is off :) [01:05:35] i need to head out to collect $kid. i'll check in when i'm back but we should be good on the system side. [01:06:20] (03PS1) 10Ejegg: Change days param for full export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/835724 [01:06:25] thanks dwisehaupt [01:07:58] (03CR) 10Eileen: [C: 03+2] "let's try it" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/835724 (owner: 10Ejegg) [01:09:58] (03Merged) 10jenkins-bot: Change days param for full export [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/835724 (owner: 10Ejegg) [01:14:05] (03PS1) 10Ejegg: Move offset_in_days to config [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/835725 [01:14:21] might be as simple as ^^^ to make it actually configurable [01:14:41] tho i haven't smoketested [01:14:57] anyway, i'll deploy that 10k change [01:15:19] ok cool - are you gonna start it running early or let it normal run? [01:15:32] (03CR) 10CI reject: [V: 04-1] Move offset_in_days to config [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/835725 (owner: 10Ejegg) [01:15:34] maybe best to start it early? [01:15:38] (hopefully my laptop guy will be here soon so will be offline when he is) [01:15:45] re early - sure [01:15:55] it will take hours [01:16:19] (03PS1) 10Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/835726 [01:16:21] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/835726 (owner: 10Ejegg) [01:17:28] (03Merged) 10jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/835726 (owner: 10Ejegg) [01:18:49] !log updated fundraising python tools from b65109af to dd494413 [01:18:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:20:02] ok, running the full process under 'screen' [01:20:32] i'mma head afk and just watch for any failmail. [01:20:38] eileen: ^^ [01:20:52] ejegg: cool [01:22:43] (03PS2) 10Ejegg: Move offset_in_days to config [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/835725 [01:26:53] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Email: Make Silverpop export leaner - https://phabricator.wikimedia.org/T173538 (10Ejegg) 05Open→03Resolved [01:27:08] eileen: we don't have a phab for moving that var to config, do we? [01:27:47] that patch seems to work in tests - i just need to install some more python stuffs to actually smoke test locally [01:35:39] cool - yeah maybe create a phab as a sub-task? [01:40:06] 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, 10FR-Email: Move Silverpop/Acoustic export day limit to config - https://phabricator.wikimedia.org/T318767 (10Ejegg) [01:40:25] (03PS3) 10Ejegg: Move offset_in_days to config [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/835725 (https://phabricator.wikimedia.org/T318767) [01:42:09] ok, so contactlayout is also using ang-php mixin now [01:42:36] and that's on prod [01:42:40] let's see if that's working [01:43:36] seems to be, but that editor isn't on an angular # url [01:51:32] (03CR) 10Ejegg: [C: 04-1] "Almost there!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834599 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [01:55:12] PROBLEM - check_mysql on frdb1005 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1005&service=check_mysql [01:57:38] AndyRussG: you really feel adamant about discarding anything POSTed to the landing page? [01:58:10] ejegg: hmm do you feel adamant about not doing so? [01:58:19] It seems like a nice rationalization, but I'm afraid of uncovering more oddities in the pipeline right now [01:58:27] ok [01:58:42] if we hear from pcoombe on it, i'd consider that enough to C+2 [01:58:54] if not, can we put a fixme in all the places where we do take into account POSTed stuff? [01:59:06] what I guess I feel adamant about is the principle of lean interfaces [01:59:13] or whatever you would call it [01:59:22] also what do you feel about trying to restore the server-side geoip lookup? [01:59:34] ah that sounds better still yeah [02:00:12] PROBLEM - check_mysql on frdb1005 is CRITICAL: Slave IO: No Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1005&service=check_mysql [02:00:17] ^ wrt the principle, it's also normal if there are cases when you have to keep an interface broad because you don't know what's out there, but at least in that case I'd like it flagged as a problem [02:00:27] I dug into the main config repo and it looks like the geoip databases should be there in production under /usr/share/GeoIPInfo/ [02:00:39] hmm oki [02:00:56] what is needed to make it work, test it, and put it out there? is there a Phab? [02:01:43] there's code in DonationInterface that uses geoip2: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/gateway_common/CountryValidation.php$92 [02:02:08] so we should be able to test it using the geolite free database [02:02:17] sorry about that frdb1005 alert. forgot to restart replication. all set now. [02:02:18] AndyRussG: I think it would be the same phab task, no? [02:02:39] sure [02:02:43] just an alternate fix [02:03:32] ok. that's all caught up. off to dinner. have a good one. [02:03:37] dwisehaupt: cya! [02:04:06] ahh, that code has a wart... } catch ( Exception $e ) { [02:04:06] // Suppressing missing database exception thrown in CI [02:04:07] } [02:04:15] ah heheh oops [02:04:38] well maybe if it's on the main cluster now it's also CI-able [02:04:42] It's using a setting for the path, I wonder if there's a super-sparse test db [02:04:49] that we could actually check in to the code [02:05:12] RECOVERY - check_mysql on frdb1005 is OK: Uptime: 629436 Threads: 5 Questions: 100337880 Slow queries: 308 Opens: 2592 Open tables: 1052 Queries per second avg: 159.409 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1005&service=check_mysql [02:05:18] the geolite db is free to download but not check-in-able, and still pretty big for a test [02:05:54] hmmm [02:05:55] oh man, how did it get so late? [02:06:03] hehe one hour at a time [02:06:04] i have to get up early, going to call it a night [02:06:11] and also one minute at a time [02:06:15] (03PS8) 10Wfan: Add payment_methods to pending table for fetchMessageByGatewayOldest to filter it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834599 (https://phabricator.wikimedia.org/T316587) [02:06:15] and one second at a time [02:06:17] etc [02:06:31] ejegg: thanks much!!! que descanses :) [02:06:39] (03CR) 10CI reject: [V: 04-1] Add payment_methods to pending table for fetchMessageByGatewayOldest to filter it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834599 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [02:07:29] (03PS9) 10Wfan: Add payment_methods to pending table for fetchMessageByGatewayOldest to filter it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834599 (https://phabricator.wikimedia.org/T316587) [02:09:41] oh look, test databases: https://github.com/maxmind/MaxMind-DB/tree/main/test-data [02:10:08] noice! [02:10:19] I wonder if there's a composer way to pull them down [02:10:37] or some other way that wouldn't involve having to mess with CI config [02:10:53] hmm, is that already somewhere in vendor? that maxmind-db might be a dependency of geoip2 [02:12:33] nah, we have maxmind-db/reader, but that's a different repo: https://github.com/maxmind/MaxMind-DB-Reader-php [02:14:20] hmmm [02:14:28] https://github.com/maxmind/MaxMind-DB/blob/main/LICENSE looks like CC Attribution-ShareAlike [02:14:41] so we can just copy one of those to our test data folder [02:14:50] as long as we retain some notice [02:14:57] couldn't we just mock it? [02:15:16] or is this some standard core integration test of special pages that has to run? [02:15:49] probably we can mock it, all depends how we want to provide that Reader to the special pages [02:15:59] oki [02:16:15] IIRC the mediawiki framework will always be the one to construct special pages [02:16:41] we could have some fun with service wiring [02:16:43] yes there's some test that runs through all the special pages and tries to check that they don't die [02:17:08] k, really |away now. gnight! [02:17:17] hasta luego :) [02:50:18] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1210 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_mysql [02:55:18] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1510 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_mysql [03:00:18] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1810 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_mysql [03:02:32] howdy, just wanted to double check that the silverpop job running is the big catchup one. [03:02:55] if so i'll ack the icinga alert [03:05:18] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2110 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_mysql [03:06:46] ACKNOWLEDGEMENT - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2110 Dwisehaupt large silverpop export running. https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_mysql [03:08:20] 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices: Decimal separator in Thank you email confirmation fr-FR, es-ES-, it-IT, nl-NL since end of August 2022 - https://phabricator.wikimedia.org/T318327 (10TomaszGorski) Sorry, correction: the current display... [03:14:25] 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices: Decimal separator in Thank you email confirmation fr-FR, es-ES-, it-IT, nl-NL since end of August 2022 - https://phabricator.wikimedia.org/T318327 (10Eileenmcnaughton) @TomaszGorski - can you keep an eye... [03:19:35] 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices: Decimal separator in Thank you email confirmation fr-FR, es-ES-, it-IT, nl-NL since end of August 2022 - https://phabricator.wikimedia.org/T318327 (10TomaszGorski) Will do so, thank you! [03:20:18] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 1907917 Threads: 14 Questions: 267543259 Slow queries: 1947099 Opens: 758483472 Flush tables: 1 Open tables: 448 Queries per second avg: 140.227 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 535 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_mysql [05:17:15] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/835782 (owner: 10L10n-bot) [05:45:15] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Quarkery, 10Fundraising-Backlog, 10Epic: [epic] Adyen - auto settle stopped prior donors (Pending transaction Resolver) - https://phabricator.wikimedia.org/T299692 (10AndyRussG) [06:11:43] 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices: Decimal separator in Thank you email confirmation fr-FR, es-ES-, it-IT, nl-NL since end of August 2022 - https://phabricator.wikimedia.org/T318327 (10TomaszGorski) Hi y'all, I've just seen on Civi two do... [12:17:42] hey damilare I just pinged you on slack. my desktop irc isnt connecting atm [12:17:58] ohh ok [12:25:54] 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog: Add payment submethod to Civi for ApplePay and GooglePay - https://phabricator.wikimedia.org/T318362 (10Damilare) a:03Damilare [13:14:23] damilare: that ticket also looks potentially related https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/775349/3 [13:16:30] ohh I'm not sure since this is for audit and shortened method display (no submethod), that's probably more related to imports [13:19:54] that'll get run during the audit processing [13:20:34] I guess it depends on what payment_method is [13:21:12] ah I see, it'll likely stay 'apple' even after you break them out [13:21:15] fingers crossed [13:21:47] yh I'd do some log diving in that area too [13:22:06] sorry I mean debug* diving [13:37:48] 10Fundraising Tech - Chaos Crew: Intermittent Apple Pay timeouts when testing locally - https://phabricator.wikimedia.org/T318808 (10jgleeson) [13:38:59] 10Fundraising Tech - Chaos Crew: Intermittent Apple Pay timeouts when testing locally - https://phabricator.wikimedia.org/T318808 (10jgleeson) [13:58:34] 10Fundraising-Backlog, 10fr-donorservices: Civi process when generating/adding the donor name - https://phabricator.wikimedia.org/T318812 (10SHust) [14:24:10] 10Fundraising-Backlog, 10fr-donorservices: Civi process when generating/adding the donor name - https://phabricator.wikimedia.org/T318812 (10krobinson) For context - this donor has two CIDs tied to the same email address, CID 6115350 (correct first name, mirrored in greeting) and CID 51559392 (typo in first na... [14:31:58] (03PS1) 10Damilare Adedoyin: WIP: Add payment submethod to Civi for ApplePay and GooglePay [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836225 (https://phabricator.wikimedia.org/T318362) [14:36:16] (03PS1) 10Ejegg: WIP card type suffixes for other methods [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836229 [14:37:00] damilare: what do you think about putting the submethod mapping for cc, google, and apple all in the same separate method? ^^^ [14:37:18] I had that WIP sitting around locally and it looked like it might be relevant to the work you're doing now [14:39:20] ok checking ejegg [14:40:35] that makes sense, I'd do that [14:41:07] cool! Feel free to just copy the method from that patch into your own, since that patch doesn't have the other parts that are needed [14:41:29] sure [15:00:00] a switch in a switch [15:00:04] my eyes [15:02:15] want to go all the way to mapping in the database? [15:02:22] should be performant if we cache well [15:04:04] should be easier to follow also being in its own method [15:04:43] heh, we could also break out the mapping into its own class a la the ReferenceData classes in SmashPig [15:04:53] love that idea [15:04:55] and that class could live in the new Civi extension [15:06:58] dami - do you want to try that? [15:09:40] (03PS2) 10Damilare Adedoyin: WIP: Add payment submethod to Civi for ApplePay and GooglePay [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836225 (https://phabricator.wikimedia.org/T318362) [15:12:01] sorry just seeing the thread, was thinking about using a yaml file like in DI but I haven't seen any of such. I like the Class in civi extension (like referenceData in smashpig) idea [15:12:39] any of such in Civi* i mean [15:13:43] PHP now has Enums [15:14:00] damilare: moving the mapping to settings also sounds like a good idea. In Civi I think it might be a bad idea to introduce settings in yaml files - if we're going to add a setting I would do it as a Civi native setting. Those can be set in the db or in PHP files [15:15:29] the db settings sound easier to maintain [15:15:47] hmm [15:16:09] do we maintain other app options lists in settings files? [15:16:17] please where can I find an example of civi native setting? [15:16:36] oh you mean the drupal settings copy thing [15:17:25] i think civicrm calls it config [15:17:58] ohh is it this: dev/src/civi-sites/wmff/drupal/sites/all/modules/civicrm/settings/Address.setting.php? [15:18:04] oh no that's something else, it is civirm_settings [15:18:20] damilare: https://docs.civicrm.org/dev/en/latest/framework/setting/ [15:18:35] this is the same as the drupal vars stuff [15:19:41] and reading them in from file is https://docs.civicrm.org/dev/en/latest/framework/setting/#settings-definition [15:23:00] damilare: ejegg i feel like the docs are discouraging the use of the settings for this use case https://docs.civicrm.org/dev/en/latest/framework/setting/#what-is-a-setting [15:25:01] feels like a rule of thumb is that a 'setting' is something essential that is needed for the app to run correctly [15:25:22] This: "For example: if you want to have a custom set of allowable values for your extension, you'll want to use the 'Option Group' system." [15:25:25] ok, so maybe let's just leave the switch statements for now? [15:25:35] ^^ is pretty much what we are doing with the update script [15:25:40] Not all configuration-type values need to use this system - in particular, if you need to store persistent data that changes frequently and/or may grow indefinitely in size, this may not be the right tool. For example: if you want to have a custom set of allowable values for your extension, you'll want to use the 'Option Group' system. [15:25:40] and just put them in a separate class to improve the code organization [15:26:09] 10Fundraising-Backlog, 10fr-donorservices: Unsubscribe button no longer on Civi main menu bar - https://phabricator.wikimedia.org/T318830 (10SHust) [15:26:17] hiiii fr-tech damilare jgleeson ejegg ... howsie goesies? [15:26:17] How about sticking with the option group but just storing that list in an Enum style class [15:26:23] tthe switch statement is useful for fetching the payment_instrument_id [15:26:29] jgleeson: yeah, so there are already option values involved here - those are the payment_instruments that we are mapping to [15:26:30] actually we can't use Enums as we're not on php 8 [15:27:08] ejegg: also btw do u have a quick link on hand for that geoip db usage on main prod cluster? (sorry to interrupt, no worries if not) [15:27:27] AndyRussG: it's in the IPInfo extension [15:27:27] hey AndyRussG [15:27:29] lemme see [15:27:33] yhh moving the switch to a new class seems like the way forward [15:27:38] hi AndyRussG [15:27:53] AndyRussG: I just searched for geoip2 in phabricator to see what was happening with it [15:28:27] :) :) :) [15:28:31] thx ejegg [15:33:10] damilare: ejegg this would be perfect https://www.php.net/manual/en/language.enumerations.listing.php [15:33:39] and https://www.php.net/manual/en/language.enumerations.static-methods.php [15:34:59] 10Fundraising-Backlog, 10fr-donorservices: Unsubscribe button no longer on Civi main menu bar - https://phabricator.wikimedia.org/T318830 (10krobinson) @Eileenmcnaughton [15:36:37] do we currently have support for php8 ? [15:37:11] no :( [15:37:39] it'd have been a lot tidier [15:44:04] 10Fundraising Tech - Chaos Crew: Failmail not working on payments-wiki local - https://phabricator.wikimedia.org/T318831 (10jgleeson) [15:49:26] 10Fundraising-Backlog, 10fr-donorservices: Broken Deduper Clause Field - https://phabricator.wikimedia.org/T318833 (10SHust) [15:50:49] 10Fundraising-Backlog, 10fr-donorservices: Broken Deduper Clause Field - https://phabricator.wikimedia.org/T318833 (10SHust) p:05Triage→03Unbreak! [16:01:10] oof, that Broken Deduper Clause UBN seems to be deep in the angular code [16:01:21] TypeError: deferreds is null [16:06:45] ejegg, you around for standup? [16:06:46] ejegg: hiiiiii [16:23:13] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog: Custom field "AF_has_active_recurring_donation" is showing false positives - https://phabricator.wikimedia.org/T315102 (10KHaggar... [16:28:21] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: prevent the get property from non-object error - https://phabricator.wikimedia.org/T318837 (10AnnWF) [16:28:42] ahh wfan, I had a type in that first part. I'll fix it [16:32:06] (03PS4) 10Ejegg: Opt-out users missed due to GatewayChooser bug [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/834413 (https://phabricator.wikimedia.org/T311974) [16:32:59] (03CR) 10Ejegg: "Thanks for catching that wfan! The join from the custom field to the contribution was wrong, but I've fixed it in PS4." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/834413 (https://phabricator.wikimedia.org/T311974) (owner: 10Ejegg) [16:43:53] 10Fundraising-Backlog, 10fr-donorservices: Civi process when generating/adding the donor name - https://phabricator.wikimedia.org/T318812 (10KHaggard) Hi @krobinson - So I looked into the cids and the email address. Confirming that Acoustic sent the Sep 22nd email to CID 51559392 only. The other CID hasn't bee... [16:51:10] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Aldrick Beckford - https://phabricator.wikimedia.org/T318840 (10SHust) [16:58:22] (03PS1) 10Ejegg: Fix for deduper angular error [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836260 (https://phabricator.wikimedia.org/T318833) [16:58:39] fr-tech: ^^^ seems to fix that unbreak-now bug on my machine [16:59:10] as mentioned in the commit message I don't completely understand why it started breaking, but that fix is pretty conservative [16:59:59] heh, I guess i mean I don't completely understand how it wasn't breaking before [17:01:10] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: prevent the get property from non-object error - https://phabricator.wikimedia.org/T318837 (10Ejegg) Is that from a process-control scheduled job log @AnnWF ? [17:09:04] Heh, one of those "How did this ever work?" kind of bugs, eh? [17:27:28] oh we need to put the smashpig db creds in the fr-dev wmff civi-sites configuration, so we can look at the 'damaged' table UI [17:41:29] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: prevent the get property from non-object error - https://phabricator.wikimedia.org/T318837 (10AnnWF) yes from fetch_civimail_bounces >>! In T318837#8269672, @Ejegg wrote: > Is that from a process-control scheduled job log @AnnWF ? [18:29:56] 10Fundraising-Backlog, 10fr-donorservices: Adyen: add email address for subsequent recurring donations - https://phabricator.wikimedia.org/T318851 (10MBeat33) [18:41:23] (03CR) 10Jsn.sherman: [C: 03+1] Add description for Special:Preferences layout [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/835663 (https://phabricator.wikimedia.org/T311717) (owner: 10Scardenasmolinar) [18:45:42] 10Fundraising-Backlog, 10fundraising-tech-ops: Need new SSL cert & access for new laptop - https://phabricator.wikimedia.org/T316361 (10Dwisehaupt) 05Open→03Resolved Verified in logs that the certificate is working. [18:47:56] 10fundraising-tech-ops: Fundraising access request for dbu - https://phabricator.wikimedia.org/T314827 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt [18:51:22] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Aldrick Beckford - https://phabricator.wikimedia.org/T318840 (10Dwisehaupt) [18:53:53] (03PS2) 10Ejegg: Fix for deduper angular error [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836260 (https://phabricator.wikimedia.org/T318833) [19:07:57] (03CR) 10Jgleeson: [C: 03+2] "LGTM! tested on tech-talk and fixes the issue. thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836260 (https://phabricator.wikimedia.org/T318833) (owner: 10Ejegg) [19:13:09] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/836271 [19:13:13] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/836271 (owner: 10Ejegg) [19:13:16] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Aldrick Beckford - https://phabricator.wikimedia.org/T318840 (10Dwisehaupt) SSL client cert created and sent via email. Password sent via SMS. Civi account created and set with random password. Superset account already created. Added... [19:13:44] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Aldrick Beckford - https://phabricator.wikimedia.org/T318840 (10Dwisehaupt) [19:20:39] (03Merged) 10jenkins-bot: Fix for deduper angular error [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836260 (https://phabricator.wikimedia.org/T318833) (owner: 10Ejegg) [19:24:10] !log updated fundraising CiviCRM from 916a8b08 to d31c19a0 [19:24:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:25:11] looks like that worked! [19:26:51] 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Broken Deduper Clause Field - https://phabricator.wikimedia.org/T318833 (10Ejegg) Hi @SHust, we just deployed a change that should fix the problem. Let me know if you still see issues after reloading the page. [19:27:06] nice [19:27:29] ejegg: is there any major reason we can't rename the astropay files to dlocal? [19:27:35] before I write the ticket [19:28:23] jgleeson: heh, at some point I heard they had another rename coming [19:28:30] but it's been a while and still dlocal [19:29:24] 10Fundraising Tech - Chaos Crew: dLocal Insecure Form warnings - https://phabricator.wikimedia.org/T318742 (10jgleeson) [19:29:33] 10Fundraising Tech - Chaos Crew: dLocal Safari internal errors on redirect - https://phabricator.wikimedia.org/T318744 (10jgleeson) [19:30:39] 10Fundraising-Backlog: Rename Astropay files to dLocal - https://phabricator.wikimedia.org/T318857 (10jgleeson) [19:31:05] i guess we need to make a ticket for switching ingenico to worldline [19:31:53] actually there's still a lot of ingenico naming on the worldline site [19:32:42] Ingenico, a Worldline brand [19:32:52] yep, looks like it's still gonna stick around [19:38:05] we should start naming processors by random md5 sums since it's more accurate with all their name swaps. :) [19:38:49] :) [19:39:18] code names [19:39:29] Ingenico, something like Old Guard [19:39:34] Adyen, New Kid [19:39:45] Paypal, ***** [19:40:04] nsfw [19:40:33] have a naming session like sprint names when a new processor or integration comes along. [19:40:48] oh wow, dlocal went public last year and has DLO on nasdaq [19:40:58] ya i saw that ejegg [19:41:01] maybe that name will stick around too [19:41:07] worth billions right? [19:41:26] oh. i should eat lunch. [19:41:54] yah, looks like it peaked at almost $10B but is back down to 6.5B now [19:42:23] buy the dip! [19:42:27] ha [19:42:38] maybe the investors haven't used the sandbox environment yet [19:43:03] so yeah, I'd +2 a rename [19:44:31] heh, duolingo is public too ?? [19:44:53] ejegg: I've finally completed the payment tests across the new and old payments-wiki images, https://phabricator.wikimedia.org/T317701#8261569, so gonna move on to trying out the geoip stuff. am i right in thinking this hasn't been tested out yet since we switched things over to docker? [19:44:55] guess that explains why the free plan keeps getting more annoying to use [19:45:14] jgleeson: right, it hasn't been tested and we don't have the dbs installed on the docker images [19:45:25] we would have to download them from https://dev.maxmind.com/geoip/geoip2/geolite2/ [19:45:34] argh [19:45:39] ok thanks [19:45:46] I'll dig in tomorrow [19:45:58] lemme paste that URL on the ticket [19:46:27] jgleeson: but since it's all the composer-installed lib rather than the OS-installed php-geoip package, I'm not sure that's totally necessary [19:47:08] oh huh [19:47:25] so there's no actual reliance on anything that's changed between OSes? [19:47:39] not for GeoIP, no [19:47:59] hallelujah [19:48:11] so I can wrap this thing up? [19:48:18] I think so! [19:48:24] phew [19:48:34] sorry in advance for whoever reviews this one [19:48:51] On the ops side, we want to make sure they d/l the databases same as they did on the previous OS, but that's not something we'd deal with [19:48:57] especially the Apple Pay stuff! [19:49:11] heh, I just made sure my mac was up to date [19:49:25] had to re-verify the test domains a couple days ago [19:49:38] ah nice [19:51:03] ejegg: yeah, the dbs should be downloaded just fine. i can triple check just in case. [19:51:22] cool cool dwisehaupt . To the same path and everything? [19:52:21] 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog: Exhaustively test bullseye upgrade in fundraising-dev - https://phabricator.wikimedia.org/T317701 (10jgleeson) It looks like we don't have to compare GeoIP behaviour after all across buster and bullseye as we're n... [19:53:39] ok [19:53:53] so it looks like most things in the backlog are specific to eileen [19:55:57] I can see a few things in review so i can sniff around those first thing tomorrow but beyond that I think the next in order of priority will be the paypal stuff ejegg [19:56:11] thanks jgleeson, sounds good [19:56:23] I'll keep filling out those subtasks [19:57:04] ah I hadn't seen them [19:57:08] I see them now on https://phabricator.wikimedia.org/T317245 [19:57:27] just two so far, I'll make the rest today [19:57:30] I didn't see any linked from the ticket in sprint, sorry that was a misplaced nudge :) [19:57:52] I'll pick one up and pull it in, thanks [19:58:00] any suggestions on the best one to start with? [20:07:29] jgleeson: let [20:07:42] 's see, maybe the DoExpressCheckoutPayment ? [20:08:06] although the first sequentially in the PTR will be the lookup, whatever that's called [20:08:23] might be the simplest too [20:08:42] lemme make that ticket next [20:13:56] ejegg: i think so, but let me triple check before agreeing. :) [20:16:06] cool. will check 'em out tomorrow [20:16:08] thanks [20:16:37] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, and 4 others: Creating New Matching Gift Import - https://phabricator.wikimedia.org/T303986 (10MDemosWMF) We just sat down with Ellen for a walkthrough in he... [20:20:23] yeah, we are pulling down the geolite2 dbs to /usr/share/GeoIP on both the buster and bullseye payments hosts. [20:23:28] greg-g: ejegg XenoRyet - Tim is still dealing with the personal situation from last week - I just checked in with him & I think we need to punt the meeting again - next week I'll see him in person & so will Jack & Dami [20:24:38] :) [20:25:28] eileen: alright, I'll move the meeting, thanks for the heads up [20:26:44] greg-g: yeah same time next week will be tricky due to dev training - but I'll push him to put some stuff in writing cos my take is the next step on deadlocks is something in writing for us & then we can start on the next topic [20:30:02] oh right, I just blindly put it for next week [20:30:23] eileen: should I make the meeting for the following week or? [20:31:06] hmm - well i don't think it will the following week - but maybe having it there will make sure we reschedule it closer to the time ? [20:31:22] 10-4 [20:33:03] hi eileen , that sounds fine to me. Hope Tim is OK [20:33:21] yeah he has a tricky personal situation to deal with [20:34:31] but no one is sick / dying - not that sort of thing [20:34:37] ok, that's good. [20:34:57] eileen: we found a potentially unused JS file in deduper [20:35:12] ejegg: yeah I saw - well found [20:35:23] it was referring to a non-existant template, and removing that line fixed the bug [20:35:30] also - the fact is was unbreak now shows they do use it all the time :-) [20:36:25] but it looks like the whole UI works with that whole crmSearchSelector.js file deleted [20:36:49] I think you ended up implementing the criteria dropdowns in dedupefindCntrl [20:37:40] the potentially unused one says at the top "This has been shamelessly copied & butchered from api v4 explorer" [20:38:04] so maybe you were starting from there and then realized you didn't need all the stuff that the api explorer field picker does? [20:38:34] ejegg: I think that sounds like it is exactly what happened [20:38:48] :) cool, let's zap that file then [20:38:52] I would kinda like to make it so you can find contacts in search kit for that [20:39:08] oh - I thought you'd zapped it - does it still need review? [20:40:54] eileen: the fix I deployed just deleted the one line referring to a non-existent template [20:41:10] I'll put up another patch removing the js file entirely [20:41:14] ok cool [20:43:17] (03PS1) 10Ejegg: Delete unused JS file from deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836291 [20:44:47] g'night fr-tech o/ [20:49:11] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Implement PayPal EC GetExpressCheckoutDetails in SmashPig - https://phabricator.wikimedia.org/T318867 (10Ejegg) [20:49:24] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Implement PayPal EC GetExpressCheckoutDetails in SmashPig - https://phabricator.wikimedia.org/T318867 (10Ejegg) [20:49:26] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig, 10Epic: Move PayPal EC API calls to SmashPig - https://phabricator.wikimedia.org/T317245 (10Ejegg) [20:50:55] ejegg: do you know if the export succeeded [20:56:45] oh right, I was going to check on that eileen [20:58:20] eileen: looks like it did! [20:59:00] whew, is that an 8GB file? [20:59:41] musta been some network upgrades since the last time we were doing full uploads every night [20:59:58] 27.3M records [21:00:32] whoa that's a lot [21:06:18] I guess we move the ticket to done & ping Katie to check it all looks good [21:09:36] eileen: is there anything else you had planned for maint week that would impact civi? just pondering sending the 'all done' email. [21:15:07] 10Fundraising-Backlog, 10fr-donorservices: Broken Deduper Clause Field - https://phabricator.wikimedia.org/T318833 (10SHust) @Ejegg the "add clause” field still isn’t working for my admin team (CIDs 56582127, 50731216, and 31779349 / 498), however, it is working for me! [21:21:50] (03CR) 10Wfan: [C: 03+2] "LGTM. Will have 884 row update and 14,368 insert" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/834413 (https://phabricator.wikimedia.org/T311974) (owner: 10Ejegg) [21:22:32] dwisehaupt: nope - that's it [21:22:48] coolthx [21:28:28] 10Fundraising-Backlog, 10fr-donorservices: Broken Deduper Clause Field - https://phabricator.wikimedia.org/T318833 (10Ejegg) @SHust they might need to do a 'hard refresh' of the page to get the fixed JavaScript. The button for that depending on OS and browser . Ctrl-F5 does it for a lot of them. See this graph... [21:33:50] thanks wfan [21:34:54] (03Merged) 10jenkins-bot: Opt-out users missed due to GatewayChooser bug [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/834413 (https://phabricator.wikimedia.org/T311974) (owner: 10Ejegg) [21:35:00] np >~< very straightforward [21:35:47] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/836298 [21:35:49] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/836298 (owner: 10Ejegg) [21:38:24] ejegg: did you try again on the omnimail one - it ... mostly... worked for me [21:41:28] not yet eileen [21:41:38] will do that after I finish reviewing wfan's patch [21:41:55] cool - I'm just trying to figure out why one a recur isn't cancelled [21:43:33] wfan I can't seem to get your 007_ script to work locally - were you able to run it with that 'IF NOT EXISTS ' bit around it? [21:44:10] I was able to do it like this: [21:44:11] ALTER TABLE pending ADD COLUMN IF NOT EXISTS payment_method varchar(16) DEFAULT NULL; [21:45:49] could I also do this one for sqlite? [21:46:03] no, sqlite doesn't support ADD COLUMN IF NOT EXISTS [21:48:00] ok, will update the if not exist to the one you have, thanks~ [21:49:37] oh hey, payments-init queue consumer is logging all the messages twice [21:49:42] (03PS10) 10Wfan: Add payment_methods to pending table for fetchMessageByGatewayOldest to filter it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834599 (https://phabricator.wikimedia.org/T316587) [21:49:58] wait, is the CT queue consumer doing that too? [21:50:51] oops, yep [21:50:53] lemme fix that [21:59:30] (03PS1) 10Ejegg: Quit double-logging message in a couple QCs [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836302 (https://phabricator.wikimedia.org/T307929) [21:59:37] ah, there was indeed a phab for it [22:08:38] 10Fundraising-Backlog, 10fr-donorservices: Unsubscribe button no longer on Civi main menu bar - https://phabricator.wikimedia.org/T318830 (10Eileenmcnaughton) @krobinson @shust it has been moved under the Contacts menu - but we can put it back so it is in both? The only downside is that all people get it at th... [22:11:49] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices: Adyen iframe config error messages inside card fields - https://phabricator.wikimedia.org/T292571 (10AnnWF) a:03AnnWF [22:19:27] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog: Custom field "AF_has_active_recurring_donation" is showing false positives - https://phabricator.wikimedia.org/T315102 (10Eileenm... [22:20:39] !log updated fundraising CiviCRM from d31c19a0 to f3461a44 [22:20:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:21:34] oh darn, Duplicate entry '7222229' for key 'unique_entity_id' when I tried to run that opt_in update [22:21:58] I need to add a group by [22:22:20] wfan I'll have another version of that up in a sec [22:22:50] ha, ok [22:24:30] ok, the first part completed fine, I'll add a new update just with a fixed version of the insert [22:27:01] (03PS1) 10Ejegg: Corrected version of opt-in fix second step [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836305 (https://phabricator.wikimedia.org/T311974) [22:27:51] (03PS11) 10Ejegg: Add payment_methods to pending table for fetchMessageByGatewayOldest to filter it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834599 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [22:28:01] (03CR) 10Ejegg: [C: 03+2] "Thanks, this looks great" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834599 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [22:28:42] Thanks elliott :) [22:28:53] (03Merged) 10jenkins-bot: Add payment_methods to pending table for fetchMessageByGatewayOldest to filter it [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834599 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [22:30:14] :) [22:30:50] I'll be back in an hour or so [22:48:33] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog: Custom field "AF_has_active_recurring_donation" is showing false positives - https://phabricator.wikimedia.org/T315102 (10KHaggar... [22:50:50] 10Fundraising-Backlog, 10fr-donorservices: Broken Deduper Clause Field - https://phabricator.wikimedia.org/T318833 (10SHust) @Ejegg Thanks for the link, I ended up sharing a different link that appears to have worked for the only admin available at this time so I'm sure the others will be able to do the same t... [23:29:13] 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices: Decimal separator in Thank you email confirmation fr-FR, es-ES-, it-IT, nl-NL since end of August 2022 - https://phabricator.wikimedia.org/T318327 (10Eileenmcnaughton) Oh yay - thanks for confirming