[00:05:20] (03PS1) 10Eileen: Fix CancelInactives to set status [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836315 (https://phabricator.wikimedia.org/T315102) [00:06:23] ejegg|afk: I found the cancel status wasn't being updated from your new script ^^ fixes [00:10:32] oh shoot! [00:10:34] thanks [00:11:11] with that merged I think the phab is 'done' but I'll double check it does update them once deployed [00:11:55] (03PS2) 10Ejegg: Fix CancelInactives to set status [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836315 (https://phabricator.wikimedia.org/T315102) (owner: 10Eileen) [00:11:59] (03CR) 10Ejegg: [C: 03+2] Fix CancelInactives to set status [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836315 (https://phabricator.wikimedia.org/T315102) (owner: 10Eileen) [00:12:05] good catch [00:13:16] eileen: ok, I can either just revert that offset_in_days back to 7, or we can try this patch to put it in config: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/835725 [00:18:19] ejegg: oh right - I will take a look - when does the job kick off though? [00:18:39] in 2.5 hrs I think? [00:18:40] checking [00:20:07] yep, the job is at 11pm my time and it's now 8:20 my time [00:20:15] (it's 4:20 somewhere!) [00:20:33] so if it's not a trivial merge I'll just revert [00:21:29] ok cool - that seems like enough time - once I've deployed ^^ & checked it works I'll look at yours [00:22:09] wfan do you have a moment to look at the fixed version of that opt-in update? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/836305 [00:22:19] sure [00:22:44] thanks! [00:24:03] (03CR) 10Wfan: [C: 03+2] "Ah right should group by contact id, and looks right that 14362 row will get updated, thanks for catch that before deploy!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836305 (https://phabricator.wikimedia.org/T311974) (owner: 10Ejegg) [00:24:14] (03CR) 10CI reject: [V: 04-1] Fix CancelInactives to set status [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836315 (https://phabricator.wikimedia.org/T315102) (owner: 10Eileen) [00:24:34] oh weird [00:25:05] oh hah, authorization failed? [00:26:20] I guess in test setup [00:26:25] odd that it passed PS1 [00:32:16] (03PS3) 10Eileen: Fix CancelInactives to set status [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836315 (https://phabricator.wikimedia.org/T315102) [00:36:06] (03Merged) 10jenkins-bot: Corrected version of opt-in fix second step [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836305 (https://phabricator.wikimedia.org/T311974) (owner: 10Ejegg) [00:36:14] (03CR) 10Eileen: [C: 03+2] "putting back Plus 2" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836315 (https://phabricator.wikimedia.org/T315102) (owner: 10Eileen) [00:36:16] (03PS4) 10Ejegg: Fix CancelInactives to set status [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836315 (https://phabricator.wikimedia.org/T315102) (owner: 10Eileen) [00:36:18] (03CR) 10Ejegg: [C: 03+2] Fix CancelInactives to set status [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836315 (https://phabricator.wikimedia.org/T315102) (owner: 10Eileen) [00:36:46] ejegg: yeah something weird in that it coped locally - prob something we could do to run tests as admin but oh well [00:46:22] gawd it's such a pain running silverpop locally [00:48:46] (03Merged) 10jenkins-bot: Fix CancelInactives to set status [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836315 (https://phabricator.wikimedia.org/T315102) (owner: 10Eileen) [01:51:35] shall we pop a quick php rewrite into sprint? [02:03:15] lol [02:03:46] ejegg: so I got it going & agree it is loading it from config so that seems OK locally - but how do we pass in the value? [02:04:14] eileen: hah, string replace [02:04:27] or do you mean how to do it in config? [02:04:47] no I mean the idea is we can set it via the command line when running the script? [02:04:57] ahh, that would be a good idea [02:05:19] because I just remembered that on prod, we devs can't deploy changes to that config file [02:05:40] it's an /etc config file, so that needs ops [02:05:54] ok, for now I will just revert [02:05:55] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/836320 [02:06:23] (03PS1) 10Ejegg: Revert "Change days param for full export" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/836321 [02:06:31] ejegg: ah yeah - that makes sense - also - if we can test via command line we can test what would happen in prod - rather than hoping we don't screw up config [02:06:46] (03CR) 10Eileen: [C: 03+2] Revert "Change days param for full export" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/836321 (owner: 10Ejegg) [02:07:24] (03PS1) 10Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/836322 [02:07:27] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/836322 (owner: 10Ejegg) [02:08:12] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/836320 (owner: 10Eileen) [02:11:14] (03Merged) 10jenkins-bot: Revert "Change days param for full export" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/836321 (owner: 10Ejegg) [02:11:16] (03Merged) 10jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/836322 (owner: 10Ejegg) [02:20:10] !log updated fundraising python tools from dd494413 to 14d60435 [02:20:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:26:19] zuul seems to be sleeping on your merge patch [02:26:23] I'll just force it [02:26:27] (03CR) 10Ejegg: [V: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/836320 (owner: 10Eileen) [02:26:54] I'll deploy that too since I'm already on frpm [02:27:04] and I want to run that updb [02:28:04] ejegg: cool - I'll check the recurs get cancelled & then we can close the phab [02:29:07] !log updated fundraising CiviCRM from f3461a44 to 5e1738a1 [02:29:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:30:17] nice, seems to have fixed those optins [02:31:04] 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, 10fr-donorservices: Broken Deduper Clause Field - https://phabricator.wikimedia.org/T318833 (10Ejegg) a:05Eileenmcnaughton→03Ejegg [02:32:42] 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog: Check need to account for opt-in param loss from 2022-06-15 through 2022-06-30 - https://phabricator.wikimedia.org/T311974 (10Ejegg) 05Open→03Resolved OK, this fix has been made in production [02:34:00] re-running cancel-recur [02:35:21] ok - that looks like it worked [02:36:52] 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog: Custom field "AF_has_active_recurring_donation" is showing false positives - https://phabricator.wikimedia.org/T315102 (10Eileenm... [02:36:57] nice! [02:37:26] 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Last CiviCRM point update for the year - https://phabricator.wikimedia.org/T316713 (10Eileenmcnaughton) 05Open→03Resolved [02:40:47] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Implement PayPal EC CreateRecurringPaymentsProfile in SmashPig - https://phabricator.wikimedia.org/T318881 (10Ejegg) [02:41:04] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Implement PayPal EC CreateRecurringPaymentsProfile in SmashPig - https://phabricator.wikimedia.org/T318881 (10Ejegg) [02:41:06] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig, 10Epic: Move PayPal EC API calls to SmashPig - https://phabricator.wikimedia.org/T317245 (10Ejegg) [02:43:58] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Implement PayPal EC RefundTransaction in SmashPig - https://phabricator.wikimedia.org/T318882 (10Ejegg) [02:45:54] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/835782 (owner: 10L10n-bot) [02:47:54] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig, 10Epic: Implement PayPal EC ManageRecurringPaymentsProfileStatusCancel in SmashPig - https://phabricator.wikimedia.org/T318883 (10Ejegg) [02:48:16] (03PS1) 10Eileen: Run Civix.upgrade on civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836323 (https://phabricator.wikimedia.org/T318304) [03:03:00] 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, and 2 others: Run civix.update on extensions - https://phabricator.wikimedia.org/T318304 (10Eileenmcnaughton) This is getting a bit hard to track - gonna create a table |Extension|S... [03:04:30] 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, and 2 others: Run civix.update on extensions - https://phabricator.wikimedia.org/T318304 (10Eileenmcnaughton) [03:07:24] 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, and 2 others: Run civix.update on extensions - https://phabricator.wikimedia.org/T318304 (10Eileenmcnaughton) [03:08:00] 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, and 2 others: Run civix.update on extensions - https://phabricator.wikimedia.org/T318304 (10Eileenmcnaughton) [03:14:30] 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, and 2 others: Run civix.update on extensions - https://phabricator.wikimedia.org/T318304 (10Eileenmcnaughton) [03:18:47] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Create base function for calling PayPal EC API in SmashPig - https://phabricator.wikimedia.org/T318884 (10Ejegg) [03:25:18] (03CR) 10Ejegg: [C: 04-1] "Let's see if we can accept this param on the command line" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/835725 (https://phabricator.wikimedia.org/T318767) (owner: 10Ejegg) [03:27:57] (03PS1) 10Ejegg: Push donor details up to PaymentDetailResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/836325 (https://phabricator.wikimedia.org/T318867) [03:49:34] (03PS1) 10Eileen: Civix upgrade on wmffraud [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836326 (https://phabricator.wikimedia.org/T318304) [03:50:07] 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, and 2 others: Run civix.update on extensions - https://phabricator.wikimedia.org/T318304 (10Eileenmcnaughton) [04:02:46] (03PS1) 10Eileen: Update geocoder [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836327 (https://phabricator.wikimedia.org/T318304) [04:07:46] 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, and 2 others: Run civix.update on extensions - https://phabricator.wikimedia.org/T318304 (10Eileenmcnaughton) [04:09:53] 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, and 2 others: Run civix.update on extensions - https://phabricator.wikimedia.org/T318304 (10Eileenmcnaughton) [04:16:17] (03PS1) 10Eileen: Update contact editor [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836329 (https://phabricator.wikimedia.org/T318304) [04:21:11] 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, and 2 others: Run civix.update on extensions - https://phabricator.wikimedia.org/T318304 (10Eileenmcnaughton) [04:22:31] (03PS1) 10Eileen: Civix upgrade on datachecks [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836330 (https://phabricator.wikimedia.org/T318304) [04:23:11] 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, and 2 others: Run civix.update on extensions - https://phabricator.wikimedia.org/T318304 (10Eileenmcnaughton) [04:30:25] (03PS1) 10Eileen: Update shoreditch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836331 (https://phabricator.wikimedia.org/T318304) [04:31:21] 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, and 2 others: Run civix.update on extensions - https://phabricator.wikimedia.org/T318304 (10Eileenmcnaughton) [04:33:28] (03PS2) 10Eileen: Update shoreditch [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836331 (https://phabricator.wikimedia.org/T318304) [04:40:43] (03PS2) 10Eileen: Civix update omnimail [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835712 (https://phabricator.wikimedia.org/T318304) [04:40:45] (03PS2) 10Eileen: Civix upgrade on systemtools [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835713 (https://phabricator.wikimedia.org/T318304) [04:40:47] (03PS3) 10Eileen: Civix update on deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835711 (https://phabricator.wikimedia.org/T318304) [05:13:42] 10Fundraising-Backlog: Determining from which banner an RML donation originated - https://phabricator.wikimedia.org/T318887 (10MSuijkerbuijk_WMF) [05:19:49] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/836396 (owner: 10L10n-bot) [09:14:09] 10Fundraising-Backlog: Determining from which banner an RML donation originated - https://phabricator.wikimedia.org/T318887 (10Eileenmcnaughton) This is our documentation on it - we do bring back the source (it can be overwritten but I think that would be rare) https://wikitech.wikimedia.org/wiki/Fundraising/Dat... [10:17:08] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/836396 (owner: 10L10n-bot) [13:06:02] (03PS1) 10Thiemo Kreuz (WMDE): Make use of the ?? syntax where it makes sense [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/836802 [13:32:27] (03PS1) 10Thiemo Kreuz (WMDE): Fix visibility of setUp/tearDown methods in tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/836810 [13:35:25] (03PS1) 10Thiemo Kreuz (WMDE): Prefer in_array() over array_search() when that's not needed [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/836812 [13:36:21] (03PS1) 10Thiemo Kreuz (WMDE): Use the convenient createMock() shortcut in tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/836814 [13:46:10] (03CR) 10Jgleeson: [C: 03+2] "Thanks! this is working well for me. After mounting in the latest on Smashpig and running `composer cc` and `composer dump-autoload`, I wa" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832525 (owner: 10Ejegg) [13:47:08] 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Create base function for calling PayPal EC API in SmashPig - https://phabricator.wikimedia.org/T318884 (10jgleeson) 05Open→03In progress a:03jgleeson [13:47:10] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig, 10Epic: Move PayPal EC API calls to SmashPig - https://phabricator.wikimedia.org/T317245 (10jgleeson) [14:14:39] (03Merged) 10jenkins-bot: Update namespaces for SmashPig responses [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/832525 (owner: 10Ejegg) [15:03:07] (03PS3) 10Damilare Adedoyin: WIP: Add payment submethod to Civi for ApplePay and GooglePay [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836225 (https://phabricator.wikimedia.org/T318362) [15:03:57] (03CR) 10CI reject: [V: 04-1] WIP: Add payment submethod to Civi for ApplePay and GooglePay [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836225 (https://phabricator.wikimedia.org/T318362) (owner: 10Damilare Adedoyin) [15:07:53] (03PS4) 10Damilare Adedoyin: WIP: Add payment submethod to Civi for ApplePay and GooglePay [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836225 (https://phabricator.wikimedia.org/T318362) [15:22:28] (03PS5) 10Damilare Adedoyin: Add payment submethod to Civi for ApplePay and GooglePay [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836225 (https://phabricator.wikimedia.org/T318362) [15:28:21] 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, 10FR-AutoTY-Email, 10fr-donorservices: Decimal separator in Thank you email confirmation fr-FR, es-ES-, it-IT, nl-NL since end of August 2022 - https://phabricator.wikimedia.org/T318327 (10Damilare) a:03Eileenmcnaughton [15:29:38] hey wfan: does the searchkit comment in T314525 resolve the issue? [15:29:39] T314525: Way to send Civi TY email to a group? - https://phabricator.wikimedia.org/T314525 [15:29:52] also hi fr-tech [15:31:04] heyy damilare jgleeson fr-tech [15:32:07] hi AndyRussG damilare [15:32:17] :) :) [15:32:22] :) [15:32:42] :) :) :) ;p [15:32:51] hi fr-tech [15:33:09] thanks for the code review jgleeson ! [15:33:17] :) :) :) ;p :D [15:35:01] damilare: no, I believe that link is for reference not the solution. [15:36:15] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/836864 [15:36:18] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/836864 (owner: 10Ejegg) [15:37:45] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/836864 (owner: 10Ejegg) [15:38:12] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/836866 [15:40:01] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/836866 (owner: 10Ejegg) [15:40:39] hey ejegg. np [16:48:47] 10Fundraising-Backlog: Determining from which banner an RML donation originated - https://phabricator.wikimedia.org/T318887 (10EWilfong_WMF) Thanks, @Eileenmcnaughton, for noting the documentation. Based on this documentation, it looks like if the record has a Contact ID in Acoustic (née Silverpop) it's rml_sou... [16:52:13] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: check_endpoints_critical (Astropay-DLocal:1) 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [16:56:56] (03CR) 10Jforrester: "Note that this won't start merging until the dependent vendor patch is C+2'ed (and manually merged)." [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/836866 (owner: 10Ejegg) [16:57:13] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:00:07] fr-tech I'll be a couple minutes afk between meetings [17:00:16] 10-4 [17:01:17] Actually, I need a minute or two as well. [17:02:35] 10Fundraising-Backlog, 10FR-Amazon: Amazon donation error after logging in; possible iframe error - https://phabricator.wikimedia.org/T116956 (10MBeat33) 05Open→03Resolved a:03MBeat33 Closing due to age of this task and the lack of any similar instances. [17:06:55] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/836866 (owner: 10Ejegg) [17:07:00] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Civi: downloading scans is slower lately - https://phabricator.wikimedia.org/T284692 (10MBeat33) 05Open→03Resolved a:03MBeat33 Resolving this Task, Civi updates since it was created seem to have covered this, and exports are prompt. [17:10:02] 10Fundraising-Backlog, 10Recurring-Donations, 10fr-donorservices: Civi: recurring Ingenico status question - https://phabricator.wikimedia.org/T253259 (10MBeat33) 05Open→03Resolved a:03MBeat33 Resolving this Task due to the lack of any extra cases since it was made. [17:17:48] 10Fundraising Tech - Chaos Crew: php_network_getaddresses: getaddrinfo failed: Temporary failure in name resolution - https://phabricator.wikimedia.org/T318956 (10AnnWF) [17:26:55] 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, 10Patch-For-Review: Add payment submethod to Civi for ApplePay and GooglePay - https://phabricator.wikimedia.org/T318362 (10Dwisehaupt) [17:31:15] 10Fundraising-Backlog: Figure out what to do with CHARGEBACK_REVERSED Adyen ipns - https://phabricator.wikimedia.org/T318175 (10XenoRyet) [17:51:18] 10Fundraising Tech - Chaos Crew: Failmail not working on payments-wiki local - https://phabricator.wikimedia.org/T318831 (10jgleeson) I got emails on payments working in a few steps. - Connect to payments container as root(need to install packages) `docker-compose exec -u root payments bash` - Install ssmtp... [17:53:36] 10Fundraising-Backlog, 10FR-Tech-Analytics: English Pretests (starting 7/13) do not have all the status codes in the central notice banner history data set - https://phabricator.wikimedia.org/T318960 (10JMando) [18:06:41] (03CR) 10Ejegg: "Could we move the whole mapping switch to the new extension, not just the submethods?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836225 (https://phabricator.wikimedia.org/T318362) (owner: 10Damilare Adedoyin) [18:10:55] (03PS2) 10Thiemo Kreuz (WMDE): Use the convenient createMock() shortcut in tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/836814 [19:45:44] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks for working on this. Tested and looks good to me" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834411 (https://phabricator.wikimedia.org/T315238) (owner: 10Ejegg) [19:46:27] thanks damilare [19:46:42] (03Merged) 10jenkins-bot: Add suppressed count to failmails [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/834411 (https://phabricator.wikimedia.org/T315238) (owner: 10Ejegg) [19:46:47] np, thanks for working on that [19:56:05] !log payments-wiki upgraded from 0456850e to 839d6dde [19:56:09] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:57:34] ok fr-tech I just deployed these changes to payments-wiki: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/836864 [19:58:48] I guess let's try to make sure the adyen and ingenico forms are still working fine [19:59:22] oh darn, getting some errors [19:59:29] f_1%7Etime_26&referrer=en.wikipedia.org%2F TypeError from line 100 of /srv/www/org/wikimedia/payments/vendor/wikimedia/smash-pig/PaymentProviders/Adyen/PaymentProvider.php: Return value of SmashPig\PaymentProviders\Adyen\PaymentProvider::getPaymentMethods() must be an instance of SmashPig\PaymentProviders\Responses\PaymentMethodResponse, instance of __PHP_Incomplete_Class returned [19:59:35] whoa [19:59:37] ok, reverting [20:00:27] ahhh darn, is that a cache thing? [20:00:30] I think it is... [20:00:36] ok, how do we fix that [20:02:38] well, that seems to have settled down [20:03:16] ah no, just for the US/USD [20:03:25] darn, i will roll back [20:03:48] and try to see how to clear the cache [20:04:37] !log payments-wiki rolled back from 839d6dde to 0456850e [20:04:39] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:04:50] ok, so I guess I'll fix it in code [20:06:39] ejegg: what's the bug? [20:06:46] I didn't see that locally [20:06:59] I tested adyen too [20:07:50] ejegg: did the smashpig stuff get checked into vendor? [20:07:59] jgleeson: yeah, it was because we were caching serialized response objects [20:08:21] so the old code cached them serialized as \SmashPig\PaymentProvider\PaymentMethodResponse [20:08:36] then in the new code that class doesn't exist (it's in a different namespace) [20:09:21] so the deserialization fails and we return the weird __PHP_Incomplete_Class [20:09:21] argh I vaguely remember that. to cut down on the payment method calls? [20:09:26] yeah [20:09:37] what's the backend, can we expire it some how? [20:09:42] anyway, we can set the cache key prefix in config [20:09:56] so I'm going to just temporarily change that [20:10:24] maybe ops could expire it, but it's the same backend that holds mediawiki sessions, so we'd want to be careful about the keys [20:10:37] I think changing the cache key prefix for a while is the easiest [20:11:04] default is key-base: SMASHPIG_ADYEN_METHODS [20:11:40] so probably we should have just been caching the raw response all along and not a PHP class [20:11:47] serialization is weird [20:12:25] huh [20:12:47] ah I see [20:13:04] sweet. the cache key is in the adyen smashpig config I think? [20:13:45] yep yep! [20:17:53] !log payments-wiki upgraded from 0456850e to 839d6dde (with cache prefix altered for moved classes) [20:17:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:18:49] ack, that setting goes out with the SmashPig f_c_u, right [20:18:58] ok, a couple more of those errors but now it's good [20:19:09] or... is it? [20:19:33] 10Fundraising-Backlog: Gpay issue - https://phabricator.wikimedia.org/T318978 (10EMartin) [20:19:40] the heck... [20:20:57] grr, still getting bad cached values for CA/CAD [20:21:24] 10Fundraising-Backlog: Gpay issue - https://phabricator.wikimedia.org/T318978 (10Ejegg) Sorry, this is a bad deploy I'm trying to fix right now. [20:21:55] emartin_: I'm trying to fix that now - it's not just GPay [20:22:03] Hi All. Trilogy has detected an issue with GPay. Is this on our end or do I need to raise with Adyen: https://phabricator.wikimedia.org/T318978 [20:22:10] emartin_: it's on our end [20:22:22] Oh, I see Elliott. We'll stand by. [20:23:19] dwisehaupt: can you selectively kill some keys in the payments-wiki memcache? [20:23:57] hrm. probably. [20:23:58] I've got the adyen payment method caches half-populated with stuff that breaks the old code and half with stuff that breaks the new code [20:24:21] trying to clearn anything with SMASHPIG_ADYEN_ [20:25:24] 10Fundraising-Backlog: Gpay issue - https://phabricator.wikimedia.org/T318978 (10EMartin) Seems to be rectified, Elliott:{F35540420} [20:25:54] ejegg: anything I can do to help? [20:25:59] heh, the cached object for US/USD works with the new code, so I rolled forward again [20:26:17] jgleeson: want to double check whether I did the right thing to change the cache key? [20:26:29] I thought I did it, and that should have gotten us a blank slate [20:26:34] but the errors kept coming [20:26:44] sure [20:27:16] I changed the key-base in SmashPig/local-settings/adyen/main.yaml [20:27:33] and then synced that out with f_c_u SmashPig and rsync_blaster SmashPig:ALL [20:27:36] config change looks good [20:27:39] or at least I think I did [20:27:41] just checking code [20:28:31] yeah, log announcer messages make it look like I synced it out right [20:28:57] I'm going to try again [20:29:39] yeh. memcache doesn't have the easy ability to do that. i'm looking at the options. [20:30:03] ejegg: you are all over the failmail? doesn't seem to be civi? [20:30:04] the quick response is just bounce memcache but that would dump all keys. [20:30:55] dwisehaupt: shoot, I was hoping not to kill everyone's sessions [20:31:03] eileen: yep, I'm trying to fix it [20:31:20] eileen: the failmail is something else [20:31:24] I guess we can kill everyone's sessions if there's no way to do it surgically [20:31:26] unrelated I think ejegg [20:31:38] ok - just checking in to see if I can help [20:32:01] oh, I see a lot of nagios [20:32:14] yeah I think dwisehaupt was on that earlier [20:33:04] oh hey, i see a successful GB/GBP in the init logs, that key might have just timed out anyway [20:33:27] ejegg: that code looks good [20:33:31] dwisehaupt: I think we're OK now [20:33:36] ok cool\ [20:33:47] you didn't end up bouncing the server? [20:34:05] ok, CA/CAD coming in good too [20:34:20] that was the other combo that had a bad cached value [20:34:40] it's strange that new cache key wasn't effective immediately [20:34:49] yeah, I wonder what's up with that [20:34:53] that points to a delay in the rsync process maybe [20:35:18] hmm, or the php web process hanging on to an old value somehow? [20:35:37] opcache? [20:35:37] i mean, the code rsyncs immediately [20:35:46] can't think why the yaml would be slower [20:35:52] (03CR) 10Eileen: "I just made a couple of super minor comments - but they are not high priority. It would be good to put new code in the extension" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836225 (https://phabricator.wikimedia.org/T318362) (owner: 10Damilare Adedoyin) [20:35:52] we're not using any opcache are we? [20:36:05] apc etc [20:36:28] opcache would be for code, right? or is it for other random files you read in too? [20:37:52] i did not bounce memcache. [20:38:12] dwisehaupt: ok, so either they timed out organically or that key prefix change I tried to do finally took effect [20:38:29] can we confirm the new prefix exists? [20:38:35] in memcache [20:38:39] anyway, I think the lesson is to cache strings and not serialized classes whenever possible [20:38:50] yeah [20:39:37] ejegg: wrt to opcache: yeah that doesn;t make sense either [20:43:34] yeah, memcache doesn't have much tooling around it so it's not the easiest to poke at. :) [20:46:24] 10Fundraising-Backlog: Gpay issue - https://phabricator.wikimedia.org/T318978 (10Ejegg) Yep, we deployed some new code that changed the namespace of a class we had been caching. Oops! Next time we want to cache something, let's cache a plain old string and not a serialized class. We were able to change the cach... [20:48:05] 10Fundraising-Backlog: Gpay issue - https://phabricator.wikimedia.org/T318978 (10EMartin) 05Open→03Resolved a:03EMartin [20:48:56] i logs dont tell us much [20:49:00] the* [20:49:41] (03PS1) 10Ejegg: Merge branch 'REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/836923 [20:49:45] (03CR) 10Ejegg: [C: 03+2] Merge branch 'REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/836923 (owner: 10Ejegg) [20:54:26] damilare: do you have any dietary requirements? I don't see your response to the dev training email [20:59:14] (03Merged) 10jenkins-bot: Merge branch 'REL1_35' into fundraising/REL1_35 [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/836923 (owner: 10Ejegg) [21:09:58] oh no I don't, I'd fill it up right away. Thanks eileen [21:10:05] thanks [21:16:28] (03PS1) 10Ejegg: Don't log spurious warning on missing params [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/836930 [21:16:48] jgleeson: that should stop those bad warnings ^^^ [21:18:05] !log payments-wiki upgraded from 839d6dde to aeee9676 [21:18:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:19:27] (03CR) 10Jgleeson: [C: 03+2] "LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/836930 (owner: 10Ejegg) [21:19:55] wfan: OK, I'm going to tag another version of smash-pig and then another matching version of donation-interface, so we can update 'em both in crm and get the new payment_method filter on the pending fetch [21:20:00] thanks jgleeson ! [21:21:10] Sounds good, thanks Elliott :) [21:21:59] (03Merged) 10jenkins-bot: Don't log spurious warning on missing params [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/836930 (owner: 10Ejegg) [21:23:26] AndyRussG: ejegg: this smtp mailhander rework (support for mailcatcher on smashpig) is taking a bit more time than I'd like. I'm trying to make it config driven so we can just drop in settings in our local smashpig config but to do that requires a bit of a refactor of the smashpig mail internals and I won't finish tonight I'll continue tomorrow fresh and caffeinated. [21:23:50] so* [21:24:14] also. this work isn't in the sprint fr-tech. sorry! [21:24:29] I've kinda gone off on a skirmish to get failmails working [21:25:28] which is pretty hypocritical of me after pontificating in the retro doc about finishing the sprint ABOVE ALL ELSE !!!!111 [21:26:55] I'll timebox it to an hour tomorrow and if I don't finish it I'll add the WIP patch to the ticket for someone else to finish when appropriate. That way if I don't finish it, we at least retain the beginnings of the solution and some useful context in the code. Does that sound ok ? [21:27:03] XenoRyet: greg-g fr-tech ^ [21:27:58] jgleeson: sounds good :) Way to catch yourself! [21:28:12] don't worry it's all good jgleeson [21:28:22] thank you! [21:28:46] sometimes the best ideas come when you're sidetracked ;) [21:28:51] ha [21:28:53] yes they do [21:29:15] :) [21:29:52] ok. I'm gonna wrap up now and go watch the second half of "days of thunder" https://www.imdb.com/title/tt0099371/ before bed :) [21:29:57] bye for now fr-tech o/ [21:29:58] (03PS4) 10Eileen: Civix update on deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/835711 (https://phabricator.wikimedia.org/T318304) [21:39:15] (03PS1) 10Eileen: Add comment explaining crmSearchSelector [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836936 [21:40:10] (03CR) 10Eileen: [V: 04-1] "I did some testing & figured out where this is used & put up https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/836936 that adds" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836291 (owner: 10Ejegg) [21:49:23] oh man, this hit a little too close to home: https://pbs.twimg.com/media/FdyNG9UVsAA2l_l?format=jpg&name=small [21:50:16] (03Abandoned) 10Ejegg: Delete unused JS file from deduper [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/836291 (owner: 10Ejegg) [21:50:38] oops eileen I guess I didn't test more than just the contact ID one [21:51:13] ejegg: yeah - I might have missed it if I hadn't also been testing the deduper update & I did a bit of searching the code too [21:51:44] my son Luke is watching breaking bad at the mo [21:52:08] heh, explains the last bit of test data [22:02:40] (03PS1) 10Ejegg: Update Smash-Pig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/836941 [22:02:47] (03CR) 10Ejegg: [C: 03+2] Update Smash-Pig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/836941 (owner: 10Ejegg) [22:04:17] ok eileen once I get these composer updates all cascaded I'll review those extension updates [22:04:58] ejegg: ok cool- I have done a little testing on the shoreditch one - but if there is a css regression it doesn't look like one we will find [22:15:28] (03PS4) 10Ejegg: Update SmashPig and DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/832523 [22:16:30] ok wfan, assuming ^^^ passes tests, you can rebase your pending transaction resolver patch over that one to get the new method signature for pending fetch [22:17:30] ok, seems like origin error was like SmashPig\PaymentProviders\Responses\CreatePaymentResponse not found and you added at the same pr, so it should be fine right~ [22:18:01] (03Merged) 10jenkins-bot: Update Smash-Pig [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/836941 (owner: 10Ejegg) [22:19:34] wfan: ejegg; hey quick question before you finish the day.... just doing my non-work cooking and such, but I'd be at the keyboard some again later I hope.... were you able to make headway on the CentralNotice status codes issue? should I dig in later, or do you plan to keep digging in wfan? or if you prefer we can also look at it again more tomorrow? [22:20:02] AndyRussG: sorry, no, no progress on that - I've been working on other stuff so far today [22:20:08] ok [22:20:19] Would you able to help that code tomorrow, we can schedule a time to do that a bit tomorrow thanks Andy~ [22:20:28] I would like to try that banner on aa wikibooks at some point [22:20:33] no worries of course ejegg [22:20:42] yes sounds great wfan ejegg [22:20:44] on both points [22:28:06] hmm wfan, looks like that test has some errors, let's see what they are [22:28:30] (03CR) 10CI reject: [V: 04-1] Update SmashPig and DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/832523 (owner: 10Ejegg) [22:28:55] 15:28:13 Error: Cannot instantiate abstract class SmashPig\PaymentProviders\Adyen\Audit\AdyenAudit [22:29:04] ohhhh, adyenAudit needs update too [22:29:07] I think Christine has a patch to update this [22:29:22] hmm, I guess we need to squash those together? [22:29:51] I'll abandon my patch and just upload another patch set on hers [22:30:22] ohh, hers is all ready to submit! [22:30:35] (03PS19) 10Ejegg: Adding payments_details_report as an option for the Adyen Audit [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831146 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [22:40:33] ejegg: I saw that tech lead documentation image earlier and.... yeah, I would be lying if I didn't think of you when I saw it :) [22:48:23] ejegg: should we manual submit this https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/831146/ ? [22:49:27] I just did wfan [22:49:32] (after a rebase) [22:50:20] greg-g: I swear I'll write it all down sometime! Just as soon as they stop asking for new features... and we get all the refactors done :) [22:50:49] ejegg: <3 [22:51:34] Ha nice, then we can have your newer version update unblocked~ [22:52:17] (03PS5) 10Ejegg: Update SmashPig and DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/832523 [23:00:43] ok wfan it's gotten past the part where it failed before [23:00:56] wohoo~ [23:00:58] I think it's ready for some CR if you want to take a quick look [23:02:11] Sure, seems like this is the combination of Update namespaces for SmashPig responses and the pending resolver [23:03:02] 10Fundraising-Backlog: Rename Astropay files to dLocal - https://phabricator.wikimedia.org/T318857 (10Ejegg) [23:03:10] 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface, 10Epic: [EPIC] Rename AstroPay to dLocal - https://phabricator.wikimedia.org/T144835 (10Ejegg) [23:03:27] hah, we've been thinking about that rename for 6 years now [23:03:32] maybe with the new integration? [23:05:41] (03CR) 10Wfan: [C: 03+2] "Update for smashpig to 0.8.3.1 for Update namespaces for SmashPig responses and add payment_method column to pending table for pending res" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/832523 (owner: 10Ejegg) [23:06:25] thanks wfan! [23:06:48] why do we need to submit manually? [23:07:02] sometimes zuul just stalls out, i don't know why [23:07:09] back in a bit! [23:08:01] (03PS13) 10Wfan: Add adyen to pending transaction resolver, and add google to the $_resolvableMethods array [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831618 (https://phabricator.wikimedia.org/T316587) [23:13:51] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Aldrick Beckford - https://phabricator.wikimedia.org/T318840 (10Dwisehaupt) [23:14:07] 10Fundraising-Backlog, 10fundraising-tech-ops: Fundraising access request for Aldrick Beckford - https://phabricator.wikimedia.org/T318840 (10Dwisehaupt) 05Open→03Resolved Worked together today to get the certificate installed in chrome on windows. Verified civi access and anticipate no issues with superse...