[02:39:24] 10Fundraising-Backlog: Determining from which banner an RML donation originated - https://phabricator.wikimedia.org/T318887 (10Eileenmcnaughton) @EWilfong_WMF - you are correct the source will only be equal to the RML source IF that is how they first enter our database. If an existing contact (either a previous... [12:09:00] (03PS7) 10Jgleeson: Add support for SMTP to SmashPig's MailHandler [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/837136 (https://phabricator.wikimedia.org/T318831) [12:12:42] (03CR) 10Jgleeson: "To fix this, I had to put the testing URL on a new line in the commit message. I'm guessing I breached commit rules? One to remember for t" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/837136 (https://phabricator.wikimedia.org/T318831) (owner: 10Jgleeson) [12:41:38] 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Create base function for calling PayPal EC API in SmashPig - https://phabricator.wikimedia.org/T318884 (10jgleeson) Looking at the [[ https://developer.paypal.com/api/nvp-soap/NVPAPIOverview/#link-s... [12:56:30] 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Create base function for calling PayPal EC API in SmashPig - https://phabricator.wikimedia.org/T318884 (10jgleeson) Due to the number of request elements on the Paypal calls, to makes sense to templ... [13:29:18] (03PS1) 10Jgleeson: WIP: Create Base API class for PayPal EC [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/837669 (https://phabricator.wikimedia.org/T318884) [13:33:27] (03PS2) 10Jgleeson: WIP: Create Base API class for PayPal EC [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/837669 (https://phabricator.wikimedia.org/T318884) [14:18:11] 10Fundraising-Backlog, 10fr-donorservices: Donor with over 28 charges in Civi after single donation was made - https://phabricator.wikimedia.org/T319203 (10SHust) [15:00:44] 10Fundraising-Backlog, 10fr-donorservices: Donor with over 28 charges in Civi after single donation was made - https://phabricator.wikimedia.org/T319203 (10EMartin) Adding transaction list here: PSP Reference Merchant Reference Account Creation Date TimeZone Value Currency LKCXJW3KDNC84V62 129882096.1 Wikimed... [15:12:04] Helllllo fr-tech I am back in Colorado [15:13:00] hiiiii cstone damilare jgleeson|skrun fr-tech :) [15:13:08] how was the drive cstone? [15:13:57] hi AndyrussG fr-tech! welcomeback cstone [15:16:01] Long AndyRussG ! But wasn't 90/32 degrees for once while driving so that was nice [15:16:08] Hi damilare ! [15:18:26] :) [15:18:36] ah good to hear cstone [15:19:28] I might have covid again though but so far no symptoms! (both my parents have it and are ok) [15:27:30] 10Fundraising-Backlog, 10fr-donorservices: Donor with over 28 charges in Civi after single donation was made - https://phabricator.wikimedia.org/T319203 (10Cstone) Hey @SHust Did they say anything about having issues trying to donate or clicking donate a bunch? [15:29:03] cstone: welcome back! hope the covid doesn't get you! [15:30:11] 10Fundraising-Backlog, 10fr-donorservices: Donor with over 28 charges in Civi after single donation was made - https://phabricator.wikimedia.org/T319203 (10SHust) @Cstone No issues from their end [15:32:44] (03CR) 10Damilare Adedoyin: [C: 03+1] "Thanks jgleeson for working on this fix and also setting clear instructions on how to test it. I was able to run it locally and it works a" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/837136 (https://phabricator.wikimedia.org/T318831) (owner: 10Jgleeson) [15:47:16] 10Fundraising-Backlog, 10fr-donorservices: Donor with over 28 charges in Civi after single donation was made - https://phabricator.wikimedia.org/T319203 (10EMartin) Adyen suggests we made these calls and again points to idem potency to avoid situations like this. We do have this already in effect. Please let... [15:49:48] (03PS14) 10Damilare Adedoyin: Add adyen to pending transaction resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831618 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [15:49:50] (03PS5) 10Damilare Adedoyin: Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) [15:52:10] oh cstone take care! [15:55:39] 10Fundraising-Backlog: Determining from which banner an RML donation originated - https://phabricator.wikimedia.org/T318887 (10EWilfong_WMF) Thanks for confirming, @Eileenmcnaughton. Since I do not have Civi access, would it be possible for you to provide me the list of RML email donations with Contact ID, Emai... [16:02:46] (03CR) 10CI reject: [V: 04-1] Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) (owner: 10Damilare Adedoyin) [16:06:32] Hi cstone and hi dami, i see u remove google from the resolvable array, I think that that adyen pending resolved can contain google as one of payment sub method, and since we do have the capture part for google I believe this is fine to have it? [16:10:00] and if not payment method pass for fetchMessageByGatewayOldest, then default would be empty array, and this will not filter the recurring for adyen~ [16:10:26] so not sure why https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/831618/ this latest change for? [16:12:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [16:17:11] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [16:17:57] dwisehaupt: if you pull latest smashpig, then you will see that we add payment_method for fetchMessageByGatewayOldest~ [16:19:16] wenjun, I didn't remove the line on purpose. I only did a rebase of my patch over master as it was behind and had conflicts [16:19:43] really sorry about that [16:21:00] also not sure why your patch was updated after I rebased mine. I'd probably abandon it and start another. [16:27:10] PROBLEM - check_mysql on frdb2001 is CRITICAL: Cant connect to local MySQL server through socket /var/run/mysqld/mysqld.sock (2) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql [16:27:11] RECOVERY - check_mysql on frdb2003 is OK: Uptime: 952607 Threads: 5 Questions: 461603856 Slow queries: 387 Opens: 3654 Open tables: 1456 Queries per second avg: 484.569 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [16:28:02] (03PS15) 10Damilare Adedoyin: Add adyen to pending transaction resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831618 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [16:29:29] Apologies once again Wfan, I've now reset the changes. not sure why that happened especially since it was +2'd and merged [16:32:26] Ha, no worry, thanks for reset it :) and I think this one did not get +2 after that smashpig one merged, maybe you can do the review for this again? Thanks :) [16:36:37] sure [16:51:54] (03PS6) 10Damilare Adedoyin: Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) [16:57:58] 10Fundraising-Backlog, 10fr-donorservices: Donor with over 28 charges in Civi after single donation was made - https://phabricator.wikimedia.org/T319203 (10Cstone) Some notes from looking into this: Two damaged messages where the duplicate notification is chained like 129880996.1|dup-1663101285|dup-1663104423... [17:07:28] (03CR) 10CI reject: [V: 04-1] Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) (owner: 10Damilare Adedoyin) [17:17:33] (03PS1) 10Wfan: Check if $mail->from exist and if not set reply to to blank [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/837728 (https://phabricator.wikimedia.org/T318837) [17:39:10] (03CR) 10Wfan: [C: 03+2] "works awesome with the patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/837136" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/837141 (https://phabricator.wikimedia.org/T318831) (owner: 10Jgleeson) [17:42:25] 10Fundraising Tech - Chaos Crew, 10Patch-For-Review: Failmail not working on payments-wiki local - https://phabricator.wikimedia.org/T318831 (10AnnWF) works awesome, thanks for this detail test steps :) very easy to test with it >>! In T318831#8276302, @jgleeson wrote: > **How to test:** > > - Pull down the... [17:54:18] (03CR) 10Ejegg: "Looks like this might be a useful fix for the upstream CiviCRM repo. In the interests of keeping our code in sync with upstream, do you wa" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/837728 (https://phabricator.wikimedia.org/T318837) (owner: 10Wfan) [17:55:59] (03CR) 10Ejegg: "Also, note that we are no longer using the crm/civicrm submodule, so we shouldn't submit any more patches to this repo. You may need to rm" [wikimedia/fundraising/crm/civicrm] - 10https://gerrit.wikimedia.org/r/837728 (https://phabricator.wikimedia.org/T318837) (owner: 10Wfan) [17:58:17] ejegg: any ideas on this one https://phabricator.wikimedia.org/T319203 they created 31 donations in 6 seconds, some with the same contribution tracking id but some with new ones [18:11:03] (03PS7) 10Damilare Adedoyin: Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) [18:15:49] (03PS8) 10Damilare Adedoyin: Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) [18:20:42] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts, 10Patch-For-Review: INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found failmail coming from the listener on ideal - https://phabricator.wikimedia.org/T315031 (10Cstone) Happened again, unintended i... [18:33:55] (03CR) 10Damilare Adedoyin: [C: 03+2] Add adyen to pending transaction resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831618 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [18:36:49] hi wfan, I just +2'd the pending transaction resolver changes as they look good to me. Thanks for working on that [18:37:24] please help review the tests too once yours gets merged [18:41:07] Sounds good and sure thanks dami :) [18:46:43] (03Merged) 10jenkins-bot: Add adyen to pending transaction resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831618 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [18:47:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [18:51:54] PROBLEM - Host frdb2001 is DOWN: PING CRITICAL - Packet loss = 100% [18:55:40] oh nice dami, I was just looking at that locally too. Had a couple of comments but nothing that would get in the way of C+2 [18:56:32] (03CR) 10Ejegg: [C: 03+2] "Looks good! In a followup we could maybe centralize that resolvable methods list." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/831618 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [18:56:42] thanks for the review wfan ! [18:57:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [18:57:25] np and here is the upstream pr https://github.com/civicrm/civicrm-core/pull/24667/commits/b2a1c9439fa17638720bc7e4f0348f32221224cc not sure will this need review from Elieen? [18:58:35] also thanks damilare for review! [18:58:41] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Contact updated to have an invalid language - https://phabricator.wikimedia.org/T319142 (10Cstone) CID 57031227 [18:59:26] np jgleeson and ejegg [19:02:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [19:04:16] oh shoot wfan, we might need to make one more change to Adyen\PaymentProvider::getLatestPaymentStatus [19:04:35] it doesn't set the 'successful' status to true or false [19:04:52] Oh let me check that sorry~ [19:05:27] oh i see, we're not actually calling isSuccessful on that result anywhere in PendingTransaction::Resolve [19:05:49] so we won't get an error in the Pending Transaction Resolver [19:06:14] we should still fix that in case we want to use that call anywhere else later. [19:07:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [19:07:16] PROBLEM - check_puppetrun on frban2001 is CRITICAL: CRITICAL: Puppet has 18 failures. Last run 6 minutes ago with 18 failures. Failed resources (up to 3 shown): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban2001&service=check_puppetrun [19:09:22] Oh we are setting the status for adyen pending trxn based on paymentsInitRow $result->setStatus( $paymentsInitRow['payments_final_status'] ?? FinalStatus::PENDING_POKE ); [19:09:55] right, there is a 'Status' pseudo-enum property and an 'isSuccessful' boolean property [19:09:59] and ingenico has setSuccessful [19:10:01] for every other call we set both [19:10:10] PROBLEM - check_puppetrun on frlog2001 is CRITICAL: CRITICAL: Puppet has 11 failures. Last run 7 minutes ago with 11 failures. Failed resources (up to 3 shown): File[/usr/local/bin/package_update_check],File[/etc/vim/vimrc.local],File[/usr/local/bin/yubikey_otp_filter],File[/bin/nopeshell] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frlog2001&service=check_puppetrun [19:10:16] PROBLEM - check_puppetrun on frauth2001 is CRITICAL: CRITICAL: Puppet has 15 failures. Last run 7 minutes ago with 15 failures. Failed resources (up to 3 shown): File[/usr/local/bin/package_update_check],File[/etc/vim/vimrc.local],File[/usr/local/bin/yubikey_otp_filter],File[/bin/nopeshell] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frauth2001&service=check_puppetrun [19:10:30] so we should add the setSuccessful to adyen as well [19:10:34] (03CR) 10Jgleeson: Add support for SMTP to SmashPig's MailHandler (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/837136 (https://phabricator.wikimedia.org/T318831) (owner: 10Jgleeson) [19:10:43] wfan yes please [19:11:17] because otherwise calling isSuccessful will throw an error as it will return null for a non-nullable boolean return value [19:12:06] ok [19:12:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [19:12:16] PROBLEM - check_puppetrun on frbackup2002 is CRITICAL: CRITICAL: Puppet has 17 failures. Last run 9 minutes ago with 17 failures. Failed resources (up to 3 shown): File[/usr/local/bin/package_update_check],File[/etc/vim/vimrc.local],File[/usr/local/bin/yubikey_otp_filter],File[/bin/nopeshell] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frbackup2002&service=check_puppetrun [19:12:16] PROBLEM - check_puppetrun on frban2001 is CRITICAL: CRITICAL: Puppet has 18 failures. Last run 11 minutes ago with 18 failures. Failed resources (up to 3 shown): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban2001&service=check_puppetrun [19:12:50] this is me ^^^ rebooting the codfw puppet server [19:15:10] PROBLEM - check_puppetrun on frlog2001 is CRITICAL: CRITICAL: Puppet has 11 failures. Last run 12 minutes ago with 11 failures. Failed resources (up to 3 shown): File[/usr/local/bin/package_update_check],File[/etc/vim/vimrc.local],File[/usr/local/bin/yubikey_otp_filter],File[/bin/nopeshell] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frlog2001&service=check_puppetrun [19:15:16] RECOVERY - check_puppetrun on frauth2001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frauth2001&service=check_puppetrun [19:16:24] (03PS8) 10Wfan: Add support for SMTP to SmashPig's MailHandler [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/837136 (https://phabricator.wikimedia.org/T318831) (owner: 10Jgleeson) [19:16:26] (03PS1) 10Wfan: Set isSuccessful to false to adyen latest status [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/837743 (https://phabricator.wikimedia.org/T316587) [19:16:49] (03CR) 10Ejegg: "Looks like a pretty thorough test! Just found a couple of things to nitpick about, nothing big." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) (owner: 10Damilare Adedoyin) [19:17:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [19:17:16] RECOVERY - check_puppetrun on frbackup2002 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frbackup2002&service=check_puppetrun [19:17:16] RECOVERY - check_puppetrun on frban2001 is OK: OK: Puppet is currently enabled, last run 57 seconds ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban2001&service=check_puppetrun [19:17:22] (03PS2) 10Wfan: Set isSuccessful to false to adyen latest status [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/837743 (https://phabricator.wikimedia.org/T316587) [19:18:18] wfan maybe it shouldn't always be false? [19:19:29] The Big Lebowski - Hotel California - The Gipsy Kings. https://www.youtube.com/watch?v=3l436MSlivQ [19:19:53] ~(Λ˜β–ΎΛ˜~) [19:20:02] While if this is not only been used for resolver then πŸ€” ok [19:20:10] RECOVERY - check_puppetrun on frlog2001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frlog2001&service=check_puppetrun [19:20:51] Looks like we use 'true' for the PENDING_POKE cass [19:20:54] case [19:21:01] in the Ingenico function [19:21:10] so let's just try to make this one act similarly [19:21:36] (03PS9) 10Damilare Adedoyin: Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) [19:22:01] setSuccessful( in_array( $status, $this->getPaymentDetailsSuccessfulStatuses ) ) [19:22:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [19:22:12] I think somethign like that wfan ^^^ [19:22:28] well, with the parens to call that get...Statuses method [19:23:32] (03CR) 10Damilare Adedoyin: "Thanks for the review ejegg, I pushed up a patchset with the recommended changes." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) (owner: 10Damilare Adedoyin) [19:26:58] (03CR) 10CI reject: [V: 04-1] Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) (owner: 10Damilare Adedoyin) [19:27:10] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [19:30:15] (03CR) 10Damilare Adedoyin: "Recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) (owner: 10Damilare Adedoyin) [19:32:13] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [19:37:13] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [19:37:30] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: prevent the get property from non-object error - https://phabricator.wikimedia.org/T318837 (10AnnWF) https://github.com/civicrm/civicrm-core/pull/24667/commits/b2a1c9439fa17638720bc7e4f0348f32221224cc github civi-core upstream pr [19:45:11] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Contact updated to have an invalid language - https://phabricator.wikimedia.org/T319142 (10Damilare) This was a similar patch where we caught invalid language codes during import and default to en_US: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising... [19:47:13] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [19:47:32] (03PS3) 10Wfan: Set isSuccessful to false to adyen latest status if payment_init table do not have complete as final status [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/837743 (https://phabricator.wikimedia.org/T316587) [19:48:02] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Implement PayPal EC ManageRecurringPaymentsProfileStatusCancel in SmashPig - https://phabricator.wikimedia.org/T318883 (10Ejegg) [19:48:18] 10Fundraising-Backlog, 10fr-donorservices: Donor with over 28 charges in Civi after single donation was made - https://phabricator.wikimedia.org/T319203 (10Jgreen) Logs from the payments server are at frpm1001:/tmp/T319203-* [19:50:19] 10Fundraising-Backlog, 10fr-donorservices: Unsubscribe button no longer on Civi main menu bar - https://phabricator.wikimedia.org/T318830 (10XenoRyet) 05Openβ†’03Resolved [19:52:13] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [19:57:13] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [20:03:01] 10Fundraising-Backlog: chmod(): Operation not permitted BaseAuditProcessor.php:1063 - https://phabricator.wikimedia.org/T318623 (10XenoRyet) p:05Triageβ†’03Low [20:03:33] (03CR) 10Damilare Adedoyin: "Recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) (owner: 10Damilare Adedoyin) [20:03:46] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Donor with over 28 charges in Civi after single donation was made - https://phabricator.wikimedia.org/T319203 (10XenoRyet) [20:03:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Civi merged two CID but did not save/include an active recurring donation - https://phabricator.wikimedia.org/T319073 (10XenoRyet) [20:03:50] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Contact updated to have an invalid language - https://phabricator.wikimedia.org/T319142 (10XenoRyet) [20:03:52] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Adyen: add email address for subsequent recurring donations - https://phabricator.wikimedia.org/T318851 (10XenoRyet) [20:03:57] 10Fundraising Sprint Potato, 10Fundraising Sprint Quarkery, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Unit tests for Adyen Pending Transaction Resolver - https://phabricator.wikimedia.org/T316588 (10XenoRyet) [20:04:03] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: chmod(): Operation not permitted BaseAuditProcessor.php:1063 - https://phabricator.wikimedia.org/T318623 (10XenoRyet) [20:04:05] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface, 10Epic: [EPIC] Rename AstroPay to dLocal - https://phabricator.wikimedia.org/T144835 (10XenoRyet) [20:07:13] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [20:07:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Contact updated to have an invalid language - https://phabricator.wikimedia.org/T319142 (10Eileenmcnaughton) so we should pick the 'best' language for the 2 letter language code if the 2 + 2 variant doesn't exist - ie f... [20:08:51] (03CR) 10CI reject: [V: 04-1] Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) (owner: 10Damilare Adedoyin) [20:11:35] 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig, 10Patch-For-Review: Create base function for calling PayPal EC API in SmashPig - https://phabricator.wikimedia.org/T318884 (10Ejegg) >>! In T318884#8279552, @jgleeson wrote: > @Ejegg, can you conf... [20:13:34] 10Fundraising Sprint Recursion Excursion, 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig, 10Patch-For-Review: Create base function for calling PayPal EC API in SmashPig - https://phabricator.wikimedia.org/T318884 (10Ejegg) Regarding the Cert / Signature mix - I agree that it would be p... [20:14:32] (03PS10) 10Damilare Adedoyin: Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) [20:19:49] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: prevent the get property from non-object error - https://phabricator.wikimedia.org/T318837 (10Eileenmcnaughton) I'm looking at the code & trying to figure out why 'from' would be blank - do you have any idea? It looks like it is par... [20:20:49] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: prevent the get property from non-object error - https://phabricator.wikimedia.org/T318837 (10Eileenmcnaughton) OH - is this not a new bug but one that we have had for a while but it was never a priority pre chaos crew? [20:28:57] 10Fundraising-Backlog: Figure out what to do with CHARGEBACK_REVERSED Adyen ipns - https://phabricator.wikimedia.org/T318175 (10Dwisehaupt) [20:32:13] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [20:32:32] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10FR-Email: Make unsubscribe work in EmailPreferences, delete Unsub extension - https://phabricator.wikimedia.org/T223330 (10Ejegg) [20:37:13] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [20:39:16] 10Fundraising-Backlog, 10FR-Adyen: Remove Adyen WSDL classes and related code in Api.php and PaymentProvider classes - https://phabricator.wikimedia.org/T317837 (10Dwisehaupt) [20:42:09] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [20:42:09] 10Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig, 10Patch-For-Review: Use REST endpoint for createPayment API call - https://phabricator.wikimedia.org/T317834 (10Dwisehaupt) [20:43:45] 10Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: Make Adyen IPN listener understand JSON messages - https://phabricator.wikimedia.org/T317833 (10Dwisehaupt) [20:46:26] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Add Idempotency headers to PayPal EC API calls - https://phabricator.wikimedia.org/T317696 (10Ejegg) https://developer.paypal.com/docs/archive/express-checkout/integration-guide/ec-related-ops/#idempotency [20:47:13] PROBLEM - check_mysql on frdb2003 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [20:49:48] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Add Idempotency headers to PayPal EC API calls - https://phabricator.wikimedia.org/T317696 (10Ejegg) Looks like we just add an extra 'MsgSubId' field and deal with the potential warnings in the error code section of the response. [20:50:09] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Add Idempotency headers to PayPal EC API calls - https://phabricator.wikimedia.org/T317696 (10Dwisehaupt) [20:55:43] (03PS11) 10Damilare Adedoyin: Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) [21:02:13] RECOVERY - check_mysql on frdb2003 is OK: Uptime: 969107 Threads: 5 Questions: 476565497 Slow queries: 407 Opens: 3668 Open tables: 1463 Queries per second avg: 491.757 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2003&service=check_mysql [21:33:39] 10Fundraising-Backlog, 10FR-Smashpig: PredisCache should serialize/deserialize values - https://phabricator.wikimedia.org/T318638 (10Ejegg) [21:38:26] (03CR) 10Ejegg: [C: 04-1] "I think we want success in more cases, and also not to rely on the payments-init row existing." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/837743 (https://phabricator.wikimedia.org/T316587) (owner: 10Wfan) [21:52:01] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) (owner: 10Damilare Adedoyin) [22:03:37] (03Merged) 10jenkins-bot: Tests for Adyen Pending Transaction Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/833444 (https://phabricator.wikimedia.org/T316588) (owner: 10Damilare Adedoyin) [22:10:06] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.38-notes (1.38.0-wmf.4; 2021-10-12), 10Patch-For-Review, 10Performance-Team (Radar): Reduce module registration overhead from CentralNotice - https://phabricator.wikimedia.org/T221805 (10Krinkle) [22:17:45] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.38-notes (1.38.0-wmf.4; 2021-10-12), 10Patch-For-Review, 10Performance-Team (Radar): Reduce module registration overhead from CentralNotice - https://phabricator.wikimedia.org/T221805 (10Krinkle) >>! Task description: > As of April 2019,... [22:17:53] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.38-notes (1.38.0-wmf.4; 2021-10-12), 10Patch-For-Review, 10Performance-Team (Radar): Reduce module registration overhead from CentralNotice - https://phabricator.wikimedia.org/T221805 (10Krinkle) p:05Triageβ†’03Medium [22:18:05] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.38-notes (1.38.0-wmf.4; 2021-10-12), 10Patch-For-Review, 10Performance-Team (Radar): Reduce module registration overhead from CentralNotice - https://phabricator.wikimedia.org/T221805 (10Krinkle) [23:52:17] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Adyen: add email address for subsequent recurring donations - https://phabricator.wikimedia.org/T318851 (10Cstone) Hi @MBeat33 the fix in T316404 will add email too, we charged 35883142 on Oct 1 with LTVSSSQ5KD33FKG2. If you look th... [23:52:47] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Donor with over 28 charges in Civi after single donation was made - https://phabricator.wikimedia.org/T319203 (10Cstone) a:03Cstone [23:55:38] (03CR) 10Jsn.sherman: [C: 03+1] "We got the go-ahead to +2 this since it's so low risk." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/835663 (https://phabricator.wikimedia.org/T311717) (owner: 10Scardenasmolinar) [23:59:15] (03CR) 10Jsn.sherman: [C: 03+2] Add description for Special:Preferences layout [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/835663 (https://phabricator.wikimedia.org/T311717) (owner: 10Scardenasmolinar)