[00:36:02] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices, 10Patch-For-Review: Adyen iframe config error messages inside card fields - https://phabricator.wikimedia.org/T292571 (10AnnWF) todo: ask donor relation to do some generic trouble shooting test [00:51:36] AndyRussG: oh right, so there are two parts to the global gitignore - the file itself (which can be named anything) and the pointer to it in .gitconfig's [core] excludesfile https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/ [01:16:25] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Back again but from donations queue consumer: INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found - https://phabricator.wikimedia.org/T320587 (10Cstone) [01:16:43] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts, 10Patch-For-Review: INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found failmail coming from the listener on ideal - https://phabricator.wikimedia.org/T315031 (10Cstone) Current status: Duplicate iD... [01:18:06] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Something is causing a lot of deadlocks at :20 and :50 - https://phabricator.wikimedia.org/T320287 (10Cstone) [01:20:31] (03PS2) 10Ejegg: Setting for refund discrepancy alert threshold [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/841589 (https://phabricator.wikimedia.org/T319439) [01:22:26] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Due to high currency fluctuations, should we Refund amount mismatch more lenient - https://phabricator.wikimedia.org/T319439 (10Ejegg) OK @AnnWF, just uploaded patch set 2 which should work. [01:26:29] (03CR) 10Ejegg: "Nice to have the error handling! One suggestion for rethrow." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/840577 (https://phabricator.wikimedia.org/T292571) (owner: 10Wfan) [01:28:45] (03PS7) 10Wfan: Add try catch for adyen to catch if any adyen connection been blocked [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/840577 (https://phabricator.wikimedia.org/T292571) [01:38:53] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/840577 (https://phabricator.wikimedia.org/T292571) (owner: 10Wfan) [01:39:04] see you all tomorrow! [01:41:02] (03Merged) 10jenkins-bot: Add try catch for adyen to catch if any adyen connection been blocked [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/840577 (https://phabricator.wikimedia.org/T292571) (owner: 10Wfan) [05:04:24] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/841647 (owner: 10L10n-bot) [15:12:48] 10Fundraising Tech - Chaos Crew: Document contribution_tracking contibution_source tbl triggers - https://phabricator.wikimedia.org/T316898 (10Ejegg) a:03Ejegg [16:26:14] PROBLEM - check_procs on frdb1006 is CRITICAL: PROCS CRITICAL: 1688 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1006&service=check_procs [16:46:14] RECOVERY - check_procs on frdb1006 is OK: PROCS OK: 950 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1006&service=check_procs [18:07:02] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Back again but from donations queue consumer: INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found - https://phabricator.wikimedia.org/T320587 (10Ejegg) One of these was a PayPal donation where the donor seems to hav... [18:07:14] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: check_endpoints_critical (Adyen:1) 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [18:12:14] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [18:19:52] (03PS1) 10Ejegg: Use ::class to set $maintClass [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/841960 [18:20:13] fr-tech that patch is just nice to have but would be good to review before it goes stale ^^^ [18:20:55] ah nice ejegg I can test that [18:21:11] Thanks! Shouldn't need to run 'em all, just one or two [18:21:18] and peek at the file edits in gerrit [18:21:28] I just tested with ConsumePendingQueue locally [18:21:50] oh I guess I should test with one in a different namespace from MaintenanceBase [18:22:09] (03CR) 10CI reject: [V: 04-1] Use ::class to set $maintClass [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/841960 (owner: 10Ejegg) [18:22:19] awww [18:22:43] aha, single colon in one of em [18:23:11] (03PS2) 10Ejegg: Use ::class to set $maintClass [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/841960 [18:23:26] anyway, the Adyen test connectivity script still works with the edit [18:23:34] so I'd bet the rest of 'em will be fine [18:35:40] hmmm, looking at more of those paypal / recurring / no token ones [18:36:01] I think we do want to reset the order ID on recurring change [18:38:58] hmm ejegg should that be another ticket for paypal ones then? [18:39:32] could be [18:48:15] (03PS1) 10Ejegg: WIP add donorwiki service [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) [18:48:22] (03CR) 10Cstone: [C: 03+2] "Looks good!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/841960 (owner: 10Ejegg) [18:48:30] thanks cstone ! [18:49:13] (03PS1) 10Ejegg: Drop support for imports from STOMP queues [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/841987 [18:49:17] (03Merged) 10jenkins-bot: Use ::class to set $maintClass [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/841960 (owner: 10Ejegg) [19:03:01] 10Fundraising Tech - Chaos Crew: Document contribution_tracking contibution_source tbl triggers - https://phabricator.wikimedia.org/T316898 (10Ejegg) New process documented at https://wikitech.wikimedia.org/wiki/Fundraising#Contribution_tracking TODO: split the whole 'Data and Flow' chunk of that main page into... [19:12:18] (03PS2) 10Ejegg: Adyen: Return array on errors in getCheckoutConfiguration [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/753600 (https://phabricator.wikimedia.org/T295149) [19:14:41] (03CR) 10CI reject: [V: 04-1] Adyen: Return array on errors in getCheckoutConfiguration [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/753600 (https://phabricator.wikimedia.org/T295149) (owner: 10Ejegg) [19:16:27] oh dang, there is already code to reset the order ID on recurring change [19:16:58] but it's annoyingly complicated [19:17:14] i definitely wrote that... [19:19:09] (03PS3) 10Ejegg: Adyen: Return array on errors in getCheckoutConfiguration [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/753600 (https://phabricator.wikimedia.org/T295149) [19:26:08] hey fundraising, service ops SRE here -- did Special:FundraiserRedirector change recently? these two tests started failing, just want to make sure it's intended: https://gerrit.wikimedia.org/r/plugins/gitiles/operations/puppet/+/refs/heads/production/modules/profile/files/httpbb/appserver/test_foundation.yaml#24 [19:27:21] fr-tech ^ [19:28:18] the test expects a 302 to https://donate.wikimedia.org/w/index.php?title=Special:LandingPage&[...] and we just started getting https://donate.wikimedia.org/w/index.php?title=Special:FundraiserRedirector&reloaded=true for the first test URL there [19:28:22] and https://donate.wikimedia.org/w/index.php?title=Special:FundraiserRedirector&rdfrom=%2F%2Ffoundation.wikimedia.org%2Fw%2Findex.php%3Ftitle%3DFundraising%26redirect%3Dno&reloaded=true for the second [19:31:49] rzl I don't know of any changes but others might, if no one else responds soon I can make a phab for it [19:33:47] cstone: thanks :) fwiw the test failure correlated with the 1.40.0-wmf.5 rollout to group1 which includes donatewiki [19:34:34] rzl yep, that change was expected [19:36:02] perfect thanks! I'll just update those tests to assert on the new URLs, if that'll be reasonably stable -- open to other recommendations though [19:36:30] (fwiw the intent of the tests is just to verify our apache configs are doing the right thing -- but you inevitably catch some app-layer behavior that way too) [19:50:38] 10Fundraising-Backlog, 10fr-donorservices: ENO browser extension incompatible with donation form? - https://phabricator.wikimedia.org/T320677 (10AMJohnson) [20:50:58] 10Fundraising-Backlog, 10fr-donorservices: ENO browser extension incompatible with donation form? - https://phabricator.wikimedia.org/T320677 (10Ejegg) I would imagine it's only for one of our credit card processors, not both, since they have very different card inputs (one big Ingenico hosted iframe vs iframe... [20:59:05] 10Fundraising-Backlog: GPAY slow settlements - https://phabricator.wikimedia.org/T320580 (10EMartin) Further to this issue, we are seeing that most of these GPay authed but not settled transactions have been stopped due to no match on AVS and CVV:{F35565057}. Many of these transactions have been stopped in our... [21:00:01] 10Fundraising-Backlog: GPAY slow settlements - https://phabricator.wikimedia.org/T320580 (10EMartin) Given the conversion rate on Gpay is at 97% I am closing this as I expect many of these Gpay transactions stopped at Authorization are fraud related. [21:00:15] 10Fundraising-Backlog: GPAY slow settlements - https://phabricator.wikimedia.org/T320580 (10EMartin) 05Open→03Resolved a:03EMartin [21:28:33] (03PS4) 10Ejegg: Push donor details up to PaymentDetailResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/836325 (https://phabricator.wikimedia.org/T318867) [21:28:35] (03PS3) 10Ejegg: Implement GetExpressCheckoutDetails for PayPal EC [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/839844 (https://phabricator.wikimedia.org/T318867) [21:30:47] (03CR) 10CI reject: [V: 04-1] Implement GetExpressCheckoutDetails for PayPal EC [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/839844 (https://phabricator.wikimedia.org/T318867) (owner: 10Ejegg) [21:33:31] (03PS4) 10Ejegg: Implement GetExpressCheckoutDetails for PayPal EC [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/839844 (https://phabricator.wikimedia.org/T318867) [21:33:35] (03PS1) 10Ejegg: Always log PayPal EC API response at debug level [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/842012 [22:47:54] 10Fundraising Sprint Quarkery, 10Fundraising-Backlog, 10Epic: Upgrading payments-wiki from buster to bullseye - https://phabricator.wikimedia.org/T315585 (10Dwisehaupt) [22:48:13] cstone: OK, I'll make another ticket for that order_id reset - i think the fix is pretty easy [22:50:51] rebooting payments1005 for kernel upgrade. no side effects expected. [22:53:29] and it's back. [22:56:11] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Order ID regeneration on recurring change is not functioning, leads to missing token failmail. - https://phabricator.wikimedia.org/T320686 (10Ejegg) [22:57:10] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Back again but from donations queue consumer: INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found - https://phabricator.wikimedia.org/T320587 (10Ejegg) Ticket for the incomplete session reset bug: T320686 [23:10:43] oops, lots of TY failures [23:12:47] dang, lots of Cannot instantiate malformed locale: en [23:12:57] so where are we setting that [23:13:15] ohhh, trxn id starts with ENGAGE [23:13:21] imported, I guess? [23:13:47] 10Fundraising-Backlog, 10fr-donorservices: ENO browser extension incompatible with donation form? - https://phabricator.wikimedia.org/T320677 (10EMartin) 1185556 - came in through Adyen 1186212 - came in through Adyen 1185137 - came in through Adyen 1184943 - came in through Adyen I will see if Adyen has any a...