[00:20:40] (03PS1) 10Ejegg: Avoid loading external scripts on error forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/842546 [00:22:46] (03CR) 10CI reject: [V: 04-1] Avoid loading external scripts on error forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/842546 (owner: 10Ejegg) [00:24:02] (03PS2) 10Ejegg: Avoid loading external scripts on error forms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/842546 [00:58:00] (03PS1) 10Ejegg: Catch errors in setClientVariables [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/842549 (https://phabricator.wikimedia.org/T295149) [01:00:03] (03CR) 10CI reject: [V: 04-1] Catch errors in setClientVariables [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/842549 (https://phabricator.wikimedia.org/T295149) (owner: 10Ejegg) [01:00:40] (03PS2) 10Ejegg: Catch errors in setClientVariables [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/842549 (https://phabricator.wikimedia.org/T295149) [01:05:16] (03PS1) 10Ejegg: Show error form when error in getPaymentMethods [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/842550 (https://phabricator.wikimedia.org/T295149) [01:06:31] (03Abandoned) 10Ejegg: Catch exceptions setting up Adyen page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/842540 (https://phabricator.wikimedia.org/T293131) (owner: 10Ejegg) [01:07:41] ejegg: heyyy how's it going...? If you'll be around for the next 15 minutes or so I should have that CN ESI patch ready, if you'd like to quickly review [01:08:10] Hi AndyRussG I'm just writing my end of day email - but that'll probably take me 15 minutes :) [01:08:11] sorry for the delay... many cooking and housework and kid care stuff.......... [01:08:34] ok if you have time it'll be great, no worries if not! thx in advance in either case! [01:13:20] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices, 10Patch-For-Review: Adyen: recent 'MediaWiki internal error - fatal exception' errors - https://phabricator.wikimedia.org/T293131 (10Ejegg) a:03Ejegg [01:15:22] 10Fundraising Sprint Visual C Saw, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fundraising sprint Universal Cereal Bus, 10Patch-For-Review: Payment session lost causing error page throwing exception - https://phabricator.wikimedia.org/T295149 (10Ejegg) These should be solved by the same pat... [01:22:07] (03PS1) 10AndyRussG: Add ESI test string to base HTML [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/842552 (https://phabricator.wikimedia.org/T320734) [01:22:19] ejegg: ^ :) :) :) [01:22:44] looking [01:24:19] Comment in code says T308799 but Bug: tag is T320734 ? [01:24:20] T320734: CentralNotice: Add ESI test string to base HTML - https://phabricator.wikimedia.org/T320734 [01:24:20] T308799: Test ESI feasibility with current Varnish installation - https://phabricator.wikimedia.org/T308799 [01:24:51] oh i see [01:24:54] ejegg: its the parent task with more explanation [01:25:21] I could have included both tags but really the child task is so trivial, has no more info than the commit message... [01:25:43] if someone wants to know the purpose of that bit, really the parent task is the place to go [01:25:55] ok, cool [01:26:08] so the var will be set to something like [01:26:21] yeeeee savouring the day when finally there is no more banner bump, ever [01:26:37] or looking forward to doing so, rather ;p [01:26:39] well, it looks like a pretty harmless patch in itself! [01:26:48] bwahahaha [01:26:54] * AndyRussG counts unhatched chickens [01:27:34] also yes the var will be set to exactly that, via a separate config patch [01:27:36] (03CR) 10Ejegg: [C: 03+2] "Looks like a nice safe way to start testing!" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/842552 (https://phabricator.wikimedia.org/T320734) (owner: 10AndyRussG) [01:27:56] ok, i'mma head out for the weekend. have a good one! [01:28:03] cool beans thanks so much! and apologies for asking u to stay late... yeah have fun! :) [01:28:05] thx again :) [01:28:41] oh hah, I never finished that payments deploy I wanted to do [01:28:54] ...and my wife is talking with her mom. Guess I'll stay on a lil longer :) [01:28:57] ejegg: would you like me to do it? [01:29:08] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/842555 [01:29:09] I've finished most of my non-work for the day.... [01:29:18] AndyRussG: sure... if you don't mind! [01:29:28] should be very low-risk [01:29:34] yeah for sure [01:29:39] The merge to DonationInterface deploy is all done [01:29:41] (03Merged) 10jenkins-bot: Add ESI test string to base HTML [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/842552 (https://phabricator.wikimedia.org/T320734) (owner: 10AndyRussG) [01:29:44] and there's no need for a vendor update [01:30:17] this was the merge: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/842530 [01:31:05] one change that's only hit in the paypal orphan rectifier, and has already been deployed under CRM [01:31:26] oki [01:31:35] k yep I can push that out tonite [01:31:42] thanks! [01:32:04] one change should add more error handling to the Adyen forms [01:32:25] and one change fixes the order_id reset when recurring changes from 0 to 1 or vice versa [01:32:44] oki [01:34:12] oh hmm, maybe that error handling needs more testing [01:34:22] AndyRussG: sorry... let's maybe not do it right now? [01:34:48] (03Abandoned) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/842555 (owner: 10Ejegg) [01:35:01] ejegg: ah hmm oki also fine [01:36:00] this one, right ejegg? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/840577 [01:36:09] yeah [01:37:35] oki any one-sentence explanations of what specifically might need more testing, or why you think it's the case, that I could bring up tomorrow? [01:37:37] Looks like onError is actually triggered by empty card fields, and we don't want to show the failed payment error message for that - just highlight the card fields, which is what the code did previously [01:37:51] Lemme see if I can do a superquick fix [01:51:31] (03PS1) 10Ejegg: Don't show general error on incomplete fields [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/842557 (https://phabricator.wikimedia.org/T292571) [01:52:24] ack, that's not quite sufficient [01:52:35] there are more error codes we don't want to trigger that on [01:52:41] darn it, I might have to revert that [01:53:23] ejegg: don't worry I imagine it's fine if we don't deploy a fix for that bug until Monday, no? [01:53:37] AndyRussG: right, it should be OK [01:53:47] I just feel bad leaving the deployment branch in a risky state [01:53:54] or if it's super urgent we can figure it out tomorrow and just cherry-pick deploy [01:54:08] no, nothing urgent [01:54:11] it's okok it happens :) [01:55:08] if any urgent deploys come up that do need to go out before Monday we'll take this into account, all good :) [02:03:10] (03CR) 10Ejegg: [C: 03+2] "Sorry I didn't test this well enough! It turns out we had a good reason not to set the onError handler before - it is fired for a lot of t" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/840577 (https://phabricator.wikimedia.org/T292571) (owner: 10Wfan) [02:06:15] (03PS2) 10Ejegg: Adyen: Don't show general error on validation fail [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/842557 (https://phabricator.wikimedia.org/T292571) [02:08:13] (03CR) 10CI reject: [V: 04-1] Adyen: Don't show general error on validation fail [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/842557 (https://phabricator.wikimedia.org/T292571) (owner: 10Ejegg) [02:11:11] (03PS3) 10Ejegg: Adyen: Don't show general error on validation fail [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/842557 (https://phabricator.wikimedia.org/T292571) [02:11:21] ok AndyRussG that might actually do it ^^^ [02:12:57] ejegg: okiii I don't know that I can confidently get my head into that space this evening to the degree of feeling comfortable +2ing something...? so tomorrow we'll go at it, sound okok? [02:13:11] sure thing, thanks! [02:13:49] thank u!!!! :) [14:23:21] 10Fundraising-Backlog, 10fundraising-tech-ops: Fix duplicate entries in pgehres tables so we can convert them to utf8mb4 - https://phabricator.wikimedia.org/T277484 (10Jgreen) [14:23:23] 10Fundraising-Backlog: pgehres: Remove obviously incorrect rows from lookup tables - https://phabricator.wikimedia.org/T198639 (10Jgreen) [14:28:26] 10Fundraising-Backlog, 10fundraising-tech-ops: Fix duplicate entries in pgehres tables so we can convert them to utf8mb4 - https://phabricator.wikimedia.org/T277484 (10Jgreen) >>! In T277484#8315657, @Ejegg wrote: > let's delete all the rows if they're supposed to be countries or languages and aren't actually... [15:08:53] (03CR) 10AndyRussG: [V: 03+2] Memcached purge script [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/835638 (owner: 10AndyRussG) [15:23:15] (03CR) 10Jgleeson: [C: 03+2] "Thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/839844 (https://phabricator.wikimedia.org/T318867) (owner: 10Ejegg) [15:24:10] (03Merged) 10jenkins-bot: Implement GetExpressCheckoutDetails for PayPal EC [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/839844 (https://phabricator.wikimedia.org/T318867) (owner: 10Ejegg) [15:34:20] (03CR) 10Jgleeson: Add support for SMTP to SmashPig's MailHandler (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/837136 (https://phabricator.wikimedia.org/T318831) (owner: 10Jgleeson) [15:35:22] (03PS9) 10Jgleeson: Add support for SMTP to SmashPig's MailHandler [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/837136 (https://phabricator.wikimedia.org/T318831) [15:42:26] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Adyen, 10fr-donorservices, and 2 others: Adyen iframe config error messages inside card fields - https://phabricator.wikimedia.org/T292571 (10AndyRussG) Moved this back to backlog because it seems another patch is needed. From an e-mail by @Ejegg... [15:46:44] 10Fundraising Sprint Solid State Spaghetti, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.40-notes (1.40.0-wmf.6; 2022-10-17): CentralNotice: Add ESI test string to base HTML - https://phabricator.wikimedia.org/T320734 (10AndyRussG) [15:50:38] (03CR) 10Wfan: [C: 03+2] "Looks good to me, and thanks that now we can check Refund discrepancy alert factor at https://wmff.localhost:32353/civicrm/admin/setting/w" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/841589 (https://phabricator.wikimedia.org/T319439) (owner: 10Ejegg) [15:54:46] (03CR) 10Wfan: [C: 03+2] "Thanks Elliott for catching this one, and I agree that most of those common error should not shown the general error above." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/842557 (https://phabricator.wikimedia.org/T292571) (owner: 10Ejegg) [15:55:18] (03CR) 10Jgleeson: [C: 04-2] "Looks like $response is coming back as an array. I'm getting failmail locally due to it being treated as a string." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/842012 (owner: 10Ejegg) [15:58:23] 10Fundraising Sprint Solid State Spaghetti, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MW-1.40-notes (1.40.0-wmf.6; 2022-10-17): CentralNotice: Add ESI test string to base HTML - https://phabricator.wikimedia.org/T320734 (10AndyRussG) a:03AndyRussG [16:04:49] (03Merged) 10jenkins-bot: Setting for refund discrepancy alert threshold [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/841589 (https://phabricator.wikimedia.org/T319439) (owner: 10Ejegg) [16:10:27] (03Merged) 10jenkins-bot: Adyen: Don't show general error on validation fail [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/842557 (https://phabricator.wikimedia.org/T292571) (owner: 10Ejegg) [16:46:58] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Civimail - send now error - https://phabricator.wikimedia.org/T320821 (10Pcoombe) [16:49:40] fr-tech FYI Jayme made the above as Unbreak Now, but hadn't added project tags [16:52:46] looking pcoombe [17:34:40] 10Fundraising-Backlog: Clean up our two-character locale data - https://phabricator.wikimedia.org/T320829 (10jgleeson) [17:39:05] 10Fundraising-Backlog: Clean up our two-character locale data - https://phabricator.wikimedia.org/T320829 (10Damilare) Searchkit search: https://civicrm.wikimedia.org/civicrm/admin/search#/edit/628 [17:39:50] 10Fundraising-Backlog: Clean up our two-character locale data - https://phabricator.wikimedia.org/T320829 (10jgleeson) We should probably also check for any other locales which don't meet the regex requirement in the fn conditional [17:45:11] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Civimail - send now error - https://phabricator.wikimedia.org/T320821 (10jgleeson) We fixed this live on our call today [17:53:11] 10Fundraising-Backlog: Add Unit Test Coverage for Smashpig's MailHandler code - https://phabricator.wikimedia.org/T320832 (10jgleeson) [17:54:09] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Civimail - send now error - https://phabricator.wikimedia.org/T320821 (10AnnWF) those contact's prefer language code set to en not en_US, fixed couple of contacts manually today, but still need to write some patch to catch the error in the future~ [17:54:39] (03CR) 10Jgleeson: Add support for SMTP to SmashPig's MailHandler (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/837136 (https://phabricator.wikimedia.org/T318831) (owner: 10Jgleeson) [18:58:35] fr-tech: as mentioned, i'm pulling frmx1001 from the email flow for upgrade. [19:03:36] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Civimail - send now error - https://phabricator.wikimedia.org/T320821 (10Cstone) Three donors in this group had bad preferred_languages, two of en and one of zh_hans. We updated the languages to the right ones (en_US, zh_CN) for everyone in the group so... [19:04:01] whoops my phab didnt update that others also updated itt hah triple update [19:13:32] thanks Christine for this ticket update haha [19:13:43] sorry to like write the same thing you wrote [19:16:22] haha you had the zh_CN one 😃 [19:22:43] 10Fundraising Tech - Chaos Crew: 'is' is not a valid option for field preferred_language - https://phabricator.wikimedia.org/T320836 (10AnnWF) [19:24:54] 10Fundraising Tech - Chaos Crew: 'is' is not a valid option for field preferred_language - https://phabricator.wikimedia.org/T320836 (10AnnWF) [19:48:36] 10Fundraising-Backlog, 10fr-donorservices: ENO browser extension incompatible with donation form? - https://phabricator.wikimedia.org/T320677 (10AMJohnson) Interesting! Thanks for the additional context @Ejegg. [20:46:25] frmx1001 is upgraded and back in service. just turned the jobs back on so mail will flow through there. [22:15:38] 10fundraising-tech-ops: reimage fundraising frmx role servers to Bullseye - https://phabricator.wikimedia.org/T316725 (10Dwisehaupt) [22:15:59] 10fundraising-tech-ops: reimage fundraising frmx role servers to Bullseye - https://phabricator.wikimedia.org/T316725 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt frmx1001 rebuilt. closing. [22:16:01] 10fundraising-tech-ops: Fundraising environment support for Debian 11 (Bullseye) - https://phabricator.wikimedia.org/T277184 (10Dwisehaupt) [22:40:53] 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, and 4 others: configure endpoint monitoring for Braintree API hosts - https://phabricator.wikimedia.org/T311727 (10Dwisehaupt... [22:40:55] 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Braintree-Integration: Network configuration for Braintree integration - https://phabricator.wikimedia.org/T303457 (10Dwisehaupt) [22:55:08] 10fundraising-tech-ops: Reevaluate fundraising grafana proxy configuration - https://phabricator.wikimedia.org/T320560 (10Dwisehaupt) Docs to reference if we need. https://grafana.com/tutorials/run-grafana-behind-a-proxy/ [23:49:07] (03CR) 10Wfan: [C: 03+2] "Tested locally, and LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/842550 (https://phabricator.wikimedia.org/T295149) (owner: 10Ejegg)