[00:10:53] (03PS10) 10Damilare Adedoyin: WIP: Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) [00:20:49] (03PS11) 10Damilare Adedoyin: WIP: Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) [01:25:10] (03PS1) 10Ejegg: Update DonationInterface [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/849723 [01:25:13] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/849723 (owner: 10Ejegg) [01:34:20] (03Merged) 10jenkins-bot: Update DonationInterface [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/849723 (owner: 10Ejegg) [01:47:31] !log payments-wiki upgraded from 4f923066 to 61cf970b [01:47:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:22:06] oho, looks like mw-vagrant is getting Mac silicon support: https://gerrit.wikimedia.org/r/c/mediawiki/vagrant/+/844932 [02:22:59] (03CR) 10Eileen: [C: 03+2] "Nice - this has a test now which was the only hesitation earlier" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844080 (owner: 10Ejegg) [02:30:15] (03PS1) 10Eileen: Update email_greeting template to handle missing first name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/849725 (https://phabricator.wikimedia.org/T321691) [02:35:22] (03Merged) 10jenkins-bot: Avoid stack overflow in Contact ShowMe [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844080 (owner: 10Ejegg) [06:09:05] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/849801 (owner: 10L10n-bot) [07:20:58] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/849801 (owner: 10L10n-bot) [09:03:49] (03CR) 10Kosta Harlan: Update email_greeting template to handle missing first name (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/849725 (https://phabricator.wikimedia.org/T321691) (owner: 10Eileen) [16:00:51] 10Fundraising-Backlog, 10FR-MW-Vagrant, 10MediaWiki-Vagrant, 10SRE: Package XDebug 2.9 for apt.wikimedia.org - https://phabricator.wikimedia.org/T220406 (10Tgr) 05Open→03Invalid After {T271649} and the switch to PHP 7.4, Vagrant now uses XDebug 3. [17:08:15] (03CR) 10Wfan: [C: 03+2] Update Symfony/Yaml and fix maps and tests [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/849208 (https://phabricator.wikimedia.org/T321621) (owner: 10Ejegg) [17:08:53] (03Merged) 10jenkins-bot: Update Symfony/Yaml and fix maps and tests [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/849208 (https://phabricator.wikimedia.org/T321621) (owner: 10Ejegg) [17:10:39] 10Fundraising-Backlog, 10fr-donorservices: Deduper Interface - https://phabricator.wikimedia.org/T321843 (10SHust) [17:37:15] 10Fundraising-Backlog, 10fr-donorservices: Make the CID visible when mousing over the person icon - https://phabricator.wikimedia.org/T321849 (10SHust) [17:38:50] 10Fundraising-Backlog, 10fr-donorservices: Addition to the Deduper Interface - https://phabricator.wikimedia.org/T321843 (10SHust) [18:41:40] thanks for the review wfan [18:41:53] np :) [18:41:55] I'll tag another version of SmashPig and make the corresponding updates in DonationInterface [18:48:25] (03PS1) 10Ejegg: Update smash-pig and yaml libraries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/850255 [18:49:26] (03CR) 10CI reject: [V: 04-1] Update smash-pig and yaml libraries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/850255 (owner: 10Ejegg) [18:49:31] (03CR) 10Jsn.sherman: [C: 03+2] "Recalling a past conversation with agreen, I think we can +2 this ourselves since it doesn't impact any banner functionality." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/849199 (https://phabricator.wikimedia.org/T317419) (owner: 10Scardenasmolinar) [18:51:40] (03CR) 10CI reject: [V: 04-1] Add PreferencesGetIconHook [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/849199 (https://phabricator.wikimedia.org/T317419) (owner: 10Scardenasmolinar) [18:55:43] darn, it looks like we need to update symfony/event-dispatcher as well [18:56:37] since the newer versions of symfony/console conflict with older versions of event-dispatcher [19:02:45] so... what exactly are we using that event-dispatcher for??? [19:03:58] errr, nothing??? [19:04:47] tests all pass without it [19:04:57] Can't find anything in the SmashPig code using it [19:11:05] (03PS1) 10Ejegg: Remove unused event-dispatcher library [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/850258 [19:11:18] wfan do you have a minute to look at ^^^ ? [19:11:29] There is no mention of EventDispatcher in any of our code [19:11:40] 👌 [19:11:48] and even looking in the git log I only find it in the vendor directory [19:12:00] so I'm pretty sure we can safely remove that library [19:16:53] (03CR) 10Wfan: [C: 03+2] "yeah, confirmed that we are not using Symfony\Component\EventDispatcher\EventDispatcher anywhere under smashpig, can be removed" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/850258 (owner: 10Ejegg) [19:17:26] (03Merged) 10jenkins-bot: Remove unused event-dispatcher library [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/850258 (owner: 10Ejegg) [19:18:33] woo for removing things [19:21:16] thanks wfan! [19:21:59] :) np thanks for looking for that~ [19:23:34] (03PS2) 10Ejegg: Update smash-pig and yaml libraries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/850255 [19:24:41] oops, gotta head out for a bit [19:25:11] orrr... maybe not yet? [19:26:33] (03CR) 10Ejegg: [C: 04-2] "Looks like this was maybe a bad merge?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/829025 (owner: 10Wfan) [19:27:03] (03Abandoned) 10Wfan: Merge branch 'master' of https://gerrit.wikimedia.org/r/p/mediawiki/extensions/DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/829025 (owner: 10Wfan) [19:27:12] yep, abandon that one now [19:30:31] :) [19:31:01] ok, looks like I can get composer to install with that [19:31:12] and... I will have to go afk for a bit [19:41:02] (03Abandoned) 10Wfan: For Thank you letter, instead of the civi shorter verison currency use full 3 digital currency [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/788447 (https://phabricator.wikimedia.org/T306576) (owner: 10Wfan) [20:12:11] (03PS1) 10Cstone: Add catch for when exchange rate is empty [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/850265 [20:14:05] (03CR) 10CI reject: [V: 04-1] Add catch for when exchange rate is empty [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/850265 (owner: 10Cstone) [20:14:53] (03PS2) 10Cstone: Add catch for when exchange rate is empty [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/850265 [20:15:28] ^ added that cause its really spamming up the audit logs with divide by 0 warnings [20:22:55] 10Fundraising-Backlog, 10fr-donorservices: Make the CID visible when mousing over the person icon - https://phabricator.wikimedia.org/T321849 (10Eileenmcnaughton) @shust the field on that screen are configured in the UI - I just added it https://civicrm.wikimedia.org/civicrm/admin/uf/group/field?reset=1&action... [20:23:20] 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising-Backlog, 10fr-donorservices: Make the CID visible when mousing over the person icon - https://phabricator.wikimedia.org/T321849 (10Eileenmcnaughton) [20:42:38] (03CR) 10Ejegg: [C: 03+2] Update smash-pig and yaml libraries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/850255 (owner: 10Ejegg) [20:43:22] ejegg|afk: are you going to be deploying smashpig in civi today? [20:43:44] cstone: I could! [20:43:55] I just have a small patch to stop spammy audit lines [20:44:04] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/850265/ [20:44:16] the amex transactions come in with no exchange rate [20:44:41] (03CR) 10Ejegg: [C: 03+2] Add catch for when exchange rate is empty [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/850265 (owner: 10Cstone) [20:45:00] man, that Amex stuff just keeps giving us more headaches [20:45:08] yeah its really interseting the weekly ONLY has apple pay ame [20:45:09] x [20:45:12] the nightly has all of them [20:45:14] (03Merged) 10jenkins-bot: Add catch for when exchange rate is empty [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/850265 (owner: 10Cstone) [20:45:34] did you see this ask? T321611 [20:45:34] T321611: AMEX needs to be established as it's own gateway in Civi - https://phabricator.wikimedia.org/T321611 [20:45:48] I'm hoping we can get those reconciliation results some other way [20:46:04] yeah definitely cause its still so tied to adyen [20:47:56] ejegg theres this one too not sure how much review time you have but you looked at it a little so far https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/849139 [20:48:20] Oh sure, I can look at that too [20:48:25] thanks! [20:48:27] sorry, I assumed someone else was on it [20:48:36] no worries [20:56:09] ok, I'll tag more versions [20:56:36] hah sorry to find that right after you just tagged it [20:58:29] np, the matching DI patch hadn't merged yet [20:59:25] (03PS3) 10Ejegg: Update smash-pig and yaml libraries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/850255 [20:59:32] (03CR) 10Ejegg: [C: 03+2] Update smash-pig and yaml libraries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/850255 (owner: 10Ejegg) [20:59:57] oops, lemme fix the extension version number in the json too [21:00:52] 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising-Backlog, 10fr-donorservices: Make the CID visible when mousing over the person icon - https://phabricator.wikimedia.org/T321849 (10SHust) WOW, thanks a million! @Eileenmcnaughton [21:00:59] (03PS4) 10Ejegg: Update smash-pig and yaml libraries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/850255 [21:01:07] (03CR) 10Ejegg: [C: 03+2] Update smash-pig and yaml libraries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/850255 (owner: 10Ejegg) [21:03:20] (03Merged) 10jenkins-bot: Update smash-pig and yaml libraries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/850255 (owner: 10Ejegg) [21:12:29] ugh, more composer version conflicts over in crm-land [21:16:20] arrrrrgh drush needs "symfony/yaml": "~2.3|^3|^4.4", [21:16:32] okayyyy so let's see if we can make that work [21:24:05] sweet. the change i submitted has the jenkins package checks working again. [21:24:13] well, and alerting for a twig update. [21:28:11] (03CR) 10Wfan: [C: 03+2] Add check for gateway_txn_id to Adyen in the Pending Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/849139 (https://phabricator.wikimedia.org/T321602) (owner: 10Cstone) [21:28:33] thanks wfan ! [21:28:33] Ha remember this ticket, and forget to plus 2 when it's pass jenkins~ [21:28:35] npn [21:41:36] (03Merged) 10jenkins-bot: Add check for gateway_txn_id to Adyen in the Pending Resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/849139 (https://phabricator.wikimedia.org/T321602) (owner: 10Cstone) [22:08:18] ejegg|afk: i think i found a toggle for the frdev smashpig db that we are looking for. just wanted to verify that on the frdev* hosts we want to point the smashpig db handles at the "staging db" host. [22:08:34] the logic was a few levels above where i was looking in the template.