[02:18:05] (03PS1) 10Ejegg: Error handling for contribution forgetme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/851176 (https://phabricator.wikimedia.org/T321694) [02:23:06] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Acoustic Import: Job Status Failed - https://phabricator.wikimedia.org/T322059 (10Ejegg) Hi @LMedley-WMF, our job logs show that we successfully uploaded a 226MB file called Unsubscribes-20221031041641.csv at 2022-10-31 04:25:19 . Can you t... [02:32:10] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Acoustic Import: Job Status Failed - https://phabricator.wikimedia.org/T322059 (10LMedley-WMF) Hi @Ejegg, thanks for checking into this for us! We receive a daily email from Acoustic that details if the import jobs have been completed succes... [02:36:07] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Acoustic Import: Job Status Failed - https://phabricator.wikimedia.org/T322059 (10Ejegg) FR-tech is pretty good at figuring out anything up to the point of sending the data off to Acoustic. Once it's there, I think someone from Trilogy has t... [02:43:54] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Acoustic Import: Job Status Failed - https://phabricator.wikimedia.org/T322059 (10LMedley-WMF) Many thanks, Elliott! Sounds great, I will kindly check the next upload job tomorrow morning. Thank you for all of your help and guidance! [02:56:28] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Tech-Analytics: Differences between civicrm.wmf_donor table and Civi UI - https://phabricator.wikimedia.org/T321920 (10Eileenmcnaughton) So the first thing I wanted to check is whether the triggers were calculatin... [03:08:12] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Tech-Analytics: Differences between civicrm.wmf_donor table and Civi UI - https://phabricator.wikimedia.org/T321920 (10Eileenmcnaughton) OK - I was able to replicate this by actively selecting to copy over wmf_don... [03:30:37] (03PS2) 10Eileen: Update email_greeting template to handle missing first name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/849725 (https://phabricator.wikimedia.org/T321691) [04:07:58] (03CR) 10Eileen: "I got some warnings - am thinking this might by php version related - 8 might hate them less?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) (owner: 10Damilare Adedoyin) [04:13:47] (03CR) 10Eileen: "Dami - am trying to test this locally - so far looking promising but I am hitting some snaffus which are odd but probably not related." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) (owner: 10Damilare Adedoyin) [14:01:15] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Tech-Analytics: Differences between civicrm.wmf_donor table and Civi UI - https://phabricator.wikimedia.org/T321920 (10SHust) @Eileenmcnaughton a technical solution would definitely be the best route! [14:36:37] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Tech-Analytics: Differences between civicrm.wmf_donor table and Civi UI - https://phabricator.wikimedia.org/T321920 (10JMando) @Eileenmcnaughton I unfortunately do not know how many total rows are affected. I luck... [14:43:35] 10Fundraising-Backlog, 10fr-donorservices: Addition to the Deduper Interface - https://phabricator.wikimedia.org/T321843 (10jgleeson) Hey there @SHust, a bunch of us spoke yesterday about how awesome this feature request is. Thanks for taking the time to lay out the requirements the way you have. It's fantasti... [14:53:04] ejegg: I'm reviewing https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/851176 and wonder if you can tell me a good way to find an affected record based on the conditions you mention in the commit message? [14:53:39] Hi jgleeson! To get a simple one, just make a PayPal EC contribution via the local paymentswiki and consume queues [14:53:54] thanks [14:54:17] thank you for taking a look [14:54:55] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Acoustic Import: Job Status Failed - https://phabricator.wikimedia.org/T322059 (10Ejegg) Hi @LMedley-WMF, did you get another failure email today? [15:27:15] hmm ejegg I'm noticing some strangeness to this fix [15:30:12] it looks like "paypal_ec" being passed in to the smashpig context creation is having potentially unexpected consequences that fix the bug but however cause notices in the log due to smashpig expecting "paypal" [15:32:10] it's possible this is all intentional but it feels confusing if so [15:33:32] this might also be due to paypal not being the best gateway to test with [15:33:48] (03PS14) 10Damilare Adedoyin: WIP: Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) [15:34:06] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Civi: Forget Me button yields configuration error - https://phabricator.wikimedia.org/T321694 (10MBeat33) Thanks, @Ejegg I just tested the Forget Me button and got similar: {F35691457} [15:39:46] I'll leave some comments on the patch. The bug is fixed but the paypal_ec gateway path resulting in an empty $providerConfig and the follow-on exception makes me curious whether this is intentional [15:40:00] (03CR) 10Damilare Adedoyin: "Hi Eileen, I pushed up a file with demo rows for the smashpig damaged table. It would help in populating the smashpig database with data t" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) (owner: 10Damilare Adedoyin) [15:40:03] (03PS15) 10Damilare Adedoyin: Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) [15:46:39] 10Fundraising-Backlog, 10fr-donorservices: Addition to the Deduper Interface - https://phabricator.wikimedia.org/T321843 (10SHust) @jgleeson you made my day + I'm now hopeful that it can become a reality! Ty and the team :) [15:48:36] jgleeson: so there are other values that we record in that column (like engage) which will result in the same thing [15:48:54] yeah [15:49:19] I guess my first thought is the closeness of paypal_ec (failing) and paypal is dangerous [15:49:44] for paypal_ec -> paypal, I think we should handle that in the 'remapProvider' function in ProviderConfiguration [15:49:48] I also think that to avoid the php notice warnings on the array key check, we could just throw an exception is $providerConfig is null [15:50:01] where we are already remapping astropay -> dlocal and globalcollect -> ingenico [15:50:05] I'm noting as much on the ticket now [15:50:07] I'll add a SmashPig patch [15:50:24] in this case, the try / catch is explicitly to catch those errors [15:50:30] as I note in the comment above [15:50:48] yeah that makes sense but I feel like we could do it neater [15:50:55] without the php notice [15:51:30] with the existing SmashPig code? Or are you proposing a new function to check whether it's a valid name before instantiating? [15:51:52] lemme finish commenting on the patch, it'll be easier to follow [15:51:55] ok [15:52:43] the bug is fixed and this code is good. this is just nit pick to prevent php notices and be more explicit about throwing exceptions when we know code is going to fail [15:53:02] in one of the two scenarios that lead to the exception [15:53:34] ejegg: btw if you map paypal_ec to paypal, it will find the first method 'paypal' changing the existing behaviour of throwing an exception [15:54:06] yep, that'll be fine because the PayPalPaymentProvider doesn't implement IDeleteDataProvider [15:54:35] so the check done in both places where we call the fn will still return false [15:56:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Civi: Forget Me button yields configuration error - https://phabricator.wikimedia.org/T321694 (10Ejegg) @MBeat33 we've got a fix in review - I'll let you know when we have it deployed. [15:58:33] (03PS1) 10Ejegg: ProviderConfiguration: remap paypal_ec to paypal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/851662 [15:58:43] jgleeson: ok, there's the remap function ^^^ [16:02:27] (03PS1) 10Ejegg: Function to check for valid provider name [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/851664 [16:02:53] jgleeson: and there's a function we could use to check the name before instantiating the config ^^^ [16:03:18] (03PS2) 10Ejegg: Function to check for valid provider name [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/851664 [16:03:34] (03PS3) 10Ejegg: Function to check for valid provider name [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/851664 [16:03:54] (03CR) 10Jgleeson: "This is working great. thanks. I added a comment inline about we might make the exception scenarios more explicit in the code." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/851176 (https://phabricator.wikimedia.org/T321694) (owner: 10Ejegg) [16:03:58] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Civi: Forget Me button yields configuration error - https://phabricator.wikimedia.org/T321694 (10MBeat33) Many thanks! [16:04:52] ejegg: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/851176/1/drupal/sites/default/civicrm/extensions/wmf-civicrm/api/v3/Contribution/Forgetme.php#81 [16:05:12] ah yeah, good idea [16:05:35] (03PS2) 10Ejegg: Error handling for contribution forgetme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/851176 (https://phabricator.wikimedia.org/T321694) [16:05:42] ok, there's that check for empty ^^^ [16:05:45] sorry I shouldn't of tried to get into that on irc, too hard [16:05:51] shouldn't have* [16:06:11] I just had it return null directly rather than throwing the exception to be caught [16:07:25] So when I was writing that I had been assuming wmf_common_create_smashpig_context with a bad provider name would throw an exception [16:07:28] ejegg: the commit message threw me a little also. is 'cc' important here or is it just any payment method [16:07:59] jgleeson: just that the previous code had hard-coded 'cc' as the payment method to instantiate [16:08:02] yeah ejegg that makes sense [16:08:16] oh rly I didn't see that [16:08:34] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/851176/1/drupal/sites/default/civicrm/extensions/wmf-civicrm/api/v3/Contribution/Forgetme.php#b68 [16:08:42] jgleeson: hey quick question, for testing this patch, https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/845045, where should I be getting the value for the second argument (FLJLQ2GV38E4Y) from? [16:09:03] so far I've just been copying that from the commit message, and using a locally generated value for the first argument [16:09:06] AndyRussG: that comes back from the previous call as the PAYER_ID [16:09:34] ejegg: hmm ok.... that's not something that ever gets into our queue messages I guess, right? [16:09:38] also thx! [16:09:43] ejegg: line 68 ? [16:09:45] AndyRussG: no, it doesn't get sent to the queue [16:10:05] jgleeson: yep, line 68 of the old code [16:10:11] // Just use 'cc' as the payment method - it doesn't matter for the data deletion API call [16:10:14] ahh [16:10:17] return PaymentProviderFactory::getProviderForMethod('cc'); [16:10:32] so that was the direct cause of the error MBeat saw [16:10:38] but I wanted to catch more errors [16:11:02] and leave the code ready for a future where PayPalPaymentProvider might also have a gdpr request [16:11:10] ejegg: jgleeson: so so far I was trying to test by first trying to make a local Paypal donation... so should I debug into that process to find it? or try the previous call via a maintenance script? [16:11:13] sorry AndyRussG not ignoring just clicking around code in relation to this one [16:11:24] yeah sorry to interrupt the other discussion! [16:11:28] no worries and thx! [16:11:41] AndyRussG: you can use the GetPaymentStatus maintenance script [16:12:04] hmm [16:12:18] ejegg: I think I had to put through a local payment to test the properly [16:12:39] jgleeson: the paypal one? [16:12:43] yes [16:12:46] just checking my notes [16:13:10] so for those, I have been trying to simulate orphan donations [16:13:28] by adding an exception into the processReturn or similar place [16:13:33] is there documentation somewhere about how this works currently? [16:13:37] and then going through a local payment [16:13:37] actually, let me close out this subject [16:13:48] and then I'll confirm how to test that new patch [16:13:49] jgleeson: ejegg yeah no rush [16:13:51] sorry AndyRussG [16:13:57] AndyRussG: let's see what we have [16:14:00] no worries, also sorry for the interruption! [16:14:28] doesn't look like we have much over at wikitech [16:15:03] https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_flow/PSP_integrations/PayPal_Express [16:15:58] right, not much there [16:16:19] I'll put a few lines up at least mentioning the different API calls we make [16:18:41] ejegg: cool thanks! [16:18:51] (03CR) 10Jgleeson: [C: 03+2] "working great for me, and thanks for the small update!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/851176 (https://phabricator.wikimedia.org/T321694) (owner: 10Ejegg) [16:20:04] (03CR) 10Jgleeson: [C: 03+2] "LGTM!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/851662 (owner: 10Ejegg) [16:20:20] ejegg: I guess the code to look at is the returnFromProcessor (or something similar) flow in DI, which is called by existing the paypal pendant transantlatic revolver? [16:20:31] hi ejegg, please how do I test this: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/849205/ [16:20:46] (03Merged) 10jenkins-bot: ProviderConfiguration: remap paypal_ec to paypal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/851662 (owner: 10Ejegg) [16:23:11] hi damilare! [16:23:23] (03CR) 10Jgleeson: [C: 04-1] "This looks good, although I feel uneasy about merging untested code. I feel cruel asking for a unit test or changes to existing code to se" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/851664 (owner: 10Ejegg) [16:23:36] sorry ejegg ! [16:23:49] heh, tests are always good [16:24:15] ok paypal [16:24:26] I was thinking maybe I should even call isValidProviderName somewhere in the ProviderConfiguration instantiation code [16:25:05] AndyRussG: I seem to remember one of those params needed for the Maintenance script, not being easy to find [16:25:15] I'm guessing payerID? [16:25:30] that comes back from the paypal 'getExpressCheckout' API call [16:25:36] so damilare you will need an example audit file [16:26:02] and yes you're right I think I was using xdebug whilst making a donation locally to stop and capture that [16:26:35] and I think we'll need some setup file for the audit parser so you can run it under the civicrm container [16:27:01] ejegg I thought this would be a sample audit file audit/paypal/tests/data/express_checkout_donation_denied.csv [16:27:11] saw it in your patch [16:30:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Email: Acoustic Import: Job Status Failed - https://phabricator.wikimedia.org/T322059 (10LMedley-WMF) Good morning @Ejegg, thank you very much for checking-in! All imports were successful today! Thanks again for your help and guidance. [16:32:16] AndyRussG: yeah this one is a bit tricky to test, as we've cut out some of the steps of the "full" integration to speed up the decoupling of donation-interface from civicrm. To test that patch, you need to put through a local paypal donation and stop it before it calls 'doExpressCheckout' is called as part of the usual flow [16:32:58] I should really write up testing instruction on the ticket if I hadn't done so already [16:33:22] nope! [16:33:59] AndyRussG: I've got a call now but when that is finished I'll write up the steps for testing. thanks for digging in on that also [16:34:51] (03Merged) 10jenkins-bot: Error handling for contribution forgetme [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/851176 (https://phabricator.wikimedia.org/T321694) (owner: 10Ejegg) [16:46:26] AndyRussG: here's a first bit: https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_flow/PSP_integrations/PayPal_Express [16:48:14] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/851679 [16:48:20] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/851679 (owner: 10Ejegg) [16:49:57] damilare: yep, so that should work as a sample audit file [16:50:29] I'm trying to run the parser locally, and it looks like we'll need to install some python libraries first [16:50:58] AndyRussG: when you were running the python tools under docker, you had to first log in as root to install pip3, right? [17:26:05] ok during that call I was thinking about whether it's possible to just chain up our existing Paypal maintenance scripts to get the data you need AndyRussG [17:26:19] jgleeson: it should be! [17:26:25] which would make testing a bit easier and have less debugging hurdles [17:26:35] We just need the TOKEN that you can get on the redirect URL [17:27:14] then you can use php PaymentProviders/PayPal/Maintenance/GetPaymentStatus.php [17:27:28] I started a writeup of the API calls here: https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_flow/PSP_integrations/PayPal_Express [17:27:34] jgleeson: ah there's a WIP patch! [17:27:41] I think we get that token back [17:27:51] on the TestApi maint script ejegg [17:28:36] oh? hmm, you would need to manually craft the URL to log in and authorize the payment if you used that maint script [17:28:39] jgleeson damilare for tools: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/841441 [17:28:44] I think it's easier to do it via the front end [17:28:48] ahhh thanks AndyRussG [17:29:00] thanks AndyRussG [17:29:08] oh right, it's a whole other container for the tools [17:29:16] ejegg: damilare yw looking forward to the rotten tomatoes flying at me ;p [17:29:29] see the commit message for some details [17:30:17] AndyRussG: ugh... so I think maybe we want to run the paypal audit script (which lives in the tools repo) under the civicrm container [17:31:21] ejegg: sure that can also work... making it a separate container is not a done decision, I was just trying it out that way... however, also, why? [17:31:23] hmmm, or maybe not so necessary? It needs a pair of directories with audit files (that are currently created with the civi setup) [17:31:46] and then needs to make some DB lookups to civi, but that can be from tools just fine [17:31:50] yeah hopefully all the relevant files can/should be shared anywhere needed [17:32:46] the paypal audit script does NOT use the log parsing that the rest of them do [17:32:58] so sure, it should be fine to run out of that new container [17:33:11] just needs those directories [17:33:17] ok, lunchtime [17:35:44] hmmm looks like we can't use the existing scripts [17:35:44] 10Fundraising-Backlog, 10fr-donorservices: Unsubscribe link not communicating with Civi as it used to - https://phabricator.wikimedia.org/T322084 (10SHust) [17:35:53] due to the reasons you mention I think ejegg|food [17:36:03] also gonna grab dinner before new tech-talk [18:11:35] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Gpay transactions stopped erroneously for AVS/CVV scores in non-US markets - https://phabricator.wikimedia.org/T321136 (10greg) [18:12:24] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Gpay transactions stopped erroneously for AVS/CVV scores in non-US markets - https://phabricator.wikimedia.org/T321136 (10XenoRyet) p:05Triage→03High [18:12:56] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Alerts, 10MW-1.39-notes (1.39.0-wmf.15; 2022-06-06): SmashPig::queue2civicrm find a completed dlocal payment mark as failed and removed from queue table - https://phabricator.wikimedia.org/T309799 (10greg) p:05Triage→03Medium [18:13:21] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Merge and go to listing redirect fail - https://phabricator.wikimedia.org/T309801 (10greg) p:05Triage→03Low [18:14:21] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Investigate timeouts from Adyen Soap listener - https://phabricator.wikimedia.org/T317422 (10greg) p:05Triage→03Low [18:14:31] 10Fundraising Tech - Chaos Crew: AmazonPay script errors when testing locally - https://phabricator.wikimedia.org/T318732 (10greg) p:05Triage→03Low [18:15:10] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Contact updated to have an invalid language - https://phabricator.wikimedia.org/T319142 (10greg) p:05Triage→03Medium [18:15:28] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Donor directed to "Thank You" page even though payment rejected - https://phabricator.wikimedia.org/T310383 (10greg) p:05Triage→03Medium [18:15:52] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Tech-Analytics: Differences between civicrm.wmf_donor table and Civi UI - https://phabricator.wikimedia.org/T321920 (10greg) p:05Triage→03Medium [18:16:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Something is causing a lot of deadlocks at :20 and :50 - https://phabricator.wikimedia.org/T320287 (10greg) p:05Triage→03Medium [18:54:59] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Tech-Analytics: Differences between civicrm.wmf_donor table and Civi UI - https://phabricator.wikimedia.org/T321920 (10JMando) Here are some more I have come across today: 43750645, 30337455, 14720652, 13303304, a... [19:19:05] 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Review dependabot report - https://phabricator.wikimedia.org/T321523 (10Dwisehaupt) [19:21:58] (03CR) 10Cstone: [C: 03+2] Work around name parser bug on multibyte initials [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/845102 (https://phabricator.wikimedia.org/T321343) (owner: 10Ejegg) [19:32:26] 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Review dependabot report - https://phabricator.wikimedia.org/T321523 (10Ejegg) Reviewed! All of these are in composer.... [19:35:35] (03Merged) 10jenkins-bot: Work around name parser bug on multibyte initials [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/845102 (https://phabricator.wikimedia.org/T321343) (owner: 10Ejegg) [19:41:35] 10Fundraising-Backlog: AMEX volume needs to be reported separately in Civi and not roll up to gateway PSPs - https://phabricator.wikimedia.org/T321611 (10Ejegg) Thanks for the ticket rename, @EMartin ! In a fr-tech / analytics hangout today, @JMando showed us this new version of the reconciliation board which... [19:50:15] 10Fundraising-Backlog: AMEX volume needs to be reported separately in Civi and not roll up to gateway PSPs - https://phabricator.wikimedia.org/T321611 (10EMartin) @Ejegg @jmando. This looks great!! Many thanks. This solves the issue for reconciliation!! [19:50:35] 10Fundraising-Backlog: AMEX volume needs to be reported separately in Civi and not roll up to gateway PSPs - https://phabricator.wikimedia.org/T321611 (10EMartin) 05Open→03Resolved a:03EMartin [19:55:35] hi fr-tech! pre-test launching in 5 minutes :) [19:55:45] thank haley_ [20:01:08] (03PS2) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/851679 [20:01:10] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/851679 (owner: 10Ejegg) [20:05:35] sorry - I dropped connection [20:10:13] !log civicrm upgraded from 6f511710 to 97b9d830 [20:10:14] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:11:49] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Review dependabot report - https://phabricator.wikimedia.org/T321523 (10Dwisehaupt) [20:15:20] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Civi: Forget Me button yields configuration error - https://phabricator.wikimedia.org/T321694 (10Ejegg) OK @MBeat33 the fix is deployed. It no longer throws the error when loading the initial screen on that contact. I haven't yet pre... [20:25:47] hi ejegg, please what would be the command to run the tests in the tools patch? [20:37:14] sorry damilare I've got to head out for a bit [20:37:22] 'tox' I think will be the command [20:37:41] ejegg|afk: damilare I think you need to use nose [20:37:47] uhh [20:37:52] or we did do back in the day [20:38:14] ok tox did something, lemme check the docs [20:38:34] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Civi: Forget Me button yields configuration error - https://phabricator.wikimedia.org/T321694 (10MBeat33) Thanks, @Ejegg I tested on a non-Adyen donor and it worked, but for an Adyen donor Civi responded with: {F35692975} [20:38:43] jgleeson, nose says "command not found" on the container [20:42:00] python -m nose [20:42:29] also damilare you might need to make sure the test-requirements are installed [20:43:49] (this is an alternative to running tox if that doesn't work) [20:44:12] ok I just pip installed the test-requirements [20:44:39] jgleeson: /usr/bin/python: No module named nose is the error I'm getting [20:44:41] pip3 install -r requirements.txt -r test-requirements.txt [20:44:55] and then `python3 -m nose` [20:47:32] ok that worked [20:47:59] guess it got installed in python3 [20:48:13] I can't remember why I gave up on tox. it didn't work for me [20:48:20] jgleeson do you have debugging setup [20:48:49] on the tools project [20:49:02] yeah but not using that patch [20:49:16] yh looks like tox is throwing an InvocationError [20:49:19] I had it running without docker [20:49:24] before we used docker [20:49:25] Oh what's your setup like? [20:50:32] so currently I run tools locally but at one point we used it with vagrant [20:50:50] the debug settings are pretty simple, you just tell it to point to your host machine IP and a port to open [20:51:06] it should then give you a few lines to include on top of the script [20:51:12] (if you're using pycharm) [20:51:26] ahh, right... [20:51:27] argh yeah [20:51:30] I debug in pycharm [20:51:43] the jetbrains python IDE [20:51:53] I think I instaled that at some point [20:52:49] Ok lemme set that up then, thanks! [20:53:10] np [20:53:32] I'm also thinking, it shouldn't make much difference if the idekey is to phpstorm on both ends [20:53:59] but lemme do that. [20:54:02] idekey? [20:54:17] that's for xdebug right [20:55:47] yep [20:56:17] ohh yea, xdebug is for php [20:56:36] ya [21:00:46] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Product-Analytics, 10Readers-Web-Backlog, and 2 others: CentralNotice severely impacts CLS score - https://phabricator.wikimedia.org/T318046 (10jwang) We did some initial analysis of WMF pageview metric on Hebrew Wikisource. Pageviews referred... [21:01:10] sorry was on a call but finished now [21:01:37] it looks like AndyRussG is using debugpy [21:02:19] and with pycharm I use pydevd-pycharm [21:02:27] or at least that's what they say to use [21:02:34] not sure what IT uses under the hood [21:02:58] https://www.jetbrains.com/help/pycharm/remote-debugging-with-product.html#remote-debug-config [21:04:07] although it shouldn't matter much if we all standardise on the same port (pycharm users vs other IDEs) [21:06:30] ohh cool, thanks for sharing [21:08:58] we should really fix that tox set up bug [21:09:09] it would be nicer to not have to work around that [21:09:22] let's dig in tomorrow on our call and see if we can figure it out [21:10:54] sounds good [21:23:49] -frauth1001 & -frauth1001 going away, expected? [21:25:03] dns deploy? [21:26:46] sorry and -frlog1001 [21:27:30] jhathaway: i believe that was jeff_green's change and yes, that is expected. [21:27:38] dwisehaupt: woohoo, thanks! [21:40:20] jgleeson|away: damilare ah yeah funny thing about the debugpy, the server-client relationship is (or at least can be?) inverted [21:40:36] which is why the jobs container would expose a port for that [21:57:29] that's interesting, thanks for working on this Andy. [21:57:34] See you all tomorrow [22:41:21] (03CR) 10Cstone: [C: 03+2] Update email_greeting template to handle missing first name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/849725 (https://phabricator.wikimedia.org/T321691) (owner: 10Eileen) [22:41:48] (03CR) 10Eileen: [V: 03+2] Update email_greeting template to handle missing first name [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/849725 (https://phabricator.wikimedia.org/T321691) (owner: 10Eileen) [22:42:50] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/851732 [22:43:04] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/851732 (owner: 10Eileen) [23:06:53] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Process control - would it be possible to log when each job starts & stops - https://phabricator.wikimedia.org/T322170 (10Eileenmcnaughton) [23:09:08] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Process control - would it be possible to log when each job starts & stops - https://phabricator.wikimedia.org/T322170 (10Eileenmcnaughton) [23:15:13] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Something is causing a lot of deadlocks in ConfigAndLog - https://phabricator.wikimedia.org/T320287 (10Cstone) [23:57:16] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Excessive Redis cache hits - https://phabricator.wikimedia.org/T322172 (10Eileenmcnaughton)