[00:14:35] AndyRussG: I was trying to create a sub-page here https://wikitech.wikimedia.org/wiki/Fundraising/Data_and_flow/Queues#Performance in your tree - but I don't think it has created it as a subpage.... [00:25:48] actually Maybe I did get it right & it just looked wrong? [01:15:40] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Determine if we should fork the name parser library - https://phabricator.wikimedia.org/T322174 (10Eileenmcnaughton) [01:21:54] 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Review our greeting templates - specifically - can we put in `Dear Donor` is there is no first name - https://phabricator.wikimedia.org/T321619 (10Eileenmc... [01:48:05] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Refunds should be negative contributions IMHO - https://phabricator.wikimedia.org/T322175 (10Eileenmcnaughton) [03:53:42] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: WMF donor fields are running out - https://phabricator.wikimedia.org/T322176 (10Eileenmcnaughton) [09:00:09] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Tech-Analytics: Fix legacy deduper screen so it is not possible to select to copy across wmf_donor data - https://phabricator.wikimedia.org/T322188 (10Eileenmcnaughton) [09:01:45] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Tech-Analytics: Fix sql error when calculating first donation date where a $0 or negative donation is involved - https://phabricator.wikimedia.org/T322189 (10Eileenmcnaughton) [09:02:00] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Tech-Analytics: Fix sql error when calculating first donation date where a $0 or negative donation is involved - https://phabricator.wikimedia.org/T322189 (10Eileenmcnaughton) [09:02:59] (03PS1) 10Eileen: Fix trigger handling of null or negative contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852133 (https://phabricator.wikimedia.org/T322189) [09:26:49] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Tech-Analytics: Differences between civicrm.wmf_donor table and Civi UI - https://phabricator.wikimedia.org/T321920 (10Eileenmcnaughton) ==tldr== there is not a significant number of contacts involved but I have... [09:44:17] (03PS2) 10Umherirrender: schema: Convert Unique Index to Primary Key on cn_notice_languages [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/817879 (https://phabricator.wikimedia.org/T312270) [09:44:20] (03PS3) 10Umherirrender: schema: Convert Unique Index to Primary Key on cn_notice_languages [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/817879 (https://phabricator.wikimedia.org/T312270) [09:46:28] (03PS2) 10Umherirrender: schema: Convert Unique Index to Primary Key on cn_notice_projects [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/817880 (https://phabricator.wikimedia.org/T312272) [09:46:58] (03PS2) 10Umherirrender: schema: Convert Unique Index to Primary Key on cn_notice_countries [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/817881 (https://phabricator.wikimedia.org/T312273) [09:47:09] (03PS2) 10Umherirrender: schema: Convert Unique Index to Primary Key on cn_notice_regions [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/817882 (https://phabricator.wikimedia.org/T312274) [11:46:48] 10Fundraising Sprint N*E*R*D, 10Fundraising Sprint ODB, 10Fundraising Sprint Snoop (Dogg|Lion), 10Fundraising-Backlog, and 3 others: Publishing translations for central notice banners fails - https://phabricator.wikimedia.org/T104774 (10jbond) [15:11:45] (03CR) 10Cstone: [C: 03+2] Fix trigger handling of null or negative contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852133 (https://phabricator.wikimedia.org/T322189) (owner: 10Eileen) [15:25:21] (03Merged) 10jenkins-bot: Fix trigger handling of null or negative contributions [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852133 (https://phabricator.wikimedia.org/T322189) (owner: 10Eileen) [15:50:33] (03PS1) 10Cstone: Add capturefailued to ignored Adyen audit types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/852226 (https://phabricator.wikimedia.org/T314753) [15:58:15] (03CR) 10Damilare Adedoyin: [C: 03+2] "LGTM" [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/849205 (https://phabricator.wikimedia.org/T320989) (owner: 10Ejegg) [16:01:54] (03Merged) 10jenkins-bot: Ignore non-successful lines in PayPal audit [wikimedia/fundraising/tools] - 10https://gerrit.wikimedia.org/r/849205 (https://phabricator.wikimedia.org/T320989) (owner: 10Ejegg) [16:05:58] 10Fundraising-Backlog, 10Wikimedia-FR-Tech-Systems: Fundraising Tech Systems Architecture Diagram - https://phabricator.wikimedia.org/T321089 (10jgleeson) As of 02/11/2022 {F35697203} [16:08:45] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Process control - would it be possible to log when each job starts & stops - https://phabricator.wikimedia.org/T322170 (10Jgreen) There's definitely room for improvement, below is what we have now. We log precise job start/end data but it's not in a very... [16:11:50] (03PS1) 10Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/852236 [16:11:52] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/852236 (owner: 10Ejegg) [16:13:00] (03Merged) 10jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - 10https://gerrit.wikimedia.org/r/852236 (owner: 10Ejegg) [16:54:21] grep -l "^schedule" * [17:01:54] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Can we run each process-control job as a different Civi user? - https://phabricator.wikimedia.org/T322240 (10Ejegg) [17:06:41] 10Fundraising-Backlog, 10Documentation: Document which tables are hit by each process-control job - https://phabricator.wikimedia.org/T322243 (10Ejegg) [17:50:55] ok cstone, that adyen_update_tokens job is gone [17:51:12] Thanks ejegg ! [17:52:11] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Tech-Analytics: Fix sql error when calculating first donation date where a $0 or negative donation is involved - https://phabricator.wikimedia.org/T322189 (10Damilare) a:03Eileenmcnaughton [17:53:58] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Tech-Analytics: Differences between civicrm.wmf_donor table and Civi UI - https://phabricator.wikimedia.org/T321920 (10Damilare) a:03Eileenmcnaughton [17:55:20] ok, and there's a new listenabled command pushed to the localsettings/process-control directory (the level up from the machine-specific subdirs) [17:55:57] running it with no commands will list enabled jobs for civi1001, but it'll take a hostname arg in case we start running things elsewhere [17:58:08] hmm, some of those jobs would def be tricky to run locally to get good info about tables hit [17:58:21] I guess for some we'll just have to figure it out from the code [18:01:01] !log updated fundraising python tools from 4c143d97 to 72570bdd [18:01:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:02:16] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Civi showing completed donations when they were rejected at Paypal - https://phabricator.wikimedia.org/T320989 (10Ejegg) OK, that's the fix for the PayPal audit processor deployed. Going forward we shouldn't see any more of these. I... [18:25:19] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Civi showing completed donations when they were rejected at Paypal - https://phabricator.wikimedia.org/T320989 (10Ejegg) I was able to set all the ones from the past year to 'Cancelled' via the Civi API. Here's the list of invoice ID... [18:33:48] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Civi showing completed donations when they were rejected at Paypal - https://phabricator.wikimedia.org/T320989 (10MBeat33) Thanks, @Ejegg ! [18:47:28] (03PS1) 10Cstone: Change the Adyen audit file sort to look at modified date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852267 (https://phabricator.wikimedia.org/T321531) [19:22:45] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Refunds should be negative contributions IMHO - https://phabricator.wikimedia.org/T322175 (10Cstone) I think this is a bug, the refund should be like in the top donation there, I haven't seen it be separate like that for a recent donation. [19:46:08] hi fr-tech, FYI that the Endowment banner pre-test is launching in 15 minutes (20-23 UTC Today)! [19:46:47] thanks haley_ ! [19:46:56] np cstone! [19:55:09] :> [20:00:24] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Refunds should be negative contributions IMHO - https://phabricator.wikimedia.org/T322175 (10Cstone) Looks like it may just be jcb related The refund came in on payments_accounting_report_2022_10_25 (in the completed directory if people are looking for... [20:09:45] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Refunds should be negative contributions IMHO - https://phabricator.wikimedia.org/T322175 (10Ejegg) Aha, I think I see the problem - the JPY amount in the refund queue message is 100x smaller than it should be. Instead of refunding 114 JPY the message say... [20:15:21] 10Fundraising-Backlog: FR-Tech Systems Snapshot metric ideas - https://phabricator.wikimedia.org/T322266 (10jgleeson) [20:18:03] 10Fundraising-Backlog: FR-Tech Systems Snapshot metric ideas - https://phabricator.wikimedia.org/T322266 (10jgleeson) [20:42:52] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Tech-Analytics: Fix sql error when calculating first donation date where a $0 or negative donation is involved - https://phabricator.wikimedia.org/T322189 (10Eileenmcnaughton) For some reason this didn't link thro... [20:45:20] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Tech-Analytics: Fix sql error when calculating first donation date where a $0 or negative donation is involved - https://phabricator.wikimedia.org/T322189 (10Eileenmcnaughton) In terms of what to do with this phab... [21:10:35] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Refunds should be negative contributions IMHO - https://phabricator.wikimedia.org/T322175 (10Eileenmcnaughton) oh - that might actually be correct. But I'm not sure we are accounting for it correctly in the triggers [21:16:22] eileen: we're on the eileen-time tech talk and there's no eileen [21:16:59] jgleeson: hmm - that is not in my calendar today - what is the url [21:18:23] https://meet.google.com/odz-juym-nog?authuser=0 [21:34:02] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks for this!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/849384 (https://phabricator.wikimedia.org/T295412) (owner: 10Eileen) [21:45:29] (03CR) 10Ejegg: [C: 03+2] Add capturefailued to ignored Adyen audit types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/852226 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [21:46:17] (03Merged) 10jenkins-bot: Add capturefailued to ignored Adyen audit types [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/852226 (https://phabricator.wikimedia.org/T314753) (owner: 10Cstone) [21:47:25] (03Merged) 10jenkins-bot: Port search kit fix [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/849384 (https://phabricator.wikimedia.org/T295412) (owner: 10Eileen) [22:41:15] damilare: I got tox working [22:42:04] I ended up upgrading to the latest version of python 3.7 which seemed to get rid of some cryptography invocation error [22:42:32] I then I didn't have the right perms set up for the test database that the silverpop tests use on fundraising tools [22:43:06] which we have docs for here https://github.com/wikimedia/wikimedia-fundraising-tools/blob/e8f067b24786d64907b5dcaac1b54c3969746c9b/README.md#test-database [23:29:01] jgleeson|away: would be good to update the readme - this was my last effort https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/tools/+/673176 [23:29:55] oh I see - that it the same file [23:45:13] cool, jgleeson. I'd set mine up tomorrow. [23:47:04] (03PS16) 10Damilare Adedoyin: Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412)