[01:06:14] (03PS1) 10Ejegg: Remove WMF Donor fields from legacy merge screen [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852321 (https://phabricator.wikimedia.org/T322188) [01:08:07] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Tech-Analytics, 10Patch-For-Review: Fix legacy deduper screen so it is not possible to select to copy across wmf_donor data - https://phabricator.wikimedia.org/T322188 (10SHust) @Eileenmcnaughton whichever route... [02:10:00] (03PS1) 10Eileen: Update to latest version of CiviCRM 5.54 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852325 [02:13:17] (03PS2) 10Ejegg: Remove WMF Donor fields from legacy merge screen [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852321 (https://phabricator.wikimedia.org/T322188) [02:16:16] (03CR) 10Eileen: Remove WMF Donor fields from legacy merge screen (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852321 (https://phabricator.wikimedia.org/T322188) (owner: 10Ejegg) [02:30:26] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Refunds should be negative contributions IMHO - https://phabricator.wikimedia.org/T322175 (10Ejegg) Aha, the bad data was coming from inside the report! payments_accounting_report_2022_10_25.csv has a row with the refund whose 'Original Amount' field is... [05:21:13] (03CR) 10Eileen: "Hi Dami," [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) (owner: 10Damilare Adedoyin) [05:21:31] (03PS1) 10Eileen: Damaged fixes - some may by php version specific but I should be on the same version as prod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852330 (https://phabricator.wikimedia.org/T295412) [05:24:00] (03CR) 10Eileen: Move Damage table to CiviCRM extension (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) (owner: 10Damilare Adedoyin) [05:54:38] (03CR) 10Eileen: "This worked well in my testing - just one question about whether the code to get wmf_donor fields should be located on the `CalculatedFiel" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852321 (https://phabricator.wikimedia.org/T322188) (owner: 10Ejegg) [05:56:12] (03CR) 10Eileen: [V: 03+2] "Just noting we undid this on live" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/849725 (https://phabricator.wikimedia.org/T321691) (owner: 10Eileen) [05:59:13] (03PS2) 10Eileen: Damaged fixes - some may by php version specific but I should be on the same version as prod [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852330 (https://phabricator.wikimedia.org/T295412) [11:29:06] well that was a fun hour of not being able to use terminal on my machine [11:29:17] fr-tech, be careful upgrading python on ubuntu [11:30:27] in my case, a few ubuntu internals such as gnome-terminal (main terminal) and the ubuntu updater scripts relied on Python 3.6 and upgrading to Python 3.7 removes packages needed to for the OS to function and terminal to open [11:31:09] I really should upgrade from ubuntu 18 LTS to whatever the latest is [13:52:25] jgleeson: looks like you just might make that update this time.. [13:54:36] fr-tech I'm having an issue publishing a doc on wikitech [13:54:51] I'm getting this error " [13:55:02] [3c2fc170-301b-40b4-9200-979d37374a9b] Caught exception of type MediaWiki\Rest\HttpException [13:59:47] Ok never mind, it's saved now. I opened another instance of the page, copied from the instance that wasn't publishing and pasted on the new instance edit page. [14:01:32] (03CR) 10Jgleeson: Implement PayPal EC DoExpressCheckoutPayment API call (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/845045 (https://phabricator.wikimedia.org/T318756) (owner: 10Jgleeson) [14:01:52] ha damilare. fingers crossed re:upate [14:01:54] looks like it may have been caused by a merge conflict of somesort. From the history, I see jgleeson edited the same page while I was writing the doc. [14:02:26] I updated it last night [14:02:31] with the UML diagram we added [14:02:37] the pending trxn resolver stuff? [14:03:28] yh that's it. It's the same page I'm adding the civi stuff to [14:03:36] https://wikitech.wikimedia.org/wiki/Fundraising [14:04:12] hmmm [14:04:16] do you have a direct link? [14:04:28] I didn't edit that page I don't think [14:04:49] oh yeah earlier I added the latest stack diagram [14:05:07] but that's not the thing I added to the pending trxn page. is it not that page you were editing [14:05:44] (03PS8) 10Jgleeson: Implement PayPal EC DoExpressCheckoutPayment API call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/845045 (https://phabricator.wikimedia.org/T318756) [14:06:35] oh man [14:06:42] python 3.7 has broken my git review [14:06:53] sigh [14:07:52] no I am writing stuff on the civi work I did last sprint on the Fundraising wikitech [14:08:13] Ah sorry about that RE:python-weirdness [14:10:29] Sorry jgleeson, I think pycharm created a virtual environment on it's terminal when I set mine up. [14:10:39] Are you using pycharm terminal? [14:12:30] no I use gnome terminal [14:13:56] ahh that sucks, well can you create a venv with the last stable python version on your computer? [14:17:13] I needed to update pyopenssl it seems [14:30:43] cool [14:59:25] 10Fundraising Sprint Solid State Spaghetti, 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, and 2 others: Implement PayPal EC DoExpressCheckoutPayment in SmashPig - https://phabricator.wikimedia.org/T318756... [15:02:19] (03PS9) 10Jgleeson: Implement PayPal EC DoExpressCheckoutPayment API call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/845045 (https://phabricator.wikimedia.org/T318756) [15:03:22] (03CR) 10Jgleeson: "PS9 updates the commit message to include a test instructions link and a reference to the code we will be replacing in Donation Interface." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/845045 (https://phabricator.wikimedia.org/T318756) (owner: 10Jgleeson) [15:08:51] (03PS17) 10Damilare Adedoyin: Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) [15:58:07] (03PS1) 10Ejegg: Use different field for Adyen refund amount [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/852919 (https://phabricator.wikimedia.org/T322175) [16:02:44] (03PS3) 10Ejegg: Remove WMF Donor fields from legacy merge screen [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852321 (https://phabricator.wikimedia.org/T322188) [16:10:11] (03CR) 10Ejegg: "OK, I moved those functions" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852321 (https://phabricator.wikimedia.org/T322188) (owner: 10Ejegg) [16:11:38] (03Abandoned) 10Ejegg: Set contribution_recur_id when token found [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/828094 (https://phabricator.wikimedia.org/T315031) (owner: 10Ejegg) [16:17:17] (03PS1) 10Ejegg: Quit trying to chmod moved audit files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852952 (https://phabricator.wikimedia.org/T318623) [16:22:57] (03CR) 10Cstone: [C: 03+2] "Thanks for figuring this out!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/852919 (https://phabricator.wikimedia.org/T322175) (owner: 10Ejegg) [16:23:29] (03Merged) 10jenkins-bot: Use different field for Adyen refund amount [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/852919 (https://phabricator.wikimedia.org/T322175) (owner: 10Ejegg) [16:24:17] thanks cstone ! [16:24:45] let's see, is there anything else in review in SmashPig that we should wait for before tagging a new version? [16:25:05] fr-tech it's looking like the staff meeting will overrun further [16:25:17] should we combine alerts retro and standup? [16:25:50] sounds good ejegg [16:29:42] mmm we might make it [16:33:30] kaarel is net level for presentation giving [16:35:27] ya he is. he's always at the architecture calls and gives great talks [16:40:49] (03CR) 10AndyRussG: "Hi! Thanks so much for this! Everything looks fine other than the error noted inline :)" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/845045 (https://phabricator.wikimedia.org/T318756) (owner: 10Jgleeson) [16:42:53] (03CR) 10AndyRussG: Implement PayPal EC DoExpressCheckoutPayment API call (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/845045 (https://phabricator.wikimedia.org/T318756) (owner: 10Jgleeson) [16:49:03] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Process control - would it be possible to log when each job starts & stops - https://phabricator.wikimedia.org/T322170 (10Jgreen) Here's a first try at more precise way of reporting this in Grafana. https://frmon.wikimedia.org/d/lIN1akDVz/process-control... [16:51:11] 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: DonationInterface: Update MaxMind + GeoIP libraries to latest version - https://phabricator.wikimedia.org/T281443 (10AndyRussG) a:03AndyRussG [16:58:14] (03PS18) 10Damilare Adedoyin: Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) [17:11:43] (03CR) 10CI reject: [V: 04-1] Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) (owner: 10Damilare Adedoyin) [17:25:40] (03PS19) 10Damilare Adedoyin: Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) [17:33:39] (03PS20) 10Damilare Adedoyin: Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) [17:35:52] (03CR) 10Damilare Adedoyin: "Thanks Eileen for the review and comments. I installed the plugins you recommended and fixed most of the suggestions that came up. I also " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) (owner: 10Damilare Adedoyin) [17:46:19] (03CR) 10CI reject: [V: 04-1] Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) (owner: 10Damilare Adedoyin) [17:57:30] gotta head out for now [18:00:19] (03PS1) 10Cstone: Update SmashPig to v0.8.3.10 and own version number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/852985 [18:03:41] (03CR) 10Cstone: [C: 03+2] Update SmashPig to v0.8.3.10 and own version number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/852985 (owner: 10Cstone) [18:03:59] (03PS21) 10Damilare Adedoyin: Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) [18:06:23] (03Merged) 10jenkins-bot: Update SmashPig to v0.8.3.10 and own version number [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/852985 (owner: 10Cstone) [18:17:40] (03CR) 10CI reject: [V: 04-1] Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) (owner: 10Damilare Adedoyin) [18:24:55] (03PS1) 10Cstone: Update SmashPig to v0.8.3.10 and DonationInterface to v2.5.8.8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852989 [18:38:53] (03PS22) 10Damilare Adedoyin: Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) [18:41:39] (03CR) 10Cstone: [C: 03+2] Update SmashPig to v0.8.3.10 and DonationInterface to v2.5.8.8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852989 (owner: 10Cstone) [18:51:48] (03CR) 10CI reject: [V: 04-1] Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) (owner: 10Damilare Adedoyin) [18:53:51] (03Merged) 10jenkins-bot: Update SmashPig to v0.8.3.10 and DonationInterface to v2.5.8.8 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852989 (owner: 10Cstone) [19:09:55] (03PS23) 10Damilare Adedoyin: Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) [19:27:03] (03PS1) 10Cstone: Update SmashPig to v0.8.3.10 and DonationInterface to v2.5.8.8 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/852999 [19:27:58] (03CR) 10Cstone: [C: 03+2] Update SmashPig to v0.8.3.10 and DonationInterface to v2.5.8.8 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/852999 (owner: 10Cstone) [19:40:23] (03Merged) 10jenkins-bot: Update SmashPig to v0.8.3.10 and DonationInterface to v2.5.8.8 [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/852999 (owner: 10Cstone) [19:40:51] (03PS1) 10Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/853002 [19:44:14] (03CR) 10Cstone: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/853002 (owner: 10Cstone) [19:45:00] (03CR) 10Cstone: [C: 03+2] "recheck" [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/853002 (owner: 10Cstone) [19:48:49] hey damilare [19:49:50] !log civicrm upgraded from d1f286f0 to c0db8f34 [19:49:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:50:10] it looks you addressed everything so I can probably just do a quick re-test [20:17:23] hi eileen, sorry I had to step away from my computer for a bit [20:17:44] yep I did try to address the issues you mentioned [20:19:32] damilare: cool - I'm just checking it now - it still works locally so just giving it all one last look-over [20:20:19] what did you do with these ones - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/852330 - is this obsolete now? [20:20:36] I rebased it into mine [20:23:14] ok cool. [20:28:15] (03CR) 10Eileen: [C: 03+2] "This is a cool improvement." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) (owner: 10Damilare Adedoyin) [20:28:45] damilare: in your phpstorm there is a setting to trim trailing spaces on save - is that checked (Under General/Editor on mine) [20:29:24] oh I don't think so, I'd check [20:29:34] Thanks for the +2 also! [20:30:15] damilare: yeah - good to get it out there. It would be good to have a test on the api action sendToDamanged - but I didn't want to hold it up over that [20:31:31] Ok I could create a ticket for that [20:40:23] damilare: one question - what needs to be done in the roll out - does prod already have the right permissions at the sql level? [20:41:13] I don't think so, we need to modify the access rights of the db user on prod. [20:41:45] we didn't do that on staging because we want to ensure the balance in both environments [20:41:56] (03Merged) 10jenkins-bot: Move Damage table to CiviCRM extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/844072 (https://phabricator.wikimedia.org/T295412) (owner: 10Damilare Adedoyin) [20:42:27] which is why dwisehaupt had to setup the dev_* db replicas on staging with the desired access rights [20:57:35] yeah. i can look at those rights and get them consistent. [20:57:40] won't take long [21:05:35] ok. rights updated in git and applied on frdb1004. i'll apply them on the other replicas too. [21:06:24] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Process control - would it be possible to log when each job starts & stops - https://phabricator.wikimedia.org/T322170 (10Eileenmcnaughton) That's cool & def helps. It would be amazing (but possibly not do-able) to overlay other metrics like queue speed o... [21:06:39] cool, thanks dwisehaupt [21:11:15] 10Fundraising Sprint Solid State Spaghetti, 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, and 2 others: Move damaged message browser to SmashPig CiviCRM ext... - https://phabricator.wikimedia.org/T295412 [21:59:06] (03CR) 10Eileen: [C: 03+2] "I verified that this has been failing a long time (as early as 20211104) and also that the line number was correct - it was 1063 in the ph" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852952 (https://phabricator.wikimedia.org/T318623) (owner: 10Ejegg) [22:11:44] (03Merged) 10jenkins-bot: Quit trying to chmod moved audit files [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852952 (https://phabricator.wikimedia.org/T318623) (owner: 10Ejegg) [22:51:29] 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising-Backlog, 10fundraising-tech-ops, 10SRE, and 3 others: SSL cert for links.email.wikimedia.org - https://phabricator.wikimedia.org/T188561 (10greg) @BBlack @KOfori Hi both! Could we bother you for... [23:25:57] (03PS1) 10Eileen: Remove trailing spaces [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/853068 [23:26:19] super easy review ^ [23:46:48] heh. even i can review that one. [23:47:52] (03CR) 10Dwisehaupt: [C: 03+2] "Goodbye extraneous spaces. shipit." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/853068 (owner: 10Eileen) [23:51:44] (03PS1) 10Krinkle: Avoid unsafe wrapping of Message::parse() into paragraph [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/853070 (https://phabricator.wikimedia.org/T322173)