[07:52:38] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/853764 (owner: 10L10n-bot) [08:11:55] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/853764 (owner: 10L10n-bot) [14:01:28] (03PS1) 10Damilare Adedoyin: Return fallback language [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/854004 (https://phabricator.wikimedia.org/T319142) [16:21:57] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Civi: Forget Me button yields configuration error - https://phabricator.wikimedia.org/T321694 (10MBeat33) Awesome, thank you both. I just tested with an Adyen and a non-Adyen donor, and it looks great. [16:26:10] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Civi: Forget Me button yields configuration error - https://phabricator.wikimedia.org/T321694 (10MBeat33) 05Open→03Resolved a:03MBeat33 [16:27:19] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Contact updated to have an invalid language - https://phabricator.wikimedia.org/T319142 (10Damilare) Noticed the Engage data doesn't come with a language column and the EngageChecksFile doesn't [[ h... [16:36:23] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Contact updated to have an invalid language - https://phabricator.wikimedia.org/T319142 (10Damilare) a:03Damilare [16:49:22] (03CR) 10Jgleeson: [C: 03+1] "Thanks for this. I'm surprised we don't already set a preferred language as discussed on our call. I'm +1ing this for now just because I'd" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/854004 (https://phabricator.wikimedia.org/T319142) (owner: 10Damilare Adedoyin) [17:33:24] (03PS1) 10Jgleeson: Move GetExpressCheckoutDetails mapping into API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/854057 (https://phabricator.wikimedia.org/T318867) [17:33:56] (03CR) 10CI reject: [V: 04-1] Move GetExpressCheckoutDetails mapping into API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/854057 (https://phabricator.wikimedia.org/T318867) (owner: 10Jgleeson) [17:36:23] (03PS2) 10Jgleeson: Move GetExpressCheckoutDetails mapping into API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/854057 (https://phabricator.wikimedia.org/T318867) [17:45:23] 10Fundraising-Backlog: Add error handling and mapping for Smashpig PayPal EC GetExpressCheckoutDetails API call - https://phabricator.wikimedia.org/T322570 (10jgleeson) [17:46:12] 10Fundraising-Backlog: Add error handling and mapping for Smashpig PayPal EC GetExpressCheckoutDetails API call - https://phabricator.wikimedia.org/T322570 (10jgleeson) [17:54:08] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Civi: Forget Me button yields configuration error - https://phabricator.wikimedia.org/T321694 (10MBeat33) 05Resolved→03Open Not sure if this should be a spinoff Task, but I got the following error when f... [18:21:17] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fundraising-tech-ops, 10fr-donorservices: Civi: Forget Me button yields configuration error - https://phabricator.wikimedia.org/T321694 (10Dwisehaupt) >>! In T321694#8376345, @MBeat33 wrote: > Not sure if this should be a spinoff Task, but I got the... [19:09:09] (03PS1) 10AndyRussG: Move test ESI injection to BeforePageDisplay hook [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/854091 (https://phabricator.wikimedia.org/T320734) [19:36:17] (03PS2) 10Jgleeson: Change the Adyen audit file sort to look at modified date [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852267 (https://phabricator.wikimedia.org/T321531) (owner: 10Cstone) [20:01:03] (03PS4) 10Damilare Adedoyin: Remove WMF Donor fields from legacy merge screen [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852321 (https://phabricator.wikimedia.org/T322188) (owner: 10Ejegg) [20:05:01] cstone: I'm reviewing https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/852267 and I'm seeing an array of audit files being created with the oldest first [20:05:13] i don't think we want that right? [20:05:20] yeah its confusing so the code outside of that [20:05:24] pops off the last 3 [20:05:29] of that array [20:05:33] oh [20:06:06] line 413 of the baseauditprocessor [20:07:28] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks for working on this and for the test instructions. Tested locally and works well." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852321 (https://phabricator.wikimedia.org/T322188) (owner: 10Ejegg) [20:08:24] ah i see [20:08:30] ok cool [20:08:33] this is hella confusing [20:08:50] yeahhh [20:10:43] hmm [20:11:52] I wonder if we should add a comment somewhere around here https://github.com/wikimedia/wikimedia-fundraising-crm/blob/2d3bde85156803443f101ffdb95a69929d8023af/drupal/sites/all/modules/wmf_audit/BaseAuditProcessor.php#L623 explaining that the sort order deliberately puts the newest at the bottom of the stack due to the array_pop behaviour to follow [20:12:41] albeit you haven't actually changed that code [20:12:49] I'll add that as a comment on the patch [20:13:06] if we get to rewrite that soon hopefully we can just remove all the confusion too [20:17:21] (03CR) 10Jgleeson: [C: 03+1] "Thanks! The change is working well for me, but it was a little confusing to see the array of files ordered oldest-to-new and then find out" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852267 (https://phabricator.wikimedia.org/T321531) (owner: 10Cstone) [20:19:42] (03Merged) 10jenkins-bot: Remove WMF Donor fields from legacy merge screen [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852321 (https://phabricator.wikimedia.org/T322188) (owner: 10Ejegg) [20:23:57] happy to +2 that one cstone if you agree on the comment bit [20:25:50] yeah its definitely confusing there are some comments about it up on like 397 but I think I've been in it too long so I just accept the chaos :P If where you want to add it makes sense to you I can add one there too [20:26:24] oh right I must have missed 'em [20:26:26] lemme check [20:30:59] hmm cstone that says top 3 [20:31:23] oops meet [20:43:09] 10Fundraising-Backlog, 10fr-donorservices: Unsubscribe link not communicating with Civi as it used to - https://phabricator.wikimedia.org/T322084 (10XenoRyet) p:05Triage→03High [20:45:34] 10Fundraising-Backlog, 10fr-donorservices: Unrelated CID popping up when searching for another in Civi - https://phabricator.wikimedia.org/T322581 (10SHust) [20:49:05] 10Fundraising-Backlog, 10fr-donorservices: Unrelated CID popping up when searching for another in Civi - https://phabricator.wikimedia.org/T322581 (10Ejegg) The underscore is a wildcard in searches, so searching for that particular email will also match any email with the _ replaced by some other character, su... [20:49:08] 10Fundraising-Backlog, 10fr-donorservices: Unrelated CID popping up when searching for another in Civi - https://phabricator.wikimedia.org/T322581 (10SHust) [20:53:16] 10Fundraising-Backlog, 10fr-donorservices: Unrelated CID popping up when searching for another in Civi - https://phabricator.wikimedia.org/T322581 (10Ejegg) If you put a backslash before the underscore, it looks like it only finds the contact with the underscore in their email. Pretty funny looking, but this... [20:57:20] 10Fundraising-Backlog, 10fr-donorservices: Unrelated CID popping up when searching for another in Civi - https://phabricator.wikimedia.org/T322581 (10SHust) Thanks for the speedy reply @Ejegg. I'll add this info to our Civi documentation. I'm surprised I never ran into it before today! [21:04:59] 10Fundraising-Backlog: Add error handling and mapping for Smashpig PayPal EC GetExpressCheckoutDetails API call - https://phabricator.wikimedia.org/T322570 (10Dwisehaupt) [21:15:06] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Can we run each process-control job as a different Civi user? - https://phabricator.wikimedia.org/T322240 (10Ejegg) [21:16:06] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Can we run each process-control job as a different Civi user? - https://phabricator.wikimedia.org/T322240 (10Dwisehaupt) [21:18:27] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: WMF donor fields are running out - https://phabricator.wikimedia.org/T322176 (10Dwisehaupt) [21:19:05] 10Fundraising Tech - Chaos Crew: Document which tables are hit by each process-control job - https://phabricator.wikimedia.org/T322243 (10XenoRyet) [21:19:07] 10Fundraising Tech - Chaos Crew: Unrelated CID popping up when searching for another in Civi - https://phabricator.wikimedia.org/T322581 (10XenoRyet) [21:19:10] 10Fundraising Tech - Chaos Crew: Fix legacy deduper screen so it is not possible to select to copy across wmf_donor data - https://phabricator.wikimedia.org/T322188 (10XenoRyet) [21:19:14] 10Fundraising Tech - Chaos Crew: Civi: Forget Me button yields configuration error - https://phabricator.wikimedia.org/T321694 (10XenoRyet) [21:19:16] 10Fundraising Tech - Chaos Crew: Fix sql error when calculating first donation date where a $0 or negative donation is involved - https://phabricator.wikimedia.org/T322189 (10XenoRyet) [21:19:18] 10Fundraising Tech - Chaos Crew: Review dependabot report - https://phabricator.wikimedia.org/T321523 (10XenoRyet) [21:19:20] 10Fundraising Tech - Chaos Crew: Pending table rows have no gateway_txn_id in the column and in the message its gateway_txn_id:false - https://phabricator.wikimedia.org/T321631 (10XenoRyet) [21:19:22] 10Fundraising Tech - Chaos Crew: Civi showing completed donations when they were rejected at Paypal - https://phabricator.wikimedia.org/T320989 (10XenoRyet) [21:19:24] 10Fundraising Tech - Chaos Crew: Back again but from donations queue consumer: INVALID_MESSAGE Recurring donation, but no subscription ID or recurring payment token found - https://phabricator.wikimedia.org/T320587 (10XenoRyet) [21:19:26] 10Fundraising Tech - Chaos Crew: Name parser breaks Irish last names - https://phabricator.wikimedia.org/T321343 (10XenoRyet) [21:19:28] 10Fundraising Tech - Chaos Crew: ENO browser extension incompatible with donation form? - https://phabricator.wikimedia.org/T320677 (10XenoRyet) [21:19:30] 10Fundraising Tech - Chaos Crew: Civi DB Error: constraint violation detected from civicrm_mailing_event_delivered from recurring_queue_consume log - https://phabricator.wikimedia.org/T319445 (10XenoRyet) [21:19:32] 10Fundraising Tech - Chaos Crew: Adyen audit sending not refunded recurring ideal donations to the refund queue - https://phabricator.wikimedia.org/T320286 (10XenoRyet) [21:19:34] 10Fundraising Tech - Chaos Crew: Broken links from Waystogive? - https://phabricator.wikimedia.org/T315268 (10XenoRyet) [21:19:36] 10Fundraising Tech - Chaos Crew: Deleted Contact Overwriting Current Contact Record - https://phabricator.wikimedia.org/T311438 (10XenoRyet) [21:19:38] 10Fundraising Tech - Chaos Crew: Adyen: Client side error on Safari even with successful donation - https://phabricator.wikimedia.org/T310737 (10XenoRyet) [21:19:40] 10Fundraising Tech - Chaos Crew: Unsubscribe link not communicating with Civi as it used to - https://phabricator.wikimedia.org/T322084 (10XenoRyet) [21:19:42] 10Fundraising Tech - Chaos Crew: Documentation: Banner data flow and data stores - https://phabricator.wikimedia.org/T296222 (10XenoRyet) [21:19:44] 10Fundraising Tech - Chaos Crew: Can’t mark CentralNotice translations as reviewed - https://phabricator.wikimedia.org/T308614 (10XenoRyet) [21:19:46] 10Fundraising Tech - Chaos Crew: Acoustic Import: Job Status Failed - https://phabricator.wikimedia.org/T322059 (10XenoRyet) [21:19:48] 10Fundraising Tech - Chaos Crew: Differences between civicrm.wmf_donor table and Civi UI - https://phabricator.wikimedia.org/T321920 (10XenoRyet) [21:19:50] 10Fundraising Tech - Chaos Crew: Something is causing a lot of deadlocks in ConfigAndLog - https://phabricator.wikimedia.org/T320287 (10XenoRyet) [21:19:52] 10Fundraising Tech - Chaos Crew: Pending resolver should not capture donations from donors with one in the last 24 hrs - https://phabricator.wikimedia.org/T320578 (10XenoRyet) [21:19:54] 10Fundraising Tech - Chaos Crew: Complete Adyen Checkout documentation to include donation statuses for all stages/permutations - https://phabricator.wikimedia.org/T316583 (10XenoRyet) [21:19:56] 10Fundraising Tech - Chaos Crew: Name changes required for Ingenico 3DS2.0 - https://phabricator.wikimedia.org/T312877 (10XenoRyet) [21:19:58] 10Fundraising Tech - Chaos Crew: Contact updated to have an invalid language - https://phabricator.wikimedia.org/T319142 (10XenoRyet) [21:20:00] 10Fundraising Tech - Chaos Crew: SmashPig::queue2civicrm find a completed dlocal payment mark as failed and removed from queue table - https://phabricator.wikimedia.org/T309799 (10XenoRyet) [21:20:02] 10Fundraising Tech - Chaos Crew: Donor directed to "Thank You" page even though payment rejected - https://phabricator.wikimedia.org/T310383 (10XenoRyet) [21:20:04] 10Fundraising Tech - Chaos Crew: chmod(): Operation not permitted BaseAuditProcessor.php:1063 - https://phabricator.wikimedia.org/T318623 (10XenoRyet) [21:20:06] 10Fundraising Tech - Chaos Crew: [EPIC] Rename AstroPay to dLocal - https://phabricator.wikimedia.org/T144835 (10XenoRyet) [21:20:08] 10Fundraising Tech - Chaos Crew: Merge and go to listing redirect fail - https://phabricator.wikimedia.org/T309801 (10XenoRyet) [21:20:10] 10Fundraising Tech - Chaos Crew: Investigate timeouts from Adyen Soap listener - https://phabricator.wikimedia.org/T317422 (10XenoRyet) [21:42:08] hi all, sorry for missing the meeting - my laptop slept in [21:42:43] It's still only half-awake - built in screen, keyboard not working - am on an external keyboard & monitor & logged a support ticket :-( [21:42:50] ah no [21:43:03] is that a new one eileen ? [21:43:24] no - but recently repaired & problem likely relates [21:43:33] it happened before & then came right - seems to be when it is cole [21:43:49] cold [21:53:05] :( [22:06:43] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/854127 [22:06:46] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/854127 (owner: 10Ejegg) [22:07:31] cstone: are you ok adding a small comment in the other location about the sorting behaviour on https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/852267 ? [22:07:42] I'm just wrapping up and I know you're out tomorrow [22:07:50] or I think? [22:07:53] Oh I'll be here tomorrow jgleeson [22:07:57] ah ok [22:08:09] Sorry started making some food hah but yeah I can add the comment [22:09:26] it can wait cstone. sorry! [22:09:36] No worries jgleeson [22:10:49] (03PS3) 10Jgleeson: WIP: createRecurringPaymentsProfile [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/853318 (https://phabricator.wikimedia.org/T318881) (owner: 10Wfan) [22:14:06] (03Abandoned) 10Jgleeson: Remove payment submethod check during Adyen 3DSecure [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/816858 (https://phabricator.wikimedia.org/T313756) (owner: 10Jgleeson) [22:16:27] (03CR) 10Eileen: "I think the code is already doing this - ie returning" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/854004 (https://phabricator.wikimedia.org/T319142) (owner: 10Damilare Adedoyin) [22:18:34] 10Fundraising Tech - Chaos Crew: Contact updated to have an invalid language - https://phabricator.wikimedia.org/T319142 (10Eileenmcnaughton) Since the last instance of this being recorded as an issue (13 Oct) Wenjun removed 'en' from the option value table - so we are no longer getting new instances of it sel... [22:23:09] (03CR) 10Eileen: "Just thinking this through - I guess there might be a flow through the code not handled but I'm not 100% sure if it is a real thing rather" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/854004 (https://phabricator.wikimedia.org/T319142) (owner: 10Damilare Adedoyin) [22:36:28] !log fundraising CiviCRM upgraded from c0db8f34 to 72fccce1 [22:36:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:26:46] (03PS3) 10Ejegg: Update to latest version of CiviCRM 5.54 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852325 (owner: 10Eileen) [23:26:57] (03CR) 10Ejegg: [C: 03+2] "Looks like this would be good to deploy!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852325 (owner: 10Eileen) [23:39:26] (03Merged) 10jenkins-bot: Update to latest version of CiviCRM 5.54 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/852325 (owner: 10Eileen) [23:50:53] is someone ok to merge https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/853071 - would just like to include in deploy ( but not update just yet)