[00:39:50] (03PS1) 10Eileen: Truncate error column in display [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855159 [00:44:11] 10Fundraising Tech - Chaos Crew: Fix sql error when calculating first donation date where a $0 or negative donation is involved - https://phabricator.wikimedia.org/T322189 (10Dwisehaupt) The triggers have been updated. [00:46:46] 10Fundraising Tech - Chaos Crew: Fix sql error when calculating first donation date where a $0 or negative donation is involved - https://phabricator.wikimedia.org/T322189 (10Eileenmcnaughton) Thanks @Dwisehaupt [01:35:29] 10Fundraising Tech - Chaos Crew: Differences between civicrm.wmf_donor table and Civi UI - https://phabricator.wikimedia.org/T321920 (10Eileenmcnaughton) I checked & there are around 370 remaining ones - when I edit them in the form they now fix to the correct value. Unfortunatley I cant see an easy way to bulk... [03:24:22] (03CR) 10Ejegg: [C: 04-1] "getLatestPaymentStatus isn't part of any interface yet, but it should be, since we're calling it on multiple different PaymentProcessor im" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/854057 (https://phabricator.wikimedia.org/T318867) (owner: 10Jgleeson) [04:25:56] 10Fundraising Tech - Chaos Crew: Differences between civicrm.wmf_donor table and Civi UI - https://phabricator.wikimedia.org/T321920 (10Eileenmcnaughton) @JMando - I think we can close this as there is a follow on Phab for cleaning up those last rows (if we care enough ) https://phabricator.wikimedia.org/T322189 [05:41:55] 10Fundraising-Backlog, 10FR-Civi-Dedupe, 10fr-donorservices: Civi Dedupe: show Last Donated date at top of legacy dedupe screen - https://phabricator.wikimedia.org/T256314 (10Eileenmcnaughton) [05:41:55] 10Fundraising Tech - Chaos Crew: Fix legacy deduper screen so it is not possible to select to copy across wmf_donor data - https://phabricator.wikimedia.org/T322188 (10Eileenmcnaughton) [05:42:27] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Civi-Dedupe, 10fr-donorservices, 10Unplanned-Sprint-Work: Civi Dedupe: show Last Donated date at top of legacy dedupe screen - https://phabricator.wikimedia.org/T256314 (10Eileenmcnaughton) [05:42:39] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Civi-Dedupe, 10fr-donorservices, 10Unplanned-Sprint-Work: Civi Dedupe: show Last Donated date at top of legacy dedupe screen - https://phabricator.wikimedia.org/T256314 (10Eileenmcnaughton) [05:43:43] 10Fundraising Tech - Chaos Crew: Fix legacy deduper screen so it is not possible to select to copy across wmf_donor data - https://phabricator.wikimedia.org/T322188 (10Eileenmcnaughton) @SHust - yes - this ticket is closed so a new phab is better. However, ..... here is one I put in the over earlier.... (Well Mi... [05:45:32] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Civi-Dedupe, 10fr-donorservices, 10Unplanned-Sprint-Work: Civi Dedupe: show Last Donated date at top of legacy dedupe screen - https://phabricator.wikimedia.org/T256314 (10Eileenmcnaughton) I pulled this in as it became more urgent due to work... [05:47:16] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: check_endpoints_critical (Amazon:1, Astropay-DLocal:1, BraintreeApi:2, BraintreeGateway:2) 6 [=1], check_endpoints_warning (Astropay-DLocal:1) 1 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [05:50:06] (03PS1) 10Eileen: Add last_donation_date to the top of the merge screen. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855180 (https://phabricator.wikimedia.org/T256314) [05:52:10] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [05:55:33] (03PS2) 10Eileen: Add last_donation_date to the top of the merge screen. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855180 (https://phabricator.wikimedia.org/T256314) [05:55:48] (03CR) 10Eileen: Add last_donation_date to the top of the merge screen. (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855180 (https://phabricator.wikimedia.org/T256314) (owner: 10Eileen) [06:04:49] (03PS1) 10Eileen: Add Organization to examples for message templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855183 (https://phabricator.wikimedia.org/T306556) [06:27:03] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/855248 (owner: 10L10n-bot) [06:53:59] (03PS1) 10Eileen: Remove pseudo-contact ids from example contacts. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855419 (https://phabricator.wikimedia.org/T306556) [06:54:45] (03PS2) 10Eileen: Add Organization to examples for message templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855183 (https://phabricator.wikimedia.org/T306556) [06:54:47] (03PS2) 10Eileen: Remove pseudo-contact ids from example contacts. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855419 (https://phabricator.wikimedia.org/T306556) [07:34:25] 10Fundraising Tech - Chaos Crew: Can’t mark CentralNotice translations as reviewed - https://phabricator.wikimedia.org/T308614 (10Nikerabbit) @AnnWF What is this blocked on? @XenoRyet Why did you remove the extension tags? [08:36:52] (03PS1) 10Eileen: Add support & test for Organization specific greeting in emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855487 (https://phabricator.wikimedia.org/T306556) [08:49:32] (03CR) 10CI reject: [V: 04-1] Add support & test for Organization specific greeting in emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855487 (https://phabricator.wikimedia.org/T306556) (owner: 10Eileen) [08:53:05] (03PS2) 10Eileen: Add support & test for Organization specific greeting in emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855487 (https://phabricator.wikimedia.org/T306556) [09:07:28] 10Fundraising-Backlog, 10FR-Japan: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10CDenes_WMF) [12:54:01] thanks for the review ejegg|away! [13:45:44] (03CR) 10Damilare Adedoyin: [C: 03+1] "This works!! Thanks for putting this through, +1'ing because I'd like to push up an additional patch to this for some small fixes on the t" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855159 (owner: 10Eileen) [13:52:42] hi jgleeson, seeing you're on chaos crew biz this sprint, can we talk about some tasks on the backlog? [13:53:11] hi dami. I can't just now as I'm heading out shortly to pick up my dad but when I get back later sure! [13:54:20] I've been responding to some review this morning and working in some extra unit tests on the paypal stuff so I might spend a bit more time on that today just wrapping it all up but once it's all good and merged I'll be right in the chaos :) [13:56:21] ahh sorry just saw your email... no problem, whenever you're back just give me a shout [13:56:38] or when you're fully into cc stuff [13:58:58] sounds good! [14:33:04] (03PS1) 10Damilare Adedoyin: added default sort by original date to packaged table and some css fixes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855579 [14:38:46] (03PS2) 10Damilare Adedoyin: added default sort by original date to packaged table and some css fixes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855579 [14:59:59] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/855248 (owner: 10L10n-bot) [15:19:01] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Civi-Dedupe, 10fr-donorservices, and 2 others: Civi Dedupe: show Last Donated date at top of legacy dedupe screen - https://phabricator.wikimedia.org/T256314 (10Damilare) a:03Eileenmcnaughton [15:53:54] 10Fundraising Tech - Chaos Crew: Differences between civicrm.wmf_donor table and Civi UI - https://phabricator.wikimedia.org/T321920 (10JMando) Sounds good! Thank you! [16:05:53] 10Fundraising Sprint U 2022, 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Implement PayPal EC ManageRecurringPaymentsProfileStatusCancel in SmashPig - https://phabricator.wikimedia.org/T318883 (10AndyRussG) a:03AndyRussG [16:14:54] (03CR) 10Damilare Adedoyin: [C: 03+2] "Looks good to me, thanks for adding the extra field." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855180 (https://phabricator.wikimedia.org/T256314) (owner: 10Eileen) [16:30:28] (03Merged) 10jenkins-bot: Add last_donation_date to the top of the merge screen. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855180 (https://phabricator.wikimedia.org/T256314) (owner: 10Eileen) [16:32:29] (03CR) 10Jgleeson: [C: 03+2] "Looks good to me! thanks for the demo late last night also :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855579 (owner: 10Damilare Adedoyin) [16:33:55] thanks jgleeson for the CR! [16:35:39] np! [16:55:40] (03CR) 10Damilare Adedoyin: [C: 03+2] Truncate error column in display [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855159 (owner: 10Eileen) [16:56:37] 10Fundraising Tech - Chaos Crew, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate: Can’t mark CentralNotice translations as reviewed - https://phabricator.wikimedia.org/T308614 (10AndyRussG) >>! In T308614#8385531, @Nikerabbit wrote: > @AnnWF What is this blocked on? > @XenoRyet Why did... [17:08:18] (03Merged) 10jenkins-bot: Truncate error column in display [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855159 (owner: 10Eileen) [17:08:53] (03Merged) 10jenkins-bot: added default sort by original date to packaged table and some css fixes [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855579 (owner: 10Damilare Adedoyin) [17:40:23] (03PS1) 10Ejegg: Turn off fraud checks for GPay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/855660 (https://phabricator.wikimedia.org/T321136) [17:54:55] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Civi: Forget Me button yielding parameters errors - https://phabricator.wikimedia.org/T322796 (10jgleeson) p:05Triage→03High [17:58:23] 10Fundraising Tech - Chaos Crew, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate: Can’t mark CentralNotice translations as reviewed - https://phabricator.wikimedia.org/T308614 (10Nikerabbit) Cool! Do let me know if we can help further. [18:38:29] (03CR) 10Cstone: [C: 03+2] "Dear Bugle Reporters we see the example!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855183 (https://phabricator.wikimedia.org/T306556) (owner: 10Eileen) [18:38:45] (03CR) 10Cstone: [C: 03+2] Remove pseudo-contact ids from example contacts. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855419 (https://phabricator.wikimedia.org/T306556) (owner: 10Eileen) [18:42:06] 10Fundraising Tech - Chaos Crew: Unsubscribe link not communicating with Civi as it used to - https://phabricator.wikimedia.org/T322084 (10Ejegg) It looks like the jobs are running as usual, pulling down events and then marking them in Civi. I see a couple of limitations, though - 1) It only pulls events back... [18:51:33] (03Merged) 10jenkins-bot: Add Organization to examples for message templates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855183 (https://phabricator.wikimedia.org/T306556) (owner: 10Eileen) [18:51:47] (03Merged) 10jenkins-bot: Remove pseudo-contact ids from example contacts. [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855419 (https://phabricator.wikimedia.org/T306556) (owner: 10Eileen) [18:57:57] (03CR) 10Cstone: Add support & test for Organization specific greeting in emails (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855487 (https://phabricator.wikimedia.org/T306556) (owner: 10Eileen) [19:14:58] 10Fundraising-Backlog, 10Epic: EPIC: Paypal reintegration: braintree docs - https://phabricator.wikimedia.org/T243095 (10EMartin) @Fr-tech Notating here that multi-currency accounts have been established finally at Paypal should we ever resume the work associated with reintegrating to Braintree. [19:27:28] (03PS1) 10Damilare Adedoyin: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/855698 [19:28:07] (03CR) 10Damilare Adedoyin: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/855698 (owner: 10Damilare Adedoyin) [19:32:59] !log civicrm upgraded from 07fdeed5 to 6c2e07e0 [19:33:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:19:14] 10Fundraising-Backlog: FR-Tech Systems Snapshot metric ideas - https://phabricator.wikimedia.org/T322266 (10Jgreen) We have the process-control status, load, queue size and tons of other metrics in Prometheus already. Here's an attempt at putting a bunch of potentially useful metrics in one Grafana dashboard: ht... [20:37:35] (03CR) 10Eileen: Add support & test for Organization specific greeting in emails (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855487 (https://phabricator.wikimedia.org/T306556) (owner: 10Eileen) [20:40:17] 10Fundraising-Backlog, 10FR-Japan, 10fr-donorservices: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10MBeat33) [20:42:07] 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising Sprint U 2022, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Automatic thank you email from Civi for Organization Contact Types - https://phabricator.wikimedia.org/T306556 (10Eileenmcna... [20:54:23] 10Fundraising-Backlog, 10fr-donorservices: Donors receiving unintended PTF amounts EN6C 2022 - https://phabricator.wikimedia.org/T322882 (10MBeat33) [20:55:59] (03CR) 10Eileen: "I replicated the en_US thing - will look - it appears to only affect the preview screen" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855487 (https://phabricator.wikimedia.org/T306556) (owner: 10Eileen) [20:57:34] 10Fundraising Tech - Chaos Crew: Differences between civicrm.wmf_donor table and Civi UI - https://phabricator.wikimedia.org/T321920 (10Eileenmcnaughton) 05Open→03Resolved [20:59:06] cstone: just chatting with Thea about when to push that code out- I think the en_US thing only affects preview [20:59:34] ok eileen I can +2 then if its just that [21:00:39] cstone: can you jump on https://meet.google.com/dqt-rgsm-kjy?authuser=0 [21:00:45] sure [21:06:57] (03CR) 10Cstone: [C: 03+2] Add support & test for Organization specific greeting in emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855487 (https://phabricator.wikimedia.org/T306556) (owner: 10Eileen) [21:07:03] (03CR) 10Jgleeson: [C: 03+2] "This is working as expected for me. thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/855660 (https://phabricator.wikimedia.org/T321136) (owner: 10Ejegg) [21:09:35] (03Merged) 10jenkins-bot: Turn off fraud checks for GPay [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/855660 (https://phabricator.wikimedia.org/T321136) (owner: 10Ejegg) [21:13:33] (03PS1) 10Jgleeson: Turn off fraud checks for GPay [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/855712 (https://phabricator.wikimedia.org/T321136) [21:14:58] (03CR) 10Jgleeson: [C: 03+2] Turn off fraud checks for GPay [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/855712 (https://phabricator.wikimedia.org/T321136) (owner: 10Jgleeson) [21:17:54] (03PS1) 10Jgleeson: Update Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/855713 [21:19:44] (03Merged) 10jenkins-bot: Add support & test for Organization specific greeting in emails [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/855487 (https://phabricator.wikimedia.org/T306556) (owner: 10Eileen) [21:21:48] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/855714 [21:22:00] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/855714 (owner: 10Eileen) [21:24:25] (03Merged) 10jenkins-bot: Turn off fraud checks for GPay [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/855712 (https://phabricator.wikimedia.org/T321136) (owner: 10Jgleeson) [21:25:24] (03CR) 10Jgleeson: [C: 03+2] Update Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/855713 (owner: 10Jgleeson) [21:34:35] (03Merged) 10jenkins-bot: Update Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/855713 (owner: 10Jgleeson) [21:37:13] tskaff: cstone , fr-tech. I'm gonna stop the thank you mail queue & push out the greeting change now & then try a slow-start [21:37:32] ok eileen [21:39:50] cstone: do you want to check the patch to turn it off (it is just 3 instances of [21:39:50] -schedule: "5-59/6 * * * *" [21:39:50] +#schedule: "5-59/6 * * * *" [21:40:08] hi folks [21:40:14] hey ejegg [21:40:24] thank you so much eileen and cstone! [21:40:37] hi jgleeson, thanks for merging that stuff! [21:40:50] I can push the buttons up on frpm if you want to sign off now [21:41:04] looks good eileen [21:41:09] thanks [21:41:57] oic you just did [21:42:43] !log process-control config revision changed from 4e438cf5 to bbdd4315 (disable thank you) [21:42:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:43:33] !civicrm upgraded from 6c2e07e0 to fd60273a [21:47:23] !log 3:43:33 !civicrm upgraded from 6c2e07e0 to fd60273a [21:47:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:47:25] :) [21:47:35] opps [21:47:51] thanks [21:51:37] hmm this is a bit odd cstone ejegg damilare - the email that went out with my slow start was for a donation 10 days ago - https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=36900313 - it is one of the Engage null language ones [21:53:01] would those engage ones have had nothankyou reason eileen ? [21:53:08] ah I see - that is the contribution date, not the import date - so still NULL language [21:53:28] !log payments updated from 17cd1956 to a058fdbc [21:53:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:53:39] (03PS4) 10Wfan: CreateRecurringPaymentsProfile [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/853318 [21:53:53] guess it didnt [21:57:15] oh null language could also be ones that already existed [21:59:37] yep - was an update, not contact.create [22:00:20] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Implement PayPal EC SetExpressCheckout in SmashPig - https://phabricator.wikimedia.org/T318759 (10AnnWF) a:03AnnWF [22:07:18] yeah eileen I guess the same would apply to update [22:07:56] damilare: yeah - I think if we are not changing the language then it won't add the default - probably need to do a one-off update on contacts with NULL language [22:08:40] 165k - but I don't think there is any hurry to fix them [22:09:24] hmm - looks like a few of them are 'blanks; - https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=47841280 [22:09:33] yeah no need, since it isn't breaking anything atm [22:11:04] yeah - I'm gonna log a phab for the 2860 contacts I found with no data - I think they are old & can just be UI deleted [22:11:10] interesting, how come? [22:11:41] no activities,either. [22:12:18] I'm gonna have to step off soon, but it looks like the truncate pipe method didn't really work. [22:13:46] oh dang - it appeared to work in my testing [22:14:06] the only thing is it does weird stuff if the string is shorter than the truncate [22:14:55] Also RE: T322084, ejegg and I discovered that this job civicrm_api3_omnirecipient_process_unsubscribes uses the contact id from acoustic but an email could be attached to multiple contacts [22:14:55] T322084: Unsubscribe link not communicating with Civi as it used to - https://phabricator.wikimedia.org/T322084 [22:15:43] ahh yh I think the links in the local test aren't as long as prod, I should have played around with the length [22:16:01] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Delete blank contacts - https://phabricator.wikimedia.org/T322887 (10Eileenmcnaughton) [22:16:11] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Delete blank contacts - https://phabricator.wikimedia.org/T322887 (10Eileenmcnaughton) [22:16:47] yeah - it originally failed for me when I had the length too short - you can tinker in the UI with it & put whatever works in code (if it does) [22:16:49] So for that ticket, we are considering getting the email from the contact id to retrieve the list of ids on civi. In order to do a blank unsubscribe [22:16:58] blanket** [22:17:15] ohh nice, I'd check that out [22:17:58] (03CR) 10Wfan: "LGTM, just one question about Partially-Refunded." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/854581 (https://phabricator.wikimedia.org/T318756) (owner: 10Jgleeson) [22:18:13] (03CR) 10Wfan: [C: 03+2] Add test for Paypal Express API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/855060 (https://phabricator.wikimedia.org/T318756) (owner: 10Jgleeson) [22:18:16] hmm - damilare which ticket is that - I 'm not following the blanket unsubscribe bit [22:18:32] oh https://phabricator.wikimedia.org/T322084 [22:18:39] yep [22:20:49] thanks for the review wfan !! [22:21:00] np :P [22:21:17] 10Fundraising Tech - Chaos Crew: Unsubscribe link not communicating with Civi as it used to - https://phabricator.wikimedia.org/T322084 (10Eileenmcnaughton) So DR is not using this one for permanent unsubscribe? https://civicrm.wikimedia.org/civicrm/a/#/email/unsubscribe - from memory that DOES unsubscribe all i... [22:24:05] 10Fundraising Tech - Chaos Crew: Unsubscribe link not communicating with Civi as it used to - https://phabricator.wikimedia.org/T322084 (10Eileenmcnaughton) It looks like that internal function uses code that lives in the js layer drupal/sites/default/civicrm/extensions/org.wikimedia.unsubscribeemail/ang/unsub... [22:25:24] (03PS3) 10Wfan: Add test for Paypal Express API [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/855060 (https://phabricator.wikimedia.org/T318756) (owner: 10Jgleeson) [22:25:37] ejegg: damilare when I look at https://phabricator.wikimedia.org/T322084 it makes me think about the conversation I just had with cstone - ie are we thinking enough about code freeze yet - cos we don't seem to have it top-of-mind like we have had in other years (says she who just patched thank_you mail) [22:25:46] (cstone just turning thank you mail back on) [22:26:33] hah ok eileen [22:27:02] would sending myself a ty email from an already made donation pick up the new template eileen ? [22:27:33] cstone: yep [22:27:49] !log thank you back on config revision changed from bbdd4315 to 2bb73bb1 [22:27:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:28:32] hmm I'm getting Dear donor but its not en_US [22:31:16] cstone: huh - that sounds like a good thing? [22:31:42] or do you mean your language is not en_US - if so should be unchanged [22:31:53] shouldnt it done Dear friends at Christine [22:31:57] er have been* [22:32:00] i org'd myself [22:32:02] is that your org - what ID [22:32:14] 165749 [22:32:19] & is your email_greeting_display filled in? [22:32:30] is that different thatn email greeting [22:33:04] ah - we might have a timeout ? [22:33:14] ah from the template change? [22:33:37] i couldnt figure out if that was happening locally when I couldnt get the ty email to change [22:33:56] eileen: yeah, I don't think it's necessary to change that code right now [22:34:04] since the donor still does get opted out [22:34:28] well, the email address does end up in the unsubscribes file on the round trip, I mean [22:34:43] ejegg: ok cool - I just feel in general we are not as mindful of code freeze right now as we were in prior years at this time - maybe no David [22:34:52] true [22:35:12] cstone: ok - I got 'Dear donor' - my money is the template is cached [22:35:23] also this new team split has most of the team still working on feature stuff at a time when in prior years we would all be just in chaos mode [22:35:26] ok not en_us though! [22:35:36] good point ejegg [22:35:43] cstone: as in no stray 'en_US' in the text? [22:35:48] I think i did bring that up before about how maybe we should all switch over to chaos? [22:35:55] yeah no en_us replacing the greeting [22:36:14] yeah - I will dig into that but it is some leakage in the preview I think [22:36:41] yeah, definitely entering the chaos time of year. [22:36:50] 10Fundraising-Analysis, 10Fundraising-Backlog, 10FR-Email: Diff Tool to compare two emails - Test vs Control - https://phabricator.wikimedia.org/T322891 (10DBu-WMF) [22:37:03] not that it is chaos, but that the chaos things need addressing more. [22:37:35] it could be chaos [22:37:54] its 2 weeks to black friday [22:38:05] yeah - I kinda feel that we are really enthused about 'fixing the stuff' on the chaos side though & we also there need to make sure we are thinking 'should I fix this at this time of year' - maybe we could have a board for 'ok for code freeze time' & one for 'after code freeze is over' [22:38:16] according to that ads i've seen, black friday started a month ago. :) [22:38:48] eileen: in theory, that should be taken into account when planning the sprint. [22:39:06] if it's not ok to go out in the time of the sprint, it should be pushed to a later one. [22:39:26] dwisehaupt: yeah - we just haven't been as focussed on that this year IMHO - but for chaos crew - don't we have just one board [22:40:37] oh. you mean in the realm of the chaos crew board. yeah, that doesn't have the defined start/end like the sprints do. [22:41:12] yeah - just to surface the conversation of 'should we be touching this at this time of year' for that board too [22:41:17] maybe a temporary column until the end of en6c thats like "wait till after" [22:42:08] totally. great to bring up, talk about, and find an answer. [22:42:37] yep - channel our inner David [22:42:59] we can't say that anymore eileen! [22:43:07] lol [22:43:10] :> [22:43:14] just a few more weeks? [22:43:39] he was the one always telling us to expect payment processor freak outs [22:44:16] yeah we should document whatever that period was [22:44:35] we would switch to checking the backlog daily too but not sure when that started maybe big english? [22:44:36] isn't it like a 2 week spell when the gateways push out a bunch of stuff in a rush? [22:44:46] yeah jgleeson this next 2 weeks [22:44:59] for black friday in the US on the 25 [22:45:08] dlocal already pushed out our new api credentials by the looks of it.. [22:46:14] yeah. we would parse triage daily starting thanksgiving week or so. [22:46:51] although i'm not sure how much triaging david would do behind the scenes, so it could have been earlier. [22:47:20] * dwisehaupt wonders if he feels his ears burning as we talk about him. :) [22:47:42] ha [22:48:23] :-) [22:48:58] cstone: It just sent me the updated one - I think it was caching [22:49:01] nice! [22:49:35] woo yeah i see it too now [22:49:48] yay [22:51:41] 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising Sprint U 2022, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Automatic thank you email from Civi for Organization Contact Types - https://phabricator.wikimedia.org/T306556 (10Eileenmcna... [22:52:56] I think we should rename the sprint 'Underwhelming Sprint name' - guess we ran outta time! [22:57:29] i like it eileen [22:59:44] backlog reading: yeah, daily triage is a good idea starting soon-ish. [23:00:03] also, I guess everyone should vote on sprint names now. I'll send an email. [23:00:06] oh yeat. totally forgot the naming. [23:02:02] duplicate what I just emailed in shorter form: vote now, name will be changed "monday" "morning" (pacific time) [23:03:31] 10Fundraising Tech - Chaos Crew: Unsubscribe link not communicating with Civi as it used to - https://phabricator.wikimedia.org/T322084 (10SHust) @Eileenmcnaughton when dealing with high volume, [[ https://www.pages04.net/wikimedia/WMFUnsubscribe/Unsubscribe?vs=NzlkMTkzZWMtYjAyYi00YjY3LTlkOTQtNDU1ZDEwN2FiZGZkOzs... [23:05:40] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Unsubscribe link not communicating with Civi as it used to - https://phabricator.wikimedia.org/T322084 (10greg) [23:12:43] (03PS5) 10Wfan: CreateRecurringPaymentsProfile [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/853318 (https://phabricator.wikimedia.org/T318881)