[00:23:08] (03PS1) 10Ejegg: Use labels for SmashPig recurring errors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860130 (https://phabricator.wikimedia.org/T323644) [00:23:47] (03CR) 10Ejegg: [C: 03+2] Make errors from recurring smashpig charge job more visible (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860082 (https://phabricator.wikimedia.org/T323644) (owner: 10Damilare Adedoyin) [01:37:42] wfan: it looks like there are two versions of your SetExpressCheckout patch up in gerrit [01:37:57] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/860107 and https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/859142 [01:38:18] ah will fix it now [01:39:28] (03PS1) 10Wfan: Add SetExpressCheckout api for paypal EC [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/860135 (https://phabricator.wikimedia.org/T318759) [01:39:59] oh hmm, now there are three! [01:40:02] (03PS2) 10Wfan: Add SetExpressCheckout api for paypal EC [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/860135 (https://phabricator.wikimedia.org/T318759) [01:41:49] (03PS3) 10Wfan: Add SetExpressCheckout api for paypal EC [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/859142 (https://phabricator.wikimedia.org/T318759) [01:42:06] (03Abandoned) 10Wfan: Add SetExpressCheckout api for paypal EC [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/860135 (https://phabricator.wikimedia.org/T318759) (owner: 10Wfan) [01:42:12] (03Abandoned) 10Wfan: Add SetExpressCheckout api for paypal EC [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/860107 (https://phabricator.wikimedia.org/T318759) (owner: 10Wfan) [01:42:40] this is the original one https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/859142 [01:42:58] 😂 [02:45:07] turn off the update language job, since kinda finish the cleaned up locale task https://phabricator.wikimedia.org/T321251 [02:54:45] 10Fundraising-Backlog, 10FR-Smashpig: Rationalize use of ApiException vs PaymentProviderResponse error properties across all providers - https://phabricator.wikimedia.org/T323740 (10Ejegg) [02:59:39] 10Fundraising-Backlog, 10FR-Smashpig: Rationalize use of ApiException vs PaymentProviderResponse error properties across all providers - https://phabricator.wikimedia.org/T323740 (10Ejegg) [03:01:41] 10Fundraising-Backlog, 10FR-Smashpig: Rationalize use of ApiException vs PaymentProviderResponse error properties across all providers - https://phabricator.wikimedia.org/T323740 (10Ejegg) [03:07:55] ok wfan, I just had to look over the error handling for the other providers and write down what I thought made sense, before I went back to review that CreateRecurringPaymentsProfile patch [03:20:10] (03CR) 10Ejegg: "This looks great! Just one minor request to allow setting a future profile start date." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/853318 (https://phabricator.wikimedia.org/T318881) (owner: 10Wfan) [03:25:26] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations: Set financial type ID when creating ContributionRecur records - https://phabricator.wikimedia.org/T323741 (10Ejegg) [03:26:04] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations: Set financial type ID when creating ContributionRecur records - https://phabricator.wikimedia.org/T323741 (10Ejegg) Stale patch that attempted this: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/579462 [13:25:50] (03PS2) 10Damilare Adedoyin: Use labels for SmashPig recurring errors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860130 (https://phabricator.wikimedia.org/T323644) (owner: 10Ejegg) [17:59:46] (03CR) 10Jgleeson: Make errors from recurring smashpig charge job more visible (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860082 (https://phabricator.wikimedia.org/T323644) (owner: 10Damilare Adedoyin) [18:04:04] (03CR) 10Jgleeson: "In response to the question in the commit message, the answer is yes, we can remove the base Failure stats." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860130 (https://phabricator.wikimedia.org/T323644) (owner: 10Ejegg) [18:09:45] (03CR) 10Jgleeson: "This looks great. However, my inconsistent-casing-spider-sense is now tingling, failed is now Failed, while success is still lowercase. Le" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860130 (https://phabricator.wikimedia.org/T323644) (owner: 10Ejegg) [18:23:54] (03CR) 10Jgleeson: [C: 04-1] "We're also gonna need to update the code which preps the $metrics array inside the hook function to detect our new labels https://github.c" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860130 (https://phabricator.wikimedia.org/T323644) (owner: 10Ejegg) [18:25:50] damilare: ejegg|away is gonna be out today and tomorrow so it you wanna close the loop on the new Prometheus metrics by updating his follow-on patch to yours, I'm sure that would be fine [18:26:34] there's no rush though if you'd rather not [18:26:54] sure I'd do that, just checking out some things on the recurring flow [18:27:16] I'd get to it before my end of day and we could talk about it tomorrow [18:27:43] yeah sounds good. I'm finishing soon also so if you wanna leave it until tomorrow that is fine too [18:28:30] I'm also wondering why we need to make changes to that wmf_civicrm_civicrm_smashpig_stats function [18:29:12] given it's only concatenating the smashpig location to the metric label [18:29:36] lemme take a look [18:30:30] I think it's the last comment you dropped [18:31:39] oh I see what you mean [18:32:01] so we should end up with something like 'recurring_smashpig_failed{error="declined"}' [18:32:13] yhh [18:32:28] yeah you're right lemme retract that last comment [18:33:11] (03CR) 10Jgleeson: Use labels for SmashPig recurring errors (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860130 (https://phabricator.wikimedia.org/T323644) (owner: 10Ejegg) [19:30:20] jgleeson, the Completedlabel is the one in use at the metric level and it's uppercase:dev/src/civi-sites/wmff/drupal/sites/default/civicrm/extensions/org.wikimedia.smashpig/CRM/Core/Payment/SmashPigRecurringProcessor.php:128 [19:31:50] given the fact we are removing the "failed" unaggregated stat, I'm thinking we should leave the casing. They'd all be changed to lowercase here anyway: \lcStatus [19:32:20] dev/src/civi-sites/wmff/drupal/sites/all/modules/wmf_civicrm/wmf_civicrm.hooks.php:15 [19:32:50] what do you think? [19:35:35] (03PS3) 10Damilare Adedoyin: Use labels for SmashPig recurring errors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860130 (https://phabricator.wikimedia.org/T323644) (owner: 10Ejegg) [19:41:37] (03CR) 10Damilare Adedoyin: "Thanks for the review jgleeson, I've made the changes given ejegg is out today. I also left some comments inline." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860130 (https://phabricator.wikimedia.org/T323644) (owner: 10Ejegg) [20:21:45] (03PS1) 10AndyRussG: Implement PayPal EC ManageRecurringPaymentsProfileStatusCancel API call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/860643 (https://phabricator.wikimedia.org/T318883) [20:23:08] fr-tech ^ [22:19:17] (03PS1) 10Umherirrender: tests: Replace assertEmpty with assertSame [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/860683 [22:21:42] (03CR) 10CI reject: [V: 04-1] tests: Replace assertEmpty with assertSame [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/860683 (owner: 10Umherirrender) [22:53:51] (03PS2) 10Umherirrender: tests: Replace assertEmpty with assertSame [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/860683 [22:56:00] (03CR) 10CI reject: [V: 04-1] tests: Replace assertEmpty with assertSame [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/860683 (owner: 10Umherirrender) [22:58:10] (03PS3) 10Umherirrender: tests: Replace assertEmpty with assertSame [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/860683