[06:28:59] (03CR) 10AndyRussG: "hi!!! thanks so so much for all this!! really cool!! :)" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/859142 (https://phabricator.wikimedia.org/T318759) (owner: 10Wfan) [09:23:58] 10Fundraising-Backlog, 10fr-donorservices: Unresponsive donation form 11/24/22 - https://phabricator.wikimedia.org/T323895 (10krobinson) [09:29:13] 10Fundraising-Backlog, 10fr-donorservices: Unresponsive donation form 11/24/22 - https://phabricator.wikimedia.org/T323895 (10krobinson) [10:18:04] 10fundraising-tech-ops: Fundraising access request for Emma Hughes - https://phabricator.wikimedia.org/T323729 (10ehughes) Hi @Dwisehaupt here's the public key for my ssh keypair: ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIBGMKizxsslWM4FY5+g86i3ae7sNT30k2wqv5Ssl/5QE ehughes@wikimedia.org [13:48:14] (03PS1) 10Damilare Adedoyin: Set financial type ID when creating ContributionRecur records [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/861390 (https://phabricator.wikimedia.org/T323741) [14:00:13] (03CR) 10CI reject: [V: 04-1] Set financial type ID when creating ContributionRecur records [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/861390 (https://phabricator.wikimedia.org/T323741) (owner: 10Damilare Adedoyin) [14:13:21] (03PS2) 10Damilare Adedoyin: Set financial type ID when creating ContributionRecur records [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/861390 (https://phabricator.wikimedia.org/T323741) [14:59:56] 10Fundraising Tech - Chaos Crew: dLocal Insecure Form warnings - https://phabricator.wikimedia.org/T318742 (10Damilare) Tested this and I only saw the "information not secure" error when the Callback URL is set on an HTTP address. The error didn't come up when I changed to https with my proxy forwarding URL in t... [15:54:22] (03CR) 10Ejegg: "Looks like we use a different Exception class for the similar situation in other processors" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/857150 (https://phabricator.wikimedia.org/T322570) (owner: 10Wfan) [16:27:55] 10Fundraising-Backlog, 10fr-donorservices: Unresponsive donation form 11/24/22 - https://phabricator.wikimedia.org/T323895 (10Pcoombe) Thanks for logging it. Can't see any outages on https://www.wikimediastatus.net/#week at that time. There's nothing in [donatewiki recent changes](https://donate.wikimedia.org/... [16:29:52] 10Fundraising-Backlog, 10fr-donorservices: Unresponsive donation form 11/24/22 - https://phabricator.wikimedia.org/T323895 (10krobinson) Did we throttle the UK send, @nisrael ? Were emails still going out at this time? Thanks! [16:31:40] 10Fundraising-Backlog, 10fr-donorservices: Unresponsive donation form 11/24/22 - https://phabricator.wikimedia.org/T323895 (10greg) Just posting this link for now. We were definitely processing donations at that time: https://frmon.wikimedia.org/d/R5m3iU1Wk/queue?orgId=1&from=1669298635343&to=1669334289866 A... [16:57:35] 10fundraising-tech-ops: Fundraising access request for Panagiotis Penloglu - https://phabricator.wikimedia.org/T323708 (10Dwisehaupt) [16:58:30] 10fundraising-tech-ops: Fundraising access request for Panagiotis Penloglu - https://phabricator.wikimedia.org/T323708 (10Dwisehaupt) Verified ssh access is not required at this point. `Date: Wed, 23 Nov 2022 22:40:59 From: Danny Bu To: Dallas Wisehaupt Subject: Re: Access to Civi and Superset for Panos Penglol... [18:48:07] 10fundraising-tech-ops: Fundraising access request for Emma Hughes - https://phabricator.wikimedia.org/T323729 (10Dwisehaupt) Thanks @ehughes. I'll be sending on the instructions for testing your connection in just a few minutes. [18:48:29] 10fundraising-tech-ops: Fundraising access request for Emma Hughes - https://phabricator.wikimedia.org/T323729 (10Dwisehaupt) [18:48:36] (03CR) 10Ejegg: "Please let's not remove the failed txn IDs from the API output." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860130 (https://phabricator.wikimedia.org/T323644) (owner: 10Ejegg) [18:54:13] (03CR) 10Jgleeson: Use labels for SmashPig recurring errors (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860130 (https://phabricator.wikimedia.org/T323644) (owner: 10Ejegg) [18:57:35] 10fundraising-tech-ops: Fundraising access request for Emma Hughes - https://phabricator.wikimedia.org/T323729 (10Dwisehaupt) a:03Dwisehaupt [18:57:46] (03CR) 10Jgleeson: Use labels for SmashPig recurring errors (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860130 (https://phabricator.wikimedia.org/T323644) (owner: 10Ejegg) [18:57:58] 10fundraising-tech-ops: Fundraising access request for Amy Fowler - https://phabricator.wikimedia.org/T323528 (10Dwisehaupt) a:03Dwisehaupt [18:58:09] 10fundraising-tech-ops: Fundraising access request for Panagiotis Penloglu - https://phabricator.wikimedia.org/T323708 (10Dwisehaupt) a:03Dwisehaupt [19:03:58] 10fundraising-tech-ops: Fundraising access request for Panagiotis Penloglu - https://phabricator.wikimedia.org/T323708 (10Dwisehaupt) [19:04:48] 10fundraising-tech-ops: Fundraising access request for Panagiotis Penloglu - https://phabricator.wikimedia.org/T323708 (10Dwisehaupt) 05Open→03Resolved `Date: Mon, 28 Nov 2022 02:20:50 From: Panagiotis Penloglou To: Dallas Wisehaupt Subject: Re: Civi and Superset access --------------------------------------... [19:06:39] 10fundraising-tech-ops: Fundraising access request for Amy Fowler - https://phabricator.wikimedia.org/T323528 (10Dwisehaupt) [19:07:24] 10fundraising-tech-ops: Fundraising access request for Amy Fowler - https://phabricator.wikimedia.org/T323528 (10Dwisehaupt) 05Open→03Resolved ` Date: Mon, 28 Nov 2022 04:27:45 From: Amy Fowler To: Dallas Wisehaupt Subject: Re: Fundraising account setup ---------------------------------------- Hi Dallas,  T... [20:02:19] (03CR) 10Wfan: Add error handling and mapping error for Smashpig PayPal EC GetExpressCheckoutDetails API call (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/857150 (https://phabricator.wikimedia.org/T322570) (owner: 10Wfan) [20:06:49] (03PS4) 10Damilare Adedoyin: Use labels for SmashPig recurring errors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860130 (https://phabricator.wikimedia.org/T323644) (owner: 10Ejegg) [20:24:54] 10Fundraising Tech - Chaos Crew: Name changes required for Ingenico 3DS2.0 - https://phabricator.wikimedia.org/T312877 (10greg) p:05Medium→03High Setting to high given the change in timeline. [20:31:58] (03PS5) 10Damilare Adedoyin: Use labels for SmashPig recurring errors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860130 (https://phabricator.wikimedia.org/T323644) (owner: 10Ejegg) [20:32:47] (03CR) 10AndyRussG: "Regarding which method name to use, it looks like for both Adyen and Braintree, we implement IPaymentProvider::createPayment() for the fir" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/859142 (https://phabricator.wikimedia.org/T318759) (owner: 10Wfan) [20:35:44] (03PS6) 10Damilare Adedoyin: Use labels for SmashPig recurring errors [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860130 (https://phabricator.wikimedia.org/T323644) (owner: 10Ejegg) [20:36:50] (03CR) 10Damilare Adedoyin: Use labels for SmashPig recurring errors (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/860130 (https://phabricator.wikimedia.org/T323644) (owner: 10Ejegg) [20:41:03] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Unresponsive donation form 11/24/22 - https://phabricator.wikimedia.org/T323895 (10greg) p:05Triage→03High Setting to High as this doesn't seem to be on-going (so not UBN!) and it needs some more investigation. From Dallas in st... [20:41:53] 10Fundraising-Backlog: Adyen form requested for Czech Republic for Q3 testing - https://phabricator.wikimedia.org/T323715 (10XenoRyet) a:05XenoRyet→03None [20:49:55] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Unresponsive donation form 11/24/22 - https://phabricator.wikimedia.org/T323895 (10jgleeson) This is weird. I can't find any log hits for the email address associated with the c_id on the first one. Did we get a contribution tracki... [20:52:51] 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 10Patch-For-Review: Set financial type ID when creating ContributionRecur records - https://phabricator.wikimedia.org/T323741 (10XenoRyet) [21:17:25] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Make Donations queue consumer wait for new messages - https://phabricator.wikimedia.org/T323657 (10Dwisehaupt) [21:19:11] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Mobile: Mobile version of Special:CentralNotice shouldn't load complete list by default - https://phabricator.wikimedia.org/T323864 (10Dwisehaupt) [21:25:52] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Check out whether we can speed up 'update address' - https://phabricator.wikimedia.org/T323857 (10Dwisehaupt) [21:26:13] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Check out whether we can speed up 'update address' - https://phabricator.wikimedia.org/T323857 (10jgleeson) The metric is called //civicrm_import_message_location_update_average_process_time// and the code where this is measured is [[ https://github.com/... [21:27:21] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Check out whether we can speed up 'update address' - https://phabricator.wikimedia.org/T323857 (10Dwisehaupt) [21:28:23] 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Recurring-Donations, 10Patch-For-Review: Set financial type ID when creating ContributionRecur records - https://phabricator.wikimedia.org/T323741 (10Dwisehaupt) [21:29:31] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Mobile: Mobile version of Special:CentralNotice shouldn't load complete list by default - https://phabricator.wikimedia.org/T323864 (10Pcoombe) The best fix would probably be to move archived campaigns to a separate page. At the moment even on de... [21:31:12] 10Fundraising-Backlog: Add ApiException for Braintree Api Call invalid response - https://phabricator.wikimedia.org/T323660 (10AnnWF) [21:31:14] 10Fundraising-Backlog, 10FR-Smashpig: Rationalize use of ApiException vs PaymentProviderResponse error properties across all providers - https://phabricator.wikimedia.org/T323740 (10AnnWF) [21:32:19] 10Fundraising-Backlog, 10FR-Smashpig: Rationalize use of ApiException vs PaymentProviderResponse error properties across all providers - https://phabricator.wikimedia.org/T323740 (10Ejegg) 05duplicate→03Open I think this is separate from the Braintree work [21:34:08] 10Fundraising-Backlog, 10FR-Smashpig: Rationalize use of ApiException vs PaymentProviderResponse error properties across all providers - https://phabricator.wikimedia.org/T323740 (10Dwisehaupt) [21:35:14] 10Fundraising-Backlog: Adyen form requested for Czech Republic for Q3 testing - https://phabricator.wikimedia.org/T323715 (10Dwisehaupt) [21:40:00] 10Fundraising-Backlog: Add ApiException for Braintree Api Call invalid response - https://phabricator.wikimedia.org/T323660 (10Dwisehaupt) [21:42:25] 10Fundraising-Backlog: Add ability to have payment methods as variants in ReferenceData - https://phabricator.wikimedia.org/T323658 (10Dwisehaupt) [21:47:08] 10Fundraising-Backlog, 10FR-Japan, 10fr-donorservices: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10TSkaff) @Ejegg Hi Elliott, just checking in: Do these variants seem reasonable to test in Q3? Any blockers you spot, or do we need to simplify anything? We also resp... [21:55:03] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/861390 (https://phabricator.wikimedia.org/T323741) (owner: 10Damilare Adedoyin) [22:07:09] (03Merged) 10jenkins-bot: Set financial type ID when creating ContributionRecur records [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/861390 (https://phabricator.wikimedia.org/T323741) (owner: 10Damilare Adedoyin) [22:10:19] phab loading for other folks? [22:11:51] ejegg: maintenance again [22:12:04] ah cool [23:15:24] 10Fundraising-Backlog, 10fr-donorservices: Report potential unintended duplicate donations - https://phabricator.wikimedia.org/T312964 (10Cstone) Hi @MBeat33 I made a duplicate searchkit for people who had more than 3 donations in a 7 day period here https://civicrm.wikimedia.org/civicrm/search#/display/Donors... [23:23:08] 10Fundraising-Backlog, 10FR-Smashpig: PaymentProviders capabilities should be clearly indicated by interfaces - https://phabricator.wikimedia.org/T323962 (10Ejegg) [23:26:54] 10Fundraising-Backlog, 10fr-donorservices: Report potential unintended duplicate donations - https://phabricator.wikimedia.org/T312964 (10MBeat33) Wow, this is rad, thank you @Cstone ! I will share with DR team. [23:30:19] (03PS1) 10Jgleeson: Add new 'donations_total_messages_import_time' metric [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/861495 (https://phabricator.wikimedia.org/T323273) [23:32:02] ejegg: that new dupe-excluding processing time stat is in that patch ^ [23:33:15] I feel bad uploading it in that form as I'd really like to refactor it and the stats collector to add in some new features to make it much cleaner but we're probably out of time if we wanna go live with it before 9am UTC [23:33:43] I tested it locally and it worked good me, lemme add instructions real quick on the ticket [23:33:49] for* [23:33:57] thanks! [23:34:00] I'll take a look [23:35:09] jgleeson: ahh, so this is a solution that doesn't need an update to your library? [23:35:23] yeah [23:35:30] it's a workaround [23:35:40] ok, cool, i think i see how it works [23:36:40] though I guess for a workaround we could just use a local var and time() rather than the temporary timer var [23:37:09] err, temporary timer stat [23:38:03] jgleeson: would that be a bit cleaner for now? [23:38:31] hmm [23:39:12] I don't know if that would make it cleaner [23:39:19] maybe the same code just done differently [23:39:45] we get some benefits using the timer stuff [23:40:20] oh ok, i thought it was just $start = microtime(); ... $diff = microtime() - start; [23:40:57] yeah that's pretty much all it does while adding it to a namespace [23:41:55] ok, so with this patch, if I added the 'wait for new donations' behavior, this new stat would still be a good processing rate metric [23:42:30] but the existing processing rate stat will be distorted [23:42:40] so historical comparisons will be hard [23:42:56] I guess we can easily add it [23:43:30] we can add this stat that is [23:43:33] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Update DonationStatsCollector to factor in the duplicate donations when calculating processing rates and run time. - https://phabricator.wikimedia.org/T323273 (10jgleeson) How to test: - pull the patch - submit a couple of donati... [23:43:47] sorry, I need to help with dinner [23:44:32] yeah this one should be easy enough but if we're gonna add more to this area we should probably look at the wider refactor just to put it all in one place and tidy up the scattered parts [23:55:29] ok bed time [23:55:32] bye for now [23:55:36] night jgleeson [23:55:40] night cstone !