[02:54:45] ejegg: thx for all that work on donut... sorry I haven't gotten to checking it out yet! [02:55:48] smol request ,if you have the chance to give a possible +1 here before your long weekend, that'd be swell https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/854091 [02:57:06] oh sure, looking now [02:58:59] thx!!!!! [03:06:44] AndyRussG: is it OK that the comment is inserted just above the footer in the HTML? [03:06:59] I guess from the name of the hook I would have expected it a bit higher in the page [03:07:39] ejegg: hmm I thought it was higher.... one sec [03:08:04] on my local wiki the page content definitely comes first [03:10:36] ejegg: yeah same here... I guess I just hadn't checked carefully where it was inserted [03:10:39] yes it's fine there also [03:11:00] so this is just a test, and in the test ESI would be used to replace this comment with another [03:11:59] the reason for moving it to this hook is that the mobile skin was clobbering it on prod, so it wasn't getting injected on mobile [03:12:20] ok, so once the concept is proven we can move it to a different hook that shows up nearer the top for banner convenience? [03:12:55] ejegg: yes, so that will likely require a change in core (just adding a new parameter to another hook) [03:13:08] but at this point for the initial tests it doesn't matter [03:13:32] the comment can be anywhere in the HTML provided it's not somehow breaking something [03:17:26] k, cool, in that case I'd be happy to even +2 [03:17:36] the code looks low-risk [03:18:18] ejegg: I'm tempted to suggest you do so, but we have already asked for additional review from elsewhere, just basically out of abundance of caution [03:18:32] but that may indeed end up being the way to go [03:18:52] but yeah I guess for now let's keep it to +1 [03:19:02] does that sound okok? [03:19:40] 10Fundraising-Backlog, 10FR-India, 10FR-dlocal, 10Recurring-Donations: Support India Network Tokenization (recurring credit cards) for DLocal - https://phabricator.wikimedia.org/T324304 (10Ejegg) [03:19:49] ok, sure [03:19:53] thx!!! [03:21:06] that little bit of futzing to get my 1.39 wiki working has me wanting to start looking at what'll be needed to make DI compatible with new LTS [03:22:16] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Implement cancelPayment for DLocal - https://phabricator.wikimedia.org/T324727 (10Ejegg) [03:22:31] phew, tonight seems to mark the start of fireworks month here [03:22:40] thankfully the kiddo just giggles at the explosions [03:22:47] awww heheheh [03:23:00] glad she's able to keep in touch with both cultures and sides of the family [03:24:14] (03CR) 10Ejegg: [C: 03+1] "The code looks fine to me, and it works on my machine. Displays the comment just above the footer, but should be fine for an initial test." [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/854091 (https://phabricator.wikimedia.org/T320734) (owner: 10AndyRussG) [03:24:47] "displays"? [03:24:56] sorry, injects [03:25:25] (03CR) 10Ejegg: [C: 03+1] Move test ESI injection to BeforePageDisplay hook (031 comment) [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/854091 (https://phabricator.wikimedia.org/T320734) (owner: 10AndyRussG) [03:25:48] :) thx much!!!! [03:31:01] 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface, 10Recurring-Donations: Dlocal - Ensure all Monthly Convert templates are built by FRTech for all markets - https://phabricator.wikimedia.org/T324624 (10Ejegg) [03:31:22] :) [03:32:04] ok, gonna sign off [03:32:29] have a good rest of week and weekend, and I hope you feel better soon! [03:36:19] ejegg|away: thx!! [04:11:21] (03PS1) 10Wfan: Add Skeleton for Dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/865833 (https://phabricator.wikimedia.org/T324270) [04:13:44] (03CR) 10CI reject: [V: 04-1] Add Skeleton for Dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/865833 (https://phabricator.wikimedia.org/T324270) (owner: 10Wfan) [04:15:14] (03PS2) 10Wfan: Add Skeleton for Dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/865833 (https://phabricator.wikimedia.org/T324270) [04:17:24] (03CR) 10CI reject: [V: 04-1] Add Skeleton for Dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/865833 (https://phabricator.wikimedia.org/T324270) (owner: 10Wfan) [04:48:25] (03PS1) 10Eileen: Add on_hold information to the deduper interface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/865839 (https://phabricator.wikimedia.org/T321843) [04:53:44] 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Addition to the Deduper Interface - https://phabricator.wikimedia.org/T321843 (10Eileenmcnaughton) I've put up a patch for review that makes the on-hold-ness visible in the UI per the screen shots... [05:02:26] (03PS3) 10Wfan: Add Skeleton for Dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/865833 (https://phabricator.wikimedia.org/T324270) [05:04:15] (03CR) 10CI reject: [V: 04-1] Add Skeleton for Dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/865833 (https://phabricator.wikimedia.org/T324270) (owner: 10Wfan) [05:14:52] 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Diffusion-Repository-Administrators, and 5 others: Archive the fundraising/crm/civicrm repo - https://phabricator.wikimedia.org/T324732 (10Eileenmcnaughton) [05:16:53] 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, and 3 others: Decommission Fundraising's crm/civicrm git repo - https://phabricator.wikimedia.org/T314995 (10Eileenmcnaughton) @Aklapper you are c... [06:52:32] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/865918 (owner: 10L10n-bot) [07:33:03] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/866175 (owner: 10L10n-bot) [09:00:15] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/866175 (owner: 10L10n-bot) [09:32:05] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/865291 (owner: 10L10n-bot) [10:09:09] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/865918 (owner: 10L10n-bot) [11:32:57] 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Diffusion-Repository-Administrators, and 5 others: Archive the fundraising/crm/civicrm repo - https://phabricator.wikimedia.org/T324732 (10Aklapper) [16:29:25] (03CR) 10Damilare Adedoyin: "Thanks for working on this Eileen, tested and I can see the "on hold" label in the dedupe screen as described in the feature request." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/865839 (https://phabricator.wikimedia.org/T321843) (owner: 10Eileen) [16:59:35] 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface, 10Recurring-Donations: Dlocal - Ensure all Monthly Convert templates are built by FRTech for all markets - https://phabricator.wikimedia.org/T324624 (10EMartin) @ejegg Can we not use UPI AutoPay? This is pretty critical to the... [19:44:45] 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Addition to the Deduper Interface - https://phabricator.wikimedia.org/T321843 (10SHust) @Eileenmcnaughton thank you, we'll test it out. If you think that there's a way to pull queries without the... [19:47:12] 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Addition to the Deduper Interface - https://phabricator.wikimedia.org/T321843 (10Eileenmcnaughton) @SHust for clarity - it isn't deployed yet. I need to fix some errors Dami found in review & get... [19:49:40] 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10fr-donorservices, 10Patch-For-Review: Addition to the Deduper Interface - https://phabricator.wikimedia.org/T321843 (10SHust) @Eileenmcnaughton gotcha, thanks for the update! [20:18:15] 10Fundraising-Backlog, 10fr-donorservices: CIVI error displaying contribs for cid=11355636 - https://phabricator.wikimedia.org/T324787 (10MBeat33) [20:31:54] (03PS3) 10Damilare Adedoyin: [WIP] IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [20:33:50] (03CR) 10CI reject: [V: 04-1] [WIP] IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [20:38:07] (03PS4) 10Damilare Adedoyin: [WIP] IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [20:39:58] (03CR) 10CI reject: [V: 04-1] [WIP] IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [20:43:14] (03PS5) 10Damilare Adedoyin: [WIP] IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [20:53:51] (03PS6) 10Jgleeson: [WIP] IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [22:32:45] (03CR) 10Jgleeson: [C: 04-1] "Thanks for the updates and digging in on this tricky part of the code." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [22:51:47] (03PS1) 10Cstone: Add Google Wallet as a payment method [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/866515 [22:52:54] (03CR) 10Jgleeson: [C: 03+2] "LGTM" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/866515 (owner: 10Cstone) [22:53:07] thanks jgleeson [22:53:25] (03Merged) 10jenkins-bot: Add Google Wallet as a payment method [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/866515 (owner: 10Cstone) [22:53:48] np [23:30:39] (03PS4) 10Wfan: Add Skeleton for Dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/865833 (https://phabricator.wikimedia.org/T324270) [23:32:30] (03CR) 10CI reject: [V: 04-1] Add Skeleton for Dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/865833 (https://phabricator.wikimedia.org/T324270) (owner: 10Wfan) [23:48:36] (03PS5) 10Wfan: Add Skeleton for Dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/865833 (https://phabricator.wikimedia.org/T324270) [23:55:04] 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Render card SmartField on DLocal form - https://phabricator.wikimedia.org/T324271 (10AnnWF) a:03AnnWF