[04:23:53] (03CR) 10AndyRussG: "Thanks so much for all this!!! Woohoo more steps towards Drupal independence! All the code here looks great. Please see inline comments on" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871918 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [04:30:21] (03CR) 10AndyRussG: Move Payment instrument installation to Managed system (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871918 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [04:32:28] (03PS4) 10Eileen: Move Payment instrument installation to Managed system [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871918 (https://phabricator.wikimedia.org/T270680) [04:32:42] (03CR) 10Eileen: Move Payment instrument installation to Managed system (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871918 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [04:32:55] AndyRussG: I made some changes to the commit message [04:33:30] ah okii thx [04:37:44] (03CR) 10AndyRussG: Move Payment instrument installation to Managed system (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871918 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [04:39:20] (03PS5) 10Eileen: Move Payment instrument installation to Managed system [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871918 (https://phabricator.wikimedia.org/T270680) [04:39:31] (03CR) 10Eileen: "Ah ok - you are right" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871918 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [04:51:58] (03CR) 10AndyRussG: [C: 03+2] "Woohhoo cool beans!!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871918 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [04:52:17] thx eileen! [04:52:45] yay thanks [04:53:46] eileen: :) moving on to the next one [04:54:17] if you can think of any digging I should do on the bus error pls lmk, though it seems continuing down the CR road is probably best [04:54:25] yep - the next one is just removal [04:54:33] also heads-up tomorrow is a WMF global holiday [04:55:08] the bus error is an odd one - I'm pondering - but I'm pretty sure it is file access by more than one process - with one whipping it out from under the other [04:55:26] hmmm interesting [04:56:03] I'm trying to see if the more recent smarty version handles it differently [04:57:00] ah oki [05:02:11] AndyRussG: thanks for telling me re holiday [05:03:39] yw :) [05:03:59] eileen: wrt the first patch on the chain https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/871918 it says "ready to submit" but does not seem to merge [05:04:08] shall I click "Submit"? [05:04:34] ah yeah - maybe the comments aren't acked so yes please [05:05:49] oh is that it? wow that's a new "feature" [05:06:11] (03Merged) 10jenkins-bot: Move Payment instrument installation to Managed system [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871918 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [05:06:58] hmmm not sure that was me [05:12:51] the chain seems happy - it still knows the patch is the 'right one' even though I edited it [05:14:57] the happy chains of unthinking silicon [05:15:57] lol [05:16:52] in any case merging should be fine since nothing in the actual code changed in the first one [06:01:50] (03CR) 10AndyRussG: "Heyyy this also looks straightforward and completely fine codewise... Just a few tidbits:" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871920 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [06:02:25] (03PS3) 10AndyRussG: Remove code to update offline receipts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871920 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [06:02:40] eileen: ^ [06:02:58] oh cool - will look [06:03:05] thx! [06:03:45] (03CR) 10CI reject: [V: 04-1] Remove code to update offline receipts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871920 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [06:05:01] (03CR) 10AndyRussG: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871920 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [06:05:49] (03PS4) 10Eileen: Remove code to update offline receipts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871920 (https://phabricator.wikimedia.org/T270680) [06:07:23] (03CR) 10Eileen: "Andy I updated the phab into the commit message but removing that checkbox by removing those lines is hacking core so there is an ongoing " [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871920 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [06:12:46] (03CR) 10AndyRussG: [C: 03+2] "Thx!!!! :) :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871920 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [06:16:04] well that's all for my brain for today...... cya! thx! :) [06:17:16] night - thanks for the review [06:17:23] :) [06:26:32] (03Merged) 10jenkins-bot: Remove code to update offline receipts [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871920 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [06:45:52] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: DB Error 'No such field' when sorting Civi advanced search results by country - https://phabricator.wikimedia.org/T324288 (10Eileenmcnaughton) Although I argued for low priority here I've been digging into this today - 2... [07:03:52] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/874082 (owner: 10L10n-bot) [07:47:56] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/874273 (owner: 10L10n-bot) [07:48:00] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/874283 (owner: 10L10n-bot) [07:50:41] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/874273 (owner: 10L10n-bot) [07:50:58] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/874283 (owner: 10L10n-bot) [07:52:55] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/FundraisingEmailUnsubscribe] - 10https://gerrit.wikimedia.org/r/874283 (owner: 10L10n-bot) [08:17:25] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/874082 (owner: 10L10n-bot) [09:20:35] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] build: Remove syntax option from stylelint [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/856687 (owner: 10Umherirrender) [18:01:29] (03CR) 10AndyRussG: [C: 03+2] "Thanks!!! Just noting here what code review has involved:" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/872495 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [18:40:41] (03CR) 10AndyRussG: [C: 03+2] "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/872495 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [18:40:53] (03CR) 10CI reject: [V: 04-1] Remove moneyFormat setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/872495 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [18:43:06] (03PS2) 10AndyRussG: Remove moneyFormat setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/872495 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [18:44:07] (03CR) 10AndyRussG: [C: 03+2] Remove moneyFormat setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/872495 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [18:46:10] (03PS3) 10AndyRussG: Remove earlier attempts to cleanup languages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871921 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [18:47:19] (03PS4) 10AndyRussG: Move declaration of Dedupe fishing net rule to managed entities [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/872497 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [18:47:24] (03PS6) 10AndyRussG: Move enabling CiviCampaign to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/872496 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [18:47:31] (03PS2) 10AndyRussG: Move creating of AddressHistory tab to managed [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/872500 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [18:47:42] (03PS2) 10AndyRussG: Remove now do-nothing install function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/872501 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [18:48:02] (03PS2) 10AndyRussG: Remove the various historical data cleanups from the install script [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/872502 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [18:48:11] (03PS2) 10AndyRussG: Remove install script section on status preferences [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/872503 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [18:48:18] (03PS2) 10AndyRussG: Remove upgrade to add primary key to civicrm_deleted_email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/872505 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [18:58:42] (03Merged) 10jenkins-bot: Remove moneyFormat setting [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/872495 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [19:12:15] (03CR) 10AndyRussG: "Cool, thanks!! :) See inline about another file that I think would be deleted with this patch?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871921 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [19:59:26] (03PS4) 10Eileen: Remove earlier attempts to cleanup languages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871921 (https://phabricator.wikimedia.org/T270680) [20:01:12] (03PS1) 10Eileen: Remove old cleanup function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/874437 (https://phabricator.wikimedia.org/T270680) [20:05:02] (03CR) 10Eileen: "Yep good spotting - removed. I also put up a patch for another similar file that got missed in last year's cleanup" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871921 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [21:33:55] (03CR) 10AndyRussG: [C: 03+2] "Woohooo nice! Thanks!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871921 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [21:34:23] (03CR) 10AndyRussG: [C: 03+2] "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871921 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [21:48:02] (03Merged) 10jenkins-bot: Remove earlier attempts to cleanup languages [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/871921 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [21:52:28] yay