[00:09:48] (03PS1) 10Bartosz Dziewoński: Avoid deprecated override for IndexPager::makeLink [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/875451 (https://phabricator.wikimedia.org/T317916) [00:11:33] (03CR) 10Bartosz Dziewoński: "I don't have this extension set up locally to test this, but it seems that it should work exactly the same. Various other extensions overr" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/875451 (https://phabricator.wikimedia.org/T317916) (owner: 10Bartosz Dziewoński) [09:42:10] PROBLEM - check_log_messages on frav1002 is CRITICAL: reading conf /etc/check_log_messages.conf https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [09:47:16] RECOVERY - check_log_messages on frav1002 is OK: reading conf /etc/check_log_messages.conf https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [11:44:02] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Implement DLocal signature calculation in SmashPig - https://phabricator.wikimedia.org/T324274 (10jgleeson) [11:44:15] hi fr-tech! [11:45:41] music for today starts with "This Music Turns your Bread into Cake and your Water into Wine" [11:45:55] the title caught my eye https://www.youtube.com/watch?v=EoYk1reppIo [12:00:36] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/FundraisingEmailUnsubscribe] (REL1_38) - 10https://gerrit.wikimedia.org/r/875043 (owner: 10L10n-bot) [12:01:36] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/875036 (owner: 10L10n-bot) [13:21:32] 10Fundraising-Backlog: How can we build in donor control of their recurring donation? - https://phabricator.wikimedia.org/T325317 (10MSuijkerbuijk_WMF) As per Evelyn's last point, it'd be great to confirm if the current Acoustic field 'AF_latest_native_amount' reflects the recurring amount for active recurring d... [13:59:41] (03PS1) 10Jgleeson: WIP: add dLocal request headers [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/875898 (https://phabricator.wikimedia.org/T324274) [14:05:32] (03CR) 10CI reject: [V: 04-1] WIP: add dLocal request headers [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/875898 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [14:28:02] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Implement approvePayment for DLocal in SmashPig - https://phabricator.wikimedia.org/T324281 (10Damilare) a:03Damilare [14:33:46] (03CR) 10Damilare Adedoyin: [C: 03+2] Add dLocal Skeleton for SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/875425 (https://phabricator.wikimedia.org/T324273) (owner: 10Jgleeson) [14:34:17] (03Merged) 10jenkins-bot: Add dLocal Skeleton for SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/875425 (https://phabricator.wikimedia.org/T324273) (owner: 10Jgleeson) [14:35:05] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Implement createPayment for DLocal CC / SmartFields in SmashPig - https://phabricator.wikimedia.org/T324279 (10Damilare) a:03Damilare [14:35:41] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Implement approvePayment for DLocal in SmashPig - https://phabricator.wikimedia.org/T324281 (10Damilare) a:05Damilare→03None [14:41:18] thanks damilare ! [14:41:38] np jgleeson|skrun [15:59:16] jgleeson|ish: we'd have way too much wine with that playing today given how much rain we got last night. Our 500 gallons of rain water in the barrels is full! [16:36:22] woah greg-g that's a lot [16:36:44] is too much wine really a bad thing ?! [16:37:18] (03PS21) 10Damilare Adedoyin: IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [16:37:20] 10 x 50 gallon barrels, just lined up under the roof edge on the north side of the house, not even connected to a gutter system (we don't have one) [16:39:29] where are you based greg-g ? [16:39:50] sounds like a lot of rain to fill those [16:54:12] (03PS22) 10Damilare Adedoyin: IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [17:07:22] (03PS1) 10Wfan: Redirect to donate wiki if no country or payment_method pass from url [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/875976 (https://phabricator.wikimedia.org/T324706) [17:11:59] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Handle donors reaching payment forms with no payment_method - https://phabricator.wikimedia.org/T140269 (10AnnWF) [17:12:03] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Handle the GatewayChooser error handling nicer - https://phabricator.wikimedia.org/T324706 (10AnnWF) [17:39:54] (03CR) 10Ejegg: [C: 04-1] Redirect to donate wiki if no country or payment_method pass from url (032 comments) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/875976 (https://phabricator.wikimedia.org/T324706) (owner: 10Wfan) [17:47:43] Thanks elliott for the review, will do the update, and add the unit test thanks~ [17:47:54] sure thing! [17:49:15] fr-tech I'm going to have to start the 'upgrading mediawiki' process to get a usable MW1.39 to test DI on [17:49:23] I'm going to follow the steps on https://wikitech.wikimedia.org/wiki/Fundraising/External-facing/Payments#Upgrading_MediaWiki [17:49:38] and will update them with whatever else turns out to be needed [17:56:56] (03PS1) 10Ejegg: Remove extensions and skins not used on payments-wiki [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/875983 (https://phabricator.wikimedia.org/T324154) [17:58:57] thanks ejegg [18:04:57] (03CR) 10CI reject: [V: 04-1] Remove extensions and skins not used on payments-wiki [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/875983 (https://phabricator.wikimedia.org/T324154) (owner: 10Ejegg) [18:11:16] (03PS1) 10Ejegg: Add logos used on payments-wiki [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/875988 (https://phabricator.wikimedia.org/T324154) [18:11:20] (03PS1) 10Ejegg: Add extensions used on payments-wiki [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/875989 (https://phabricator.wikimedia.org/T324154) [18:20:02] (03CR) 10CI reject: [V: 04-1] Add logos used on payments-wiki [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/875988 (https://phabricator.wikimedia.org/T324154) (owner: 10Ejegg) [18:22:21] (03CR) 10CI reject: [V: 04-1] Add extensions used on payments-wiki [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/875989 (https://phabricator.wikimedia.org/T324154) (owner: 10Ejegg) [18:25:02] oh hey, no version conflicts on the composer install! [18:25:39] i was sure we'd have to tweak some constraints in DonationInterface/composer.json [18:27:39] Heh, just got my end of year email [18:29:36] (03PS2) 10Ejegg: Add extensions used on payments-wiki [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/875989 (https://phabricator.wikimedia.org/T324154) [18:29:38] (03PS1) 10Ejegg: Update composer.json for payments-wiki [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/875991 (https://phabricator.wikimedia.org/T324154) [18:29:56] well formatted, I hope, Xeno1 ? [18:32:27] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Make DonationInterface compatible with MediaWiki 1.39 - https://phabricator.wikimedia.org/T324154 (10Ejegg) a:03Ejegg [18:34:54] Yea, it looked good to me ;-) [18:36:27] oh hey, payments forms seem to load just fine on 1.39 locally! [18:36:46] let's look in the logs for deprecation notices... [18:37:40] ok, yep, there's a bit [18:37:42] Use of PersonalUrls hook (used in NoLoginLinkOnMainPage) was deprecated in MediaWiki 1.39. [18:38:32] is that all, though? [18:39:06] (03CR) 10CI reject: [V: 04-1] Add extensions used on payments-wiki [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/875989 (https://phabricator.wikimedia.org/T324154) (owner: 10Ejegg) [18:39:24] Deprecated: since 1.39 Use SkinTemplateNavigation__Universal instead. [18:39:32] so far not seeing other deprecation [18:40:53] nice, and that SkinTemplateNavigation__Universal hook is even available in 1.35 [18:41:00] so we should be able to deploy that fix first [18:42:03] (03CR) 10CI reject: [V: 04-1] Update composer.json for payments-wiki [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/875991 (https://phabricator.wikimedia.org/T324154) (owner: 10Ejegg) [19:03:18] fr-tech that string of patches is ready for some more local smoke testing if anyone wants to check it out ^^^ [19:14:37] (03PS2) 10Jgleeson: Add dLocal API request headers [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/875898 (https://phabricator.wikimedia.org/T324274) [19:15:01] (03CR) 10CI reject: [V: 04-1] Add dLocal API request headers [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/875898 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [19:16:03] (03PS3) 10Jgleeson: Add dLocal API request headers [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/875898 (https://phabricator.wikimedia.org/T324274) [19:49:16] (03PS2) 10Wfan: Redirect to donate wiki if no country or payment_method pass from url [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/875976 (https://phabricator.wikimedia.org/T324706) [19:50:28] (03PS3) 10Wfan: Redirect to donate wiki if no country or payment_method pass from url [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/875976 (https://phabricator.wikimedia.org/T324706) [20:05:32] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Handle donors reaching payment forms with no payment_method - https://phabricator.wikimedia.org/T140269 (10AnnWF) a:03AnnWF [20:06:16] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Handle the GatewayChooser error handling nicer - https://phabricator.wikimedia.org/T324706 (10AnnWF) 05duplicate→03Open [20:11:26] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Missing payment_method in gateway page URLs is really confusing - https://phabricator.wikimedia.org/T160968 (10AnnWF) [20:11:30] 10Fundraising Tech - Chaos Crew: exception in setClientVariables: Configuration key 'payment-provider//class' does not exist - https://phabricator.wikimedia.org/T325985 (10AnnWF) [20:11:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Handle donors reaching payment forms with no payment_method - https://phabricator.wikimedia.org/T140269 (10AnnWF) [20:13:35] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Handle donors reaching payment forms with no payment_method - https://phabricator.wikimedia.org/T140269 (10AnnWF) [20:16:19] (03PS1) 10Jgleeson: Add dlocal API request signature header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/876004 (https://phabricator.wikimedia.org/T324274) [20:18:03] damilare: is the ip velocity patch ready for another round of review [20:22:59] (03PS2) 10Jgleeson: Add dLocal API request signature header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/876004 (https://phabricator.wikimedia.org/T324274) [20:31:19] I'll take a look anyway [20:32:12] tomorrow that is. I'll see if I can chip in on anything else that needs review too [20:32:27] bye for now fr-tech [20:45:05] sorry I missed your message jgleeson|away. . I've made some changes, but I'm working on the tests now. Yes please feel free to look into it as well. [20:50:03] (03PS1) 10Ejegg: Update namespace for RemexHtml [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876007 [20:51:58] (03CR) 10CI reject: [V: 04-1] Update namespace for RemexHtml [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876007 (owner: 10Ejegg) [21:03:14] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Install `coworker` and `cv` on prod - https://phabricator.wikimedia.org/T324611 (10Jgreen) [21:17:14] (03PS2) 10Ejegg: Handle new namespace for RemexHtml [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876007 (https://phabricator.wikimedia.org/T324154) [21:19:34] (03CR) 10CI reject: [V: 04-1] Handle new namespace for RemexHtml [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876007 (https://phabricator.wikimedia.org/T324154) (owner: 10Ejegg) [21:20:43] (03PS3) 10Ejegg: Handle new namespace for RemexHtml [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876007 (https://phabricator.wikimedia.org/T324154) [21:23:05] (03PS1) 10Ejegg: Updates to paymentswiki LocalSettings for MW 1.39 [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/876014 (https://phabricator.wikimedia.org/T324154) [21:23:38] fr-tech does anynne else want to see a working local paymentswiki on MW 1.39? [21:23:51] it's surprisingly easy! [21:35:11] 10Fundraising Tech - Chaos Crew: Something is causing a lot of deadlocks in ConfigAndLog - https://phabricator.wikimedia.org/T320287 (10Eileenmcnaughton) The conflict over that table is probably because the triggers are looking up that table to get to the original currency - which as a custom field is not availa... [21:37:40] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Install `coworker` and `cv` on prod - https://phabricator.wikimedia.org/T324611 (10Jgreen) [21:41:03] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Install `coworker` and `cv` on prod - https://phabricator.wikimedia.org/T324611 (10Jgreen) [21:41:17] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Install `coworker` and `cv` on prod - https://phabricator.wikimedia.org/T324611 (10Eileenmcnaughton) @Jgreen - my take on the maintenance mode part is that it is something that would fall on us rather than fr-tech-ops to implemen... [22:07:46] 10Fundraising-Backlog: Adyen pending resolver resolved duplicate donations in the same run - https://phabricator.wikimedia.org/T326361 (10Cstone) [22:18:44] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Install `coworker` and `cv` on prod - https://phabricator.wikimedia.org/T324611 (10Jgreen) >>! In T324611#8503166, @Eileenmcnaughton wrote: > @Jgreen - my take on the maintenance mode part is that it is something that would fall... [23:14:09] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Bus error 2: The bus strikes back - https://phabricator.wikimedia.org/T326013 (10Eileenmcnaughton) Talking to Tim just now gave me an idea - the issue is the file is being recreated all the time - in this case we have tried to stop smarty from creating e... [23:20:11] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Make DonationInterface compatible with MediaWiki 1.39 - https://phabricator.wikimedia.org/T324154 (10Ejegg) The upgrade seems remarkably easy this time around! To test: * pull down this... [23:31:18] eileen: are you around to do a quick screenshare on this activity timestamp weirdness, I can't replicate it locally [23:31:42] I can in 10 - [23:31:47] thanks! [23:32:13] Just hearing about this - https://www.theguardian.com/technology/2023/jan/05/saudi-arabia-jails-two-wikipedia-staff-in-bid-to-control-content [23:34:13] theres a post in slack about about it having inaccuracies [23:35:40] which channel? [23:35:44] general [23:36:06] shall we use https://meet.google.com/odz-juym-nog?authuser=0 [23:36:13] that works [23:38:13] Lost power for a second eileen [23:38:21] ah cool [23:38:24] Coming back once wifi reboots itself [23:50:31] 10Fundraising-Backlog: Manually sent civi thank you email has a time stamp either in the past or future - https://phabricator.wikimedia.org/T326371 (10Cstone) [23:53:21] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Release-Engineering-Team, 10Continuous-Integration-Config: Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4 - https://phabricator.wikimedia.org/T326372 (10Ejegg) [23:56:32] 10Fundraising-Backlog: Manually sent civi thank you email has a time stamp either in the past or future - https://phabricator.wikimedia.org/T326371 (10Cstone) [23:56:37] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Make DonationInterface compatible with MediaWiki 1.39 - https://phabricator.wikimedia.org/T324154 (10Ejegg) Oh hey, we will need to finish T315585 before we can deploy this. [23:57:15] dwisehaupt: what's your and Jeff_Green's schedule for T315585 ? [23:57:15] T315585: Upgrading payments-wiki from buster to bullseye - https://phabricator.wikimedia.org/T315585 [23:58:00] dwisehaupt: I've been playing with the MW upgrade to the next LTS version (1.39) and it seems really easy this time around. [23:58:25] It will need PHP 7.4, though, so we wouldn't be able to deploy it till we get the payments-servers on bullseye [23:59:01] locally we've been developing on bullseye payments images for a couple months now