[00:00:41] AndyRussG: I found an error - I'll do a force push to gitlab in a few minutes to update that PR [00:06:12] ok, that's fixed [00:12:48] and looking good [00:13:36] (03PS11) 10Ejegg: Add donatewiki service [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) [00:13:38] (03PS1) 10Ejegg: Use new mediawiki-apache2 image for payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877280 [00:14:29] oops, I must have amended with no change, PS11 is totally the same as PS10 [00:18:10] (03PS1) 10Ejegg: Use new apache2 image for email-pref-ctr [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877281 [00:32:06] thx ejegg :) [00:32:35] I'm giving up on running CentralNotice qunit tests locally. I've made some headway, so I have some notes for one day when we try again. But it's just not working right now [00:35:58] (03PS1) 10AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/877282 [00:36:29] (03CR) 10AndyRussG: [C: 03+2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/877282 (owner: 10AndyRussG) [00:38:50] (03Merged) 10jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - 10https://gerrit.wikimedia.org/r/877282 (owner: 10AndyRussG) [00:40:57] hi all - not sure if anyone is like me & hasn't used the vpn in a while but my certificate had expired & apparently linux vpn users are so rare they hadn't even uploaded the new one until I contacted support - anyway might be worth grabbing the cert now so it doesn't confuse you later like it did me (the error message was - well there wasn't one) [00:41:48] - the new cert will be there when there is an update to https://office.wikimedia.org/w/index.php?title=ITS/OpenVPN_Setup&action=history or I have it already [00:44:10] cool thx eileen [00:50:51] 10Fundraising-Backlog, 10fr-donorservices: Dedupe query under certain rules no longer generating queries - https://phabricator.wikimedia.org/T326605 (10SHust) [01:04:30] 10Fundraising Sprint Amazing grep, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: DAF import error - https://phabricator.wikimedia.org/T326447 (10Eileenmcnaughton) It looks like the problem is a stray bit of data in a column way off to the right - I'm just trying to find where it is - it looks like... [01:05:16] well that was fun - the spreadsheet Melanie couldn't import had a stray bit of data ... in column 16384 [01:05:50] last column with real data in it is 37! [01:07:08] hmm - I just put the phab in ready for review - but is that confusing cos it's really just telling Melanie how to try to fix up the excel - not fr-tech review [01:14:48] cstone: I just moved that Activity date one to 'done' - but then remembered you said it hadn't been deployed - is that still the case? (I guess I can check) - also do we have a follow on to 'make sane'? [01:20:01] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/877288 [01:20:15] OK it wasn't [01:21:09] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/877288 (owner: 10Eileen) [01:28:58] !log civicrm upgraded from e3405a4e to 391e8482 [01:28:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:33:32] eileen: I dont think we have a follow on to make sane [01:33:43] ok - I should log it huh [01:42:15] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog: Unhurt our brains - activity_date_time - https://phabricator.wikimedia.org/T326606 (10Eileenmcnaughton) [01:42:37] 10Fundraising-Backlog: Unhurt our brains - activity_date_time - https://phabricator.wikimedia.org/T326606 (10Eileenmcnaughton) [01:42:42] AndyRussG: oops, found another bug in the setup script, will update the fundraising-dev patch soon [01:47:10] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog: Manually sent civi thank you email has a time stamp either in the past or future - https://phabricator.wikimedia.org/T326371 (10Eileenmcnaughton) OK I'm just gonna talk this through for clarity. We originally had a situation where the activity_date_time... [01:52:03] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Figure out storage implications of varchar vs text in possible logging solution - https://phabricator.wikimedia.org/T325789 (10Eileen... [01:53:09] oh hey, i just noticed new warnings: [01:53:11] NOTE: Do not run maintenance scripts directly, use maintenance/run.php instead! Running scripts directly has been deprecated in MediaWiki 1.40. It may not work for some (or any) scripts in the future. [01:53:29] for the importDump, update, and install [01:53:41] I suppose I could update those in the same patch [02:00:50] weird, email-pref-ctr is still crashing trying to DROP INDEX `tl_namespace` [02:01:05] every time I try to reinstall, on the old image or the new one [02:01:23] MysqlUpdater->doBacklinkingIndicesUpdate [02:02:13] got it up to date with fundraising/REL1_35, and it's got all the submodules at the right place [02:18:00] (03PS12) 10Ejegg: Add donatewiki service [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) [02:18:02] (03PS2) 10Ejegg: Use new mediawiki-apache2 image for payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877280 [02:18:04] (03PS2) 10Ejegg: Use new apache2 image for email-pref-ctr [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877281 [02:18:06] (03PS1) 10Ejegg: WIP add CentralNotice to donut [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877296 [02:20:25] ah dang, re-running setup now gets me 'The file /var/www/html/LocalSettings.php must exist and be readable. [02:23:37] hmph, install.php gives the deprecated warning, but running it with run.php doesn't work, so I [02:23:40] 'll leave it [02:26:53] (03PS1) 10Eileen: 5.57.0 updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877297 (https://phabricator.wikimedia.org/T326271) [02:26:56] (03PS13) 10Ejegg: Add donatewiki service [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) [02:26:58] (03PS3) 10Ejegg: Use new mediawiki-apache2 image for payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877280 [02:27:00] (03PS3) 10Ejegg: Use new apache2 image for email-pref-ctr [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877281 [02:27:02] (03PS2) 10Ejegg: WIP add CentralNotice to donut [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877296 [02:35:00] (03PS1) 10Ejegg: Don't set ct sequence to (nil) if already cleared [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877298 [02:35:56] (03PS1) 10Eileen: Drupal upgrade to 7.94 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) [02:42:23] aw dang, the UK satellite launch failed [02:44:16] (03PS2) 10Ejegg: 5.57.0 updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877297 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [02:44:25] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877297 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [02:47:52] (03CR) 10CI reject: [V: 04-1] Drupal upgrade to 7.94 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [02:48:57] oh, that namespace autoloader thing [02:50:40] (03PS1) 10Eileen: Move last wmf_civicrm.install functions to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877302 (https://phabricator.wikimedia.org/T270680) [02:50:50] ejegg: yah - I'll take a look [02:51:46] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/877299/1/drupal/includes/registry.inc [02:53:54] (03CR) 10CI reject: [V: 04-1] Move last wmf_civicrm.install functions to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877302 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [02:58:20] (03Merged) 10jenkins-bot: 5.57.0 updates [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877297 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [02:59:23] (03PS2) 10Eileen: Drupal upgrade to 7.94 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) [02:59:25] (03PS1) 10Eileen: Move ImportStatsCollector to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877303 (https://phabricator.wikimedia.org/T326271) [02:59:38] ejegg: I was thinking along the lines of https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/877303 [02:59:47] (will need a couple more like that but...) [02:59:58] oh sure, sounds good to me! [03:01:16] I'm gonna deploy just the civi patch now - to get that out - since the drupal one will take a few rounds with gerrit [03:01:51] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/877304 [03:01:53] (03CR) 10Ejegg: "Can remove it from wmf_civicrm.info too:" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877303 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:02:01] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/877304 (owner: 10Eileen) [03:03:30] (03PS2) 10Eileen: Move ImportStatsCollector to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877303 (https://phabricator.wikimedia.org/T326271) [03:03:46] (03CR) 10Eileen: Move ImportStatsCollector to extension (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877303 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:03:52] (03CR) 10CI reject: [V: 04-1] Drupal upgrade to 7.94 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:03:54] (03CR) 10CI reject: [V: 04-1] Move ImportStatsCollector to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877303 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:04:14] (03PS3) 10Ejegg: Move ImportStatsCollector to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877303 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:04:31] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877303 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:04:54] ejegg do you remember if we have ever seen/caught this error before AdyenCheckout is not defined [03:04:55] let's see if it passes tests now - and what the drupal one fails on next... [03:05:03] it seems really familiar but then i cant find anything [03:05:18] cstone: is that in JS? [03:05:25] yes [03:05:52] sounds like the script that we pull in from Adyen's site didn't load right [03:06:09] yeah sorry thats it but didnt we have like tickets looking at that [03:06:14] or was it just offhand we dealt with it [03:06:41] or I guess it could be load order - let's make sure our script that tries to use it only runs after that script is loaded [03:06:56] ill juts make a new ticket and if theres another one found we can combine [03:08:44] cstone ooh, I don't see us using mw.loader.load() anywhere in adyen.js [03:08:56] it could possibly be a load order issue! [03:09:11] ok ill add your thoughts here to the ticket thanks ejegg ! [03:10:49] so we call new AdyenCheckout() in some code that runs on page ready [03:11:09] and I've forgotten whether pageReady is before or after all the other JS loads [03:11:39] SO says nope: https://stackoverflow.com/questions/16983774/is-document-ready-called-after-loading-all-script-files-in-the-body [03:11:47] so yeah, we should do something about that! [03:11:53] (03PS2) 10Eileen: Move last wmf_civicrm.install functions to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877302 (https://phabricator.wikimedia.org/T270680) [03:13:05] ok, it's late here. have a good one eileen and cstone [03:13:10] night ejegg [03:14:48] !log civicrm upgraded from 391e8482 to 9afd2789 [03:14:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:15:31] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877302 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [03:15:52] 10Fundraising-Backlog: Handle JS ReferenceError: AdyenCheckout is not defined - https://phabricator.wikimedia.org/T326610 (10Cstone) [03:17:09] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Adyen iframe config error messages Q2 2022: the sequel - https://phabricator.wikimedia.org/T324362 (10Cstone) For 157350993.1 I created {T326610} [03:19:55] (03Merged) 10jenkins-bot: Move ImportStatsCollector to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877303 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:31:44] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising Sprint Undefined, 10Fundraising Sprint Vwl Cnsrvtn, and 2 others: Access to Logstash/OpenSearch Dashboards for all FR... - https://phabricator.wikimedia.org/T321494 [03:33:46] (03PS3) 10Eileen: Drupal upgrade to 7.94 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) [03:38:50] (03PS3) 10Eileen: Move last wmf_civicrm.install functions to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877302 (https://phabricator.wikimedia.org/T270680) [03:38:52] (03PS1) 10Eileen: Remove unused php helper file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877306 (https://phabricator.wikimedia.org/T270680) [03:45:13] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Move queue2civicrm_log to civicrm database (from drupal) - https://phabricator.wikimedia.org/T326611 (10Eileenmcnaughton) [03:47:02] (03CR) 10Eileen: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:47:18] (03CR) 10CI reject: [V: 04-1] Drupal upgrade to 7.94 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:57:02] (03PS1) 10Eileen: WIP stop enabling civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877307 (https://phabricator.wikimedia.org/T325698) [04:11:30] (03CR) 10CI reject: [V: 04-1] WIP stop enabling civi-data-translate [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877307 (https://phabricator.wikimedia.org/T325698) (owner: 10Eileen) [04:27:04] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Mismatch between the Civi refund date vs what we see at the Adyen console - https://phabricator.wikimedia.org/T326254 (10Cstone) Hi @SHust it looks although both the weekly and nightly audit have columns named Creation Date, the nigh... [06:40:32] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/FundraisingEmailUnsubscribe] (REL1_35) - 10https://gerrit.wikimedia.org/r/876503 (owner: 10L10n-bot) [06:57:03] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/877431 (owner: 10L10n-bot) [12:37:10] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/877431 (owner: 10L10n-bot) [13:02:32] (03PS7) 10Jgleeson: Add dLocal API request headers [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/875898 (https://phabricator.wikimedia.org/T324274) [14:08:15] (03CR) 10Jgleeson: Add dLocal API request signature header (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/876004 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [14:18:00] (03PS10) 10Jgleeson: Add dLocal API request signature header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/876004 (https://phabricator.wikimedia.org/T324274) [14:19:36] oh man [14:20:08] I give up trying to have aligned multi fn calls [14:20:31] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/876004/10/PaymentProviders/dlocal/Api.php#50 [14:20:47] tried manually. tried magically. no play [14:29:45] (03PS11) 10Jgleeson: Add dLocal API request signature header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/876004 (https://phabricator.wikimedia.org/T324274) [14:45:42] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Implement dLocal health check API call - https://phabricator.wikimedia.org/T326248 (10jgleeson) a:03jgleeson [15:14:46] 10Fundraising Sprint Amazing grep, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: DAF import error - https://phabricator.wikimedia.org/T326447 (10MDemosWMF) Strange! Not sure how data got all the way over there. I will try that and see how it goes! [15:15:52] 10Fundraising-Backlog, 10FR-dlocal: Add error handling to backend SmashPig API calls - https://phabricator.wikimedia.org/T324691 (10Damilare) The link in the description seems to be the error codes for Payout transactions. Here's the link for Payin response status codes: https://docs.dlocal.com/reference/payme... [15:21:54] 10Fundraising Sprint Amazing grep, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: DAF import error - https://phabricator.wikimedia.org/T326447 (10MDemosWMF) It worked, the import is in! Thank you @Eileenmcnaughton [16:26:15] (03PS12) 10Damilare Adedoyin: Add dLocal API request signature header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/876004 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [16:26:19] (03PS11) 10Damilare Adedoyin: WIP: dlocal create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/877179 [16:26:37] (03CR) 10CI reject: [V: 04-1] Add dLocal API request signature header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/876004 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [16:26:39] (03PS1) 10Jgleeson: WIP: Add dlocal getPaymentMethods API call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878129 (https://phabricator.wikimedia.org/T326248) [16:27:07] did you change the earlier patches damilare [16:27:10] ? [16:27:15] sorry jgleeson, I'd revert the changes I mistakenly push to your patch [16:27:31] ah ok thanks [16:27:32] I rebased over yours and it changed yours [16:27:39] when I pushed mine [16:28:15] np! [16:29:01] I'm breaking now. I promised Oscar I'd have a 'Fortnite Hour' during my dinner break :). Back later [16:35:06] (03CR) 10Ejegg: "check experimental" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876007 (https://phabricator.wikimedia.org/T324154) (owner: 10Ejegg) [16:39:41] (03PS13) 10Damilare Adedoyin: Add dLocal API request signature header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/876004 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [16:40:49] (03PS14) 10Damilare Adedoyin: Add dLocal API request signature header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/876004 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [16:42:00] (03CR) 10Ejegg: "So to get rid of our drupal namespace hack, we'll have to move exchange_rates (https://phabricator.wikimedia.org/T270666 - estimate 4), qu" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [16:45:09] (03PS12) 10Damilare Adedoyin: WIP: dlocal create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/877179 [16:54:53] (03Abandoned) 10Damilare Adedoyin: WIP: dlocal create payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/877179 (owner: 10Damilare Adedoyin) [16:55:24] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Release-Engineering-Team, and 2 others: Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4 - https://phabricator.wikimedia.org/T326372 (10Jdforrester-WMF) OK, the new PHP74/... [17:01:14] (03PS4) 10Wfan: Add cc as payment_method default in general for old gateway link that contains no payment_method. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876044 (https://phabricator.wikimedia.org/T140269) [17:01:17] (03PS1) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [17:02:31] (03PS2) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [17:11:10] 10Fundraising Sprint Amazing grep, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: DAF import error - https://phabricator.wikimedia.org/T326447 (10LeanneS) Thank you for spotting that stray data value @Eileenmcnaughton! Good to know the fix if this ever pops up again. [17:41:04] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Install `coworker` and `cv` on prod - https://phabricator.wikimedia.org/T324611 (10Jgreen) @Eileenmcnaughton After yesterday's mtg, I went back and looked at how civicrm is implemented and now I understand the question about sepa... [17:55:17] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Adyen Audit - manually settled transactions not being imported into civi with the nightly audit file - https://phabricator.wikimedia.org/T325415 (10AnnWF) a:03AnnWF [18:08:53] (03CR) 10Ejegg: [C: 03+1] "Looks good! One more opportunity for a type hint" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/875898 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [18:20:34] (03CR) 10Ejegg: "check experimental" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876007 (https://phabricator.wikimedia.org/T324154) (owner: 10Ejegg) [18:21:11] thanks the the review ejegg. good spot on the typehint! [18:21:41] woot, REL1_39 test jobs are activated for the experimental suite [18:21:47] https://integration.wikimedia.org/ci/job/quibble-donationinterface-REL1_39-php74-docker/1/console [18:21:50] for the* [18:22:13] you seem to be short an 'e' jgleson :) [18:22:27] bad day for typos [18:22:30] :) [18:23:13] woohoo, it passed all the core tests [18:23:21] nice [18:23:47] I guess I can +2 the ones I tested if they're not already done [18:24:14] this is the next one that needs a C+2: https://gerrit.wikimedia.org/r/876007 [18:24:28] back soon, gonna help make lunch [18:48:54] 10Fundraising-Backlog: GatewayChooser: No supported gateway for parameters - https://phabricator.wikimedia.org/T326666 (10AnnWF) [18:51:18] 10Fundraising-Backlog: GatewayChooser: No supported gateway for parameters - https://phabricator.wikimedia.org/T326666 (10AnnWF) [18:59:28] (03PS8) 10Jgleeson: Add dLocal API request headers [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/875898 (https://phabricator.wikimedia.org/T324274) [19:00:52] (03CR) 10Jgleeson: "thanks for the review! I've updated the typehint" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/875898 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [19:01:24] (03PS15) 10Jgleeson: Add dLocal API request signature header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/876004 (https://phabricator.wikimedia.org/T324274) [19:01:32] (03PS2) 10Jgleeson: WIP: Add dlocal getPaymentMethods API call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878129 (https://phabricator.wikimedia.org/T326248) [19:20:17] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Dedupe query under certain rules no longer generating queries - https://phabricator.wikimedia.org/T326605 (10XenoRyet) [19:20:57] (03CR) 10AndyRussG: Add donatewiki service (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [19:54:03] 10Fundraising-Backlog: Update SmashPig currency rates - https://phabricator.wikimedia.org/T326671 (10HNordeenWMF) [20:15:14] (03PS1) 10Eileen: Use casting rather than function for clarity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878189 [20:19:45] (03CR) 10CI reject: [V: 04-1] Move ExchangeRate exceptions to fledgling extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801835 (owner: 10Eileen) [20:20:13] 10Fundraising-Backlog: Old globalcollect recurring force cancel behaviour not working - https://phabricator.wikimedia.org/T254303 (10Cstone) 05Open→03Resolved a:03Cstone RIP old globalcollect - we aren't using this integration anymore [20:30:38] (03CR) 10Jgleeson: [C: 04-1] "Took a quick first pass and noticed a few things inline. Thanks!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [20:31:35] (03PS3) 10Jgleeson: WIP: Add dlocal getPaymentMethods API call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878129 (https://phabricator.wikimedia.org/T326248) [20:32:09] (03CR) 10CI reject: [V: 04-1] WIP: Add dlocal getPaymentMethods API call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878129 (https://phabricator.wikimedia.org/T326248) (owner: 10Jgleeson) [20:37:32] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10FR-Docker: Set up CentralNotice on donut container - https://phabricator.wikimedia.org/T326673 (10Ejegg) [20:39:47] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Mismatch between the Civi refund date vs what we see at the Adyen console - https://phabricator.wikimedia.org/T326254 (10Cstone) a:03Cstone [20:42:32] this is that casting change - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/878189 [20:48:43] 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Donations queue consumer should write stats every minute - https://phabricator.wikimedia.org/T323162 (10XenoRyet) [20:51:05] 10Fundraising Sprint Amazing grep, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: DAF import error - https://phabricator.wikimedia.org/T326447 (10Eileenmcnaughton) The first clue was it complained about file size when I tried to open it [20:51:23] 10Fundraising Sprint Amazing grep, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: DAF import error - https://phabricator.wikimedia.org/T326447 (10Eileenmcnaughton) 05Open→03Resolved [20:52:03] (03CR) 10Jgleeson: "This makes everything 5 times faster right? LGTM :)" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878189 (owner: 10Eileen) [20:52:07] (03CR) 10Jgleeson: [C: 03+2] Use casting rather than function for clarity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878189 (owner: 10Eileen) [20:52:12] thanks jgleeson - only in php 5 [20:52:45] ah right. let's downgrade! :) [21:02:49] (03PS3) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [21:03:02] (03CR) 10CI reject: [V: 04-1] Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [21:04:03] 10Fundraising Sprint Amazing grep, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Bus error 2: The bus strikes back - https://phabricator.wikimedia.org/T326013 (10Eileenmcnaughton) [21:05:42] 10Fundraising Sprint Amazing grep, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Bus error 2: The bus strikes back - https://phabricator.wikimedia.org/T326013 (10Cstone) [21:05:44] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Smarty template load failures in process-control job logs - https://phabricator.wikimedia.org/T326023 (10Cstone) [21:06:14] (03PS4) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [21:06:25] (03CR) 10CI reject: [V: 04-1] Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [21:06:40] 10Fundraising Tech - Chaos Crew: change default to Adyen for Japan - https://phabricator.wikimedia.org/T326676 (10EMartin) [21:07:26] (03Merged) 10jenkins-bot: Use casting rather than function for clarity [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878189 (owner: 10Eileen) [21:11:09] (03PS5) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [21:11:32] (03CR) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig (033 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [21:13:44] (03PS6) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [21:27:01] cstone: Oscar was just reading an animal fact book for bed and I gobsmacked to hear carrots are not good for rabbits, they don't eat them in the wild and they can even upset their tummy!!! https://www.rspca.org.uk/adviceandwelfare/pets/rabbits/diet/myths [21:27:13] I was* [21:27:28] haha bun will only eat like dried carrots [21:27:39] was it all disinformation from Bugs Bunny? [21:27:47] yeah anything besides like hay/grass really isnt the best and just should be treats [21:28:17] wow I just got an exciting popup from youtube [21:29:04] Today's StarTalk show is called "How do stars die" [21:30:23] cstone: I guess it makes sense if they don't eat root vegetables in the wild. I just assumed they were all like Peter Rabbit raiding the farmers field [21:31:16] im sure they would love raiding the farmers field but yeah not the best for them [21:31:57] we have rodents in the back yard that will eat the 1.5" of greens from the ground to the rest of the plant and move on. [21:32:10] we found that out when our pea plants all started withering. [21:32:34] if they are going to spoil the yield, the least they could do is eat the peas and leave some for us. [21:32:57] im gona go outside for a bit its 60f/15c out need to take advantage before it snows tonight [21:34:19] dwisehaupt: they didnt want the peas they wanted the stems :P [21:35:14] we always used to plant 2x or 3x strawberry plants so that we could have some after the garden critters ate their lot. [21:40:47] ha. plant bribes [21:59:26] oh nice, brennen just published the dev-images change [21:59:53] so folks can test donutwiki without needing to build the images [22:02:23] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Figure out storage implications of varchar vs text in possible logging solution - https://phabricator.wikimedia.org/T325789 (10Jgreen... [22:32:37] woot, and I have a banner showing [22:33:00] I just needed to tell the banner to show itself to anon + logged in users [22:40:52] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Install `coworker` and `cv` on prod - https://phabricator.wikimedia.org/T324611 (10Eileenmcnaughton) @Jgreen cool - do you need anything from me on that or are you handling getting the repo created? [22:49:35] (03PS14) 10Ejegg: Add donatewiki service [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) [22:49:37] (03PS4) 10Ejegg: Use new mediawiki-apache2 image for payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877280 [22:49:39] (03PS4) 10Ejegg: Use new apache2 image for email-pref-ctr [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877281 [22:49:41] (03PS3) 10Ejegg: Add CentralNotice to donut [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877296 (https://phabricator.wikimedia.org/T317498) [22:50:28] ok fr-tech, that's all ready to test, no image-building needed ^^^ [22:51:10] thx ejegg! [22:51:53] AndyRussG: actually, do you want me to squash the 'Add CentralNotice patch into the donatewiki patch ? [22:52:12] that would save having to download core all over again to test setup [22:52:41] hmmm whatever sens [22:52:48] seems [22:53:20] most logical from a git history perspective maybe? [22:53:21] ok, I'll squish em together [22:53:37] sure thx! [22:57:23] (03PS15) 10Ejegg: Add service for donatewiki and centralnotice [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) [22:57:25] (03PS5) 10Ejegg: Use new mediawiki-apache2 image for payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877280 [22:57:27] (03PS5) 10Ejegg: Use new apache2 image for email-pref-ctr [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877281 [22:57:38] k, there it is squashed AndyRussG ^^^ [22:58:25] thx ejegg! gonna walk doggie and right after that I can have a look :) [22:58:32] sounds good! [23:00:57] (03PS6) 10Ejegg: Use new apache2 image for email-pref-ctr [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877281 [23:01:21] ah that smashpig service should be updated to bullseye too [23:10:54] oh hah, could I have taken the 'mediawiki' out of that image name? [23:12:51] I totally could have [23:13:22] the only explicitly mediawiki thing in there was the 000-default.conf, and that's on the host now [23:13:50] so... I guess I can just use it for the smashpig service and we rename it sometime later? [23:31:36] ejegg: sure! [23:32:19] (03PS1) 10Wfan: Merge branch 'master' into deployment 522b6d82 Replace deprecated Http::userAgent c785a740 Localisation updates from https://translatewiki.net. 073d2205 Update SmashPig to v0.8.3.12 and own version number 3b0af04e Add Skeleton for Dlocal 685e37b3 Localisation updates from https://translatewiki.net. 43c430b1 Localisation updates from https://translatewiki.net. 92400399 Update SmashPig version and own version [23:32:19] Localisation updates from https://translatewiki.net. 722dc0c7 Localisation updates from https://translatewiki.net. f8b48560 Localisation updates from https://translatewiki.net. 81e1a734 Localisation updates from https://translatewiki.net. f0d28d09 Replace deprecated Language::isValidBuiltInCode e0e65f3a Replace deprecated Language::getFallbacksFor 5362daff Replace deprecated Language::getMessageFor d76a46c1 Localisation updates [23:32:19] https://translatewiki.net. c89d3d60 Initialise transaction response in the process donor return if not present. e7eb2d5c Localisation updates from https://translatewiki.net. 571f0232 Localisation updates from https://translatewiki.net. e9c0a415 Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/878214 [23:32:24] ejegg: just off the top of my head (just starting to look again at this) was there a reason not to put all the files needed for the apache config on the host? [23:32:38] (03PS2) 10Wfan: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/878214 [23:32:47] AndyRussG: you mean everything under /etc/apache2 ? [23:32:59] nooo hmmm one sec lemme check [23:33:05] just seemed like overkill [23:33:19] since we weren't touching anything except for the site config [23:34:37] /etc/apache2/envvars I guess? [23:35:00] ejegg: yeah the whole /etc/apache2 tree seems like too much [23:35:01] oh and ports.conf [23:35:13] I wonder if we couldn't just get rid of envars [23:35:49] and then put the ports directive.... hmmm I guess the ports directive is more closely tied to the image setup and docker-compose.yaml [23:36:02] maybe we can just kill envars in a follow-on... [23:36:09] probably fine as it is for now I guess [23:36:24] yeah the mods enabled/available stuff under /etc/apache2 definitely goes in the image [23:36:39] cool cool, it seems to be working for the smashpig service [23:37:31] fr-tech it would be nice if someone could peek at https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/876014 [23:38:05] I keep having to cherry-pick it back over the other docker patches so I can still run setup without reverting to REL1_35 [23:38:22] the patch should be back-compatible [23:39:08] sure I can also look (unless someone else really would like to ofc :) ) [23:39:13] thanks! [23:42:58] (03CR) 10Wfan: [C: 03+2] "checked the latest bug fixed and dlocal are all here" [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/878214 (owner: 10Wfan) [23:45:31] (03PS1) 10Wfan: Update Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/878216 [23:47:33] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/878214 (owner: 10Wfan) [23:48:14] (03CR) 10Wfan: [C: 03+2] Update Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/878216 (owner: 10Wfan) [23:54:00] (03CR) 10CI reject: [V: 04-1] Update Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/878216 (owner: 10Wfan) [23:55:09] wow quite a few items in review for fr-dev https://gerrit.wikimedia.org/r/q/project:wikimedia/fundraising/dev+status:open [23:57:34] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] "Coool thanks for this! :)" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/876014 (https://phabricator.wikimedia.org/T324154) (owner: 10Ejegg)