[00:14:37] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] "noice! :)" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877298 (owner: 10Ejegg) [00:19:52] (03CR) 10Wfan: [C: 03+2] "recheck" [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/878216 (owner: 10Wfan) [00:26:37] (03CR) 10CI reject: [V: 04-1] Update Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/878216 (owner: 10Wfan) [00:27:18] oh i see, needs to update smashpig version first [00:28:20] yeah wfan looks like it got updated to 13 but the matching DI patch didnt get made [00:28:48] yeah just saw it Required package "wikimedia/smash-pig" is in the lock file as "v0.8.3.11" but that does not satisfy your constraint "0.8.3.13". [01:11:08] (03PS1) 10Wfan: update smash-pig requirement to 0.8.2.14 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/878228 [01:14:01] (03CR) 10Wfan: [C: 03+2] update smash-pig requirement to 0.8.2.14 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/878228 (owner: 10Wfan) [01:15:55] (03Merged) 10jenkins-bot: update smash-pig requirement to 0.8.2.14 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/878228 (owner: 10Wfan) [01:34:38] hrmmm? this time I get a missing table error on importing the donatewiki dump [01:34:46] Table 'donut.revtag' doesn't exist [01:35:11] never failed like that before [01:35:18] what could have changed? [01:37:46] (03PS16) 10Ejegg: Add service for donatewiki and centralnotice [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) [01:37:58] ^^^ just a rebase [01:38:09] okii [01:39:00] oh right, I never tried taking out that privileged port line in the docker compose [01:43:17] (03Abandoned) 10Ejegg: Add CentralNotice to donut [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877296 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [01:46:11] (03PS1) 10Wfan: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/878229 [01:47:26] (03CR) 10Wfan: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/878229 (owner: 10Wfan) [01:50:31] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/878229 (owner: 10Wfan) [01:50:45] seems like that revtag thing has to do with the translate extension [01:51:18] so it just wasn't failing till I squashed the cn patch into the donate patch [01:52:05] (03PS2) 10Wfan: Update Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/878216 [01:52:59] ugh, it works after I run update.php? [01:53:11] so why would I have to run update on a fresh install? [01:54:06] ahhh, because the LocalSettings from the install don't include the extensions, of course [01:54:22] OK, so we'll run update after the LocalSettings are rewritten [01:55:07] AndyRussG: one more change incoming [01:55:55] ^ yes corect [01:55:58] correct [01:56:00] cool thx! [02:00:48] (03CR) 10CI reject: [V: 04-1] Update Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/878216 (owner: 10Wfan) [02:01:06] (03PS17) 10Ejegg: Add service for donatewiki and centralnotice [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) [02:04:27] (03CR) 10AndyRussG: Add service for donatewiki and centralnotice (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [02:15:53] (03PS3) 10Wfan: Update Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/878216 [02:17:00] (03CR) 10AndyRussG: "Looking great so far btw!!! just a question inline :)" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [02:18:56] (03PS18) 10Ejegg: Add service for donatewiki and centralnotice [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) [02:19:16] (03CR) 10Ejegg: Add service for donatewiki and centralnotice (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [02:20:32] hmm AndyRussG does prod actually have copies of all the dependencies in each different extension's vendor subdir? [02:20:53] That seems really risky for version conflicts [02:21:00] ejegg: welp I guess now I'm not totally sure... I guess let's check? [02:21:05] sure [02:21:22] I've always just done the composer install for each thingy separately, so I guess I was just assuming that, but it could well be wrong [02:24:13] (03CR) 10CI reject: [V: 04-1] Update Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/878216 (owner: 10Wfan) [02:24:30] also hahah 2014 https://www.mediawiki.org/wiki/Requests_for_comment/Composer_managed_libraries_for_use_on_WMF_cluster [02:27:16] ejegg: you're right! sorry about that 8p [02:28:38] (03PS1) 10Eileen: Switch wmf_campaigns to use Factory method [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878237 (https://phabricator.wikimedia.org/T326271) [02:29:02] AndyRussG: ahh, where did you find that? [02:29:21] I couldn't find documentation so I'm just about to log in to prod deploy server [02:29:59] hehe I'd be curious as to what you find there, but yes there is a compoer.local.json-sample included at least with the wmf branches of core [02:30:18] (03CR) 10AndyRussG: Add service for donatewiki and centralnotice (032 comments) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [02:30:58] ah shoot, I thought I fixed all the spacing in PS18. Will fix that tab [02:31:37] and I guess config is as good a place as any for that... will just delete the comment [02:33:38] so on prod in the staging dir, there are no vendor folders under any extn [02:33:41] ls: cannot access 'extensions/*/vendor': No such file or directory [02:33:44] ls: cannot access 'extensions/*/vendor': No such file or directory [02:34:02] there's also no composer.local.json or composer.lock [02:34:23] so I'm not sure when in the deploy process the vendor submodule gets updated [02:34:35] maybe there's a readme in that repo? [02:34:52] oh yep [02:35:08] with a link to https://www.mediawiki.org/wiki/Manual:External_libraries [02:36:37] huh, but it really just talks about libraries included in mediawiki/core [02:37:04] ok, on that linked page there's a line about [02:37:08] "The extension distributor automatically packages composer dependencies, so tarball users won't have to do it manually. You'll then need to add the library to the mediawiki/vendor repository after the security review is complete. " [02:37:43] ohhh, mediawiki/vendor has its own composer.json and composer.lock [02:38:28] with a lot more required packages than in the parent dir [02:41:34] (03PS19) 10Ejegg: Add service for donatewiki and centralnotice [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) [02:41:42] k, that's the spacing issue gone [02:42:59] now just to figure out why email pref center keeps barfing when running update after install [02:43:06] Error 1091: Can't DROP INDEX `tl_namespace`; check that it exists [02:43:21] (for a following patch, not for the donut one) [02:45:17] https://gerrit.wikimedia.org/g/mediawiki/vendor [02:46:38] anyway if prod is that complex it doesn't make sense to care much about emulating exactly [02:46:56] sure, sounds good [02:46:59] the "tarball users" bit is for non-WMF users [02:47:03] right [02:47:07] (sorry if u knew that already) [02:49:09] so it is nice to know forexample that donatewiki has geoip2 libraries in vendor: https://phabricator.wikimedia.org/diffusion/MWVD/browse/master/composer.json$37 [02:49:50] good guideline for any deps we might want to add to CN or fundraiserlandingpage [02:54:28] grr, tl_namespace index totally exists [02:55:14] and running that failing query seems to work too [02:59:28] ah, I'm running update twice on donut install [03:01:35] hmm, but for email-pref-ctr, do any of the installed extensions actually have schema? [03:01:50] why would we need the update for that wiki? [03:03:28] (03CR) 10AndyRussG: Add service for donatewiki and centralnotice (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [03:05:05] hmmm we might not indeed need the update if wiki extensions don't have schema, though it might be good to do because... hmmm... tradition? [03:05:27] k, heredoc seems fine for composer.local, good point about assuming edits are reflected in the container [03:07:28] well, I'm not going to worry too much about email-pref-ctr not installing on REL1_35 if we're about to move it to REL1_39 anyway [03:08:38] yeah +1 [03:12:49] (03PS20) 10Ejegg: Add service for donatewiki and centralnotice [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) [03:16:21] (03CR) 10Ejegg: Add service for donatewiki and centralnotice (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [03:24:09] (03CR) 10AndyRussG: "Thanks again and apologies for the nitpicks...! Inline note, but if this works as is, I think it's not a blocker for merging btw!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [03:38:57] (03CR) 10Ejegg: Add service for donatewiki and centralnotice (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [03:39:26] AndyRussG: i'mma head to bed now, but maybe we can look at the path and the rewrites in a follow-on patch? [03:39:44] ejegg sure thanks so much!!!!!!!!! [03:40:20] (03CR) 10AndyRussG: Add service for donatewiki and centralnotice (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [03:40:30] 'night! [03:48:02] (03CR) 10Ejegg: Add service for donatewiki and centralnotice (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [03:48:12] context for that install.php note ^^^ [03:48:37] you should see that annoying warning in the output on install [03:52:21] (03PS1) 10Eileen: Large donation - fix to use MailFactory [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878241 (https://phabricator.wikimedia.org/T326271) [03:52:47] (03PS2) 10Eileen: Large donation test - fix to use MailFactory [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878241 (https://phabricator.wikimedia.org/T326271) [04:05:45] (03CR) 10AndyRussG: Add service for donatewiki and centralnotice (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [04:06:30] (03CR) 10CI reject: [V: 04-1] Large donation test - fix to use MailFactory [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878241 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [04:10:20] (03PS3) 10Eileen: Large donation test, other tests testing mails - fix to use MailFactory [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878241 (https://phabricator.wikimedia.org/T326271) [04:13:40] (03PS4) 10Eileen: Large donation test, other tests testing mails - fix to use MailFactory [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878241 (https://phabricator.wikimedia.org/T326271) [04:27:08] (03CR) 10CI reject: [V: 04-1] Large donation test, other tests testing mails - fix to use MailFactory [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878241 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [04:58:02] (03CR) 10AndyRussG: Add service for donatewiki and centralnotice (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [05:21:16] (03PS5) 10Eileen: FailMail, Large donation test, other tests testing mails - fix to use MailFactory [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878241 (https://phabricator.wikimedia.org/T326271) [05:23:56] (03PS1) 10Eileen: Remove last interaction with Mailer class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878243 (https://phabricator.wikimedia.org/T326271) [05:46:13] (03PS2) 10Eileen: Switch wmf_campaigns to use Factory method [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878237 (https://phabricator.wikimedia.org/T326271) [05:46:15] (03PS6) 10Eileen: FailMail, Large donation test, other tests testing mails - fix to use MailFactory [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878241 (https://phabricator.wikimedia.org/T326271) [05:49:10] (03PS2) 10Eileen: Remove last interaction with Mailer class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878243 (https://phabricator.wikimedia.org/T326271) [05:49:12] (03PS4) 10Eileen: Drupal upgrade to 7.94 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) [05:49:14] (03PS1) 10Eileen: Re-apply WMF patches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878246 (https://phabricator.wikimedia.org/T326271) [06:01:22] (03CR) 10CI reject: [V: 04-1] Drupal upgrade to 7.94 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [06:49:36] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/878342 (owner: 10L10n-bot) [11:40:06] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_38) - 10https://gerrit.wikimedia.org/r/878342 (owner: 10L10n-bot) [13:42:51] (03PS27) 10Damilare Adedoyin: IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [13:44:41] (03CR) 10CI reject: [V: 04-1] IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [13:48:41] 10Fundraising-Backlog, 10fundraising-tech-ops, 10WMF-NDA: nginx SSL_do_handshake failed - https://phabricator.wikimedia.org/T326601 (10Jgreen) [13:51:47] 10Fundraising-Backlog, 10fundraising-tech-ops: nginx SSL_do_handshake failed - https://phabricator.wikimedia.org/T326601 (10Jgreen) [16:07:47] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Install `coworker` and `cv` on prod - https://phabricator.wikimedia.org/T324611 (10Jgreen) >>! In T324611#8514730, @Eileenmcnaughton wrote: > @Jgreen cool - do you need anything from me on that or are you handling getting the re... [17:27:16] (03PS21) 10Ejegg: Add service for donatewiki and centralnotice [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) [17:34:00] (03CR) 10Ejegg: Add service for donatewiki and centralnotice (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [17:41:11] (03PS1) 10Wfan: Update SmashPig to v0.8.2.11 and DonationInterface to v2.5.7.12 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/879108 [18:05:32] (03PS4) 10Wfan: Update Smashpig composer.lock and Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/878216 [18:07:40] (03PS5) 10Wfan: Update Smashpig composer.lock and Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/878216 [18:16:54] (03CR) 10Wfan: [C: 03+2] Update Smashpig composer.lock and Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/878216 (owner: 10Wfan) [18:18:30] (03PS2) 10Wfan: Update SmashPig to v0.8.3.14 and DonationInterface to v2.5.8.12 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/879108 [18:19:12] (03CR) 10Wfan: [C: 03+2] Update SmashPig to v0.8.3.14 and DonationInterface to v2.5.8.12 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/879108 (owner: 10Wfan) [18:25:55] (03Merged) 10jenkins-bot: Update Smashpig composer.lock and Donation Interface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/878216 (owner: 10Wfan) [18:34:33] (03Merged) 10jenkins-bot: Update SmashPig to v0.8.3.14 and DonationInterface to v2.5.8.12 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/879108 (owner: 10Wfan) [19:17:06] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] "wooohhoooo donut donut donut donut ahhhh" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [19:18:37] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] Add service for donatewiki and centralnotice (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841965 (https://phabricator.wikimedia.org/T317498) (owner: 10Ejegg) [19:20:16] the donut has landed!!!! [19:43:01] 10Fundraising-Backlog, 10FR-Civi-Dedupe: Alternate name field for donors with different alphabet characters - https://phabricator.wikimedia.org/T275678 (10EMartin) Before we use 'Rakuten 2' Payment form in Japan which includes the nickname field, we would need to solve for this in Civi to avoid confusion. @Fr... [19:46:30] (03PS12) 10Wfan: Render smartfield ui to the dlocal gateway page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/868161 (https://phabricator.wikimedia.org/T324271) [20:41:48] (03PS1) 10Wfan: Type for payment_method should be cc instead of dlocal [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/879132 (https://phabricator.wikimedia.org/T324271) [20:49:23] (03PS6) 10Jgleeson: Add dlocal getPaymentMethods API call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878129 (https://phabricator.wikimedia.org/T326248) [20:53:26] (03PS6) 10Ejegg: Use new mediawiki-apache2 image for payments [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877280 [20:53:28] (03PS7) 10Ejegg: Use new apache2 image for email-pref-ctr [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877281 [20:53:30] (03PS1) 10Ejegg: Update SmashPig service to use bullseye apache2 image [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/879134 [21:17:53] damilare: I've pushed up a working version of the search payments patch which should unblock the create payment stuff https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/878129/ [21:18:16] cool thanks jgleeson [21:19:16] I'm not 100% happy with some of the names of methods in my patch but it's functional so I can revisit those with fresher eyes tomorrow [21:19:27] I might rename them all to source code [21:20:18] (03PS1) 10Ejegg: Use ReferenceData to unstage Ingenico submethod [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879138 [21:39:28] (03PS13) 10Wfan: Render smartfield ui to the dlocal gateway page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/868161 (https://phabricator.wikimedia.org/T324271) [21:58:54] (03PS7) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [22:49:10] 10fundraising-tech-ops: Fundraising access request for Anil Kanji - https://phabricator.wikimedia.org/T326765 (10greg) [22:50:01] (03CR) 10Ejegg: [C: 03+2] Type for payment_method should be cc instead of dlocal [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/879132 (https://phabricator.wikimedia.org/T324271) (owner: 10Wfan) [23:07:30] 10fundraising-tech-ops: Fundraising access request for Anil Kanji - https://phabricator.wikimedia.org/T326765 (10Dwisehaupt) a:03Dwisehaupt Access approved from Lisa: ` ---------- Forwarded message --------- From: Lisa Seitz Gruwell Date: Wed, Jan 11, 2023 at 2:05 PM Subject: Re: Access request approval for A... [23:10:15] 10fundraising-tech-ops: Fundraising access request for Anil Kanji - https://phabricator.wikimedia.org/T326765 (10Dwisehaupt) [23:24:21] 10fundraising-tech-ops: Fundraising access request for Anil Kanji - https://phabricator.wikimedia.org/T326765 (10Dwisehaupt) Sent intro email and awaiting addition of collab contact info.