[00:19:01] I jut moved the 'move install to extension' to review - most of it has been reviewed but just these last 2 patches - https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/877306/1 [00:39:10] 10Fundraising-Backlog, 10fr-donorservices: questions re: Civi Recur fail email Jan 2022 - https://phabricator.wikimedia.org/T326770 (10MBeat33) [00:39:20] 10Fundraising-Backlog, 10fr-donorservices: questions re: Civi Recur fail email Jan 2022 - https://phabricator.wikimedia.org/T326770 (10MBeat33) p:05Triage→03Medium [00:53:23] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review, 10Unplanned-Sprint-Work: CiviCRM security ports - https://phabricator.wikimedia.org/T326271 (10Eileenmcnaughton) I also did the drupal security upgrade (although we didn't see it as security-urg... [00:55:14] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Eliminate `watchdog` from our custom code - https://phabricator.wikimedia.org/T326771 (10Eileenmcnaughton) [00:56:11] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Eliminate `watchdog` from our custom code - https://phabricator.wikimedia.org/T326771 (10Eileenmcnaughton) 05Open→03Declined https://phabricator.wikimedia.org/T288585 [00:56:47] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Switch CiviCRM mailing to use smtp fallback, consolidate our smtp use across our codebase - https://phabricator.wikimedia.org/T297647 (10Eileenmcnaughton) This got partially done recently - bringing back to high in sprint +1 as... [00:58:44] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Swap all our process logging to Civi::log('wmf') from watchdog() - https://phabricator.wikimedia.org/T288585 (10Eileenmcnaughton) I brought this back to sprint +1 as it seems getting this done would make it easier to sort out o... [01:00:47] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Figure out storage implications of varchar vs text in possible logging solution - https://phabricator.wikimedia.org/T325789 (10Eileen... [01:04:15] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Gather WMF data to supplement Logging report - https://phabricator.wikimedia.org/T324161 (10Eileenmcnaughton) Moved this to DONE as... [01:50:13] (03PS3) 10Ejegg: Switch wmf_campaigns to use Factory method [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878237 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [01:50:28] (03CR) 10Ejegg: [C: 03+2] "Looks great! One nitpick" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878237 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [01:51:32] (03CR) 10Eileen: Switch wmf_campaigns to use Factory method (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878237 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [01:51:56] (03PS4) 10Eileen: Switch wmf_campaigns to use Factory method [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878237 (https://phabricator.wikimedia.org/T326271) [01:52:44] heh, lightning response! [02:15:03] (03CR) 10Ejegg: [C: 03+1] "Looks good! We could delete a few bits of TestMailer if we wanted to" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878241 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [02:17:04] ejegg: I am a bit scared of more scope creep so I pulled https://phabricator.wikimedia.org/T297647 into sprint +1 [02:17:34] but yeah those fns can probably go [02:19:02] (03CR) 10Ejegg: [C: 04-1] "One more to get rid of over on line 946 of thank_you.module, in thank_you_batch_test:" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878243 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [02:20:06] ok eileen, happy to merge as-is [02:20:23] ejegg: well we can add a follow up patch maybe [02:20:29] (03PS7) 10Ejegg: FailMail, Large donation test, other tests testing mails - fix to use MailFactory [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878241 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [02:20:41] since we've looked [02:20:56] (03CR) 10Ejegg: [C: 03+2] "Cool, let's those other fns in a follow-on" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878241 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [02:22:46] (03PS5) 10Eileen: Drupal upgrade to 7.94 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) [02:22:48] (03PS1) 10Eileen: Use MailFactory in thank_you module test function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/879165 [02:23:15] (03PS2) 10Eileen: Use MailFactory in thank_you module test function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/879165 [02:23:28] ejegg: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/879165 covers that other place [02:24:12] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/875898 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [02:24:44] (03Merged) 10jenkins-bot: Add dLocal API request headers [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/875898 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [02:29:34] (03PS6) 10Eileen: Drupal upgrade to 7.94 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) [02:30:08] (03PS2) 10Eileen: Re-apply WMF patches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878246 (https://phabricator.wikimedia.org/T326271) [02:30:36] I've broken up the chain since the drupal one doesn't, in the end, rely on the namespace fixes [02:35:59] (03CR) 10CI reject: [V: 04-1] Use MailFactory in thank_you module test function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/879165 (owner: 10Eileen) [02:42:33] (03CR) 10CI reject: [V: 04-1] Drupal upgrade to 7.94 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [02:43:22] (03CR) 10Eileen: [C: 03+2] Switch wmf_campaigns to use Factory method [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878237 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [02:43:44] (03CR) 10Eileen: [C: 03+2] "This lost it's +2 so I just put it back" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878237 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [02:44:58] dang I hate these chains with gerrit [02:57:45] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Add Idempotency headers to DLocal API calls - https://phabricator.wikimedia.org/T326772 (10Ejegg) [03:06:53] (03CR) 10Ejegg: [C: 03+1] "Works great, happy to merge as-is. One general musing on our half-hearted dependency injection and a couple of questions about whether you" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/876004 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [03:07:20] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Type for payment_method should be cc instead of dlocal [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/879132 (https://phabricator.wikimedia.org/T324271) (owner: 10Wfan) [03:11:57] (03Merged) 10jenkins-bot: FailMail, Large donation test, other tests testing mails - fix to use MailFactory [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878241 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:35:40] (03CR) 10Ejegg: [C: 04-1] "Looking really close! I noted a testing class and a couple of config values that are probably unneeded, and one edge-case timing bug that " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/868161 (https://phabricator.wikimedia.org/T324271) (owner: 10Wfan) [03:37:26] (03PS3) 10Ejegg: Use MailFactory in thank_you module test function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/879165 (owner: 10Eileen) [03:37:30] (03CR) 10Ejegg: [C: 03+2] Use MailFactory in thank_you module test function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/879165 (owner: 10Eileen) [03:39:38] (03PS3) 10Ejegg: Remove last interaction with Mailer class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878243 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:40:04] (03PS4) 10Ejegg: Remove last interaction with Mailer class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878243 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:40:10] (03CR) 10Ejegg: [C: 03+2] Remove last interaction with Mailer class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878243 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:40:22] one more class down [03:40:29] yay [03:42:48] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Implement dLocal health check API call - https://phabricator.wikimedia.org/T326248 (10Ejegg) [03:50:48] (03PS7) 10Ejegg: Drupal upgrade to 7.94 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:50:55] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Drupal upgrade to 7.94 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:51:04] (03PS3) 10Ejegg: Re-apply WMF patches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878246 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:51:10] (03CR) 10Ejegg: [C: 03+2] Re-apply WMF patches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878246 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [03:51:52] k eileen, I'mma head to bed now. have a good rest of your day! [03:52:16] (03Merged) 10jenkins-bot: Use MailFactory in thank_you module test function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/879165 (owner: 10Eileen) [03:53:25] (03Merged) 10jenkins-bot: Remove last interaction with Mailer class [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878243 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [04:02:19] (03CR) 10CI reject: [V: 04-1] Drupal upgrade to 7.94 [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877299 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [04:02:21] (03CR) 10CI reject: [V: 04-1] Re-apply WMF patches [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/878246 (https://phabricator.wikimedia.org/T326271) (owner: 10Eileen) [05:34:39] (03CR) 10Abijeet Patro: [C: 03+1] Update references to MessageGroups::class [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/861718 (https://phabricator.wikimedia.org/T313242) (owner: 10Wangombe) [13:52:45] today's music suggestion fr-tech is an 80s-inspired Synthwave mix. Pretty cool video too! https://www.youtube.com/watch?v=0QKQlf8r7ls [14:35:44] (03CR) 10Jgleeson: "Thanks ejegg for the review and thoughtful feedback!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/876004 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [14:40:22] (03CR) 10Damilare Adedoyin: "hi jgleeson, thanks for setting this up. I left a small comment in the API implementation." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878129 (https://phabricator.wikimedia.org/T326248) (owner: 10Jgleeson) [14:40:54] (03CR) 10Jgleeson: Add dLocal API request signature header (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/876004 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [14:41:29] thanks for the review damilare! [14:41:42] sure thing [14:44:00] just gonna go pickup Oscar. I'll be back soon [15:11:11] (03PS8) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [15:59:03] (03CR) 10Jgleeson: "Thanks for the review damilare!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878129 (https://phabricator.wikimedia.org/T326248) (owner: 10Jgleeson) [16:32:35] (03CR) 10Ejegg: [C: 03+2] "Looks good! I can see you've thought through all the things I wondered about." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/876004 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [16:33:07] (03Merged) 10jenkins-bot: Add dLocal API request signature header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/876004 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [16:38:08] thanks ejegg ! [16:39:23] (03PS1) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/879596 [16:40:15] (03CR) 10CI reject: [V: 04-1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/879596 (owner: 10Ejegg) [16:42:10] (03PS1) 10Ejegg: Update DonationInterface and SmashPig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/879597 [16:43:02] (03PS2) 10Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/879596 [16:43:15] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Update DonationInterface and SmashPig [wikimedia/fundraising/crm/vendor] - 10https://gerrit.wikimedia.org/r/879597 (owner: 10Ejegg) [16:44:03] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/879596 (owner: 10Ejegg) [16:51:15] PROBLEM - check_mysql on frdb1006 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1006&service=check_mysql [16:56:15] PROBLEM - check_mysql on frdb1006 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1006&service=check_mysql [16:58:22] 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising-Backlog: Adding and storing rml_source data for RML donations reporting - https://phabricator.wikimedia.org/T321163 (10EWilfong_WMF) Reviving this discussion post-Q2. Let me know if the development... [17:01:14] RECOVERY - check_mysql on frdb1006 is OK: Uptime: 776998 Threads: 5 Questions: 52102139 Slow queries: 9 Opens: 1480 Open tables: 1377 Queries per second avg: 67.055 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1006&service=check_mysql [17:01:42] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/879596 (owner: 10Ejegg) [17:05:26] !log civicrm upgraded from 9afd2789 to 7ecb5038 [17:05:28] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:11:50] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10FR-Japan, 10fr-donorservices: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10XenoRyet) p:05Triage→03High [17:17:47] (03PS2) 10AndyRussG: WIP Adyen API idempotency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/870946 (https://phabricator.wikimedia.org/T324860) [17:19:41] (03CR) 10CI reject: [V: 04-1] WIP Adyen API idempotency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/870946 (https://phabricator.wikimedia.org/T324860) (owner: 10AndyRussG) [17:26:33] ejegg: reports of civi being down [17:26:51] (03PS3) 10AndyRussG: WIP Adyen API idempotency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/870946 (https://phabricator.wikimedia.org/T324860) [17:27:08] ejegg: I'm getting unstylized content [17:27:43] (03PS1) 10Jgleeson: Add signature prefix to dLocal API request signature header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879608 (https://phabricator.wikimedia.org/T324274) [17:27:56] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Bug: duplicate Adyen transactions in short sequence - https://phabricator.wikimedia.org/T324860 (10AndyRussG) Current version of the attached patch seems to work! I think at least a bit more testing and study is needed to check for p... [17:28:42] (03CR) 10CI reject: [V: 04-1] WIP Adyen API idempotency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/870946 (https://phabricator.wikimedia.org/T324860) (owner: 10AndyRussG) [17:32:05] (03PS4) 10AndyRussG: WIP Adyen API idempotency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/870946 (https://phabricator.wikimedia.org/T324860) [17:33:23] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Bug: duplicate Adyen transactions in short sequence - https://phabricator.wikimedia.org/T324860 (10AndyRussG) a:05AndyRussG→03None [17:33:47] (03CR) 10CI reject: [V: 04-1] WIP Adyen API idempotency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/870946 (https://phabricator.wikimedia.org/T324860) (owner: 10AndyRussG) [17:34:03] (03PS7) 10Jgleeson: Add dlocal getPaymentMethods API call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878129 (https://phabricator.wikimedia.org/T326248) [17:34:32] (03PS9) 10Jgleeson: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [17:34:50] !log civicrm rolled back from 7ecb5038 to 9afd2789 [17:34:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:38:19] (03PS8) 10Jgleeson: Add dlocal getPaymentMethods API call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878129 (https://phabricator.wikimedia.org/T326248) [17:52:49] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks jgleeson for working on this, looks good to me." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878129 (https://phabricator.wikimedia.org/T326248) (owner: 10Jgleeson) [18:05:57] 10fundraising-tech-ops: Fundraising access request for Anil Kanji - https://phabricator.wikimedia.org/T326765 (10AKanji-WMF) >>! In T326765#8518096, @Dwisehaupt wrote: > Sent intro email and awaiting addition of collab contact info. Added Collab Info @Dwisehaupt , ty [18:07:07] 10Fundraising-Backlog, 10FR-India, 10FR-Smashpig, 10FR-dlocal, 10Recurring-Donations: Implement backend for DLocal recurring UPI payments in SmashPig - https://phabricator.wikimedia.org/T324299 (10Dwisehaupt) [18:13:55] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig - https://phabricator.wikimedia.org/T324289 (10Dwisehaupt) [18:15:05] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig - https://phabricator.wikimedia.org/T324289 (10Ejegg) [18:15:48] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Handle card submission in DLocal in DonationInterface - https://phabricator.wikimedia.org/T324290 (10Dwisehaupt) [18:19:26] 10Fundraising-Backlog: Class 'wmf_civicrm\ImportStatsCollector' not found in wmf_civicrm_contribution_message_import() - https://phabricator.wikimedia.org/T326841 (10AnnWF) [18:20:10] 10Fundraising-Backlog: Class 'wmf_civicrm\ImportStatsCollector' not found in wmf_civicrm_contribution_message_import() - https://phabricator.wikimedia.org/T326841 (10AnnWF) [18:24:27] 10fundraising-tech-ops: Fundraising access request for Anil Kanji - https://phabricator.wikimedia.org/T326765 (10greg) Added @AKanji-WMF to #acl_wmf-fr, #wmf-nda, #project-admins as well. @AKanji-WMF can you add/verify you have 2fa enabled on your Phab account? You can see it here: https://phabricator.wikimedia... [18:48:04] 10fundraising-tech-ops: Fundraising access request for Anil Kanji - https://phabricator.wikimedia.org/T326765 (10Dwisehaupt) [18:50:03] 10fundraising-tech-ops: Fundraising access request for Anil Kanji - https://phabricator.wikimedia.org/T326765 (10Dwisehaupt) Verified contact info was in collab. Created ssl client cert and sent it via email. Sent password via sms. Created civicrm account with random password. Sent notification with how to chang... [18:50:20] 10fundraising-tech-ops: Fundraising access request for Anil Kanji - https://phabricator.wikimedia.org/T326765 (10Dwisehaupt) [19:38:56] (03PS10) 10Jgleeson: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [19:45:29] ty for the review damilare ! [19:45:39] np [19:48:47] (03CR) 10Damilare Adedoyin: [C: 03+2] Add signature prefix to dLocal API request signature header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879608 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [19:49:20] just saw this was blocking the merge of the last one [19:49:21] (03Merged) 10jenkins-bot: Add signature prefix to dLocal API request signature header [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879608 (https://phabricator.wikimedia.org/T324274) (owner: 10Jgleeson) [19:49:27] (03Merged) 10jenkins-bot: Add dlocal getPaymentMethods API call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878129 (https://phabricator.wikimedia.org/T326248) (owner: 10Jgleeson) [19:51:42] ah yeah I restacked 'em. thanks for all the review! [19:51:57] 10fundraising-tech-ops: Fundraising access request for Anil Kanji - https://phabricator.wikimedia.org/T326765 (10AKanji-WMF) Thanks @Dwisehaupt , I'm able to log into Civi and Superset. @greg I've enabled 2FA in Phabricator. [20:00:20] ok fr-tech I'm going to try to redo the deploy [20:00:36] this time with the queues stopped [20:00:52] oh, actually, does anyone else want to try to reproduce the missing CSS locally? [20:01:08] I have the current deployment branch pulled down in my wmff site and it all looks fine [20:04:50] ejegg: I was going to try but my local civi is now misbehaving [20:05:06] oh shoot, how so? [20:05:15] its mad about wmf_settings.json [20:05:24] 's permissions but they look like everything else in that folder [20:05:32] ahh, I had that once [20:05:36] lemme see what I did [20:05:51] did I write that down? [20:06:17] https://wikitech.wikimedia.org/wiki/Fundraising/Internal-facing/CiviCRM#Troubleshooting_setup [20:06:23] Make sure the settings directory (src/civi-sites/wmff/drupal/sites/default/) is writeable by the user that runs setup.sh [20:10:21] (03PS11) 10Damilare Adedoyin: iImplement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [20:11:17] thanks ejegg [20:24:24] ejegg: got it locally and i see the css [20:24:48] huh, ok, I'll just turn off the queues and try deploying then clearing all the caches [20:24:53] thanks for checking cstone ! [20:25:04] yeah no console errors at all [20:25:04] * greg-g is happy to be an F5 presser while he's in a meeting :) [20:26:39] 10Fundraising-Backlog, 10FR-India, 10FR-Smashpig, 10FR-dlocal, 10Recurring-Donations: Implement backend for DLocal recurring UPI payments in SmashPig - https://phabricator.wikimedia.org/T324299 (10Ejegg) [20:29:40] !log disabled fundraising scheduled jobs for civi deploy [20:29:41] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:31:07] !log civicrm upgraded from 9afd2789 to 7ecb5038 [20:31:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:32:50] ok, styling is still gone [20:32:53] and I see this [20:32:57] The specified file temporary://filePnPGBh could not be copied, because the destination directory is not properly configured. This may be caused by a problem with file or directory permissions. More information is available in the system log. [20:33:17] looking at logs [20:33:54] the destination directory public://js is not configured correctly. [20:34:03] okayyyyy [20:34:14] I guess that's why no styles [20:34:16] but how to fix [20:35:36] dwisehaupt: I might need some help changing dir permissions in Civi [20:36:38] yup confirmed no css/etc [20:36:49] huh, sites/default/files/js and sites/default/files/css are both writable by the web user [20:37:19] DR is complaining :) [20:38:00] well shoot, I can roll back again, or try to fix now [20:38:23] try the fix if you can quickly, I'd say [20:41:03] damn, filesystem config looks right at https://civicrm.wikimedia.org/admin/config/media/file-system [20:41:12] I mean the values, that page is also without styles [20:42:04] well, I guess I'll roll back and Eileen can try again on Sunday [20:43:14] !log rolled back CiviCRM to 9afd2789 [20:43:16] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:44:01] ejegg: sorry, was on the phone. let me know if you need anything. [20:44:09] greg-g: ok, I rolled back [21:03:48] (03PS1) 10Jgleeson: WIP: Add dlocal health check maintenance script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879647 (https://phabricator.wikimedia.org/T326248) [21:07:52] catch you all tomorrow o/ [21:18:53] 10Fundraising-Backlog, 10fr-donorservices: Add check to pending transaction resolver to not resolve more than one donation per donor per run - https://phabricator.wikimedia.org/T326361 (10MBeat33) [21:19:53] !log civicrm upgraded from 9afd2789 to 7ecb5038 [21:19:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:20:00] ok, now to restart the jobs [21:21:23] !log restarted fundraising scheduled jobs [21:21:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:22:02] jeez, that took a lot more of my day than I was expecting! [21:25:30] (03PS14) 10Wfan: Render smartfield ui to the dlocal gateway page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/868161 (https://phabricator.wikimedia.org/T324271) [21:25:46] 10fundraising-tech-ops: Fundraising access request for Anil Kanji - https://phabricator.wikimedia.org/T326765 (10Dwisehaupt) [21:26:11] 10fundraising-tech-ops: Fundraising access request for Anil Kanji - https://phabricator.wikimedia.org/T326765 (10Dwisehaupt) Verified access is good and working for our systems. @greg Do you have anything else you want to keep this task open for? If not we are clear to resolve it. [21:35:45] ejegg: just saw your comment - that's the drupal upgrade rolled back - I think there might be some cache clearing that works but Mon also an option [21:36:38] eileen: it's fixed! [21:36:44] it's all rolled forward [21:36:52] I sent an email with the magic vset [21:39:28] oh yay [21:51:31] 10Fundraising-Backlog: Class 'wmf_civicrm\ImportStatsCollector' not found in wmf_civicrm_contribution_message_import() - https://phabricator.wikimedia.org/T326841 (10Ejegg) Oops, this class was moved in the civi deploy and I forgot to stop the scheduled jobs until clearing the caches. It's fixed now. [21:51:43] 10Fundraising-Backlog: Class 'wmf_civicrm\ImportStatsCollector' not found in wmf_civicrm_contribution_message_import() - https://phabricator.wikimedia.org/T326841 (10Ejegg) 05Open→03Resolved a:03Ejegg [22:04:49] 10fundraising-tech-ops: Fundraising access request for Anil Kanji - https://phabricator.wikimedia.org/T326765 (10greg) Nope, good to close, I'll do the security access request separately. [22:06:37] 10fundraising-tech-ops: Fundraising access request for Anil Kanji - https://phabricator.wikimedia.org/T326765 (10Dwisehaupt) 05Open→03Resolved [22:33:08] 10Fundraising-Backlog, 10FR-Italy, 10fr-donorservices: Italian mobile form obscures the card number field - https://phabricator.wikimedia.org/T275458 (10TSkaff) @MBeat33 I think we can close this since we're using Adyen this year (not Ingenico). Still perplexed at what this person was seeing, but we won't be... [22:34:53] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10FR-Japan, 10fr-donorservices: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10Ejegg) a:03Ejegg [23:14:46] (03PS1) 10Ejegg: WIP first variant for Japan tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879658 (https://phabricator.wikimedia.org/T322793) [23:15:48] (03PS2) 10Ejegg: WIP first variant for Japan tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879658 (https://phabricator.wikimedia.org/T322793) [23:17:32] (03CR) 10CI reject: [V: 04-1] WIP first variant for Japan tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879658 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [23:35:21] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10FR-Japan, 10fr-donorservices, 10Patch-For-Review: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10Ejegg) Hi @TSkaff I am starting to implement these now. I've got a working version of variant 1A, with one... [23:36:07] (03PS1) 10Vaughn Walters: selenium: Remove webdriverio npm package from the CentralNotice extension [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/879668 (https://phabricator.wikimedia.org/T325059) [23:37:22] (03PS1) 10Ejegg: WIP update Japanese Adyen expiration date placeholder [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879665 (https://phabricator.wikimedia.org/T322793) [23:37:41] (03CR) 10CI reject: [V: 04-1] selenium: Remove webdriverio npm package from the CentralNotice extension [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/879668 (https://phabricator.wikimedia.org/T325059) (owner: 10Vaughn Walters) [23:39:01] (03CR) 10CI reject: [V: 04-1] WIP update Japanese Adyen expiration date placeholder [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879665 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [23:41:09] (03PS3) 10Ejegg: WIP first variant for Japan tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879658 (https://phabricator.wikimedia.org/T322793) [23:41:11] (03PS2) 10Ejegg: WIP update Japanese Adyen expiration date placeholder [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879665 (https://phabricator.wikimedia.org/T322793) [23:47:53] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10FR-Japan, 10fr-donorservices, 10Patch-For-Review: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10TSkaff) @EMartin @CDenes_WMF @krobinson Per Elliott's comments above--is this ok with you to proceed updati...