[06:46:08] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/880055 (owner: 10L10n-bot) [09:27:17] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/880055 (owner: 10L10n-bot) [13:54:48] 10Fundraising-Backlog, 10FR-Docker, 10mwcli: Docker: config to selectively enable/disable services - https://phabricator.wikimedia.org/T326972 (10Addshore) In principle, I see no reason mwcli couldn't work for yall with some tweaks. Not sure how interesting that would sound to you though. The idea for mwcli... [14:35:14] (03PS2) 10Jgleeson: Tweak dlocal API request header date format. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879858 [14:36:53] (03PS3) 10Jgleeson: Tweak dlocal API request header date format. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879858 [14:37:13] (03CR) 10Jgleeson: "ready for review!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879858 (owner: 10Jgleeson) [14:39:10] (03PS4) 10Jgleeson: Tweak dlocal API request header date format. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879858 [14:39:26] (03PS7) 10Jgleeson: Add dlocal health check maintenance script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879647 (https://phabricator.wikimedia.org/T326248) [15:20:45] (03PS5) 10Jgleeson: Tweak dlocal API request header date format. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879858 [15:22:37] (03PS8) 10Jgleeson: Add dlocal health check maintenance script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879647 (https://phabricator.wikimedia.org/T326248) [15:45:14] (03PS12) 10Jgleeson: iImplement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [15:45:47] rebasing over latest ^ [15:47:37] in order to review [15:49:36] time for the second school run! Oscar has an arts and craft hour after school every Monday for the next four weeks. Back soon [18:06:49] 7 [18:07:18] sorry - mistype [18:07:34] that's in now [18:07:37] you typed 7 [18:08:11] * jgleeson pulls trapdoor lever [18:11:37] secret IRC codes! [18:12:43] :) [18:44:56] (03PS1) 10Damilare Adedoyin: Handle errors from DLocal SmartForms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880528 (https://phabricator.wikimedia.org/T324272) [19:26:32] (03CR) 10Jgleeson: [C: 04-1] "Thanks Dami. Still some work to do on this one." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [20:19:53] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Dedupe query under certain rules no longer generating queries - https://phabricator.wikimedia.org/T326605 (10Eileenmcnaughton) @SHust I'm still digging but I was able to reproduce the issue with the large number of contacts you trie... [20:21:32] fr-tech, I'm guessing we're skipping today's call due to the US holidau [20:21:38] holiday* [20:26:25] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Dedupe query under certain rules no longer generating queries - https://phabricator.wikimedia.org/T326605 (10Eileenmcnaughton) Here is how using contact ID would work {F36268408} [20:29:04] yeah I think so [20:29:14] jgleeson, I guess so also [20:29:47] cool cool [20:33:45] (03PS13) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [20:34:46] (03CR) 10Damilare Adedoyin: "Thanks for comments jgleeson, made some changes and responded to one of them inline" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [20:34:55] ah mlk day [20:35:03] damilare: you might want to pull first [20:35:14] I'm about if anyone needs anything tho btw [20:35:24] also hoping anyone in California is doing ok! [20:35:41] it looks like a bunch of stuff that got added during the latest rebase has been removed in your latest PS [20:35:50] (03PS14) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [20:35:56] done [20:36:24] damilare: did you managed to test create payment? [20:36:28] have* [20:37:35] not yet I think you made some changes to th headers as well, would it work without [20:37:43] i think a smoke test on top of the health check might be a good step as it took me about 3 hours to review the earlier stuff to find some of the stuff noted [20:38:47] I rebased your patch on top of the latest stuff earlier in the day so i could review it. you should have all the header updates I think [20:39:27] there were a few conflict when rebasing your stuff over which i resolved. I don't think the headers was an issue [20:39:45] hey - so no meeting due to US holiday? [20:40:06] I mean would the requests work without this patch: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/879858? [20:40:45] eileen: yeah I think [20:40:56] anyway both ops folks are out [20:41:13] yep eileen ! [20:41:22] ok cool [20:41:36] hmm damilare this patch was previously rebased over that change [20:41:45] earlier today [20:43:01] ok thanks [20:43:16] no it's not there now [20:43:27] I think your last push got rid of them [20:43:35] possibly due to it not being the latest [20:43:46] I didn't think gerrit let that happen [20:44:06] let me see what happens when I try to rebase it again [20:44:31] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/879647 that was the original chain [20:44:39] you can see your patch at the top is now not current [20:44:51] so hopefully it can be re-rebased ha [20:45:05] argh [20:45:14] no it's showing a bunch of conflicts again [20:45:34] it might be easier to pull down the tip of this old patch dami https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/879647 [20:45:48] ok [20:45:50] and then merge your latest changes into that [20:58:46] (03CR) 10Jgleeson: Implement createPayment for DLocal CC / SmartFields in SmashPig (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [21:12:38] (03CR) 10Jgleeson: "Thanks for the updates. I'll test 'em properly tomorrow. There's a few other unresolved items I think so I'll hold out until you let me kn" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [21:19:29] have a good evening all o/ [21:35:21] 👋🏽 [23:18:22] 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising-Backlog: Adding and storing rml_source data for RML donations reporting - https://phabricator.wikimedia.org/T321163 (10Eileenmcnaughton) I've pulled this back to our triage column so we can discuss... [23:23:20] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Install `coworker` and `cv` on prod - https://phabricator.wikimedia.org/T324611 (10Eileenmcnaughton) @Ejegg you found the page to request a repo & put it in a hangout - but I lost what it is. I think in terms of the repo there a...