[11:26:08] (03PS15) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [11:35:18] (03PS2) 10Damilare Adedoyin: Handle errors from DLocal SmartForms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880528 (https://phabricator.wikimedia.org/T324272) [12:20:50] (03CR) 10Jgleeson: Implement createPayment for DLocal CC / SmartFields in SmashPig (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [12:22:30] sure thing jgleeson, thanks for the constructive feedback as well [12:23:11] please can you wait 1 sec before the final review... sorry, I'd give you heads up once I've pushed the last recommended change [12:24:13] np! and thank you for all the work. sure thing, I'll hold off until you say it's ready [12:51:28] (03PS16) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [12:58:02] (03CR) 10Damilare Adedoyin: "Thanks jgleeson, I've made the recommended changes and ran a smoke test to confirm the requests is made." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [12:59:53] (03PS17) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [13:00:34] hi jgleeson, you can proceed with the review now. Thanks [13:11:43] thanks damilare [13:12:09] I finally submitted the CiviSprint expense claim [13:12:17] and did the Coupa training at the same time ha [13:13:49] sounds like a productive day already [13:16:09] food time [14:15:17] 10Fundraising Tech - Chaos Crew: Recurring job triggering recurring failmail - https://phabricator.wikimedia.org/T327174 (10jgleeson) [14:19:10] (03PS1) 10Jgleeson: Tone down the LockError exception message. [wikimedia/fundraising/process-control] - 10https://gerrit.wikimedia.org/r/880965 (https://phabricator.wikimedia.org/T327174) [14:32:55] PHP 8.2 has deprecated ${} string interpolations along with utf8_encode and utf8_decode functions :S [14:33:19] looks like we've got a few instances of those scattered around [14:33:33] https://www.php.net/releases/8.2/en.php [14:37:52] damilare: did you see these comments https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/878135/ which are marked as unresolved? [14:38:13] I'm heading out to pick the kids up. back soon! [14:50:57] (03PS18) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [14:51:38] oops, sorry about that jgleeson|skrun. done now [14:51:59] (03CR) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig (0315 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [15:15:28] (03PS3) 10Damilare Adedoyin: Handle errors from DLocal SmartForms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880528 (https://phabricator.wikimedia.org/T324272) [15:20:06] (03PS4) 10Damilare Adedoyin: Handle errors from DLocal SmartForms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880528 (https://phabricator.wikimedia.org/T324272) [15:30:44] (03CR) 10Damilare Adedoyin: "Hi jgleeson, thanks for working on this. It works for me, but I'm not sure about the approach taken (comments inline)." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879647 (https://phabricator.wikimedia.org/T326248) (owner: 10Jgleeson) [16:21:02] (03CR) 10Jgleeson: "Thanks Dami! I've added some notes regarding switching over to a consistent health check pattern." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879647 (https://phabricator.wikimedia.org/T326248) (owner: 10Jgleeson) [16:42:40] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Install `coworker` and `cv` on prod - https://phabricator.wikimedia.org/T324611 (10Ejegg) Here's the link @Eileenmcnaughton : https://www.mediawiki.org/wiki/Gerrit/New_repositories I agree that vendor as a submodule would make n... [17:00:12] (03CR) 10Zfilipin: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/879668 (https://phabricator.wikimedia.org/T325059) (owner: 10Vaughn Walters) [17:10:16] (03CR) 10Damilare Adedoyin: [C: 03+2] Add dlocal health check maintenance script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879647 (https://phabricator.wikimedia.org/T326248) (owner: 10Jgleeson) [17:30:15] 10Fundraising-Backlog, 10FR-Civi-Dedupe: Alternate name field for donors with different alphabet characters - https://phabricator.wikimedia.org/T275678 (10LeanneS) After chatting with Sandra, having the values added to nickname field wouldn't necessarily cause any issues, but if the data is to be used, there s... [17:33:59] 10Fundraising Tech - Chaos Crew: Request failed: no data found for trigger id 214227925 - https://phabricator.wikimedia.org/T327191 (10AnnWF) [17:36:42] 10Fundraising Tech - Chaos Crew: Request failed: no data found for trigger id 214227925 - https://phabricator.wikimedia.org/T327191 (10AnnWF) [17:55:46] thanks for the review damilare|brb! Also, the health check idea is a first pass so if you have any ideas on how to improve or arguments against that would be good feedback too. thanks again! [18:42:39] (03PS3) 10Cstone: Replace creation date with booking date for the payments accounting report [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879690 (https://phabricator.wikimedia.org/T326254) [18:51:04] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Dedupe query under certain rules no longer generating queries - https://phabricator.wikimedia.org/T326605 (10SHust) Thanks for digging Eileen we tried searching for smaller batches and adding a contact ID segmentation, plus many othe... [18:54:49] 10Fundraising Tech - Chaos Crew, 10Patch-For-Review: Recurring job triggering recurring failmail - https://phabricator.wikimedia.org/T327174 (10Cstone) I think actually doing {T239770} will help with this as right now the log just spits everything out at the end which isn't helpful. Something happened within... [18:57:43] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks for working on this wfan. LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/868161 (https://phabricator.wikimedia.org/T324271) (owner: 10Wfan) [18:59:13] np jgleeson|away [18:59:36] (03Merged) 10jenkins-bot: Render smartfield ui to the dlocal gateway page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/868161 (https://phabricator.wikimedia.org/T324271) (owner: 10Wfan) [19:00:03] Thanks damilare :P [19:16:17] jgleeson|ish [19:16:31] let's try that again [19:17:17] cstone: thanks. that also sounds like a good idea on the ticket [19:17:52] how do you feel above changing 'Aborting!' to 'skipping' [19:18:05] sounds less NASA Panic to me [19:18:21] sounds good to me jgleeson|ish [19:18:33] thanks ejegg [19:18:58] I guess in some cases it's fine for jobs to overrun [19:19:06] it's not always a sign of a problem that is [19:19:22] but a helpful hint that we might wanna tweak the config [19:19:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: change default to Adyen for Japan - https://phabricator.wikimedia.org/T326676 (10XenoRyet) [19:19:45] yep, we do actually have an allow_overtime flag in the config [19:19:58] oh yeah I forgot about that [19:20:00] to specifically skip that failmail on a per-job basis [19:20:22] maybe that's a better approach? [19:21:22] i am curious why its taking longer for adyen though [19:21:23] If anyone was able to look at these last 2 (small) patches I could close the phab out in the sprint .. https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/877306/ [19:26:59] eileen: they both look like pretty straightforward +2 cases to me [19:27:05] the first one slightly more meaty [19:27:20] would I need to rebuild to test it? [19:27:30] jgleeson|ish: yep - I had some grander plans around indexes but scaled back to just moving the code [19:28:09] I guess I'm feeling inclined to +2 them both but slightly hesitant without a smoke test [19:28:17] on the first one [19:34:42] yeah - they only sort of affect our dev environments - I mean they add the index like on live but without the volume of data the indexes are kinda meaningless [19:38:26] (03CR) 10AndyRussG: [C: 03+2] "Smoke tested and debugged through, works great! Thanks so much!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877302 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [19:38:46] oh yay thanks AndyRussG [19:38:49] (03CR) 10AndyRussG: [C: 03+2] "Bwaahaha cruft begone!!!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877306 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [19:38:58] eileen: thank u! :) [19:39:14] thanks AndyRussG [19:39:27] jgleeson: thank u :) [19:40:25] fr-tech any 20-minute final-push tasks available? [19:51:15] 10Fundraising-Backlog: Move Croatia to Adyen as default - https://phabricator.wikimedia.org/T327207 (10EMartin) [19:53:36] (03Merged) 10jenkins-bot: Move last wmf_civicrm.install functions to extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877302 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [19:54:21] (03Merged) 10jenkins-bot: Remove unused php helper file [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/877306 (https://phabricator.wikimedia.org/T270680) (owner: 10Eileen) [19:56:21] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/880998 [19:56:37] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Adyen iframe config error messages Q2 2022: the sequel - https://phabricator.wikimedia.org/T324362 (10Cstone) [19:56:47] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/880998 (owner: 10Eileen) [20:04:57] !log config revision changed from 2e5cee3c to 7425df0b [20:04:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:06:02] 10Fundraising Sprint Amazing grep, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Bus error 2: The bus strikes back - https://phabricator.wikimedia.org/T326013 (10Eileenmcnaughton) a:03Eileenmcnaughton [20:06:06] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog: Write up medium term project outline for ESI+CentralNotice - https://phabricator.wikimedia.org/T325191 (10XenoRyet) 05Open→03Resolved [20:06:46] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10FR-AutoTY-Email: Please begin the deployment of the Auto TY email receipt ("End of Year Receipt") - https://phabricator.wikimedia.org/T326155 (10XenoRyet) 05Open→03Resolved [20:08:42] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising Sprint Undefined, 10Fundraising Sprint Vwl Cnsrvtn, and 4 others: Add a test version of a main-cluster wiki to fundra... - https://phabricator.wikimedia.org/T317498 [20:09:03] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog: Manually sent civi thank you email has a time stamp either in the past or future - https://phabricator.wikimedia.org/T326371 (10XenoRyet) 05Open→03Resolved [20:09:31] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10FR-Docker: Set up CentralNotice on donut container - https://phabricator.wikimedia.org/T326673 (10XenoRyet) 05Open→03Resolved [20:09:36] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising Sprint Undefined, 10Fundraising Sprint Vwl Cnsrvtn, and 4 others: Add a test version of a main-cluster wiki to fundra... - https://phabricator.wikimedia.org/T317498 [20:09:57] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Undefined, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog: Add error handling and mapping for Smashpig PayPal EC GetExpressCheckoutDetails API call - https://phabricator.wikimedia.org/T322570 (... [20:10:42] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising Sprint Undefined, 10Fundraising Sprint Vwl Cnsrvtn, and 2 others: Access to Logstash/OpenSearch Dashboards for all FR... - https://phabricator.wikimedia.org/T321494 [20:10:53] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Turtles that are robotic that destroy the whole world with their foot theory, 10Fundraising Sprint Undefined, 10Fundraising Sprint Vwl Cnsrvtn, and 2 others: Access to Logstash/OpenSearch Dashboards for all FR... - https://phabricator.wikimedia.org/T321494 [20:11:39] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Create DLocal PaymentProvider in SmashPig - https://phabricator.wikimedia.org/T324273 (10XenoRyet) 05Open→03Resolved [20:11:41] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet) [20:12:03] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Zeitgeistbusters, 10Fundraising-Backlog, and 3 others: Clean up install script from wmf_civicrm & move relevant parts to the extension - https://phabricator.wikimedia.org/T270680 (10XenoRyet) [20:12:50] 10Fundraising Sprint Git Rebase Jump, 10Fundraising Sprint Humongous bacteria petting zoo, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Move all remaining dedupe code out of wmf_civicrm to deduper extension - https://phabricator.wikimedia.org/T270679 (10XenoRyet) [20:12:54] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Zeitgeistbusters, 10Fundraising-Backlog, and 3 others: Clean up install script from wmf_civicrm & move relevant parts to the extension - https://phabricator.wikimedia.org/T270680 (10XenoRyet) 05Open... [20:13:04] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Gather WMF data to supplement Logging report - https://phabricator.wikimedia.org/T324161 (10XenoRyet) 05Open→03Resolved [20:13:45] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Undefined, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, and 3 others: Implement PayPal EC ManageRecurringPaymentsProfileStatusCancel in SmashPig - https://phabricator.wikimedia.org/T318883 (10XenoRyet) 05Open→03... [20:13:47] 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig, 10Epic: Move PayPal EC API calls to SmashPig - https://phabricator.wikimedia.org/T317245 (10XenoRyet) [20:14:22] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10fr-donorservices: Smart group created to 'batch merge' not showing up in the Deduper interface - https://phabricator.wikimedia.org/T326158 (10XenoRyet) 05Open→03Resolved [20:14:52] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Unplanned-Sprint-Work: CiviCRM security ports - https://phabricator.wikimedia.org/T326271 (10XenoRyet) 05Open→03Resolved [20:16:49] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Gather WMF data to supplement Logging report - https://phabricator.wikimedia.org/T324161 (10Eileenmcnaughton) [20:16:54] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Figure out storage implications of varchar vs text in possible logging solution - https://phabricator.wikimedia.org/T325789 (10Eileen... [20:16:57] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Figure out storage implications of varchar vs text in possible logging solution - https://phabricator.wikimedia.org/T325789 (10Eileen... [20:18:32] (03CR) 10Damilare Adedoyin: [C: 03+2] Tweak dlocal API request header date format. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879858 (owner: 10Jgleeson) [20:20:43] 10Fundraising Tech - Chaos Crew, 10MW-1.40-notes (1.40.0-wmf.18; 2023-01-09): Dlocal: Call to a member function setCommunicationStatus() on null - https://phabricator.wikimedia.org/T324353 (10XenoRyet) 05Open→03Resolved [20:21:16] 10Fundraising Tech - Chaos Crew: dLocal Insecure Form warnings - https://phabricator.wikimedia.org/T318742 (10XenoRyet) 05Open→03Resolved [20:21:58] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-PayPal-ExpressCheckout, 10FR-Smashpig: Add PayPal IPN type for recurring_payment_outstanding_payment_failed - https://phabricator.wikimedia.org/T324510 (10XenoRyet) 05Open→03Resolved [20:23:56] 10Fundraising-Backlog: change default to Adyen for Japan - https://phabricator.wikimedia.org/T326676 (10XenoRyet) [20:53:58] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Ensure external scripts are loaded before using them - https://phabricator.wikimedia.org/T327214 (10Ejegg) [20:56:42] 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Make sure gateway script fully loaded first for Dlocal, Adyen Checkout and Amazon - https://phabricator.wikimedia.org/T326975 (10AnnWF) [20:56:48] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Ensure external scripts are loaded before using them - https://phabricator.wikimedia.org/T327214 (10AnnWF) [20:57:28] 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Make sure gateway script fully loaded first for Dlocal, Adyen Checkout and Amazon - https://phabricator.wikimedia.org/T326975 (10AnnWF) [21:00:31] (03PS2) 10Vaughn Walters: selenium: Remove webdriverio npm package from the extension [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/879668 (https://phabricator.wikimedia.org/T325059) [21:18:00] 10Fundraising Sprint B 2023, 10Fundraising-Backlog: Move Croatia to Adyen as default - https://phabricator.wikimedia.org/T327207 (10XenoRyet) [21:18:03] 10Fundraising Sprint B 2023, 10Fundraising-Backlog: change default to Adyen for Japan - https://phabricator.wikimedia.org/T326676 (10XenoRyet) [21:18:05] 10Fundraising Sprint B 2023, 10Fundraising-Backlog: Unhurt our brains - activity_date_time - https://phabricator.wikimedia.org/T326606 (10XenoRyet) [21:18:09] 10Fundraising Sprint B 2023, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Upgrade Civi to latest point version now BE is over - https://phabricator.wikimedia.org/T326272 (10XenoRyet) [21:18:13] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint B 2023, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, and 3 others: Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4 - https://phabricator.wikimedia.org/T326372 (10XenoRyet) [21:18:17] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint B 2023, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Implement dLocal health check API call - https://phabricator.wikimedia.org/T326248 (10XenoRyet) [21:18:21] 10Fundraising Sprint B 2023, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-PayPal-ExpressCheckout: Update Pending Transaction Resolver to handle PayPal - https://phabricator.wikimedia.org/T324642 (10XenoRyet) [21:18:25] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint B 2023, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Decommission `civi-data-translate` extension - https://phabricator.wikimedia.org/T325698 (10XenoRyet) [21:18:29] 10Fundraising Sprint B 2023, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Handle IPNs from DLocal payins - https://phabricator.wikimedia.org/T324293 (10XenoRyet) [21:18:33] 10Fundraising Sprint B 2023, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig - https://phabricator.wikimedia.org/T324289 (10XenoRyet) [21:18:39] 10Fundraising Sprint B 2023, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Handle submission for DLocal REDIRECT methods in DonationInterface - https://phabricator.wikimedia.org/T324291 (10XenoRyet) [21:18:43] 10Fundraising Sprint B 2023, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Handle card submission in DLocal in DonationInterface - https://phabricator.wikimedia.org/T324290 (10XenoRyet) [21:18:47] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint B 2023, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Implement approvePayment for DLocal in SmashPig - https://phabricator.wikimedia.org/T324281 (10XenoRyet) [21:18:55] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint B 2023, 10Fundraising-Backlog, 10FR-Smashpig, and 2 others: Implement createPayment for DLocal CC / SmartFields in SmashPig - https://phabricator.wikimedia.org/T324279 (10XenoRyet) [21:19:01] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint B 2023, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, and 3 others: Render card SmartField on DLocal form - https://phabricator.wikimedia.org/T324271 (10XenoRyet) [21:19:05] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint B 2023, 10Fundraising-Backlog, 10FR-Smashpig, and 2 others: Implement DLocal signature calculation in SmashPig - https://phabricator.wikimedia.org/T324274 (10XenoRyet) [21:19:11] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint B 2023, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, and 3 others: Handle errors from DLocal SmartForms - https://phabricator.wikimedia.org/T324272 (10XenoRyet) [21:19:17] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint B 2023, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.40-notes (1.40.0-wmf.19; 2023-01-16): Make DonationInterface compatible with MediaWiki 1.39 - https://phabricator.wikimedia.org/T324154 (10XenoRyet) [21:19:25] 10Fundraising Sprint B 2023, 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, and 6 others: Creating New Matching Gift Import - https://phabricator.wikimedia.org/T303986 (10XenoRyet) [21:19:29] 10Fundraising Sprint B 2023, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Donations queue consumer should write stats every minute - https://phabricator.wikimedia.org/T323162 (10XenoRyet) [21:19:33] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint B 2023, 10Fundraising-Backlog, 10FR-Japan, and 2 others: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10XenoRyet) [21:35:48] thanks for reviewing that other small patch damilare. There's one more at the bottom of that chain here with is a really small change https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/879857/1 [21:36:05] which* [21:36:40] (03CR) 10Damilare Adedoyin: "Seems this hasn't been updated since the change to the makeApiCall function. Suggestion inline" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879857 (owner: 10Jgleeson) [21:37:14] ahh coincidentally I was just writing a review on that jgleeson [21:41:52] damilare: I think the change you're referring to hasn't happened yet in the context of that patch [21:41:59] it happens in you patch later on [21:42:07] ohh right [21:42:07] (adding $route param) [21:42:18] time travel [21:42:21] ha! [21:42:33] yeah. your patch will update that [21:42:52] (03CR) 10Damilare Adedoyin: [C: 03+2] "Nevermind last comment, LGTM" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879857 (owner: 10Jgleeson) [21:43:03] thanks!!! [21:43:20] I guess I should fix that in my patch then [21:43:33] (03Merged) 10jenkins-bot: Fix dlocal route for payments-methods call. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879857 (owner: 10Jgleeson) [21:43:37] (03Merged) 10jenkins-bot: Tweak dlocal API request header date format. [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879858 (owner: 10Jgleeson) [21:43:39] (03Merged) 10jenkins-bot: Add dlocal health check maintenance script [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/879647 (https://phabricator.wikimedia.org/T326248) (owner: 10Jgleeson) [21:43:48] yeah that would work [21:44:06] the tests should pick it up [21:44:14] they are checking the URL [21:44:19] and route [21:47:38] ohh looks like I already did [21:48:23] here: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/878135/18/PaymentProviders/dlocal/Api.php [21:49:55] awesome! [21:53:00] 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Donations queue consumer should write stats every minute - https://phabricator.wikimedia.org/T323162 (10Ejegg) [21:54:16] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Japan, and 2 others: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10Ejegg) >>! In T322793#8522583, @CDenes_WMF wrote: > Dang! I really wanted to see how th... [21:55:16] Eileen do you have any recollection of seeing 'Request failed: no data found for trigger id 214227925' when you were writing the Omnimail recipient fetch / load calls? [21:55:25] They seem to all be failing with that code today [21:55:51] oh weird - no - is that the id of a DB trigger? [22:07:03] eileen: I wish I knew! [22:07:30] ejegg: we can dig in in tech talk - maybe dwisehaupt can join? [22:11:04] tech talk in 50 mins? i could probably join. [22:14:30] cool [22:15:17] separate question - this failmail issue - https://phabricator.wikimedia.org/T323057 - I put in a hack-fix for the imap timeout with a plan to upstream if the hack-fix worked - am I right in thinking it did? I feel like that fail mail variant eased up... [22:18:27] i don't know about that one. [22:19:12] that does seem right eileen [22:19:24] last 'failed with code 1' I see is Nov 21 [22:19:50] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Upgrade Civi to latest point version now BE is over - https://phabricator.wikimedia.org/T326272 (10Eileenmcnaughton) a:03Eileenmcnaughton Since it is a wee while since we last upgraded I need to check th... [22:19:57] ejegg: cooll [22:20:48] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Upstream imap timeout fix - https://phabricator.wikimedia.org/T327225 (10Eileenmcnaughton) [22:25:59] (03PS1) 10Wfan: WIP: Preload third party script [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881013 (https://phabricator.wikimedia.org/T326975) [22:38:50] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Figure out storage implications of varchar vs text in possible logging solution - https://phabricator.wikimedia.org/T325789 (10Jgreen... [22:42:00] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Figure out storage implications of varchar vs text in possible logging solution - https://phabricator.wikimedia.org/T325789 (10Jgreen... [22:56:08] (03PS1) 10Wfan: If no supported gateway, show donate wiki instead of error page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880519 (https://phabricator.wikimedia.org/T326666) [22:57:49] (03CR) 10CI reject: [V: 04-1] If no supported gateway, show donate wiki instead of error page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880519 (https://phabricator.wikimedia.org/T326666) (owner: 10Wfan) [23:12:42] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Handle JS ReferenceError: AdyenCheckout is not defined - https://phabricator.wikimedia.org/T326610 (10Cstone) [23:13:39] (03PS4) 10Ejegg: First variant for Japan tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879658 (https://phabricator.wikimedia.org/T322793) [23:13:41] (03PS2) 10Ejegg: Japan form variant #2 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879689 (https://phabricator.wikimedia.org/T322793) [23:39:06] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: GatewayChooser: No supported gateway for parameters - https://phabricator.wikimedia.org/T326666 (10AnnWF) E.g.: For country that we are not accept paypal, like AF. we still see the paypal option from donate wiki page, probably needs...