[00:04:51] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Resolve core CiviCRM test regression without hack - https://phabricator.wikimedia.org/T327360 (10Eileenmcnaughton) [00:06:22] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Resolve core CiviCRM test regression without hack - https://phabricator.wikimedia.org/T327360 (10Eileenmcnaughton) [00:21:55] (03PS2) 10Eileen: Stock CiviCRM 5.58.beta1 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881061 (https://phabricator.wikimedia.org/T326272) [00:30:11] (03Abandoned) 10Eileen: Stock CiviCRM 5.58.beta1 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881063 (https://phabricator.wikimedia.org/T326272) (owner: 10Eileen) [00:42:50] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, and 2 others: Figure out storage implications of varchar vs text in possible logging solution - https://phabricator.wikimedia.org/T325789 (10Eileenmcnaughton) @jgreen... [00:59:40] (03PS1) 10Eileen: Temporarily remove slow, unhelpful query [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881490 (https://phabricator.wikimedia.org/T326272) [01:50:32] (03CR) 10Wfan: [C: 03+2] "Looks good for the "Uncaught ReferenceError: AdyenCheckout is not defined" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881050 (https://phabricator.wikimedia.org/T326975) (owner: 10Ejegg) [01:50:54] thanks wfan [01:51:53] np, thanks for this example haha :) [01:52:21] (03Merged) 10jenkins-bot: Adyen: ensure external script loads first [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881050 (https://phabricator.wikimedia.org/T326975) (owner: 10Ejegg) [02:02:22] grr, ingenico says their new cardholder name fields are actually ready this time but I sure can't make them show up on preprod [02:37:45] cstone: were you able to get a visa-debit test card through ingenico to test that 'payment product 114 not found' thing? [02:37:54] I couldn't find a test case with that product ID [02:38:58] Hmmm I I think I was getting another error with it but maybe I told you verbally and never actually wrote it on the patch [02:39:57] And then must have gotten distracted with something else hmm what was I even trying to test when I found that [02:40:28] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Review CiviCRM indexes in order to reduce disk space & improve performance - https://phabricator.wikimedia.org/T126388 (10Eileenmcnaughton) I'm dragging this back to triage as I've been looking at the activity indexes in the context of the upgrade & thin... [02:40:31] heh, there was this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/879138 [02:44:22] oh yep, now it's The payment submethod [visa-debit] was not found. [02:44:24] (03PS1) 10Eileen: Do not pass go, do not add this new index [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881493 (https://phabricator.wikimedia.org/T326272) [02:44:42] guess I found one! [02:48:17] ok, for now I can just add that extra dummy entry too I guess [02:56:06] cstone was there even a phab for that? [02:56:29] I don't think so [02:56:45] oh hey I have this one: https://phabricator.wikimedia.org/T308088 [02:57:20] haha i had even written a patch last may and totally forgotten about it [02:58:45] oh wow and there was this additional wrinkle - https://phabricator.wikimedia.org/T316796 [02:58:52] jeez, my amnesia is getting bad [03:05:17] (03PS2) 10Ejegg: Use ReferenceData to unstage Ingenico submethod [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879138 [03:07:49] ugh, ok, that patch has the same issue [03:07:53] well, i'm tired [03:08:09] gonna call it a night, and try deploying the donationinterface stuff tomorrow morning [03:09:50] (03PS2) 10Wfan: Preload third party script for google and dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881013 (https://phabricator.wikimedia.org/T326975) [03:11:38] (03CR) 10CI reject: [V: 04-1] Preload third party script for google and dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881013 (https://phabricator.wikimedia.org/T326975) (owner: 10Wfan) [03:14:09] (03PS3) 10Wfan: Preload third party script for google and dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881013 (https://phabricator.wikimedia.org/T326975) [10:34:00] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881527 (owner: 10L10n-bot) [12:04:48] (03CR) 10Raimond Spekking: [C: 03+2] "false positive" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881527 (owner: 10L10n-bot) [13:36:28] 10Fundraising-Backlog, 10FR-Docker: fundraising-dev: start tagging releases - https://phabricator.wikimedia.org/T327400 (10jgleeson) [13:58:13] (03PS1) 10Jgleeson: Remove '-O' flag on scp command [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/881627 [13:59:35] 10Fundraising-Backlog, 10FR-Docker: fundraising-dev: decouple application config '/config' from main docker stack project - https://phabricator.wikimedia.org/T327401 (10jgleeson) [14:47:18] (03PS21) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [14:47:46] (03CR) 10CI reject: [V: 04-1] Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [14:49:00] (03PS22) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [14:49:25] (03CR) 10CI reject: [V: 04-1] Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [14:56:15] (03PS23) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [16:03:05] (03PS24) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [16:03:31] (03CR) 10CI reject: [V: 04-1] Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [16:03:39] (03PS25) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [16:05:18] (03PS26) 10Damilare Adedoyin: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) [16:13:32] (03CR) 10Jgleeson: [C: 03+2] "AWESOMENESS! Thanks for all the work on this. Let's get it out there!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [16:14:29] (03Merged) 10jenkins-bot: Implement createPayment for DLocal CC / SmartFields in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/878135 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [16:14:44] thanks jgleeson for the cr [16:15:02] np! thanks for all the work on that. I just moved the ticket into Pending Deployment :) [16:16:26] cool [16:48:19] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, and 6 others: Creating New Matching Gift Import - https://phabricator.wikimedia.org/T303986 (10MDemosWMF) @Eileenmcnaughton Sure! I can put... [17:24:18] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, and 2 others: Make sure gateway script fully loaded first for Dlocal, Adyen Checkout and Amazon - https://phabricator.wikimedia.org/T326975 (10AnnWF) [17:27:12] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog: Source Code project planning and scoping - https://phabricator.wikimedia.org/T327425 (10XenoRyet) [17:31:33] (03CR) 10AndyRussG: "Thanks for this!!! Works great! See inline for some brief notes... The only other idea so far is to perhaps find a place in the code to ad" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879658 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [17:41:13] (03PS1) 10Ejegg: Only use scp -O on newer scp [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/881676 [17:41:36] fr-tech ^^^ should let the scp command work on both old and new setups [17:57:57] cstone: fr-tech if you get ssh errors when updating fr-tech (to pull in donut) try adding in that patch ^ [17:58:42] yep haha ran into it [17:59:08] which patch [17:59:25] above from ejegg:https://gerrit.wikimedia.org/r/881676 [17:59:39] did y'all see the one I wrote earlier? [17:59:45] lemme check that one out [18:00:15] jgleeson: from what I understood from ejegg is that depending on the scp version you have, sometimes you need the flag, and sometimes you don't? [18:00:31] I was just wondering if you saw it [18:01:52] jgleeson: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/881627/ ? yes I saw it, thx for that... apologies, I guess from what I understood the flag is indeed needed on some platforms [18:04:06] jgleeson btw also apologies if my initial reaction to your suggestion of making a separate submodule repo for config was too negative!!! definitely we can look into moving that around if it seems helpful [18:04:16] yeah although I'm curious why the other commands without the -O flag work for ejegg ? [18:04:44] are we doing something new in the "new" donut calls for getting the githook stuff? [18:04:45] they probably didn't on his current version of stuff, but he just hadn't had to reclone since he'd updated his system maybe? [18:05:09] so does that mean they are broke on them all for ejegg ? [18:05:44] as regards config, another idea that I had was a unified config generator to bring mange in a single tool our config for prod, staging and local setup [18:05:57] ejegg: are you about? [18:06:04] some kind of template-y thing so we can easily see what's the same everywhere and what has to change in specific places [18:07:44] looking for a phab that I might have created on that one but it seems there isn't one [18:09:43] (though also I think moving local docker config to a submodule wouldn't depend on whether or not we get to revamping our entire config process... just mentioning it in case it's relevant for discussion, since it seems perhaps vaguely related) [18:10:39] I feel decouping the application-config from stack is low hanging fruit. I'm envisaging a flow where we update the config more often than the docker stuff, which I think is how we work today. This would allow $wgDLocalEnabled=true style changes to get pulled in and leave updates on the docker-stack separate [18:11:08] although it's probably a good idea to be on the latest docker-stack, it's not always required [18:11:49] we could merge the configs like ejegg suggested or we could create a new repo / submodule [18:12:02] it's true they are different areas, in terms of separations of concern [18:13:03] and doing that would probably make it easier to run an automatic templatey config generator in the future [18:14:29] I'd need to see more of what's in your head to understand the config generator stuff [18:14:36] it sounds good though [18:16:51] ejegg: thanks for the patch. I'm wondering if there's a way to indicate version support other than grepping the manual [18:17:18] could we possibly detect it by ssh -V or the exit code of a scp command with -O? [18:18:05] jgleeson oki! if it's helpful I could make a general discussion task to have a place to write up the config generator idea and the submodule idea and also have a place to write down the reflections, and find them later? does that make sense? [18:18:40] we've got a task for submodule one ttps://phabricator.wikimedia.org/T327401 [18:18:47] https://phabricator.wikimedia.org/T327401 [18:18:49] (agreed about grepping the manual, though in fairness it deserves points for originality!) [18:19:01] ha [18:19:06] yeah pretty neat hack [18:19:31] wrt config-genrator ticket. feels like a good one to also try out on tech-talk [18:19:37] jgleeson: ah fantastic thanks! many apologies if you'd linked or mentioned the task before and I missed it [18:19:37] alongside discussion ticket [18:20:11] I could make a separate one for the config generator and then link the two tasks via a mention? [18:20:12] we could look at our configs and think of any ways to improve and then explore how to automate [18:20:14] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Dedupe query under certain rules no longer generating queries - https://phabricator.wikimedia.org/T326605 (10XenoRyet) p:05Triage→03High [18:20:20] sounds good AndyRussG ! [18:20:34] jgleeson: cool beans jgleeson thx much! will do :) [18:21:43] (03CR) 10Jgleeson: "Thanks for the patch. I'm wondering if there's a way to indicate version support other than grepping the manual. Could we possibly detect " [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/881676 (owner: 10Ejegg) [18:24:55] (03Abandoned) 10Jgleeson: Remove '-O' flag on scp command [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/881627 (owner: 10Jgleeson) [18:31:22] (03CR) 10Ejegg: Only use scp -O on newer scp (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/881676 (owner: 10Ejegg) [18:32:47] (03CR) 10Jgleeson: Only use scp -O on newer scp (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/881676 (owner: 10Ejegg) [18:35:33] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Implement 3DSecure for DLocal cards - https://phabricator.wikimedia.org/T324302 (10jgleeson) This is needed for India, according to the docs https://docs.dlocal.com/docs/3d-secure#redirect-3d-secure [18:40:57] 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: We calculate a bad DLocal signature when email contains '+' - https://phabricator.wikimedia.org/T264030 (10jgleeson) I think this is a bug with the current streamline integration? Maybe we should also confirm it's not a problem wit... [18:46:03] (03CR) 10Cstone: Only use scp -O on newer scp (031 comment) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/881676 (owner: 10Ejegg) [19:01:23] (03PS1) 10Jgleeson: WIP: Implement approvePayment for DLocal in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/881700 (https://phabricator.wikimedia.org/T324281) [19:03:28] (03PS2) 10Ejegg: Only use scp -O on SSH 9.x [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/881676 [19:06:55] gah, ssh -V doesn't seem to output to stdout? [19:07:10] ssh -V | grep -o OpenSSH_[0-9] [19:07:10] OpenSSH_9.1p1 Debian-1, OpenSSL 3.0.7 1 Nov 2022 [19:07:25] that grep -o should only output the matching parts, right? [19:08:26] jgleeson: do we not have the 'man' command on all the environments that would be using fundraising-dev? [19:10:34] I'm just flailing a bit trying to parse out the version from ssh -V [19:11:02] ejegg: try `ssh -V 2>&1 | grep -o OpenSSH_[0-9]` [19:11:29] ah yep, that does it, thanks [19:15:14] (03PS3) 10Ejegg: Only use scp -O on SSH versions 9 and up [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/881676 [19:15:25] ok jgleeson ^^^ should do it [19:18:19] sorry ejegg [19:18:23] my grep nerd hat is on [19:18:40] you can use \K for the capture group in grep [19:18:58] try `ssh -V 2>&1 | grep -oP 'OpenSSH_\K[0-9]'` [19:19:06] saves the additional call to sed [19:19:27] jgleeson: want to make that change? [19:19:53] I'm just about to send my end of day, I'm an hour over my 8 [19:19:58] but I can +2 without [19:20:01] k [19:20:02] it's not important [19:20:46] (03PS1) 10Ejegg: Log and preserve QS on redirect to donatewiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881704 [19:20:53] wfan does that look OK? ^^^ [19:21:24] I was hesitant to deploy the original GatewayChooser redirect patch without it logging when it does the redirect [19:21:58] then I realized we probably want to maintain the utm_ variables etc [19:22:04] Yeah, looks fine [19:22:12] and thanks for the extra log [19:22:18] cool cool! [19:22:44] (03CR) 10CI reject: [V: 04-1] Log and preserve QS on redirect to donatewiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881704 (owner: 10Ejegg) [19:23:01] (03CR) 10Jgleeson: [C: 03+2] "Thanks for this!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/881676 (owner: 10Ejegg) [19:24:41] thanks jgleeson! [19:24:51] lemme see what's up with that V-1 wfan [19:26:11] sure, seems like unit test failed, and once it passed the validation, will run the test and +2 :) thanks ejegg~ [19:28:00] (03CR) 10Jgleeson: [V: 03+2 C: 03+2] Only use scp -O on SSH versions 9 and up [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/881676 (owner: 10Ejegg) [19:29:48] (03PS2) 10Ejegg: Log and preserve QS on redirect to donatewiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881704 [19:31:26] 10Wikimedia-Fundraising-Banners, 10Wikipedia-Android-App-Backlog (Android Release FY2022-23): Updated message for 2022 English fundraising in Android app - https://phabricator.wikimedia.org/T325691 (10Sharvaniharan) 05Open→03Resolved [19:31:32] (03CR) 10CI reject: [V: 04-1] Log and preserve QS on redirect to donatewiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881704 (owner: 10Ejegg) [19:31:53] Also, ejegg: could we add T324706 to commit for that extra logging and param pr? Thanks [19:31:54] T324706: Handle the GatewayChooser error handling nicer - https://phabricator.wikimedia.org/T324706 [19:32:59] will do [19:34:51] (03PS3) 10Ejegg: Log and preserve QS on redirect to donatewiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881704 (https://phabricator.wikimedia.org/T324706) [19:35:02] hah, oops, writing code against REL1_39 [19:36:10] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, and 2 others: Make sure gateway script fully loaded first for Dlocal, Adyen Checkout and Google - https://phabricator.wikimedia.org/T326975 (10AnnWF) [19:43:12] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Add extra field for some countries if create payment with dlocal smartfield - https://phabricator.wikimedia.org/T326976 (10XenoRyet) [19:44:27] that's passing wfan [19:44:55] but I wonder if it should be failing - we're not checking for the extra parameters at the end of the location header [19:45:12] I can only assume that it's the QueryVarsOnly interacting wiht the FauxRequest [19:49:09] ahh yeah, FauxRequest doesn't override that function [19:49:24] so it uses the real WebReuqest one which ofcourse doesn't have the fake params [19:49:27] huh [19:50:30] Hmm, noticed another thing that we have the param currency pass to donate wiki, https://localhost:9001/index.php/Special:GatewayChooser?currency=NOK, but we still show the currency USD. [19:51:30] looks like donate wiki get the default currency based on geoip country [19:51:35] ahh ok [19:51:45] is that expected? or we should log a bug [19:53:26] hmm, maybe? [19:53:35] shoot, I have another meeting soon [19:54:13] ok, I think we don't need the 'Only' version of that function. That way we can make the tests cover the QS preservation too [19:57:13] (03PS4) 10Ejegg: Log and preserve QS on redirect to donatewiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881704 (https://phabricator.wikimedia.org/T324706) [19:58:51] (03CR) 10Wfan: [C: 03+2] "Tested see the extra log and the see the param pass to donate wiki, looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881704 (https://phabricator.wikimedia.org/T324706) (owner: 10Ejegg) [20:00:30] Ah just noticed that only thing [20:01:22] thank you for the CR! [21:16:04] 10Fundraising Sprint Quarkery, 10Fundraising-Backlog, 10Epic: Upgrading payments-wiki from buster to bullseye - https://phabricator.wikimedia.org/T315585 (10Dwisehaupt) [21:16:53] 10Fundraising Sprint Quarkery, 10Fundraising-Backlog, 10Epic: Upgrading payments-wiki from buster to bullseye - https://phabricator.wikimedia.org/T315585 (10Dwisehaupt) All payments hosts now running bullseye. Closing this task. [21:17:38] 10fundraising-tech-ops: reimage fundraising payments role servers to Bullseye - https://phabricator.wikimedia.org/T315599 (10Dwisehaupt) [21:17:55] 10fundraising-tech-ops: reimage fundraising payments role servers to Bullseye - https://phabricator.wikimedia.org/T315599 (10Dwisehaupt) All payments hosts are now running bullseye and are in service. [21:18:17] 10Fundraising Sprint Quarkery, 10Fundraising-Backlog, 10Epic: Upgrading payments-wiki from buster to bullseye - https://phabricator.wikimedia.org/T315585 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt [21:18:41] 10fundraising-tech-ops: reimage fundraising payments role servers to Bullseye - https://phabricator.wikimedia.org/T315599 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt [21:18:45] 10fundraising-tech-ops: Fundraising environment support for Debian 11 (Bullseye) - https://phabricator.wikimedia.org/T277184 (10Dwisehaupt) [21:20:08] woohoo, thanks for the payments upgrade dwisehaupt ! [21:21:17] weird wfan it looks like gerrit forgot your C+2 on that patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/881704/ [21:21:41] (03CR) 10Wfan: [C: 03+2] Log and preserve QS on redirect to donatewiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881704 (https://phabricator.wikimedia.org/T324706) (owner: 10Ejegg) [21:21:46] thanks! [21:21:49] did again~ [21:21:50] np [21:27:07] (03CR) 10Ejegg: "Thanks for the CR! I'll move that language hook-like thing." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879658 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [21:37:23] (03Merged) 10jenkins-bot: Log and preserve QS on redirect to donatewiki [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881704 (https://phabricator.wikimedia.org/T324706) (owner: 10Ejegg) [21:41:17] (03PS7) 10Ejegg: First variant for Japan tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879658 (https://phabricator.wikimedia.org/T322793) [21:41:19] (03PS6) 10Ejegg: Japan form variant #2 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879689 (https://phabricator.wikimedia.org/T322793) [21:42:11] ok AndyRussG I moved that language hook so even arabic can be overridden, using the $.extend function so you could just specify certain ones [21:43:12] (03PS2) 10Ejegg: Tone down the LockError exception message. [wikimedia/fundraising/process-control] - 10https://gerrit.wikimedia.org/r/880965 (https://phabricator.wikimedia.org/T327174) (owner: 10Jgleeson) [21:43:20] (03CR) 10Ejegg: [C: 03+2] Tone down the LockError exception message. [wikimedia/fundraising/process-control] - 10https://gerrit.wikimedia.org/r/880965 (https://phabricator.wikimedia.org/T327174) (owner: 10Jgleeson) [21:43:51] (03Merged) 10jenkins-bot: Tone down the LockError exception message. [wikimedia/fundraising/process-control] - 10https://gerrit.wikimedia.org/r/880965 (https://phabricator.wikimedia.org/T327174) (owner: 10Jgleeson) [21:56:31] ejegg: ah cool beans, thx! [22:05:06] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, and 2 others: Figure out storage implications of varchar vs text in possible logging solution - https://phabricator.wikimedia.org/T325789 (10Jgreen) I'm collecting res... [22:23:25] fr-tech has anyone else been testing the DLocal smartfields in FireFox? [22:23:41] I get all sorts of JS errors trying to type in any of the fields [22:23:49] in the DLocal script, not in our own [22:23:49] (03PS1) 10Damilare Adedoyin: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [22:24:08] mostly TypeError: n.path is undefined [22:25:03] (03CR) 10CI reject: [V: 04-1] Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [22:31:18] they're spamming the heck out of console.log too [22:33:22] hmmm [22:44:33] (03PS1) 10Ejegg: Tweak Dlocal HTML to align expiry and CVV [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881721 [22:47:40] (03CR) 10Wfan: [C: 03+2] "LGTM" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881721 (owner: 10Ejegg) [22:49:26] (03Merged) 10jenkins-bot: Tweak Dlocal HTML to align expiry and CVV [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881721 (owner: 10Ejegg) [22:56:40] 10fundraising-tech-ops: reimage fundraising queue role servers to Bullseye - https://phabricator.wikimedia.org/T327453 (10Dwisehaupt) [22:57:48] (03PS2) 10Ejegg: Change Croatia currency to EUR [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/830927 (https://phabricator.wikimedia.org/T327207) [23:00:22] ejegg: I just download the firefox, and also see "Uncaught TypeError: n.path is undefined [23:00:22] click https://static-sandbox.dlocal.com/js/collector/bundle.js:1" [23:00:54] and checked safari, works fine~ [23:01:48] hmm anyone that rebuilt recently did you see cat: 'src/smashpig/Schema/mysql/00[127]*.sql': No such file or directory [23:01:59] i didnt expect that part to break [23:02:27] I rebuild 3 days ago and no error at that time~ [23:02:47] let me check if I have this sql file [23:03:25] 001_CreatePendingTable.sql [23:03:25] 002_CreateDamagedTable.sql [23:03:25] 003_CreatePaymentsInitialTable.sql [23:03:25] 005_CreatePaymentsFraudTable.sql [23:03:25] 006_CreatePaymentsFraudBreakdownTable.sql [23:03:25] 007_AddPaymentMethodToPendingTable.sql those are all sql I have under smashpig schema [23:03:56] oh its me theres nothing in my smashpig folder [23:03:57] haha [23:04:01] hmmm [23:04:40] maybe pull a new smashpig~ [23:05:02] yeah ill have to but how did it get emptied in the first place [23:09:23] oh dang cstone someone nabbed your pig! [23:09:58] thanks for that HTML review wfan ! [23:11:57] haha, should we email squintero@dlocal.com for that firefox n.path is undefine error? [23:14:10] just did! [23:14:46] Wow cool, thanks [23:16:01] It was getting in the way of testing damilare|away's patch to handle errors [23:19:08] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10Patch-For-Review: Move Croatia to Adyen as default - https://phabricator.wikimedia.org/T327207 (10EMartin) And move Croatia to Adyen! [23:19:20] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/881723 [23:19:33] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/881723 (owner: 10Ejegg) [23:20:12] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/881723 (owner: 10Ejegg) [23:25:32] (03PS1) 10Ejegg: Swap Croatia (HR) to Adyen and EUR [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881725 [23:26:56] (03PS9) 10Ejegg: Use new apache2 image for email-pref-ctr [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/877281 [23:26:58] (03PS3) 10Ejegg: Update SmashPig service to use bullseye apache2 image [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/879134 [23:27:13] (03CR) 10CI reject: [V: 04-1] Swap Croatia (HR) to Adyen and EUR [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881725 (owner: 10Ejegg) [23:30:09] (03PS2) 10Ejegg: Swap Croatia (HR) to Adyen and EUR [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881725 [23:31:35] hmm, why is that test failing? [23:31:54] (03CR) 10CI reject: [V: 04-1] Swap Croatia (HR) to Adyen and EUR [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881725 (owner: 10Ejegg) [23:32:28] oh I probably need to list it in countries.yaml [23:33:22] (03PS3) 10Ejegg: Swap Croatia (HR) to Adyen and EUR [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881725 [23:52:18] (03CR) 10Ejegg: "Some whitespace inconsistencies, and I don't see the error message spans rendering when I look at the page or the HTML. I noticed the Smar" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880528 (https://phabricator.wikimedia.org/T324272) (owner: 10Damilare Adedoyin) [23:55:26] (03CR) 10Wfan: [C: 03+2] "Tested with https://localhost:9001/index.php?title=Special:IngenicoGateway&appeal=JimmyQuote&amount=10&country=HR&payment_method=cc&recurr" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/830927 (https://phabricator.wikimedia.org/T327207) (owner: 10Ejegg) [23:55:28] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/881726 [23:55:32] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/881726 (owner: 10Ejegg) [23:55:58] (03Merged) 10jenkins-bot: Change Croatia currency to EUR [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/830927 (https://phabricator.wikimedia.org/T327207) (owner: 10Ejegg) [23:56:15] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/881727 [23:56:18] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/881727 (owner: 10Ejegg) [23:56:44] (03CR) 10CI reject: [V: 04-1] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/881727 (owner: 10Ejegg) [23:57:51] (03PS2) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/881727 [23:57:53] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/881727 (owner: 10Ejegg)