[02:26:50] (03CR) 10Ladsgroup: [C: 03+2] Avoid deprecated override for IndexPager::makeLink [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/875451 (https://phabricator.wikimedia.org/T317916) (owner: 10Bartosz Dziewoński) [02:28:50] (03Merged) 10jenkins-bot: Avoid deprecated override for IndexPager::makeLink [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/875451 (https://phabricator.wikimedia.org/T317916) (owner: 10Bartosz Dziewoński) [05:34:03] 10Fundraising-Backlog: New custom fields on a contribution- matching Gift related - https://phabricator.wikimedia.org/T327614 (10NNichols) [06:51:12] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/882299 (owner: 10L10n-bot) [08:37:44] (03CR) 10AndyRussG: [C: 04-1] "Heyy! Thanks again for this! Digging in a bit more here. I think I'd like to see use use a better, more repeatable mechanism for determini" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879658 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [08:39:38] (03CR) 10AndyRussG: [C: 04-1] "See message on previous patch in chain: let's figure out a better way to do the execution order. I feel it can't be that complicated. Apol" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879689 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [12:23:55] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_35) - 10https://gerrit.wikimedia.org/r/882299 (owner: 10L10n-bot) [13:16:19] 10Fundraising Tech - Chaos Crew: Investigate timeouts from Adyen Soap listener - https://phabricator.wikimedia.org/T317422 (10jgleeson) We've had eleven of these this month already, so it doesn't seem to be going away. Maybe it's time to reach out to Adyen and see if they're aware of anything at their end? [15:02:35] (03CR) 10Ejegg: "Thanks for the CR. Any suggestions for the execution order mechanism?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879658 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [15:08:28] (03CR) 10Ejegg: "I've been trying to think of other mechanisms and so far nothing occurs to me. Since this is a variant, it's more an experiment and not a " [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879689 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [15:16:43] (03PS7) 10Damilare Adedoyin: WIP: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [15:18:53] (03CR) 10CI reject: [V: 04-1] WIP: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [15:22:06] (03CR) 10Ejegg: "Thanks for the CR! I was thinking I would rename the image when we're ready to switch the civicrm container over to bullseye as well, so w" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/879134 (owner: 10Ejegg) [15:22:40] (03CR) 10Ejegg: "I'll try to do that right after I get something up for the Ingenico cardholder name change" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/879134 (owner: 10Ejegg) [15:31:54] (03PS1) 10Ejegg: Stop sending name fields to Ingenico [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882665 (https://phabricator.wikimedia.org/T312877) [15:32:17] (03CR) 10CI reject: [V: 04-1] Stop sending name fields to Ingenico [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882665 (https://phabricator.wikimedia.org/T312877) (owner: 10Ejegg) [15:32:51] oh wait, that might not even be needed, let's just add a test for the empty name case [15:34:27] oh hey, there already is a test with no names. Cool, can abandon that [15:34:44] (03Abandoned) 10Ejegg: Stop sending name fields to Ingenico [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882665 (https://phabricator.wikimedia.org/T312877) (owner: 10Ejegg) [15:42:24] hey ejegg [15:42:35] I saw your comment re:renaming image [15:43:48] do you mean the civicrm image will also use the same base image as the smashpig image? [15:48:26] (03PS1) 10Jgleeson: Remove redundant dLocal PaymentProvider instantiation test [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882673 [15:48:36] (03PS1) 10Ejegg: Add full name to Ingenico hosted status response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882674 (https://phabricator.wikimedia.org/T312877) [15:48:55] (03CR) 10CI reject: [V: 04-1] Remove redundant dLocal PaymentProvider instantiation test [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882673 (owner: 10Jgleeson) [15:49:04] (03CR) 10CI reject: [V: 04-1] Add full name to Ingenico hosted status response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882674 (https://phabricator.wikimedia.org/T312877) (owner: 10Ejegg) [15:49:46] I'll fix that when I get back [15:50:51] PROBLEM - Host civi2001 is DOWN: PING CRITICAL - Packet loss = 100% [15:56:38] jgleeson|skrun2: yep, we should be able to use a single apache2 image for the wikis, smashpig, and civicrm [15:58:12] now that the site configuration is moved to the host [16:00:02] 10fundraising-tech-ops, 10FR-Tech-Analytics: Upgrade Fundraising Superset to 1.5.3 - https://phabricator.wikimedia.org/T311540 (10Jgreen) [16:02:09] RECOVERY - Host civi2001 is UP: PING OK - Packet loss = 0%, RTA = 30.22 ms [16:06:25] 10Fundraising Tech - Chaos Crew, 10Patch-For-Review: Name changes required for Ingenico 3DS2.0 - https://phabricator.wikimedia.org/T312877 (10Ejegg) Note: we will need to update the pending transaction resolver to be able to match based on the parsed full_name rather than the separate first_name and last_name... [16:17:51] ah cool. sounds good ejegg [16:17:58] 10Fundraising Tech - Chaos Crew, 10Patch-For-Review: Name changes required for Ingenico 3DS2.0 - https://phabricator.wikimedia.org/T312877 (10Ejegg) It looks like we have to send Minfraud separate first_name and last_name fields to get any scores related to names - checking to see if there's any way to send th... [16:22:48] (03PS2) 10Ejegg: Add full name to Ingenico hosted status response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882674 (https://phabricator.wikimedia.org/T312877) [16:25:01] (03PS2) 10Jgleeson: Remove redundant dLocal PaymentProvider instantiation test [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882673 [16:25:22] 10fundraising-tech-ops, 10Infrastructure-Foundations, 10SRE, 10netops: Upgrade fasw to Junos 21 - https://phabricator.wikimedia.org/T316542 (10Papaul) [16:26:36] 10Wikimedia-Fundraising: Untranslated Credit Card fields (GlobalCollect iframes) - https://phabricator.wikimedia.org/T109064 (10Ejegg) 05Open→03Declined [16:27:35] 10Fundraising-Backlog, 10FR-Ingenico, 10MediaWiki-extensions-DonationInterface: DonationInterface: Remove old GlobalCollect classes, config and directory, integrating currently used functionality into Ingenico gateway - https://phabricator.wikimedia.org/T291798 (10Ejegg) [16:27:46] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Technical-Debt: Delete Globalcollect adapter, fold still-used code into Ingenico adapter - https://phabricator.wikimedia.org/T260725 (10Ejegg) [16:27:59] (03PS1) 10Ejegg: Ingenico: get name from iframe, not our field [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/882684 (https://phabricator.wikimedia.org/T312877) [16:29:50] (03CR) 10CI reject: [V: 04-1] Ingenico: get name from iframe, not our field [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/882684 (https://phabricator.wikimedia.org/T312877) (owner: 10Ejegg) [16:30:51] (03CR) 10AndyRussG: [C: 04-1] Japan form variant #2 (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879689 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [16:31:40] (03CR) 10AndyRussG: [C: 04-1] First variant for Japan tests (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879658 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [16:32:26] (03CR) 10Ejegg: "We stil need adyen.js to work with no variant, so we don't want to add any variant-specific calls to the main script." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879689 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [16:32:30] hiii fr-tech :) [16:32:41] hi AndyRussG ! Thanks for all the scrutiny [16:33:16] ejegg same! thanks for the quick turnaround :)( I'll reply on the change) [16:43:00] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: GatewayChooser: No supported gateway for parameters - https://phabricator.wikimedia.org/T326666 (10AnnWF) @Pcoombe Hi, peter, for this ticket, since it's related with the DonationForm.js, it needs some help from you 1: Seems like we... [16:43:41] fr-tech I'm tempted to pull in T260725 as a pre-requisite of the Ingenico name field [16:43:41] T260725: Delete Globalcollect adapter, fold still-used code into Ingenico adapter - https://phabricator.wikimedia.org/T260725 [16:44:14] that would be nice to get in [16:44:27] I mean, we can DO it without that, but it's cleaner if we start using the actual SmashPig response properties [16:44:42] +1 [16:44:51] (03CR) 10AndyRussG: [C: 04-1] Japan form variant #2 (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879689 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [16:44:56] ejegg: I am still worried about dlocal :S [16:44:58] hehe, it might be big, but this is our chance for big changes [16:45:11] so not sure if that would distract away from that much [16:45:39] yeah, we might need to settle for the quick way [16:46:28] maybe estimate it roughly and we could talk about it in mid sprint? if it can be done quick it might make sense because it does sound like a real nice to have [16:47:09] AndyRussG: want to jump on a call? [16:47:16] I think we've got about 2 and 1/2 sprints to move all the tickets from Internal & One-Hour over to done https://phabricator.wikimedia.org/tag/fr-dlocal/ [16:47:30] AndyRussG: backlog link? https://meet.google.com/mkm-dptq-dqq [16:50:29] (03PS2) 10Wfan: If no supported gateway, show donate wiki instead of error page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880519 (https://phabricator.wikimedia.org/T326666) [16:52:10] (03CR) 10CI reject: [V: 04-1] If no supported gateway, show donate wiki instead of error page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880519 (https://phabricator.wikimedia.org/T326666) (owner: 10Wfan) [16:53:42] ejegg: heyyyy sorry just saw your ping... ready in 5, is that okok? [16:53:47] sure thing [16:53:54] thx! [17:00:24] (03PS3) 10Wfan: If no supported gateway, show donate wiki instead of error page [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880519 (https://phabricator.wikimedia.org/T326666) [17:00:34] I'm trying the latest suggestion, and it feels like we need to reinvent a bunch of dependency logic [17:00:52] fr-tech, today's music recommendation is some Middle Earth Music https://www.youtube.com/watch?v=CahOLfYxiq0 It's mostly chilled but every now and again the inner FOR FRODO!!!!!!!!! bubbles up [17:01:34] heh, i started my day with Dragonforce [17:01:48] not at all chill, but could be construed as tolkein-y [17:02:34] * jgleeson is googling Dragonforce :) [17:02:51] have a good time jgleeson haha [17:03:35] just makes me think of what the original guitar hero? [17:03:35] herman li streams on twitch pretty regularly. taking requests and just jamming. [17:03:41] hehe yep cstone [17:03:59] i think they had a song on Rock Band too [17:04:08] I remember that being one of the toughest on drums [17:04:43] my college roommate corrupted my guitar hero save file and i dont think I played since haha then we moved onto rock band [17:04:55] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Bug: duplicate Adyen transactions in short sequence - https://phabricator.wikimedia.org/T324860 (10AnnWF) [17:04:57] oh nooooo [17:05:35] i still have that ps2 i wonder if it will even turn on haha [17:05:40] i need to clear out some space in the basement and requisition my Wii back from the ex-roomie that's been babysitting it for the last 6 years [17:05:48] I'm really jonesing for some rock band [17:06:16] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Bug: duplicate Adyen transactions in short sequence - https://phabricator.wikimedia.org/T324860 (10AnnWF) 05duplicate→03Open [17:07:28] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Bug: duplicate Adyen transactions in short sequence - https://phabricator.wikimedia.org/T324860 (10AnnWF) a:03AnnWF [17:07:54] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Bug: duplicate Adyen transactions in short sequence - https://phabricator.wikimedia.org/T324860 (10AnnWF) [17:17:45] It was so nice to have a basement, but basements are scarce in SC maybe due to earthquakes [17:31:00] (03PS8) 10Ejegg: First variant for Japan tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879658 (https://phabricator.wikimedia.org/T322793) [17:31:02] (03PS7) 10Ejegg: Japan form variant #2 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879689 (https://phabricator.wikimedia.org/T322793) [17:31:05] (03PS1) 10Ejegg: WIP try loading adyen variants with mw.loader.using [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/882694 (https://phabricator.wikimedia.org/T322793) [17:31:14] oh hmmm maybe that's why they're scarce here too [17:32:09] ejegg: ohh there's already a task that even explains the issue: T293287 [17:32:10] T293287: Rewrite DonationInterface forms and validation JS - https://phabricator.wikimedia.org/T293287 [17:32:55] (03CR) 10CI reject: [V: 04-1] WIP try loading adyen variants with mw.loader.using [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/882694 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [17:33:26] if you agree, I feel linking in would be good? [17:33:40] *linking that one in [17:34:19] (i.e., that task would be sufficient Phab-side explanation) [17:38:46] (03PS9) 10Ejegg: First variant for Japan tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879658 (https://phabricator.wikimedia.org/T322793) [17:38:48] (03PS8) 10Ejegg: Japan form variant #2 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879689 (https://phabricator.wikimedia.org/T322793) [17:39:06] ok AndyRussG, there are the extra comments ^^^ [17:40:04] sure, we can link that task as an example use case [17:41:11] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Handle IPNs from DLocal payins - https://phabricator.wikimedia.org/T324293 (10Cstone) a:03Cstone [17:41:51] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Technical-Debt: Rewrite DonationInterface forms and validation JS - https://phabricator.wikimedia.org/T293287 (10Ejegg) [17:44:34] ok, so even the quick solution to the cardholder name field is going to require changes to the minfraud filter and the pending transaction resolver [17:45:02] I should get a test on the other pending transaction resolver patch so it's ready to review, then do the neme fix on top of it [17:46:58] 10Fundraising-Backlog, 10MediaWiki-extensions-Translate, 10Language-Team (Language-2023-January-March), 10MW-1.40-notes (1.40.0-wmf.20; 2023-01-23), and 2 others: Move classes in the Translate root directory to namespace - https://phabricator.wikimedia.org/T313242 (10AndyRussG) [17:48:19] oh hey, but the resolver patch for ingenico should also help make the resolver ready for PayPal! [17:51:13] (03PS8) 10Damilare Adedoyin: WIP: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [17:53:04] (03CR) 10CI reject: [V: 04-1] WIP: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [17:55:38] (03PS9) 10Damilare Adedoyin: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [17:57:39] (03CR) 10CI reject: [V: 04-1] Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [17:58:57] (03PS10) 10Damilare Adedoyin: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [18:00:46] (03CR) 10CI reject: [V: 04-1] Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [18:14:58] (03CR) 10AndyRussG: [C: 04-1] "Hi! Thanks so much for this, and for finding where the issue is happening!" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/881385 (https://phabricator.wikimedia.org/T318103) (owner: 10Wfan) [18:24:45] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10JavaScript, and 2 others: flaky qunit test in CentralNotice: Uncaught TypeError: Cannot read property 'timeRemaining' of undefined - https://phabricator.wikimedia.org/T318103 (10AndyRussG) Hmmm maybe we're not m... [18:34:04] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog: Adyen form requested for Czech Republic for Q3 testing - https://phabricator.wikimedia.org/T323715 (10XenoRyet) [18:37:14] (03PS11) 10Damilare Adedoyin: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [18:38:26] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig - https://phabricator.wikimedia.org/T324289 (10Damilare) a:03Damilare [18:39:18] (03CR) 10CI reject: [V: 04-1] Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [19:15:59] (03CR) 10AndyRussG: [C: 03+2] "Thanks for this, for the updates, and for digging in to possible ways to do this!!! :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879658 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [19:17:20] (03CR) 10AndyRussG: [C: 03+2] "Thanks for this, for the updates, and for all the discussion!!! :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879689 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [19:17:46] (03Merged) 10jenkins-bot: First variant for Japan tests [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879658 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [19:19:25] (03Merged) 10jenkins-bot: Japan form variant #2 [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879689 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [20:02:11] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sguseman - https://phabricator.wikimedia.org/T327694 (10Dwisehaupt) [20:02:44] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for dadedoyin - https://phabricator.wikimedia.org/T327695 (10Dwisehaupt) [20:03:21] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for spatton - https://phabricator.wikimedia.org/T327696 (10Dwisehaupt) [20:04:10] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for asarabadani - https://phabricator.wikimedia.org/T327697 (10Dwisehaupt) [20:04:51] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for lwadleigh - https://phabricator.wikimedia.org/T327698 (10Dwisehaupt) [20:05:33] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ehughes - https://phabricator.wikimedia.org/T327699 (10Dwisehaupt) [20:06:01] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for shust - https://phabricator.wikimedia.org/T327700 (10Dwisehaupt) [20:06:32] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ebrill - https://phabricator.wikimedia.org/T327701 (10Dwisehaupt) [20:07:05] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sinaba - https://phabricator.wikimedia.org/T327702 (10Dwisehaupt) [20:07:49] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for dbu - https://phabricator.wikimedia.org/T327703 (10Dwisehaupt) [20:34:34] 10fundraising-tech-ops, 10FR-Tech-Analytics: Upgrade Fundraising Superset to 1.5.3 - https://phabricator.wikimedia.org/T311540 (10Jgreen) [20:36:51] 10fundraising-tech-ops, 10FR-Tech-Analytics: Upgrade Fundraising Superset to 1.5.3 - https://phabricator.wikimedia.org/T311540 (10Jgreen) [20:47:21] 10Fundraising-Backlog: globalcollect: Displaying fail page for exception: The payment method [cc] was not found. - https://phabricator.wikimedia.org/T326600 (10Ejegg) 05Open→03Declined We're disabling it in prod by removing the payment methods in config until we can actually remove the code - see T260725 [20:47:56] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Move queue2civicrm_log to civicrm database (from drupal) - https://phabricator.wikimedia.org/T326611 (10Eileenmcnaughton) [20:50:04] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: questions re: Civi Recur fail email Jan 2022 - https://phabricator.wikimedia.org/T326770 (10Dwisehaupt) [20:50:36] 10fundraising-tech-ops, 10FR-Tech-Analytics: Upgrade Fundraising Superset to 1.5.3 - https://phabricator.wikimedia.org/T311540 (10Jgreen) [20:55:37] (03CR) 10Ejegg: "It might be better to just expose the existing idempotency header in the SmashPig call (see T243967 and I08dffc10420caad663a333 ). Also we" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/870946 (https://phabricator.wikimedia.org/T324860) (owner: 10AndyRussG) [20:57:37] 10Fundraising-Backlog, 10FR-Docker: Docker: make all MediaWiki services work with Fresh - https://phabricator.wikimedia.org/T326974 (10Dwisehaupt) p:05Triage→03Medium adjusting priority in relation to other docker tasks planned. [21:00:59] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: email addresses in Adyen recurring donor name fields - https://phabricator.wikimedia.org/T326986 (10Dwisehaupt) [21:01:55] (03PS1) 10Ejegg: Update currency rates [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882723 (https://phabricator.wikimedia.org/T326671) [21:02:20] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Japan, and 3 others: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10AndyRussG) From the commit message on the patch for the 2nd variant: > TODO: actually... [21:11:06] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: GatewayChooser: No supported gateway for parameters - https://phabricator.wikimedia.org/T326666 (10Pcoombe) Hi @AnnWF 1: That's correct, donatewiki doesn't accept a currency parameter, it just uses one currency per country. It woul... [21:12:43] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate: Review CentralNotice patch for Translate namespace change - https://phabricator.wikimedia.org/T327712 (10AndyRussG) [21:13:03] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate: Review CentralNotice patch for Translate namespace change - https://phabricator.wikimedia.org/T327712 (10AndyRussG) a:05Wangombe→03None [21:15:28] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog: New custom fields on a contribution- matching Gift related - https://phabricator.wikimedia.org/T327614 (10Dwisehaupt) [21:15:44] 10Fundraising-Backlog: Discuss SmashPig IPaymentProvider Interface - https://phabricator.wikimedia.org/T327498 (10jgleeson) [21:16:42] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Translate: Review CentralNotice patch for Translate namespace change - https://phabricator.wikimedia.org/T327712 (10Dwisehaupt) [21:17:44] 10Fundraising-Backlog: Discuss SmashPig IPaymentProvider Interface - https://phabricator.wikimedia.org/T327498 (10Ejegg) Agreed that we should look at the interfaces again ( T323962 ) and probably move approvePayment to a different interface. On the one hand, I like the thought of having a single createPayment... [21:23:11] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Update SmashPig currency rates - https://phabricator.wikimedia.org/T326671 (10Ejegg) [21:23:25] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: Update SmashPig currency rates - https://phabricator.wikimedia.org/T326671 (10Ejegg) a:03Ejegg [21:33:04] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Docker: Docker: make all MediaWiki services work with Fresh - https://phabricator.wikimedia.org/T326974 (10AnnWF) [21:38:06] (03CR) 10Wfan: [C: 03+2] "LGTM, check that from civi1001 tmp folder" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882723 (https://phabricator.wikimedia.org/T326671) (owner: 10Ejegg) [21:38:38] (03Merged) 10jenkins-bot: Update currency rates [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882723 (https://phabricator.wikimedia.org/T326671) (owner: 10Ejegg) [21:46:17] 10fundraising-tech-ops, 10FR-Tech-Analytics: Upgrade Fundraising Superset to 1.5.3 - https://phabricator.wikimedia.org/T311540 (10Jgreen) [21:47:23] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for dadedoyin - https://phabricator.wikimedia.org/T327695 (10Dwisehaupt) Client certificate renewed and sent via email. Password sent via sms. [21:49:22] 10Fundraising Tech - Chaos Crew: Investigate timeouts from Adyen Soap listener - https://phabricator.wikimedia.org/T317422 (10Ejegg) Let's get rid of the SOAP! T317837 T317833 [21:54:22] 10Fundraising-Backlog, 10FR-Adyen, 10FR-Smashpig: Make Adyen IPN listener understand JSON messages - https://phabricator.wikimedia.org/T317833 (10Ejegg) [21:54:27] 10Fundraising-Backlog, 10FR-Adyen: Add ability to accept JSON notifications - https://phabricator.wikimedia.org/T289166 (10Ejegg) [21:54:50] 10Fundraising-Backlog, 10FR-Adyen: Add ability to accept JSON notifications - https://phabricator.wikimedia.org/T289166 (10Ejegg) Copying estimate over from duplicate task [21:58:24] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Japan, and 3 others: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10Ejegg) @AndyRussG the existing name fields are still required, so donors shouldn't be a... [22:03:41] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: GatewayChooser: No supported gateway for parameters - https://phabricator.wikimedia.org/T326666 (10AnnWF) Hi @Pcoombe 1: ok, if this is expected behavior, then no worry, will keep this in mind then 2: here is the country list that... [22:25:58] (03PS2) 10Ejegg: Don't resolve multiple txns for same email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881447 (https://phabricator.wikimedia.org/T326361) [22:26:09] ok fr-tech, that patch is actually ready for review now ^^^ [22:26:56] oh i could add one more test for the pending-poke status and alreadyResolved [22:32:19] oh hmm, we should apply that alreadyProcessed check in other situations I think [22:37:21] (03PS3) 10Ejegg: Don't resolve multiple txns for same email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881447 (https://phabricator.wikimedia.org/T326361) [22:50:42] (03CR) 10CI reject: [V: 04-1] Don't resolve multiple txns for same email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881447 (https://phabricator.wikimedia.org/T326361) (owner: 10Ejegg) [22:55:51] (03PS4) 10Ejegg: Don't resolve multiple txns for same email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881447 (https://phabricator.wikimedia.org/T326361) [22:56:12] ok, I want to refactor that a bit but I'm going to do it in a follow-on patch [23:01:13] (03PS1) 10Ejegg: Refactor Resolve to shrink main _run function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/882753 [23:01:28] fr-tech does that look like any improvement? ^^^ [23:02:02] I feel like _run was right at the verge of too hard to understand even before adding the extra check on alreadyResolved [23:04:21] I just met up with Natalie - I suggested that the current process for her re prioritisation was to checkin during greg-g / XenoRyet office hours - although at some point that will switch to anilk [23:04:32] thanks eileen [23:04:47] also she is in Sarawak but hasn't seen the smelly flower [23:05:03] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Update deduper documentation to explain the critieria better - https://phabricator.wikimedia.org/T327727 (10Eileenmcnaughton) [23:07:58] OK, I'm going to assume that refactor is acceptable and write the next patch on top of it [23:08:15] hopefully won't touch exactly the same parts of the code [23:09:22] or.... I could do some review for a bit and give people a chance to object :) [23:10:20] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Revisit deduper interface with a view to making it possible to do a search in search kit to dedupe - https://phabricator.wikimedia.org/T327728 (10Eileenmcnaughton) [23:10:27] (03PS3) 10Ejegg: Remove redundant dLocal PaymentProvider instantiation test [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882673 (owner: 10Jgleeson) [23:10:32] (03CR) 10Ejegg: [C: 03+2] Remove redundant dLocal PaymentProvider instantiation test [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882673 (owner: 10Jgleeson) [23:11:04] (03Merged) 10jenkins-bot: Remove redundant dLocal PaymentProvider instantiation test [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882673 (owner: 10Jgleeson) [23:15:11] (03CR) 10CI reject: [V: 04-1] Refactor Resolve to shrink main _run function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/882753 (owner: 10Ejegg) [23:35:00] (03PS2) 10Ejegg: Refactor Resolve to shrink main _run function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/882753 [23:54:07] (03PS5) 10Ejegg: Don't resolve multiple txns for same email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881447 (https://phabricator.wikimedia.org/T326361) [23:57:33] (03PS3) 10Ejegg: Refactor Resolve to shrink main _run function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/882753