[00:00:10] (03PS4) 10Ejegg: Refactor Resolve to shrink main _run function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/882753 [00:02:09] PROBLEM - check_log_messages on frav1002 is CRITICAL: reading conf /etc/check_log_messages.conf https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [00:04:09] gonna afk for a lil bit while kid is still awake, might be back later [00:07:11] RECOVERY - check_log_messages on frav1002 is OK: reading conf /etc/check_log_messages.conf https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [00:21:07] anilk - you get our fr-tech@wikimedia.org emails don't you? Just checking cos that training email reply came through [00:38:38] (03PS3) 10Eileen: Stock CiviCRM 5.58.beta1 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881061 (https://phabricator.wikimedia.org/T326272) [00:50:57] ejegg|afk: I just successfully upgraded staging - but it picked up the drupal patch too. Did you create a symlink on live? [01:49:57] eileen: hi! yep, anilk has confirmed to me he's on that list [01:50:31] so i got around the issue introduced by the drupal patch by setting the var to skip the new check [01:51:05] ah sweet [01:54:54] ok eileen, i set it on staging too and the css + stuff is all loading [01:55:09] ejegg: yep - so I guess it's basically ready to review now [02:12:55] AndyRussG: that MessageGroups fix looks pretty clean, and the new namespace has been in the Translate extension since November [02:13:27] it's literally just a single 'use' statement added to two classes [02:14:20] ahh, the Translate patch was written in November but merged in December [02:14:30] and it's just working now because there's a class_alias [02:15:26] (03CR) 10Ejegg: [C: 03+1] "Looks good to me too, but maybe AndyRussG wants to give it the final +2?" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/861718 (https://phabricator.wikimedia.org/T313242) (owner: 10Wangombe) [02:16:34] thx ejegg I'll take a peek in a bit! [02:40:26] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/882764 [02:40:29] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/882764 (owner: 10Ejegg) [02:41:04] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/882764 (owner: 10Ejegg) [02:43:46] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/882765 [02:43:50] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/882765 (owner: 10Ejegg) [02:50:58] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/882765 (owner: 10Ejegg) [02:51:57] ejegg: ty for deploying stuff :) [02:52:36] * AndyRussG should have thought to offer to do so [02:54:21] AndyRussG: hehe, if you want to take it from here it's all yours [02:54:36] I'mma just do a matching submodule update on fundraising/REL1_39 [02:55:28] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/882786 [02:55:32] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/882786 (owner: 10Ejegg) [02:56:13] ejegg: oki! [02:56:52] I see rel135... and we're not pushing out rel139 until later this week, right? [02:57:05] AndyRussG: right [02:57:24] there's no worry about deploying the wrong branch [02:57:41] switching the gerrit deploy source branch takes an act of fr-tech-ops [02:58:08] I just want to keep rel1_39 in sync so we don't get anything reverted when we do the upgrade on Wednesday [02:58:09] ah okok so I'll push out rel1_35 for payments... that's all I see in the backscroll, so that's it, right? [02:58:13] yeah makes sense [02:58:17] yep yep, that's all [02:58:40] seems to be merged and ready for the f_c_u and rsync_blaster [02:58:51] then quickly test the adyen base forms [02:59:05] that is, the adyen form with no variant [02:59:18] and at our leisure test the variant [03:00:06] should be fine as long as it loads + renders the smartfields - the latest code changes don't touch anything further along in the flow [03:00:22] ejegg: ok cool got it :) [03:02:27] (03CR) 10CI reject: [V: 04-1] Update DonationInterface submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/882786 (owner: 10Ejegg) [03:02:37] oops [03:02:44] oh that's 1_39 [03:02:57] ah interesting, I'll try to fix that [03:03:33] oh hah, there are still some php 7.3 tests running on fundraising/REL1_39 [03:03:47] tomorrow I'll ask releng to swap all those over to the 7.4 ones [03:03:48] (03PS1) 10Eileen: Add new MatchingGiftInfo fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/882787 (https://phabricator.wikimedia.org/T327614) [03:04:12] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/882786 (owner: 10Ejegg) [03:04:23] forcemerged [03:06:56] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Civi Staging: grant select on contribution_tracking to civi dev read-only user - https://phabricator.wikimedia.org/T327736 (10Ejegg) [03:27:45] ok AndyRussG looks like that's still loading the non-variant page fine [03:28:30] (03PS2) 10Eileen: Add new MatchingGiftInfo fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/882787 (https://phabricator.wikimedia.org/T327614) [03:28:44] i just noticed an interesting thing though - in the adyen form we don't seem to show the name/email error messages on the first click when there are also blank card fields [03:29:02] then when you fill in the card fields and click again we do validate the email and name fields [03:29:18] hmmm [03:29:32] that wouldn't be new in this patch though [03:29:40] oh hey, do you want to !log the change? [03:30:17] yes about to [03:30:34] !log payments-wiki upgraded from 3d882ac7 to 15395d05 [03:30:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:31:16] in French, the label for the expiry date gets cut off on my form [03:31:31] oh shoot [03:32:28] Expiration de la carte bancaire ou de crédit< [03:32:44] yeah, we should add some instructions to translators to keep that short [03:33:23] 30 chars max or so [03:33:28] https://phabricator.wikimedia.org/F36456171 [03:33:54] I like 'Cryptogramme' for CVV [03:34:15] I just looked it up now heh [03:35:32] hmm, doesn't seem to be a common translation [03:35:41] maybe code de sécurité is more common? [03:36:05] yeah are those translations new? [03:36:32] I've had my browser requesting pages in French for quite a while now and I don't ever recall seeing "cryptoprogramme" before [03:36:42] sorry "cryptogramme" [03:37:01] AndyRussG: ohh, those would actually be from Adyen [03:37:05] we can override them [03:37:09] Expiry could just be "Expiration" [03:37:16] right [03:38:02] and (though someone else should check this) I would shorten "Adresse de couriel" to just "Courriel" [03:38:28] * AndyRussG runs back to his own department [03:38:38] let's file a bug to see how much of these we have translated and how much we should override [03:39:01] ejegg: I don't see any errors coming down the pipe [03:39:07] great! [03:39:24] Ingenico form also loads [03:40:05] on the ja_02 variant i can submit with just the top name fields, but not with just the bottom name fields [03:43:43] ejegg: cool! yeah sorry I didn't remember that requiredness, derp [03:43:59] nope, that's actually fine [03:44:27] it shouldn't require the bottom fields, just the fact that it asks for them makes it crystal clear which form of the name goes in the top fields [03:44:58] yeah [03:46:50] also funny thing, when I first changed the URL to uselang=ja and country=JP, the labels of a few of our fields remained in French [03:47:04] though now reloading that same URL they're correctly in Japanese [03:47:15] must be some weird caching thing [03:48:05] arrgh we still have some stuff looking at language and some stuff looking at uselang [03:48:34] someday we will sort that out [03:48:47] for now it only is visible to those of us that monkey with URL params [03:49:17] oh dang it got late! [03:49:25] ejegg: yeah I doubt any donors would hit it. I didn't add a language param for it to work, and when I opened the same URL in a private window everything was fine [03:49:31] well I'mma +2 that civi upgrade patch, it's looking fine to me [03:49:44] so I think it is caching of some sort, maybe RL caching some of the messages it sends in? [03:50:35] I think we set the language in our session, then we read that out for our own template rendering maybe after sending RL messages to JS? [03:52:35] ah yeah session sounds like a place of funkiness here [03:52:38] or a likely one [03:56:52] (03PS4) 10Ejegg: Stock CiviCRM 5.58.beta1 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881061 (https://phabricator.wikimedia.org/T326272) (owner: 10Eileen) [03:56:56] (03CR) 10Ejegg: [C: 03+2] Stock CiviCRM 5.58.beta1 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881061 (https://phabricator.wikimedia.org/T326272) (owner: 10Eileen) [04:01:30] (03Abandoned) 10Ejegg: WIP try loading adyen variants with mw.loader.using [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/882694 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [04:04:57] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Update SmashPig currency rates - https://phabricator.wikimedia.org/T326671 (10Ejegg) Hi @HNordeenWMF, they're updated in the [[ https://github.com/wikimedia/wikimedia-fundraising-SmashPig/blob/master/PaymentData/ReferenceData/CurrencyRates.php | source co... [04:11:18] (03Merged) 10jenkins-bot: Stock CiviCRM 5.58.beta1 rc [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881061 (https://phabricator.wikimedia.org/T326272) (owner: 10Eileen) [04:11:34] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Japan, and 3 others: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10Ejegg) OK @TSkaff, these are deployed. Note that the phonetic fields are currently just... [04:13:08] (03PS6) 10Ejegg: Don't resolve multiple txns for same email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881447 (https://phabricator.wikimedia.org/T326361) [04:15:17] (03PS5) 10Ejegg: Refactor Resolve to shrink main _run function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/882753 [04:15:30] gnight! [05:07:19] (03PS1) 10Cstone: WIP: Add api calls and maintenance scripts for dlocal notifications [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882789 (https://phabricator.wikimedia.org/T324293) [05:07:43] (03CR) 10CI reject: [V: 04-1] WIP: Add api calls and maintenance scripts for dlocal notifications [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882789 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [05:10:08] (03PS2) 10Cstone: WIP: Add api calls and maintenance scripts for dlocal notifications [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882789 (https://phabricator.wikimedia.org/T324293) [05:15:58] (03PS5) 10Wfan: Adyen API idempotency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/870946 (https://phabricator.wikimedia.org/T324860) (owner: 10AndyRussG) [05:17:50] (03CR) 10CI reject: [V: 04-1] Adyen API idempotency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/870946 (https://phabricator.wikimedia.org/T324860) (owner: 10AndyRussG) [05:20:27] (03PS6) 10Wfan: Adyen API idempotency [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/870946 (https://phabricator.wikimedia.org/T324860) (owner: 10AndyRussG) [06:20:05] (03CR) 10CI reject: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/882839 (owner: 10L10n-bot) [12:23:16] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] (REL1_39) - 10https://gerrit.wikimedia.org/r/882839 (owner: 10L10n-bot) [12:24:00] (03CR) 10Jgleeson: [C: 03+2] "This is working for me! Thanks for the tests." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881447 (https://phabricator.wikimedia.org/T326361) (owner: 10Ejegg) [12:38:32] (03Merged) 10jenkins-bot: Don't resolve multiple txns for same email [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881447 (https://phabricator.wikimedia.org/T326361) (owner: 10Ejegg) [12:47:46] (03CR) 10Jgleeson: [C: 03+2] "Definitely makes it easier to read through. Thanks" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/882753 (owner: 10Ejegg) [12:53:26] (03PS1) 10Jgleeson: Small fn name update in pending trxn resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/883164 [13:01:43] (03Merged) 10jenkins-bot: Refactor Resolve to shrink main _run function [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/882753 (owner: 10Ejegg) [14:13:21] (03PS12) 10Damilare Adedoyin: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [14:15:29] (03CR) 10CI reject: [V: 04-1] Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [15:18:42] 10fundraising-tech-ops, 10FR-Tech-Analytics: Upgrade Fundraising Superset to 1.5.3 - https://phabricator.wikimedia.org/T311540 (10Jgreen) [15:19:17] 10fundraising-tech-ops, 10FR-Tech-Analytics: Upgrade Fundraising Superset to 1.5.3 - https://phabricator.wikimedia.org/T311540 (10Jgreen) [15:20:28] 10fundraising-tech-ops, 10FR-Tech-Analytics: Upgrade Fundraising Superset to 1.5.3 - https://phabricator.wikimedia.org/T311540 (10Jgreen) bullseye and superset 1.5.3 upgrades are complete in my test environment [16:31:16] PROBLEM - check_puppetrun on pay-lvs2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 21 seconds ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=pay-lvs2002&service=check_puppetrun [16:31:16] PROBLEM - check_puppetrun on fran1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran1001&service=check_puppetrun [16:32:16] PROBLEM - check_puppetrun on frav1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 42 seconds ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_puppetrun [16:32:16] PROBLEM - check_puppetrun on frqueue1004 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 1 minute ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_puppetrun [16:32:57] (03CR) 10Ejegg: "Looks like this has changed in the base version to not do the query if max(id) is over one million. so.. this patch may not be needed?" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881490 (https://phabricator.wikimedia.org/T326272) (owner: 10Eileen) [16:33:05] (03PS2) 10Ejegg: Do not pass go, do not add this new index [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881493 (https://phabricator.wikimedia.org/T326272) (owner: 10Eileen) [16:33:18] PROBLEM - check_puppetrun on frpig1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 1 minute ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpig1001&service=check_puppetrun [16:36:10] PROBLEM - check_puppetrun on pay-lvs2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=pay-lvs2001&service=check_puppetrun [16:36:16] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2002&service=check_puppetrun [16:36:16] PROBLEM - check_puppetrun on pay-lvs2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=pay-lvs2002&service=check_puppetrun [16:36:16] RECOVERY - check_puppetrun on fran1001 is OK: OK: Puppet is currently enabled, last run 3 seconds ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=fran1001&service=check_puppetrun [16:36:26] PROBLEM - check_puppetrun on frpig2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpig2001&service=check_puppetrun [16:37:10] PROBLEM - check_puppetrun on frav1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_puppetrun [16:37:10] PROBLEM - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 1 minute ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_puppetrun [16:37:16] PROBLEM - check_puppetrun on frdb1003 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_puppetrun [16:37:16] PROBLEM - check_puppetrun on civi2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=civi2001&service=check_puppetrun [16:37:16] PROBLEM - check_puppetrun on pay-lvs1003 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=pay-lvs1003&service=check_puppetrun [16:37:17] PROBLEM - check_puppetrun on frpm2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm2001&service=check_puppetrun [16:37:17] PROBLEM - check_puppetrun on frqueue1004 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_puppetrun [16:37:17] PROBLEM - check_puppetrun on frdev1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1002&service=check_puppetrun [16:37:17] PROBLEM - check_puppetrun on frban2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban2001&service=check_puppetrun [16:37:18] PROBLEM - check_puppetrun on frban1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_puppetrun [16:37:18] PROBLEM - check_puppetrun on frdata2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdata2001&service=check_puppetrun [16:37:37] (03PS1) 10Jgleeson: Reorder CardPaymentProvider methods for public/protected/private [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883230 (https://phabricator.wikimedia.org/T324281) [16:37:58] (03CR) 10CI reject: [V: 04-1] Reorder CardPaymentProvider methods for public/protected/private [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883230 (https://phabricator.wikimedia.org/T324281) (owner: 10Jgleeson) [16:38:16] PROBLEM - check_puppetrun on frqueue2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue2001&service=check_puppetrun [16:38:16] PROBLEM - check_puppetrun on frbast2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 7 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frbast2001&service=check_puppetrun [16:38:16] PROBLEM - check_puppetrun on frnetmon1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frnetmon1001&service=check_puppetrun [16:38:18] PROBLEM - check_puppetrun on frpig1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpig1001&service=check_puppetrun [16:40:10] PROBLEM - check_puppetrun on frlog2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 9 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frlog2001&service=check_puppetrun [16:40:16] PROBLEM - check_puppetrun on frauth2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 9 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frauth2001&service=check_puppetrun [16:40:18] PROBLEM - check_puppetrun on frdev1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_puppetrun [16:40:18] PROBLEM - check_puppetrun on frdata1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 8 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdata1002&service=check_puppetrun [16:40:18] PROBLEM - check_puppetrun on civi1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 8 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=civi1001&service=check_puppetrun [16:40:59] (03CR) 10Ejegg: [C: 03+2] "Sure, seems worth skipping just for the upgrade time. I'm curious how much space foreign keys actually take up though - I guess that "on d" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881493 (https://phabricator.wikimedia.org/T326272) (owner: 10Eileen) [16:41:10] PROBLEM - check_puppetrun on frbast1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 9 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frbast1001&service=check_puppetrun [16:41:12] PROBLEM - check_puppetrun on frpm1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 9 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1001&service=check_puppetrun [16:41:12] PROBLEM - check_puppetrun on pay-lvs2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=pay-lvs2001&service=check_puppetrun [16:41:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2002&service=check_puppetrun [16:41:14] PROBLEM - check_puppetrun on pay-lvs2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=pay-lvs2002&service=check_puppetrun [16:41:16] PROBLEM - check_puppetrun on pay-lvs1004 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=pay-lvs1004&service=check_puppetrun [16:41:26] PROBLEM - check_puppetrun on frpig2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpig2001&service=check_puppetrun [16:42:14] PROBLEM - check_puppetrun on frav1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_puppetrun [16:42:14] PROBLEM - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_puppetrun [16:42:14] RECOVERY - check_puppetrun on frpm2001 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm2001&service=check_puppetrun [16:42:15] PROBLEM - check_puppetrun on pay-lvs1003 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=pay-lvs1003&service=check_puppetrun [16:42:15] PROBLEM - check_puppetrun on frqueue1004 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 11 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_puppetrun [16:42:15] PROBLEM - check_puppetrun on frdb1003 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_puppetrun [16:42:15] PROBLEM - check_puppetrun on civi2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 11 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=civi2001&service=check_puppetrun [16:42:16] PROBLEM - check_puppetrun on frdev1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1002&service=check_puppetrun [16:42:16] PROBLEM - check_puppetrun on frban2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 11 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban2001&service=check_puppetrun [16:42:20] PROBLEM - check_puppetrun on frban1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 11 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_puppetrun [16:42:20] PROBLEM - check_puppetrun on frdata2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 11 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdata2001&service=check_puppetrun [16:43:16] PROBLEM - check_puppetrun on frqueue2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 11 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue2001&service=check_puppetrun [16:43:16] PROBLEM - check_puppetrun on frbast2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 12 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frbast2001&service=check_puppetrun [16:43:16] RECOVERY - check_puppetrun on frnetmon1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frnetmon1001&service=check_puppetrun [16:43:18] PROBLEM - check_puppetrun on frpig1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 11 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpig1001&service=check_puppetrun [16:43:34] (03PS2) 10Jgleeson: Reorder CardPaymentProvider methods for public/protected/private [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883230 (https://phabricator.wikimedia.org/T324281) [16:43:56] (03CR) 10jenkins-bot: Reorder CardPaymentProvider methods for public/protected/private [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883230 (https://phabricator.wikimedia.org/T324281) (owner: 10Jgleeson) [16:44:20] (03PS3) 10Jgleeson: Reorder CardPaymentProvider methods for public/protected/private [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883230 (https://phabricator.wikimedia.org/T324281) [16:45:10] PROBLEM - check_puppetrun on frlog2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 14 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frlog2001&service=check_puppetrun [16:45:16] PROBLEM - check_puppetrun on frauth2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 14 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frauth2001&service=check_puppetrun [16:45:16] RECOVERY - check_puppetrun on frdata1002 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdata1002&service=check_puppetrun [16:45:18] PROBLEM - check_puppetrun on frdev1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_puppetrun [16:45:18] RECOVERY - check_puppetrun on civi1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=civi1001&service=check_puppetrun [16:46:10] PROBLEM - check_puppetrun on frbast1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 14 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frbast1001&service=check_puppetrun [16:46:12] RECOVERY - check_puppetrun on pay-lvs2001 is OK: OK: Puppet is currently enabled, last run 43 seconds ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=pay-lvs2001&service=check_puppetrun [16:46:14] PROBLEM - check_puppetrun on frdb2002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 15 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2002&service=check_puppetrun [16:46:14] RECOVERY - check_puppetrun on pay-lvs2002 is OK: OK: Puppet is currently enabled, last run 6 seconds ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=pay-lvs2002&service=check_puppetrun [16:46:16] PROBLEM - check_puppetrun on frpm1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 14 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1001&service=check_puppetrun [16:46:18] PROBLEM - check_puppetrun on pay-lvs1004 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 10 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[systemd-timesyncd] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=pay-lvs1004&service=check_puppetrun [16:46:26] RECOVERY - check_puppetrun on frpig2001 is OK: OK: Puppet is currently enabled, last run 21 seconds ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpig2001&service=check_puppetrun [16:47:10] RECOVERY - check_puppetrun on frav1002 is OK: OK: Puppet is currently enabled, last run 39 seconds ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_puppetrun [16:47:10] RECOVERY - check_puppetrun on frdb1003 is OK: OK: Puppet is currently enabled, last run 43 seconds ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1003&service=check_puppetrun [16:47:11] RECOVERY - check_puppetrun on frdb2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_puppetrun [16:47:11] RECOVERY - check_puppetrun on frqueue1004 is OK: OK: Puppet is currently enabled, last run 42 seconds ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue1004&service=check_puppetrun [16:47:12] RECOVERY - check_puppetrun on frdev1002 is OK: OK: Puppet is currently enabled, last run 44 seconds ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1002&service=check_puppetrun [16:47:12] RECOVERY - check_puppetrun on pay-lvs1003 is OK: OK: Puppet is currently enabled, last run 46 seconds ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=pay-lvs1003&service=check_puppetrun [16:47:16] RECOVERY - check_puppetrun on civi2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=civi2001&service=check_puppetrun [16:47:16] RECOVERY - check_puppetrun on frban1001 is OK: OK: Puppet is currently enabled, last run 45 seconds ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_puppetrun [16:47:16] RECOVERY - check_puppetrun on frban2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban2001&service=check_puppetrun [16:47:18] RECOVERY - check_puppetrun on frdata2001 is OK: OK: Puppet is currently enabled, last run 36 seconds ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdata2001&service=check_puppetrun [16:48:10] RECOVERY - check_puppetrun on frqueue2001 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frqueue2001&service=check_puppetrun [16:48:12] RECOVERY - check_puppetrun on frpig1001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpig1001&service=check_puppetrun [16:48:16] RECOVERY - check_puppetrun on frbast2001 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frbast2001&service=check_puppetrun [16:50:10] RECOVERY - check_puppetrun on frlog2001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frlog2001&service=check_puppetrun [16:50:16] RECOVERY - check_puppetrun on frauth2001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frauth2001&service=check_puppetrun [16:50:18] RECOVERY - check_puppetrun on frdev1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_puppetrun [16:51:10] RECOVERY - check_puppetrun on frbast1001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frbast1001&service=check_puppetrun [16:51:10] RECOVERY - check_puppetrun on frpm1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1001&service=check_puppetrun [16:51:16] RECOVERY - check_puppetrun on frdb2002 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2002&service=check_puppetrun [16:51:16] RECOVERY - check_puppetrun on pay-lvs1004 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=pay-lvs1004&service=check_puppetrun [16:55:56] (03Merged) 10jenkins-bot: Do not pass go, do not add this new index [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881493 (https://phabricator.wikimedia.org/T326272) (owner: 10Eileen) [16:57:43] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Japan, and 2 others: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10TSkaff) Wo-hoo thank you @Ejegg!! I'll pass these off to the Online team for QA & rev... [17:01:22] (03PS2) 10Ejegg: Small fn name update in pending trxn resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/883164 (owner: 10Jgleeson) [17:01:26] (03CR) 10Ejegg: [C: 03+2] Small fn name update in pending trxn resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/883164 (owner: 10Jgleeson) [17:16:00] (03Merged) 10jenkins-bot: Small fn name update in pending trxn resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/883164 (owner: 10Jgleeson) [17:20:49] (03PS3) 10Ejegg: Add new MatchingGiftInfo fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/882787 (https://phabricator.wikimedia.org/T327614) (owner: 10Eileen) [17:21:30] (03CR) 10Ejegg: [C: 03+2] "Looks good! The fields show up for me locally after a system.flush" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/882787 (https://phabricator.wikimedia.org/T327614) (owner: 10Eileen) [17:30:41] (03PS2) 10Ejegg: Ingenico: get name from iframe, not our field [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/882684 (https://phabricator.wikimedia.org/T312877) [17:32:12] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Review CiviCRM indexes in order to reduce disk space & improve performance - https://phabricator.wikimedia.org/T126388 (10Dwisehaupt) This index has been dropped. ` MariaDB [civicrm]> show indexes from civicrm_activity; +------------------+------------... [17:32:50] (03CR) 10CI reject: [V: 04-1] Ingenico: get name from iframe, not our field [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/882684 (https://phabricator.wikimedia.org/T312877) (owner: 10Ejegg) [17:34:15] (03PS3) 10Ejegg: Ingenico: get name from iframe, not our field [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/882684 (https://phabricator.wikimedia.org/T312877) [17:38:58] (03Merged) 10jenkins-bot: Add new MatchingGiftInfo fields [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/882787 (https://phabricator.wikimedia.org/T327614) (owner: 10Eileen) [17:43:54] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Review CiviCRM indexes in order to reduce disk space & improve performance - https://phabricator.wikimedia.org/T126388 (10Dwisehaupt) [17:48:33] (03PS1) 10Ejegg: Split full_name for use in minfraud queries [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/883248 (https://phabricator.wikimedia.org/T312877) [17:58:53] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10fundraising-tech-ops: Civi Staging: grant select on contribution_tracking to civi dev read-only user - https://phabricator.wikimedia.org/T327736 (10Dwisehaupt) Grants have been updated and applied to the staging and qa role hosts. Please feel free to... [18:01:47] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Japan, and 2 others: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10TSkaff) Hi again @Ejegg, I think I misunderstood--so we can't run real donations throug... [18:15:18] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Japan, and 2 others: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10TSkaff) Nevermind, I got it. I added a real banner for the utm_source @Ejegg [18:28:22] (03PS1) 10Ejegg: New name flow for Ingenico pending resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/883252 (https://phabricator.wikimedia.org/T312877) [18:29:24] ^^^ will fail tests because it needs a SmashPig change that's still in review [18:37:07] (03PS4) 10Jgleeson: Reorder CardPaymentProvider methods for public/protected/private [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883230 (https://phabricator.wikimedia.org/T324281) [18:45:17] (03CR) 10CI reject: [V: 04-1] New name flow for Ingenico pending resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/883252 (https://phabricator.wikimedia.org/T312877) (owner: 10Ejegg) [18:49:31] db locks [18:49:51] hmm, no current big queries though [18:51:38] ejegg: it's possible that there was contention right when the civicrm_activity table alter finished. was reclaiming space from an index drop. [18:53:30] it finished up about 1848 utc and you can see it replicating now: https://frmon.wikimedia.org/d/000000273/mariadb?orgId=1&viewPanel=49&from=now-1h&to=now [18:53:55] ah ok, thanks dwisehaupt [18:53:55] should clear in ~45 mins based on the runtime on the origin server. [18:54:27] looks like someone is deduping too [19:10:12] PROBLEM - check_mysql on frdb1005 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1294 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1005&service=check_mysql [19:10:18] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1293 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_mysql [19:10:56] those are known, i'm going to put in downtime for the hosts. [19:11:12] PROBLEM - check_mysql on frdb1006 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1354 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1006&service=check_mysql [19:11:14] PROBLEM - check_procs on frdb1006 is CRITICAL: PROCS CRITICAL: 1510 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1006&service=check_procs [19:21:18] RECOVERY - check_procs on frdb1006 is OK: PROCS OK: 720 processes https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1006&service=check_procs [19:21:56] (03PS1) 10Jgleeson: Add dlocal approvePayment call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883268 (https://phabricator.wikimedia.org/T324281) [19:22:05] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for dbu - https://phabricator.wikimedia.org/T327703 (10Dwisehaupt) Certificate renewed and sent via email. Password sent via sms. [19:22:50] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Handle submission for DLocal REDIRECT methods in DonationInterface - https://phabricator.wikimedia.org/T324291 (10jgleeson) a:03jgleeson [19:24:52] (03PS2) 10Jgleeson: Add dlocal approvePayment call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883268 (https://phabricator.wikimedia.org/T324281) [19:26:33] (03PS3) 10Jgleeson: Add dlocal approvePayment call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883268 (https://phabricator.wikimedia.org/T324281) [19:26:50] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sguseman - https://phabricator.wikimedia.org/T327694 (10Dwisehaupt) Certificate renewed and sent via email. Password sent via sms. [19:35:14] RECOVERY - check_mysql on frdb1005 is OK: Uptime: 1821410 Threads: 4 Questions: 48322511 Slow queries: 917 Opens: 1557 Open tables: 1206 Queries per second avg: 26.530 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1005&service=check_mysql [19:36:16] RECOVERY - check_mysql on frdb1006 is OK: Uptime: 1823097 Threads: 6 Questions: 121735370 Slow queries: 125 Opens: 1846 Open tables: 1390 Queries per second avg: 66.773 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1006&service=check_mysql [19:42:41] 10Fundraising-Backlog: Remove AVS fraud score while we run the JP and Sweden campaigns though 15 April - https://phabricator.wikimedia.org/T327810 (10EMartin) [19:43:28] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog: Adyen form requested for Czech Republic for Q3 testing - https://phabricator.wikimedia.org/T323715 (10Cstone) a:03Cstone [20:10:14] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 1821938 Threads: 16 Questions: 47948126 Slow queries: 421477 Opens: 227038158 Flush tables: 1 Open tables: 200 Queries per second avg: 26.317 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_mysql [20:34:40] testing : xdebug.remote_host # [20:34:40] Replaced by xdebug.client_host. for xdebug 3 [20:35:00] Thanks AndyRussG: for pointing that out did not noticed xdebug3 [20:36:09] wfan: thank u :) [20:36:46] (03Abandoned) 10Eileen: Temporarily remove slow, unhelpful query [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/881490 (https://phabricator.wikimedia.org/T326272) (owner: 10Eileen) [20:46:08] wfan: AndyRussG my civicrm is runnin xdebug 2.7 [20:46:17] and I rebuilt from scratch last week [20:47:37] yep yep, civicrm is still running buster [20:47:48] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog: New custom fields on a contribution- matching Gift related - https://phabricator.wikimedia.org/T327614 (10Eileenmcnaughton) a:03Eileenmcnaughton [20:47:57] i haven't had the chance to switch it to the bullseye container yet [20:51:35] AndyRussG: xdebug for payment works ~ yeah~ and yes civi remain working since not update to xdebug2 [20:51:39] xdebug3 [20:56:27] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-PayPal-ExpressCheckout: Update Pending Transaction Resolver to handle PayPal - https://phabricator.wikimedia.org/T324642 (10Dwisehaupt) Pulling from current sprint to do next sprint. [20:56:34] wfan: [20:56:43] what does your config/civicrm/xdebug-web.ini look like [20:57:05] xdebug.remote_port=9000 [20:57:05] xdebug.remote_autostart=off [20:57:05] xdebug.remote_host=docker.for.mac.localhost [20:57:05] xdebug.idekey=PHPSTORM [20:57:33] will update to on when do the test~ and for payments just update the remote_host to client_host [20:57:55] (03CR) 10Ejegg: [C: 03+1] "This works great! Just needs some spaces replaced with tabs in the JS" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880528 (https://phabricator.wikimedia.org/T324272) (owner: 10Damilare Adedoyin) [20:57:55] hmm I don't think you need to update those [20:58:07] they look good to me [20:59:04] wfan here's mine: [20:59:09] xdebug.remote_port=9000 [20:59:11] xdebug.start_with_request=on [20:59:13] xdebug.client_host=docker.for.mac.localhost [20:59:15] xdebug.idekey="PHPSTORM" [20:59:17] \ [20:59:31] only difference is client_host is your remote_host [20:59:43] hmm damilare and also remote_autostart [20:59:54] damilare: those are xdebug 3 settings [21:00:03] you have those for your civi xdebug config? [21:00:04] https://xdebug.org/docs/upgrade_guide#changed-xdebug.remote_host [21:00:11] remote_host = 2.7 [21:00:17] client_host = 4 [21:00:20] oops [21:00:25] client_host = 3 [21:01:12] PROBLEM - check_mysql on frdb2002 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1360 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2002&service=check_mysql [21:01:16] (xdebug 2.7) (xdebug 3) [21:01:23] so my civi use xdebug2, payments use xdebug3, and then for the config, civi use remote_host, payments use client_host [21:01:25] ohh sorry that was payment, didn't know you were talking about civi [21:01:55] wfan: let's jump on a call after this one [21:02:03] I just gotta relocate [21:02:10] PROBLEM - check_mysql on frdb2001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1418 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql [21:03:12] ok [21:06:04] here's what I have for civi wfan [21:06:06] xdebug.remote_port=9000 [21:06:08] xdebug.remote_autostart=on [21:06:10] xdebug.remote_host=docker.for.mac.localhost [21:06:12] xdebug.idekey="PHPSTORM" [21:06:12] RECOVERY - check_mysql on frdb2002 is OK: Uptime: 1826085 Threads: 10 Questions: 48082456 Slow queries: 928 Opens: 1576 Flush tables: 1 Open tables: 1207 Queries per second avg: 26.330 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2002&service=check_mysql [21:06:14] xdebug.remote_timeout=1000000000 [21:07:18] xdebug.remote_timeout=1000000000 only for civi? [21:08:43] yh I think so [21:08:47] ok, just find out if we want add to payments also, for xdebug3 we have xdebug.connect_timeout_ms haha, thanks damilare [21:08:56] nah not on payment [21:09:13] just civi [21:09:26] my payment config was what I shared earlier [21:10:20] ok, but why do you add that timeout for civi? [21:10:50] (03PS1) 10Ejegg: New interface to mark processor-side recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883277 (https://phabricator.wikimedia.org/T323962) [21:11:03] bvecause of the time it takes to bootstrap tests [21:11:57] sometimes xdebugs times out before phpunit starts running tests [21:12:12] RECOVERY - check_mysql on frdb2001 is OK: Uptime: 1825595 Threads: 10 Questions: 48077290 Slow queries: 907 Opens: 1587 Flush tables: 1 Open tables: 1215 Queries per second avg: 26.335 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb2001&service=check_mysql [21:12:12] ok will add to mine too thanks for the hint~ [21:15:16] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2201 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_mysql [21:20:18] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2501 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_mysql [21:25:18] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 2801 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_mysql [21:30:50] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, and 3 others: Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4 - https://phabricator.wikimedia.org/T326372 (10Ejegg) Thanks,... [21:35:18] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 1827038 Threads: 16 Questions: 47998458 Slow queries: 422532 Opens: 227200158 Flush tables: 1 Open tables: 200 Queries per second avg: 26.271 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1001&service=check_mysql [21:35:27] (03PS13) 10Damilare Adedoyin: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [21:35:45] (03PS1) 10Ejegg: Use fundraising/REL1_39 for new payments installs [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/883279 [21:37:18] (03CR) 10CI reject: [V: 04-1] Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [21:42:56] (03CR) 10Ejegg: "Interesting pattern! Splitting approve response mapping out into a new class seems like a good way to avoid bloating the CardPaymentProvid" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883268 (https://phabricator.wikimedia.org/T324281) (owner: 10Jgleeson) [21:42:58] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, and 3 others: Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4 - https://phabricator.wikimedia.org/T326372 (10Jdforrester-WMF... [21:43:43] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883230 (https://phabricator.wikimedia.org/T324281) (owner: 10Jgleeson) [21:44:16] (03Merged) 10jenkins-bot: Reorder CardPaymentProvider methods for public/protected/private [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883230 (https://phabricator.wikimedia.org/T324281) (owner: 10Jgleeson) [21:46:42] oh shoot cstone those webhooks look like things the banks would be calling, not the merchant [21:47:25] aren't the 'issuing' bits all for card issuers? [21:47:31] ah yeah i was just trying to see if i could get any notification in the test env [21:47:47] i thought i had gotten there from the webhook area i guess i thought they were setup calls [21:47:53] ah cool [21:47:59] ok, now I [21:48:05] m reading the docs [21:48:20] and I do see some indications that they're for merchants [21:48:24] sorry for the confusion [21:48:40] no its fine i just wanted a test webhook before i wrote the main part and was attempting with that hah [21:49:28] ok, so there's no way to just configure which notifications we want in the UI? [21:49:33] i couldnt find it [21:49:34] (03PS6) 10Damilare Adedoyin: Handle errors from DLocal SmartForms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880528 (https://phabricator.wikimedia.org/T324272) [21:49:37] boo [21:50:02] k, I guess we need these API calls then [21:50:21] you might be right though ejegg I was just trying to get something [21:52:03] ejegg: thanks for the review. I moved away from the new Mapper concept because I felt like it I was introducing another "home brew" pattern with no real clear rules to follow and that might have caused issues down the road. The current ::fromRawResponse is pretty much a Factory method. I extended the vanilla class so we could add dlocal specific build steps [21:53:14] jgleeson: damilare have you done any test payments on the new dlocal? or are there multiple consoles? [21:53:22] maybe ive been in the wrong console [21:53:30] I've done a few [21:53:44] but not looked an 'em in the console yet [21:54:04] same at least with the create payment, I think I saw them on the dlocal sandbox dash [21:54:22] i dont see any but are there multiple consoles? [21:54:57] (03CR) 10Damilare Adedoyin: "Thanks ejegg for the review. The recommended changes have been made" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880528 (https://phabricator.wikimedia.org/T324272) (owner: 10Damilare Adedoyin) [21:55:36] jgleeson: yep, it seems like the right pattern, I guess I just don't see the new class accessing any protected bits of the parent class, so it doesn't really have to inherit... No big deal in any case [21:55:55] yh cstone, you'd probably have to increase the date range on the test sandbox [21:56:12] I think it's set to today by default [21:56:27] LOL haha yeah wow [21:56:32] my fault for not looking at that [21:56:49] no p, missed it at first myself [22:01:57] (03PS7) 10Ejegg: Handle errors from DLocal SmartForms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880528 (https://phabricator.wikimedia.org/T324272) (owner: 10Damilare Adedoyin) [22:02:54] ejegg: we should probably move the factory method to the parent class [22:03:25] and the benefit would be that we could call it from the children and implement the processor-specific stuff there [22:03:37] jgleeson: ahh, make it abstract? [22:04:21] https://refactoring.guru/design-patterns/factory-method [22:04:55] I guess... I was just suggesting keeping your patch as is, just omitting the 'extends ...' and saying new ApprovePaymentResponse instead of new static() [22:06:25] so we could do that and make it a single factory for dlocal stuff but I was thinking we could also add it on the parent and then implement it in the children, to make it easier for others to use [22:06:52] that way the hierarchy would make sense [22:06:58] I agree that now, it doesn't add any value [22:08:08] lemme fix that typo [22:08:41] jgleeson: I feel a bit queasy about letting the response objects have processor-specific sublasses [22:08:51] i've been thinking of them as 'final' [22:09:23] (03CR) 10Jforrester: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/879689 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [22:09:24] since they are supposed to be the fully-normalized form and usable identically across all processors [22:10:22] well, I guess some of the responses inherit from other responses so they're not really 'final', but you know what I mean [22:12:02] I get that. using your suggestion, maybe what we need here is something like ApprovePaymentResponseFactory::fromDLocalRawResponse() [22:12:19] that sounds good jgleeson [22:12:36] that could be an abstract factory then [22:13:21] (03CR) 10Ejegg: [C: 03+2] "Thanks, looks good!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880528 (https://phabricator.wikimedia.org/T324272) (owner: 10Damilare Adedoyin) [22:13:23] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, and 3 others: Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4 - https://phabricator.wikimedia.org/T326372 (10Jdforrester-WMF... [22:14:46] fr-tech I've just asked releng to switch CI over to using fundraising/REL1_39 for the DonationInterface tests [22:15:07] (03CR) 10CI reject: [V: 04-1] Handle errors from DLocal SmartForms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880528 (https://phabricator.wikimedia.org/T324272) (owner: 10Damilare Adedoyin) [22:16:29] ah shoot, 17:14:59 Error: Call to a member function getAccountConfig() on null [22:17:14] that shouldn't have been caused by anything in the patch - is it the new tests? [22:17:53] damilare: looks like your patch is the victim of a not-quite-related test failure maybe? [22:18:05] let's see why that would be null [22:19:21] ahh, so for adyen we're adding stuff like that in addGatewaySpecificResources, not right in execute. [22:19:28] let's see if that works for DLocal [22:19:54] we don't have that till my next patch [22:20:18] oh shoot, we might need to pull that one change forward just to get the tests passing [22:20:53] I can make a tiny standalone patch to do that [22:21:05] ok, I'd review [22:21:18] (03PS4) 10Jgleeson: Add dlocal approvePayment call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883268 (https://phabricator.wikimedia.org/T324281) [22:22:24] (03CR) 10Jgleeson: "Thanks for the review. Updated the typo and I'll follow on tomorrow with the updates discussed on IRC." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883268 (https://phabricator.wikimedia.org/T324281) (owner: 10Jgleeson) [22:23:27] (03PS1) 10Ejegg: Use addGatewaySpecificResources for dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/883286 [22:23:45] damilare: I think that should do it ^^^ but I need to smoke test [22:24:24] oh hey, I can put the argument typehint in there [22:24:37] (03PS2) 10Ejegg: Use addGatewaySpecificResources for dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/883286 [22:24:55] ohh this is different [22:26:35] ok, seems to load fine locally [22:28:13] (03CR) 10Damilare Adedoyin: [C: 03+2] "Thanks for this. Tested and works well" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/883286 (owner: 10Ejegg) [22:28:46] rockin, let's see if that lets your patch merge [22:29:22] (03PS8) 10Ejegg: Handle errors from DLocal SmartForms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880528 (https://phabricator.wikimedia.org/T324272) (owner: 10Damilare Adedoyin) [22:29:38] (03CR) 10Ejegg: [C: 03+2] Handle errors from DLocal SmartForms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880528 (https://phabricator.wikimedia.org/T324272) (owner: 10Damilare Adedoyin) [22:31:40] thanks ejegg, looks like that resolved the issue [22:31:53] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Use fundraising/REL1_39 for new payments installs [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/883279 (owner: 10Ejegg) [22:32:44] oh nice jgleeson, i see the capturePayment patch is out of WIP [22:32:49] will take a look [22:32:58] yay damilare [22:35:27] yeah ejegg, doh, I forgot it was still in WIP [22:35:32] (03CR) 10Ejegg: "Looking good so far, just one suggestion for the our-side param name that gets sent as authorization_id." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/881700 (https://phabricator.wikimedia.org/T324281) (owner: 10Jgleeson) [22:37:09] thanks for the review ejegg [22:37:19] does that make sense? [22:37:35] yep! I'll update that mapping in the morning [22:37:36] I know we probably SHOULD have a local concept of auth ID vs capture ID [22:37:56] but... so far we have this silly gateway_txn_id [22:38:19] have a good night jgleeson [22:38:21] have a good evening fr-tech. bye for now o/ [22:41:24] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, and 3 others: Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4 - https://phabricator.wikimedia.org/T326372 (10Ejegg) Hi @Jdfo... [22:42:16] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, and 3 others: Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4 - https://phabricator.wikimedia.org/T326372 (10Ejegg) And than... [22:45:21] cstone: so your forwarding endpoint is https://paymentsipntest6.wmcloud.org/astropay ? [22:45:51] Just looking for IPN config up at the dlocal console and all I see is that value in the 'Payins notification URL' [22:45:55] no mine is 4 but i was just trying to find a way to trigger one [22:46:04] i didnt change it there yet [22:46:12] you can also send a url with each payment [22:46:21] ah right [22:46:42] hmm, so it says status updates for pending payments [22:46:44] maybe they just happen automatically then? i was just messing around last night with those api calls [22:46:52] so what's te test flow for e.g. boletos? [22:46:53] i will ask tomorrow [22:47:00] k [22:48:19] fr-tech: the work to move from frpm1001->frpm1002 is in process. the puppet portions are working. currently we are testing the code update and sync processes. just fyi [22:48:40] ooh, i'm going to have to teach my fingers a new servername [22:51:09] ssh config entry with a host mapping the old hostname to the new host. :) [22:51:20] heh yep, that'll do it [22:53:14] (03CR) 10Ejegg: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/883286 (owner: 10Ejegg) [22:53:53] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, and 3 others: Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4 - https://phabricator.wikimedia.org/T326372 (10Jdforrester-WMF... [22:53:59] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.40-notes (1.40.0-wmf.19; 2023-01-16): Make DonationInterface compatible with MediaWiki 1.39 - https://phabricator.wikimedia.org/T324154 (10Jdforrester-... [22:56:21] (03Merged) 10jenkins-bot: Use addGatewaySpecificResources for dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/883286 (owner: 10Ejegg) [22:56:24] (03Merged) 10jenkins-bot: Handle errors from DLocal SmartForms [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/880528 (https://phabricator.wikimedia.org/T324272) (owner: 10Damilare Adedoyin) [23:06:03] oh no is it dlocalListener or DlocalListener [23:06:09] ahahaha [23:06:30] i was holding my tongue seeing the /PaymentProviders/dlocal/ casing in SmashPig [23:06:39] when it's on a diet it's the dLoCalListener [23:06:46] groaaan [23:06:52] i'll show myself out. [23:07:08] perfect dLOCalListener [23:07:27] did you see this? https://www.theregister.com/2023/01/19/google_dns_queries/?td=rt-3a [23:07:56] "spicy formatting" [23:08:00] google is randomizing case in dns lookups (eXaMpLe.coM) to avoid cache poisoning attacks [23:08:37] hehe, yeah, nice technical term [23:09:31] i didn't realize just how easy those attacks were [23:09:36] "This is all possible because DNS servers rely on UDP – a network protocol that's faster than TCP but doesn't make guarantees about connections and is consequently more vulnerable to spoofing. It also works because DNS query IDs are 16-bit fields, meaning their possible values can range only from 0 to 65,535 – a small enough range to guess with a deluge of malicious requests." [23:10:23] so basically you just send 66k fake answers and maybe one of them is accepted because with UDP they have no idea who's actually answering! [23:19:18] ok, sniped myself with that and now it's time for dinner... [23:20:09] oh hey there are two lil smashpig patches I would love to get merged: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/882674 https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/883277 [23:25:45] ok checking [23:42:17] (03CR) 10Wfan: [C: 03+2] "Tested unit test from smashpig ./vendor/bin/phpunit --filter testGetHostedPaymentStatus. Test return ok" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882674 (https://phabricator.wikimedia.org/T312877) (owner: 10Ejegg) [23:42:50] (03Merged) 10jenkins-bot: Add full name to Ingenico hosted status response [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882674 (https://phabricator.wikimedia.org/T312877) (owner: 10Ejegg) [23:43:09] (03CR) 10Wfan: [C: 03+2] New interface to mark processor-side recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883277 (https://phabricator.wikimedia.org/T323962) (owner: 10Ejegg) [23:43:41] (03Merged) 10jenkins-bot: New interface to mark processor-side recurring [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883277 (https://phabricator.wikimedia.org/T323962) (owner: 10Ejegg) [23:44:20] fr-tech: ok from this point forward, please use frpm1002 for deployments. i'll follow up with that message in the end of day maint window email too.