[00:49:08] !log disabled pending transaction resolvers for civi deploy [00:49:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:50:05] !log civicrm upgraded from 3e6b21b6 to b5d6a790 [00:50:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:00:01] !log turned pending transaction resolvers back on after civi deploy [01:00:03] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:14:23] !log disabled fundraising scheduled jobs for queue server reboot [01:14:24] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:14:31] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, and 6 others: Creating New Matching Gift Import - https://phabricator.wikimedia.org/T303986 (10Eileenmcnaughton) I caught up with @MDemosWMF... [01:17:30] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Mismatch between the Civi refund date vs what we see at the Adyen console - https://phabricator.wikimedia.org/T326254 (10Cstone) This has been deployed. I updated the payments account report column to switch to booking date and clean... [01:24:12] !log payments-wiki upgraded from 15395d05 to 08b8c3bc (upgraded from MW 1.35 to MW 1.39) [01:24:14] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:27:20] For the new failmails, still related with the network work that caused a loss of connectivity for hosts. based on Dallas, it's expected but noisy 😃 [01:30:18] PROBLEM - check_payments_wiki on payments1007 is CRITICAL: HTTP CRITICAL: HTTP/1.1 500 Internal Server Error - string OK not found on https://payments1007.frack.eqiad.wmnet:443https://payments.wikimedia.org/index.php/Special:SystemStatus - 274 bytes in 0.017 second response time https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=payments1007&service=check_payments_wiki [01:31:14] PROBLEM - check_payments_wiki on payments1006 is CRITICAL: HTTP CRITICAL: HTTP/1.1 500 Internal Server Error - string OK not found on https://payments1006.frack.eqiad.wmnet:443https://payments.wikimedia.org/index.php/Special:SystemStatus - 274 bytes in 0.017 second response time https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=payments1006&service=check_payments_wiki [01:31:14] PROBLEM - check_payments_wiki on payments2002 is CRITICAL: HTTP CRITICAL: HTTP/1.1 500 Internal Server Error - string OK not found on https://payments2002.frack.codfw.wmnet:443https://payments.wikimedia.org/index.php/Special:SystemStatus - 274 bytes in 0.015 second response time https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=payments2002&service=check_payments_wiki [01:32:28] wfan: yeah. that was me restarting frqueue when we thought the queues were down but they actually weren't. sorry about that. [01:32:48] and ^^^ icinga alerts are known and just added a downtime for them. [01:37:07] (03PS1) 10Cstone: Change fiscal number for BR to generated example. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/883683 [01:43:14] PROBLEM - check_disk on frpm1002 is CRITICAL: DISK CRITICAL - free space: /dev 31946 MB (100% inode=99%): /run 6392 MB (99% inode=99%): / 4560 MB (65% inode=84%): /dev/shm 31968 MB (99% inode=99%): /run/lock 5 MB (100% inode=99%): /home 5394 MB (43% inode=90%): /tmp 537 MB (4% inode=99%): /var 21881 MB (82% inode=98%): /var/log 24934 MB (93% inode=99%): /var/log/audit 422 MB (99% inode=99%): /var/tmp 422 MB (99% inode=99%): /boot 323 MB [01:43:14] e=99%): /srv 243535 MB (83% inode=65%): /run/user/3609 6393 MB (100% inode=99%): /run/user/573 6393 MB (100% inode=99%): /run/user/16765 6393 MB (100% inode=99%): /run/user/3649 6393 MB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [01:48:18] RECOVERY - check_disk on frpm1002 is OK: DISK OK - free space: /dev 31946 MB (100% inode=99%): /run 6392 MB (99% inode=99%): / 4560 MB (65% inode=84%): /dev/shm 31968 MB (99% inode=99%): /run/lock 5 MB (100% inode=99%): /home 5394 MB (43% inode=90%): /tmp 12350 MB (99% inode=99%): /var 21881 MB (82% inode=98%): /var/log 24926 MB (93% inode=99%): /var/log/audit 422 MB (99% inode=99%): /var/tmp 422 MB (99% inode=99%): /boot 323 MB (76% ino [01:48:18] /srv 243416 MB (83% inode=65%): /run/user/3609 6393 MB (100% inode=99%): /run/user/573 6393 MB (100% inode=99%): /run/user/3649 6393 MB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [01:55:18] RECOVERY - check_payments_wiki on payments1007 is OK: HTTP OK: HTTP/1.1 200 OK - 500 bytes in 0.051 second response time https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=payments1007&service=check_payments_wiki [01:56:14] RECOVERY - check_payments_wiki on payments1006 is OK: HTTP OK: HTTP/1.1 200 OK - 500 bytes in 0.047 second response time https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=payments1006&service=check_payments_wiki [01:56:16] RECOVERY - check_payments_wiki on payments2002 is OK: HTTP OK: HTTP/1.1 200 OK - 500 bytes in 0.037 second response time https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=payments2002&service=check_payments_wiki [01:58:44] !log restarted fundraising scheduled jobs after queue server reboot [01:58:46] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:10:25] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/883687 [03:10:37] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/883687 (owner: 10Ejegg) [03:11:02] ok, since Ingenico is apparently already collecting the cardholder name I might as well deploy our patch to stop getting it from our form [03:13:27] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/883687 (owner: 10Ejegg) [03:13:44] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/883689 [03:13:47] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/883689 (owner: 10Ejegg) [03:14:23] (03CR) 10CI reject: [V: 04-1] Update DonationInterface submodule [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/883689 (owner: 10Ejegg) [03:14:30] oh hmm, right [03:14:41] those automatic submodule updates [03:15:28] hiiii [03:15:37] (03PS2) 10Ejegg: Update vendor and composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/883689 [03:15:45] * AndyRussG sees many patches flying by, does not read backscroll [03:16:40] oh weird, looks like our 1_39 branch of vendor is still getting tested on php7.3 [03:17:04] k, we need to ask releng to fix that [03:17:28] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Update vendor and composer.lock [core] (fundraising/REL1_39) - 10https://gerrit.wikimedia.org/r/883689 (owner: 10Ejegg) [03:27:32] !log payments-wiki upgraded from 08b8c3bc to 82d89841 [03:27:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:28:04] lol employer field must never get filled in for ingenico [03:28:23] it's under the visa/etc and once you click the card type we freeze the form [03:30:56] ok, the full_name field made it to the donations queue for that one [03:31:16] let's see if Civi does the dedupe on ingress when it comes in stuck together [03:35:50] cstone: ohhh, sorry, I had updated CiviCRM right before the payments stuff started and forgot to give you the heads-up [03:35:55] ejegg: huh isn't employer field older than Adyen? [03:36:10] also lmk if I can help with stuff [03:36:29] cstone the new audit code in SMashPig is live in Civi now [03:36:37] AndyRussG: I'm just writing my EOD email [03:37:13] ejegg: oki :) [03:37:43] also same cstone ^ am at the keyboard for a bit again, if I can help with update stuff or anything else lmk [03:38:45] (03PS3) 10Eileen: [WIP] exception for civiimport [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/883674 [03:56:13] RECOVERY - check_mysql on frdb1006 is OK: Uptime: 4954 Threads: 5 Questions: 14776 Slow queries: 0 Opens: 643 Open tables: 637 Queries per second avg: 2.982 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdb1006&service=check_mysql [04:20:31] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, and 6 others: Creating New Matching Gift Import - https://phabricator.wikimedia.org/T303986 (10Eileenmcnaughton) @MDemosWMF when I tried aga... [05:11:34] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, and 6 others: Creating New Matching Gift Import - https://phabricator.wikimedia.org/T303986 (10Eileenmcnaughton) @MDemosWMF testing locally... [10:47:46] (03PS11) 10Jgleeson: Add dlocal approvePayment call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883268 (https://phabricator.wikimedia.org/T324281) [10:48:02] gl [10:50:17] gerrit down? [10:50:23] damilare: is gerrit down for you? [10:51:04] it's back. looks like there was some alarms in wikimedia-operations [10:51:13] not really jgleeson. seems to be working fine [10:51:17] ohh [10:54:12] https://www.bbc.co.uk/news/science-environment-64411469 this is making me think of the movie greenland :O [10:54:58] "This one was only picked up last weekend by amateur astronomer Gennadiy Borisov, who operates from Nauchnyi in Crimea, the peninsula that Russia seized from Ukraine in 2014." [10:55:27] You definitely shouldn't panic but there is a biggish asteroid about to pass by Earth in the coming hours. [10:55:34] how can you NOT panic reading that lol [10:55:47] have you seen the movie Greenland damilare ? [10:56:11] it starts out with the news folks saying, don't worry it's not going to hit us and then all hell breaks loose [10:56:43] civilization collapses, looting, martial law... [10:56:46] lol wow [10:57:27] Sounbds like the similar scenes that happened in "Don't look up" [10:58:44] Haven't seen greenland but I added to my list, that's like te kind of movies I enjoy watching [10:59:18] With an estimated size of 3.5m to 8.5m across (11.5ft to 28ft), the rock would likely disintegrate high in the atmosphere. It would though produce a spectacular fireball. [10:59:20] For comparison, the famous Chelyabinsk meteor that entered Earth's atmosphere over southern Russia in 2013 was an object near 20m (66ft) across. It produced a shockwave that shattered windows on the ground. [10:59:35] space rocks are not to be taking lightly [10:59:43] taken* [10:59:44] that's scary [11:05:35] wow this is also scary damilare https://www.bbc.co.uk/news/uk-england-derbyshire-62078939 [11:05:54] I didn't know deodorant was so dangerous [11:07:02] The Royal Society for the Prevention of Accidents (RoSPA) said a number of people had died after over-spraying deodorants. [11:07:04] me neither, when you say children they might as well put an age limit as well. [11:07:30] over spraying deodorants... wtf [11:08:10] yeah they shouldn't be able to be sold to children full stop if they can kill you for "over spraying" [11:08:19] how much is over spraying? [11:08:24] exactly [11:08:33] completely stupid advice from corporate interests [11:10:52] its actually weird if you think about it that the public isn't well educated on something toxic sold at that scale. [11:11:03] 100% [11:11:16] TIL Lynx can kill me [11:11:23] I know aerosol is inflammable but I never had a limit to how much deodorant I spray on myself [11:11:44] yeah I've never heard that [12:06:41] (03PS18) 10Jgleeson: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [12:08:13] (03CR) 10CI reject: [V: 04-1] Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [12:12:48] hey damilare. just going through the code on your dlocal DI patch [12:13:09] I can see you marked this as done, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/881719/13/gateway_common/DlocalPaymentMethod.php#11, but I'm nut sure what changed [12:13:47] it looks like we're still mapping the method_id and flow in the stager [12:14:12] Ithink I deleted the file [12:14:39] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/881719/18/gateway_common/DlocalPaymentMethod.php [12:15:16] sorry looks like I pusehed an empty commit [12:25:28] sorry jgleeson I'm on a call now, not sure why that change didn't make it up. I'd check it soon as I drop off [12:37:43] no worries! [12:38:59] in other news, I've finally figured out how to run phpunit from phpstorm for payments, with test debugging!!!! [12:39:10] it's slightly hackish but it works [12:39:28] I can show you on a call later if you want [13:02:36] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Smashpig, and 2 others: Implement approvePayment for DLocal in SmashPig - https://phabricator.wikimedia.org/T324281 (10jgleeson) [13:05:26] ohh that's pretty cool. Sure I just ended the call I'm on right now, let me push up that change and we could jump on a call afterwards [13:06:06] let's do it a bit later if that's ok. I think cstone uses runs tests from the IDE too so we can wait until she's around [13:06:35] sounds perfect [13:09:46] (03PS19) 10Damilare Adedoyin: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [13:10:40] (03PS20) 10Damilare Adedoyin: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [13:12:11] (03CR) 10CI reject: [V: 04-1] Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [13:17:29] jgleeson: I've removed the rogue file. Thanks for spotting that [13:20:23] thanks! [13:26:19] damilare: so I've managed the wire up the your new dlocal patch with the latest in smashpig and I can see at the start we're getting validation failures when calling $provider->createPayment( $createPaymentParams ); [13:27:01] createPayment is expecting those two params that got removed in the staging helper [13:27:07] must be because this hasn't been merged into smasghpgi yet [13:27:09] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/883594 [13:27:22] smashpig* [13:27:22] ah ok [13:27:32] lemme see if I can stack that [13:27:44] with the other latest stuff [13:27:54] cool [13:28:08] ejegg|away: left some review on that [13:28:30] (03PS2) 10Jgleeson: Remove Payment_method and Payment_submethod from required fields in Dlocal createPayment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883594 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [13:28:41] ok that's stacked now on the latest approve payment stuff [13:28:52] I'll again [13:31:55] okk [14:47:16] PROBLEM - check_puppetrun on frdev1002 is CRITICAL: CRITICAL: Puppet has 2 failures. Last run 47 seconds ago with 2 failures. Failed resources (up to 3 shown): Mount[/srv/archive/banner_logs] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1002&service=check_puppetrun [14:52:16] PROBLEM - check_ipsec on frban1001 is CRITICAL: Strongswan CRITICAL - ok: 1 connecting: frdev1002_v4 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_ipsec [14:52:16] PROBLEM - check_puppetrun on frdev1002 is CRITICAL: CRITICAL: Puppet has 2 failures. Last run 5 minutes ago with 2 failures. Failed resources (up to 3 shown): Mount[/srv/archive/banner_logs] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1002&service=check_puppetrun [14:54:04] hey fr-tech, apparently I get no normal days this week and thus I have an errand that needs running this morning and I'll miss standup. [14:54:55] My update is that I have all my normal Thursday check-ins, and I should be back at the keyboard to check in with damilare at 9:30 [14:55:48] noted XenoRyet [14:57:12] PROBLEM - check_ipsec on frban1001 is CRITICAL: Strongswan CRITICAL - ok: 1 connecting: frdev1002_v4 https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_ipsec [15:02:12] RECOVERY - check_ipsec on frban1001 is OK: Strongswan OK - 2 ESP OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frban1001&service=check_ipsec [15:02:14] RECOVERY - check_puppetrun on frdev1002 is OK: OK: Puppet is currently enabled, last run 47 seconds ago with 0 failures https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frdev1002&service=check_puppetrun [15:40:08] 10Fundraising Tech - Chaos Crew: dLocal Safari internal errors on redirect - https://phabricator.wikimedia.org/T318744 (10AnnWF) I used my big sure mac safari tested again, which is works fine with that redirect link updated for this https://phabricator.wikimedia.org/T318742, I have used the link https://local... [15:42:58] 10Fundraising Tech - Chaos Crew: dLocal Safari internal errors on redirect - https://phabricator.wikimedia.org/T318744 (10AnnWF) a:03AnnWF [16:03:00] damilare: jgleeson|away I was going to ask about that payment_method and payment_submethod stuff as it seems more constant-y than anything we would pass through [16:03:46] yh we are no longer passing those from DI to smashpig [16:04:27] the payment_method_flow and payment_method_id would be inferred on the smashpig layer [16:05:05] yeah makes sense [16:22:16] (03PS1) 10Damilare Adedoyin: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) [16:36:24] (03PS1) 10Wfan: Add process-control and fresh to docker [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/883524 [16:42:49] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: ApplePay token amount-mismatch - https://phabricator.wikimedia.org/T324413 (10AnnWF) [16:50:05] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: ApplePay token amount-mismatch - https://phabricator.wikimedia.org/T324413 (10AnnWF) [16:55:25] 10Fundraising Tech - Chaos Crew: Broken links from Waystogive? - https://phabricator.wikimedia.org/T315268 (10AnnWF) [16:55:32] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Handle donors reaching payment forms with no payment_method - https://phabricator.wikimedia.org/T140269 (10AnnWF) [16:58:41] sorry I didn't get to review those patches yet jgleeson - deploying stuff ended up taking most of my time last night and I'm just getting started for the day now [16:59:14] no problem ejegg [17:19:19] 10Fundraising-Backlog, 10FR-Email: Click-tracking in Acoustic - https://phabricator.wikimedia.org/T316573 (10TSkaff) This is amazing, well done! [17:19:49] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Change fiscal number for BR to generated example. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/883683 (owner: 10Cstone) [17:23:33] (03Abandoned) 10Cstone: WIP: Add api calls and maintenance scripts for dlocal notifications [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/882789 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [18:44:30] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for tgorski - https://phabricator.wikimedia.org/T328062 (10Dwisehaupt) [18:45:11] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for cstone - https://phabricator.wikimedia.org/T328063 (10Dwisehaupt) [18:45:44] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sredkina - https://phabricator.wikimedia.org/T328064 (10Dwisehaupt) [18:46:14] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jjameshill - https://phabricator.wikimedia.org/T328065 (10Dwisehaupt) [18:46:45] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jmoreira - https://phabricator.wikimedia.org/T328066 (10Dwisehaupt) [18:47:13] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for hnordeen - https://phabricator.wikimedia.org/T328067 (10Dwisehaupt) [18:47:42] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for spuri - https://phabricator.wikimedia.org/T328068 (10Dwisehaupt) [18:49:09] jgleeson: ahh, so the references between objects in the earlier smashpig config was more like the yaml backreferences than actual service wiring [18:49:20] here's where it's removed: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/285317 [18:49:34] and we see that it was only used for the repeated amazon credentials array [18:49:37] back soon! [18:55:37] AndyRussG: let me know if you got time, I have another meeting in 30 mins. [18:57:20] or we can talk after that one which gonna end in next 1 hrs [19:10:14] (03CR) 10Ejegg: "Parameter mapping looks good, I'd just suggest a different path for error handling" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/881700 (https://phabricator.wikimedia.org/T324281) (owner: 10Jgleeson) [19:12:50] looking at that patch ejegg [19:12:53] DI one [19:13:11] hmm not the most helpful qualifier [19:13:21] Dependency Injection one [19:14:23] heh [19:46:26] hi wfan I just saw this message now! [19:46:43] sorry about that! [19:47:20] Np, let me know when is a good time, and we can use the stand up link 😊. [19:49:03] (03PS1) 10Jgleeson: WIP: Playing around with DI container support for classes as contructor params [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/884069 [19:49:26] (03CR) 10CI reject: [V: 04-1] WIP: Playing around with DI container support for classes as contructor params [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/884069 (owner: 10Jgleeson) [19:50:09] ejegg: I just gave that 30 minutes to see if I could transform the contructor-params into objects with a bit of recursive calling but ran into arrays going a few layers down. [19:51:17] that is a first play but I feel like the idea behind that isn't a million miles away from what the final version could do [19:51:40] effectively just type checking and treating constructor params as object to be resolved [19:51:45] objects* [19:57:26] jgleeson: heh, there are definitely a lot of cases to consider there [19:57:38] wfan: does 5 minutes from now work for you? [19:57:55] yep [19:58:18] wfan: cool thanks! [20:00:07] ejegg: I feel like the simplest case of just getting 'class:' to build an object would be a good start [20:00:35] (03PS2) 10Damilare Adedoyin: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) [20:01:31] jgleeson: did you see the comment on that dlocal error / exception treatment? [20:01:40] ah no lemme get back to that [20:02:31] I think we want to normalize those to PaymentErrors with ErrorCodes where we can [20:03:34] ejegg: that type of handling is happening in the layer above here https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/883268/11/PaymentProviders/dlocal/CardPaymentProvider.php#189 [20:04:04] I guess I was thinking if it gets to the API internals then it's exceptional [20:04:56] wfan: in the call now https://meet.google.com/ksg-mnkt-buh [20:05:15] so I tried to set designate the provider entry points as they place where we validate input and in the case where we find an issue we map it to the repsonse [20:05:16] fr-tech ^ in case anyone else wants to discuss CentralNotice flaky test :) [20:05:23] -set [20:05:58] that specific exception would be a failure to transform the params [20:06:19] whereas the one at the higher level would be intending to tell the calling code you didn't pass the right stuff in [20:06:47] granted it's confusing because it's the same param [20:08:23] if that doesn't make sense I could hop on a call to try an explain better [20:10:56] sure, let's hop on a call [20:11:22] same one as before jgleeson ? [20:11:35] I think AndyRussG and wfan are on that one [20:11:43] oh hah, ok, new one [20:11:45] let's use the social salon from earlier [20:11:51] meet.google.com/shq-oqyp-bfo [20:11:53] https://meet.google.com/kff-bmey-rsr [20:11:58] beat me to it, going to yours [20:12:25] https://meet.google.com/shq-oqyp-bfo * [20:29:37] huh, pending qc timeout? [20:30:12] ejegg: related to the origin swap perhaps. [20:30:16] ah ok [20:30:18] i'm just pulling us out of maint mode. [20:30:24] cool cool [20:30:41] we may have some things that need kicking to hit the new origin server but most should auto recover. [20:31:57] (03PS12) 10Jgleeson: Add dlocal approvePayment call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883268 (https://phabricator.wikimedia.org/T324281) [20:32:55] ejegg: I ended up doing it a bit different from what we just agreed but I think it's the same end result https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/883268/11..12/PaymentProviders/dlocal/DlocalApprovePaymentResponseFactory.php [20:36:55] 400 Bad Request 5005 User unauthorized due to cadastral situation. [20:36:58] huh? [20:49:43] oh man, don't want to get into a bad cadastral situation [20:49:46] errr [20:50:08] i think that had something to do with the user's tax ID number being on a government bad list [20:50:26] thanks jgleeson, that looks good [20:51:22] (03CR) 10Ejegg: [C: 03+2] "As discussed, we'll revisit the error handling. This looks good for the no-errors case and will let us proceed with the work!" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/881700 (https://phabricator.wikimedia.org/T324281) (owner: 10Jgleeson) [20:51:55] (03Merged) 10jenkins-bot: Add dlocal API capturePayment call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/881700 (https://phabricator.wikimedia.org/T324281) (owner: 10Jgleeson) [20:52:50] ejegg: I just realised the errors we want to map also come back to 200 http headers [20:52:59] ah fun [20:53:32] https://phabricator.wikimedia.org/P43428 [20:53:43] ah, one more tiny thing with the second patch [20:54:05] the $rawResponse is not necessarily an array, since that depends on the underlying API [20:54:13] so I guess we're ok to leave the API-http-code checking for non-200 responses as they all look like bad ones e.g. 4xx & 5xx https://docs.dlocal.com/reference/http-errors-payments [20:54:24] for example the rawResponses for the old-old adyen stuff were soap objects [20:54:34] yeah I was thinking about that ejegg when defining the abstract [20:54:37] and I think some paypal rawResponses are just a string [20:54:45] should we make it looser? [20:54:47] so let's just leave the parameter type open [20:54:49] yes please [20:54:52] ok will do [20:54:56] thanks! [20:57:12] 10Fundraising-Backlog: Update error handling for authorizePayment to handle REJECTION respones - https://phabricator.wikimedia.org/T328082 (10jgleeson) [20:57:41] I'll add some tests to cover the rejection => paymentErrors handling [20:58:55] grrr I can't link to github from phpstorm anymore L( [20:58:57] :( [20:59:14] oh man, that was so handy [20:59:25] the github mirror is there but for some reason the menu option is gone [20:59:28] wait, I think you just need to add a github remote to the repo, right? [20:59:28] yeah it was [20:59:33] lemme try [21:00:13] ohhhhh [21:00:15] it's me [21:00:42] oops lol https://phabricator.wikimedia.org/F36521667 [21:00:53] somehow I added the gerrit non-ssh as github [21:00:56] that'll do it [21:02:32] Tidal just recommended something from the "Hallelujah Chicken Run Band": https://listen.tidal.com/artist/4537306 [21:06:25] 10Fundraising-Backlog: Remove param typehint from ApprovePaymentResponseFactory::fromRawResponse(array $rawResponse) - https://phabricator.wikimedia.org/T328084 (10jgleeson) [21:07:00] ok ejegg [21:07:05] the top of my todo list for tomorrow looks like this [21:07:07] todo: [21:07:09] - do 'Update error handling for authorizePayment to handle REJECTION respones' https://phabricator.wikimedia.org/T328082 [21:07:11] - do 'Remove param typehint from ApprovePaymentResponseFactory::fromRawResponse(array $rawResponse)' https://phabricator.wikimedia.org/T328084 [21:07:25] thanks for the review! [21:07:35] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Docker: Docker: make all MediaWiki services work with Fresh - https://phabricator.wikimedia.org/T326974 (10AnnWF) [21:07:40] I'm a bit over so will skip my end of day. catch you all tomorrow o. [21:07:42] o/ [21:07:44] * [21:09:02] 10Fundraising-Backlog: Update error handling for authorizePayment to handle REJECTION respones - https://phabricator.wikimedia.org/T328082 (10jgleeson) [21:17:02] oh man, Tidal followed that Hallelujah Chicken Run Band with 'Barbie Girl' - that was a bit of a shock [21:17:25] guess I'mma just put on some Shakira [21:46:50] 10fundraising-tech-ops: reimage fundraising frdb_analytics role servers to Bullseye - https://phabricator.wikimedia.org/T315600 (10Dwisehaupt) [21:47:11] 10fundraising-tech-ops: reimage fundraising frdb_analytics role servers to Bullseye - https://phabricator.wikimedia.org/T315600 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt This was completed during the maintenance window. [21:47:13] 10fundraising-tech-ops: Fundraising environment support for Debian 11 (Bullseye) - https://phabricator.wikimedia.org/T277184 (10Dwisehaupt) [21:47:49] 10fundraising-tech-ops: reimage fundraising_database role servers to Bullseye - https://phabricator.wikimedia.org/T315601 (10Dwisehaupt) [21:49:23] 10fundraising-tech-ops: install/configure frpm1002 - https://phabricator.wikimedia.org/T299069 (10Dwisehaupt) [22:06:02] hey wfan I'm back from picking up my daughter... sorry again for the interruption! pls let me know if you have more questions, if you would like to continue looking at that ticket together, or if I can help in any other way [22:07:38] 10fundraising-tech-ops: install/configure frpm1002 - https://phabricator.wikimedia.org/T299069 (10Dwisehaupt) pfw changes tasked as T328085 [22:07:43] (03CR) 10Ejegg: [C: 03+2] "Looks good! We'll loosen up that $rawResponse type in a follow-on patch" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883268 (https://phabricator.wikimedia.org/T324281) (owner: 10Jgleeson) [22:08:18] (03Merged) 10jenkins-bot: Add dlocal approvePayment call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883268 (https://phabricator.wikimedia.org/T324281) (owner: 10Jgleeson) [22:09:28] Hi Andy, I still hope we can have the local fresh env setup for npm quint test, and if you can also take a look see if you can make that works locally. otherwise I think I use Gerrit to test if able to catch the fail sounds ok with me. [22:10:10] (03PS3) 10Ejegg: Remove Payment_method and Payment_submethod from required fields in Dlocal createPayment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883594 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [22:10:21] (03CR) 10Ejegg: [C: 03+2] Remove Payment_method and Payment_submethod from required fields in Dlocal createPayment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883594 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [22:10:53] (03Merged) 10jenkins-bot: Remove Payment_method and Payment_submethod from required fields in Dlocal createPayment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883594 (https://phabricator.wikimedia.org/T324279) (owner: 10Damilare Adedoyin) [22:11:16] wfan: yeah I'm thinking the same thing [22:11:41] I'll try looking at it a bit more this afternoon/evening for sure :) [22:14:42] Thanks Andy, I add the quint link to that fresh installation ticket. I think this part is the most important reasons why we wants fresh env [22:17:19] (03PS1) 10Ejegg: Allow any type for $rawResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/884104 (https://phabricator.wikimedia.org/T328084) [22:21:26] (03PS3) 10Ejegg: Rename 'token' params in PayPal API calls [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883651 (https://phabricator.wikimedia.org/T324642) [22:23:52] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Mismatch between the Civi refund date vs what we see at the Adyen console - https://phabricator.wikimedia.org/T326254 (10Cstone) Confirming that everything is looking good with the column change, refunds coming in on the nightly audi... [22:25:15] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10Patch-For-Review: Remove param typehint from ApprovePaymentResponseFactory::fromRawResponse(array $rawResponse) - https://phabricator.wikimedia.org/T328084 (10Ejegg) [22:27:37] 10Fundraising-Backlog, 10fundraising-tech-ops, 10FR-Tech-Analytics: Fundraising superset may need the request length tuned - https://phabricator.wikimedia.org/T324067 (10Dwisehaupt) 05Open→03Resolved a:03Dwisehaupt 1.5.3 and bullseye upgrade has completed. Bumped to "limit_request_line = 5120" and test... [22:29:53] 10fundraising-tech-ops: reimage fundraising build (frpm) role servers to Bullseye - https://phabricator.wikimedia.org/T305972 (10Dwisehaupt) [22:31:23] (03CR) 10Wfan: [C: 03+2] Allow any type for $rawResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/884104 (https://phabricator.wikimedia.org/T328084) (owner: 10Ejegg) [22:31:31] thanks wfan [22:31:58] (03Merged) 10jenkins-bot: Allow any type for $rawResponse [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/884104 (https://phabricator.wikimedia.org/T328084) (owner: 10Ejegg) [22:33:24] (03PS4) 10Ejegg: Rename 'token' params in PayPal API calls [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883651 (https://phabricator.wikimedia.org/T324642) [22:34:35] thanks wfan yes agreed [22:49:46] (03CR) 10Wfan: Check for success on getStatus call (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/883670 (owner: 10Ejegg) [23:02:20] (03CR) 10Wfan: "LGTM, just realized we have PAYMENTREQUEST_n_DESC as optional, but PAYMENTREQUEST_n_PAYMENTREASON is not even one of the request field" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883651 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [23:23:29] AndyRussG: I actually think https://phabricator.wikimedia.org/T214140 this ticket still valid, that both mediawiki and our donut got this 0 test warning~ with Task "karma:main" failed [23:34:07] (03CR) 10Ejegg: [C: 04-1] "This is looking pretty good! Some suggestions inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [23:37:57] oh nice find wfan [23:38:26] also I'm wondering, so composer fix and fix php lint errors, but does it detect and/or fix javascript lint errors? [23:38:34] if not, that would be another justification for Fresh [23:56:09] (03CR) 10Wfan: [C: 03+2] "LGTM" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/883669 (owner: 10Ejegg)