[00:11:49] (03Merged) 10jenkins-bot: Put resolvable methods in one place [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/883669 (owner: 10Ejegg) [00:35:00] (03PS4) 10Wfan: Do not just check deadline exist before get timeRemaining from it to avoid undefined [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/881385 (https://phabricator.wikimedia.org/T318103) [00:35:03] (03PS1) 10Cstone: Add CZ for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884139 (https://phabricator.wikimedia.org/T323715) [00:36:49] (03CR) 10CI reject: [V: 04-1] Add CZ for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884139 (https://phabricator.wikimedia.org/T323715) (owner: 10Cstone) [00:53:25] (03CR) 10Wfan: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/881385 (https://phabricator.wikimedia.org/T318103) (owner: 10Wfan) [01:43:16] PROBLEM - check_disk on frpm1002 is CRITICAL: DISK CRITICAL - free space: /dev 31946 MB (100% inode=99%): /run 6392 MB (99% inode=99%): / 4560 MB (65% inode=84%): /dev/shm 31968 MB (99% inode=99%): /run/lock 5 MB (100% inode=99%): /home 5393 MB (43% inode=90%): /tmp 609 MB (4% inode=99%): /var 21729 MB (81% inode=98%): /var/log 24374 MB (91% inode=99%): /var/log/audit 422 MB (99% inode=99%): /var/tmp 422 MB (99% inode=99%): /boot 323 MB [01:43:16] e=99%): /srv 240007 MB (82% inode=64%): /run/user/3609 6393 MB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [01:43:31] oh heck, PaymentActionNotInitiated totally does not mean what I thought it meant [01:44:01] So we get taht CheckoutStatus back from the payment after they donor has clicked the accept button [01:44:33] I suspect we have never successfully rectified a paypal orphan [01:44:56] so we could just delete the paypal orphan rectifier and call it no loss of functionality [01:46:29] ok, let's see what else we can use in the response to determine whether the donor has accepted [01:48:16] PROBLEM - check_disk on frpm1002 is CRITICAL: DISK CRITICAL - free space: /dev 31946 MB (100% inode=99%): /run 6392 MB (99% inode=99%): / 4560 MB (65% inode=84%): /dev/shm 31968 MB (99% inode=99%): /run/lock 5 MB (100% inode=99%): /home 5393 MB (43% inode=90%): /tmp 0 MB (0% inode=99%): /var 21729 MB (81% inode=98%): /var/log 24373 MB (91% inode=99%): /var/log/audit 422 MB (99% inode=99%): /var/tmp 422 MB (99% inode=99%): /boot 323 MB (7 [01:48:16] 99%): /srv 240007 MB (82% inode=64%): /run/user/3609 6393 MB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [01:52:43] (03CR) 10Wfan: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/881385 (https://phabricator.wikimedia.org/T318103) (owner: 10Wfan) [01:53:16] RECOVERY - check_disk on frpm1002 is OK: DISK OK - free space: /dev 31946 MB (100% inode=99%): /run 6392 MB (99% inode=99%): / 4560 MB (65% inode=84%): /dev/shm 31968 MB (99% inode=99%): /run/lock 5 MB (100% inode=99%): /home 5393 MB (43% inode=90%): /tmp 12350 MB (99% inode=99%): /var 21729 MB (81% inode=98%): /var/log 24365 MB (91% inode=99%): /var/log/audit 422 MB (99% inode=99%): /var/tmp 422 MB (99% inode=99%): /boot 323 MB (76% ino [01:53:16] /srv 240007 MB (82% inode=64%): /run/user/3609 6393 MB (100% inode=99%): /run/user/3649 6393 MB (100% inode=99%): https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frpm1002&service=check_disk [01:54:06] huh, something wrote a dozen gigs to /tmp on frpm? [02:05:35] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog: Remove param typehint from ApprovePaymentResponseFactory::fromRawResponse(array $rawResponse) - https://phabricator.wikimedia.org/T328084 (10Ejegg) 05Open→03Resolved a:03Ejegg [02:30:03] (03PS1) 10Ejegg: Fix dumb assumption about CheckoutStatus [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884146 [02:50:24] (03PS1) 10Ejegg: Fix PaymentActionNotInitiated status mapping [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/884147 (https://phabricator.wikimedia.org/T324642) [02:50:48] (03CR) 10CI reject: [V: 04-1] Fix PaymentActionNotInitiated status mapping [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/884147 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [02:56:41] (03PS2) 10Ejegg: Fix PaymentActionNotInitiated status mapping [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/884147 (https://phabricator.wikimedia.org/T324642) [03:18:44] (03PS2) 10Ejegg: Check for success on getStatus call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/883670 [03:18:46] (03PS1) 10Ejegg: Allow info from status call to overwrite blank keys [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/884148 (https://phabricator.wikimedia.org/T324642) [03:18:48] (03PS1) 10Ejegg: Make pending txn resolver work for PayPal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/884149 (https://phabricator.wikimedia.org/T324642) [03:22:39] (03PS2) 10Ejegg: Make pending txn resolver work for PayPal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/884149 (https://phabricator.wikimedia.org/T324642) [03:32:42] (03CR) 10CI reject: [V: 04-1] Make pending txn resolver work for PayPal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/884149 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [03:34:17] (03CR) 10CI reject: [V: 04-1] Allow info from status call to overwrite blank keys [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/884148 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [03:37:40] (03CR) 10CI reject: [V: 04-1] Make pending txn resolver work for PayPal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/884149 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [03:52:59] (03PS2) 10Ejegg: Allow info from status call to overwrite blank keys [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/884148 (https://phabricator.wikimedia.org/T324642) [03:53:01] (03PS3) 10Ejegg: Make pending txn resolver work for PayPal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/884149 (https://phabricator.wikimedia.org/T324642) [04:07:51] (03CR) 10CI reject: [V: 04-1] Make pending txn resolver work for PayPal [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/884149 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [04:13:45] not I (wrt writing stuff on /tmp) [04:14:02] at one point three were web logs put there for examination for some ticket IIRC [10:33:59] (03PS2) 10Jgleeson: Fix accidental assumption about CheckoutStatus [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884146 (owner: 10Ejegg) [10:41:43] (03CR) 10Jgleeson: [C: 03+2] "LGTM. Good spot!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884146 (owner: 10Ejegg) [10:43:21] (03Merged) 10jenkins-bot: Fix accidental assumption about CheckoutStatus [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884146 (owner: 10Ejegg) [10:44:17] (03PS3) 10Jgleeson: Fix PaymentActionNotInitiated status mapping [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/884147 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [11:18:43] damilare: let's make these strings constants somewhere https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/883594/3/PaymentProviders/dlocal/CardPaymentProvider.php#21 [11:18:55] and move them out of the createPayment [11:19:07] in an effort to keep all the transformation stuff together [11:19:55] (03PS3) 10Damilare Adedoyin: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) [11:21:08] sure jgleeson, I also made some transformation changes on this patch https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/883985 [11:31:50] thanks damilare I'll check it out now [11:32:00] also trying to wrap up review on your other patch [11:32:45] ok thanks! [11:53:56] (03PS4) 10Damilare Adedoyin: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) [12:14:06] (03PS5) 10Damilare Adedoyin: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) [12:14:30] (03CR) 10CI reject: [V: 04-1] Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) (owner: 10Damilare Adedoyin) [12:22:56] (03PS6) 10Damilare Adedoyin: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) [13:52:17] (03PS7) 10Damilare Adedoyin: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) [13:52:58] (03PS21) 10Damilare Adedoyin: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [13:54:40] (03CR) 10CI reject: [V: 04-1] Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [14:04:39] (03CR) 10Jgleeson: [C: 04-1] "This is working for me. I'm can put through a successful transaction when using the latest SmashPig code. On the whole it looks really goo" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [14:34:47] (03CR) 10Jgleeson: "It looks like we just need to update this line to be AdyenCheckoutGateway https://github.com/wikimedia/mediawiki-extensions-DonationInterf" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884139 (https://phabricator.wikimedia.org/T323715) (owner: 10Cstone) [14:38:12] (03PS22) 10Damilare Adedoyin: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [14:52:13] (03CR) 10AndyRussG: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/881385 (https://phabricator.wikimedia.org/T318103) (owner: 10Wfan) [14:52:16] (03PS1) 10Jgleeson: Map GatewayTxnId to Response during ApprovePayment call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/884321 (https://phabricator.wikimedia.org/T324281) [15:02:45] (03PS23) 10Damilare Adedoyin: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [15:05:57] (03CR) 10Damilare Adedoyin: "Thanks ejegg and jgleeson for the review. I made some changes and commented on some. Please see comments inline." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [16:09:10] (03CR) 10Jgleeson: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig (031 comment) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) (owner: 10Damilare Adedoyin) [17:00:18] (03PS2) 10Cstone: Add CZ for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884139 (https://phabricator.wikimedia.org/T323715) [17:06:43] (03CR) 10Wfan: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/881385 (https://phabricator.wikimedia.org/T318103) (owner: 10Wfan) [17:08:13] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Docker: fundraising-dev: email prefs showing internal error after fresh install - https://phabricator.wikimedia.org/T327480 (10AnnWF) a:03AnnWF [17:08:47] (03CR) 10CI reject: [V: 04-1] Do not just check deadline exist before get timeRemaining from it to avoid undefined [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/881385 (https://phabricator.wikimedia.org/T318103) (owner: 10Wfan) [17:14:03] 10Fundraising-Backlog: Batch account updater support for Adyen - https://phabricator.wikimedia.org/T328151 (10EMartin) [17:17:37] (03CR) 10Wfan: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/881385 (https://phabricator.wikimedia.org/T318103) (owner: 10Wfan) [17:36:59] (03CR) 10Wfan: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/881385 (https://phabricator.wikimedia.org/T318103) (owner: 10Wfan) [17:52:48] (03PS8) 10Damilare Adedoyin: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) [17:56:24] (03CR) 10Damilare Adedoyin: "Good spot, thanks jgleeson" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) (owner: 10Damilare Adedoyin) [18:12:57] Sorry damilare I completely missed that you'd marked all those comments as resolved [18:13:18] np [18:13:20] I started looking at the updates as soon as you pushed the patch so missed the follow-on comment [18:13:38] only added a comment on 1 of yours and 1 of ejegg's [18:15:21] fr-tech I'm gonna go eat soon. Do folks wanna see how to get phpunit for payments running in phpstorm? If not I can demo it on tech-talk or something next week [18:16:52] next week sounds good jgleeson [18:17:11] awesome [18:17:13] tech-talk might be better, since every one would be on the call [18:17:14] let's do it during tech-talk! [18:17:20] ^^ [18:17:20] thanks [18:33:10] (03CR) 10Wfan: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/881385 (https://phabricator.wikimedia.org/T318103) (owner: 10Wfan) [18:46:46] (03CR) 10Wfan: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/881385 (https://phabricator.wikimedia.org/T318103) (owner: 10Wfan) [19:04:25] (03CR) 10Jgleeson: [C: 03+2] "Test with gateway form chooser and was able to put donation through with test card. LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884139 (https://phabricator.wikimedia.org/T323715) (owner: 10Cstone) [19:09:38] (03CR) 10Jgleeson: "Thanks for the updates!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [19:10:08] 10Fundraising-Backlog: JP forms 2223 testing issue - https://phabricator.wikimedia.org/T328161 (10EMartin) [19:15:39] (03Merged) 10jenkins-bot: Add CZ for Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884139 (https://phabricator.wikimedia.org/T323715) (owner: 10Cstone) [19:19:00] (03CR) 10Wfan: "recheck" [extensions/CentralNotice] - 10https://gerrit.wikimedia.org/r/881385 (https://phabricator.wikimedia.org/T318103) (owner: 10Wfan) [19:44:25] (03CR) 10Jgleeson: [C: 04-1] "This looking good! I haven't tested it yet but I had a few comments after reading through the code." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) (owner: 10Damilare Adedoyin) [20:00:24] have a good weekend all. bye for now o/ [20:11:45] good night and have a good weekend~ [21:58:02] 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Diffusion-Repository-Administrators, and 5 others: Archive the fundraising/crm/civicrm repo - https://phabricator.wikimedia.org/T324732 (10demon) [22:04:04] 10Fundraising-Backlog, 10Python3-Porting: modernize DjangoBannerStats to python3 - https://phabricator.wikimedia.org/T301905 (10Jgreen) There is a functional test environment on frdev1002. I've done a bunch of work on LoadBannerImpressions2Aggregate and LoadLPImpressions which are the only subcommands we seem... [22:41:49] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Update SmashPig currency rates - https://phabricator.wikimedia.org/T326671 (10HNordeenWMF) looks like these have been deployed!! @Pcoombe I've updated our hard minimums to match this: https://meta.wikimedia.org/w/index.php?title=MediaWiki%3AFundraisingBa... [23:56:20] (03PS9) 10Damilare Adedoyin: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) [23:58:05] (03CR) 10Damilare Adedoyin: "thanks jgleeson, all comments resolved" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) (owner: 10Damilare Adedoyin)