[00:56:19] 10Fundraising Tech - Chaos Crew, 10MediaWiki-extensions-CLDR, 10ci-test-error (WMF-deployed Build Failure): quibble-fundraising-cldr-REL1_39-php74-docker failure on CLDR master - https://phabricator.wikimedia.org/T328240 (10Reedy) [00:56:28] 10Fundraising Tech - Chaos Crew, 10MediaWiki-extensions-CLDR, 10ci-test-error (WMF-deployed Build Failure): quibble-fundraising-cldr-REL1_39-php74-docker failure on CLDR master - https://phabricator.wikimedia.org/T328240 (10Reedy) p:05Triage→03High [01:22:27] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] "Cool! Thanks!!!!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/881833 (owner: 10Jgleeson) [01:36:12] (03Abandoned) 10AndyRussG: Update .gitignore to ignore hidden files [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/804763 (owner: 10AndyRussG) [01:41:57] (03PS1) 10AndyRussG: Donut: Enable JS tests and remove setting [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884484 (https://phabricator.wikimedia.org/T326974) [04:04:30] (03PS1) 10AndyRussG: Donut: Use /w for $wgScriptPath [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884520 (https://phabricator.wikimedia.org/T326974) [04:31:45] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Docker, 10Patch-For-Review: Docker: make all MediaWiki services work with Fresh - https://phabricator.wikimedia.org/T326974 (10AndyRussG) Two attached patches (the second one was somehow not added by gerritbot): - [[ https://gerrit.wikimedia.org/... [04:45:31] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10JavaScript, and 2 others: flaky qunit test in CentralNotice: Uncaught TypeError: Cannot read property 'timeRemaining' of undefined - https://phabricator.wikimedia.org/T318103 (10AndyRussG) While I'm still unable... [04:48:46] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10JavaScript, and 2 others: flaky qunit test in CentralNotice: Uncaught TypeError: Cannot read property 'timeRemaining' of undefined - https://phabricator.wikimedia.org/T318103 (10AndyRussG) [05:06:50] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Community-Wishlist-Survey-2016: CentralNotice moves content down when a link to a heading is followed - https://phabricator.wikimedia.org/T28234 (10Tgr) This is more-or-less the same as {T52865}, except the specific issue with anchors shouldn't b... [05:07:19] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Community-Wishlist-Survey-2016: CentralNotice moves content down when a link to a heading is followed - https://phabricator.wikimedia.org/T28234 (10Tgr) [05:07:27] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CentralNotice shifts down page content on load (causes mis-clicks) - https://phabricator.wikimedia.org/T52865 (10Tgr) [05:10:03] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CentralNotice shifts down page content on load (causes mis-clicks) - https://phabricator.wikimedia.org/T52865 (10Tgr) [05:12:23] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice: CentralNotice shifts down page content on load (causes mis-clicks) - https://phabricator.wikimedia.org/T52865 (10Tgr) [05:12:56] 10Fundraising-Backlog, 10MediaWiki-Interface, 10MediaWiki-Page-editing, 10MediaWiki-extensions-CentralNotice, and 3 others: Content jumps after JavaScript is loaded - https://phabricator.wikimedia.org/T138177 (10Tgr) The patch is merged and otherwise this doesn't seem to add much to {T52865}. [05:13:07] 10Fundraising-Backlog, 10MediaWiki-Interface, 10MediaWiki-Page-editing, 10MediaWiki-extensions-CentralNotice, and 3 others: Content jumps after JavaScript is loaded - https://phabricator.wikimedia.org/T138177 (10Tgr) [05:16:27] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Spike: Spike: CentralNotice: How can we better monitor/provide tools/collaborate to prevent errors in banners? - https://phabricator.wikimedia.org/T165686 (10Tgr) We have JS error logging these days (#instrument-clienterror) so probably just need... [05:16:59] 10Wikimedia-Fundraising-Banners, 10Instrument-ClientError, 10MW-1.40-notes (1.40.0-wmf.3; 2022-09-26): Tag errors where a banner is being displayed - https://phabricator.wikimedia.org/T265096 (10Tgr) 05Open→03Resolved a:03Tgr Nothing left here to do, I think. [05:19:21] 10Wikimedia-Fundraising-Banners, 10Instrument-ClientError, 10MW-1.40-notes (1.40.0-wmf.3; 2022-09-26): Tag errors where a banner is being displayed - https://phabricator.wikimedia.org/T265096 (10Tgr) Except that per {T319498} it is somewhat broken, but let's follow up on that there. [05:20:07] 10Wikimedia-Fundraising-Banners, 10Instrument-ClientError, 10MW-1.40-notes (1.40.0-wmf.3; 2022-09-26): Tag errors where a banner is being displayed - https://phabricator.wikimedia.org/T265096 (10Tgr) [06:38:27] (03PS1) 10AndyRussG: Donut: add logger config [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884546 [06:48:40] (03PS1) 10AndyRussG: Donut: set fake GeoIP cookie in Apache [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884721 [08:49:21] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Japan, and 3 others: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10CDenes_WMF) Thank you @Ejegg ! Exciting stuff. Yukari, Seilo, and Ichi all reviewed. Ju... [12:57:01] (03PS10) 10Damilare Adedoyin: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) [13:40:10] (03CR) 10Jgleeson: "I was just running tests locally and noticed the O." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [13:49:24] (03PS24) 10Damilare Adedoyin: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [13:56:01] (03CR) 10Damilare Adedoyin: "good catch. thanks jgleeson" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [14:30:28] (03PS1) 10Jgleeson: WIP: Handle submission for DLocal REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) [14:31:02] (03PS2) 10Jgleeson: WIP: Handle submission for DLocal REDIRECT methods in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884899 (https://phabricator.wikimedia.org/T324291) [15:24:50] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jmoreira - https://phabricator.wikimedia.org/T328066 (10Dwisehaupt) SSL cert renewed and sent via email. Password sent via SMS. [15:56:01] (03CR) 10Damilare Adedoyin: [C: 03+2] Map GatewayTxnId to Response during ApprovePayment call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/884321 (https://phabricator.wikimedia.org/T324281) (owner: 10Jgleeson) [15:56:38] (03Merged) 10jenkins-bot: Map GatewayTxnId to Response during ApprovePayment call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/884321 (https://phabricator.wikimedia.org/T324281) (owner: 10Jgleeson) [16:06:43] (03CR) 10Damilare Adedoyin: [C: 03+2] Donut: add logger config [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884546 (owner: 10AndyRussG) [16:07:23] (03CR) 10Damilare Adedoyin: [C: 03+2] Donut: set fake GeoIP cookie in Apache [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884721 (owner: 10AndyRussG) [16:20:46] thanks damilare [16:21:25] np [16:37:57] (03CR) 10Damilare Adedoyin: [V: 03+2 C: 03+2] Donut: set fake GeoIP cookie in Apache [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884721 (owner: 10AndyRussG) [16:38:12] (03CR) 10Damilare Adedoyin: [V: 03+2 C: 03+2] Donut: add logger config [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884546 (owner: 10AndyRussG) [16:40:51] (03PS1) 10Damilare Adedoyin: Run composer install from /w directory. [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884959 [16:42:34] hi AndyRussG, looks like the donut user has limited privilege in the doocker container [16:43:30] during setup.sh run, I get this composer error: ndraising/dev] - https://gerrit.wikimedia.org/r/884721 (owner: AndyRussG) [16:43:31] │16:12:18 <-- | Jeff_Green (~ [16:43:51] ? [16:44:06] sorry.... not sure where that came from [16:44:08] damilare: hii hmm oki checking [16:44:14] ha! [16:44:20] AndyRussG: here's the error: /var/www/html/cache/composer/vcs does not exist and could not be created [16:44:21] also hii fr-tech :) :) :) [16:44:31] hey AndyRussG [16:44:38] hello AndyRussG [16:44:58] damilare: ohhhh hmm are you running on the unmerged patch? that might be an error then [16:45:03] hey AndyRussG [16:45:15] nah I did on that and also in Master [16:45:32] huh oki gonna check, thx! [16:45:36] I was thinking maybe you had seen the error before and managed it [16:45:48] nooo but I think I know a possible cause [16:45:50] I tried chmod -R 777 on /var/www [16:46:04] but I didn't have the privilege :) [16:46:08] ohh cool [16:46:22] yeah that directory is owned by the container root user [16:46:46] I needed a password to switch user too [16:46:46] (if you want you can also go into the container as root user, just with the -u 0 flag when you open a shell, but you shouldn't have to) [16:47:00] yh it requested for a password [16:47:13] docker-compose exec -u 0 donut bash [16:47:30] oh let me try this [16:47:32] should give you a root shell in the donut (or any other) container [16:47:40] but it shouldn't be necessary, so it does sound like abug [16:48:20] damilare: could be that you were on the newest patch, then you didn't do dc down and dc up again before moving back to master? [16:48:56] ohh doesn't setup.sh do that at the initial stages [16:49:15] damilare: if you tell it not to destroy the containers, it only does dc stop [16:49:36] and so probably inside the container you have your donut source mounted at /var/www/html/w/ [16:49:36] ok let me do that and try again [16:49:43] which is the new location [16:50:12] on the unmerged patch, in line with the production Wikis and also stock MediaWiki docker setup [16:50:36] whereas on other containers, in line with Payments production, we omit the last w/ directory [16:51:09] damilare: also thanks so much for digging in and for the review!!!! :) :) [16:51:18] np [16:51:25] also just gonna update the commit message on one of those yet unmerged patches [16:51:49] does that mean we may not have to use this https://gerrit.wikimedia.org/r/884959 [16:54:05] ohh ok, I see what you mean now [16:54:17] AndyRussG: I was looking at that aearlier after wondering why we had set payments up differently. I think the stock Mediawiki docker compose is mounting to /var/www/html although it is recommended to put it in a mediawiki or 'w' dir like you say [16:54:40] AndyRussG: why are we using the w dir? [16:54:59] damilare: ah that patch is excellent, thank you, yes that should fix it [16:55:22] nice! [16:55:29] jgleeson: damilare: the Payments docker service is mounted to mirror the way Payments production is installed, without the w/ [16:56:02] and the new Donut patch moves Donut docker service to be mounted with the w/, to mirror Donate Wiki and all the wikis that run CentralNotice [16:56:19] https://github.com/wikimedia/mediawiki/blob/ea37b78f148b089246532cf88ae57b6e36df78dc/docker-compose.yml#L14 [16:56:37] the change also means you can go to https://localhost:9010/wiki/Page_Name, like on the production wikis [16:56:41] on Donut [16:57:04] this allows a bunch of links inside the Donut forms, generated by content downloaded from Donate wiki prod, to work correctly [16:57:29] and also I was hoping would fix the Fresh tool on Donut, though that did not happen [16:58:30] The change on Donut would also allow you to directly copy and paste a link to any form or a template from Donate Wiki, replace the host name with localhost:9010, and it should work locally [16:59:03] does that make sense? if folks object, I'm not adamant about the change, but it seems correct. had previously been discussed informally with ejegg on a previous Gerrit change also [16:59:52] AndyRussG: makes sense to me to follow the recommended settings [17:00:01] sounds good to me if it mirrors prod [17:01:59] oki cool! [17:02:04] thx :) :) [17:02:33] AndyRussG: ah, i see you made that donut config change. Thanks! [17:02:52] Looks like the docs mention both a 'mediawiki' dir within the webserver root and a 'w' dir. The medaiwiki default docker stuff however installs it to the root [17:02:56] :) thank u ejegg [17:03:04] (03CR) 10Ejegg: Handle card submission in DLocal in DonationInterface (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [17:03:10] fr-tech k just lemme update ccommit messages there though [17:05:10] AndyRussG: do all Canadians listen to Stan Rogers, or just those from the coastal provinces? [17:05:21] never heard of him? [17:05:32] anilk might know better [17:05:58] anilk: ^^^ Stan Rogers fan? [17:06:07] if he's an announcer/interviewer on CBC radio, then maybe yes [17:06:11] AndyRussG: he does sea chanties [17:06:27] hmmm then no [17:06:40] just recalling the voice of mid-morning radio during my youth: https://en.wikipedia.org/wiki/Peter_Gzowski [17:06:57] https://en.wikipedia.org/wiki/Stan_Rogers [17:07:47] I've had "Barrett's Privateers" running through my head all day [17:08:30] (03PS2) 10AndyRussG: Donut: Enable JS tests and remove setting [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884484 (https://phabricator.wikimedia.org/T326974) [17:10:59] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Docker: fundraising-dev: email prefs showing internal error after fresh install - https://phabricator.wikimedia.org/T327480 (10AnnWF) This is expected, that we now needs to have param with emailPreferences, checksum and contact_id. like https://loc... [17:14:41] damilare: would you be ok if I integrate https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/884959/ into the preceding Donut script path change? seems part of the same change? [17:15:10] yh sure np AndyRussG [17:15:29] damilare: oki thanks so much! and thanks for finding that :) :) [17:16:14] also found COMPOSER_CACHE_DIR=/var/www/html/cache/composer in docker-compose.yml, which I also just added the w to [17:16:45] cool! [17:18:06] mmm also have to update the container directory for install.php and update.php in setup.sh [17:18:43] and for the import scripts [17:27:38] (03PS2) 10AndyRussG: Donut: Use /w for $wgScriptPath [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884520 (https://phabricator.wikimedia.org/T326974) [17:29:07] (03PS2) 10AndyRussG: Donut: set fake GeoIP cookie in Apache [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884721 [17:29:30] ^ oki all fixed comit-message-updated and rebased [17:35:57] (03PS25) 10Damilare Adedoyin: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [17:37:16] 10fundraising-tech-ops: install/configure frpm1002 - https://phabricator.wikimedia.org/T299069 (10Dwisehaupt) [17:38:26] 10fundraising-tech-ops: install/configure frpm1002 - https://phabricator.wikimedia.org/T299069 (10Dwisehaupt) 05Open→03Resolved Closing out the build task. Any new issues should be opened in a new task. [17:39:16] (03PS3) 10AndyRussG: Donut: set fake GeoIP cookie in Apache [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884721 [17:39:50] (03CR) 10Damilare Adedoyin: Handle card submission in DLocal in DonationInterface (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [17:40:21] (03PS26) 10Damilare Adedoyin: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) [17:44:49] 10Fundraising-Backlog: JP forms 2223 testing issue - https://phabricator.wikimedia.org/T328161 (10RKumar_WMF) Another example: {F36556145} I can see the transaction for JPY 300 with error reference number 157787367.1 successful in Adyen console as well as Civi. CID: 51194107. PSP Reference: MBHBR5N58BK4K472. [17:44:53] setup.sh seems to work now btw! [17:45:28] (also rebased the GeoIP patch, since it has changes right next to the apache changes for the script path) [17:46:48] great, trying it now AndyRussG [17:49:04] damilare: cool! for the first questions, I'd recommend saying "yes" to the "Remove any existing containers" question, but then saying "no" to "Reset persistent storage" (since saying yes to the latter would make you have to rebuild Civi) [17:49:55] oops I said yes to both, Civi would be a future pain then [17:50:08] ooops sorry :| [17:50:15] (03PS1) 10Wfan: Default emailPreference template to emailPreferences [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884543 (https://phabricator.wikimedia.org/T327480) [17:50:58] the reason setup.sh asks the first question is that sometimes folks might have custom changes in the ephemeral storage layer of a container, which is destroyed every time you do dc down and up [17:51:25] I keep wondering if completely disabling xdebug during the Civi install process would speed it up on the Mac [17:52:14] there would be a way to try that out by opening a root shell on the container from another terminal just before doing the civi rebuild, and directly modifying the php cli settings [17:52:16] well probably, I could try it on my next run [17:52:35] if it helps we could integrate it into setup.sh [17:53:12] sure, you could put up a patch which I would run civi setup on [17:53:12] another thing I've been trying is adding xdebug.log_level=0 to the exposed xdebug config for containers on xdebug3 [17:53:40] AndyRussG: oho, almost definitely would help! [17:53:54] (disabling during install) [17:54:10] damilare: ejegg: hmmm it would take some fiddling to automate it, wondering if it might be best to test it manually first? [17:54:17] but yeah, maybe just disabling xdebug logging would be enough [17:54:32] since it's the FS writes that are the biggest drag on mac [17:54:41] ejegg: well turning xdebug off completely can't hurt, either, no? [17:55:14] in any case I imagine it could be automated to turn it all off during setup.sh without changing the base images [17:55:19] right right, when you actually want to debug setup you can turn it back on [17:55:56] hmm I was thinking a temporary hack by running a script inside the container to do so [17:56:10] though then the danger would be if setup.sh dies midway you'd get stuck with that [17:57:38] probably some docker-compose.yml extra file magic would be better [17:58:37] as in, somehow during setup run the container with an extra docker-compose setting that overwrites the php cli settings, so that when you do a normal dc up you don't get that? still feels hacky tho [18:02:21] AndyRussG ejegg I'm afraid I am ignorant of Stan Rogers [18:02:32] 10Fundraising-Backlog, 10FR-Sweden: Sweden currently processing through Ingenico instead of Adyen - https://phabricator.wikimedia.org/T304161 (10TSkaff) [18:02:37] awww [18:02:41] gonna look him up now [18:03:16] anilk: do you remember Peter Gzowski or was he before your time? [18:03:39] Oh yeah, a little on CBC [18:04:37] it was my mid-morning getting-up-late-'cause-I-didn't-have-class-yet listen during university times [18:05:08] 10Fundraising-Backlog: Transaction not found in Adyen. Error Reference 157787384.1 - https://phabricator.wikimedia.org/T328344 (10RKumar_WMF) [18:07:02] ejegg: if you really want to know you can ask the #canada WMF Slack channel [18:07:56] * AndyRussG analogously teases ejegg for only ever having eaten Boston baked beans from a can [18:09:33] heh [18:14:27] thanks for the review AndyRussG [18:18:12] thank u jgleeson :) [18:18:46] ejegg: in the Donut config, does the special setting of Mediawiki:Mainpage come from production? [18:19:34] I was having trouble getting to a page where I could test a banner, since they don't show up on special pages, and many of the pages on Donut are styled like the WMF site, and cause normal banners to be hidden because of some css thing [18:19:39] (03PS1) 10Ejegg: Switch SE forms to Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884986 (https://phabricator.wikimedia.org/T304161) [18:19:50] in the end I ended up testing on Mediawiki:Mainpage itself hehe [18:20:28] cstone: ok, there's the SE switcheroo ^^ [18:20:41] AndyRussG: oh yeah, I think that's from production [18:21:21] So let's add a couple more links - there should be some 'normal' content pages on donut I think [18:21:43] or are FAQ / other ways / etc all served via a specialpage? [18:22:12] https://localhost:9010/index.php/Support_pages is a nice index [18:22:13] (03CR) 10Cstone: [C: 03+2] Switch SE forms to Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884986 (https://phabricator.wikimedia.org/T304161) (owner: 10Ejegg) [18:22:18] thanks cstone ! [18:22:58] ah, but many of those support pages have special stying to look like foundation-not-wiki-site [18:23:02] ejegg: hmm not sure, but I had trouble finding stuff that didn't have that special styling yeah [18:23:21] so the banner does get successfully injected on those, but it's just not visible [18:23:21] derp, right, just fully read your comment [18:23:36] well, that support index itself is just a wiki page :) [18:24:02] (03Merged) 10jenkins-bot: Switch SE forms to Adyen [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884986 (https://phabricator.wikimedia.org/T304161) (owner: 10Ejegg) [18:24:04] ejegg: we could also add some custom top-level css to Donut to make the CN element always visible [18:24:14] that shouldn't interfere too much with testing Donate-sourced stuff [18:24:25] AndyRussG: or we could import a few pages from enwiki to see how banners look on real articles [18:24:28] and would make the "preview banner" links, which automatically go to a random page, work properly [18:24:35] ohh that's also an idea! [18:24:46] also we need something to test with Vector2022 on [18:24:54] ah yep, that too [18:25:11] is that a separate repo and all? [18:25:19] or same as old vector? [18:25:20] yeah it's a new skin [18:25:23] ah ok [18:25:35] hmm another option could still just be taking the central out of the donut [18:26:24] not sure I like that option too much tho [18:26:43] yet another copy of core [18:27:04] I think we can make them play well together [18:27:18] yeah +1 [18:27:42] also a minor gripe I had was the shallow clone of CN... was thinking of adding a patch to change that [18:27:57] was unable to fully visualize the history of some files as a result [18:28:16] * AndyRussG stops complaining [18:28:24] really appreciate all the work on that! [18:29:14] AndyRussG: what does the importDump do on donut [18:29:42] damilare: it brings in the wiki page content from Donate wiki that is used to create the forms there [18:30:13] that's how we get the actual forms on Donut. they're not generated by code in any repo, but by wiki pages and templages [18:30:15] damilare: unlike payments-wiki where the forms are all coded in php, the forms on donatewiki are all coded in wikitext [18:30:28] heh, what he said [18:31:03] ohh ok, interesting. It's being running for a while after setup.sh [18:31:11] thanks AndyRussG and ejegg [18:31:17] yeah not super fast, might be worse on Mac [18:31:46] do you have an idea of the total count, its at 200 now [18:33:17] mine finished after 1500 [18:33:48] oof, I guess that's another reason not to delete the storage on rebuild [18:34:20] wow! then at this rate, it'd be a miracle if it finishes within the hr [18:34:24] right ejegg [18:35:15] yeah that'd probably also benefit from turning off xdebug on donut cli php [18:35:47] +1 turning xdebug off by default if pos [18:36:11] I see a lot of noise warnings when running cli stuff. i wonder if we could have some flag-style behaviour [18:36:46] there are a bunch of cli and log xdebug warnings that are new for me, probably since xdebug3 [18:36:56] ah yeah maybe [18:37:11] they are useful if you're expecting it to work [18:37:16] oh maybe from the new php version? [18:37:36] but I think the autostart default of yes could be switched to no [18:37:56] and then we can just trigger a session with specific keys [18:40:16] hmm, I do like to be able to debug CLI scripts without having to tack on additional stuff [18:40:30] but we can easily edit our own xdebug.ini files [18:40:57] yeah ejegg that's instant too [18:41:18] (on the cli) [18:41:21] (03PS1) 10Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/884988 [18:42:09] (03CR) 10Ejegg: [C: 03+2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/884988 (owner: 10Ejegg) [18:42:29] yeah I like to leave the autostart/start_with_request on. I got rid of the warnings in the logs with xdebug.log_level=0. Dunno if that'd help with the cli warnings... maybe it would? [18:42:51] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - 10https://gerrit.wikimedia.org/r/884988 (owner: 10Ejegg) [18:43:23] AndyRussG: ejegg the worst offending is during setup.sh and unit tests [18:44:03] jgleeson lmk if xdebug.log_level=0 in your xdebug settings under config helps :) [18:44:07] AndyRussG: that won't help performance for MAC folks [18:44:11] as it will stil be connecting [18:44:22] jgleeson: no, that'd be separate to just get rid of the warnings [18:44:34] can we set an environment variable to override start_with_request and turn it off? [18:44:47] for Mac folks I think the first thing to try is not fully turn of the xdebug module [18:44:54] when running setup.sh [18:44:56] ejegg: if it was off by default, you would only have to change it once to turn it back on [18:45:05] as it's mounted in with each new container instance [18:45:13] I think it is off by default, but I turn it on under config [18:45:22] oh rly [18:45:28] not 100% sure.. [18:45:32] right, but for a rebuild we don't clobber existing xdebug.ini files [18:45:47] also correct [18:46:02] so to just temporarily disable during a script it looks like we can use the XDEBUG_CONFIG env var [18:46:29] https://xdebug.org/docs/all_settings [18:46:39] oh i see, that only allows overriding certain settings [18:46:48] let's see if the autostart is one of them [18:47:17] oh hmm I'm wrong, xdebug.start_with_request=yes is set inside the container [18:47:26] ejegg: can we first try just killing xdebug during setup instead? [18:47:39] even with autostart off, it'll still be doing stuff [18:47:43] sure [18:47:46] thx! [18:48:32] AndyRussG: I don't think it does anything without being started, I might be wrong [18:48:56] I used to use autostart by default in the ole days but then got used to adding the env var ejegg posted [18:49:10] jgleeson: autostart means it'll try to connect no matter what. without it, at least on the web, it's still looking for a cookie or a URL param that could trigger it [18:49:30] not sure on if anything else can trigger it on the command line though [18:49:37] although for us, I think if for the cli it's off by default and then we just switch it to on as a one-off, that should give us a default performance boost and allow the status quo [18:49:38] it's still overhead that's running inside the PHP process tho [18:49:43] ahh but it looks like start_with_request can't be overridden in XDEBUG_SETTINGS [18:50:10] AndyRussG: no cookies or url params on cli [18:50:19] XDEBUG_MODE might be the env var! [18:50:22] right, maybe an env ariable could trigger it? [18:50:30] yeah the env var does [18:50:30] jgleeson: I would still like to try just disabling xdebug 100% during setup.sh [18:50:31] XDEBUG_MODE=off " Nothing is enabled. Xdebug does no work besides checking whether functionality is enabled. Use this setting if you want close to 0 overhead." [18:50:39] https://xdebug.org/docs/all_settings#mode [18:50:46] ohhh nice [18:50:57] damilare: ^ [18:50:59] that's the same thing right? [18:51:04] "You can also set Xdebug's mode by setting the XDEBUG_MODE environment variable on the command-line; this will take precedence over the xdebug.mode setting, but will not change the value of the xdebug.mode setting." [18:51:14] noo that's different from autostart/start_with_request [18:51:31] sorry andy I mean the state is the same [18:51:35] thanks AndyRussG ejegg [18:51:43] it's off by default [18:51:44] I don't believe so jgleeson but I also could be wrong [18:51:48] yeah it is [18:51:55] you can check the logs [18:53:04] XDEBUG_MODE and XDEBUG_COFNIG are env vars [18:53:13] they are checked by the extension at run time [18:53:57] ah I meant XDEBUG_MODE would not necessarily do exactly the same thing as turning off autostart [18:54:06] sorry for the confusion and for going on about this point [18:54:15] so fr-tech we got a bonus feature on the upgrade to MW 1.39: automatic submodule bumps for DonationInterface. [18:54:27] That confused me when it first happened [18:54:32] but it's one step less [18:54:57] and they make nice long commit messages with all the merged commits noted [18:55:04] So I'm a lil confused at what the proposed solution is for now, we're gonna ask folks to remember to set some env vars to turn xdebug off? [18:55:13] Do we want to keep it, or ask releng to turn it off? [18:55:15] definitely not something I know much details about, just guessing based on how I vaguely think it works... apologies... anyway if XDEBUG_MODE=off is the suggested performance fix, yeah let's try that [18:55:42] jgleeson: I think we can just set that env var for setup [18:55:44] jgleeson: also there are two things to solve, one is the annoying warnings, and the other is performance on Mac during setup [18:56:06] then if ppl want to turn it off manually they can edit .ini files or set env vars locally [18:56:29] so that env var would be part of the setup script [18:56:37] it's easy to set env variables when runing docker-compose exec I think? someone could test it manually to see if it improves Mac performance, and if it does, yeah we could add it to setup.sh [18:56:39] not something to remember each time we run it [18:58:21] AndyRussG: ejegg. I guess from where I sit, if we disable it for default on the cli, which I'd question how often folks are debugging cli scripts to measure downsides, we get both [18:58:39] and for folks who like to debug on the cli, like me, we can switch it on once and we're good [18:58:46] AndyRussG: I'd test it tomorrow after this run is over [18:59:04] jgleeson: I'm debugging most of the time that I run civi drush scripts on the CLI [18:59:17] yeah same [18:59:51] jgleeson: I normally leave autostart//start_with_request enabled all the time on both web and cli, so I'd prefer the option that uses the env variable mentioned by ejegg to be set via setup.sh only during setup processes [18:59:53] but to see things go faster for mac folks, including unit tests and drush scripts, I'd happily enable it [19:00:30] and we could also find a way to help Mac folks run cli scripts faster when they're not debugging [19:00:35] we have a wrapper script for unit tests, right? [19:00:42] I should try this on the mac again one day too [19:00:51] we could add the off switch there too [19:00:59] yep [19:01:01] ejegg: payments yes, smashpig and civicrm no [19:01:16] oh you mean the fr-dev script [19:02:29] I mean you're talking about modifying 2/3 different scripts to set env vars on and off, and then for each other script you find along the way e.g. drush vs a default of off and one change [19:02:43] it seems like a bad cost/benefit radio to me [19:02:46] ratio* [19:02:54] ejegg: yeah agreed on that [19:03:38] ejegg: jgleeson: alternately Mac folks could add that env variable as a setting for containers in docker-compose.override.yml [19:03:45] lol [19:04:06] * jgleeson sorry I meant to say, agreeed with what you said about the bad cost/benefit ratio [19:04:20] agreed hacking the scripts doesn't seem worth it [19:04:36] I was serious about the docker-compose.override option [19:06:24] or if not docker-compose.override.yml, some other additional compose yml file that could be version-controlled and Mac users could always add in when they do docker-compose anything [19:06:55] there are other use cases for additional docker-compose yml files that could be separated out [19:07:03] such as for selectively enabling and disabling services [19:07:29] I was just looking at where we set the defaults for xdebug [19:07:59] are they generated during the docker entrypoint scrpts? I can see /tmp/xdebug.ini [19:07:59] in the container, for cli it's /etc/php/7.4/cli/conf.d/30-xdebug-cli.ini [19:08:23] ah nooo that's wrong sorry! [19:08:30] I think that's the generated one [19:08:51] yeah sorry that's the internal container view of the one under config [19:09:03] so I was wrong about about autostart being on by default, sorry!!!! [19:09:23] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Update SmashPig currency rates - https://phabricator.wikimedia.org/T326671 (10Pcoombe) Thanks @Ejegg and @HNordeenWMF ! I updated on donatewiki as well: https://donate.wikimedia.org/w/index.php?title=MediaWiki:DonationForm.js&diff=prev&oldid=38007 [19:09:41] /etc/php/7.4/cli/conf.d/25-common-xdebug.ini is the default one [19:12:26] huh, so for me in my donut config I see [19:12:28] xdebug.client_port=9000 [19:12:30] xdebug.start_with_request=no [19:12:49] maybe it is off and I've just turned it on [19:13:36] ejegg|brb: AndyRussG it looks like it is off?! https://github.com/wikimedia/wikimedia-fundraising-dev/blob/7223c3edc3ca9a3eb4fed4302e6e8f6032fa09fb/setup.sh#L575 [19:13:39] 10Fundraising-Backlog: Batch account updater support for Adyen - https://phabricator.wikimedia.org/T328151 (10EMartin) 05Open→03Resolved a:03EMartin I am closing this task. Adyen has come back to advise that real time account updater should include updates to the same extent of batch updates. We'll be wa... [19:14:20] by default* [19:14:29] jgleeson: yes you're right, I was mistaken, really sorry [19:14:59] sorry too for assuming it wasn't ! [19:15:02] or was [19:15:02] indeed that's the generated default from setup.sh. see line 557 onward in setup.sh [19:15:07] head hurts ha [19:15:34] ok so I guess that changes the direction a bit of the mac fixes [19:16:15] if it's off by default for damilare|brb & wfan then we've gotta think of something else [19:16:40] s/of/on/ [19:16:41] aww [19:17:42] yeah, I usually turn it on when I use it and then restart the box [19:17:42] I'm amazed that docker isn't doing more to fix this issue on mac [19:18:27] with some magic mount tech [19:19:40] wfan: damilare|brb you can't be convinced to switch to linux ? :P [19:19:56] laptop sticker bribes [19:20:23] haha, I actually can [19:20:36] and jack your config is also default as xdebug.start_with_request=no, not yes [19:21:14] yeah it seems the Civi solution of running your own Linux VM on Mac might be the long-term options [19:21:28] !log payments-wiki upgraded from 653c7cc8 to f20a2208 [19:21:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:23:15] yep wfan. I was confused what the default was also [19:25:15] AndyRussG: damilare|brb spent a bunch of time getting civicrm running Nix. It sounded like an interesting approach https://docs.civicrm.org/dev/en/latest/tools/buildkit/nix/ [19:25:41] my impression was that it was similar to the python venv style of encapsulation [19:26:51] oh sorry I misread what you said. do you mean just a straightforward debian/ubuntu vm [19:27:07] that would probably be easier to set up [19:37:33] ahh still interesting! [19:37:52] also relevant: https://osxdaily.com/2022/10/22/you-can-now-run-virtualbox-on-apple-silicon-m1-m2/ [19:39:37] and then maybe the Linux vm could use whatever standard mounts it would use to share the code directories with the Mac host, so the IDE could be run on the host [19:40:35] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MW-1.40-notes (1.40.0-wmf.21; 2023-01-30): Adyen form requested for Czech Republic for Q3 testing - https://phabricator.wikimedia.org/T323715 (10Cstone) CZ is now live with Adyen. Test link here: https://payments.wikimedia.org/index.php... [19:43:05] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MW-1.40-notes (1.40.0-wmf.21; 2023-01-30): Adyen form requested for Czech Republic for Q3 testing - https://phabricator.wikimedia.org/T323715 (10TSkaff) wo-hoo thanks @CStone! [19:45:41] oho, so we DO default it to off? [19:46:00] heh, I guess I just changed it long ago and forgot [19:46:28] same [19:47:37] it's ironic that we can have such a passionate back and forth posing all kinds of options and none of us had actually checked the defaults [19:49:14] haha [19:49:47] lol [19:50:18] k, now I need to read my last EOD email to figure out what else I wanted to do today [19:55:44] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Japan, and 3 others: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10Ejegg) Hi @CDenes_WMF so that donate button text change is universal across all JA form... [19:56:26] AndyRussG: I actually tried the new docker setup with M1 mac last week, still the db too slow to complete, but confirmed, that https://phabricator.wikimedia.org/T326974#8568039 will give me a way to do Special:JavaScriptTest locally, and still no error as you mentioned here https://phabricator.wikimedia.org/T318103 [19:56:49] while I think I can plus 2 for those two patches~, thanks a lot [19:57:27] (03PS3) 10Wfan: Donut: Enable JS tests and remove setting [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884484 (https://phabricator.wikimedia.org/T326974) (owner: 10AndyRussG) [20:01:07] (03CR) 10Wfan: [C: 03+1] "test good with the other pates, just confused the extra config removal" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884484 (https://phabricator.wikimedia.org/T326974) (owner: 10AndyRussG) [20:01:31] (03PS3) 10Wfan: Donut: Use /w for $wgScriptPath [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884520 (https://phabricator.wikimedia.org/T326974) (owner: 10AndyRussG) [20:01:51] ejegg: what do you mean by automatic submodule bumps with donation interface on 1.39 [20:01:55] forever? [20:02:16] * jgleeson checks submodules on DI [20:02:31] hmm [20:02:46] jgleeson: as soon as I merged the DonationInterface patches to deployment [20:03:03] some automatic process made a commit on mw/core fundraising/REL1_39 [20:03:11] so we dont have to do that step anymore? [20:03:13] updating the submodule pointer to the new deployment commit [20:03:20] looks like it cstone! [20:03:22] nice [20:03:26] woah [20:03:36] that is big [20:03:37] so the only caution I have is that it doesn't handle vendor / composer.lock updates [20:03:44] ah [20:04:03] so we could possibly forget to do that and end up with DI code that expects later SmashPig and a core/vendor that still has the old one [20:04:59] but yeah, it's a timesaver for most deploys [20:06:03] i updated or documentation to reflect that [20:06:09] thank you cstone [20:08:02] ejegg: cstone so we need to amend the auto-generated commit IF there's a package update [20:08:06] ? [20:08:33] jgleeson: we just make a follow=on commit [20:08:47] the auto-generated commit happens up at gerrit [20:09:27] so we can't amend without a force-push, altering history, timey-wimey wibbles [20:09:31] ah [20:09:34] lol [20:09:46] I see what you did there [20:09:50] :) [20:09:55] ok I'm gonna do some work before our call [20:15:06] (03CR) 10AndyRussG: Donut: Enable JS tests and remove setting (032 comments) [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884484 (https://phabricator.wikimedia.org/T326974) (owner: 10AndyRussG) [20:15:33] wfan: thanks for the review! see reply inline [20:16:13] regarding the M1 mac, I think you'd have to run Linux with the beta version of VirtualBox which runs natively on ARM, and then inside that VirtualBox VM, try installing docker? [20:16:21] (no idea if it would really work or help at all, though) [20:16:42] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10Technical-Debt: Delete Globalcollect adapter, fold still-used code into Ingenico adapter - https://phabricator.wikimedia.org/T260725 (10Ejegg) [20:16:46] 10Fundraising-Backlog, 10FR-Smashpig: SmashPig: Remove unused code from old integrations - https://phabricator.wikimedia.org/T291786 (10Ejegg) [20:20:29] 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface: Form chooser should query gatway capabilities to route donation - https://phabricator.wikimedia.org/T131989 (10Ejegg) 05Open→03Resolved a:03Ejegg [20:22:51] brb relocating [20:23:36] ejegg: is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/883673/ ready for review? [20:23:54] ah yeah, should be AndyRussG [20:23:55] I see the ticket still in "doing", but maybe also someone else should pick it up now, if there are bits left to do? [20:24:06] ah cool thx! [20:24:09] oh right, I was going to write another patch for the civi side [20:24:29] ejegg: hmm oki I guess let's discuss in the meeting how to proceed? [20:24:45] The DonationInterface patch can be reviewed independently [20:24:52] OKI [20:24:57] *oki [20:25:03] just check the donations queue message [20:25:04] sorry unintentional caps lock [20:25:11] to see if the two new fields are added [20:25:17] cool :) [20:25:27] I don't see any unclaimed dLocal tickets, and the two tickets that are "Ready for review" have a lot of comments already on the attached patches [20:25:47] hehe, must be ready for +2 then [20:26:35] jgleeson|brb: ejegg I've made the recommended changes on the Dlocal tasks available for review [20:26:54] thanks damilare, I'll take another look [20:27:11] tnx [20:27:24] AndyRussG: https://gerrit.wikimedia.org/r/plugins/gitiles/operations/mediawiki-config/+/37db2cbe585aef968dad66fb2acd3f8c4298e855/wmf-config I do not see the default value here, did you pasted wrong link? [20:27:37] wfan: exactly, it's not there [20:27:46] the default value comes from extension.json directly [20:28:07] the fact that it's not there means that on production, we don't set it explicitly, which causes it to use the default from extension.json [20:28:24] does that make sense? [20:28:28] gotcha [20:28:43] that link is the code that generates the equivalent of LocalSettings.php for the main production wikis [20:29:11] so since it's not there, also leaving it out of our own LocalSettings.php is like having the same setup as production [20:30:33] Still do not know how this code that generated the equivalent of LocalSettings.php, but I get it if we do not set our own, it's the default value. [20:36:36] damilare: I had hoped to revisit it again today but I've had a choppy day around the other dlocal thing I'm working on. If ejegg doesn't +2 it tonight I'll try and get to it tomorrow. I think I wanted to try out the rejection flow with one of them but I can't remember which [20:37:34] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Python3-Porting: modernize DjangoBannerStats to python3 - https://phabricator.wikimedia.org/T301905 (10XenoRyet) [20:37:43] tnx jgleeson np [20:49:55] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Transaction not found in Adyen. Error Reference 157787384.1 - https://phabricator.wikimedia.org/T328344 (10XenoRyet) [20:51:19] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: JP forms 2223 testing issue - https://phabricator.wikimedia.org/T328161 (10XenoRyet) [20:54:28] (03CR) 10Wfan: [C: 03+2] "Make sense, so if we do not specific the config value at LocalSetting.php, it will fall back to use the default value as production did." [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884484 (https://phabricator.wikimedia.org/T326974) (owner: 10AndyRussG) [20:54:33] (03PS4) 10Wfan: Donut: Use /w for $wgScriptPath [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884520 (https://phabricator.wikimedia.org/T326974) (owner: 10AndyRussG) [20:54:50] (03CR) 10Wfan: [C: 03+2] "LGMT! Usefull!" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884520 (https://phabricator.wikimedia.org/T326974) (owner: 10AndyRussG) [20:56:19] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review: GatewayChooser: No supported gateway for parameters - https://phabricator.wikimedia.org/T326666 (10AnnWF) @Pcoombe Hi peter, let me know when could I test, thanks so much! [20:57:53] (03CR) 10Wfan: [V: 03+2 C: 03+2] Donut: Use /w for $wgScriptPath [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884520 (https://phabricator.wikimedia.org/T326974) (owner: 10AndyRussG) [20:58:33] (03CR) 10Wfan: [V: 03+2 C: 03+2] Donut: Enable JS tests and remove setting [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884484 (https://phabricator.wikimedia.org/T326974) (owner: 10AndyRussG) [20:59:28] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-Civi-Dedupe: Update deduper documentation to explain the critieria better - https://phabricator.wikimedia.org/T327727 (10XenoRyet) [21:07:00] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-Translate, 10Language-Team (Language-2023-January-March), and 3 others: Move classes in the Translate root directory to namespace - https://phabricator.wikimedia.org/T313242 (10XenoRyet) [21:11:55] 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Run some queries to find where our dupes are - https://phabricator.wikimedia.org/T328369 (10Eileenmcnaughton) [21:12:32] 10Fundraising Sprint Juggalology 2022, 10Fundraising Sprint Kermit hopping principle, 10Fundraising Sprint Localhost Hospitality Studies, 10Fundraising Sprint Machine Unlearning, and 5 others: Currency code/currency symbol in Thank You emails received by Donors iss... - https://phabricator.wikimedia.org/T309349 [21:23:44] 10Fundraising-Backlog, 10FR-Docker: Docker dev setup: Be able to skip pulling down the private config repo - https://phabricator.wikimedia.org/T328371 (10Cstone) [22:08:30] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for mdemos - https://phabricator.wikimedia.org/T328374 (10Dwisehaupt) [22:09:03] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sdaniels - https://phabricator.wikimedia.org/T328375 (10Dwisehaupt) [22:09:30] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for eileen - https://phabricator.wikimedia.org/T328376 (10Dwisehaupt) [22:09:56] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for andyrussg - https://phabricator.wikimedia.org/T328377 (10Dwisehaupt) [22:10:22] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sbaruchel - https://phabricator.wikimedia.org/T328378 (10Dwisehaupt) [22:10:53] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sborriello - https://phabricator.wikimedia.org/T328379 (10Dwisehaupt) [22:11:29] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ewilfong - https://phabricator.wikimedia.org/T328380 (10Dwisehaupt) [22:11:47] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for rkumar - https://phabricator.wikimedia.org/T328381 (10Dwisehaupt) [22:12:17] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jbrungs - https://phabricator.wikimedia.org/T328382 (10Dwisehaupt) [22:12:42] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for amjohnson - https://phabricator.wikimedia.org/T328383 (10Dwisehaupt) [22:13:11] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for tskaff - https://phabricator.wikimedia.org/T328384 (10Dwisehaupt) [22:44:52] AndyRussG: I've got a preliminary patch for the Civi side of that import, which just defines the two new fields, if you want me to push that up [22:45:04] so you can focus on just mapping it from the message [22:53:31] (03PS1) 10Ejegg: Add new fields for phonetic first/last names [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/885044 (https://phabricator.wikimedia.org/T322793) [22:57:53] ejegg: oh cool yeah that'd be great, thanks! [22:58:04] ah I see it there ^ cool [22:58:04] it's that teeeny patch there ^^ [22:58:09] :) [23:22:00] (03PS5) 10Ejegg: Rename 'token' params in PayPal API calls [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883651 (https://phabricator.wikimedia.org/T324642) [23:22:49] (03PS6) 10Ejegg: Rename 'token' params in PayPal API calls [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883651 (https://phabricator.wikimedia.org/T324642) [23:23:10] good catch on that unneeded PAYMENTREASON parameter wfan [23:23:26] I've removed that in the latest PS if you want to take another look ^^^ [23:28:14] (03PS1) 10Ejegg: Pass through description for Dlocal authorize call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885052 [23:31:14] (03PS27) 10Ejegg: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [23:43:07] (03CR) 10Wfan: [C: 03+2] Rename 'token' params in PayPal API calls [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883651 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [23:43:13] (03PS4) 10Wfan: Fix PaymentActionNotInitiated status mapping [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/884147 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [23:43:39] (03Merged) 10jenkins-bot: Rename 'token' params in PayPal API calls [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883651 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg)