[00:01:10] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-Docker: Docker: make all MediaWiki services work with Fresh - https://phabricator.wikimedia.org/T326974 (10AnnWF) @hashar here is the related issue: https://phabricator.wikimedia.org/T214140 [00:18:10] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: JP and CZ forms 2223 testing issue - https://phabricator.wikimedia.org/T328161 (10EMartin) [00:19:10] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: JP and CZ forms 2223 testing issue - https://phabricator.wikimedia.org/T328161 (10EMartin) Hello FRTech, I was just testing the new CZ form through Adyen and see the same problem of an error but a valid auth in the Adyen console. The issue is not exclus... [00:20:03] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: JP and CZ forms 2223 testing issue - https://phabricator.wikimedia.org/T328161 (10EMartin) The error on the CZ form: {F36563070} [00:21:39] thanks wfan! [00:23:30] (03CR) 10Ejegg: [C: 03+2] "This is looking good! Works great for the successful path. We can maybe test more failure scenarios after adding the 'description' paramet" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [00:25:12] (03Merged) 10jenkins-bot: Handle card submission in DLocal in DonationInterface [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/881719 (https://phabricator.wikimedia.org/T324290) (owner: 10Damilare Adedoyin) [00:31:43] (03CR) 10Wfan: [C: 03+2] "A value of PaymentActionNotInitiated occurs when you submit a GetExpressCheckoutDetails API call before the buyer logs into a PayPal accou" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/884147 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [00:32:15] (03Merged) 10jenkins-bot: Fix PaymentActionNotInitiated status mapping [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/884147 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [00:33:01] thanks wfan ! [00:36:53] np ~ just a bit confused that paypal developer document do not have detail info for PaymentActionNotInitiated, find the description from here https://stackoverflow.com/questions/16630463/paypal-integration-getexpresscheckout [00:37:15] yeah, I guess I have some excuse for being wrong all that time :) [00:41:58] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for khansen - https://phabricator.wikimedia.org/T328392 (10Dwisehaupt) [00:44:44] (03PS1) 10Ejegg: Fix some whitespace in Dlocal adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885060 [00:45:06] (03CR) 10Wfan: [C: 03+2] "LTMG, I thought we could check if value exist, but seems no hurt to overwrite it to avoid another check in a loop." [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/884148 (https://phabricator.wikimedia.org/T324642) (owner: 10Ejegg) [00:46:12] (03CR) 10CI reject: [V: 04-1] Fix some whitespace in Dlocal adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885060 (owner: 10Ejegg) [00:46:50] ejegg: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/884149/ you have some unit test failed. [01:28:40] (03PS4) 10AndyRussG: Donut: set fake GeoIP cookie in Apache [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884721 [01:30:24] (03CR) 10AndyRussG: [V: 03+2 C: 03+2] "(Just reapplying to this rebased patch set the C+2 and V+2 previously given by @Damilare. Thanks much!!)" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884721 (owner: 10AndyRussG) [01:31:34] (03CR) 10AndyRussG: "Incorporates changes suggested in I528dcc58." [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/884520 (https://phabricator.wikimedia.org/T326974) (owner: 10AndyRussG) [02:21:32] ah wfan, i see. I'll work on those [02:42:21] (03CR) 10Ejegg: [C: 04-1] "Thanks, this will be nice to have! We probably shouldn't re-download fresh every time we run setup.sh. And it would be nice to add a confi" [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/883524 (owner: 10Wfan) [02:42:56] Thanks Elliott, fair point! [02:43:43] (03PS2) 10Ejegg: Fix some whitespace in Dlocal adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885060 [02:45:26] (03CR) 10CI reject: [V: 04-1] Fix some whitespace in Dlocal adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885060 (owner: 10Ejegg) [02:48:30] (03PS3) 10Ejegg: Fix some whitespace in Dlocal adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885060 [02:52:05] (03PS1) 10Ejegg: Add description parameter to dlocal authorize [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885063 [02:58:19] (03Abandoned) 10Ejegg: Don't throw exception on IPN verify failure [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/321016 (owner: 10Cdentinger) [02:59:43] (03Abandoned) 10Ejegg: Test PayPal verified message transform [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/311874 (owner: 10Cdentinger) [03:07:34] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sinaba - https://phabricator.wikimedia.org/T327702 (10Dwisehaupt) SSL cert renewed and sent via email. Password sent via SMS. [03:10:54] (03PS1) 10Cstone: Test api call for authorizing a redirect payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885067 [03:11:48] (03CR) 10CI reject: [V: 04-1] Test api call for authorizing a redirect payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885067 (owner: 10Cstone) [03:12:51] (03PS2) 10Cstone: Test api call for authorizing a redirect payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885067 [03:26:42] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Upstream imap timeout fix - https://phabricator.wikimedia.org/T327225 (10Eileenmcnaughton) Upstream patch now merged [03:32:27] (03CR) 10Ejegg: "A couple of suggestions and some food for though." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) (owner: 10Damilare Adedoyin) [03:32:46] cstone any reason you wouldn't want to go through the PaymentProvider object in that maintenance script? [03:32:58] are we usually calling API stuff directly? [03:33:24] In the ones I wrote I tended to go through the PaymentProvider layer just so it would be testing more code [03:33:38] in this case the validation stuff [03:35:51] oh sorry ejegg I wrote a big blurb about it in my end of day [03:36:13] im not sure whree it should go or be named or done haha [03:36:49] oh oops, hadn't read it yet [03:36:58] we dont really have a test test script like this but its useful for me [03:36:59] will take a look! [03:37:05] just what i said above [03:37:09] it can even just not be merged [03:37:14] and i can abandon it later [03:38:05] No, those test scripts are super useful to have [03:38:23] but our other test scripts are like actually calling real paratmers/could [03:38:29] this one i dont really see useful once we go live [03:38:41] cause you would have to pass like 15 things to it [03:39:37] hmm I guess a bunch could be defaults [03:41:44] but your original question sure but that code isn't merged yet hah we can update [03:42:01] (03PS2) 10Ejegg: Pass through description for Dlocal authorize call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885052 [03:43:13] (03PS3) 10Ejegg: build: Remove syntax option from stylelint [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/856687 (owner: 10Umherirrender) [03:43:27] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/856687 (owner: 10Umherirrender) [03:45:06] (03Merged) 10jenkins-bot: build: Remove syntax option from stylelint [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/856687 (owner: 10Umherirrender) [03:46:35] (03CR) 10Ejegg: [C: 04-1] "Hmm, it feels like we should apply this default at a different level - maybe up at the start of EmailPreferences::execute?" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884543 (https://phabricator.wikimedia.org/T327480) (owner: 10Wfan) [03:49:06] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: JP and CZ forms 2223 testing issue - https://phabricator.wikimedia.org/T328161 (10Cstone) Ahh @EMartin your test donation got caught by a fraud filter we had + failing AVS checks since there is no address fields on the forms. I removed the older filter bu... [03:53:36] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, 10Fundraising Sprint Potato, and 6 others: Creating New Matching Gift Import - https://phabricator.wikimedia.org/T303986 (10Eileenmcnaughton) I caught up with @mdemos to... [03:56:56] 10Fundraising Tech - Chaos Crew, 10MediaWiki-extensions-CLDR, 10ci-test-error (WMF-deployed Build Failure): quibble-fundraising-cldr-REL1_39-php74-docker failure on CLDR master - https://phabricator.wikimedia.org/T328240 (10Ejegg) Wow, that's kind of bizarre - what is composer doing looking for a DonationInt... [04:01:54] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Clean up rogue contribution_tracking id 1796212180 - https://phabricator.wikimedia.org/T325784 (10Ejegg) Wow, it's an Australian BPay bank transfer. I thought those were extinct. They must have generated a form years ago and just keep using the same numbe... [04:05:57] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Clean up rogue contribution_tracking id 1796212180 - https://phabricator.wikimedia.org/T325784 (10Ejegg) I deleted the c_t row [04:09:57] (03PS3) 10Ejegg: Check for success on getStatus call [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/883670 [04:12:52] (03PS4) 10Ejegg: Fix some whitespace in Dlocal adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885060 [04:15:40] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.40-notes (1.40.0-wmf.19; 2023-01-16): Make DonationInterface compatible with MediaWiki 1.39 - https://phabricator.wikimedia.org/T324154 (10Ejegg) [04:16:11] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, and 3 others: Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4 - https://phabricator.wikimedia.org/T326372 (10Ejegg) 05Resol... [04:16:56] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, and 3 others: Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4 - https://phabricator.wikimedia.org/T326372 (10Ejegg) Example... [05:21:10] 10Fundraising Tech - Chaos Crew, 10MediaWiki-extensions-CLDR, 10ci-test-error (WMF-deployed Build Failure): quibble-fundraising-cldr-REL1_39-php74-docker failure on CLDR master - https://phabricator.wikimedia.org/T328240 (10Reedy) ` 00:30:00 + exec docker run --entrypoint=quibble-with-supervisord --tmpfs /wo... [10:46:22] 10Fundraising-Backlog, 10MediaWiki-extensions-CentralNotice, 10Patch-Needs-Improvement, 10Technical-Debt: Use CSS instead of obsolete HTML attributes on CentralNotice tables - https://phabricator.wikimedia.org/T108259 (10Pcoombe) I believe this has been done for the main campaigns page, but not the logs pages [10:53:22] (03CR) 10Jgleeson: [C: 03+2] "LGTM! Tested with I80aeadf181de992f40b0a6ddf440872ce778452b and working as expected." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885063 (owner: 10Ejegg) [10:54:20] (03CR) 10Jgleeson: [C: 03+2] "Tested with DI patch and worked as expected. Also can confirm description is now visible in the dlocal payment console." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885052 (owner: 10Ejegg) [10:56:32] (03CR) 10Jgleeson: [C: 03+2] "LGTM!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885060 (owner: 10Ejegg) [10:56:39] (03PS2) 10Jgleeson: Add description parameter to dlocal authorize [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885063 (owner: 10Ejegg) [10:58:12] (03Merged) 10jenkins-bot: Fix some whitespace in Dlocal adapter [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885060 (owner: 10Ejegg) [12:48:41] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Japan, and 3 others: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10CDenes_WMF) @Ejegg let's keep for just these variants, so we can measure any change in KPI [13:06:36] (03CR) 10Jgleeson: [C: 03+2] "Thanks! I think this is fine where it is. It's definitely useful for generating a Redirect response, and I can see it being used in the fu" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885067 (owner: 10Cstone) [13:07:08] (03Merged) 10jenkins-bot: Test api call for authorizing a redirect payment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885067 (owner: 10Cstone) [13:19:14] (03PS1) 10Jgleeson: Update test email to something less likely to be real [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885341 [13:34:39] (03PS11) 10Jgleeson: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) (owner: 10Damilare Adedoyin) [13:43:01] (03PS12) 10Jgleeson: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) (owner: 10Damilare Adedoyin) [13:43:42] (03PS3) 10Jgleeson: Pass through description for Dlocal authorize call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885052 (owner: 10Ejegg) [15:39:28] (03CR) 10Damilare Adedoyin: "Thanks ejegg for the comments, I'm working on them now. I added a response to question on the Validation Exception.php" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) (owner: 10Damilare Adedoyin) [15:41:25] damilare: I think we might need to discuss the new HostedPaymentProvider added in https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/883985 [15:41:43] as it means we need to pull a different payment provider class on the frontend to use [15:43:39] oh ok, how do you suggest we go about jgleeson? [15:45:26] I'm using Adyen as a reference and it looks like for the same flow we typically call the standard PaymentProvier::createPayment() and then detect the redirect variation in the response. See: https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/4a709c9caf7dc8c6cff51e29d3709029be154d29/adyen_gateway/adyen_checkout.adapter.php#L53 [15:45:36] and here https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/4a709c9caf7dc8c6cff51e29d3709029be154d29/adyen_gateway/adyen_checkout.adapter.php#L61 [15:46:32] the think the fundamental difference is that we only use a single PaymentProvider for both of those calls [15:46:56] credit card calls that is [15:50:48] in your patch you've introduced a new hostedPaymentProvider to handle this variation which I think means we can't keep the adyen style flow [15:51:12] that is, call a single PaymentProvider for all cc transactions [15:52:58] was there a reason you did it that way damilare ? [15:53:02] do we want to keep the adyen style flow? [15:53:44] yh I was thinking we want to separate non-cc transactions form cc transactions since they'd have their own unique complications [15:55:00] this patch is suppose to introduce the first call in the transaction but there might be some unique methods that would be needed for non-cc and not required for cc [15:56:32] ah ok I think there two different things at play here [15:56:54] one is the cc-specific redirect scenario, 3dsecure [15:57:05] and the other is the non-cc redirects [15:57:32] the one I implemented is specifically for the non-cc redirects [15:57:36] isn't it? [15:58:30] checking the docs [15:59:14] ok I'm looking at this ticket https://phabricator.wikimedia.org/T324291 [15:59:31] which does say to call yours [15:59:43] and I think the thing that is missing is, the payment method to call this code with [15:59:52] as we don't have anything other than credit card at the moment [16:04:12] I think part of the confusion on my part is that the HostedCheckoutProvider is an ingenico thing associated with credit cards [16:06:06] ok damilare I think we need to work out a payment method to call this code on the donaation interface side [16:06:14] and then we can use your stuff [16:06:45] Yh I think ejegg brought this up sometime last week about how we can define submethods or so [16:08:15] I don't recall [16:08:27] just looking through the epic now [16:10:23] oh I thought that's what this was supposed to be for: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/884069 [16:11:49] that's a patch to make our dependency injection wiring resolve class references in constructor params [16:17:10] I thought ejegg was asking how we can select submethods using this method call PaymentProviderFactory::getProviderForMethod( [16:17:12] $this->getPaymentMethod() [16:17:14] ); [16:17:28] meaning we'd have to pass in two values [16:17:43] maybe I misunderstood [16:17:59] is that patch you linked? [16:18:03] in* [16:18:29] yh I probably misunderstood, sorry [16:19:45] so I think before we can handle the redirect method on the frontend, we need to decide which payment methods will use it and it looks like the work for that relates at least to this ticket to begin with https://phabricator.wikimedia.org/T324276 [16:20:26] but having ready that and the epic again it looks like we might wanna prioritise direct methods such as card and bank transfers like UPI in India and PIX in Brazil [16:21:02] having read* that [16:21:46] exactly [16:23:01] sometimes I wonder how dyslexia works. in my head, the instructions are to type "but having read" and then my fingers translate that to "but having ready" which doesn't make sense and takes more finger effort to type... [16:24:00] lol [16:30:34] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Handle submission for DLocal REDIRECT methods in DonationInterface - https://phabricator.wikimedia.org/T324291 (10jgleeson) I've hit a roadblock on this one. I... [16:31:08] jgleeson: sorry I'm not feeling 100% today, what's your suggestion on the HostedPaymetProvider class [16:31:24] sorry to hear that! [16:32:32] ummm I don't think it needs to change. I actually don't think we're going to be using that in the short term now that I understand it better [16:33:31] I think instead we might need to focus on the adyen-style flow I mentioned a bit earlier and implement the 3dsecure stuff first as that is mandatory for India according to the docs [16:35:17] I'm gonna propose we bring this ticket in https://phabricator.wikimedia.org/T324302 [16:35:18] looks like the 3D secure flow is also a direct transaction: https://docs.dlocal.com/docs/3d-secure [16:35:27] yeah [16:35:52] so that means we need to revise the older createPayment mthod [16:35:54] my understanding is that we want cards and UPI working for India [16:37:02] fr-tech ^ anyone else more informed on the desired payment methods for India? [16:39:15] damilare: btw if you're not feeling too good, working might not be the best thing to be doing :) [16:39:37] I had a cold on Sunday and it went Monday morning. My sickness only seems to ruin my weekends at the moment [16:40:02] lol what a considerate flu [16:40:10] ha [16:40:51] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Implement 3DSecure for DLocal cards - https://phabricator.wikimedia.org/T324302 (10jgleeson) a:03jgleeson [16:41:08] huh I thought we had a Blocked column on the sprint [16:41:25] I guess the (not fr-tech) one might do [16:41:40] although that makes me think of blockers outside of our control [16:42:46] 10Fundraising-Backlog, 10IP Masking: Update Fundraising Tech-owned products that may be affected by IP Masking - https://phabricator.wikimedia.org/T326943 (10greg) (please don't assign things to the Chaos Crew board directly, thanks! :) ) Hi, thanks for the update on this work in the Tech Leadership meeting t... [16:44:45] fr-tech I've pulled this into the sprint after the conversation above with damilare https://phabricator.wikimedia.org/T324302 [16:45:22] I'm gonna get a head start on it. The other ticket that was in sprint is blocked https://phabricator.wikimedia.org/T324291 [16:46:14] and I think now that we know more about the REDIRECT stuff it will likely be deprioritised [16:47:03] actually maybe this would be better https://phabricator.wikimedia.org/T324294 [16:47:09] Update DLocal createPayment for UPI / DIRECT method [16:47:33] Hi fr-tech, we noticed no impression counts from the Sweden test despite getting donations. The last entries in the pgehres.bannerimpressions table are from 25 Jan. Did something get turned off during maintenance? [16:47:34] I'll pull them both in to force the discussion [16:47:57] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Update DLocal createPayment for UPI / DIRECT method - https://phabricator.wikimedia.org/T324294 (10jgleeson) [16:48:20] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Update DLocal createPayment for UPI / DIRECT method - https://phabricator.wikimedia.org/T324294 (10jgleeson) Pulling into sprint to discuss priority [16:48:36] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Implement 3DSecure for DLocal cards - https://phabricator.wikimedia.org/T324302 (10jgleeson) Pulling into sprint to discuss priority [16:49:40] I've gotta head out to take Oscar to his club but fr-tech it sounds like pcoombe has a high priority chaos crew ticket there [16:49:52] pcoombe: could you make a ticket for it pls? [16:49:59] k [16:50:03] back later [16:52:02] pcoombe: hi thanks! i think this is due to an upgrade on a server that made it incompatible with DjangoBannerStats? Jeff_Green does that seem right? (See pcoombe message above.) [16:52:12] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: No entries in pgehres.bannerimpressions since 25 Jan - https://phabricator.wikimedia.org/T328460 (10Pcoombe) [16:52:37] I know an update to DjangoBS is in the works due to this, but I don't remember the exact details of how things are on production [16:52:57] thx for the heads-up jgleeson! :) [16:53:31] Correct. We upgraded the fr analytics server to Debian Bullseye, which deprecated important parts of the obsolete/deprecated python2 stuff DjangoBS relies on [16:54:07] Jeff_Green: so the absence of entries from Jan 25 onward matches what we'd expect? [16:54:16] correct [16:54:34] once we get DJangoBS modernized, we will be able to backfill all of that [16:54:40] Jeff_Green: cool thx much! looks like pcoombe created a task also ^ [16:55:27] might as well delete that task, since there's the year-old one already [16:56:51] 10Fundraising-Backlog: Adding a new tag for Ingenico transactions to avoid fees - https://phabricator.wikimedia.org/T327533 (10EMartin) We received this update from Worldline/Ingenico - this is being postponed {F36563679} [16:56:54] Jeff_Green: I bet the next question the banners team will want is "eta?" :) [16:57:11] yeah I can imagine [16:58:06] has that task been triaged yet? [16:58:39] greg-g Jeff_Green pcoombe I imagine this is not a solution, since I imagine testing is ongoing and the data is needed ASAP, but just to note, we do have a process to backfill impressions data on pgheres [16:59:41] I don't think we need data urgently, we're happy to run the test without it (it's only 3 hours). But would be good to backfill at some point [16:59:48] AndyRussG: #I'm going to go with: 1 fix djangobannerstats, #2 backfill [16:59:50] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Python3-Porting: modernize DjangoBannerStats to python3 - https://phabricator.wikimedia.org/T301905 (10greg) p:05Triage→03High [17:00:08] Jeff_Green: sounds great thx much! [17:01:13] we need a process to copy over data a few specific aggregated data sets from the main Analytics cluster (generated via Druid and Hive queries) over to FR Analytics [17:01:18] that's the real solution [17:01:50] AndyRussG: that's fine and good, but we need to not drop the functioning pipeline on the floor while we wait for that solution [17:02:01] yes totally agreed Jeff_Green [17:03:11] just thinking longer-term, once that happens, we can set up a table/data cube parallel to pgheres impressions with the full data, and perhaps the processes currently using pgheres impressions can be gradually shifted over to the table with the real data [17:03:48] but yeah don't mean to imply the current thing doesn't have to start working first [17:08:29] pcoombe: do you use any part of the djangobannerstats code for reporting, or just the mysql database directly? [17:08:44] just the database [17:09:37] ok that's great, then there's really not that much code to modernize and I think I've got it mostly done but I need developer time to review the horrible things I've done to the codebase [17:11:34] AndyRussG: do you know offhand if there's an existing table somewhere of all the languages we deal with? [17:12:16] I'm trying to rework the country/language stuff not to cruft up with junk and instead rely on predefined data [17:16:52] (03CR) 10AndyRussG: "Thanks for this!!! pls see initial comment inline :)" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/883673 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [17:19:11] Jeff_Green: hmmm there's stuff in Civi but I'm not sure I'd want to reject putting stuff in pgheres based on it not being recognized by Civi [17:19:50] Jeff_Green: do you have a WIP patch on Gerrit? happy to take a look [17:20:18] no, I'm not putting anything in gerrit at this point, but the code is where you can poke at it on frdev1002 [17:20:46] (03Restored) 10Dylsss: Remove deleted hook MediaWikiPHPUnitTest::startTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/772053 (owner: 10Dylsss) [17:21:13] AndyRussG: frdev1002:/srv/DjangoBannerStats [17:21:34] Jeff_Green: is there a reason not to send it to Gerrit as a WIP? [17:21:52] we do that a lot, just putting "WIP" at the start of the commit message [17:22:43] from my perspective it seems not worth the time and crufting up gerrit with my hacking until it's worth formally reviewing [17:23:42] (03CR) 10Dylsss: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/772053 (owner: 10Dylsss) [17:24:08] Jeff_Green: it's just the process we normally use for CR [17:24:19] if you like I can do so [17:24:58] can I see a diff on frdev1002:/srv/DjangoBannerStats ? [17:25:09] yes, it's a git clone [17:25:36] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ebrill - https://phabricator.wikimedia.org/T327701 (10Dwisehaupt) SSL certificate renewed and sent via email. Password sent via SMS. [17:25:50] re. the language part, if you look at lookup_country you'll see the direction I'm thinking for language too [17:26:38] Jeff_Green: ok thx! [17:30:07] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for mdemos - https://phabricator.wikimedia.org/T328374 (10Dwisehaupt) SSL certificate renewed and sent via email. Password sent via SMS. [17:32:53] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for shust - https://phabricator.wikimedia.org/T327700 (10Dwisehaupt) SSL certificate renewed and sent via email. Password sent via SMS. [17:34:27] (03CR) 10Dylsss: "DonationInterface test now run on mw 1.39, so I think this should be good to merge now." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/772053 (owner: 10Dylsss) [17:36:32] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for hnordeen - https://phabricator.wikimedia.org/T328067 (10Dwisehaupt) SSL certificate renewed and sent via email. Password sent via SMS. [17:37:52] (03CR) 10AndyRussG: Send phonetic name fields through on queue messages (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/883673 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [17:42:43] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for amjohnson - https://phabricator.wikimedia.org/T328383 (10Dwisehaupt) SSL certificate renewed and sent via email. Password sent via SMS. [17:45:09] (03PS2) 10Wfan: Default emailPreference template to emailPreferences [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/884543 (https://phabricator.wikimedia.org/T327480) [17:45:22] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sdaniels - https://phabricator.wikimedia.org/T328375 (10Dwisehaupt) SSL certificate renewed and sent via email. Password sent via SMS. [17:58:28] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, and 3 others: Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4 - https://phabricator.wikimedia.org/T326372 (10Jdforrester-WMF... [18:01:41] (03CR) 10Wfan: Add new fields for phonetic first/last names (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/885044 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [18:09:36] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, and 3 others: Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4 - https://phabricator.wikimedia.org/T326372 (10Jdforrester-WMF... [18:12:50] (03CR) 10Jforrester: "recheck" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/885044 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [18:12:59] (03CR) 10Jforrester: "check experimental" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/885044 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [18:17:11] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ewilfong - https://phabricator.wikimedia.org/T328380 (10Dwisehaupt) SSL certificate renewed and sent via email. Password sent via SMS. [18:19:46] (03CR) 10Ejegg: Check for success on getStatus call (031 comment) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/883670 (owner: 10Ejegg) [18:25:13] (03CR) 10Ejegg: "I replied inline wfan. Thanks for the review!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/885044 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [18:32:16] (03CR) 10Wfan: [C: 03+2] "LGMT" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/885044 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [18:34:51] fr-tech is anyone free to jump on a call real quick and look at this ipn response from dlocal before I send them an email? just want to make sure im not missing anything obvious [18:46:26] (03Merged) 10jenkins-bot: Add new fields for phonetic first/last names [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/885044 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [18:49:03] (03PS13) 10Damilare Adedoyin: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) [18:49:07] sure cstone, today's meeting? [18:49:08] cstone: I'm around [18:49:27] just got off my 1:1 [18:49:30] (03CR) 10CI reject: [V: 04-1] Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) (owner: 10Damilare Adedoyin) [18:49:34] could wait till the meeting if that works also [18:49:36] (03CR) 10Damilare Adedoyin: "thanks ejegg, responded to all the comments and replied one." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) (owner: 10Damilare Adedoyin) [18:50:09] haha sure ejegg and jgleeson in todays meeting? [18:51:59] ejegg: I'm blocked on this ticket https://phabricator.wikimedia.org/T324291 I couldn't think of a good way to progress with it without having a non-cc payment method set up. It looks like the priority is the DIRECT dlocal methods like UPI and 3dsecure for India so I pulled in some other dlocal tickets such as 3dsecure updates for dlocal and UPI updates. [18:52:23] but I just wanted to check that assumption with you [18:57:24] right jgleeson I guess the other direct ones are the priority [18:57:40] I was thinking maybe the redirect ones would be super simple [19:00:06] and that one bit of redirect code would code many countries [19:10:00] (03PS14) 10Damilare Adedoyin: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) [19:12:02] hmm jgleeson it looks like the URL generated by Dami's SMashPig patch goes to a payment method selection page when we don't pass in a payment submethod [19:12:19] so maybe you can just wire up the continue button for that ticket for now? [19:13:09] i.e. make showSubmethodButtons return false [19:25:09] oof AndyRussG those promises in adyen.js are confusing [19:25:20] (03CR) 10Ejegg: Send phonetic name fields through on queue messages (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/883673 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [19:28:15] ok, so it looks like the only extraData that gets passed in to the places where google and apple submit is the stuff from the authPromise [19:28:47] AndyRussG: it would be a bigger change to get that data all the way through to the submit for google and apple [19:29:24] And would have no functional significance for this patch [19:37:55] thanks ejegg|afk [19:39:53] sorry cstone I completely misunderstood before [19:40:09] I thought ejegg|afk was saying we would talk about it at today's meeting [19:40:15] which didn't make sense to me [19:40:25] but now I realise he meant use that, now ha [19:40:38] did you get it sorted? [19:45:29] (03CR) 10AndyRussG: Send phonetic name fields through on queue messages (031 comment) [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/883673 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [19:50:48] yep jgleeson [19:50:53] awesome [19:51:14] well i guess not sorted but i know whats going on now at least [19:51:40] (03CR) 10AndyRussG: [C: 03+2] "Works great, thanks for this!!!" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/883673 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [19:54:11] (03Merged) 10jenkins-bot: Send phonetic name fields through on queue messages [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/883673 (https://phabricator.wikimedia.org/T322793) (owner: 10Ejegg) [19:56:19] hey AndyRussG: did you see my proposal about trying to come up with a way for everyone to be included in wide-impact changes made to fundraising-dev? [19:57:30] jgleeson: yes I did, thanks so much for that! [19:57:42] does it make sense to you? [19:58:43] jgleeson: yeah seems super important [19:59:18] I also felt yesterday's IRC interaction was not the best, and following your e-mail, I realized there were some additional confusions/stuff I misunderstood [19:59:43] also I'd 100% support consensus as the best practice not just for fr-dev but everything really [20:00:25] yeah. i feel like IRC is good for some stuff but when we've a few different perspectives and relevant context, a video call wins hands down [20:00:35] yeah agreed :) [20:06:51] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MW-1.40-notes (1.40.0-wmf.20; 2023-01-23): Move Croatia to Adyen as default - https://phabricator.wikimedia.org/T327207 (10XenoRyet) 05Open→03Resolved [20:07:55] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Upgrade Civi to latest point version now BE is over - https://phabricator.wikimedia.org/T326272 (10XenoRyet) 05Open→03Resolved [20:08:19] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Upstream imap timeout fix - https://phabricator.wikimedia.org/T327225 (10XenoRyet) 05Open→03Resolved [20:08:23] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Upgrade Civi to latest point version now BE is over - https://phabricator.wikimedia.org/T326272 (10XenoRyet) [20:08:59] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MW-1.40-notes (1.40.0-wmf.21; 2023-01-30): Adyen form requested for Czech Republic for Q3 testing - https://phabricator.wikimedia.org/T323715 (10XenoRyet) 05Open→03Resolved [20:09:32] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-dlocal: Implement dLocal health check API call - https://phabricator.wikimedia.org/T326248 (10XenoRyet) [20:09:58] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-dlocal: Implement dLocal health check API call - https://phabricator.wikimedia.org/T326248 (10XenoRyet) [20:10:10] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-dlocal: Implement dLocal health check API call - https://phabricator.wikimedia.org/T326248 (10XenoRyet) 05Open→03Resolved [20:10:12] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet) [20:10:51] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog: New custom fields on a contribution- matching Gift related - https://phabricator.wikimedia.org/T327614 (10XenoRyet) 05Open→03Resolved [20:11:22] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Smashpig, and 2 others: Implement DLocal signature calculation in SmashPig - https://phabricator.wikimedia.org/T324274 (10XenoRyet) 05Open→03Resolved [20:13:20] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10MediaWiki-extensions-DonationInterface, 10MW-1.40-notes (1.40.0-wmf.19; 2023-01-16): Make DonationInterface compatible with MediaWiki 1.39 - https://phabricator.wikimedia.org/T324154 (10XenoRyet) ... [20:15:08] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Resolve core CiviCRM test regression without hack - https://phabricator.wikimedia.org/T327360 (10Eileenmcnaughton) 05Open→03Resolved There is something merged upstream that should deal with this in future [20:15:11] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Upgrade Civi to latest point version now BE is over - https://phabricator.wikimedia.org/T326272 (10Eileenmcnaughton) [20:15:20] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Resolve core CiviCRM test regression without hack - https://phabricator.wikimedia.org/T327360 (10Eileenmcnaughton) [20:15:28] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, and 3 others: Render card SmartField on DLocal form - https://phabricator.wikimedia.org/T324271 (10XenoRyet) [20:15:34] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, and 2 others: Make sure gateway script fully loaded first for Dlocal, Adyen Checkout and Google - https://phabricator.wikimedia.org/T326975 (10XenoRyet) 05Open→03Resolved [20:15:40] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet) [20:15:43] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, and 3 others: Render card SmartField on DLocal form - https://phabricator.wikimedia.org/T324271 (10XenoRyet) 05Open→03Resolved [20:16:00] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10FR-dlocal, and 2 others: Make sure gateway script fully loaded first for Dlocal, Adyen Checkout and Google - https://phabricator.wikimedia.org/T326975 (10XenoRyet) [20:16:05] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface, 10MW-1.40-notes (1.40.0-wmf.20; 2023-01-23): Add extra field for some countries if create payment with dlocal smartfield - https://phabricator.wikimedia.org/T326976 (10XenoRyet) ... [20:16:53] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, and 3 others: Handle errors from DLocal SmartForms - https://phabricator.wikimedia.org/T324272 (10XenoRyet) [20:17:05] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, 10Fundraising-Backlog, and 3 others: Handle errors from DLocal SmartForms - https://phabricator.wikimedia.org/T324272 (10XenoRyet) 05Open→03Resolved [20:17:09] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet) [20:17:43] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog: Source Code project planning and scoping - https://phabricator.wikimedia.org/T327425 (10XenoRyet) 05Open→03Declined [20:20:20] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: GPay issue due to missing config update [fixed] - https://phabricator.wikimedia.org/T327857 (10XenoRyet) 05Open→03Resolved [20:20:27] (03PS1) 10Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/885417 [20:20:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Clean up rogue contribution_tracking id 1796212180 - https://phabricator.wikimedia.org/T325784 (10XenoRyet) [20:20:43] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Clean up rogue contribution_tracking id 1796212180 - https://phabricator.wikimedia.org/T325784 (10XenoRyet) 05Open→03Resolved [20:21:09] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10fr-donorservices: Mismatch between the Civi refund date vs what we see at the Adyen console - https://phabricator.wikimedia.org/T326254 (10XenoRyet) 05Open→03Resolved [20:21:36] 10Fundraising Tech - Chaos Crew: Request failed: no data found for trigger id 214227925 - https://phabricator.wikimedia.org/T327191 (10XenoRyet) 05Open→03Resolved [20:21:37] (03CR) 10Jgleeson: [C: 03+2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/885417 (owner: 10Jgleeson) [20:21:55] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MW-1.40-notes (1.40.0-wmf.20; 2023-01-23): Handle JS ReferenceError: AdyenCheckout is not defined - https://phabricator.wikimedia.org/T326610 (10XenoRyet) 05Open→03Resolved [20:22:08] (03Merged) 10jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - 10https://gerrit.wikimedia.org/r/885417 (owner: 10Jgleeson) [20:22:11] 10Fundraising Tech - Chaos Crew: dLocal Safari internal errors on redirect - https://phabricator.wikimedia.org/T318744 (10XenoRyet) 05Open→03Resolved [20:22:29] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MW-1.40-notes (1.40.0-wmf.20; 2023-01-23): Handle the GatewayChooser error handling nicer - https://phabricator.wikimedia.org/T324706 (10XenoRyet) 05Open→03Resolved [20:23:29] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Implement approvePayment for DLocal in SmashPig - https://phabricator.wikimedia.org/T324281 (10XenoRyet) 05Open→03Resolved [20:23:32] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet) [20:23:48] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Implement createPayment for DLocal CC / SmartFields in SmashPig - https://phabricator.wikimedia.org/T324279 (10XenoRyet) 05Open→03Resolved [20:23:50] 10Fundraising-Backlog, 10FR-dlocal, 10Epic: Upgrade Dlocal to leverage Smartfields/no redirect - https://phabricator.wikimedia.org/T274300 (10XenoRyet) [20:24:31] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Implement 3DSecure for DLocal cards - https://phabricator.wikimedia.org/T324302 (10jgleeson) [20:24:57] 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Update DLocal createPayment for UPI / DIRECT method - https://phabricator.wikimedia.org/T324294 (10jgleeson) [20:42:01] (03PS1) 10Eileen: Civi ports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/885420 [21:04:11] !log smashpig updated from d1434aeb to 683df497 [21:04:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:18:07] 10Fundraising Sprint Amazing grep, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Patch-For-Review: Decommission `civi-data-translate` extension - https://phabricator.wikimedia.org/T325698 (10XenoRyet) [21:29:20] (03PS2) 10Eileen: Civi ports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/885420 (https://phabricator.wikimedia.org/T303986) [21:31:32] 10Fundraising Sprint C 2023, 10Fundraising-Backlog, 10FR-Docker: fundraising-dev: start tagging releases - https://phabricator.wikimedia.org/T327400 (10XenoRyet) [21:31:38] 10Fundraising Sprint C 2023, 10Fundraising-Backlog: Unhurt our brains - activity_date_time - https://phabricator.wikimedia.org/T326606 (10XenoRyet) [21:31:39] (03PS3) 10Eileen: Civi ports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/885420 (https://phabricator.wikimedia.org/T303986) [21:31:41] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint C 2023, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising Sprint Wibbly Wobbly Timey Wimey, and 3 others: Figure out storage implications of varchar vs text in possible logging solution - https://phabricator.wikimedia.org/T325789 (10XenoRyet) [21:31:54] 10Fundraising Sprint C 2023, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Implement 3DSecure for DLocal cards - https://phabricator.wikimedia.org/T324302 (10XenoRyet) [21:32:02] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint C 2023, 10Fundraising-Backlog, and 4 others: Update CI config for new fundraising/REL1_39 branch of mediawiki/core under php7.4 - https://phabricator.wikimedia.org/T326372 (10XenoRyet) [21:32:06] 10Fundraising Sprint C 2023, 10Fundraising-Backlog, 10FR-India, 10FR-Smashpig, and 2 others: Implement backend for DLocal recurring UPI payments in SmashPig - https://phabricator.wikimedia.org/T324299 (10XenoRyet) [21:32:10] 10Fundraising Sprint C 2023, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10FR-PayPal-ExpressCheckout, 10Patch-For-Review: Update Pending Transaction Resolver to handle PayPal - https://phabricator.wikimedia.org/T324642 (10XenoRyet) [21:32:16] 10Fundraising Sprint C 2023, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Implement one-time UPI / DIRECT payments for DLocal in DonationInterface - https://phabricator.wikimedia.org/T324295 (10XenoRyet) [21:32:20] 10Fundraising Sprint C 2023, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Update DLocal createPayment for UPI / DIRECT method - https://phabricator.wikimedia.org/T324294 (10XenoRyet) [21:32:24] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint C 2023, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Handle IPNs from DLocal payins - https://phabricator.wikimedia.org/T324293 (10XenoRyet) [21:32:28] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint C 2023, 10Fundraising-Backlog, 10FR-Smashpig, and 2 others: Handle card submission in DLocal in DonationInterface - https://phabricator.wikimedia.org/T324290 (10XenoRyet) [21:32:32] 10Fundraising Sprint C 2023, 10Fundraising Sprint Vwl Cnsrvtn, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Donations queue consumer should write stats every minute - https://phabricator.wikimedia.org/T323162 (10XenoRyet) [21:32:38] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint C 2023, 10Fundraising-Backlog, 10FR-dlocal, and 2 others: Handle submission for DLocal REDIRECT methods in DonationInterface - https://phabricator.wikimedia.org/T324291 (10XenoRyet) [21:32:44] 10Fundraising Sprint C 2023, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface, 10Patch-For-Review: Add config to determine which DLocal payment methods use DIRECT or REDIRECT integration - https://phabricator.wikimedia.org/T324276 (10XenoRyet) [21:32:49] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint C 2023, 10Fundraising-Backlog, 10FR-Smashpig, and 2 others: Implement createHostedPayment for DLocal REDIRECT methods in SmashPig - https://phabricator.wikimedia.org/T324289 (10XenoRyet) [21:32:52] 10Fundraising Sprint C 2023, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Swap all our process logging to Civi::log('wmf') from watchdog() - https://phabricator.wikimedia.org/T288585 (10XenoRyet) [21:32:56] 10Fundraising Sprint C 2023, 10Fundraising-Backlog, 10FR-Docker: Docker dev setup: scope out use cases, requirements and command-line UI for breaking out setup.sh into smaller scripts - https://phabricator.wikimedia.org/T287028 (10XenoRyet) [21:33:00] 10Fundraising Sprint Amazing grep, 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint C 2023, 10Fundraising-Backlog, and 3 others: Japan Form Variations for Testing for Q3 - https://phabricator.wikimedia.org/T322793 (10XenoRyet) [21:33:05] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint C 2023, 10Fundraising Sprint NaN is a Number, 10Fundraising Sprint Overused petting Zoo Memetics, and 8 others: Creating New Matching Gift Import - https://phabricator.wikimedia.org/T303986 (10XenoRyet) [21:33:08] (03PS4) 10Eileen: [WIP] exception for civiimport [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/883674 [22:01:16] ejegg: so this continue button thingy [22:01:29] yep jgleeson [22:01:50] are you saying we want a default form with no payment options which shows a continue button that when pressed redirects us to dlocal [22:02:04] yep, exactly [22:02:49] ok so I guess our current naming of HostedPaymentProvider might get confusing [22:03:01] would it? [22:03:05] with ingenico it means cards in an iframe [22:03:12] and now with dlocal it means free for all [22:03:19] inc non-cards [22:03:35] right right, the essence is 'hosted' meaning a redirect to someone else's form [22:04:29] (03CR) 10Umherirrender: [C: 03+2] "Rebase after CR+2 needs resubmit" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885063 (owner: 10Ejegg) [22:04:51] on the frontend we'd be checking for no payment method I think? and then instantiating this new provider [22:04:53] XenoRyet: sent u a square version now [22:05:22] jgleeson ah I figured we would do this for the 'cash' top-level method [22:05:49] so we would just want to add a couple more lines to the payment-provider config in the SmashPig config [22:05:55] I'll add that now [22:05:59] ok that can work too although the dlocal form shows a whole bunch of available payment methods [22:06:06] inc ccs [22:06:14] credit cards [22:06:34] yep yep, probably we'll want to show submethod buttons eventually for non-card methods [22:06:48] if that's easy to do now we can do it [22:07:12] https://sandbox.dlocal.com/collect/select_payment_method?id=M-defb1f79-04b4-46a4-88a3-8398c91773d1&xtid=CATH-ST-1675202825-1822686373 [22:07:13] but if it's complicated (mapping submethod, etc) we can just have the continue button and show the payment method selection [22:07:18] I think that link can only be clicked once [22:07:21] so I won;t click it [22:07:22] yeah [22:07:38] ok cool I'll proceed with that [22:07:40] thanks [22:07:42] ! [22:07:47] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for khansen - https://phabricator.wikimedia.org/T328392 (10Dwisehaupt) SSL certificate renewed and sent via email. Password sent via SMS. [22:07:50] So I think it goes to the select_payment_method page when you don't send a bank code (aka payment method id) [22:08:23] but if we send the payment method type in our createHostedPayment call it will save a step for the donor and go straight to the details page for that method [22:08:42] yw jgleeson, i hope my assumptions are correct! [22:12:04] (03Merged) 10jenkins-bot: Add description parameter to dlocal authorize [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885063 (owner: 10Ejegg) [22:13:13] 10Fundraising Sprint Bridge over troubled Wifi, 10Fundraising Sprint Can't touch $this, 10Fundraising-Backlog, 10FR-dlocal, and 2 others: Handle submission for DLocal REDIRECT methods in DonationInterface - https://phabricator.wikimedia.org/T324291 (10jgleeson) So for this one, we're going to show a paymen... [22:15:19] ejegg: should be enough to whip something up. I won't sink too much time into it due to the likely priority vs other stuff [22:21:53] cool cool [22:26:38] jgleeson I'm about ready to C+2 damilare's createHostedPayment SmashPig patch. Did you have any outstanding concerns on that one? [22:37:17] (03PS1) 10Jgreen: WIP: first pass at porting to python3 [wikimedia/fundraising/tools/DjangoBannerStats] - 10https://gerrit.wikimedia.org/r/885435 (https://phabricator.wikimedia.org/T301905) [22:37:39] (03CR) 10CI reject: [V: 04-1] WIP: first pass at porting to python3 [wikimedia/fundraising/tools/DjangoBannerStats] - 10https://gerrit.wikimedia.org/r/885435 (https://phabricator.wikimedia.org/T301905) (owner: 10Jgreen) [22:38:27] (03PS3) 10Ejegg: Remove deleted hook MediaWikiPHPUnitTest::startTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/772053 (owner: 10Dylsss) [22:38:32] (03CR) 10Ejegg: [C: 03+2] Remove deleted hook MediaWikiPHPUnitTest::startTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/772053 (owner: 10Dylsss) [22:38:55] lemme take a look ejegg [22:40:06] (03Merged) 10jenkins-bot: Remove deleted hook MediaWikiPHPUnitTest::startTest [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/772053 (owner: 10Dylsss) [22:40:07] looks like I have some notes [22:40:09] dami review: [22:40:11] - $rawStatus = $rawResponse['status'] ?? '' could end up setting empty string [22:40:13] - $statusMapper->isSuccessStatus() sending in success status array but other one has them in class. [22:40:34] could you +1 it saying you're close to +2 and then I can re-review tomorrow first thing? [22:40:37] oh right, then he catches the UnexpectedValueException that's thrown by the normalizer [22:40:47] sure, sounds good jgleeson [22:40:59] I think I made those early in the patch chain [22:41:06] but yeah would be good to circle back [22:41:27] fr-tech I'm going to tag versions of SmashPig and DonationInterface to get the updates I need for the Pending resolver into CRM [22:46:21] (03PS1) 10Ejegg: Update SmashPig dependency and own version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885436 [22:46:24] (03CR) 10Ejegg: [C: 03+2] Update SmashPig dependency and own version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885436 (owner: 10Ejegg) [22:47:13] (03CR) 10CI reject: [V: 04-1] Update SmashPig dependency and own version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885436 (owner: 10Ejegg) [22:47:48] (03CR) 10Ejegg: "recheck" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885436 (owner: 10Ejegg) [22:47:55] (03CR) 10Ejegg: [C: 03+2] Update SmashPig dependency and own version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885436 (owner: 10Ejegg) [22:49:06] (03PS4) 10Ejegg: Civi ports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/885420 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [22:49:11] (03CR) 10Ejegg: [C: 03+2] Civi ports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/885420 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [22:51:01] (03CR) 10Ejegg: [C: 03+1] "OK, this looks pretty good to me. Leaving it unmerged to let Jgleeson take one more look tomorrow morning." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/883985 (https://phabricator.wikimedia.org/T324289) (owner: 10Damilare Adedoyin) [22:52:02] (03CR) 10Cstone: [C: 03+2] Update test email to something less likely to be real [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885341 (owner: 10Jgleeson) [22:52:41] (03PS2) 10Jgreen: WIP: first pass at porting to python3 [wikimedia/fundraising/tools/DjangoBannerStats] - 10https://gerrit.wikimedia.org/r/885435 (https://phabricator.wikimedia.org/T301905) [22:53:01] (03CR) 10CI reject: [V: 04-1] WIP: first pass at porting to python3 [wikimedia/fundraising/tools/DjangoBannerStats] - 10https://gerrit.wikimedia.org/r/885435 (https://phabricator.wikimedia.org/T301905) (owner: 10Jgreen) [22:54:58] (03PS4) 10Ejegg: Pass through description for Dlocal authorize call [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885052 [22:55:43] (03CR) 10Ejegg: [C: 03+2] Update SmashPig dependency and own version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885436 (owner: 10Ejegg) [22:56:07] 10Fundraising Sprint Can't touch $this, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Swap all our process logging to Civi::log('wmf') from watchdog() - https://phabricator.wikimedia.org/T288585 (10Cstone) In SmashpigRecurringProcessor.php there are a couple lines that w... [22:57:36] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review, 10Python3-Porting: modernize DjangoBannerStats to python3 - https://phabricator.wikimedia.org/T301905 (10AndyRussG) Thanks for all this!! For debugging through this locally: here's a draft fr-dev patch with setup and instructions... [22:59:01] 10Fundraising Sprint Can't touch $this, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Swap all our process logging to Civi::log('wmf') from watchdog() - https://phabricator.wikimedia.org/T288585 (10Cstone) In SmashpigRecurringProcessor.php there are a couple lines that w... [23:01:51] (03CR) 10CI reject: [V: 04-1] Update SmashPig dependency and own version [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/885436 (owner: 10Ejegg) [23:02:31] grr, looks like composer caching? [23:04:37] (03Merged) 10jenkins-bot: Civi ports [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/885420 (https://phabricator.wikimedia.org/T303986) (owner: 10Eileen) [23:04:39] (03Merged) 10jenkins-bot: Update test email to something less likely to be real [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885341 (owner: 10Jgleeson) [23:20:55] 10Fundraising Sprint Can't touch $this, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM, 10Fr-drupal-upgrade-2021: Swap all our process logging to Civi::log('wmf') from watchdog() - https://phabricator.wikimedia.org/T288585 (10Cstone) Looks like they showed up with -vv, I added it to the recurring... [23:27:28] (03PS3) 10Jgreen: WIP: first pass at porting to python3 [wikimedia/fundraising/tools/DjangoBannerStats] - 10https://gerrit.wikimedia.org/r/885435 (https://phabricator.wikimedia.org/T301905) [23:27:47] (03CR) 10jenkins-bot: WIP: first pass at porting to python3 [wikimedia/fundraising/tools/DjangoBannerStats] - 10https://gerrit.wikimedia.org/r/885435 (https://phabricator.wikimedia.org/T301905) (owner: 10Jgreen) [23:34:19] (03PS4) 10Jgreen: WIP: first pass at porting to python3 [wikimedia/fundraising/tools/DjangoBannerStats] - 10https://gerrit.wikimedia.org/r/885435 (https://phabricator.wikimedia.org/T301905) [23:34:42] (03CR) 10CI reject: [V: 04-1] WIP: first pass at porting to python3 [wikimedia/fundraising/tools/DjangoBannerStats] - 10https://gerrit.wikimedia.org/r/885435 (https://phabricator.wikimedia.org/T301905) (owner: 10Jgreen) [23:38:37] (03PS5) 10Jgreen: WIP: first pass at porting to python3 [wikimedia/fundraising/tools/DjangoBannerStats] - 10https://gerrit.wikimedia.org/r/885435 (https://phabricator.wikimedia.org/T301905)