[00:08:54] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for khaggard - https://phabricator.wikimedia.org/T328721 (10Dwisehaupt) [00:09:27] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for sharonr - https://phabricator.wikimedia.org/T328722 (10Dwisehaupt) [00:10:01] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for cdenes - https://phabricator.wikimedia.org/T328723 (10Dwisehaupt) [00:10:33] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for ayounsi - https://phabricator.wikimedia.org/T328724 (10Dwisehaupt) [01:37:09] RoanKattouw: argh, sorry I meant to reply to you on Slack [01:37:46] So we are definitely interested in updating our payment forms with some kind of modern Javascript [01:38:04] ejegg: No worries! I saw your thing in your bio saying you're not usually on Slack and to contact you here instead. Sorry for missing that when I first messaged you [01:38:17] and I've liked what I've seen of Vue so far, though I've just made a toy form or two with it [01:39:00] We used to have an internal dashboard built with knockout [01:39:31] it was also fun to work with but some of the event wiring got a little tedious. [01:39:59] At first glance I thought that vue would be less tedious but I don't remember exactly why right now [01:44:20] we haven't looked at Codex specifically, but any widgets we use would have to be able to blend in with some form fields that are rendered by payment processor JS. Those have some styling options but we don't have full control over them (by design, to keep the form PCI compliant) [01:46:22] The main nice things about Vue IMO are two-way bindings (you can say "the value of this input is X" and that will update the input if you change X and update X if the user changes the input) and state management with Vuex/Pinia [01:47:08] Ok, so it sounds like you may need theming to some extent, depending on how different Codex form fields look from the payment processor's [01:48:05] yep, although we don't need fancy widgets on the parts of the form that we register [01:48:21] it's all just text (or number) fields and a couple of dropdowns [01:48:21] I also imagine you might need more form field components than what we currently provide (https://doc.wikimedia.org/codex/latest/components/overview.html ), and/or form management/validation stuff, if you're mainly looking at forms [01:48:29] Oh OK that's good [01:48:32] validation, yes [01:48:45] We don't have a NumberInput component yet but it's planned [01:50:06] cool, cool. For validation we have some minimum values, some pattern matches (for countries that require a national tax ID number for online transactions), length and non-emptiness [01:50:07] Validation support is very rudimentary so far, all you can do right now is set TextInput to an error state, no other form field-like components have that yet [01:51:42] We haven't thought about an overarching validation strategy for the library yet, so for the time being it's probably just going to be that we offer error states for form fields to visually indicate an error, a component to display error/warning messages (https://doc.wikimedia.org/codex/latest/components/demos/message.html ), and then Codex consumers would be on their own for piecing those things together into actual validation [01:52:51] cool, we'd be happy to use it that way [01:56:30] 10Fundraising-Backlog: Add Online Banking for Czech Republic - https://phabricator.wikimedia.org/T328717 (10Ejegg) So the API calls look almost identical to iDEAL API calls, with the one difference being the value of paymentMethod.type. Looks like we would need to actually deploy it and find someone with a CZ b... [02:30:56] 10Fundraising-Backlog: Consult new field on Ingenico authorization response to determine retryability - https://phabricator.wikimedia.org/T327533 (10Ejegg) [02:56:16] (03PS2) 10Ejegg: Initiate recurring profiles in PayPal resolver [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886129 (https://phabricator.wikimedia.org/T324642) [03:34:49] (03PS1) 10Ejegg: [Don't Merge Yet] Remove orphan_slayer and DonationInterface [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886207 [03:35:28] but if not yet, when? [03:36:33] hehe, when we have deployed the PayPal pending txn resolver [03:36:52] just wanted to leave a glimpse of the bright future ahead [03:44:29] noice [03:50:41] (03PS1) 10AndyRussG: Consume phonetic names for Japan variant [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886208 (https://phabricator.wikimedia.org/T322793) [03:51:37] ejegg|away: heyy sorry I know it's late and you're away, apologies, just noting this ^ surprisingly simple once I got my head around it [03:52:04] thx much for the tips on that!!! [03:53:17] AndyRussG: ah there is one more tricky bit [03:53:40] ejegg|away: it does show up in the contact info with that patch [03:53:51] yep, that's great! [03:54:05] hmmm what more does one need then? [03:54:26] We just want the match-donor-on-import to also consider a phonetic name matching with the existing contact name [03:54:29] there was some special name processing somewhere? [03:54:41] yes, let me find it [03:54:44] ohhh oki I think I saw that bit [03:55:01] DR was worried this would create more duplicate contacts if we didn't do the extra matching [03:55:12] getExistingContactID [03:55:15] when it decides whether to create or update a contact [03:55:17] right [03:55:26] $email->addWhere('contact_id.first_name', '=', $msg['first_name']) [03:55:57] so you change that to be i think $email->addWhere('contact_id.first_name', 'IN', [ first, first_phonetic ]) [03:56:06] ditto with last [03:56:53] hmm or maybe a bit more complicated, only add the phonetic versions to the where clause when they are non-blank [03:57:27] yeah exactly [04:01:02] ejegg|away: but there we need the internal custom field name, no? [04:01:27] or we're only looking up the non-phonetic names? [04:14:38] AndyRussG: I think for now it's OK to just match the incoming phonetic name against the saved first_name / last_name fields [04:14:42] (03PS2) 10AndyRussG: Consume phonetic names for Japan variant [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886208 (https://phabricator.wikimedia.org/T322793) [04:14:51] ejegg|away: ^ [04:14:58] since it's to match donors from last year when there was no phonetic bit [04:15:03] yeah that's how I did it [04:15:08] cool cool [04:17:42] so if you wanted to add tests for that you would add something like testUpdateLanguageWithContactExisting in ImportMessageTest (still back in the wmf_civicrm drupal module, not in the new CiviCRM extension) [04:18:26] ejegg|away: ahh oki [04:19:40] k, away for real now. See ya! [04:20:15] ejegg|away: thx so much, safe travels, have fun!!! [13:47:01] (03CR) 10Jgleeson: "Thanks for laying the foundations on this Wfan! I'm gonna build on this for the catch-all dlocal payment form." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/874932 (https://phabricator.wikimedia.org/T324276) (owner: 10Wfan) [14:12:56] (03PS8) 10Jgreen: WIP: first pass at porting to python3 [wikimedia/fundraising/tools/DjangoBannerStats] - 10https://gerrit.wikimedia.org/r/885435 (https://phabricator.wikimedia.org/T301905) [16:42:10] PROBLEM - check_log_messages on frav1002 is CRITICAL: reading conf /etc/check_log_messages.conf https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [16:43:29] 10Fundraising-Backlog: Consult new field on Ingenico authorization response to determine retryability - https://phabricator.wikimedia.org/T327533 (10EMartin) A better title for this task, Elliott! Just notating here again that this is on hold per Ingenico (see above). I'll post updates as they provide them. [16:46:11] 10Fundraising-Backlog: Add Online Banking for Czech Republic - https://phabricator.wikimedia.org/T328717 (10EMartin) Noted. Let me know when we have something to test and we'll find someone! [16:47:10] PROBLEM - check_log_messages on frav1002 is CRITICAL: reading conf /etc/check_log_messages.conf https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [16:52:10] PROBLEM - check_log_messages on frav1002 is CRITICAL: reading conf /etc/check_log_messages.conf https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [16:57:10] RECOVERY - check_log_messages on frav1002 is OK: reading conf /etc/check_log_messages.conf https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:07:12] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: check_endpoints_critical (Paypal:2) 2 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:12:09] PROBLEM - check_log_messages on frav1002 is CRITICAL: CRITICAL: check_endpoints_critical (Paypal:2) 2 [=1] https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:13:28] ACKNOWLEDGEMENT - check_log_messages on frav1002 is CRITICAL: CRITICAL: check_endpoints_critical (Paypal:2) 2 [=1] Jeff_Green known https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:22:14] RECOVERY - check_log_messages on frav1002 is OK: OK https://icinga.wikimedia.org/cgi-bin/icinga/extinfo.cgi?type=2&host=frav1002&service=check_log_messages [17:23:15] (03PS10) 10Wfan: Add default payment_method for each payment_methods.yaml for old gateway link that contains no payment_method that cause broken link [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876044 (https://phabricator.wikimedia.org/T140269) [17:24:53] (03CR) 10CI reject: [V: 04-1] Add default payment_method for each payment_methods.yaml for old gateway link that contains no payment_method that cause broken link [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/876044 (https://phabricator.wikimedia.org/T140269) (owner: 10Wfan) [17:59:22] (03PS30) 10Damilare Adedoyin: IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [18:01:01] (03CR) 10CI reject: [V: 04-1] IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [18:12:31] (03PS31) 10Damilare Adedoyin: IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [18:29:05] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review, 10Python3-Porting: modernize DjangoBannerStats to python3 - https://phabricator.wikimedia.org/T301905 (10Jgreen) [18:42:31] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10Patch-For-Review, 10Python3-Porting: modernize DjangoBannerStats to python3 - https://phabricator.wikimedia.org/T301905 (10Jgreen) [19:24:34] (03PS9) 10Jgreen: WIP: first pass at porting to python3 [wikimedia/fundraising/tools/DjangoBannerStats] - 10https://gerrit.wikimedia.org/r/885435 (https://phabricator.wikimedia.org/T301905) [19:29:20] (03PS32) 10Damilare Adedoyin: IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [19:30:55] (03CR) 10CI reject: [V: 04-1] IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [19:37:14] (03PS33) 10Damilare Adedoyin: IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [19:38:47] (03CR) 10CI reject: [V: 04-1] IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [19:49:43] 10Fundraising-Backlog, 10LDAP-Access-Requests: LDAP access to the wmf group for Anil Kanji - https://phabricator.wikimedia.org/T328805 (10Dwisehaupt) [21:16:38] (03PS34) 10Damilare Adedoyin: IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [21:17:28] (03PS10) 10Jgreen: WIP: first pass at porting to python3 [wikimedia/fundraising/tools/DjangoBannerStats] - 10https://gerrit.wikimedia.org/r/885435 (https://phabricator.wikimedia.org/T301905) [21:18:16] (03CR) 10CI reject: [V: 04-1] IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [21:21:38] (03PS35) 10Damilare Adedoyin: IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [21:23:18] (03CR) 10CI reject: [V: 04-1] IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [21:24:05] (03PS36) 10Damilare Adedoyin: IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [21:25:02] sorry AndyRussG for all the notifications, I tried changing the Author of the patch but it doesn't seem to work on gerrit [21:25:38] (03CR) 10jenkins-bot: IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [21:25:46] heyyy damilare no worries of course [21:26:17] tnx [21:26:36] hmmm I was pretty sure once years ago I found a way to do it... I'll dig around a bit in my notes :) [21:26:48] thank u! :) [21:28:15] (03PS37) 10Damilare Adedoyin: IP Velocity Filter: Increase count after first run [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/859168 (https://phabricator.wikimedia.org/T323544) (owner: 10AndyRussG) [21:34:24] see you all next week [21:53:58] (03CR) 10Wfan: Consume phonetic names for Japan variant (032 comments) [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886208 (https://phabricator.wikimedia.org/T322793) (owner: 10AndyRussG) [21:56:50] (03CR) 10AndyRussG: "thanks so much for the review!!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/886208 (https://phabricator.wikimedia.org/T322793) (owner: 10AndyRussG)