[00:52:39] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10Wikimedia-Fundraising-CiviCRM: Civi security update (minor) due out - https://phabricator.wikimedia.org/T329681 (10Eileenmcnaughton) a:03Eileenmcnaughton [01:28:05] (03PS1) 10Eileen: CiviCRM 5.58 update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/889654 (https://phabricator.wikimedia.org/T329681) [01:34:56] (03CR) 10CI reject: [V: 04-1] CiviCRM 5.58 update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/889654 (https://phabricator.wikimedia.org/T329681) (owner: 10Eileen) [01:47:29] (03PS2) 10Eileen: CiviCRM 5.58.1 update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/889654 (https://phabricator.wikimedia.org/T329681) [02:33:56] I have the civicrm security update ready to go ... https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/889654 [02:35:12] 10Fundraising-Backlog, 10FR-Japan: Make the Japan "V1" payment wiki variant the new control - https://phabricator.wikimedia.org/T329807 (10TSkaff) [04:29:54] looks good codewise eileen , will smoke test locally [04:30:06] cool - I put it on staging too [04:35:26] (03CR) 10Ejegg: [C: 03+2] CiviCRM 5.58.1 update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/889654 (https://phabricator.wikimedia.org/T329681) (owner: 10Eileen) [04:35:57] thanks! [04:36:53] sure thing! [04:37:13] Oh nice, your exchange rates exception move is passing tests too [04:37:27] (03PS5) 10Ejegg: Move ExchangeRate exceptions to fledgling extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801835 (owner: 10Eileen) [04:37:38] (03CR) 10Ejegg: [C: 03+2] "Looks good!" [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801835 (owner: 10Eileen) [04:50:08] (03Merged) 10jenkins-bot: CiviCRM 5.58.1 update [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/889654 (https://phabricator.wikimedia.org/T329681) (owner: 10Eileen) [04:52:12] (03Merged) 10jenkins-bot: Move ExchangeRate exceptions to fledgling extension [wikimedia/fundraising/crm] - 10https://gerrit.wikimedia.org/r/801835 (owner: 10Eileen) [05:48:39] (03PS1) 10Eileen: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/889659 [05:48:54] (03CR) 10Eileen: [C: 03+2] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/889659 (owner: 10Eileen) [05:49:53] (03Merged) 10jenkins-bot: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - 10https://gerrit.wikimedia.org/r/889659 (owner: 10Eileen) [06:15:52] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for afowler - https://phabricator.wikimedia.org/T329536 (10Dwisehaupt) SSL certificate renewed and sent via email. Password sent via SMS. [11:05:08] (03CR) 10Jgleeson: "Thanks for adding the tests! I did have an additional request. Thanks" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889565 (owner: 10Damilare Adedoyin) [12:12:38] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-Translate, 10Language-Team (Language-2023-January-March), and 3 others: Move classes in the Translate root directory to namespace - https://phabricator.wikimedia.org/T313242 (10Wangombe) [12:13:15] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog, 10MediaWiki-extensions-Translate, 10Language-Team (Language-2023-January-March), and 3 others: Move classes in the Translate root directory to namespace - https://phabricator.wikimedia.org/T313242 (10Wangombe) [13:26:43] 10Wikimedia-Fundraising-CiviCRM: Civi - Event Activity Update - https://phabricator.wikimedia.org/T329800 (10Aklapper) [13:55:11] 10Fundraising-Backlog, 10FR-dlocal: Refactor the current dLocal StatusNormalizers. - https://phabricator.wikimedia.org/T329838 (10jgleeson) [13:56:10] (03PS1) 10Jgleeson: Update status list in PaymentStatusNormalizer [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889804 [14:33:40] (03PS2) 10Jgleeson: Update status list in PaymentStatusNormalizer [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889804 (https://phabricator.wikimedia.org/T324291) [14:34:45] thanks jgleeson for the CR, I'd push a follow on shortly [14:35:31] np damilare. thanks! [14:35:46] be back soon, gotta go pick the kids up, again! half-term problems [14:53:06] 10fundraising-tech-ops, 10decommission-hardware: decommission frpm1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T329752 (10Jgreen) [14:58:53] 10fundraising-tech-ops, 10decommission-hardware: decommission frpm1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T329752 (10Jgreen) [15:07:05] 10Fundraising-Backlog: clean up trailing numbers from email addresses in payment provider audit files - https://phabricator.wikimedia.org/T313062 (10Jgreen) Sorry, somehow I didn't see this comment when you posted it! >>! In T313062#8102967, @greg wrote: > Questions from Jeff: > > Can we just make the audit pr... [15:07:56] 10fundraising-tech-ops: reimage fundraising build (frpm) role servers to Bullseye - https://phabricator.wikimedia.org/T305972 (10Jgreen) a:03Jgreen [15:15:48] Jeff_Green: I might make a mug for frpm1001 [15:16:02] lol do it! [15:16:09] he's been with us for a while! [15:17:17] this reminds me of my old accountant when we lived in San Francisco, who had his old adding machine mounted on a plaque on the wall which said something about its years of service [15:18:13] I hope you have a big shelf [15:18:14] he still worked that way, he'd go through your taxes during the appointment and hand you about 15ft of output from his replacement adding machine [15:18:26] ha [15:18:30] lol wow [15:33:25] 10Fundraising-Backlog: review civi orphan rectifier log use - https://phabricator.wikimedia.org/T272150 (10Jgreen) 05Open→03Declined I made educated guesses since this task never made it past triage. [15:38:16] 10Fundraising-Backlog-Old, 10Wikimedia-Fundraising-CiviCRM: we need a failsafe deployment process for civicrm triggers/procedures - https://phabricator.wikimedia.org/T210023 (10Jgreen) Task never made it past triage, closing after 4 years. [15:38:23] 10Fundraising-Backlog-Old, 10Wikimedia-Fundraising-CiviCRM: we need a failsafe deployment process for civicrm triggers/procedures - https://phabricator.wikimedia.org/T210023 (10Jgreen) 05Open→03Declined [15:39:32] 10Fundraising Sprint Airline Passenger Experience, 10Fundraising Sprint Anti-matter doesn't matter, 10Fundraising Sprint Bee Wheel, 10Fundraising Sprint Cheese String Theory, and 48 others: Fr-tech chores list - https://phabricator.wikimedia.org/T258527 (10Aklapper) [15:41:44] 10Fundraising-Backlog: civicrm failed outbound connections to https://www-prod.civicrm.osuosl.org - https://phabricator.wikimedia.org/T232094 (10Jgreen) 05Open→03Declined Closing because this task never made it past triage after 3+ years. [15:41:58] ha [15:44:05] 10fundraising-tech-ops: FY2020-21 Q3 maintenance window - https://phabricator.wikimedia.org/T268056 (10Jgreen) [15:44:07] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Epic: Epic: fundraising database scalability - https://phabricator.wikimedia.org/T241083 (10Jgreen) [15:44:12] 10Fundraising-Backlog, 10fundraising-tech-ops: examine the possibility of purging data from civicrm.civicrm_activity - https://phabricator.wikimedia.org/T261353 (10Jgreen) 05Open→03Resolved a:03Jgreen Looks like this was investigated and partially completed. [15:46:15] 10fundraising-tech-ops: encrypt fundraising database client->server communication - https://phabricator.wikimedia.org/T170321 (10Jgreen) a:03Jgreen Claiming to take care of the remaining DjangoBannerStats part of this. [15:50:26] 10Fundraising-Backlog, 10FR-Paypal: reevaluate legacy recurring paypal subscriptions tied to old fundraising domains - https://phabricator.wikimedia.org/T170414 (10Jgreen) 05Open→03Declined Never made it past triage after 5+ years, although it looks from logs as though these redirects are no longer being h... [15:51:05] 10Fundraising-Backlog, 10FR-dlocal: Refactor the current dLocal StatusNormalizers. - https://phabricator.wikimedia.org/T329838 (10SuvamManna) May I work on this issue? [15:55:05] 10Fundraising-Backlog, 10Patch-For-Review: figure out Buster package for python3-mysql.connector for use with fruec - https://phabricator.wikimedia.org/T246823 (10Jgreen) 05Open→03Declined Declining this task since it didn't make it past triage after 3 years, and since the Fruec project is stalled. [15:55:07] 10Fundraising Sprint Asymmetrical Earth Theory, 10Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), 10Fundraising Sprint Cottage Cheese isn't Made of Cottages, 10Fundraising-Backlog, 10Epic: [Epic] Fundraising kafkatee changes - https://phabricator.wikimedia.org/T183978 (10Jgreen) [15:55:09] 10fundraising-tech-ops: encrypt fundraising database client->server communication - https://phabricator.wikimedia.org/T170321 (10Jgreen) [15:57:37] 10Fundraising-Backlog: Get fr-tech folks set up with icinga access and familiarized on 'ack'-ing alerts - https://phabricator.wikimedia.org/T259259 (10Jgreen) 05Open→03Declined Didn't make it past triage after 2+ years. Closing. [16:00:12] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Epic: [FR Analytics]: Overhaul /srv/br - https://phabricator.wikimedia.org/T178953 (10Jgreen) [16:00:14] 10Fundraising-Backlog, 10fundraising-tech-ops: [FR Analytics]: move frdev1001:/srv/br/analytics out to it's own directory - https://phabricator.wikimedia.org/T258601 (10Jgreen) [16:00:56] 10Fundraising-Backlog, 10fundraising-tech-ops, 10Epic: Epic: Fundraising Analytics Tools - https://phabricator.wikimedia.org/T212796 (10Jgreen) [16:02:42] 10Fundraising-Backlog: Recent up tick in fail mail - https://phabricator.wikimedia.org/T126482 (10Jgreen) 05Open→03Declined This is a 6 year old task which points to issues that have been dealt with separately. [16:04:07] 10Fundraising-Backlog: process-conotrol jobs should target a host - https://phabricator.wikimedia.org/T161931 (10Jgreen) 05Open→03Resolved a:03Jgreen This has been addressed in how process-control configuration is loaded. [16:05:09] 10Fundraising-Backlog, 10MediaWiki-Vagrant: Make it easier to use the fundraising puppet role on labs - https://phabricator.wikimedia.org/T102304 (10Jgreen) 05Open→03Declined Ancient task, no longer relevant. [16:09:28] 10Fundraising-Backlog, 10fundraising-tech-ops: Issue new SSL Client Certificate for jgreen - https://phabricator.wikimedia.org/T329542 (10Jgreen) 05Open→03Resolved [16:17:49] (03PS1) 10Damilare Adedoyin: Add null fallback for Payment Status [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889820 [16:25:48] (03PS10) 10AndyRussG: [WIP] jobs service [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841441 (https://phabricator.wikimedia.org/T301905) [16:29:06] (03PS11) 10AndyRussG: [WIP] jobs service [wikimedia/fundraising/dev] - 10https://gerrit.wikimedia.org/r/841441 (https://phabricator.wikimedia.org/T301905) [16:29:28] 10Fundraising-Backlog, 10FR-dlocal: Refactor the current dLocal StatusNormalizers. - https://phabricator.wikimedia.org/T329838 (10jgleeson) Hi there @SuvamManna Sure, you can work on it if you feel you could do that independently without much mentoring. It's a busy period for us at the moment so we can't offe... [16:46:13] (03PS1) 10Wfan: Add unit test for cancelPayment [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889824 (https://phabricator.wikimedia.org/T324727) [16:52:06] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10FR-dlocal: Add error handling to backend SmashPig API calls - https://phabricator.wikimedia.org/T324691 (10Damilare) a:03Damilare [17:03:28] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: GatewayChooser: No supported gateway for parameters - https://phabricator.wikimedia.org/T326666 (10Pcoombe) Okay, done those @AnnWF [17:16:53] (03CR) 10Wfan: [C: 03+2] Add callback_url to redirect API params [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889605 (owner: 10Damilare Adedoyin) [17:17:25] (03Merged) 10jenkins-bot: Add callback_url to redirect API params [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889605 (owner: 10Damilare Adedoyin) [17:24:37] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Reverify payments.wikimedia.org for ApplePay (Production) - https://phabricator.wikimedia.org/T329723 (10greg) p:05Triage→03High [17:24:43] 10Fundraising Tech - Chaos Crew, 10Fundraising-Backlog: Get all fr-tech engineers added to the WMF Developer Account - https://phabricator.wikimedia.org/T329724 (10greg) p:05Triage→03Medium [17:34:01] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10FR-dlocal, 10Patch-For-Review: Separate astropay (old dlocal) config from dlocal config - https://phabricator.wikimedia.org/T328701 (10Cstone) [18:06:42] (03CR) 10Ejegg: "looks pretty good, just a couple little things could be changed" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888280 (https://phabricator.wikimedia.org/T328701) (owner: 10Cstone) [18:55:10] 10fundraising-tech-ops: Switch-over from civi1001 to civi1002 - https://phabricator.wikimedia.org/T329882 (10Jgreen) [18:55:19] 10Fundraising-Backlog, 10FR-Japan: Make the Japan "V1" payment wiki variant the new control - https://phabricator.wikimedia.org/T329807 (10TSkaff) @XenoRyet Hang on, we actually want to pause this request for now, b/c there might be a 2nd Japan pre-test! I will ping again when we're ready to make this control... [19:03:08] (03CR) 10Ejegg: [C: 04-1] "Let's update this to be consistent with the way we're handling other API calls in dlocal - maybe even with its own PaymentResponseFactory " [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889629 (https://phabricator.wikimedia.org/T324727) (owner: 10Wfan) [19:06:00] Thanks for the review will do the update [20:06:33] (03CR) 10Ejegg: "This looks like an improvement! Just one suggestion inline." [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889820 (owner: 10Damilare Adedoyin) [20:11:28] (03PS2) 10Damilare Adedoyin: Add null fallback for Payment Status [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889820 [20:12:27] (03CR) 10Damilare Adedoyin: "Done! thanks ejegg" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889820 (owner: 10Damilare Adedoyin) [20:34:14] (03PS1) 10Damilare Adedoyin: Add error handling to backend SmashPig API calls [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889860 (https://phabricator.wikimedia.org/T324691) [20:34:50] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10FR-Smashpig, 10FR-dlocal: Add Idempotency headers to DLocal API calls - https://phabricator.wikimedia.org/T326772 (10Ejegg) a:03Ejegg [20:38:25] (03PS3) 10Ejegg: Add null fallback for Payment Status [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889820 (owner: 10Damilare Adedoyin) [20:38:30] (03CR) 10Ejegg: [C: 03+2] Add null fallback for Payment Status [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889820 (owner: 10Damilare Adedoyin) [20:39:01] (03Merged) 10jenkins-bot: Add null fallback for Payment Status [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889820 (owner: 10Damilare Adedoyin) [20:39:17] thanks for the CR ejegg [20:39:25] sure thing damilare [20:39:48] oops, forgot to take down my |away flag all day! [20:42:29] (03PS1) 10Ejegg: Add idempotency headers to dlocal request [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889861 (https://phabricator.wikimedia.org/T326772) [20:46:17] o/ bye for now fr-tech [20:46:25] bye [20:46:52] (03PS2) 10Wfan: Add bank transfer submethods that supported by dlocal [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/889188 (https://phabricator.wikimedia.org/T328976) [21:08:32] (03CR) 10Ejegg: "Agreed with damilare on adding the redirect_url to the var_map. Also we should restore the logo: keys for bt & cash submethods." [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/874932 (https://phabricator.wikimedia.org/T324276) (owner: 10Wfan) [21:18:03] I think I merged but didn't deploy the security update last night - gonna deploy now if that is the case [21:20:23] (03PS3) 10Cstone: Separate astropay (old dlocal config) from dlocal (new dlocal config) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888280 (https://phabricator.wikimedia.org/T328701) [21:20:41] (03CR) 10Ejegg: "Oops, I see you add back the logo: keys in the next patch. A couple more suggestions inline" [extensions/DonationInterface] - 10https://gerrit.wikimedia.org/r/874932 (https://phabricator.wikimedia.org/T324276) (owner: 10Wfan) [21:21:09] !log civicrm upgraded from efa4c485 to ffc16d2d [21:21:11] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:21:36] (03CR) 10Cstone: Separate astropay (old dlocal config) from dlocal (new dlocal config) (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888280 (https://phabricator.wikimedia.org/T328701) (owner: 10Cstone) [21:22:57] ejegg: Isn't all cc direct? Also, seems like not the callback_url but the return_url right? [21:27:38] wfan yes, all cc is direct - so we should only need the logo: keys for bt and cash submethods [21:28:05] right, we use return_url up at the donation interface layer and then map it to callback_url down in SmashPig to send to dlocal [21:28:32] ack, right, return_url, not redirect_url [21:29:54] ah, and we would want to add that 'return_url' key to the transactions array too [21:31:21] we have a ReturnUrl staging helper that should create the value for you [21:31:48] so we can just add that to the transformers.yaml [21:32:17] Ah, I see it - ReturnUrl at the transformers.yaml [21:33:22] And we'll want to stage up that bank_code as well [21:33:43] huh, I don't remember why we did that in AstroPayFinancialNumbers, but you could do it there I guess [21:34:16] I don't like that - we should break that class into two [21:34:34] because I don't think we need the donor_id for the new API [21:34:59] bank_code is not been for dlocal used I think, feel like we only use the payment_method_id [21:35:53] ahh ok, so we just send the payment_submethod to the SmashPig API call and then map it to the payment_method_id in SmashPig? [21:36:11] yep~ [21:36:20] cool cool, that makes things simpler [21:36:57] So are we using those bank_code: keys from the payment_submethod.yaml anywhere? [21:37:42] Do not fine it been used anywhere yet, but I realized the logo thing until we do the redirect [21:37:44] so will see [21:38:38] ok, cool [21:44:11] ok, so we still need to add the code in SmashPig to do that mapping, it seems like [21:49:05] Actually, the bank_code from the payment_submethod.yaml is the payment_method_id we need in Smashpig createPayment, I thougth the bank code was the numeric one that gloabl collect used, so for dlocal I think we needs to stage up the bank_code! [21:49:26] As you suggested, right, we did not do that since cc only use CARD, but bank transfer need the bank_code [21:49:33] for payment_method_id [21:49:40] wfan if we could do it in the SmashPig layer that would be my preference [21:49:51] I like the idea of just sending payment_submethod to smashpig [21:50:01] Oh, ok, then map is needed [21:50:15] we have an AstroPay\ReferenceData class that has the map [21:50:43] but we would have to add some methods for the reverse lookup since right now it only goes from dlocal codes to our names [21:50:43] wfan: ejegg can you hold off +2ing that patch for now. it looks like there is a bunch of updates that clash with the cash redirect flow here https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/884899/ here that was intended to serve as the base for the bank transfer flow [21:51:09] oh shoot! [21:51:35] ok, let's choose one or the other [21:51:43] I'll look at that one jgleeson [21:53:12] I mentioned I was gonna use that as a starting point here https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/874932/4#message-3a53f175cd84598304416053e7deda4f1e7870c0 [21:53:26] sorry if that wasn't clear [21:54:04] I think we can take some of both patches but there is overlap that I can see. Specifically the JS and the redirect handling [21:54:19] oh i see, I read 'build on this' as meaning you would write a patch that followed [21:54:24] Ah, seems like I could update my patch to only handle direct and redirect based on cc, and your's would do the rest redirect stuff, thanks Jack~ [21:54:59] can we rebase one over the other to make that clear? [21:55:26] we could but I'm logging off shortly and was hoping to push it up finished before I do [21:55:30] I can rebase mine~ [21:55:31] ok [21:56:00] well I guess I shouldn't start the recurring stuff until we get this sorted out at least [21:56:14] i'll drop it back in backlog rather than create more merge conflicts! [21:56:17] the redirect stuff is a bit more complicated [21:56:23] as there are two types of redirect URL [21:56:24] but seems like jack's patch has some unit test warnings [21:56:29] lemme get the other patch [21:57:08] wfan: I think that's because smashpig needs updating with this patch [21:57:17] it's complaining that it can't mock stuff [21:57:39] ok noted~ [21:57:55] https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/SmashPig/+/888077/1/PaymentProviders/dlocal/DlocalCreatePaymentResponseFactory.php [21:58:14] but then the commends from dami and elliott also applied to your patch with the var_map for additional return_url right? [21:58:16] that code shows two types of redirect [21:59:12] ok, so 3d secure has another redirect url~ [21:59:43] ya [22:00:20] jgleeson: that patch looks pretty solid, i just had one comment if you want to take it out of WIP [22:00:45] oh oops, two comments [22:00:55] ejegg: I'm just finishing off the pending-poke authorize flow. it's changed a bit since that [22:00:59] Mind if I click 'start review' ? [22:01:03] lemme push up the latest [22:01:07] ah ok [22:02:27] hmm feel free to leave comments ejegg but it's probably not ready for review yet as I haven't cleaned the code yet. [22:02:40] although if there's anything fundamental feel free to note it [22:03:13] sorry wfan I should have tried to sync up with you soon on this [22:03:18] we could have paired up! [22:03:31] I've been distracted this week a little [22:03:41] the kids have been off school and we have mepps leaving [22:03:55] Ah my bad, did not realized that we have this conf since I think my patch is a easy one since we now only use cc 😂 [22:03:55] sooner* [22:04:03] (03CR) 10Ejegg: "This change is ready for review." (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888077 (https://phabricator.wikimedia.org/T324302) (owner: 10Jgleeson) [22:04:19] ack, I didn't write that ^^^ [22:04:31] I just had to click the 'start review' button to publish the comments [22:05:17] oh yeah ejegg the 3dsecure stuff is only a first pass. sorry I thought you meant you wanted to take the REDIRECT flow stuff out of WIP [22:05:42] I picked the 3dsecure stuff up when we were blocked for a day on the REDIRECT stuff [22:05:59] feel free to make any changes to that one [22:06:27] ok, thanks! Will try to give it a manual rebase too [22:06:34] looks like you've been really busy! [22:06:48] plenty of stuff in progress here [22:06:56] not so much this week! ha [22:07:05] but the kids go back to school Monday :) [22:10:54] (03PS2) 10Ejegg: Implement 3DSecure for DLocal cards [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888077 (https://phabricator.wikimedia.org/T324302) (owner: 10Jgleeson) [22:11:07] (03CR) 10Ejegg: "PS2: manual rebase" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888077 (https://phabricator.wikimedia.org/T324302) (owner: 10Jgleeson) [22:11:46] (03CR) 10CI reject: [V: 04-1] Implement 3DSecure for DLocal cards [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888077 (https://phabricator.wikimedia.org/T324302) (owner: 10Jgleeson) [22:12:25] (03PS9) 10Cstone: WIP: Create IPN listener for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) [22:12:56] (03CR) 10CI reject: [V: 04-1] WIP: Create IPN listener for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/885920 (https://phabricator.wikimedia.org/T324293) (owner: 10Cstone) [22:13:08] ^^ thats still WIP cause i want the other config patch to merge than I'll update the code, and some data still needs to be worked out with the queue message but it will put things on the donations queue if people want to look at that while im gone [22:13:40] cstone: haven't you got a plane to catch! [22:13:52] haha this one isnt till 7pm [22:14:16] (03PS3) 10Ejegg: Implement 3DSecure for DLocal cards [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888077 (https://phabricator.wikimedia.org/T324302) (owner: 10Jgleeson) [22:14:18] is there not 2-3 hour security check-in where you are? [22:14:26] not a* [22:14:36] nah like 5 minutes? haha i paid extra for that and gave the government all my info though.... [22:14:43] ah nice [22:14:47] im also like 20 minutes from the airpor jgleeson [22:14:48] t [22:15:00] over here we have to be at the airport like 3-hours before the flight [22:15:13] denver airport at 5am is a different story but a 7pm flight there should be no security line [22:15:19] or we did the last time I flew to Turkey last year [22:15:34] nice [22:15:53] im not the best at being prepared at airports though ive run through denver and others more than other people probably haha [22:16:30] (03CR) 10Ejegg: Implement 3DSecure for DLocal cards (032 comments) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888077 (https://phabricator.wikimedia.org/T324302) (owner: 10Jgleeson) [22:17:25] jgleeson: is there somewhere you anticipate us needing to send that 3dsecure => [ 'force' => true ] flag, or is that mostly just for testing? [22:18:37] it gets sent with the createPayment call I think [22:18:58] https://docs.dlocal.com/docs/3d-secure [22:19:23] so would we want to force it some places? I thought they generally would tell us whether the bank needed it, and if the bank doesn't then we're fine without it. [22:20:21] oh rly. maybe I misunderstoof [22:20:25] misunderstood [22:20:26] I do think it was good to have included it in that smashpig call! [22:20:57] I guess I was expecting us to check in DI whether we needed it and flag it for the smashpig call [22:21:36] yeah, according to the docs, if it's mandatory they just send it back anyway [22:21:46] so maybe we don't need the hard flag [22:22:17] It will probably make testing the DI flow easier though - we can just hack a quick line to send that param into the code [22:22:27] if they don't have good test cases [22:22:57] I think for ingenico we trigger it for our side [22:23:06] from* our side [22:23:14] ah yeah [22:23:19] and I was following that. although that might be different [22:23:23] right, that's why we have the global var [22:25:37] hmm the more I look at these new static factory methods, the more I wonder if they are the answer [22:25:49] it just feels odd for some reason [22:26:55] feels the factory methods are doing too much [22:27:12] and possibly another design might be more suited. [22:32:06] have a great trip cstone ! [22:34:13] thanks jgleeson [22:35:33] fr-tech I'm going to head out to the airport soonish but I'll be on a train for a while so I'll still be around in text mode a bit [22:36:21] btw cstone mepps messaged me earlier on whatsapp to say she got the mug. I asked her if it was a good print but she hasn't replied yet [22:36:46] just in time for her morning coffee in her new job next week ha! [22:39:02] oh ha, she just replied now https://drive.google.com/file/d/1m2zrAWP1GNje6-x-9ycMt9RI2uiW6vC8/view?usp=sharing [22:39:49] nice that was fast! [22:41:39] 10Fundraising Sprint Drop It Like It's Fraud, 10Fundraising-Backlog, 10FR-dlocal, 10MediaWiki-extensions-DonationInterface: Support DLocal recurring cards in DonationInterface - https://phabricator.wikimedia.org/T324297 (10Ejegg) Dropping this back in backlog because there's too much in progress in Donatio... [22:42:16] yay [22:43:38] 10fundraising-tech-ops: reimage fundraising queue role servers to Bullseye - https://phabricator.wikimedia.org/T327453 (10Dwisehaupt) [22:51:02] (03CR) 10Ejegg: "Looks pretty solid! I'd just loosen up the allowed 'recurring' value. One question about the seemingly duplicated Api::captureRecurringPay" [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889588 (https://phabricator.wikimedia.org/T324296) (owner: 10Damilare Adedoyin) [22:54:57] (03PS4) 10Ejegg: Separate astropay (old dlocal config) from dlocal (new dlocal config) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888280 (https://phabricator.wikimedia.org/T328701) (owner: 10Cstone) [22:55:08] (03CR) 10Ejegg: [C: 03+2] Separate astropay (old dlocal config) from dlocal (new dlocal config) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888280 (https://phabricator.wikimedia.org/T328701) (owner: 10Cstone) [22:55:44] (03Merged) 10jenkins-bot: Separate astropay (old dlocal config) from dlocal (new dlocal config) [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/888280 (https://phabricator.wikimedia.org/T328701) (owner: 10Cstone) [22:56:45] hmm, ^^^ may need a deploy note [22:59:34] (03PS3) 10Wfan: Add cancel payment for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889629 (https://phabricator.wikimedia.org/T324727) [23:00:02] (03CR) 10CI reject: [V: 04-1] Add cancel payment for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889629 (https://phabricator.wikimedia.org/T324727) (owner: 10Wfan) [23:01:09] Thanks ejegg !! And yeah we should extra test it [23:02:14] (03PS4) 10Wfan: Add cancel payment for dlocal [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889629 (https://phabricator.wikimedia.org/T324727) [23:07:59] cstone: yep, I'm just thinking we need to update the config yaml on prod and maybe also the ipn URL and even apache config [23:08:07] though we can do all that before the deploy [23:08:16] lemme get started, actually [23:11:14] cstone: Wishing you a great trip to Canada and happy birthday February 18th~ [23:11:24] Haha happy birthday to you February 19!!! [23:11:39] yes, happy birthday to you both and have a great trip cstone! [23:11:57] I'll be at fanexpo Vancouver haha [23:16:26] happy birthdays all around! [23:16:48] It was damilare|away's birthday last week too. Feb is a big birthday month for fr-tech! [23:18:53] heh, it's my half-birthday in Feb... [23:20:30] half birthday?! [23:21:08] are you a leap year baby ejegg ? [23:21:46] heh, no, just 6 months from my actual birthday [23:22:08] are you familiar with Pirates of Penzance? [23:22:23] (random association with leapyear babies) [23:22:46] ah I see. no I'm not familiar with that one [23:23:24] It's a Gilbert and Sullivan play [23:23:37] Frederic soon learns, however, that he was born on the 29th of February, and so, technically, he has a birthday only once each leap year. His indenture specifies that he remain apprenticed to the pirates until his "twenty-first birthday", meaning that he must serve for another 63 years. [23:23:44] ouch^ [23:23:50] hehe, exactly [23:50:20] (03PS1) 10Jgleeson: Move approvePayment() up to PaymentProvider class [wikimedia/fundraising/SmashPig] - 10https://gerrit.wikimedia.org/r/889895 (https://phabricator.wikimedia.org/T324291) [23:51:23] ooh jgleeson, are there non-card methods that need approvePayment? [23:56:46] good question ejegg [23:57:04] it looks like most of the non-complete statuses for non-cc payments are PENDING [23:57:14] so they wouldn't require the auth call [23:57:19] sorry, approve call [23:58:58] ejegg: I guess I can't see the possible statuses for cash/bank/wallet payments here https://docs.dlocal.com/docs/cash-payments but according to the payment status docs here https://docs.dlocal.com/reference/payment-status-codes we should expect it [23:59:16] so i figured moving it up just covered all bases [23:59:29] jgleeson: OK, no big deal [23:59:51] although we could confirm that with sebastian and if we never get an authorized status return for the non-cc payments we could move it back